Re: [PATCH v2] media: v4l2-ctrls: add control for test pattern

2012-09-09 Thread Sakari Ailus
Hi Hans, On Sat, Sep 08, 2012 at 01:11:04PM +0200, Hans Verkuil wrote: On Fri September 7 2012 20:20:51 Sakari Ailus wrote: Hi Prabhakar, Thanks for the patch! Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_TEST_PATTERN of type menu, which

Re: [RFCv2 API PATCH 05/28] DocBook: bus_info can no longer be empty.

2012-09-09 Thread Hans Verkuil
On Sat September 8 2012 16:19:18 Sylwester Nawrocki wrote: On 09/08/2012 01:15 PM, Hans Verkuil wrote: On Fri September 7 2012 22:00:33 Sylwester Nawrocki wrote: On 09/07/2012 03:29 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com During the 2012 Media Workshop it was

Re: [RFCv2 API PATCH 05/28] DocBook: bus_info can no longer be empty.

2012-09-09 Thread Sylwester Nawrocki
On 09/09/2012 10:45 AM, Hans Verkuil wrote: diff --git a/Documentation/DocBook/media/v4l/vidioc-querycap.xml b/Documentation/DocBook/media/v4l/vidioc-querycap.xml index f33dd74..d5b1248 100644 --- a/Documentation/DocBook/media/v4l/vidioc-querycap.xml +++

Re: [PATCH 1/3] FCI FC2580 silicon tuner driver

2012-09-09 Thread Antti Palosaari
Hello it does not make any sense. I just put those limits as those are DVB-T band lower and upper limits. Current limit values are payload from the history and does not suit very well newer designs. Anyhow, there should be some limits defined as frontend needs those to report / limit

Re: [PATCH 1/3] FCI FC2580 silicon tuner driver

2012-09-09 Thread Oliver Schinagl
According to the 'spec sheet' [1] The min frequency goes as low as 170MHz (opposed to the 172MHz in this patch). Maximum frequency 'should' be only 860MHz though. Don't know if the L Band needs to be included into this min/max thing, as that one runs from 1350 - 1750MHz :) [1]

Re: dvb-apps scan files

2012-09-09 Thread Hernán Rossetto
It seems these were not added to the dvb-apps mercurial repo. Is this the way to submit these files ? If not, please let me know and I'll follow the right procedure. Thanks again, Hernán.- On Sat, Sep 8, 2012 at 3:54 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Great! On Sat, Sep 8, 2012

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-09 Thread Francesco Lavra
Hi, I'm going to report the (few) things which are also present in Sylwester's tree. On 09/06/2012 05:08 PM, Sangwook Lee wrote: This patch adds driver for S5K4ECGX sensor with embedded ISP SoC, S5K4ECGX, which is a 5M CMOS Image sensor from Samsung The driver implements preview mode of the

[PATCH 1/6] gspca_pac7302: add support for device 1ae7:2001 Speedlink Snappy Microphone SL-6825-SBK

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/gspca/pac7302.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index 4877f7a..e906f56 100644 ---

[PATCH 2/6] gspca_pac7302: make red balance and blue balance controls work again

2012-09-09 Thread Frank Schäfer
Fix a regression from kernel 3.4 which has been introduced with the conversion of the gspca driver to the v4l2 control framework. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/gspca/pac7302.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 3/6] gspca_pac7302: add sharpness control

2012-09-09 Thread Frank Schäfer
The Windows driver uses page 0 register 0xb6 for sharpness adjustment. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git

[PATCH 4/6] gspca_pac7302: increase default value for white balance temperature

2012-09-09 Thread Frank Schäfer
The current white balance temperature default value is 4, which is much too small (possible values are 0-255). Improve the picture quality by increasing the default value to 55, which is the default value used by the Windows driver. Signed-off-by: Frank Schäfer fschaefer@googlemail.com ---

[PATCH 5/6] gspca_pac7302: avoid duplicate calls of the image quality adjustment functions on capturing start

2012-09-09 Thread Frank Schäfer
There is no need to call the image quality adjustment functions in sd_start. The gspca main driver calls v4l2_ctrl_handler_setup in gspca_init_transfer, which already applies all image control values. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c

[PATCH 6/6] gspca_pac7302: extend register documentation

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index 71fa5a4..2d5c6d83 100644 ---

[PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/jpeg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libv4lconvert/jpeg.c b/lib/libv4lconvert/jpeg.c index e088a90..aa9cace 100644 --- a/lib/libv4lconvert/jpeg.c +++

[PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-09 Thread Frank Schäfer
The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/libv4lconvert/control/libv4lcontrol.c

[PATCH 3/3] libv4lconvert: update the list of pac7302 webcams

2012-09-09 Thread Frank Schäfer
All pac7302 webcams need image rotation, so synchronize the list with the driver. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git

Re: [PATCH v2] drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c: fix error return code

2012-09-09 Thread walter harms
looks ok to me, note: i do not have the hardware Reviewed-by: walter harms wha...@bfs.de Am 08.09.2012 16:01, schrieb Peter Senna Tschudin: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A

MFC Encode on S5PV210 hangs

2012-09-09 Thread Mike Dyer
Hi All, I'm trying to use the MFC encoder to generate an H264 bitstream using the V4L2 interface. I've tried using my own application, and also the example encode application here: git://git.infradead.org/users/kmpark/public-apps Both exhibit the same behavior. Input frames are queued up until

cron job: media_tree daily build: WARNINGS

2012-09-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Sep 9 19:00:22 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc

[patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Dan Carpenter
Several of the drivers use carrier as a divisor in their s_tx_carrier() functions. We should do a sanity check here like we do for LIRC_SET_REC_CARRIER. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Ben Hutchings pointed out that my first patch was not a complete fix. diff

[PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-09 Thread oliver
From: Oliver Schinagl oli...@schinagl.nl Initial support for the Asus MyCinema U3100Mini Plus. This currently does not work however. It uses teh af9033/5 demodulater with an FCI FC2580 tuner. Signed-off-by: Oliver Schinagl oli...@schinagl.nl --- drivers/media/dvb-core/dvb-usb-ids.h | 1 +

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-09 Thread Oliver Schinagl
Hi All/Antti, I used Antti's previous patch to try to get some support in for the Asus MyCinema U3100Mini Plus as it uses a supported driver (af9035) and now supported tuner (FCI FC2580). It compiles fine and almost works :( Here's what I get, which I have no idea what causes it. dmesg

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread walter harms
Hi all, I am not sure if that is a good idea. it should be in the hands of the driver who to use these 'val' some driver may need a higher value like this one: static int iguanair_set_tx_carrier(struct rc_dev *dev, uint32_t carrier) { struct iguanair *ir = dev-priv; if (carrier

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-09 Thread Guennadi Liakhovetski
Hi Prashanth On Fri, 7 Sep 2012, Prashanth Subramanya wrote: This driver adds basic support for Aptina ar0130 1.2M sensor. Signed-off-by: Prashanth Subramanya sprasha...@aptina.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 +

Re: pac7302-webcams and libv4lconvert interaction

2012-09-09 Thread Hans de Goede
Hi, On 09/06/2012 05:13 PM, Frank Schäfer wrote: Hi, I'm currently looking into the gspca_pac7302-driver and how it interacts with libv4lconvert. This is how it currently works - driver announces v4l2_pix_format 640x480 (width x height) - the frames (jpeg) passed to userspace are encoded as

Re: [PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch

2012-09-09 Thread Hans de Goede
Thanks, applied (and will be pushed to the official repo soon). On 09/09/2012 08:36 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/jpeg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-09 Thread Hans de Goede
Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 3/3] libv4lconvert: update the list of pac7302 webcams

2012-09-09 Thread Hans de Goede
Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: All pac7302 webcams need image rotation, so synchronize the list with the driver. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 13 - 1 files changed, 12

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-09 Thread Antti Palosaari
On 09/09/2012 11:49 PM, Oliver Schinagl wrote: Hi All/Antti, I used Antti's previous patch to try to get some support in for the Asus MyCinema U3100Mini Plus as it uses a supported driver (af9035) and now supported tuner (FCI FC2580). It compiles fine and almost works :( Here's what I get,

[GIT PULL FOR 3.7]: shark 1 2 / tea575x tea5777 AM support + misc gspca fixes

2012-09-09 Thread Hans de Goede
Hi Mauro, Please pull from my media-for_v3.7 branch for AM frequency band support for the shark 1 2 / tea575x tea5777 AM support, as well as various gspca and 2 pwc fixes. The following changes since commit 79e8c7bebb467bbc3f2514d75bba669a3f354324: Merge tag 'v3.6-rc3' into

Re: [PATCH 1/6] gspca_pac7302: add support for device 1ae7:2001 Speedlink Snappy Microphone SL-6825-SBK

2012-09-09 Thread Hans de Goede
Hi, Entire series applied and included in my pull-req for 3.7 which I just send out. Thanks, Hans On 09/09/2012 08:02 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/gspca/pac7302.c |1 + 1 files changed,

Re: [PATCH 14/14] drivers/media/usb/gspca/cpia1.c: fix error return code

2012-09-09 Thread Hans de Goede
Hi, Applied to my gspca tree and included in my pull-req for 3.7 which I just send out. Thanks, Hans On 09/06/2012 05:24 PM, Peter Senna Tschudin wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the

Re: [PATCH 02/10] pwc: Remove unneeded struct vb2_queue clearing

2012-09-09 Thread Hans de Goede
Hi, Thanks! Applied to my gspca / media / pwc tree and included in my pull-req for 3.7 which I just send out. Regards, Hans On 08/23/2012 03:08 PM, Ezequiel Garcia wrote: struct vb2_queue is allocated through kzalloc as part of a larger struct, there's no need to clear it. Cc: Hans de

Re: [media] gspca: Fix locking issues related to suspend/resume

2012-09-09 Thread Hans de Goede
Hi, Thanks for the report, it turns out that the checking for gspca_dev-dev, rather then gspca_dev-present (which is a mod I made on top of Hans Verkuil's orginal patch), turns out to be a bad idea in general as its racy, this race has been fixed by this commit:

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Ben Hutchings
On Sun, 2012-09-09 at 23:01 +0200, walter harms wrote: Hi all, I am not sure if that is a good idea. it should be in the hands of the driver who to use these 'val' some driver may need a higher value like this one: I doubt that any driver can actually work with the full range of positive

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-09 Thread Oliver Schinagl
On 09/09/12 23:51, Antti Palosaari wrote: On 09/09/2012 11:49 PM, Oliver Schinagl wrote: Hi All/Antti, I used Antti's previous patch to try to get some support in for the Asus MyCinema U3100Mini Plus as it uses a supported driver (af9035) and now supported tuner (FCI FC2580). It compiles fine

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Sean Young
On Sun, Sep 09, 2012 at 11:31:42PM +0300, Dan Carpenter wrote: Several of the drivers use carrier as a divisor in their s_tx_carrier() functions. We should do a sanity check here like we do for LIRC_SET_REC_CARRIER. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Ben

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-09 Thread Antti Palosaari
On 09/10/2012 01:26 AM, Oliver Schinagl wrote: On 09/09/12 23:51, Antti Palosaari wrote: On 09/09/2012 11:49 PM, Oliver Schinagl wrote: Hi All/Antti, I used Antti's previous patch to try to get some support in for the Asus MyCinema U3100Mini Plus as it uses a supported driver (af9035) and now

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

2012-09-09 Thread Ben Hutchings
On Sun, 2012-09-09 at 23:26 +0100, Sean Young wrote: On Sun, Sep 09, 2012 at 11:31:42PM +0300, Dan Carpenter wrote: Several of the drivers use carrier as a divisor in their s_tx_carrier() functions. We should do a sanity check here like we do for LIRC_SET_REC_CARRIER. Signed-off-by:

[PATCH v5] media: v4l2-ctrls: add control for dpcm predictor

2012-09-09 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Hans