Re: [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.

2013-02-09 Thread Hans Verkuil
On Sat February 9 2013 01:33:44 Mauro Carvalho Chehab wrote: Em Fri, 8 Feb 2013 09:40:27 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: Mauro, Please fast-track this for 3.8. Yesterday I discovered that commits made earlier for 3.8 kill ivtv and cx18 (as in: unable to boot,

[GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.

2013-02-09 Thread Hans Verkuil
Mauro, Please fast-track this for 3.8. Two days ago I discovered that commits made earlier for 3.8 kill ivtv and cx18 (as in: unable to boot, instant crash) since a function was made __init that was actually called after initialization. We are already at rc7 and this should make it for 3.8 if at

[RFCv2 PATCH 00/26] cx231xx: v4l2-compliance fixes, big-endian fixes

2013-02-09 Thread Hans Verkuil
Hi all, This patch series cleans up the cx231xx driver based on v4l2-compliance reports. I have tested this on various cx231xx devices. However, I have no hardware that supports the radio tuner, so that's untested. Also note that the MPEG encoder support does not seem to work. It didn't work

[RFCv2 PATCH 01/26] cx231xx: add device_caps support to QUERYCAP.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This fixes a v4l2_compliance failure. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[RFCv2 PATCH 03/26] cx231xx: clean up radio support.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Radio should not use video or audio inputs. In addition, fix a bug in radio_g_tuner where s_tuner was called in the tuner subdev instead of g_tuner. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c | 79

[RFCv2 PATCH 04/26] cx231xx: remove broken audio input support from the driver.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The audio selection code is broken. Audio and video indices were mixed up and s_audio would reject changing the audio input to something else anyway, so what's the point? All the audio input code has been removed. Signed-off-by: Hans Verkuil

[RFCv2 PATCH 05/26] cx231xx: fix tuner compliance issues.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The g_tuner call wasn't passed on to the subdevices, g_frequency didn't check for invalid tuners and a low-level function that was expected to return 0 or a negative error returned a positive number instead, causing s_frequency to return bogus errors.

[RFCv2 PATCH 10/26] cx231xx: add struct v4l2_fh to get prio and event support.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Required to resolve v4l2-compliance failures. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c | 31 - drivers/media/usb/cx231xx/cx231xx.h |2 ++ 2 files changed, 28

[RFCv2 PATCH 06/26] cx231xx: zero priv field and use right width in try_fmt

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The priv field of v4l2_pix_format must be zeroed. Also fix a bug in try_fmt where the current width was used instead of the width passed to try_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c |4

[RFCv2 PATCH 08/26] cx231xx: fix vbi compliance issues.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Various v4l2-compliance fixes: remove unused sliced VBI functions, zero the reserved fields of struct v4l2_vbi_format and implement the missing s_fmt_vbi_cap. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[RFCv2 PATCH 07/26] cx231xx: fix frequency clamping.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Let the tuner clamp the frequency and store that clamped value. This fixes a v4l2_compliance failure. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c | 11 ++- 1 file changed, 2 insertions(+), 9

[RFCv2 PATCH 14/26] cx231xx: improve std handling.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Set the initial standard of subdevices instead of leaving it undefined. Also update the width and height when a new standard is chosen and return -EBUSY when attempting to change the standard while videobuf is busy. Signed-off-by: Hans Verkuil

[RFCv2 PATCH 02/26] cx231xx: add required VIDIOC_DBG_G_CHIP_IDENT support.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This fixes a v4l2_compliance failure. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c

[RFCv2 PATCH 17/26] cx231xx-417: fix g/try_fmt compliance problems

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Colorspace, field and priv were not set, and sizeimage was calculated using the wrong values (dev-ts1.ts_packet_size and dev-ts1.ts_packet_count can be 0 at module load). Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[RFCv2 PATCH 11/26] cx231xx: remove current_norm usage.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The use of this field is deprecated since it will not work when multiple device nodes reference the same video input (the video and vbi nodes in this case). The norm field should be a device-global value. Signed-off-by: Hans Verkuil

[RFCv2 PATCH 23/26] cx231xx: don't reset width/height on first open.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The last set width/height must be preserved as per the spec. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c |3 --- 1 file changed, 3 deletions(-) diff --git

[RFCv2 PATCH 24/26] cx231xx: don't use port 3 on the Conexant video grabber.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com It's not working reliably if port 3 is enabled. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-cards.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c

[RFCv2 PATCH 18/26] cx231xx-417: checkpatch cleanups.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 732 +++ 1 file changed, 360 insertions(+), 372 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c

[RFCv2 PATCH 25/26] cx231xx: fix big-endian problems.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Tested on my big-endian ppc-based test machine. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-audio.c |4 ++-- drivers/media/usb/cx231xx/cx231xx-avcore.c |8

[RFCv2 PATCH 26/26] cx231xx: fix gpio big-endian problems

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Tested on my big-endian ppc-based test machine. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 73 +++- drivers/media/usb/cx231xx/cx231xx.h|2 - 2 files changed,

[RFCv2 PATCH 22/26] cx231xx: disable 417 support from the Conexant video grabber

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The 417 support doesn't work. Until someone can dig into this driver to figure out why it isn't working the 417 support is disabled. Sometimes you can actually stream a bit, but very soon the whole machine crashes, so something is seriously wrong. For

[RFCv2 PATCH 16/26] cx231xx-417: use one querycap for all device nodes.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 20 +--- drivers/media/usb/cx231xx/cx231xx-video.c |6 +++--- drivers/media/usb/cx231xx/cx231xx.h |2 ++ 3 files changed, 6

[RFCv2 PATCH 20/26] cx231xx-417: convert to the control framework.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 213 --- drivers/media/usb/cx231xx/cx231xx.h |2 +- 2 files changed, 86 insertions(+), 129 deletions(-) diff --git

[RFCv2 PATCH 13/26] cx231xx: get rid of a bunch of unused cx231xx_fh fields.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-video.c |6 +- drivers/media/usb/cx231xx/cx231xx.h | 18 +- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git

[RFCv2 PATCH 12/26] cx231xx: replace ioctl by unlocked_ioctl.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com There was already a core lock, so why wasn't ioctl already replaced by unlock_ioctl? This patch switches to unlocked_ioctl. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 15 ++-

[RFCv2 PATCH 15/26] cx231xx-417: remove empty functions.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 68 +-- 1 file changed, 1 insertion(+), 67 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c

[RFCv2 PATCH 19/26] cx231xx-417: share ioctls with cx231xx-video.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Share tuner, frequency, debug and input ioctls with cx231xx-video. These are all shared resources, so no need to implement them again. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-417.c | 113

[RFCv2 PATCH 21/26] cx231xx: remove bogus driver prefix in log messages.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The prefix is generated automatically, so no need to provide it again. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-vbi.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-)

[RFCv2 PATCH 09/26] cx231xx: convert to the control framework.

2013-02-09 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This is needed to resolve the v4l2-compliance complaints about the control ioctls. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/cx231xx/cx231xx-audio.c |4 - drivers/media/usb/cx231xx/cx231xx-cards.c |2 -

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-09 Thread Arvydas Sidorenko
On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to

Re: [PATCH v2] media: rc: gpio-ir-recv: add support for device tree parsing

2013-02-09 Thread Mauro Carvalho Chehab
Em Sat, 09 Feb 2013 01:45:42 +0100 Sebastian Hesselbarth sebastian.hesselba...@gmail.com escreveu: On 02/09/2013 01:03 AM, Mauro Carvalho Chehab wrote: Em Fri, 8 Feb 2013 21:38:07 +0100 Sebastian Hesselbarthsebastian.hesselba...@gmail.com escreveu: This patch adds device tree parsing

[PATCH] media_build: add PTR_RET to compat.h

2013-02-09 Thread Gianluca Gennari
PTR_RET is used by the solo6x10 staging driver, and was introduced in kernel 2.6.39. Add it to compat.h for compatibility with older kernels. Signed-off-by: Gianluca Gennari gennar...@gmail.com --- v4l/compat.h | 10 ++ v4l/scripts/make_config_compat.pl | 1 + 2

Re: af9035 test needed!

2013-02-09 Thread Gianluca Gennari
Il 31/01/2013 19:52, Antti Palosaari ha scritto: Jose, Gianluca, On 01/31/2013 08:40 PM, Andre Heider wrote: Hey, On Thu, Jan 31, 2013 at 2:59 PM, Antti Palosaari cr...@iki.fi wrote: On Fri, Jan 11, 2013 at 7:38 PM, Antti Palosaari cr...@iki.fi wrote: Could you test that (tda18218

Re: [PATCH] media_build: add PTR_RET to compat.h

2013-02-09 Thread Hans Verkuil
On Sat February 9 2013 15:04:40 Gianluca Gennari wrote: PTR_RET is used by the solo6x10 staging driver, and was introduced in kernel 2.6.39. Add it to compat.h for compatibility with older kernels. Applied, thanks! Regards, Hans Signed-off-by: Gianluca Gennari gennar...@gmail.com

Re: [PATCH v2] media: rc: gpio-ir-recv: add support for device tree parsing

2013-02-09 Thread Sylwester Nawrocki
On 02/09/2013 01:45 AM, Sebastian Hesselbarth wrote: new file mode 100644 index 000..8589f30 --- /dev/null +++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.txt @@ -0,0 +1,16 @@ +Device-Tree bindings for GPIO IR receiver + +Required properties: + - compatible = gpio-ir-receiver;

Re: [oselas] Audio support on Mini6410 board

2013-02-09 Thread Sylwester Nawrocki
Cc: LMML On 02/09/2013 07:21 PM, Sylwester Nawrocki wrote: Hi, On 01/20/2013 09:46 PM, Alexander Nestorov wrote: I have been playing for a week with the board. Both audio and video work correctly, but I haven't been able to set the mic settings in alsamixer (so I can't test the mic). The

Re: [oselas] Audio support on Mini6410 board

2013-02-09 Thread Tomasz Figa
Hi, On Saturday 09 of February 2013 19:21:32 Sylwester Nawrocki wrote: Hi, On 01/20/2013 09:46 PM, Alexander Nestorov wrote: I have been playing for a week with the board. Both audio and video work correctly, but I haven't been able to set the mic settings in alsamixer (so I can't test

[PATCH] media: Add 0x3009 USB PID to ttusb2 driver

2013-02-09 Thread Christoph Nuscheler
The Technisat SkyStar USB plus is a TT-connect S-2400 clone, which the V4L-DVB drivers already support. However, some of these devices (like mine) come with a different USB PID 0x3009 instead of 0x3006. There have already been patches simply overwriting the USB PID in dvb-usb-ids.h. Of course

[PATCH] media: Add 0x3009 USB PID to ttusb2 driver (fixed diff)

2013-02-09 Thread Christoph Nuscheler
Sorry about the mess in my last message; this time diff output should be formatted correctly. The Technisat SkyStar USB plus is a TT-connect S-2400 clone, which the V4L-DVB drivers already support. However, some of these devices (like mine) come with a different USB PID 0x3009 instead of

cron job: media_tree daily build: ERRORS

2013-02-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 9 19:00:26 CET 2013 git branch: for_v3.9 git hash: 4880f56438ef56457edd5548b257382761591998 gcc

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-09 Thread Sylwester Nawrocki
On 02/09/2013 01:32 AM, Stephen Warren wrote: On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote: On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff --git

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-09 Thread Sylwester Nawrocki
On 02/09/2013 11:29 PM, Sylwester Nawrocki wrote: After all, what happens in some later SoC where you have two different types of module that feed into the common module, such that type A sources have IDs 0..3 in the common module, and type B sources have IDs 4..7 in the common module - you

bt878: radio frequency stuck

2013-02-09 Thread Emile Joubert
Hi, I have the same symptoms as the ones described here: http://article.gmane.org/gmane.linux.kernel/1214773 I have the same model card (37284) which also stopped working at commit cbde689823776d187ba1b307a171625dbc02dd4f. Since that commit the radio produces white noise and changing the