Hi Jonathan,
Sorry for delay reply. Please see the below comments.
Regards,
Libin
-Original Message-
From: Jonathan Corbet [mailto:cor...@lwn.net]
Sent: Saturday, June 22, 2013 1:00 AM
To: Libin Yang
Cc: g.liakhovet...@gmx.de; mche...@redhat.com;
linux-media@vger.kernel.org;
Hi Jonathan,
Do you mean using IS_ERR() here directly? I think it should be OK. I will
change to IS_ERR() in next version.
Regards,
Libin
-Original Message-
From: Jonathan Corbet [mailto:cor...@lwn.net]
Sent: Saturday, June 22, 2013 1:02 AM
To: Libin Yang
Cc: g.liakhovet...@gmx.de;
Hi Hans,
On Mon, Jun 24, 2013 at 02:48:15PM +0200, Hans Verkuil wrote:
Hi all,
While working on extending v4l2-compliance with cropping/selection test cases
I decided to add support for that to vivi as well (this would give
applications
a good test driver to work with).
However, I ran
On Tue 25 June 2013 10:21:19 Sakari Ailus wrote:
Hi Hans,
On Mon, Jun 24, 2013 at 02:48:15PM +0200, Hans Verkuil wrote:
Hi all,
While working on extending v4l2-compliance with cropping/selection test
cases
I decided to add support for that to vivi as well (this would give
The scaling / cropping library, that has been extracted from the CEU
driver still contained a couple of references to the original hardware.
Clean them up.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
A cosmetic fix, goes on top of
https://patchwork.linuxtv.org/patch/18209/
Hi Hans,
On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Prabhakar,
On Sat June 22 2013 17:03:03 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
[snip]
+#ifndef _DT_BINDINGS_VIDEO_INTERFACES_H
+#define _DT_BINDINGS_VIDEO_INTERFACES_H
+
Hi Sylwester
On Mon, 24 Jun 2013, Sylwester Nawrocki wrote:
Hi Guennadi,
On 06/24/2013 01:20 PM, Guennadi Liakhovetski wrote:
Add documentation for the V4L2 clock and V4L2 asynchronous probing APIs
to v4l2-framework.txt.
Signed-off-by: Guennadi Liakhovetskig.liakhovet...@gmx.de
On Tue, Jun 18, 2013 at 12:46 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Note: the existing stuff does have the nice side effect of being able
to pass buffers which do not have a struct page * associated with them
through the dma_buf API - I think we can still preserve that
The patch updates few encoder buffer sizes for MFC v6.5
as per the udpdated user manual. The same buffer sizes
holds good for v7 firmware also.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v6.h |4
Firmware version v7 is mostly similar to v6 in terms
of hardware specific controls and commands. So the hardware
specific opr_v6 and cmd_v6 are re-used for v7 also. This patch
updates the v6 files to handle v7 version also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
MFC v7 supports VP8 encoding and this patch adds support
for it in the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c |3 +
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 19 -
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
This patch adds new V4L controls for VP8 encoding.
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
Documentation/DocBook/media/v4l/controls.xml | 150 ++
drivers/media/v4l2-core/v4l2-ctrls.c | 33 ++
Adds variant data and core support for the MFC v7 firmware
Signed-off-by: Arun Kumar K arun...@samsung.com
---
.../devicetree/bindings/media/s5p-mfc.txt |1 +
drivers/media/platform/s5p-mfc/s5p_mfc.c | 32
This patch series adds MFC v7 firmware support to the Exynos
MFC driver. MFC v7 is present in 5420 SoC which has support
for VP8 encoding and many other features.
Changes from v2:
- Addressed review comments from Sylwester
http://www.mail-archive.com/linux-media@vger.kernel.org/msg63676.html
The patch adds the register definition file for new firmware
version v7 for MFC. New firmware supports VP8 encoding along with
many other features.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v7.h | 58 ++
1 file changed,
From: Sylwester Nawrocki s.nawro...@samsung.com
The patch modifies the helper function v4l2_ctrl_new_std_menu
to accept integer menu controls with standard menu items.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
The MFC v6 specific code holds good for MFC v7 also as
the v7 version is a superset of v6 and the HW interface
remains more or less similar. This patch renames the macro
IS_MFCV6() to IS_MFCV6_PLUS() so that it can be used
for v7 also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
This series includes fixes for issues found while working on a libv4l
plugin for the exynos4-is driver, i.e. TRY format propagation, colorspace
handling and initial format setting on some exynos4-is subdevs.
Sylwester Nawrocki (6):
exynos4-is: Fix format propagation on FIMC-LITE.n subdevs
Ensure the image resolution and crop rectangle on the FIMC-LITE.n
subdevs and fimc-lite.n.capture video nodes is properly configured
upon the driver's initialization.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
FIMC-LITE subdevs have one sink pad and two source pads on which the image
formats are always same. This patch implements missing format propagation
from the sink pad to the source pads, to allow user space to negotiate TRY
format on whole media pipeline involving FIMC-LITE.n subdevs. The subdev
Ensure there are valid initial image formats on the FIMC.n subdev pads.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-capture.c | 19 +--
Ensure there is a valid initial resolution and pixel format set
at the FIMC-IS-ISP subdev pads.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-isp.c | 18 ++
1 file
Ensure the colorspace is properly adjusted by the driver for YUV
and Bayer image formats. The subdev try_fmt helper is simplified.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-lite.c |
Hi Arun,
@@ -684,5 +685,6 @@ void set_work_bit_irqsave(struct s5p_mfc_ctx *ctx);
(dev-variant-port_num ? 1 : 0) : 0) : 0)
#define IS_TWOPORT(dev)(dev-variant-port_num == 2 ? 1 : 0)
#define IS_MFCV6_PLUS(dev) (dev-variant-version = 0x60 ? 1
On Tue, Jun 25, 2013 at 5:09 AM, Inki Dae daei...@gmail.com wrote:
that
should be the role of kernel memory management which of course needs
synchronization btw A and B. But in no case this should be done using
dma-buf. dma-buf is for sharing content btw different devices not
sharing
Sehr geehrter Kunde,
Kürzlich zeigen unsere Aufzeichnungen, dass Ihr UBS-Konto möglich durch
einen Dritten unbefugten Zutritt.
Die Sicherheit Ihres Kontos ist unser wichtigstes Anliegen, deshalb haben
wir beschlossen,
den Zugang zu Ihrem Konto vorübergehend zu begrenzen. Für den vollen
Hi Arun,
This patch sets looks very good.
Please check my comments below.
From: Arun Kumar K [mailto:arun...@samsung.com]
This patch adds new V4L controls for VP8 encoding.
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
Hi Arun,
This patch sets looks very good.
Please check my comments below.
From: Arun Kumar K [mailto:arun...@samsung.com]
Firmware version v7 is mostly similar to v6 in terms of hardware
specific controls and commands. So the hardware specific opr_v6 and
cmd_v6 are re-used for v7 also.
This patch series adds a simple driver for the Samsung S5P/Exynos SoC
series MIPI CSI-2 receiver (MIPI DSIM) and MIPI DSI transmitter (MIPI
DSIM) DPHYs, using the generic PHY framework [1]. Previously the MIPI
CSIS and MIPI DSIM used a platform callback to control the PHY power
enable and reset
2013/6/25 Rob Clark robdcl...@gmail.com:
On Tue, Jun 25, 2013 at 5:09 AM, Inki Dae daei...@gmail.com wrote:
that
should be the role of kernel memory management which of course needs
synchronization btw A and B. But in no case this should be done using
dma-buf. dma-buf is for sharing content
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2
receiver and MIPI DSI transmitter DPHYs.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
Changes since v1:
- enabled build as module and with CONFIG_OF disabled
Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
arch/arm/boot/dts/exynos4.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git
Use the generic PHY API instead of the platform callback to control
the MIPI DSIM DPHY. The 'phy_label' field is added to the platform
data structure to allow PHY lookup on non-dt platforms.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park
Generic PHY drivers are used to handle the MIPI CSIS and MIPI DSIM
DPHYs so we can remove now unused code at arch/arm/plat-samsung.
In case there is any board file for S5PV210 platforms using MIPI
CSIS/DSIM (not any upstream currently) it should use the generic
PHY API to bind the PHYs to
Use the generic PHY API instead of the platform callback to control
the MIPI CSIS DPHY. The 'phy_label' field is added to the platform
data structure to allow PHY lookup on non-dt platforms
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park
On Tue, Jun 25, 2013 at 10:17 AM, Inki Dae daei...@gmail.com wrote:
2013/6/25 Rob Clark robdcl...@gmail.com:
On Tue, Jun 25, 2013 at 5:09 AM, Inki Dae daei...@gmail.com wrote:
that
should be the role of kernel memory management which of course needs
synchronization btw A and B. But in no case
Hi,
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+ PHY_CSIS0,
+ PHY_DSIM0,
+ PHY_CSIS1,
+ PHY_DSIM1,
+ NUM_PHYS
please prepend these with EXYNOS_PHY_ or EXYNOS_MIPI_PHY_
+struct exynos_video_phy {
+ spinlock_t slock;
+
Hi,
On Tue, Jun 25, 2013 at 04:21:48PM +0200, Sylwester Nawrocki wrote:
Use the generic PHY API instead of the platform callback to control
the MIPI DSIM DPHY. The 'phy_label' field is added to the platform
data structure to allow PHY lookup on non-dt platforms.
Signed-off-by: Sylwester
On Tue, Jun 25, 2013 at 04:21:49PM +0200, Sylwester Nawrocki wrote:
Use the generic PHY API instead of the platform callback to control
the MIPI CSIS DPHY. The 'phy_label' field is added to the platform
data structure to allow PHY lookup on non-dt platforms
Signed-off-by: Sylwester Nawrocki
On Tue, Jun 25, 2013 at 04:21:50PM +0200, Sylwester Nawrocki wrote:
Generic PHY drivers are used to handle the MIPI CSIS and MIPI DSIM
DPHYs so we can remove now unused code at arch/arm/plat-samsung.
In case there is any board file for S5PV210 platforms using MIPI
CSIS/DSIM (not any upstream
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Add support for asynchronous subdevice probing, using the v4l2-async API.
The legacy synchronous mode is still supported too, which allows to
gradually update drivers and platforms.
Signed-off-by: Prabhakar Lad prabhakar.cse...@gmail.com
Cc:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Add support for asynchronous subdevice probing, using the v4l2-async API.
The legacy synchronous mode is still supported too, which allows to
gradually update drivers and platforms.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch series adds support for vpif capture and display
driver to support asynchronously register subdevices.
Need for this support:
Currently bridge device drivers register devices for all subdevices
synchronously, typically, during their
Hi Felipe,
Thanks for the review.
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+PHY_CSIS0,
+PHY_DSIM0,
+PHY_CSIS1,
+PHY_DSIM1,
+NUM_PHYS
please prepend these with EXYNOS_PHY_ or
Hi Sylwester, Felipe,
On Tuesday 25 of June 2013 19:44:52 Sylwester Nawrocki wrote:
Hi Felipe,
Thanks for the review.
On 06/25/2013 05:06 PM, Felipe Balbi wrote:
On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote:
+enum phy_id {
+ PHY_CSIS0,
+ PHY_DSIM0,
+
Hi Mauro,
This change set includes mostly fixes to the exynos4-is and patches
to add support for some IPs of the Exynos5 SoC series at this driver.
If it looks OK and it is too late for 3.11 already, please just queue
for 3.12.
The following changes since commit
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Jun 25 19:00:19 CEST 2013
git branch: test
git hash: 188af63c0af2d7ef395bc94e3efa173f34dae03d
gcc
Hi,
On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote:
+struct exynos_video_phy {
+ spinlock_t slock;
+ struct phy *phys[NUM_PHYS];
more than one phy ? This means you should instantiate driver multiple
drivers. Each phy id should call probe again.
Why ? This
On Tue, Jun 25, 2013 at 11:47:13PM +0200, Sylwester Nawrocki wrote:
Hi,
On 06/25/2013 10:54 PM, Felipe Balbi wrote:
+static int exynos_video_phy_probe(struct platform_device *pdev)
+{
+ struct exynos_video_phy *state;
+ struct device *dev =pdev-dev;
+ struct resource
49 matches
Mail list logo
