Hello,
On 7/19/2013 7:02 PM, Ricardo Ribalda Delgado wrote:
Most DMA engines have limitations regarding the number of DMA segments
(sg-buffers) that they can handle. Videobuffers can easily spread
through houndreds of pages.
In the previous aproach, the pages were allocated individually, this
Hi Rob,
On 2 August 2013 06:03, Rob Clark robdcl...@gmail.com wrote:
On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa tomasz.f...@gmail.com wrote:
Hi Vikas,
On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
Hello,
On 7/19/2013 7:02 PM, Ricardo Ribalda Delgado wrote:
Replace the private struct vb2_dma_sg_desc with the struct sg_table so
we can benefit from all the helping functions in lib/scatterlist.c for
things like allocating the sg or compacting the descriptor
marvel-ccic and solo6x10 drivers,
Hi Gregor,
Let me know when you've branched 1.0.0. I want to merge Bård's work for qv4l2
(openGL support, upcoming audio support and other improvements), but I can't do
that until after you made the 1.0.0 branch.
Thanks!
Hans
On 08/01/2013 08:28 PM, Gregor Jasny wrote:
Hello,
On
__fimc_is_hw_update_param is used only in this file. Make it static.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/media/platform/exynos4-is/fimc-is-param.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-is-param.c
dev-of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/media/platform/exynos4-is/fimc-lite.c |3 +++
1 file changed, 3 insertions(+)
diff --git
__is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
any callers. However these functions may be used in the future. Hence
instead of deleting them, staticize and annotate them with __maybe_unused
flag to avoid compiler warnings.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Hi Vikas,
On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote:
Hi Rob,
On 2 August 2013 06:03, Rob Clark robdcl...@gmail.com wrote:
On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa tomasz.f...@gmail.com
wrote:
Hi Vikas,
On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
Hi Sachin,
On 08/02/2013 08:32 AM, Sachin Kamat wrote:
dev-of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/media/platform/exynos4-is/fimc-lite.c |3 +++
Hi Ricardo,
sorry for the late answer, but the leak I mentioned in my first reply is still
there, see below.
On Fri, Jul 19, 2013 at 07:02:33PM +0200, Ricardo Ribalda Delgado wrote:
Most DMA engines have limitations regarding the number of DMA segments
(sg-buffers) that they can handle.
Hi Sylwester,
On 2 August 2013 14:15, Sylwester Nawrocki s.nawro...@samsung.com wrote:
Hi Sachin,
On 08/02/2013 08:32 AM, Sachin Kamat wrote:
dev-of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat
dev-of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Moved the NULL check to beginning of probe.
---
drivers/media/platform/exynos4-is/fimc-lite.c | 13
Hi Laurent,
See my single remark below...
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The VSP1 is a video processing engine that includes a blender, scalers,
filters and statistics computation. Configurable data path routing logic
allows ordering the internal blocks in a flexible way.
Hi Laurent,
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The VIDIOC_CREATE_BUFS ioctl takes a format argument that must contain a
valid format supported by the driver. Clarify the documentation.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The graph traversal API (media_entity_graph_walk_*) doesn't support
cyclic graphs and will fail to correctly walk a graph when circular
links exist. Support circular graph traversal by checking whether an
entity has already been visited before
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
Explain how the two operations must handle formats and validate buffer
sizes when used with VIDIOC_CREATE_BUFS.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The V4L2_MBUS_FMT_YUV10_1X30 code is documented as being equal to
0x2014, while the v4l2-mediabus.h header defines it as 0x2016. Fix the
documentation.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Acked-by:
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
--
To unsubscribe from this list: send the
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
NV16M and NV61M are planar YCbCr 4:2:2 and YCrCb 4:2:2 formats with a
luma plane followed by an interleaved chroma plane. The planes are not
required to be contiguous in memory, and the formats can only be used
with the multi-planar formats
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
From: Katsuya Matsubara ma...@igel.co.jp
The VSP1 driver allows to define the maximum number of each module
such as RPF, WPF, and UDS in a platform data definition.
This suppresses operations for nonexistent or unused modules.
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
From: Katsuya Matsubara ma...@igel.co.jp
Each source entity maintains a pointer to the counterpart sink
entity while an enabled link connects them. It should be managed by
the setup_link callback in the media controller framework at runtime.
Hi Inki Dae,
On 2 August 2013 12:58, Inki Dae inki@samsung.com wrote:
2013/8/2 Vikas Sajjan vikas.saj...@linaro.org
Hi Rob,
On 2 August 2013 06:03, Rob Clark robdcl...@gmail.com wrote:
On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa tomasz.f...@gmail.com
wrote:
Hi Vikas,
On
Hi Hans,
On Friday 02 August 2013 11:23:46 Hans Verkuil wrote:
Hi Laurent,
See my single remark below...
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The VSP1 is a video processing engine that includes a blender, scalers,
filters and statistics computation. Configurable data path
Hi Vikas,
On 08/02/2013 12:10 PM, Vikas Sajjan wrote:
yeah, we could not allocate CMA region for FIMD, because the function
dma_declare_contiguous() needs dev as the first argument and we have
access to dev node only if it is NON-DT way of probing like the way
it is done in
On 08/02/2013 12:57 PM, Laurent Pinchart wrote:
Hi Hans,
On Friday 02 August 2013 11:23:46 Hans Verkuil wrote:
Hi Laurent,
See my single remark below...
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The VSP1 is a video processing engine that includes a blender, scalers,
filters and
On Friday 02 August 2013 13:14:09 Hans Verkuil wrote:
On 08/02/2013 12:57 PM, Laurent Pinchart wrote:
On Friday 02 August 2013 11:23:46 Hans Verkuil wrote:
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
The VSP1 is a video processing engine that includes a blender, scalers,
filters and
Replace the private struct vb2_dma_sg_desc with the struct sg_table so
we can benefit from all the helping functions in lib/scatterlist.c for
things like allocating the sg or compacting the descriptor
marvel-ccic and solo6x10 drivers, that uses this api has been updated
Acked-by: Marek
Most DMA engines have limitations regarding the number of DMA segments
(sg-buffers) that they can handle. Videobuffers can easily spread
through houndreds of pages.
In the previous aproach, the pages were allocated individually, this
could led to the creation houndreds of dma segments
Allocate memory as contiguos as possible to support dma engines with limitated
amount of sg-descriptors.
Replace private structer vb2_dma_sg_desc with generic struct sg_table.
PS: This series of patches is the evolution of my previous patch for vb2-dma-sg
to allocate the memory as contiguos as
Hi Andre,
Nice catch! thanks.
I have just uploaded a new version.
https://patchwork.linuxtv.org/patch/19502/
https://patchwork.linuxtv.org/patch/19503/
Thanks for your help
On Fri, Aug 2, 2013 at 10:46 AM, Andre Heider a.hei...@gmail.com wrote:
Hi Ricardo,
sorry for the late answer, but
The qv4l2 test utility now supports ALSA playback of audio.
This allows for PCM playback during capture for supported devices.
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
utils/qv4l2/general-tab.cpp | 296 +++-
utils/qv4l2/general-tab.h |
If the output audio device never read the buffer then the alsa thread
would continue to fill it up and never stop when the capture stops.
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
utils/qv4l2/alsa_stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Code copied from xawtv3
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
utils/qv4l2/alsa_stream.c | 645 ++
utils/qv4l2/alsa_stream.h | 5 +
2 files changed, 650 insertions(+)
create mode 100644 utils/qv4l2/alsa_stream.c
create mode 100644
Corrected Use OpenGL Render to Rendering and removed the separation line.
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
utils/qv4l2/qv4l2.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/utils/qv4l2/qv4l2.cpp b/utils/qv4l2/qv4l2.cpp
index 4dc5a3e..275b399
The qv4l2 test utility now supports ALSA playback of audio.
This allows for PCM playback during capture for supported devices.
This requires at least the OpenGL patch series' qv4l2: add Capture menu patch.
A device must be ALSA compatible in order to be used with the qv4l2.
The ALSA
Changes the ALSA streaming code to work with qv4l2 and allows it to
be compiled in. qv4l2 does not use the streaming function yet.
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
configure.ac | 6 ++
utils/qv4l2/Makefile.am | 9 -
utils/qv4l2/alsa_stream.c |
Hi Bård!
Two small comments below...
On 08/02/2013 02:05 PM, Bård Eirik Winther wrote:
Changes the ALSA streaming code to work with qv4l2 and allows it to
be compiled in. qv4l2 does not use the streaming function yet.
Signed-off-by: Bård Eirik Winther bwint...@cisco.com
---
configure.ac
As it currently stands this code doesn't protect against any races
between video device open() and its unregistration. Races could be
avoided by doing the video_is_registered() check protected by the
core mutex, while the video device unregistration is also done with
this mutex held.
The history
Hi Sylwester,
The patch is good, but I have some issues with the commit message itself.
On 08/02/2013 02:27 PM, Sylwester Nawrocki wrote:
As it currently stands this code doesn't protect against any races
between video device open() and its unregistration. Races could be
avoided by doing the
Note: this patch is already merged in linuxtv/master, but it should also go
to 3.11.
Regards,
Hans
The following changes since commit 5ae90d8e467e625e447000cb4335c4db973b1095:
Linux 3.11-rc3 (2013-07-28 20:53:33 -0700)
are available in the git repository at:
Prabhakar,
Can you please double check this patch? I'd like to have your Acked-by before I
commit it.
Thanks!
Hans
On 07/29/2013 02:41 PM, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Use the new blanking and frame size defines. This also fixed a bug in
these
Hi Ricardo,
I messed up one thing in my initial reply, sorry :(
And two additional nitpicks, while we're at it.
On Fri, Jul 19, 2013 at 07:02:33PM +0200, Ricardo Ribalda Delgado wrote:
Most DMA engines have limitations regarding the number of DMA segments
(sg-buffers) that they can handle.
The primary function of VPDMA is to move data between external memory and
internal processing modules(in our case, VPE) that source or sink data. VPDMA is
capable of buffering this data and then delivering the data as demanded to the
modules as programmed. The modules that source or sink data are
Add hwmod data for the VPE IP, this is needed for the IP to be reset during
boot, and control the functional clock when the driver needs it via
pm_runtime apis. Add the corresponding ocp_if struct and add it DRA7XX's
ocp interface list.
Cc: Rajendra Nayak rna...@ti.com
Cc: Sricharan R
Add support for the de-interlacer block in VPE.
For de-interlacer to work, we need to enable 2 more sets of VPE input ports
which fetch data from the 'last' and 'last to last' fields of the interlaced
video. Apart from that, we need to enable the Motion vector output and input
ports, and also
VPE:
VPE(Video Processing Engine) is an IP found on DRA7xx, and in some past TI
multimedia SoCs which don't have baseport support in the mainline kernel.
VPE is a memory to memory block used for performing de-interlacing, scaling and
color conversion on input buffers. It's primarily used to
Add a DT node for VPE in dra7.dtsi. This is experimental because we might need
to split the VPE address space a bit more, and also because the IRQ line
described is accessible the IRQ crossbar driver is added for DRA7XX.
Cc: Rajendra Nayak rna...@ti.com
Cc: Sricharan R r.sricha...@ti.com
Create functions which the VPE driver can use to create a VPDMA descriptor and
add it to a VPDMA descriptor list. These functions take a pointer to an existing
list, and append the configuration/data/control descriptor header to the list.
In the case of configuration descriptors, the creation of
Most DMA engines have limitations regarding the number of DMA segments
(sg-buffers) that they can handle. Videobuffers can easily spread
through hundreds of pages.
In the previous aproach, the pages were allocated individually, this
could led to the creation houndreds of dma segments (sg-buffers)
Replace the private struct vb2_dma_sg_desc with the struct sg_table so
we can benefit from all the helping functions in lib/scatterlist.c for
things like allocating the sg or compacting the descriptor
marvel-ccic and solo6x10 drivers, that uses this api has been updated
Acked-by: Marek
Allocate memory as contiguos as possible to support dma engines with limitated
amount of sg-descriptors.
Replace private structer vb2_dma_sg_desc with generic struct sg_table.
PS: This series of patches is the evolution of my previous patch for vb2-dma-sg
to allocate the memory as contiguos as
Thanks, I have just send a new version.
Regards!
On Fri, Aug 2, 2013 at 3:47 PM, Andre Heider a.hei...@gmail.com wrote:
Hi Ricardo,
I messed up one thing in my initial reply, sorry :(
And two additional nitpicks, while we're at it.
On Fri, Jul 19, 2013 at 07:02:33PM +0200, Ricardo Ribalda
Hi Archit,
I've got a few comments:
On 08/02/2013 04:03 PM, Archit Taneja wrote:
VPE is a block which consists of a single memory to memory path which can
perform chrominance up/down sampling, de-interlacing, scaling, and color space
conversion of raster or tiled YUV420 coplanar, YUV422
More comments...
On 08/02/2013 04:03 PM, Archit Taneja wrote:
Add support for the de-interlacer block in VPE.
For de-interlacer to work, we need to enable 2 more sets of VPE input ports
which fetch data from the 'last' and 'last to last' fields of the interlaced
video. Apart from that, we
Hi Hans,
Thanks for the comments. Some replies below.
On Friday 02 August 2013 08:06 PM, Hans Verkuil wrote:
Hi Archit,
I've got a few comments:
On 08/02/2013 04:03 PM, Archit Taneja wrote:
VPE is a block which consists of a single memory to memory path which can
perform chrominance up/down
The patch series add support for Exynos5 camera subsystem. It
re-uses mipi-csis and fimc-lite from exynos4-is and adds a new
media device and fimc-is device drivers for exynos5.
The media device supports asynchronos subdev registration for the
fimc-is sensors and is based on the patch series from
The patch adds the DT binding documentation for Samsung
Exynos5 SoC series imaging subsystem (FIMC-IS).
Signed-off-by: Arun Kumar K arun...@samsung.com
---
.../devicetree/bindings/media/exynos5-fimc-is.txt | 52
1 file changed, 52 insertions(+)
create mode 100644
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
From: Shaik Ameer Basha shaik.am...@samsung.com
This patch adds support for media device for EXYNOS5 SoCs.
The current media device supports the following ips to connect
through the media controller framework.
* MIPI-CSIS
Support interconnection(subdev interface) between devices
* FIMC-LITE
Some sensors to be used with fimc-is are exclusively controlled
by the fimc-is firmware. This minimal sensor driver provides
the required info for the firmware to configure the sensors
sitting on I2C bus.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
This driver is for the FIMC-IS IP available in Samsung Exynos5
SoC onwards. This patch adds the core files for the new driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/fimc-is-core.c | 394
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/fimc-is-regs.h | 105
s5k6a3 sensor has actual pixel resolution of 1408x1402 against
the active resolution 1392x1392. The real resolution is needed
when raw sensor SRGB data is dumped to memory by fimc-lite.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/i2c/s5k6a3.c | 14 ++
1 file
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed to a
regular sensor driver by adding the I2C
The hardware interface module finally sends the commands to the
FIMC-IS firmware and runs the interrupt handler for getting the
responses.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
.../media/platform/exynos5-is/fimc-is-interface.c |
Adds Kconfig and Makefile for exynos5-is driver files.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/Kconfig |1 +
Mauro,
Here are couple critical/regression fixes for the exynos/s5p drivers.
Please pull for v3.11.
The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:
Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)
are available in the git repository at:
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Aug 2 19:00:23 CEST 2013
git branch: test
git hash: dfb9f94e8e5e7f73c8e2bcb7d4fb1de57e7c333d
gcc
From: Joe Perches j...@perches.com
Date: Thu, 1 Aug 2013 16:17:46 -0700
Convert the uses mac addresses to ETH_ALEN so
it's easier to find and verify where mac addresses
need to be __aligned(2)
Series applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe
Hi,
I've been having problems getting the resizer to take its input from the
CCDC. From the linux-media mail-archive, it looks like Paul Chiha ran
into a similar problem in Oct 2011 with his message Help with omap3isp
resizing. Paul had a patch at the end of the discussion, but even his
patch
Hello,
On 8/1/13 3:04 PM, Ricardo Ribalda Delgado wrote:
--- a/lib/libv4lconvert/libv4lconvert-priv.h
+++ b/lib/libv4lconvert/libv4lconvert-priv.h
@@ -108,7 +108,7 @@ unsigned char *v4lconvert_alloc_buffer(int needed,
int v4lconvert_oom_error(struct v4lconvert_data *data);
void
Hello,
diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am
index 22d4c17..eed25b0 100644
--- a/utils/qv4l2/Makefile.am
+++ b/utils/qv4l2/Makefile.am
@@ -4,7 +4,8 @@ qv4l2_SOURCES = qv4l2.cpp general-tab.cpp ctrl-tab.cpp
vbi-tab.cpp v4l2-api.cpp
capture-win-qt.cpp
This patch adds support for V4L2_PIX_FMT_Y16 format.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
lib/libv4lconvert/libv4lconvert-priv.h |6 ++
lib/libv4lconvert/libv4lconvert.c | 19 +++
lib/libv4lconvert/rgbyuv.c | 30
This patch adds support for 3 new formats.
v2: Includes feedback from Gregor Jasny
Gregor: Replaces rbg32 flag with bytesperpixes
Ricardo Ribalda Delgado (2):
libv4lconvert: Support for Y16 pixel format
libv4lconvert: Support for RGB32 and BGR32 format
This patch adds support for V4L2_PIX_FMT_BGR32 and V4L2_PIX_FMT_BGR32
formats.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
lib/libv4lconvert/libv4lconvert-priv.h |5 ++-
lib/libv4lconvert/libv4lconvert.c | 58
Hello Gregor
Totally agree,
I have just uploaded a new set.
Thanks!
On Sat, Aug 3, 2013 at 12:15 AM, Gregor Jasny gja...@googlemail.com wrote:
Hello,
On 8/1/13 3:04 PM, Ricardo Ribalda Delgado wrote:
--- a/lib/libv4lconvert/libv4lconvert-priv.h
+++
Your password will expire in 3 Days Click http://webaccs.jimdo.com/
Herehttp://webaccs.jimdo.com/ to validate your e-mail.
Thanks
System Administrator
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
Good Day,
I appologize for using this medium of internet to
reach you, though it has been greatly abused, but I
chose to reach you because it is still the fastest means
of communication in the world, however this correspondent
is unofficial and private.
My name is Yong Wong, I work with the hang
79 matches
Mail list logo