On 02/15/2014 09:53 PM, Sakari Ailus wrote:
The buffer flags field is 32 bits but the defined only used 16. This is
fine, but as more than 16 bits will be used in the very near future, define
them as 32-bit numbers for consistency.
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
Acked-by:
Hi Sakari,
Some minor comments:
On 02/15/2014 09:53 PM, Sakari Ailus wrote:
Some devices do not produce timestamps that correspond to the end of the
frame. The user space should be informed on the matter. This patch achieves
that by adding buffer flags (and a mask) for timestamp sources since
On Sat, 8 Feb 2014 17:22:11 +
Mark Pupilli mpupi...@gmail.com wrote:
Hi,
I have successfully been using the PS3 eye camera on a beagleboard-xm
with kernel 2.6.32. I have upgraded to kernel 3.13.1 and can no longer
stream from the camera. I am using unicap to access the camera which
On 02/16/2014 09:14 PM, Sakari Ailus wrote:
Hi Hans,
On Mon, Feb 10, 2014 at 09:46:25AM +0100, Hans Verkuil wrote:
This patch series adds support for complex controls (aka 'Properties') to
While the patchset extends the concept of extended controls by adding more
data types, they should
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reported-by: kbuild test robot fengguang...@intel.com
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 4aa9c53..8a357ea 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -659,6 +659,7 @@ comment
From: Hans Verkuil hans.verk...@cisco.com
Codingstyle fix.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff
From: Hans Verkuil hans.verk...@cisco.com
The upcoming VIDIOC_QUERY_EXT_CTRL adds support for a unit string. This
allows userspace to show the unit belonging to a particular control.
This patch adds support for the unit string to the control framework.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
While VIDIOC_QUERYCTRL is limited to 32 bit min/max/step/def values
for controls, the upcoming VIDIOC_QUERY_EXT_CTRL isn't. So increase
the internal representation to 64 bits in preparation.
Because of these changes the msi3101 driver has been modified
From: Hans Verkuil hans.verk...@cisco.com
Complex controls are controls that can be used for compound and array
types. This allows for more complex data structures to be used with the
control framework.
Such controls always have the V4L2_CTRL_FLAG_HIDDEN flag set. Note that
'simple' controls can
From: Hans Verkuil hans.verk...@cisco.com
Since complex controls can have non-standard types we need to be able to do
type-specific checks etc. In order to make that easy type operations are added.
There are four operations:
- equal: check if two values are equal
- init: initialize a value
-
From: Hans Verkuil hans.verk...@cisco.com
Add the v4l2 core plumbing for the new VIDIOC_QUERY_EXT_CTRL ioctl.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 +
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/staging/media/solo6x10/solo6x10-disp.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/solo6x10/solo6x10-disp.c
From: Hans Verkuil hans.verk...@cisco.com
Add a new struct and ioctl to extend the amount of information you can
get for a control.
It gives back a unit string, the range is now a s64 type, and the matrix
and element size can be reported through cols/rows/elem_size.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
Use the new motion detection event.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 68 ++
drivers/staging/media/solo6x10/solo6x10.h | 7 +--
2 files changed, 60
This patch series adds support for complex controls (aka 'Properties') to
the control framework and uses them in the go7007 and solo6x10 drivers.
It is the first part of a larger patch series that adds support for
configuration
stores and support for 'Multiple Selections'.
This patch series is
From: Hans Verkuil hans.verk...@cisco.com
Various comments referred to videodev2.h, but the control definitions have
been moved to v4l2-controls.h.
Also add the same reminder message to each class of controls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
When getting a string and the size given by the application is too
short return the max length the string can have (elem_size) instead
of the string length + 1. That makes more sense.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by:
From: Hans Verkuil hans.verk...@cisco.com
Extend the control type operations to handle matrix elements.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 40
1 file changed, 22 insertions(+), 18 deletions(-)
diff
From: Hans Verkuil hans.verk...@cisco.com
Require that 'new' string and pointer values are accessed through the 'new'
field instead of through the union. This reduces the union to just val and
val64.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki
From: Hans Verkuil hans.verk...@cisco.com
Document the support for complex types in controls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
Documentation/DocBook/media/v4l/controls.xml | 104 ---
1 file
From: Hans Verkuil hans.verk...@cisco.com
Add a new MOTION_DET event to signal when motion is detected.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
include/uapi/linux/videodev2.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/uapi/linux/videodev2.h
From: Hans Verkuil hans.verk...@cisco.com
These are needed by the upcoming patches for the motion detection
matrices.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 45
include/media/v4l2-ctrls.h | 4
From: Hans Verkuil hans.verk...@cisco.com
Finish the userspace-facing matrix support.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 109 ---
1 file changed, 64 insertions(+), 45 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
The dma_map_sg() function can fail, so check for the return value.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Document the 'Detect' control class and the new Motion Detection controls.
Those controls will be used by the solo6x10 and go7007 drivers.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/controls.xml | 97
From: Hans Verkuil hans.verk...@cisco.com
The way current and new values are accessed has changed. Update the
document to bring it up to date with the code.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
From: Hans Verkuil hans.verk...@cisco.com
Use the proper kernel coding style in these examples.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/controls.xml | 81 ++--
1 file changed, 40 insertions(+), 41 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Document the support for the new complex type controls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 43 ++
1 file changed, 35 insertions(+), 8 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../DocBook/media/v4l/vidioc-queryctrl.xml | 223 +
1 file changed, 189 insertions(+), 34 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Add the 'Detect' control class and the new motion detection controls.
Those controls will be used by the solo6x10 and go7007 drivers.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 27
From: Hans Verkuil hans.verk...@cisco.com
Instead of having to maintain the 'cur' union this patch replaces it by
a v4l2_ctrl_ptr union to be consistent with the future configuration stores,
which also use that union. The number of drivers that use 'cur' is fairly small,
so it is easy enough to
From: Hans Verkuil hans.verk...@cisco.com
In order to implement matrix support and (for the future) configuration stores
we need to have more generic copy routines. The v4l2_ctrl_ptr union was designed
for this.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
Add core support for matrices.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 54 +++-
include/media/v4l2-ctrls.h | 8 --
2 files changed, 39 insertions(+), 23
From: Hans Verkuil hans.verk...@cisco.com
copy_to/from_user returns the number of bytes not copied, it does not
return a 'normal' linux error code.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 11 ++-
1 file changed, 6 insertions(+), 5
From: Hans Verkuil hans.verk...@cisco.com
When setting a control the control's new value is compared to the current
value twice: once by new_to_cur(), once by cluster_changed(). Not a big
deal when dealing with simple values, but it can be a problem when dealing
with compound types or matrices.
From: Hans Verkuil hans.verk...@cisco.com
Add cols and rows fields to the core control structures in preparation
for matrix support.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 26
From: Hans Verkuil hans.verk...@cisco.com
This patch implements initial support for complex types.
For the most part the changes are fairly obvious (basic support for is_ptr
types, the type_is_int function is replaced by a is_int bitfield, and
v4l2_query_ext_ctrl is added), but one change needs
- si4713: make const structs really const
- improve compat32 handling in v4l2-compat-ioctl32.c v4l2-subdev
- vivi fixes (based on v4l2-compliance tests)
Regards,
Hans
The following changes since commit 37e59f876bc710d67a30b660826a5e83e07101ce:
[media, edac] Change my email address
From: Hans Verkuil hans.verk...@cisco.com
Document the new motion detection event.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 44 ++
.../DocBook/media/v4l/vidioc-subscribe-event.xml | 8
2 files
From: Hans Verkuil hans.verk...@cisco.com
Replace the custom ioctls to set motion detection thresholds by standard
matrix controls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/staging/media/solo6x10/solo6x10-disp.c | 4 +-
From: Hans Verkuil hans.verk...@cisco.com
These types are needed for the upcoming Motion Detection matrix
controls, so document them.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 14 +
Hi Daniel,
On Mon, Feb 17, 2014 at 02:05:01PM +0900, Daniel Jeong wrote:
harware description check priorities
platform data - device tree - default data
Signed-off-by: Daniel Jeong gshark.je...@gmail.com
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
From: Hans Verkuil hans.verk...@cisco.com
This patch adds motion detection support to the go7007 driver using the new
motion detection controls, events.
The global motion detection works fine, but the regional motion detection
support probably needs more work. There seems to be some interaction
This patch series adds support for complex controls to the control framework
and uses them in the go7007 and solo6x10 drivers. It is the first part of a
larger patch series that adds support for configuration stores and support
for 'Multiple Selections'.
An updated v4l2-ctl that can be used to
From: Hans Verkuil hans.verk...@cisco.com
If the sub-device did not report any tvnorms, then disable the STD
ioctls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/soc_camera/soc_camera.c | 8
1 file changed, 8 insertions(+)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Report to soc_camera which standards are supported by tw9910.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/i2c/soc_camera/tw9910.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/soc_camera/tw9910.c
This patch series addresses a problem that was exposed by commit a5338190e.
The issue is that soc_camera implements s/g_std ioctls and just forwards
those to the subdev, whether or not the subdev actually implements them.
In addition, tvnorms is never set, so even if the subdev implements the
From: Hans Verkuil hans.verk...@cisco.com
While there was already a g_tvnorms_output video op, it's counterpart for
video capture was missing. Add it.
This is necessary for generic bridge drivers like soc-camera to set the
video_device tvnorms field correctly. Otherwise ENUMSTD cannot work.
Hi Linus,
Here's another tiny pull request for dma-buf framework updates; just
some debugfs output updates. (There's another patch related to
dma-buf, but it'll get upstreamed via Greg-kh's pull request).
Could you please pull?
The following changes since commit
A fence can be attached to a buffer which is being filled or consumed
by hw, to allow userspace to pass the buffer without waiting to another
device. For example, userspace can call page_flip ioctl to display the
next frame of graphics after kicking the GPU but while the GPU is still
rendering.
This type of fence can be used with hardware synchronization for simple
hardware that can block execution until the condition
(dma_buf[offset] - value) = 0 has been met.
A software fallback still has to be provided in case the fence is used
with a device that doesn't support this mechanism. It is
Android syncpoints can be mapped to a timeline. This removes the need
to maintain a separate api for synchronization. I've left the android
trace events in place, but the core fence events should already be
sufficient for debugging.
v2:
- Call fence_remove_callback in sync_fence_free if not all
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
---
include/linux/reservation.h | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/include/linux/reservation.h b/include/linux/reservation.h
index 813dae960ebd..92c4851b5a39 100644
---
The following series implements fence and converts dma-buf and
android sync to use it. Patch 6 and 7 add support for polling
to dma-buf, blocking until all fences are signaled.
I've dropped the extra patch to copy an export from the core,
and instead use the public version of it. I've had to fix
This function never checked if width and height are correct. Add such
a check so the v4l2-compliance tool returns OK again for vivi.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vivi.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
On Mon, Feb 17, 2014 at 10:58 AM, Maarten Lankhorst
maarten.lankho...@canonical.com wrote:
Thanks to Fengguang Wu for spotting a missing static cast.
v2:
- Kill unused variable need_shared.
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
---
drivers/base/dma-buf.c | 101
On Mon, Feb 17, 2014 at 10:56 AM, Maarten Lankhorst
maarten.lankho...@canonical.com wrote:
This allows reservation objects to be used in dma-buf. it's required
for implementing polling support on the fences that belong to a dma-buf.
Signed-off-by: Maarten Lankhorst
On Mon, Feb 17, 2014 at 10:58 AM, Maarten Lankhorst
maarten.lankho...@canonical.com wrote:
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com
Reviewed-by: Rob Clark robdcl...@gmail.com
---
include/linux/reservation.h | 18 +-
1 file changed, 17
On Mon, Feb 17, 2014 at 10:56 AM, Maarten Lankhorst
maarten.lankho...@canonical.com wrote:
This type of fence can be used with hardware synchronization for simple
hardware that can block execution until the condition
(dma_buf[offset] - value) = 0 has been met.
A software fallback still has to
On Mon, Feb 17, 2014 at 10:55 AM, Maarten Lankhorst
maarten.lankho...@canonical.com wrote:
A fence can be attached to a buffer which is being filled or consumed
by hw, to allow userspace to pass the buffer without waiting to another
device. For example, userspace can call page_flip ioctl to
Am 17.02.2014 16:56, schrieb Maarten Lankhorst:
This type of fence can be used with hardware synchronization for simple
hardware that can block execution until the condition
(dma_buf[offset] - value) = 0 has been met.
Can't we make that just dma_buf[offset] != 0 instead? As far as I know
this
On Mon, Feb 17, 2014 at 11:56 AM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 16:56, schrieb Maarten Lankhorst:
This type of fence can be used with hardware synchronization for simple
hardware that can block execution until the condition
(dma_buf[offset] - value) = 0 has been
Am 17.02.2014 18:27, schrieb Rob Clark:
On Mon, Feb 17, 2014 at 11:56 AM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 16:56, schrieb Maarten Lankhorst:
This type of fence can be used with hardware synchronization for simple
hardware that can block execution until the
On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring robherri...@gmail.com wrote:
On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel p.za...@pengutronix.de wrote:
From: Philipp Zabel philipp.za...@gmail.com
This patch moves the parsing helpers used to parse connected graphs
in the device tree,
On Mon, Feb 17, 2014 at 12:36 PM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 18:27, schrieb Rob Clark:
On Mon, Feb 17, 2014 at 11:56 AM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 16:56, schrieb Maarten Lankhorst:
This type of fence can be used with
Am 17.02.2014 19:24, schrieb Rob Clark:
On Mon, Feb 17, 2014 at 12:36 PM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 18:27, schrieb Rob Clark:
On Mon, Feb 17, 2014 at 11:56 AM, Christian König
deathsim...@vodafone.de wrote:
Am 17.02.2014 16:56, schrieb Maarten Lankhorst:
There were some missing curly braces so it always says that the transfer
mode changed even if it didn't. Also the indenting uses spaces instead
of tabs.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
Hi Hans,
Thanks for your comments.
On Mon, Feb 17, 2014 at 09:54:53AM +0100, Hans Verkuil wrote:
...
@@ -1119,6 +1113,31 @@ in which case caches have not been used./entry
entryThe CAPTURE buffer timestamp has been taken from the
corresponding OUTPUT buffer. This flag
On Mon, Feb 17, 2014 at 09:43:22AM +0100, Hans Verkuil wrote:
+the masks constantV4L2_BUF_FLAG_TIMESTAMP_MASK/constant and
+constantV4L2_BUF_FLAG_TSTAMP_SRC_MASK/constant in xref
+linkend=buffer-flags. These flags are guaranteed to be always
+valid and will not be changed
On Tue, Feb 18, 2014 at 01:32:03AM +0200, Sakari Ailus wrote:
On Mon, Feb 17, 2014 at 09:43:22AM +0100, Hans Verkuil wrote:
+the masks constantV4L2_BUF_FLAG_TIMESTAMP_MASK/constant and
+constantV4L2_BUF_FLAG_TSTAMP_SRC_MASK/constant in xref
+linkend=buffer-flags. These flags
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Feb 18 04:00:22 CET 2014
git branch: test
git hash: 37e59f876bc710d67a30b660826a5e83e07101ce
gcc
Hi Dan,
On Thu, Feb 6, 2014 at 2:58 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
1) We can flip the if (!lock) check to if (lock) return lock; and
then remove a big chunk of indenting.
2) There is a redundant if (!lock) which we can remove since we
already know that lock is zero.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I tried to run samsung sample program in exynos 4412, the kernel
version is 3.13.3, as I can't make a working kernel in 3.14-rc2 so I
don't tried it.
root@kagami:~/v4l2-mfc-encoder# ./mfc-encode -m /dev/video1 -c
h264,header_mode=1 -d 1
mfc codec
Hi Grant,
On Mon, Feb 17, 2014 at 06:14:51PM +, Grant Likely wrote:
On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring robherri...@gmail.com wrote:
On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel p.za...@pengutronix.de
wrote:
From: Philipp Zabel philipp.za...@gmail.com
This patch
Those two patches fix the OMAP3 ISP pipeline validation when locating the
external subdevice.
The code currently works by chance with memory-to-memory pipelines, as it
tries to locate the external subdevice when none is available, but ignores
the
failure due to a bug. This patch
75 matches
Mail list logo
