Re: [REVIEWv3 PATCH 19/35] DocBook media: document VIDIOC_QUERY_EXT_CTRL.

2014-03-13 Thread Hans Verkuil
On 03/12/2014 03:13 PM, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:34 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

Re: [PATCH v2 14/48] media: bfin_capture: Switch to pad-level DV operations

2014-03-13 Thread Scott Jiang
2014-03-11 7:15 GMT+08:00 Laurent Pinchart laurent.pinch...@ideasonboard.com: The video-level enum_dv_timings and dv_timings_cap operations are deprecated in favor of the pad-level versions. All subdev drivers implement the pad-level versions, switch to them. Cc: Scott Jiang

Re: Query: Mutiple CAPTURE ports on a single device

2014-03-13 Thread Hans Verkuil
Hi Vinay! On 03/12/14 18:58, vka...@codeaurora.org wrote: Hi I have a v4l2 driver for a hardware which is capable of taking one input and producing two outputs. Eg: Downscaler which takes one input @ 1080p and two outputs - one @ 720p and other at VGA. My driver is currently implemented as

Re: [PATCH] uvcvideo: Work around buggy Logitech C920 firmware

2014-03-13 Thread Laurent Pinchart
Hi William, Thank you for the patch. First of all, could you please CC me in the future for uvcvideo patches ? On Wednesday 12 March 2014 18:08:31 William Manley wrote: The uvcvideo webcam driver exposes the v4l2 control Exposure (Absolute) which allows the user to control the exposure time

[PATCH 1/3] rc: img-ir: hw: Remove unnecessary semi-colon

2014-03-13 Thread James Hogan
Fix a coccicheck warning in img-ir driver: drivers/media/rc/img-ir/img-ir-hw.c:500:2-3: Unneeded semicolon Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com --- I don't object to this patch being squashed into the patch rc: img-ir: add hardware

[PATCH 0/3] rc: img-ir: Fixes a few warnings

2014-03-13 Thread James Hogan
These patches fix a few warnings in the img-ir driver, one from coccinelle and two more from W=1 (thanks Mauro). James Hogan (3): rc: img-ir: hw: Remove unnecessary semi-colon rc: img-ir: hw: Fix min/max bits setup rc: img-ir: jvc: Remove unused no-leader timings

[PATCH 3/3] rc: img-ir: jvc: Remove unused no-leader timings

2014-03-13 Thread James Hogan
The JVC timings included timings intended for the secondary decoder (which matches messages with no leader), however they were in the wrong part of the timings structure, repeating s00 and s01 rather than being in s10 and s11. Distinct repeat timings can't be properly supported yet for JVC anyway

[PATCH 2/3] rc: img-ir: hw: Fix min/max bits setup

2014-03-13 Thread James Hogan
The calculated values for the minlen and maxlen fields, which were rounded to multiples of 2 and clamped to a valid range, were left unused. Use them in the calculation of the register value rather than using the raw input minlen and maxlen. This fixes the following warning with a W=1 build:

Re: [PATCH] uvcvideo: Work around buggy Logitech C920 firmware

2014-03-13 Thread Will Manley
On Thu, 13 Mar 2014, at 10:23, Laurent Pinchart wrote: First of all, could you please CC me in the future for uvcvideo patches ? Will do. On Wednesday 12 March 2014 18:08:31 William Manley wrote: The uvcvideo webcam driver exposes the v4l2 control Exposure (Absolute) which allows the user

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Philipp Zabel
Hi, Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely: Nak. I made comments that haven't been resolved yet. I've replied with more detail tonight. The big issues are how drivers handle the optional 'ports' node and I do not agree to the double-linkage in the binding

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Russell King - ARM Linux
On Thu, Mar 13, 2014 at 12:08:16PM +0100, Philipp Zabel wrote: I'm not sure if maybe I misunderstood or missed a mail, but I haven't seen a proposal to resolve the situation without rewinds. Given that Mauro already reverted the media tree and applied conflicting changes, that's probably not

[PATCH v4 00/14] v4l: ti-vpe: Some VPE fixes and enhancements

2014-03-13 Thread Archit Taneja
This patch set mainly consists of minor fixes for the VPE driver. These fixes ensure the following: - The VPE module can be inserted and removed successively. - Make sure that smaller resolutions like qcif work correctly. - Prevent race condition between firmware loading and an open call to the

[PATCH v4 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Archit Taneja
vpe fops(vpe_open in particular) should be called only when VPDMA firmware is loaded. File operations on the video device are possible the moment it is registered. Currently, we register the video device for VPE at driver probe, after calling a vpdma helper to initialize VPDMA and load firmware.

[PATCH v4 03/14] v4l: ti-vpe: Use video_device_release_empty

2014-03-13 Thread Archit Taneja
The video_device struct is currently embedded in the driver data struct vpe_dev. A vpe_dev instance is allocated by the driver, and the memory for the vfd is a part of this struct. The v4l2 core, however, manages the removal of the vfd region, through the video_device's .release() op, which

[PATCH v4 09/14] v4l: ti-vpe: report correct capabilities in querycap

2014-03-13 Thread Archit Taneja
querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +-

[PATCH v4 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

2014-03-13 Thread Archit Taneja
The vpe driver wasn't setting the correct field parameter for dequed CAPTURE type buffers for the case where the captured output is progressive. Set the field to V4L2_FIELD_NONE for the completed destination buffers when the captured output is progressive. For OUTPUT type buffers, a queued

[PATCH v4 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

2014-03-13 Thread Archit Taneja
For OMAP and DRA7x, we generally allocate video and graphics buffers through omapdrm since the corresponding omap-gem driver provides DMM-Tiler backed contiguous buffers. omapdrm is a dma-buf exporter. These buffers are used by other drivers in the video pipeline. Add VB2_DMABUF flag to the

[PATCH v4 07/14] v4l: ti-vpe: Add selection API in VPE driver

2014-03-13 Thread Archit Taneja
Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE(or V4L2_BUF_TYPE_VIDEO_CAPTURE/MPLANE buffers). For the CAPTURE type, V4L2_SEL_TGT_COMPOSE results in VPE writing the

[PATCH v4 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

2014-03-13 Thread Archit Taneja
Zero out the reserved formats in v4l2_pix_format_mplane and v4l2_plane_pix_format members of the returned v4l2_format pointer when passed through TRY_FMT ioctl. This ensures that the user doesn't interpret the non-zero fields as some data passed by the driver, and ensures compliance.

[PATCH v4 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

2014-03-13 Thread Archit Taneja
The dequed CAPTURE_MPLANE type buffers don't contain the flags that the originally queued OUTPUT_MPLANE type buffers have. This breaks compliance. Copy the source v4l2_buffer flags to the destination v4l2_buffer flags before they are dequed. Reviewed-by: Hans Verkuil hans.verk...@cisco.com

[PATCH v4 08/14] v4l: ti-vpe: Rename csc memory resource name

2014-03-13 Thread Archit Taneja
Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic, and both VPE and VIP DT nodes in the future can use it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/csc.c | 2 +- 1 file changed,

[PATCH v4 05/14] v4l: ti-vpe: Allow usage of smaller images

2014-03-13 Thread Archit Taneja
The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires the image width to be at least 16 bytes. Change the minimum supported dimensions to 32x32. This allows us to de-interlace qcif content. A smaller image size

[PATCH v4 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

2014-03-13 Thread Archit Taneja
Some parameters of the VPE descriptors were understood incorrectly. They are now fixed. The fixes are explained as follows: - When adding an inbound data descriptor to the VPDMA descriptor list, we intend to use c_rect as the cropped region fetched by VPDMA. Therefore, c_rect-width shouldn't

[PATCH v4 11/14] v4l: ti-vpe: Fix initial configuration queue data

2014-03-13 Thread Archit Taneja
The vpe output and capture queues are initially configured to default values in vpe_open(). A G_FMT before any S_FMTs will result in these values being populated. The colorspace and bytesperline parameter of this initial configuration are incorrect. This breaks compliance when as we get

[PATCH v4 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

2014-03-13 Thread Archit Taneja
The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com ---

RE: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Kamil Debski
Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 11, 2014 9:34 AM vpe fops(vpe_open in particular) should be called only when VPDMA firmware is loaded. File operations on the video device are possible the moment it is registered. Currently, we register the

Re: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Archit Taneja
Hi Kamil, On Thursday 13 March 2014 05:18 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 11, 2014 9:34 AM vpe fops(vpe_open in particular) should be called only when VPDMA firmware is loaded. File operations on the video device are possible

Re: [REVIEWv3 PATCH 20/35] DocBook media: update VIDIOC_G/S/TRY_EXT_CTRLS.

2014-03-13 Thread Hans Verkuil
On 03/12/14 15:20, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:35 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Document the support for the new complex type controls. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCH v2] uvcvideo: Work around buggy Logitech C920 firmware

2014-03-13 Thread William Manley
The uvcvideo webcam driver exposes the v4l2 control Exposure (Absolute) which allows the user to control the exposure time of the webcam, essentially controlling the brightness of the received image. By default the webcam automatically adjusts the exposure time automatically but the if you set

Re: [REVIEW PATCH 02/16] e4000: implement controls via v4l2 control framework

2014-03-13 Thread Mauro Carvalho Chehab
Em Thu, 27 Feb 2014 02:30:11 +0200 Antti Palosaari cr...@iki.fi escreveu: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl

Re: [PATCH 1/3] e4000: convert DVB tuner to I2C driver model

2014-03-13 Thread Mauro Carvalho Chehab
Em Mon, 27 Jan 2014 12:45:51 -0500 Michael Krufky mkru...@linuxtv.org escreveu: Antti submitted similar patches a few months ago - I have to review his newer series and see if anything has changed. My goal would be to commit these patches into a new branch and work on converting the entire

Re: [git:media_tree/master] [media] rtl28xxu: add USB ID for Genius TVGo DVB-T03

2014-03-13 Thread Jan Včelák
Hello, this patch seems to be committed by a mistake (commit 1c1b873). It is a first version of my patch, which was superseded. The new version is already merged (commit ac298cc). The device ID is now twice in the list. Jan On Wed, Mar 12, 2014 at 6:00 PM, Mauro Carvalho Chehab

Re: [REVIEW PATCH] v4l2-pci-skeleton: add a V4L2 PCI skeleton driver

2014-03-13 Thread Mauro Carvalho Chehab
Hi Hans, I don't like very much the idea of adding skeleton drivers inside drivers/media. We have there already enough drivers to pollute it with more skeleton ones. I think that the best is to put it on some other place. Eventually, we could put it at Documentation: $ ls Documentation/*/*.c

Re: [RFCv1 PATCH 5/5] DocBook media: clarify v4l2_pix_format and v4l2_pix_format_mplane fields

2014-03-13 Thread Mauro Carvalho Chehab
Em Fri, 7 Mar 2014 15:26:24 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Be more specific with regards to how some of these fields are interpreted. In particular height vs field and which fields can be set by the application. Signed-off-by:

RE: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Kamil Debski
Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 1:09 PM Hi Kamil, On Thursday 13 March 2014 05:18 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 11, 2014 9:34 AM vpe fops(vpe_open in particular)

RE: [PATCH v3 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

2014-03-13 Thread Kamil Debski
Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 11, 2014 9:34 AM VPE has a ctrl parameter which decides how many mem to mem transactions the active job from the job queue can perform. The driver's job_ready() made sure that the number of ready source buffers are

RE: [PATCH v4 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

2014-03-13 Thread Kamil Debski
From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 12:44 PM VPE has a ctrl parameter which decides how many mem to mem transactions the active job from the job queue can perform. The driver's job_ready() made sure that the number of ready source buffers are

RE: [PATCH v4 08/14] v4l: ti-vpe: Rename csc memory resource name

2014-03-13 Thread Kamil Debski
Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 12:44 PM Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic, and both VPE and VIP DT nodes in the future can use it. I understand

RE: [PATCH v4 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

2014-03-13 Thread Kamil Debski
Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 12:44 PM To: k.deb...@samsung.com; hverk...@xs4all.nl Cc: linux-media@vger.kernel.org; linux-o...@vger.kernel.org; Archit Taneja Subject: [PATCH v4 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

Re: [REVIEW PATCH 02/16] e4000: implement controls via v4l2 control framework

2014-03-13 Thread Antti Palosaari
On 13.03.2014 15:57, Mauro Carvalho Chehab wrote: Em Thu, 27 Feb 2014 02:30:11 +0200 Antti Palosaari cr...@iki.fi escreveu: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Sylwester Nawrocki
On 13/03/14 12:35, Russell King - ARM Linux wrote: [...] Grant and myself have exchanged emails in private on this discussing what should happen - essentially Grant's position is that he's happy to leave this stuff queued provided a resolution to his concerns are forthcoming. However, what I

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Sylwester Nawrocki
On 13/03/14 16:13, Sylwester Nawrocki wrote: On 13/03/14 12:35, Russell King - ARM Linux wrote: [...] Grant and myself have exchanged emails in private on this discussing what should happen - essentially Grant's position is that he's happy to leave this stuff queued provided a resolution

Re: [REVIEW PATCH 02/16] e4000: implement controls via v4l2 control framework

2014-03-13 Thread Antti Palosaari
On 13.03.2014 17:17, Antti Palosaari wrote: On 13.03.2014 15:57, Mauro Carvalho Chehab wrote: Em Thu, 27 Feb 2014 02:30:11 +0200 Antti Palosaari cr...@iki.fi escreveu: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported

Re: [REVIEW PATCH 02/16] e4000: implement controls via v4l2 control framework

2014-03-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Mar 2014 17:17:50 +0200 Antti Palosaari cr...@iki.fi escreveu: On 13.03.2014 15:57, Mauro Carvalho Chehab wrote: Em Thu, 27 Feb 2014 02:30:11 +0200 Antti Palosaari cr...@iki.fi escreveu: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control

Re: [PATCH] uvcvideo: Work around buggy Logitech C920 firmware

2014-03-13 Thread Laurent Pinchart
Hi Will, On Thursday 13 March 2014 10:48:20 Will Manley wrote: On Thu, 13 Mar 2014, at 10:23, Laurent Pinchart wrote: First of all, could you please CC me in the future for uvcvideo patches ? Will do. Thank you. On Wednesday 12 March 2014 18:08:31 William Manley wrote: The uvcvideo

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-13 Thread Laurent Pinchart
Hi Philipp, On Thursday 13 March 2014 12:08:16 Philipp Zabel wrote: Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely: Nak. I made comments that haven't been resolved yet. I've replied with more detail tonight. The big issues are how drivers handle the optional 'ports' node

[PATCH v11][ 01/12] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2014-03-13 Thread Denis Carikli
That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Signed-off-by: Denis Carikli de...@eukrea.com Acked-by: Mauro Carvalho Chehab m.che...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Philipp

[PATCH v11][ 02/12] imx-drm: Add RGB666 support for parallel display.

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli de...@eukrea.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- ChangeLog v8-v9: - Rebased. - Added Philipp Zabel's ack. - Shortened the patch title. ChangeLog v8-v9: - Removed the Cc. They are now set in git-send-email directly. - Rebased. ChangeLog v7-v8: -

[PATCH v11][ 03/12] imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-13 Thread Denis Carikli
The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli de...@eukrea.com Acked-by: Philipp Zabel p.za...@pengutronix.de --- ChangeLog v9-v10: - Rebased. - Added Philipp Zabel's Ack. - Included

[PATCH v11][ 05/12] imx-drm: use defines for clock polarity settings

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v9-v10: - New patch which was splitted out from: staging: imx-drm: Use de-active and pixelclk-active display-timings.. - Fixes many issues in staging: imx-drm: Use de-active and pixelclk-active display-timings.: - More clear meaning

[PATCH v11][ 04/12] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

2014-03-13 Thread Denis Carikli
According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v9-v10: - New patch that is now needed by the staging: imx-drm: Use de-active and

[PATCH 12/12] ARM: imx_v6_v7_defconfig: Add more drm drivers.

2014-03-13 Thread Denis Carikli
The DRM_PANEL_SIMPLE is needed by the eukrea mbimxsd51's displays. Signed-off-by: Denis Carikli de...@eukrea.com --- - New patch, splitting it would be overkill. --- arch/arm/configs/imx_v6_v7_defconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig

[PATCH 11/12] ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.

2014-03-13 Thread Denis Carikli
Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v9-v11: - Now uses the drm-panel instead of the display-timings. ChangeLog v8-v9: - Removed the Cc. They are now set in git-send-email directly. - The backlight is now on at boot. ChangeLog v6-v7: - Shrinked even more the Cc list.

Re: Query: Mutiple CAPTURE ports on a single device

2014-03-13 Thread vkalia
Thanks Hans for the pointers! Unfortunately, my driver is implemented M2M way. Thanks Vinay Hi Vinay! On 03/12/14 18:58, vka...@codeaurora.org wrote: Hi I have a v4l2 driver for a hardware which is capable of taking one input and producing two outputs. Eg: Downscaler which takes one input

Query: Reqbufs returning without calling queue_setup.

2014-03-13 Thread vkalia
Hi There is a check in __reqbufs in videobuf2-core.c in which if the count is same then the function returns immediately. __reqbufs also calls queue_setup callback into driver which updates the plane counts and sizes of vb2 queue. The count and size can be affected/changed by S_FMT and G_FMT

[PATCH] e4000/rtl2832u_sdr: use V4L2 subdev to pass V4L2 control handler

2014-03-13 Thread Antti Palosaari
Now it is a little bit similar than used on V4L2 API... Looks better? Antti Palosaari (1): e4000/rtl2832u_sdr: use V4L2 subdev to pass V4L2 control handler drivers/media/tuners/Kconfig | 2 +- drivers/media/tuners/e4000.c | 21 -

[PATCH] e4000/rtl2832u_sdr: use V4L2 subdev to pass V4L2 control handler

2014-03-13 Thread Antti Palosaari
Exporting resources using EXPORT_SYMBOL from plain I2C driver is bad idea. Use V4L2 subdev instead. Functionality is now quite likely as is done in V4L2 API. Reported-by: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi ---

Re: Query: Reqbufs returning without calling queue_setup.

2014-03-13 Thread Hans Verkuil
On 03/13/2014 09:13 PM, vka...@codeaurora.org wrote: Hi There is a check in __reqbufs in videobuf2-core.c in which if the count is same then the function returns immediately. __reqbufs also calls queue_setup callback into driver which updates the plane counts and sizes of vb2 queue. The

Re: [PATCH] e4000/rtl2832u_sdr: use V4L2 subdev to pass V4L2 control handler

2014-03-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Mar 2014 22:44:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Exporting resources using EXPORT_SYMBOL from plain I2C driver is bad idea. Use V4L2 subdev instead. Functionality is now quite likely as is done in V4L2 API. Much better! Thanks! Mauro Reported-by: Mauro Carvalho

Re: [PATCH v3 36/48] adv7604: Make output format configurable through pad format operations

2014-03-13 Thread Hans Verkuil
On 03/11/2014 04:10 PM, Laurent Pinchart wrote: Replace the dummy video format operations by pad format operations that configure the output format. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com My apologies, I completely forgot to test this today. It's going to be

Re: [PATCH] e4000/rtl2832u_sdr: use V4L2 subdev to pass V4L2 control handler

2014-03-13 Thread Antti Palosaari
On 13.03.2014 23:24, Mauro Carvalho Chehab wrote: Em Thu, 13 Mar 2014 22:44:14 +0200 Antti Palosaari cr...@iki.fi escreveu: Exporting resources using EXPORT_SYMBOL from plain I2C driver is bad idea. Use V4L2 subdev instead. Functionality is now quite likely as is done in V4L2 API. Much

Re: [PATCH] uvcvideo: Work around buggy Logitech C920 firmware

2014-03-13 Thread William Manley
On 13/03/14 17:03, Laurent Pinchart wrote: On Thursday 13 March 2014 10:48:20 Will Manley wrote: On Thu, 13 Mar 2014, at 10:23, Laurent Pinchart wrote: On Wednesday 12 March 2014 18:08:31 William Manley wrote: The uvcvideo webcam driver exposes the v4l2 control Exposure (Absolute) which

[PATCH 00/17] SDR API - rtl2832_sdr driver

2014-03-13 Thread Antti Palosaari
I decided to drop r820t changes (gain controls and bandwidth) as for now. Some small changes also done and rebased. Removed e4000 export and it uses now e4000 attach model that is quite copy pasted from V4L2. Antti Antti Palosaari (16): e4000: convert DVB tuner to I2C driver model e4000:

[PATCH 07/17] rtl28xxu: constify demod config structs

2014-03-13 Thread Antti Palosaari
Optimize a little bit from data to text. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c

[PATCH 10/17] rtl28xxu: use muxed RTL2832 I2C adapters for E4000 and RTL2832_SDR

2014-03-13 Thread Antti Palosaari
RTL2832 driver provides muxed I2C adapters for tuner bus I2C gate control. Pass those adapters to rtl2832_sdr and e4000 modules in order to get rid of proprietary DVB .i2c_gate_ctrl() callback use. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 10

[PATCH 05/17] rtl2832_sdr: Realtek RTL2832 SDR driver module

2014-03-13 Thread Antti Palosaari
Implement SDR driver for Realtek RTL2832U chip as a DVB extension module. SDR module is attached by DVB USB RTL28XXU driver as a DVB SEC (satellite equipment controller) module. Abusing unused SEC here has no harm as that is DVB-T only frontend. SDR functionality is provided by RTL2832 DVB-T

[PATCH 08/17] rtl28xxu: attach SDR extension module

2014-03-13 Thread Antti Palosaari
With that extension module it supports SDR. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/Makefile | 1 + drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 20 2 files changed, 21 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/Makefile

[PATCH 01/17] e4000: convert DVB tuner to I2C driver model

2014-03-13 Thread Antti Palosaari
Driver conversion from proprietary DVB tuner model to more general I2C driver model. Cc: Jean Delvare kh...@linux-fr.org Cc: Mauro Carvalho Chehab m.che...@samsung.com Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c| 115

[PATCH 15/17] rtl2832_sdr: fixing v4l2-compliance issues

2014-03-13 Thread Antti Palosaari
From: Hans Verkuil hverk...@xs4all.nl Fix rtl2832_sdr driver v4l2-compliance issues. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 29 +++- 1 file changed, 23

[PATCH 02/17] e4000: implement controls via v4l2 control framework

2014-03-13 Thread Antti Palosaari
Implement gain and bandwidth controls using v4l2 control framework. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/Kconfig | 2 +- drivers/media/tuners/e4000.c | 217

[PATCH 11/17] rtl28xxu: depends on I2C_MUX

2014-03-13 Thread Antti Palosaari
We need depend on I2C_MUX as rtl2832 demod used requires it. All error/warnings: warning: (DVB_USB_RTL28XXU) selects DVB_RTL2832 which has unmet direct dependencies (MEDIA_SUPPORT DVB_CORE I2C I2C_MUX) ERROR: i2c_add_mux_adapter [drivers/media/dvb-frontends/rtl2832.ko] undefined! ERROR:

[PATCH 03/17] e4000: fix PLL calc to allow higher frequencies

2014-03-13 Thread Antti Palosaari
There was 32-bit overflow on VCO frequency calculation which blocks tuning to 1073 - 1104 MHz. Use 64 bit number in order to avoid VCO frequency overflow. After that fix device in question tunes to following range: 60 - 1104 MHz 1250 - 2207 MHz Signed-off-by: Antti Palosaari cr...@iki.fi ---

[PATCH 04/17] e4000: implement PLL lock v4l control

2014-03-13 Thread Antti Palosaari
Implement PLL lock control to get PLL lock flag status from tuner synthesizer. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c | 53 ++-

[PATCH 17/17] MAINTAINERS: add rtl2832_sdr driver

2014-03-13 Thread Antti Palosaari
Realtek RTL2832 SDR driver. Currently in staging as SDR API is not ready. Signed-off-by: Antti Palosaari cr...@iki.fi --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3718c32..94c9cff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH 09/17] rtl28xxu: fix switch-case style issue

2014-03-13 Thread Antti Palosaari
Use break, not return, for every case. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

[PATCH 14/17] e4000: rename some variables

2014-03-13 Thread Antti Palosaari
Rename some variables. Change error status checks from (ret 0) to (ret). No actual functionality changes. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c | 332 +++--- drivers/media/tuners/e4000_priv.h | 2 +- 2 files changed,

[PATCH 16/17] rtl2832_sdr: clamp bandwidth to nearest legal value in automode

2014-03-13 Thread Antti Palosaari
Clamp bandwidth to nearest legal value in automode in order to pass v4l2-compliance test. Reported-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 12 ++-- 1 file changed, 10 insertions(+), 2

[PATCH 13/17] e4000: convert to Regmap API

2014-03-13 Thread Antti Palosaari
That comes possible after driver was converted to kernel I2C model (I2C binding proper I2C client with no gate control hack). All nasty low level I2C routines are now covered by regmap. Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti

[PATCH 12/17] e4000: get rid of DVB i2c_gate_ctrl()

2014-03-13 Thread Antti Palosaari
Gate control is now implemented by rtl2832 I2C adapter so we do not need proprietary DVB i2c_gate_ctrl() anymore. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/e4000.c | 103 +-- 1 file changed, 21 insertions(+), 82 deletions(-)

[PATCH 06/17] rtl2832_sdr: expose e4000 controls to user

2014-03-13 Thread Antti Palosaari
E4000 tuner driver provides now some controls. Expose those to userland. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c

[GIT PULL] rtl2832_sdr driver

2014-03-13 Thread Antti Palosaari
The following changes since commit 8ea5488a919bbd49941584f773fd66623192ffc0: [media] media: rc-core: use %s in rc_map_get() module load (2014-03-13 11:32:28 -0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git sdr_review_v6 for you to fetch changes up

cron job: media_tree daily build: ERRORS

2014-03-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 14 04:00:17 CET 2014 git branch: test git hash: 8ea5488a919bbd49941584f773fd66623192ffc0 gcc

[PATCH] media: davinci: vpbe: fix build warning

2014-03-13 Thread Lad, Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following build warning drivers/media/platform/davinci/vpbe_display.c: In function 'vpbe_start_streaming': drivers/media/platform/davinci/vpbe_display.c:344: warning: unused variable 'vpbe_dev' Signed-off-by: Lad, Prabhakar