Hi Daniel,
Looks good for the most part, but I have two comments, see below...
On 03/16/2014 11:33 AM, Daniel Glöckner wrote:
This patch adds support for the PCI-8604PW card equipped with four 878A.
It is unknown who the manufacturer of this card is and no drivers were
available during
Hi Hans,
No issues with the patch, apart from one typo in a comment, but it may
not be worth the reupload.
On Sat, Mar 15, 2014 at 10:08 PM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
Sparse generated a bunch of errors like this:
(Fixed typo pointed out by Pawel, but more importantly made an additional
change to
__qbuf_dmabuf. See last paragraph in the commit log)
Sparse generated a bunch of errors like this:
drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in
conditional expression
Hi Hans,
Thank you for the patch.
On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The notify function is a void function, yet the v4l2_subdev_notify
define uses it in a ? : construction, which causes sparse warnings.
Signed-off-by: Hans
On 03/17/2014 12:44 PM, Laurent Pinchart wrote:
Hi Hans,
Thank you for the patch.
On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The notify function is a void function, yet the v4l2_subdev_notify
define uses it in a ? : construction,
Hi Hans,
On Monday 17 March 2014 12:45:16 Hans Verkuil wrote:
On 03/17/2014 12:44 PM, Laurent Pinchart wrote:
On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The notify function is a void function, yet the v4l2_subdev_notify
define uses
Hi Hans,
Thank you for the patch.
On Saturday 15 March 2014 14:08:03 Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Drop the use of __user in the user_ptr variable since the v4l2 structs are
actually defined without __user, instead cast to a __user pointer only
there where
Hi Hans,
On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote:
+ switch (state) {
+ case 1:
+ case 5:
+ case 6:
+ case 4:
+ pr_debug(PCI-8604PW in state %i, toggling pin\n,
+
On 03/17/2014 12:59 PM, Daniel Glöckner wrote:
Hi Hans,
On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote:
+ switch (state) {
+ case 1:
+ case 5:
+ case 6:
+ case 4:
+ pr_debug(PCI-8604PW in state %i, toggling
Hi Hans,
Thank you for the patch.
On Monday 17 March 2014 11:58:08 Hans Verkuil wrote:
(Fixed typo pointed out by Pawel, but more importantly made an additional
change to __qbuf_dmabuf. See last paragraph in the commit log)
[snip]
I made one other change: in __qbuf_dmabuf the result of the
On 03/17/2014 01:26 PM, Laurent Pinchart wrote:
Hi Hans,
Thank you for the patch.
On Monday 17 March 2014 11:58:08 Hans Verkuil wrote:
(Fixed typo pointed out by Pawel, but more importantly made an additional
change to __qbuf_dmabuf. See last paragraph in the commit log)
[snip]
I
Hi Hans,
On Monday 17 March 2014 13:32:44 Hans Verkuil wrote:
On 03/17/2014 01:26 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 11:58:08 Hans Verkuil wrote:
(Fixed typo pointed out by Pawel, but more importantly made an additional
change to __qbuf_dmabuf. See last paragraph in the
On 03/17/2014 01:41 PM, Laurent Pinchart wrote:
Hi Hans,
On Monday 17 March 2014 13:32:44 Hans Verkuil wrote:
On 03/17/2014 01:26 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 11:58:08 Hans Verkuil wrote:
(Fixed typo pointed out by Pawel, but more importantly made an additional
From: Hans Verkuil hans.verk...@cisco.com
Sparse generated a bunch of errors like this:
drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in
conditional expression (different base types)
drivers/media/v4l2-core/videobuf2-core.c:136:17: error: incompatible types in
From: Hans Verkuil hans.verk...@cisco.com
In __qbuf_dmabuf the result of the memop call attach_dmabuf() is checked by
IS_ERR() instead of IS_ERR_OR_NULL(). Since the a NULL pointer makes no sense
and in other places in videobuf2-core the IS_ERR_OR_NULL macro is always used,
I've changed the
From: Hans Verkuil hans.verk...@cisco.com
The notify function is a void function, yet the v4l2_subdev_notify
define uses it in a ? : construction, which causes sparse warnings.
Replace the define by a static inline function and move it to
v4l2-device.h, which is where it belongs since it needs
From: Hans Verkuil hans.verk...@cisco.com
The edid array is copied to kernelspace by the v4l2 core, so drivers
shouldn't see the __user annotation. This conforms to other structs like
v4l2_ext_controls where the data pointed to is copied to from user to
kernelspace.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
Fix the use of __user in the check_array_args() prototype: instead of
using 'void * __user *' you should use 'void __user **' for sparse to
understand this correctly.
This also required the use of __force in the '*kernel_ptr = user_ptr'
assignment.
Also
These five patches fix sparse errors and warnings coming from the v4l2
core. There are more, but those seem to be problems with sparse itself (see
my posts from Saturday on that topic).
Please take a good look at patch 3/5 in particular: that fixes sparse
errors introduced by my vb2 changes, and
On 03/17/2014 01:54 PM, Hans Verkuil wrote:
These five patches fix sparse errors and warnings coming from the v4l2
core. There are more, but those seem to be problems with sparse itself (see
my posts from Saturday on that topic).
Please take a good look at patch 3/5 in particular: that fixes
On 03/15/2014 11:08 AM, Hans de Goede wrote:
Hi,
Some better commit msg would be nice, otherwise this patch is:
Acked-by: Hans de Goede hdego...@redhat.com
Hans Verkuil has mailed me that he would like to pick this up through
his tree. Hans V. , I say go for it :)
I noticed that these
Hi Hans,
On Monday 17 March 2014 13:47:35 Hans Verkuil wrote:
On 03/17/2014 01:41 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 13:32:44 Hans Verkuil wrote:
On 03/17/2014 01:26 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 11:58:08 Hans Verkuil wrote:
(Fixed typo pointed out
The following changes since commit ed97a6fe5308e5982d118a25f0697b791af5ec50:
[media] af9033: Don't export functions for the hardware filter (2014-03-14
20:26:59 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v3.15f
for you to fetch changes up
Hi Hans,
On Monday 17 March 2014 14:30:51 Hans Verkuil wrote:
On 03/17/2014 02:27 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 13:47:35 Hans Verkuil wrote:
On 03/17/2014 01:41 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 13:32:44 Hans Verkuil wrote:
On 03/17/2014 01:26 PM,
On 03/17/2014 02:27 PM, Laurent Pinchart wrote:
Hi Hans,
On Monday 17 March 2014 13:47:35 Hans Verkuil wrote:
On 03/17/2014 01:41 PM, Laurent Pinchart wrote:
On Monday 17 March 2014 13:32:44 Hans Verkuil wrote:
On 03/17/2014 01:26 PM, Laurent Pinchart wrote:
On Monday 17 March 2014
Hi Denis,
Thanks for the patch.
On 03/13/2014 06:17 PM, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
Signed-off-by: Denis Carikli de...@eukrea.com
---
Hello,
On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
On 03/13/2014 06:17 PM, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
Signed-off-by:
This patch series adds videobuf2-dvb support to vb2 (this was missing
until now) and converts saa7134 to vb2.
These patches are unchanged from the review patch series posted before:
http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/75376
except for being rebased to the
Hi,
Laurent Pinchart wrote:
Hello,
On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
On 03/13/2014 06:17 PM, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to
Hi Lothar,
On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
Laurent Pinchart wrote:
On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
On 03/13/2014 06:17 PM, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display
On 16 March 2014 23:18, James Hogan ja...@albanarts.com wrote:
Fair enough. So changing the minimum rc5-sz masks to 0x3fff sounds reasonable
to allow toggle to be controlled.
Just to clarify though, so you mean that the remote uses toggle=1 first (and
in repeat codes) unless you press it a
Hi James,
On 17 March 2014 00:41, James Hogan ja...@albanarts.com wrote:
Yeh I'm in two minds about this now. It's actually a little awkward since some
of the protocols have multiple variants (i.e. rc-5 = RC5+RC5X), but an
encoded message is only ever a single variant, so technically if
Hi!
After giving up on my PCTV 340e usb stick, got myself a blackgold
bgt3620, as, supposedly, had a fully functional linux support.
Unfortunately, I'm using kernel 3.12 (and 3.13). This means that the
driver supplied by manufacturer doesn't compile as it does in kubuntu
13.10 (haven't confirmed
Hi,
On 03/17/2014 02:21 PM, Hans Verkuil wrote:
On 03/15/2014 11:08 AM, Hans de Goede wrote:
Hi,
Some better commit msg would be nice, otherwise this patch is:
Acked-by: Hans de Goede hdego...@redhat.com
Hans Verkuil has mailed me that he would like to pick this up through
his tree. Hans
Convert the driver to use get_vaddr_pfns() instead of get_user_pages()
or a hand made page table walk. This removes knowledge about vmas
and mmap_sem locking from the driver.
Signed-off-by: Jan Kara j...@suse.cz
---
drivers/staging/tidspbridge/core/tiomap3430.c | 261 -
Convert vb2_vmalloc_get_userptr() to use passed vector of pfns. When we
are doing that there's no need to allocate page array and some code can
be simplified.
Signed-off-by: Jan Kara j...@suse.cz
---
drivers/media/v4l2-core/videobuf2-vmalloc.c | 86 +++--
1 file changed,
Provide new function get_vaddr_pfns(). This function maps virtual
addresses from given start and fills given array with page frame numbers of
the corresponding pages. If given start belongs to a normal vma, the function
grabs reference to each of the pages to pin them in memory. If start
belongs
Hello,
The following patch series is my first stab at abstracting vma handling
from the various media drivers. After this patch set drivers have to know
much less details about vmas, their types, and locking. My motivation for
the series is that I want to change get_user_pages() locking and I
Conversion to the use of pinned pfns made some functions unused. Remove
them. Also there's no need to lock mmap_sem in __buf_prepare() anymore.
Signed-off-by: Jan Kara j...@suse.cz
---
drivers/media/v4l2-core/videobuf2-core.c | 8 +-
drivers/media/v4l2-core/videobuf2-memops.c | 114
Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of
hand made mapping of virtual address to physical address. Also the
function leaked page reference from get_user_pages() so fix that by
properly release the reference when omap_vout_buffer_release() is
called.
Signed-off-by:
Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_pfn().
This removes the knowledge about vmas and mmap_sem locking from exynos
driver. Also it fixes a problem that the function has been mapping user
provided address without holding mmap_sem.
Signed-off-by: Jan Kara j...@suse.cz
---
Teach vb2_queue_or_prepare_buf() to get pfns underlying these buffers
and propagate them down to get_userptr callback. Thus each buffer
mapping method doesn't have to get pfns independently. Also this will
remove the knowledge about mmap_sem locking from videobuf2 core.
Signed-off-by: Jan Kara
Signed-off-by: Jan Kara j...@suse.cz
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 85 ++
1 file changed, 15 insertions(+), 70 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c
b/drivers/media/v4l2-core/videobuf2-dma-sg.c
index
On 03/17/2014 12:49 PM, Jan Kara wrote:
+int get_vaddr_pfns(unsigned long start, int nr_pfns, int write, int force,
+struct pinned_pfns *pfns)
+{
...
+ if (!(vma-vm_flags (VM_IO | VM_PFNMAP))) {
+ pfns-got_ref = 1;
+ pfns-is_pages = 1;
+
We offer all purpose loan at 3% interest rate. Contact Us for more details by
Email:santanderfinancegr...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Monday 17 March 2014 19:01:51 Antti Seppälä wrote:
On 17 March 2014 00:41, James Hogan ja...@albanarts.com wrote:
Yeh I'm in two minds about this now. It's actually a little awkward since
some of the protocols have multiple variants (i.e. rc-5 = RC5+RC5X),
but an encoded message is only
Hi Robert,
On Friday 14 March 2014 08:05:05 Robert Schwebel wrote:
On Thu, Mar 13, 2014 at 04:13:08PM +0100, Sylwester Nawrocki wrote:
My experience and feelings are similar, I started to treat mainline
kernel much less seriously after similar DT related blocking issues.
So how do we
Hi Philipp,
On Friday 14 March 2014 13:19:39 Philipp Zabel wrote:
Am Donnerstag, den 13.03.2014, 18:13 +0100 schrieb Laurent Pinchart:
On Thursday 13 March 2014 12:08:16 Philipp Zabel wrote:
Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely:
Nak. I made comments that haven't
Hi,
The DVB-T initial tuning information for Crystal Palace in the UK is completely
obsolete - despite my two attempts to submit an updated version over the YEARS.
Where is the best place to send this information, please?
Thanks,
Chris
--
To unsubscribe from this list: send the line
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Mar 18 04:00:15 CET 2014
git branch: test
git hash: ed97a6fe5308e5982d118a25f0697b791af5ec50
gcc
50 matches
Mail list logo
