[BUG PATCH] media/rc/ir-nec-decode : phantom keypress

2014-05-31 Thread Niels Laukens
Hi, I believe I've found a bug in the NEC decoder for InfraRed remote controls. The problem manifests itself as an extra keypress that happens when pushing different buttons in rapid succession. I can reproduce the problem easily (but not always) by pushing DOWN, DOWN, UP in rapid succession. I

[PATCH 9/11] drivers/media: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // smpl @@ type T; constant C;

[PATCH 8/11] drivers/media/usb/usbvision/usbvision-core.c: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // smpl @@ type T; constant C;

[PATCH 9/11 V2] drivers/media: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // smpl @@ type T; constant C;

auto-compile after reboot / compile only specific driver

2014-05-31 Thread Dexter Filmore
Hi, on debian 7 or derivates such as ubuntu 12.04/14.04, how can I automtically compile the linuxtv drivers against the latest kernel after a kernel update came in? Is DKMS suitable here? Has somebody done it and has instructions? What if I only have one specific DVB module only anyway, can I

cron job: media_tree daily build: OK

2014-05-31 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Jun 1 04:00:21 CEST 2014 git branch: test git hash: 5ea878796f0a1d9649fe43a6a09df53d3915c0ef gcc

[PATCH 16/18] v4l: vsp1: bru: Support premultiplied alpha at the BRU inputs

2014-05-31 Thread Laurent Pinchart
Adjust the BRU blending formula to avoid the multiplication by alpha when the corresponding input format is premultiplied. As this requires access to the RPFs connected to the BRU inputs from the BRU module, store pointers to the RPFs in the BRU structure when validating the pipeline.

[PATCH 06/18] v4l: vsp1: Cleanup video nodes at removal time

2014-05-31 Thread Laurent Pinchart
Video nodes created and initialized in the RPF and WPF init code paths are never unregistered, and the related resources (videobuf alloc context and media entity) never released. Fix this by storing a pointer to the vsp1_video object in vsp1_entity and calling vsp1_video_cleanup() from

[PATCH 10/18] v4l: vsp1: sru: Make the intensity controllable during streaming

2014-05-31 Thread Laurent Pinchart
The control value is currently stored in the SRU structure by the control set handler and written to the hardware at stream on time, making control set during streaming ineffective. Fix it by writing to the registers from within the control set handler. Signed-off-by: Laurent Pinchart

[PATCH 13/18] v4l: vsp1: Switch to XRGB formats

2014-05-31 Thread Laurent Pinchart
The driver ignores the alpha component on output video nodes and hardcodes the alpha component to 0 on capture video nodes. Make this explicit by exposing XRGB formats. Compatibility with existing userspace applications is handled by selecting the XRGB format corresponding to the requested old

[PATCH 00/18] Renesas VSP1: alpha support

2014-05-31 Thread Laurent Pinchart
Hello, This patch set adds alpha support to the Renesas VSP1 driver. The feature is split in two parts, support for the alpha component in capture and output buffers, and support for premultiplied colors. Each part requires extensions to the V4L API. The first two patch add new pixel formats for

[PATCH 05/18] v4l: vsp1: Fix typos

2014-05-31 Thread Laurent Pinchart
Several macros were mistakenly prefixed with VPS1 instead of VSP1. Fix them. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1.h | 12 ++-- drivers/media/platform/vsp1/vsp1_drv.c | 6 +++---

[PATCH 17/18] v4l: vsp1: bru: Support non-premultiplied colors at the BRU output

2014-05-31 Thread Laurent Pinchart
The BRU outputs premultiplied colors, enable color data normalization when the format configured at the output of the pipeline isn't premultiplied. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1_bru.c | 11 +-- 1 file

[PATCH 18/18] v4l: vsp1: bru: Make the background color configurable

2014-05-31 Thread Laurent Pinchart
Expose the background color to userspace through the V4L2_CID_BG_COLOR control. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1_bru.c | 51 ++ drivers/media/platform/vsp1/vsp1_bru.h | 3 ++ 2 files

[PATCH 11/18] v4l: vsp1: wpf: Simplify cast to pipeline structure

2014-05-31 Thread Laurent Pinchart
USe the subdev pointer directly to_vsp1_pipeline() macro instead of casting from the subdev to the wpf object and back to the subdev. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1_wpf.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 01/18] v4l: Add ARGB and XRGB pixel formats

2014-05-31 Thread Laurent Pinchart
From: Laurent Pinchart laurent.pinch...@ideasonboard.com The existing RGB pixel formats are ill-defined in respect to their alpha bits and their meaning is driver dependent. Create new standard ARGB and XRGB variants with clearly defined meanings and make the existing variants deprecated. The

[PATCH 03/18] v4l: Support extending the v4l2_pix_format structure

2014-05-31 Thread Laurent Pinchart
The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which has reserved fields that were not previously required to be zeroed out by applications. To allow extending

[PATCH 12/18] v4l: vsp1: wpf: Clear RPF to WPF association at stream off time

2014-05-31 Thread Laurent Pinchart
The VSP1 stores the video pipelines' input (RPF) to output (WPF) mappings in a WPF register. An RPF must never be associated with multiple WPFs, even if all of those WPFs but one are unused, otherwise the hardware won't function properly. The driver doesn't ensure this correctly as it never

[PATCH 15/18] v4l: vsp1: Add V4L2_CID_ALPHA_COMPONENT control support

2014-05-31 Thread Laurent Pinchart
The control is used to configure the fixed alpha channel value, when reading from memory in the RPF or writing to memory in the WPF. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1_rpf.c | 52 ---

[PATCH 14/18] v4l: vsp1: Add alpha channel support to the memory ports

2014-05-31 Thread Laurent Pinchart
Support ARGB formats on the RPF side by reading the alpha component from memory and on the WPF side by writing it to memory. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1_rpf.c | 8 --

[PATCH 02/18] DocBook: media: Document ALPHA_COMPONENT control usage on output devices

2014-05-31 Thread Laurent Pinchart
Extend the V4L2_CID_ALPHA_COMPONENT control for use on output devices, to set the alpha component value when the output format doesn't have an alpha channel. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/media/v4l/controls.xml | 17

[PATCH 09/18] v4l: vsp1: sru: Fix the intensity control default value

2014-05-31 Thread Laurent Pinchart
The default value isn't set and defaults to 0, which isn't in the 1-6 min-max range. Fix it by setting the default value to 1. This shoud have been caught when checking the control handler error field at initialization time, but the check was missing. Add it. Signed-off-by: Laurent Pinchart

[PATCH 04/18] v4l: Add premultiplied alpha flag for pixel formats

2014-05-31 Thread Laurent Pinchart
When set, the new V4L2_PIX_FMT_FLAG_PREMUL_ALPHA flag indicates that the pixel values are premultiplied by the alpha channel value. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/media/v4l/pixfmt.xml | 28 +++-

[PATCH 08/18] v4l: vsp1: Setup control handler automatically at stream on time

2014-05-31 Thread Laurent Pinchart
When setting a control directly on a subdev node the VSP1 driver doesn't guarantee that the device is powered on. This leads to crashes when the control handlers writes to hardware registers. One easy way to fix this is to ensure that the device gets powered on when a subdev node is opened.

[PATCH 07/18] v4l: vsp1: Propagate vsp1_device_get errors to the callers

2014-05-31 Thread Laurent Pinchart
Modify the vsp1_device_get() function to return an error code instead of a pointer to the VSP1 device, and use the return value in the callers. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/vsp1/vsp1.h | 2 +-