Re: [PATCH 1/6] adv7180: Remove duplicate unregister call

2014-07-17 Thread Hans Verkuil
On 07/06/2014 12:26 AM, Ben Dooks wrote: From: Ian Molton ian.mol...@codethink.co.uk This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: Ben Dooks

[GIT PULL FOR v3.17] A bunch of

2014-07-17 Thread Hans Verkuil
These are all little fixes for issues I found while working on the vivi replacement + some docbook fixes. Usually all for fairly obscure corner cases, but that's what you write a test driver for, after all. Regards, Hans The following changes since commit

Re: [GIT PULL FOR v3.17] A bunch of

2014-07-17 Thread Hans Verkuil
OK, so the full subject line should have been: A bunch of little v4l2 core fixes :-) Hans On 07/17/2014 10:09 AM, Hans Verkuil wrote: These are all little fixes for issues I found while working on the vivi replacement + some docbook fixes. Usually all for fairly obscure

Re: vb2_reqbufs() is not allowing more than VIDEO_MAX_FRAME

2014-07-17 Thread Hans Verkuil
Hi Divneil, This patch is all messed up and doesn't apply. Check your mailer settings: it clearly replaced hard tabs by a space. Can you repost? Regards, Hans On 07/07/2014 09:27 AM, Divneil Wadhawan wrote: Hi Hans, include/media/davinci/vpfe_capture.h It uses

Re: [PATCH v2] media: vb2: verify data_offset only if nonzero bytesused

2014-07-17 Thread Hans Verkuil
Hi Nikhil, First of all, sorry for the delay in answering. I needed some time to really look at this. Anyway, this patch as is is not good enough since it does not handle the case where data_offset is length and bytesused == 0. However, I think the solution should be done differently. I'll

[GIT PULL FOR v3.17] Assorted patches

2014-07-17 Thread Hans Verkuil
Mostly little cleanups and adding a new card to cx23885. Hans The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at:

[PATCH] vb2: fix bytesused == 0 handling

2014-07-17 Thread Hans Verkuil
The original report from Nikhil was that if data_offset 0 and bytesused == 0, then the check in __verify_length() would fail, even though the spec says that if bytes_used == 0, then it will be replaced by the actual length of the buffer. After digging into it a bit more I realized that there

[GIT PULL FOR v3.17] OMAP4 ISS fixes and enhancements

2014-07-17 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap4iss/next for you to

Re: [PATCH 2/3] smiapp: Set sub-device owner

2014-07-17 Thread Laurent Pinchart
Hi Sakari, What happened to this patch ? 1/3 and 3/3 from the same series seem to have been applied, but not 2/3. On Friday 28 March 2014 16:35:12 Sakari Ailus wrote: The smiapp driver is the owner of the sub-devices exposed by the smiapp driver. This prevents unloading the module whilst it's

[GIT PULL FOR v3.17] mt9v032 sensor patches

2014-07-17 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git sensors/next for you to fetch

[GIT PULL FOR v3.17] Three trivial davinci patches

2014-07-17 Thread Hans Verkuil
The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git davinci for you to fetch changes up

Re: [PATCH v2 3/3] [media] atmel-isi: add primary DT support

2014-07-17 Thread Laurent Pinchart
Hi Josh, What's the status of this patch set ? Do you plan to rebase and resubmit it ? On Monday 31 March 2014 17:05:13 Josh Wu wrote: Dear Guennadi On 3/31/2014 5:20 AM, Guennadi Liakhovetski wrote: Hi Josh, Please correct me if I'm wrong, but I don't see how this is going to work

Re: [PATCH 2/3] smiapp: Set sub-device owner

2014-07-17 Thread Sakari Ailus
On Thu, Jul 17, 2014 at 12:22:47PM +0200, Laurent Pinchart wrote: Hi Sakari, What happened to this patch ? 1/3 and 3/3 from the same series seem to have been applied, but not 2/3. I think this must have fallen through the cracks when I added a number of other patches to the set. Thanks for

Re: [PATCH 00/28] IPUv3 prep for video capture

2014-07-17 Thread Hans Verkuil
Hi Steve, I don't know what your plan is, but when you want to mainline this it is the gpu subsystem that needs to review it. I noticed it wasn't cross-posted to the dri-devel mailinglist. I am a bit worried about the amount of v4l2-specific stuff that is going into drivers/gpu/ipu-v3. Do things

[GIT PULL FOR v3.17] Replace V4L2_FIELD_ANY with V4L2_FIELD_NONE in subdev drivers

2014-07-17 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git v4l2/field for you to fetch

Re: [PATCH] tvp5150: Use i2c_smbus_(read|write)_byte_data

2014-07-17 Thread Laurent Pinchart
Hi Mauro, Ping ? On Monday 26 May 2014 21:31:28 Laurent Pinchart wrote: Replace the custom I2C read/write implementation with SMBUS functions to simplify the driver. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/tvp5150.c | 31

Re: [PATCH] tvp5150: Fix device ID kernel log message

2014-07-17 Thread Laurent Pinchart
Hi Mauro, Ping ? On Monday 26 May 2014 21:28:31 Laurent Pinchart wrote: The driver mistakenly prints the ROM version instead of the device ID to the kernel log when detecting the chip. Fix it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

Re: [PATCH 1/1] media: Set entity-links NULL in cleanup

2014-07-17 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday 27 May 2014 16:27:49 Sakari Ailus wrote: Calling media_entity_cleanup() on a cleaned-up entity would result into double free of the entity-links pointer and likely memory corruption as well. My first question is, why would anyone do that ? :-)

Re: [PATCH] media-device: Remove duplicated memset() in media_enum_entities()

2014-07-17 Thread Laurent Pinchart
Hi Salva, Thank you for the patch. On Saturday 07 June 2014 16:41:44 Salva Peiró wrote: After the zeroing the whole struct struct media_entity_desc u_ent, it is no longer necessary to memset(0) its u_ent.name field. Signed-off-by: Salva Peiró spe...@ai2.upv.es To: Mauro Carvalho Chehab

Re: [PATCH 1/1] media: Set entity-links NULL in cleanup

2014-07-17 Thread Sakari Ailus
Hi Laurent, On Thu, Jul 17, 2014 at 01:43:09PM +0200, Laurent Pinchart wrote: On Tuesday 27 May 2014 16:27:49 Sakari Ailus wrote: Calling media_entity_cleanup() on a cleaned-up entity would result into double free of the entity-links pointer and likely memory corruption as well. My

[PATCH] media: Use strlcpy instead of custom code

2014-07-17 Thread Laurent Pinchart
Replace strncpy + manually setting the terminating '\0' with an strlcpy call. Reported-by: Joe Perches j...@perches.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/media-device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) This patch

[GIT PULL FOR v3.17] MC and V4L2 core fixes

2014-07-17 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git v4l2/core for you to fetch

Re: [PATCH 1/1] media: Set entity-links NULL in cleanup

2014-07-17 Thread Laurent Pinchart
On Thursday 17 July 2014 14:53:49 Sakari Ailus wrote: On Thu, Jul 17, 2014 at 01:43:09PM +0200, Laurent Pinchart wrote: On Tuesday 27 May 2014 16:27:49 Sakari Ailus wrote: Calling media_entity_cleanup() on a cleaned-up entity would result into double free of the entity-links pointer and

Re: [PATCH] media:platform: OMAP3 camera support needs VIDEOBUF2_DMA_CONTIG

2014-07-17 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Friday 04 July 2014 09:51:47 Peter Meerwald wrote: drivers/built-in.o: In function `isp_video_open': /src/linux/drivers/media/platform/omap3isp/ispvideo.c:1253: undefined reference to `vb2_dma_contig_memops' drivers/built-in.o: In function

Re: [PATCH] [RFC] [media] omap3isp: try to fix dependencies

2014-07-17 Thread Laurent Pinchart
Hi Arnd, Sorry for the late reply. On Friday 13 June 2014 14:02:01 Arnd Bergmann wrote: commit 2a0a5472af5c (omap3isp: Use the ARM DMA IOMMU-aware operations) brought the omap3isp driver closer to using standard APIs, but also introduced two problems: a) it selects a particular IOMMU

[GIT PULL FOR v3.17] OMAP3 ISP fix

2014-07-17 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c: [media] dib8000: improve the message that reports per-layer locks (2014-07-07 09:59:01 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap3isp/next for you to

Re: [RFC/PATCH 0/5] Add Video Processing Front End Support

2014-07-17 Thread Prabhakar Lad
On Tue, Jul 15, 2014 at 6:56 PM, Felipe Balbi ba...@ti.com wrote: Hi all, the following patches add suport for AM43xx's Video Processing Front End (VPFE). Full documentation is available at [1] chapter 14. This driver has been tested with linux-next from yesterday, plus my (already queued)

[PATCH 1/2] DocBook improvement for U8 and U16 control types

2014-07-17 Thread Hans Verkuil
Removed the This type is only used-in array controls. sentence in DocBook which was thought to only confuse. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git a/Documentation/DocBook/media/v4l/vidioc-queryctrl.xml b/Documentation/DocBook/media/v4l/vidioc-queryctrl.xml index

[PATCH 2/2] v4l2-ctrls: fix compiler warning

2014-07-17 Thread Hans Verkuil
Fixed a compiler warning in v4l_print_query_ext_ctrl() due to the change from dims[8] to dims[4]. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index c38a620..96bc117 100644 ---

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-17 Thread Ricardo Ribalda Delgado
Hello Hans I am planning to test this patchset for dead pixels by the end of this week and the beggining of the next. I am thinking about comparing the performance a list of deadpixels against a list of all pixels with their property (ok pixel, dead pixel, white pixel, slow pixel...) Will write

[PATCH for v3.17] Fix 64-bit division fall-out from 64-bit control ranges

2014-07-17 Thread Hans Verkuil
Commit 0ba2aeb6dab80920edd9cf5b93b1ea4d6913b8f3 increased the internal control ranges to 64 bit, but that caused problems in drivers that use the minimum/maximum/step/default_value control values in a division or modulus operations since not all architectures support those natively. Luckily,

[linuxtv-media:master] 2181d142707a2cf5df44840ac7112ac4568b03c9 BUILD DONE

2014-07-17 Thread kbuild test robot
git://linuxtv.org/media_tree.git master 2181d142707a2cf5df44840ac7112ac4568b03c9 Merge branch 'sched_warn_fix' into patchwork (.text+0x281c8b0): undefined reference to `__divdi3' ERROR: __udivdi3 [drivers/media/v4l2-core/videodev.ko] undefined! ERROR: __umoddi3

[PATCH 10/11] [media] coda: default to h.264 decoder on invalid formats

2014-07-17 Thread Philipp Zabel
If the user provides an invalid format, let the decoder device default to h.264. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c

[PATCH 07/11] [media] coda: lock capture frame size to output frame size when streaming

2014-07-17 Thread Philipp Zabel
As soon as the output queue is streaming, let try_fmt on the capture side only allow the frame size that was set on the output side. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 08/11] [media] coda: split userspace interface into encoder and decoder device

2014-07-17 Thread Philipp Zabel
Userspace has a hard time making sense of format enumerations on V4L2 mem2mem devices if there are restrictions on which input and output formats can be used together. Alleviate the problem by splitting the video4linux device into separate encoder and decoder devices which list only raw formats on

[PATCH 09/11] [media] coda: split format enumeration for encoder end decoder device

2014-07-17 Thread Philipp Zabel
Let the decoder capture side and encoder output side only list uncompressed formats, and the decoder output and encoder capture side only list compressed formats. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 57

[PATCH 11/11] [media] coda: mark constant structures as such

2014-07-17 Thread Philipp Zabel
The format and codec lists and the ops structures are read-only. Mark them as const. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[PATCH 02/11] [media] coda: initialize hardware on pm runtime resume only if firmware available

2014-07-17 Thread Philipp Zabel
If no firmware was found and the coda module is unloaded, coda_runtime_resume will be called without an allocated code buffer. Do not call coda_hw_init in this case. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 03/11] [media] coda: remove CAPTURE and OUTPUT caps

2014-07-17 Thread Philipp Zabel
This is a mem2mem driver, pure capture or output modes are not supported. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c

[PATCH 01/11] [media] coda: fix CODA7541 hardware reset

2014-07-17 Thread Philipp Zabel
Do not try to read the CODA960 GDI status register on CODA7541. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/coda.c

[PATCH 06/11] [media] coda: delay coda_fill_bitstream()

2014-07-17 Thread Philipp Zabel
From: Michael Olbrich m.olbr...@pengutronix.de coda_fill_bitstream() calls v4l2_m2m_buf_done() which is no longer allowed before streaming was started. Delay coda_fill_bitstream() until coda_start_streaming() and explicitly set 'start_streaming_called' before calling coda_fill_bitstream()

[PATCH 04/11] [media] coda: remove VB2_USERPTR from queue io_modes

2014-07-17 Thread Philipp Zabel
Disallow USERPTR buffers, videobuf2-dma-contig doesn't support them. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index

[PATCH 05/11] [media] coda: use CODA_MAX_FRAME_SIZE everywhere

2014-07-17 Thread Philipp Zabel
From: Michael Olbrich m.olbr...@pengutronix.de Without this changing CODA_MAX_FRAME_SIZE to anything other than 0x10 can break the bitstram handling Signed-off-by: Michael Olbrich m.olbr...@pengutronix.de Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c

[PATCH 00/11] CODA encoder/decoder device split

2014-07-17 Thread Philipp Zabel
Hi, the following patches add a few fixes and cleanups and split the coda video4linux2 device into encoder and decoder. Following the principle of least surprise, this way the format enumeration on the output and capture sides is fixed and does not change depending on whether the given instance

Re: [PATCH 03/11] [media] coda: remove CAPTURE and OUTPUT caps

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: This is a mem2mem driver, pure capture or output modes are not supported. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media/platform/coda.c | 8 +---

Re: [PATCH 07/11] [media] coda: lock capture frame size to output frame size when streaming

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: As soon as the output queue is streaming, let try_fmt on the capture side only allow the frame size that was set on the output side. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Hans Verkuil hans.verk...@cisco.com Regards,

Re: [PATCH 06/11] [media] coda: delay coda_fill_bitstream()

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: From: Michael Olbrich m.olbr...@pengutronix.de coda_fill_bitstream() calls v4l2_m2m_buf_done() which is no longer allowed before streaming was started. Delay coda_fill_bitstream() until coda_start_streaming() and explicitly set

Re: [PATCH 04/11] [media] coda: remove VB2_USERPTR from queue io_modes

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: Disallow USERPTR buffers, videobuf2-dma-contig doesn't support them. Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 4 ++-- 1 file

Re: [PATCH 08/11] [media] coda: split userspace interface into encoder and decoder device

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: Userspace has a hard time making sense of format enumerations on V4L2 mem2mem devices if there are restrictions on which input and output formats can be used together. Alleviate the problem by splitting the video4linux device into separate encoder

Re: [PATCH 11/11] [media] coda: mark constant structures as such

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: The format and codec lists and the ops structures are read-only. Mark them as const. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans --- drivers/media/platform/coda.c |

Re: [PATCH 09/11] [media] coda: split format enumeration for encoder end decoder device

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: Let the decoder capture side and encoder output side only list uncompressed formats, and the decoder output and encoder capture side only list compressed formats. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Hans Verkuil

Re: [PATCH 10/11] [media] coda: default to h.264 decoder on invalid formats

2014-07-17 Thread Hans Verkuil
On 07/17/2014 06:05 PM, Philipp Zabel wrote: If the user provides an invalid format, let the decoder device default to h.264. Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 8

[PATCH 2/4] drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: fix negativity check

2014-07-17 Thread Andrey Utkin
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]: (style) Checking if unsigned variable 'val' is less than zero. val = get_oneshot_mode(ipipeif-input); if (val 0) { pr_err(ipipeif: links setup required); return -EINVAL; } but static int

Re: [PATCH 06/11] [media] coda: delay coda_fill_bitstream()

2014-07-17 Thread Philipp Zabel
Hi Hans, thank you for the review. Am Donnerstag, den 17.07.2014, 18:17 +0200 schrieb Hans Verkuil: @@ -2272,6 +2273,15 @@ static int coda_start_streaming(struct vb2_queue *q, unsigned int count) q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); if (q-type ==

[PATCH 1/1] si2168: Set symbol_rate in set_frontend for DVB-C delivery system.

2014-07-17 Thread Luis Alves
This patch adds symbol rate setting to the driver. Signed-off-by: Luis Alves lja...@gmail.com --- drivers/media/dvb-frontends/si2168.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index

RTL2836 analysis

2014-07-17 Thread yawoo
I would like to analyse my DTMB / DMB-TH TV tuner, and here is the components: USB bridge: RTL2832P, Demod: RTL2836S, Tuner: FC0012 Thanks to Antti's analysis tool, I have generated some codes. I can match parts of codes with Realtek original source code rtl2832u-2.2.2. But the beginning codes I

[GIT PULL FOR v3.17] A few more fixes for 3.17

2014-07-17 Thread Hans Verkuil
The following changes since commit bdc2df62ae38bbab044078f4d25a7a3d9e2379c9: [media] v4l: vsp1: uds: Fix scaling of alpha layer (2014-07-17 12:45:00 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.17c for you to fetch changes up to

[PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver.

2014-07-17 Thread Olli Salonen
Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/dvb-frontends/si2168.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 0422925..56811e1 100644 --- a/drivers/media/dvb-frontends/si2168.c

[PATCH for v3.17] saa7146: fix compile warning

2014-07-17 Thread Hans Verkuil
Fall-out from the recent struct v4l2_framebuffer change. drivers/media/common/saa7146/saa7146_fops.c: In function ‘saa7146_vv_init’: drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment from incompatible pointer type [enabled by default] fmt = vv-ov_fb.fmt; ^

Re: [PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver.

2014-07-17 Thread Luis Alves
This would be best done during init and not every time on set_frontend. Regards, Luis On Thu, Jul 17, 2014 at 7:43 PM, Olli Salonen olli.salo...@iki.fi wrote: Signed-off-by: Olli Salonen olli.salo...@iki.fi --- drivers/media/dvb-frontends/si2168.c | 7 +++ 1 file changed, 7

[PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0.

2014-07-17 Thread Luis Alves
Signed-off-by: Luis Alves lja...@gmail.com --- drivers/media/dvb-frontends/si2168.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 7980741..3fed522 100644 ---

davinci compiler warnings

2014-07-17 Thread Hans Verkuil
Hi Prabhakar, Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen before. Regards, Hans /home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c: In function

Re: davinci compiler warnings

2014-07-17 Thread Prabhakar Lad
Hi Hans On Thu, Jul 17, 2014 at 8:41 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen before. Ok will look at it. BTW are these errors from

Re: davinci compiler warnings

2014-07-17 Thread Hans Verkuil
On 07/17/2014 09:49 PM, Prabhakar Lad wrote: Hi Hans On Thu, Jul 17, 2014 at 8:41 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, Can you take a look at these new warnings? I've just upgraded my compiler for the daily build to 4.9.1, so that's probably why they weren't seen

Re: [PATCH 00/28] IPUv3 prep for video capture

2014-07-17 Thread Steve Longerbeam
On 07/17/2014 04:10 AM, Hans Verkuil wrote: Hi Steve, I don't know what your plan is, but when you want to mainline this it is the gpu subsystem that needs to review it. I noticed it wasn't cross-posted to the dri-devel mailinglist. Hi Hans, I'm reworking these patches, I've merged in some

[PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail.

2014-07-17 Thread Luis Alves
Signed-off-by: Luis Alves lja...@gmail.com --- drivers/media/dvb-frontends/si2168.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 3fed522..7e45eeab 100644 --- a/drivers/media/dvb-frontends/si2168.c +++

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-17 Thread Hans Verkuil
Hi Laurent, Something that just caught my eye: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which has reserved fields

Re: [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure

2014-07-17 Thread Hans Verkuil
And another thing that I found while implementing this in v4l2-ctl: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: The v4l2_pix_format structure has no reserved field. It is embedded in the v4l2_framebuffer structure which has no reserved fields either, and in the v4l2_format structure which

Re: [PATCH 1/1] si2168: Set symbol_rate in set_frontend for DVB-C delivery system.

2014-07-17 Thread Antti Palosaari
Looks sane, I will apply that. regards Antti On 07/17/2014 08:31 PM, Luis Alves wrote: This patch adds symbol rate setting to the driver. Signed-off-by: Luis Alves lja...@gmail.com --- drivers/media/dvb-frontends/si2168.c | 12 1 file changed, 12 insertions(+) diff --git

Re: [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0.

2014-07-17 Thread Antti Palosaari
Gah, there was a bug. Will apply that. Have to check if there is same mistake on other drivers I have used I2C mux. regards Antti On 07/17/2014 10:38 PM, Luis Alves wrote: Signed-off-by: Luis Alves lja...@gmail.com --- drivers/media/dvb-frontends/si2168.c | 4 +++- 1 file changed, 3

Re: [PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail.

2014-07-17 Thread Antti Palosaari
Looks good! I did some measurements against power meter and chip seems to be low power state by default. After firmware is downloaded and chip is put to sleep, it does not answer that fw status check, until it is woken up. There should not be ~any I/O during I2C probe(), so removing that quite

Re: [GIT PULL FOR v3.17] A bunch of

2014-07-17 Thread Mauro Carvalho Chehab
Em Thu, 17 Jul 2014 10:09:40 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: These are all little fixes for issues I found while working on the vivi replacement + some docbook fixes. Usually all for fairly obscure corner cases, but that's what you write a test driver for, after all.

[PATCH REBASED] v4l2-ioctl: clips, clipcount and bitmap should not be zeroed.

2014-07-17 Thread Hans Verkuil
Otherwise you cannot get the current clip and bitmap information from an overlay. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-ioctl.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver.

2014-07-17 Thread Antti Palosaari
On 07/17/2014 10:09 PM, Luis Alves wrote: This would be best done during init and not every time on set_frontend. I am perfectly fine it is done during set_frontend(), even it is static value. There were earlier tons of these 0x14 commands, including that one. I removed all that were same as

Re: [GIT PULL FOR v3.17] A bunch of

2014-07-17 Thread Hans Verkuil
On 07/17/2014 11:43 PM, Mauro Carvalho Chehab wrote: Em Thu, 17 Jul 2014 10:09:40 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: These are all little fixes for issues I found while working on the vivi replacement + some docbook fixes. Usually all for fairly obscure corner cases, but

Re: [PATCH v2 01/23] v4l: Add ARGB and XRGB pixel formats

2014-07-17 Thread Hans Verkuil
Hi Laurent, While implementing support for this in v4l-utils I discovered you missed one: On 06/24/2014 01:54 AM, Laurent Pinchart wrote: From: Laurent Pinchart laurent.pinch...@ideasonboard.com The existing RGB pixel formats are ill-defined in respect to their alpha bits and their meaning

[PATCH for v3.17] DocBook media: fix incorrect note about packed RGB and colorspace

2014-07-17 Thread Hans Verkuil
The fact that the pixelformat is using a packed RGB format has nothing to do with the colorspace that is being used. Those are very different things. The colorspace decides what color a triplet of RGB numbers actually map to. E.g. a red color with values (255, 0, 0) is a different type of red

[PATCH 1/1] si2168: Support Si2168-A20 firmware downloading.

2014-07-17 Thread Luis Alves
This adds support for the Si2168-A20 firmware download. Extracting the firmware: wget http://www.tbsdtv.com/download/document/tbs6281/tbs6281-t2-t-driver_v1.0.0.6.zip unzip tbs6281-t2-t-driver_v1.0.0.6.zip dd if=tbs-6281_x64/tbs6281_64.sys of=dvb-demod-si2168-a20-01.fw count=28656 bs=1

[PATCH] libv4lconvert: add support for new pixelformats

2014-07-17 Thread Hans Verkuil
Support for alpha-channel aware pixelformats was added. Recognize those formats in libv4lconvert. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git a/lib/libv4lconvert/libv4lconvert.c b/lib/libv4lconvert/libv4lconvert.c index 7ee7c19..cea65aa 100644 ---

[linuxtv-media:master 452/499] drivers/staging/media/solo6x10/solo6x10-disp.c:225 solo_set_motion_block() error: potential null dereference 'buf'. (kzalloc returns null)

2014-07-17 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 9409945c7ff7ba39727df8ede2551bd22e76b58b commit: 761f9aa23f2ac187aa1bed58215f09f3c8456295 [452/499] [media] solo6x10: fix 'dma from stack' warning drivers/staging/media/solo6x10/solo6x10-disp.c:225 solo_set_motion_block() error: potential

[PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.

2014-07-17 Thread Luis Alves
(ignore the previous one, it was incomplete) This adds support for the Si2168-A20 firmware download. Extracting the firmware: wget http://www.tbsdtv.com/download/document/tbs6281/tbs6281-t2-t-driver_v1.0.0.6.zip unzip tbs6281-t2-t-driver_v1.0.0.6.zip dd if=tbs-6281_x64/tbs6281_64.sys

Re: [PATCH 1/2] cx23885: fix UNSET/TUNER_ABSENT confusion.

2014-07-17 Thread Mauro Carvalho Chehab
Em Fri, 27 Jun 2014 16:15:41 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Sometimes dev-tuner_type is compared to UNSET, sometimes to TUNER_ABSENT, but these defines have different values. Standardize to TUNER_ABSENT. That patch looks wrong.

Re: [PATCH 1/2] cx23885: fix UNSET/TUNER_ABSENT confusion.

2014-07-17 Thread Hans Verkuil
On 07/18/2014 12:45 AM, Mauro Carvalho Chehab wrote: Em Fri, 27 Jun 2014 16:15:41 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Sometimes dev-tuner_type is compared to UNSET, sometimes to TUNER_ABSENT, but these defines have different values.

Re: [PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.

2014-07-17 Thread Antti Palosaari
Thank for the patch! I will apply that sure too. Driver supports now all Si2168 versions? regards Antti On 07/18/2014 01:43 AM, Luis Alves wrote: (ignore the previous one, it was incomplete) This adds support for the Si2168-A20 firmware download. Extracting the firmware: wget

Re: [PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.

2014-07-17 Thread Luis Alves
I think so... at least the known ones. On Thu, Jul 17, 2014 at 11:56 PM, Antti Palosaari cr...@iki.fi wrote: Thank for the patch! I will apply that sure too. Driver supports now all Si2168 versions? regards Antti On 07/18/2014 01:43 AM, Luis Alves wrote: (ignore the previous one, it was

Re: [git:media_tree/master] [media] cx23885: add support for Hauppauge ImpactVCB-e

2014-07-17 Thread Hans Verkuil
Please revert, without the preceding patch (cx23885: fix UNSET/TUNER_ABSENT confusion.) this board won't work. Or merge that patch as well, that's fine too... Regards, Hans On 07/18/2014 12:57 AM, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that

[PATCH for v3.17 0/4] Move go7007 and solo6x10 out of staging

2014-07-17 Thread Hans Verkuil
The compound control support was merged and that allowed the motion detection support to be merged as well. So there is nothing keeping these two drivers in staging. This patch series moves them to drivers/media. One note: the go7007 supports an saa7134+go7007 based board as well and a patch for

[PATCH for v3.17 4/4] solo6x10: move out of staging into drivers/media/pci.

2014-07-17 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Now that the custom motion detection API has been replaced with a standard API there is no reason anymore to keep it in staging. So (finally!) move it to drivers/media/pci. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCH for v3.17 1/4] go7007: update the README, fix checkpatch warnings

2014-07-17 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This prepares the driver for moving out of staging. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/go7007/README | 1 - drivers/staging/media/go7007/go7007-driver.c | 6 +

[PATCH for v3.17 2/4] go7007: move out of staging into drivers/media/usb.

2014-07-17 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Now that the custom motion detection API in this driver has been replaced with a standard API there is no reason anymore to keep it in staging. So (finally!) move it to drivers/media/usb. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCH for v3.17 3/4] solo6x10: a few checkpatch fixes

2014-07-17 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Added a blank line after variable declarations where checkpatch requested that, and removed the 'write to the FSF' paragraph, again as requested. This is in preparation of the move out of staging into drivers/media. Signed-off-by: Hans Verkuil

media_build wrong patch

2014-07-17 Thread Rafael van Horn
Hi, I'd like to file a bug in the latest commit: b6f4c524e0fe8f2d50b0a2f849e022adef76c6cc The file backports/api_version.patch rejects to patch the linux/drivers/media/v4l2-core/v4l2-ioctl.c because of wrong line numbers and because the code doesn't match. This is your code:

[linuxtv-media:master 447/499] drivers/media/common/saa7146/saa7146_fops.c:536:13: sparse: incorrect type in assignment (different base types)

2014-07-17 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 0ca1ba2aac5f6b26672099b13040c5b40db93486 commit: d52e23813672c3c72f92e7b39c7408d4b9a40a96 [447/499] [media] v4l: Support extending the v4l2_pix_format structure reproduce: make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed

Re: media_build wrong patch

2014-07-17 Thread Hans Verkuil
On 07/18/2014 01:46 AM, Rafael van Horn wrote: Hi, I'd like to file a bug in the latest commit: b6f4c524e0fe8f2d50b0a2f849e022adef76c6cc The file backports/api_version.patch rejects to patch the linux/drivers/media/v4l2-core/v4l2-ioctl.c because of wrong line numbers and because the

Re: [PATCH] airspy: AirSpy SDR driver

2014-07-17 Thread Antti Palosaari
On 07/15/2014 06:50 AM, Hans Verkuil wrote: On 07/15/2014 04:35 AM, Antti Palosaari wrote: On 07/14/2014 11:01 PM, Hans Verkuil wrote: On 07/14/2014 09:55 PM, Antti Palosaari wrote: I actually ran v4l2-compliance and there was problem with ADC band enumeration. v4l2-compliance didn't liked

[PATCH] MAINTAINERS: update MSI3101 / MSI2500 driver location

2014-07-17 Thread Antti Palosaari
MSi3101 driver is moved out of staging and renamed. Signed-off-by: Antti Palosaari cr...@iki.fi --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e0bd8b0..b2d6f2e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5893,7 +5893,7

[PATCH 4/4] MAINTAINERS: add airspy driver

2014-07-17 Thread Antti Palosaari
Video4Linux2 driver for AirSpy SDR device. Signed-off-by: Antti Palosaari cr...@iki.fi --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 943efe3..f8e2c7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -508,6 +508,16 @@ S: Supported F:

[PATCH 1/4] airspy: remove v4l2-compliance workaround

2014-07-17 Thread Antti Palosaari
v4l2-compliance is now happy with frequency ranges where both lower and upper limit is same. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/airspy/airspy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] airspy: print notice to point SDR API is not 100% stable yet

2014-07-17 Thread Antti Palosaari
Print notice on driver load: SDR API is still slightly experimental and functionality changes may follow. It is just remind possible used SDR API is very new and surprises may occur. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/airspy/airspy.c | 4 +++- 1 file changed, 3

[GIT PULL] SDR stuff

2014-07-17 Thread Antti Palosaari
* AirSpy SDR driver * all SDR drivers moved out of staging * few new SDR stream formats regards Antti The following changes since commit 3445857b22eafb70a6ac258979e955b116bfd2c6: [media] hdpvr: fix two audio bugs (2014-07-04 15:13:02 -0300) are available in the git repository at:

  1   2   >