Re: [PATCH v2 4/5] [media] c8sectpfe: Update binding to reset-gpios

2015-08-28 Thread Lee Jones
On Thu, 27 Aug 2015, Peter Griffin wrote: gpio.txt documents that GPIO properties should be named [name-]gpios, with name being the purpose of this GPIO for the device. This change has been done as one atomic commit. Signed-off-by: Peter Griffin peter.grif...@linaro.org ---

Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-28 Thread Lee Jones
On Thu, 27 Aug 2015, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- .../devicetree/bindings/media/stih407-c8sectpfe.txt | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v2 3/5] [media] c8sectpfe: Remove select on undefined LIBELF_32

2015-08-28 Thread Lee Jones
On Thu, 27 Aug 2015, Peter Griffin wrote: LIBELF_32 is not defined in Kconfig, and is left over legacy which is not required in the upstream driver, so remove it. Signed-off-by: Peter Griffin peter.grif...@linaro.org Suggested-by: Valentin Rothberg valentinrothb...@gmail.com These are the

Re: [PATCH v2 2/5] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node.

2015-08-28 Thread Lee Jones
On Thu, 27 Aug 2015, Peter Griffin wrote: This patch adds in the required DT node for the c8sectpfe Linux DVB demux driver which allows the tsin channels to be used on an upstream kernel. Signed-off-by: Peter Griffin peter.grif...@linaro.org --- arch/arm/boot/dts/stihxxx-b2120.dtsi | 34

Re: [PATCH v2 1/5] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 ssc3

2015-08-28 Thread Lee Jones
On Thu, 27 Aug 2015, Peter Griffin wrote: Adding these properties makes the I2C bus to the demodulators much more reliable, and we no longer suffer from I2C errors when tuning. Signed-off-by: Peter Griffin peter.grif...@linaro.org --- arch/arm/boot/dts/stihxxx-b2120.dtsi | 10 --

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Hans Verkuil
On 08/26/2015 03:23 PM, Steven Toth wrote: Has anyone tested the patch and validated each of the controls continue to work? As I said: my saa7146 card is no longer recognized (not sure why), so I was hoping you could test it. OK, will do. I probably won't get to this until the weekend,

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Hans Verkuil
On 08/28/2015 09:59 AM, Hans Verkuil wrote: On 08/26/2015 03:23 PM, Steven Toth wrote: Has anyone tested the patch and validated each of the controls continue to work? As I said: my saa7146 card is no longer recognized (not sure why), so I was hoping you could test it. OK, will do. I

Re: [RFC PATCH v3 3/5] media: videobuf2: Modify all device drivers

2015-08-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Aug 2015 11:19:29 +0900 Junghak Sung jh1009.s...@samsung.com escreveu: Dear Mauro, I'm sorry but patch 3 is very incomplete. At this round, I could not modify all device drivers, because there are too many files to be changed and I should change them by hands. I just want to

Re: [PATCH v7 07/44] [media] media: use media_gobj inside links

2015-08-28 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2015 18:13:13 -0600 Shuah Khan shuahk...@gmail.com escreveu: On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Just like entities and pads, links also need to have unique Object IDs along a given media controller. So, let's add a

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Hans Verkuil
On 08/28/2015 02:44 PM, Steven Toth wrote: Send me your shipping address _privately_, I talk to Hauppauge about a replacement. No need, I managed to get it working if I use a PCI-to-PCIe adapter card. Very strange, it won't work in the PCIe slot of my motherboard, but using the PCI slot

1

2015-08-28 Thread Vicky
What time can i call you? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCHv2 3/8] saa7164: fix poll bugs

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com - poll doesn't return negative values, so you can't return -EINVAL. Instead return POLLERR. - poll can't be called if !video_is_registered(), so this test can be dropped. - poll can never do a blocking wait, so remove that check. - poll shouldn't

Re: [PATCH v7 05/44] [media] media: use media_gobj inside entities

2015-08-28 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2015 16:13:10 -0600 Shuah Khan shuahk...@gmail.com escreveu: On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: As entities are graph objects, let's embed media_gobj on it. That ensures an unique ID for entities that can be global along

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Steven Toth
but the default firmware with size 4919072 fails to work (image corrupt), instead I need to use the firmware with size 4038864 (v4l-saa7164-1.0.3-3.fw). That's v4l-saa7164-1.0.2-3.fw, sorry for the confusion. Right, you need to load the -02 firmware on a -02 board. Googling suggests that

Re: [PATCH v7 04/44] [media] media: add a common struct to be embed on media graph objects

2015-08-28 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2015 14:07:07 -0600 Shuah Khan shuahk...@gmail.com escreveu: On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Due to the MC API proposed changes, we'll need to have an unique object ID for all graph objects, and have some shared fields

[PATCHv2 4/8] saa7164: add support for control events

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Now that saa7164 uses v4l2_fh and that poll() has been fixed, it is trivial to add support for control events. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCHv2 5/8] saa7164: fix format ioctls

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Fix various v4l2-compliance issues in the formatting ioctls: - the vbi device implemented video format ioctls which make no senses for a vbi device, remove them. - remove the unused ts_packet_size and ts_packet_count fields. - fill in colorspace and

[PATCHv2 7/8] saa7164: fix input and tuner compliance problems

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com - the frequency range was never set - there was no initial frequency - missing index/tuner checks - inconsistent standard reporting - removed unnecessary tuner type checks (the core handles that) - clamp frequency to the valid frequency range as per the

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Steven Toth
Send me your shipping address _privately_, I talk to Hauppauge about a replacement. No need, I managed to get it working if I use a PCI-to-PCIe adapter card. Very strange, it won't work in the PCIe slot of my motherboard, but using the PCI slot and that adapter it works fine. Excellent.

[PATCHv2 1/8] saa7164: convert to the control framework

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Convert this driver to the control framework. Note that the VBI device nodes have no controls as there is nothing to control. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCHv2 2/8] saa7164: add v4l2_fh support

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Control events require the use of struct v4l2_fh. Add this to saa7164. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/saa7164/saa7164-encoder.c | 7 +--

[PATCHv2 0/8] saa7164: v4l2-compliance fixes

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This patch series fixes many v4l2-compliance issues in the saa7164 driver. As part of that it converts this driver to the control framework which simplifies Ricardo's Support getting default values from any control patch series. Everything has been

[PATCHv2 6/8] saa7164: remove unused videobuf references

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This driver includes videobuf headers and selects VIDEOBUF_DVB, but videobuf isn't used at all. Remove this. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Tested-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/saa7164/Kconfig | 1 -

[PATCHv2 8/8] saa7164: video and vbi ports share the same input/tuner/std

2015-08-28 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The vbi port should pass any tuner/input/standard information on to the video port since in the input and tuner are shared between the two. There is no reason to duplicate this code, just pass the ioctls on to the video encoder port. Signed-off-by: Hans

Re: [PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-28 Thread Mauro Carvalho Chehab
Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab mche...@osg.samsung.com escreveu: Em Tue, 25 Aug 2015 12:55:41 -0600 Shuah Khan shua...@osg.samsung.com escreveu: On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: Now that a link can be either between two different graph

Re: [RFC PATCH v3 2/5] media: videobuf2: Restructure vb2_buffer

2015-08-28 Thread Hans Verkuil
Hi Junghak, Thanks for this patch, it looks much better. I do have a number of comments, though... On 08/26/2015 01:59 PM, Junghak Sung wrote: Remove v4l2-specific stuff from struct vb2_buffer and add member variables related with buffer management. struct vb2_plane { snip

Re: [PATCH 1/2] [media] media-entity: unregister entity links

2015-08-28 Thread Hans Verkuil
On 08/24/2015 02:03 PM, Mauro Carvalho Chehab wrote: Add functions to explicitly unregister all entity links. This function is called automatically when an entity link is destroyed. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com

Re: [PATCH] [media] v4l2-core: create MC interfaces for devnodes

2015-08-28 Thread Hans Verkuil
On 08/24/2015 03:19 PM, Mauro Carvalho Chehab wrote: All V4L2 device nodes should create an interface, if the Media Controller support is enabled. Please notice that radio devices should not create an entity, as radio input/output is either via wires or via ALSA. Signed-off-by: Mauro

Re: [PATCH 2/2] [media] v4l2-subdev: create interfaces at MC

2015-08-28 Thread Hans Verkuil
On 08/24/2015 02:03 PM, Mauro Carvalho Chehab wrote: Now that the Media Controller has support for interfaces, create them when v4l-subdev interfaces are created. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/v4l2-core/v4l2-device.c

Re: [PATCH] saa7164: convert to the control framework

2015-08-28 Thread Steven Toth
but the default firmware with size 4919072 fails to work (image corrupt), instead I need to use the firmware with size 4038864 (v4l-saa7164-1.0.3-3.fw). For that I have to patch the driver. Take a look at your board, on the main large PCIe IC, its probably marked as either a REV2 or a

Re: [PATCH] [media] v4l2-core: create MC interfaces for devnodes

2015-08-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Aug 2015 16:24:56 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 08/24/2015 03:19 PM, Mauro Carvalho Chehab wrote: All V4L2 device nodes should create an interface, if the Media Controller support is enabled. Please notice that radio devices should not create an entity,

cron job: media_tree daily build: WARNINGS

2015-08-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 29 04:00:15 CEST 2015 git branch: test git hash: d071c833a0d30e7aae0ea565d92ef83c79106d6f gcc

Re: [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-28 Thread Peter Griffin
Hi Lee, On Fri, 28 Aug 2015, Lee Jones wrote: On Thu, 27 Aug 2015, Peter Griffin wrote: Signed-off-by: Peter Griffin peter.grif...@linaro.org --- .../devicetree/bindings/media/stih407-c8sectpfe.txt | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-)

Re: [PATCH v2 3/5] [media] c8sectpfe: Remove select on undefined LIBELF_32

2015-08-28 Thread Peter Griffin
Hi Lee, On Fri, 28 Aug 2015, Lee Jones wrote: On Thu, 27 Aug 2015, Peter Griffin wrote: LIBELF_32 is not defined in Kconfig, and is left over legacy which is not required in the upstream driver, so remove it. Signed-off-by: Peter Griffin peter.grif...@linaro.org Suggested-by:

Re: [PATCH v2 2/5] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node.

2015-08-28 Thread Peter Griffin
Hi Lee, On Fri, 28 Aug 2015, Lee Jones wrote: On Thu, 27 Aug 2015, Peter Griffin wrote: This patch adds in the required DT node for the c8sectpfe Linux DVB demux driver which allows the tsin channels to be used on an upstream kernel. Signed-off-by: Peter Griffin

[PATCH v3 1/6] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 ssc3

2015-08-28 Thread Peter Griffin
Adding these properties makes the I2C bus to the demodulators much more reliable, and we no longer suffer from I2C errors when tuning. Signed-off-by: Peter Griffin peter.grif...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/stihxxx-b2120.dtsi | 10 -- 1 file

[PATCH v3 5/6] [media] c8sectpfe: Update DT binding doc with some minor fixes

2015-08-28 Thread Peter Griffin
Signed-off-by: Peter Griffin peter.grif...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org --- .../devicetree/bindings/media/stih407-c8sectpfe.txt| 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v3 3/6] [media] c8sectpfe: Remove select on undefined LIBELF_32

2015-08-28 Thread Peter Griffin
LIBELF_32 is not defined in Kconfig, and is left over legacy which is not required in the upstream driver, so remove it. Suggested-by: Valentin Rothberg valentinrothb...@gmail.com Signed-off-by: Peter Griffin peter.grif...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org ---

[PATCH v3 2/6] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node.

2015-08-28 Thread Peter Griffin
This patch adds in the required DT node for the c8sectpfe Linux DVB demux driver which allows the tsin channels to be used on an upstream kernel. Signed-off-by: Peter Griffin peter.grif...@linaro.org --- arch/arm/boot/dts/stihxxx-b2120.dtsi | 35 +++ 1 file

[PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios

2015-08-28 Thread Peter Griffin
gpio.txt documents that GPIO properties should be named [name-]gpios, with name being the purpose of this GPIO for the device. This change has been done as one atomic commit. Signed-off-by: Peter Griffin peter.grif...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org ---

[PATCH v3 6/6] [media] c8sectpfe: Simplify for loop in load_slim_core_fw

2015-08-28 Thread Peter Griffin
Signed-off-by: Peter Griffin peter.grif...@linaro.org --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-28 Thread Johann Klammer
Pls fix this!!! Either by fixing. https://github.com/torvalds/linux/blob/master/drivers/media/dvb-frontends/stv0299.c around line 583. or https://github.com/torvalds/linux/blob/master/drivers/media/dvb-core/dvb_frontend.c line 2319 but there it's problematic coz they tried to be `smart' with

[PATCH v3 0/6] [media] c8sectpfe: Various fixups

2015-08-28 Thread Peter Griffin
Hi Mauro, This series includes a couple of fixes for the c8sectpfe Linux dvb driver. One was caused by omitting a patch from the original c8sectpfe series which defined the ssc2 and ssc3 dt nodes, which was then used by the later DT patch. This patch is included, along with the original patch