Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_net.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
index bd833b0824c6..10478ac99ffb 100644
---
As Arnd reported:
With gcc-5 or higher on x86, we can get a bogus warning in the
dvb-net code:
drivers/media/dvb-core/dvb_net.c: In function ‘dvb_net_ule’:
arch/x86/include/asm/string_32.h:77:14: error: ‘dest_addr’ may be used
uninitialized in this function
The dvb_net code has a really complex function, meant to handle
DVB network packages: it is long, has several loops and ifs
inside, and even cause warnings with gcc5.
Prepare it to be split into smaller functions by storing all
arguments and internal vars inside a struct.
Signed-off-by: Mauro
This function is too big and too complex, making really hard
to understand what's there.
Split it into sub-routines, in order to make it easier to be
understood, and to allow gcc to better parse it.
As a bonus, it gets rid of a goto in the middle of a routine.
Signed-off-by: Mauro Carvalho
Em Fri, 18 Nov 2016 22:27:42 +
Andrey Utkin escreveu:
> On Wed, Nov 16, 2016 at 02:42:40PM -0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab
> >
> > Instead of calling printk() directly, use pr_foo()
> > macros, as
Em Fri, 18 Nov 2016 22:25:32 +
Andrey Utkin escreveu:
> On Wed, Nov 16, 2016 at 02:42:41PM -0200, Mauro Carvalho Chehab wrote:
> > This driver is old, and have lots of checkpatch violations.
> > As we're touching a lot on this driver due to the printk
> >
Thanks for your hard work at beautification of this driver :)
>From reviewing the diff over v1, it looks good.
Also thanks for deep explanations you gave me for my comments.
On Sat, Nov 19, 2016 at 07:27:30PM -0200, Mauro Carvalho Chehab wrote:
>
> Suggested-by: Andrey Utkin
Hi,
The two patches fix the PM / compiler warning issues Arnd found in the
smiapp driver.
since v1:
- Use IS_ENABLED() instead of preprocessor macros.
- Add another patch to fix compiler warnings.
--
Kind regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe
Power on the sensor when the module is loaded and power it off when it is
removed.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git
The smiapp_suspend() and smiapp_resume() functions will end up being unused
if CONFIG_PM is enabled but CONFIG_PM_SLEEP is disabled, causing a
compiler warning from both of the function definitions. Fix this by
marking the functions with __maybe_unused.
Suggested-by: Arnd Bergmann
Hi Pavel,
Just a few more comments...
Please check my other review as well. I believe you may have missed the
comments in between in that one.
On Sun, Oct 23, 2016 at 10:03:55PM +0200, Pavel Machek wrote:
>
> Add driver for et8ek8 sensor, found in Nokia N900 main camera. Can be
> used for
> Rather than beating our heads against the wall trying to convert between
> various image formats, maybe we need to take a step back. We're trying
> to build better documentation, and there is certainly a place for
> diagrams and such in that documentation. Johannes was asking about it
> for
On Sat, 2016-11-19 at 10:15 -0700, Jonathan Corbet wrote:
> Might there be a tool or an extension out there that
> would allow us to express these diagrams in a text-friendly, editable
> form?
I know it's unfashionable these days, but TeX always used to be bloody
good at that kind of thing.
--
Em Sat, 19 Nov 2016 10:15:43 -0700
Jonathan Corbet escreveu:
> On Thu, 17 Nov 2016 08:02:50 -0800
> Linus Torvalds wrote:
>
> > We have makefiles, but more importantly, few enough people actually
> > *generate* the documentation, that I think if
Em Sat, 19 Nov 2016 19:18:39 -0200
Mauro Carvalho Chehab escreveu:
> Em Sat, 19 Nov 2016 19:58:50 +
> Andrey Utkin escreveu:
>
> > This is from checkpatch run on cx88 source files with "-f", not your
> > patch files, right? I guess it
On 11/19/16 09:15, Jonathan Corbet wrote:
> Might there be a tool or an extension out there that would allow us
> to express these diagrams in a text-friendly, editable form?
How about using the graphviz languages for generating diagrams that can
be described easily in one of the graphviz
This is from checkpatch run on cx88 source files with "-f", not your
patch files, right? I guess it might produce less changes if run on
patches.
On Sat, Nov 19, 2016 at 10:14:05AM -0200, Mauro Carvalho Chehab wrote:
> Usually, I don't like fixing coding style issues on non-staging
> drivers, as
On Sat, Nov 19, 2016 at 9:55 AM, David Woodhouse wrote:
>
> I know it's unfashionable these days, but TeX always used to be bloody
> good at that kind of thing.
You must have used a different TeX than I did.
TeX is a horrible example. The moment you needed to insert
Em Sat, 19 Nov 2016 19:58:50 +
Andrey Utkin escreveu:
> This is from checkpatch run on cx88 source files with "-f", not your
> patch files, right? I guess it might produce less changes if run on
> patches.
Yes, I know.
> On Sat, Nov 19, 2016 at 10:14:05AM -0200,
On Thu, 17 Nov 2016 08:02:50 -0800
Linus Torvalds wrote:
> We have makefiles, but more importantly, few enough people actually
> *generate* the documentation, that I think if it's an option to just
> fix sphinx, we should do that instead. If it means that you have
On Sat, Nov 19, 2016 at 12:54 PM, Mauro Carvalho Chehab
wrote:
>
> I did some research on Friday trying to identify where those images
> came. It turns that, for the oldest images (before I took the media
> maintainership), PDF were actually their "source", as far as I
> On Sat, Nov 19, 2016 at 9:55 AM, David Woodhouse
> wrote:
>>
>> I know it's unfashionable these days, but TeX always used to be bloody
>> good at that kind of thing.
>
> You must have used a different TeX than I did.
>
> TeX is a horrible example. The moment you needed to
I have important transaction for you as next of kin to claim US$18.37m Mail me
on my private email: chimwia...@gmail.com
so I can send you more details
Thanks
Mr.Chim Wai Kim
MOVE TO INBOX===
DISCLAIMER: This email and any files it contains are confidential
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Nov 20 05:00:15 CET 2016
media-tree git hash:f2709c206d8a3e11729e68d80c57e7470bbe8e5e
media_build
24 matches
Mail list logo