Re: [PATCH v3] media: i2c-polling: add i2c-polling driver

On Wed, Nov 23, 2016 at 10:31 PM, Matt Ranostay wrote: > On Wed, Nov 23, 2016 at 8:30 AM, Laurent Pinchart > wrote: >> Hi Matt, >> >> Thank you for the patch. >> >> On Tuesday 22 Nov 2016 17:18:40 Matt Ranostay wrote: >>> There are

Re: [PATCH] [media] ti-vpe: get rid of some smatch warnings

Hi, On 22/11/16 13:09, Mauro Carvalho Chehab wrote: > When compiled on i386, it produces several warnings: > > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an > lvalue > ./arch/x86/include/asm/bitops.h:457:22: warning: asm output is not an > lvalue >

Re: [PATCH v4l-utils v7 0/7] Add a plugin for Exynos4 camera

Em Thu, 24 Nov 2016 09:10:28 +0100 Jacek Anaszewski escreveu: > On 11/23/2016 10:51 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 03 Nov 2016 13:13:12 +0100 > > Jacek Anaszewski escreveu: > > > >> Hi Hans, > >> > >> On 11/03/2016 12:51 PM,

Re: [PATCH v4l-utils v7 0/7] Add a plugin for Exynos4 camera

On 11/23/2016 10:51 PM, Mauro Carvalho Chehab wrote: Em Thu, 03 Nov 2016 13:13:12 +0100 Jacek Anaszewski escreveu: Hi Hans, On 11/03/2016 12:51 PM, Hans Verkuil wrote: Hi all, Is there anything that blocks me from merging this? This plugin work has been ongoing

Re: Enabling peer to peer device transactions for PCIe devices

Am 24.11.2016 um 00:25 schrieb Jason Gunthorpe: There is certainly nothing about the hardware that cares about ZONE_DEVICE vs System memory. Well that is clearly not so simple. When your ZONE_DEVICE pages describe a PCI BAR and another PCI device initiates a DMA to this address the DMA

Re: [PATCH v4l-utils v7 7/7] Add a libv4l plugin for Exynos4 camera

Hi Jacek, On Thu, Nov 24, 2016 at 05:14:40PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > On 11/24/2016 04:11 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thank you for your continued work on the Exynos plugin patchset! > > > >I think we're pretty close to being able to merge the set, if you

[PATCH] Media: Platform: Exynos4-is: - Fix for error handling

The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(>fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos4-is/fimc-m2m.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Media: Platform: Exynos-gsc: - Fix for error handling

The File handle is not yet added in the vfd list.So no need to call v4l2_fh_del(>fh) if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/exynos-gsc/gsc-m2m.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 25 05:00:20 CET 2016 media-tree git hash:4cc5bed1caeb6d40f2f41c4c5eb83368691fbffb media_build

[PATCH] Media: platform: vsp1: - Do not forget to call

v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition before returing from the function. Signed-off-by: Shailendra Verma --- drivers/media/platform/vsp1/vsp1_video.c |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] Staging: media: platform: davinci: - Fix for memory leak

Fix to avoid possible memory leak if the decoder initialization got failed. Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/media/platform/davinci/vpfe_capture.c |2 ++

Re: [PATCH 1/1] smiapp: Implement power-on and power-off sequences without runtime PM

Hello, (CC'ing the linux-pm mailing list) On Tuesday 22 Nov 2016 21:58:32 Arnd Bergmann wrote: > On Tuesday, November 22, 2016 8:31:42 PM CET Laurent Pinchart wrote: > >>> @@ -2915,7 +2906,11 @@ static int smiapp_probe(struct i2c_client > >>> *client, > >>> > >>> pm_runtime_enable(>dev); >

[PATCH] Media: Platform: Sti: Bdisp: - Fix for error handling

The File handle is not yet added in the vdev list.So no need to call v4l2_fh_del(>fh)if it fails to create control. Signed-off-by: Shailendra Verma --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/1] media: Drop FSF's postal address from the source code files

Hi Sakari, Thank you for the patch. On Friday 28 Oct 2016 15:43:53 Sakari Ailus wrote: > Drop the FSF's postal address from the source code files that typically > contain mostly the license text. The patch has been created with the > following command without manual edits: > > git grep -l "675

[PATCH] Media: Platform: Omap3isp: Do not forget to call

v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition before returing from the function. Signed-off-by: Shailendra Verma --- drivers/media/platform/omap3isp/ispvideo.c |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] Staging: Media: Omap4iss: Do not forget to call

v4l2_fh_init is already done.So call the v4l2_fh_exit in error condition before returing from the function. Signed-off-by: Shailendra Verma --- drivers/staging/media/omap4iss/iss_video.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] v4l: vsp1: Prevent commencing pipelines before they are setup

Hi Kieran, On Wednesday 23 Nov 2016 12:28:15 Kieran Bingham wrote: > Just FYI, > > Whilst this patch is functional on its own, it is likely to be > superseded before it gets a chance to be integrated as I am currently > reworking vsp1_video_start_streaming(), in particular the use of >

Re: [PATCH 1/1] smiapp: Implement power-on and power-off sequences without runtime PM

On Fri, 25 Nov 2016, Laurent Pinchart wrote: > Dear linux-pm developers, what's the suggested way to ensure that a runtime- > pm-enabled driver can run fine on a system with CONFIG_PM disabled ? The exact point of your question isn't entirely clear. In the most literal sense, the best ways to

[PATCH] Staging: media: davinci_vpfe: - Fix for memory leak if decoder initialization fails.

Fix to avoid possible memory leak if the decoder initialization got failed.Free the allocated memory for file handle object before return in case decoder initialization fails. Signed-off-by: Shailendra Verma --- drivers/staging/media/davinci_vpfe/vpfe_video.c |3

Re: [PATCH 3/3] [media] ivtv: mark DVB "borrowed" ioctls as deprecated

On 11/24/16 12:01, Mauro Carvalho Chehab wrote: changeset da8ec560e3b4 ("[media] ivtv: implement new decoder command ioctls") implemented proper support for mpeg audio and video control at V4L2 API. Since then, the usage of the the DVB APIs is deprecated. However, we never actually marked it as

Re: [PATCH 1/3] [media] ivtv: prepare to convert to pr_foo()

On 11/24/16 12:01, Mauro Carvalho Chehab wrote: Move the pr_fmt() macro to ivtv_driver.h and ensure that it will be the first file to be included on all ivtv files. While here, put the includes inside ivtv-driver.h on alphabetic order. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: > Add helper functions that allow for easy instantiation of media_device > object basing on whether the media device contains v4l2 subdev with > given file descriptor. Doesn't this work with

Re: [PATCH 2/3] [media] ivtv: use pr_foo() instead of calling printk() directly

On 11/24/16 12:01, Mauro Carvalho Chehab wrote: pr_foo() provides a convenient way for printk's, enforcing that they'll all prepend the error message with the driver's name. Use it inside ivtv. Signed-off-by: Mauro Carvalho Chehab ---

Re: ir-keytable: infinite loops, segfaults

On Wed, Nov 23, 2016 at 10:34:19PM +, Sean Young wrote: > > Not sure why Driver is (null), dvb_usb_cxusb is loaded. > > That's a mistake, I've fixed that now. Ah. I see the added module_name struct members. > > I tried -t and it generated events constantly, before I could press > > any

Re: [PATCH v2 2/3] [media] ivtv: use pr_foo() instead of calling printk() directly

On 11/24/16 12:52, Mauro Carvalho Chehab wrote: pr_foo() provides a convenient way for printk's, enforcing that they'll all prepend the error message with the driver's name. Use it inside ivtv. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil

[PATCH v2 1/3] [media] ivtv: prepare to convert to pr_foo()

Move the pr_fmt() macro to ivtv_driver.h and ensure that it will be the first file to be included on all ivtv files. While here, put the includes inside ivtv-driver.h on alphabetic order. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 3/3] [media] ivtv: mark DVB "borrowed" ioctls as deprecated

changeset da8ec560e3b4 ("[media] ivtv: implement new decoder command ioctls") implemented proper support for mpeg audio and video control at V4L2 API. Since then, the usage of the the DVB APIs is deprecated. However, we never actually marked it as deprecated nor provided any way to disable it.

[PATCH v2 2/3] [media] ivtv: use pr_foo() instead of calling printk() directly

pr_foo() provides a convenient way for printk's, enforcing that they'll all prepend the error message with the driver's name. Use it inside ivtv. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ivtv/ivtv-alsa-main.c | 11 +--

Re: [PATCH v4l-utils v7 0/7] Add a plugin for Exynos4 camera

On 11/24/2016 10:10 AM, Mauro Carvalho Chehab wrote: Em Thu, 24 Nov 2016 09:10:28 +0100 Jacek Anaszewski escreveu: On 11/23/2016 10:51 PM, Mauro Carvalho Chehab wrote: Em Thu, 03 Nov 2016 13:13:12 +0100 Jacek Anaszewski escreveu: Hi

Re: [PATCH v4l-utils v7 5/7] mediactl: libv4l2subdev: Add colorspace logging

Hi Jacek, On Wed, Oct 12, 2016 at 04:35:20PM +0200, Jacek Anaszewski wrote: > Add a function for obtaining colorspace name by id. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > --- > utils/media-ctl/libv4l2subdev.c | 32

[PATCH 2/3] [media] ivtv: use pr_foo() instead of calling printk() directly

pr_foo() provides a convenient way for printk's, enforcing that they'll all prepend the error message with the driver's name. Use it inside ivtv. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ivtv/ivtv-alsa-main.c | 11 +--

[PATCH 1/3] [media] ivtv: prepare to convert to pr_foo()

Move the pr_fmt() macro to ivtv_driver.h and ensure that it will be the first file to be included on all ivtv files. While here, put the includes inside ivtv-driver.h on alphabetic order. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ivtv/ivtv-alsa-main.c

[PATCH 3/3] [media] ivtv: mark DVB "borrowed" ioctls as deprecated

changeset da8ec560e3b4 ("[media] ivtv: implement new decoder command ioctls") implemented proper support for mpeg audio and video control at V4L2 API. Since then, the usage of the the DVB APIs is deprecated. However, we never actually marked it as deprecated nor provided any way to disable it.

Re: [PATCH v4l-utils v7 3/7] mediactl: Add media_entity_get_backlinks()

Hi Jacek, On Wed, Oct 12, 2016 at 04:35:18PM +0200, Jacek Anaszewski wrote: > Add a new graph helper useful for discovering video pipeline. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > --- > utils/media-ctl/libmediactl.c

Re: [PATCH 1/1] smiapp: Implement power-on and power-off sequences without runtime PM

Hi Alan and others, On Thu, Nov 24, 2016 at 09:15:39PM -0500, Alan Stern wrote: > On Fri, 25 Nov 2016, Laurent Pinchart wrote: > > > Dear linux-pm developers, what's the suggested way to ensure that a runtime- > > pm-enabled driver can run fine on a system with CONFIG_PM disabled ? > > The

Re: [PATCH 1/1] media: Drop FSF's postal address from the source code files

Hi Laurent, On 11/25/16 04:03, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday 28 Oct 2016 15:43:53 Sakari Ailus wrote: >> Drop the FSF's postal address from the source code files that typically >> contain mostly the license text. The patch has been created with

Re: [PATCH v4l-utils v7 1/7] mediactl: Add support for v4l2-ctrl-binding config

Hi Jacek, On Wed, Oct 12, 2016 at 04:35:16PM +0200, Jacek Anaszewski wrote: > Make struct v4l2_subdev capable of aggregating v4l2-ctrl-bindings - > media device configuration entries. Added are also functions for > validating support for the control on given media entity and checking > whether a

Re: [PATCH v4l-utils v7 3/7] mediactl: Add media_entity_get_backlinks()

Hi Jacek, On Thu, Nov 24, 2016 at 03:00:46PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the review. It's taken way too long. :-( My apologies for that. > On 11/24/2016 01:40 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >On Wed, Oct 12, 2016 at 04:35:18PM +0200, Jacek Anaszewski

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

Hi Jacek, On Thu, Nov 24, 2016 at 02:50:39PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the review. > > On 11/24/2016 01:17 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thanks for the patchset. > > > >On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: > >>Add

Re: [PATCH v4l-utils v7 3/7] mediactl: Add media_entity_get_backlinks()

Hi Sakari, Thanks for the review. On 11/24/2016 01:40 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Oct 12, 2016 at 04:35:18PM +0200, Jacek Anaszewski wrote: Add a new graph helper useful for discovering video pipeline. Signed-off-by: Jacek Anaszewski Acked-by:

Re: [PATCH v4l-utils v7 6/7] mediactl: libv4l2subdev: add support for comparing mbus formats

Hi Jacek, On Wed, Oct 12, 2016 at 04:35:21PM +0200, Jacek Anaszewski wrote: > This patch adds a function for checking whether two mbus formats > are compatible. Compatible doesn't in general case mean the same as... the same. On parallel busses a 10-bit source can be connected to an 8-bit

Re: [PATCH v4l-utils v7 2/7] mediatext: Add library

Hi Jacek, On Wed, Oct 12, 2016 at 04:35:17PM +0200, Jacek Anaszewski wrote: > libmediatext is a helper library for converting configurations (Media > controller links, V4L2 controls and V4L2 sub-device media bus formats and > selections) from text-based form into IOCTLs. > > libmediatext depends

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

Hi Nicolas, On 11/23/2016 10:24 PM, Nicolas Dufresne wrote: > Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : Meanwhile I have found bigger obstacle - I cannot run multiple >> instances simultaneously. By m2m design it can execute only one job (m2m >> context)

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

Hi Sakari, Thanks for the review. On 11/24/2016 01:17 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: Add helper functions that allow for easy instantiation of media_device object basing on whether the media device

Re: ir-keytable: infinite loops, segfaults

On Thu, Nov 24, 2016 at 11:12:57PM +1100, Vincent McIntyre wrote: > On Wed, Nov 23, 2016 at 10:34:19PM +, Sean Young wrote: > > > Not sure why Driver is (null), dvb_usb_cxusb is loaded. > > > > That's a mistake, I've fixed that now. > > Ah. I see the added module_name struct members. > > >

Re: [PATCH v4l-utils v7 2/7] mediatext: Add library

Hi Sakari, On 11/24/2016 02:01 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Oct 12, 2016 at 04:35:17PM +0200, Jacek Anaszewski wrote: libmediatext is a helper library for converting configurations (Media controller links, V4L2 controls and V4L2 sub-device media bus formats and selections) from

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

On 11/24/2016 03:32 PM, Sakari Ailus wrote: [...] + sprintf(device_dir_path, "/sys/class/video4linux/%s/device/", p + 1); + + device_dir = opendir(device_dir_path); + if (device_dir == NULL) + return NULL; + + while ((entry = readdir(device_dir))) { +

Re: [PATCH v4l-utils v7 6/7] mediactl: libv4l2subdev: add support for comparing mbus formats

On 11/24/2016 03:36 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Oct 12, 2016 at 04:35:21PM +0200, Jacek Anaszewski wrote: This patch adds a function for checking whether two mbus formats are compatible. Compatible doesn't in general case mean the same as... the same. On parallel busses a

Re: [PATCH v4l-utils v7 7/7] Add a libv4l plugin for Exynos4 camera

Hi Jacek, Thank you for your continued work on the Exynos plugin patchset! I think we're pretty close to being able to merge the set, if you could still bear with me awhile. :-) On Wed, Oct 12, 2016 at 04:35:22PM +0200, Jacek Anaszewski wrote: ... > diff --git

Re: [PATCH v3] media: i2c-polling: add i2c-polling driver

Hi Matt, On Thursday 24 Nov 2016 00:04:24 Matt Ranostay wrote: > On Wed, Nov 23, 2016 at 10:31 PM, Matt Ranostay wrote: > > On Wed, Nov 23, 2016 at 8:30 AM, Laurent Pinchart wrote: > >> On Tuesday 22 Nov 2016 17:18:40 Matt Ranostay wrote: > >>> There are several thermal sensors that only have a

Re: [PATCH v4l-utils v7 7/7] Add a libv4l plugin for Exynos4 camera

Hi Sakari, On 11/24/2016 04:11 PM, Sakari Ailus wrote: Hi Jacek, Thank you for your continued work on the Exynos plugin patchset! I think we're pretty close to being able to merge the set, if you could still bear with me awhile. :-) Your demanding reviewer I must admit. :-) Of course, I

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Nov 24, 2016 at 12:40:37AM +, Sagalovitch, Serguei wrote: > On Wed, Nov 23, 2016 at 02:11:29PM -0700, Logan Gunthorpe wrote: > > > Perhaps I am not following what Serguei is asking for, but I > > understood the desire was for a complex GPU allocator that could > > migrate pages

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Nov 24, 2016 at 10:45:18AM +0100, Christian König wrote: > Am 24.11.2016 um 00:25 schrieb Jason Gunthorpe: > >There is certainly nothing about the hardware that cares > >about ZONE_DEVICE vs System memory. > Well that is clearly not so simple. When your ZONE_DEVICE pages describe a > PCI

[PATCH] [media] b2c2: use IS_REACHABLE() instead of open-coding it

The FE_SUPPORTED() macro is basically the same as IS_REACHABLE, except that it causes a warning with gcc-7: common/b2c2/flexcop-fe-tuner.c:30:1: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] common/b2c2/flexcop-fe-tuner.c:30:1: error: this use of "defined" may

Re: Enabling peer to peer device transactions for PCIe devices

On Wed, Nov 23, 2016 at 06:25:21PM -0700, Logan Gunthorpe wrote: > > > On 23/11/16 02:55 PM, Jason Gunthorpe wrote: > >>> Only ODP hardware allows changing the DMA address on the fly, and it > >>> works at the page table level. We do not need special handling for > >>> RDMA. > >> > >> I am aware

Re: Enabling peer to peer device transactions for PCIe devices

On 2016-11-24 11:26 AM, Jason Gunthorpe wrote: On Thu, Nov 24, 2016 at 10:45:18AM +0100, Christian König wrote: Am 24.11.2016 um 00:25 schrieb Jason Gunthorpe: There is certainly nothing about the hardware that cares about ZONE_DEVICE vs System memory. Well that is clearly not so simple.

Re: Enabling peer to peer device transactions for PCIe devices

Hey, On 24/11/16 02:45 AM, Christian König wrote: > E.g. it can happen that PCI device A exports it's BAR using ZONE_DEVICE. > Not PCI device B (a SATA device) can directly read/write to it because > it is on the same bus segment, but PCI device C (a network card for > example) can't because it

Problem with media_build install

#make install make -C /usr/src/media_build/v4l install make[1]: Entering directory '/usr/src/media_build/v4l' make[1]: *** No rule to make target 'mm-install' needed by 'install'. Alto. make[1]: Leaving directory '/usr/src/media_build/v4l' Makefile:15: recipe for target 'install' failed make: ***

Re: Enabling peer to peer device transactions for PCIe devices

On 24/11/16 09:42 AM, Jason Gunthorpe wrote: > There are three cases to worry about: > - Coherent long lived page table mirroring (RDMA ODP MR) > - Non-coherent long lived page table mirroring (RDMA MR) > - Short lived DMA mapping (everything else) > > Like you say below we have to handle