[PATCHv4 1/9] video: add hotplug detect notifier support

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil Add support for video hotplug detect and EDID/ELD notifiers, which is used to convey information from video drivers to their CEC and audio counterparts. Based on an earlier version from Russell King: https://patchwork.kernel.org/patch/9277043/ The

[PATCHv4 7/9] sti: hdmi: add HPD notifier support

2017-02-06 Thread Hans Verkuil
From: Benjamin Gaignard Implement the HPD notifier support to allow CEC drivers to be informed when there is a new EDID and when a connect or disconnect happens. Signed-off-by: Benjamin Gaignard Signed-off-by: Hans Verkuil

[PATCHv4 8/9] stih-cec: add HPD notifier support

2017-02-06 Thread Hans Verkuil
From: Benjamin Gaignard By using the HPD notifier framework there is no longer any reason to manually set the physical address. This was the one blocking issue that prevented this driver from going out of staging, so do this move as well. Update the bindings

[PATCHv4 4/9] ARM: dts: exynos: add HDMI controller phandle to exynos4.dtsi

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil Add the new hdmi phandle to exynos4.dtsi. This phandle is needed by the s5p-cec driver to initialize the HPD notifier framework. Tested with my Odroid U3. Signed-off-by: Hans Verkuil Tested-by: Marek Szyprowski

[PATCHv4 5/9] s5p-cec.txt: document the HDMI controller phandle

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil Update the bindings documenting the new hdmi phandle. Signed-off-by: Hans Verkuil CC: linux-samsung-...@vger.kernel.org CC: devicet...@vger.kernel.org CC: Krzysztof Kozlowski ---

[PATCHv4 3/9] cec: integrate HPD notifier support

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil Support the HPD notifier framework, simplifying drivers that depend on this. Signed-off-by: Hans Verkuil Tested-by: Marek Szyprowski --- drivers/media/cec/cec-core.c | 50

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Hans Verkuil
On 01/27/2017 10:54 PM, Eric Anholt wrote: > - Supports raw YUV capture, preview, JPEG and H264. > - Uses videobuf2 for data transfer, using dma_buf. > - Uses 3.6.10 timestamping > - Camera power based on use > - Uses immutable input mode on video encoder > > This code comes from the Raspberry Pi

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. On 01/27/2017 10:54 PM, Eric Anholt wrote: - Supports raw YUV capture, preview, JPEG and H264. - Uses

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Mauro Carvalho Chehab
Em Sun, 5 Feb 2017 22:15:21 + Dave Stevenson escreveu: > Hi Mauro. > > I'm going to stick my head above the parapet as one of the original > authors back when I worked at Broadcom. > As it happens I started working at Raspberry Pi last Monday, so

Re: [PATCH RESEND v7 2/2] Add support for OV5647 sensor.

2017-02-06 Thread Ramiro Oliveira
Hi Sakari, Thank you for your feedback. On 2/3/2017 8:17 PM, Sakari Ailus wrote: > Hi Ramiro, > > Thanks for the update! > > Please see some comments below... some streaming and hardware control > related matters I missed earlier. > > On Fri, Feb 03, 2017 at 06:18:33PM +, Ramiro Oliveira

[PATCHv4 9/9] arm: sti: update sti-cec for HPD notifier support

2017-02-06 Thread Hans Verkuil
From: Benjamin Gaignard To use HPD notifier sti CEC driver needs to get phandle of the hdmi device. Signed-off-by: Benjamin Gaignard Signed-off-by: Hans Verkuil CC: devicet...@vger.kernel.org ---

Re: [PATCHv2 08/16] atmel-isi: document device tree bindings

2017-02-06 Thread Hans Verkuil
On 02/01/2017 05:50 PM, Rob Herring wrote: > On Mon, Jan 30, 2017 at 03:06:20PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document the device tree bindings for this driver. > > Bindings document h/w not drivers. Fixed. > >> >> Mostly copied from the

Re: [PATCH v3 12/24] add mux and video interface bridge entity functions

2017-02-06 Thread Philipp Zabel
On Sun, 2017-02-05 at 17:36 +0200, Laurent Pinchart wrote: > Hi Steve, > > Thank you for the patch > > On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > --- > >

Re: [PATCHv2 10/16] ov2640: enable clock and fix power/reset

2017-02-06 Thread Hans Verkuil
On 01/31/2017 11:20 AM, Sakari Ailus wrote: > Hi Hans, > > Thank you for the patchset! > > On Mon, Jan 30, 2017 at 03:06:22PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Convert v4l2_clk to normal clk, enable the clock and fix the power/reset >> handling. >>

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Hans Verkuil
On 02/06/2017 12:37 PM, Dave Stevenson wrote: > Hi Hans. > > On 06/02/17 09:08, Hans Verkuil wrote: >> Hi Eric, >> >> Great to see this driver appearing for upstream merging! >> >> See below for my review comments, focusing mostly on V4L2 specifics. >> >> On 01/27/2017 10:54 PM, Eric Anholt

Re: [PATCHv2 08/16] atmel-isi: document device tree bindings

2017-02-06 Thread Hans Verkuil
On 01/31/2017 08:30 AM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Jan 30, 2017 at 03:06:20PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document the device tree bindings for this driver. >> >> Mostly copied from the atmel-isc bindings. >> >> Signed-off-by:

[PATCHv4 0/9] video/exynos/sti/cec: add HPD state notifier & use in drivers

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil This patch series adds the hotplug detect notifier code, based on Russell's code: https://patchwork.kernel.org/patch/9277043/ It adds support for it to the exynos_hdmi drm driver, adds support for it to the CEC framework and finally adds support to

[PATCHv4 6/9] s5p-cec: add hpd-notifier support, move out of staging

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil By using the HPD notifier framework there is no longer any reason to manually set the physical address. This was the one blocking issue that prevented this driver from going out of staging, so do this move as well. Update the bindings documenting the

[PATCHv4 2/9] exynos_hdmi: add HPD notifier support

2017-02-06 Thread Hans Verkuil
From: Hans Verkuil Implement the HPD notifier support to allow CEC drivers to be informed when there is a new EDID and when a connect or disconnect happens. Signed-off-by: Hans Verkuil Tested-by: Marek Szyprowski ---

Re: [PATCHv4 1/9] video: add hotplug detect notifier support

2017-02-06 Thread Andrzej Hajda
On 06.02.2017 11:29, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for video hotplug detect and EDID/ELD notifiers, which is used > to convey information from video drivers to their CEC and audio counterparts. > > Based on an earlier version from Russell King: >

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-02-06 Thread Steve Longerbeam
On 02/02/2017 02:35 PM, Russell King - ARM Linux wrote: However, "*vfd" contains a struct device, and you _correctly_ set the release function for "*vfd" to video_device_release via camif_videodev. However, if you try to rmmod imx-media, then you end up with a kernel warning that you're

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-02-06 Thread Steve Longerbeam
On 02/02/2017 02:50 PM, Russell King - ARM Linux wrote: On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: +/* register an internal subdev as a platform device */ +static struct imx_media_subdev * +add_internal_subdev(struct imx_media_dev *imxmd, + const

cron job: media_tree daily build: WARNINGS

2017-02-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 7 05:00:21 CET 2017 media-tree git hash:47b037a0512d9f8675ec2693bed46c8ea6a884ab media_build

[PATCH] [media] mtk-vcodec: fix build errors without DEBUG

2017-02-06 Thread Minghsiu Tsai
Fix build errors after removing DEBUG definition. Signed-off-by: Minghsiu Tsai --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 9 - drivers/media/platform/mtk-vcodec/vdec_vpu_if.c| 5 ++--- drivers/media/platform/mtk-vcodec/venc_vpu_if.c| 4

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Hans Verkuil
On 02/06/2017 04:21 PM, Dave Stevenson wrote: > Hi Hans. > > On 06/02/17 12:58, Hans Verkuil wrote: >> On 02/06/2017 12:37 PM, Dave Stevenson wrote: >>> Hi Hans. >>> >>> On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging!

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Mauro. Can I just say that I'm not attempting to upstream this, others are. I've just answered questions raised. On 06/02/17 12:37, Mauro Carvalho Chehab wrote: Em Sun, 5 Feb 2017 22:15:21 + Dave Stevenson escreveu: If the goal was to

Re: [PATCH 10/11] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-02-06 Thread Andrzej Hajda
Hi Smitha, I have no big experience with HEVC, so it is hard to review it appropriately but I will try do my best. As these control names goes to user space you should be very careful about it. I guess it could be good to compare these controls with other HEVC encoders including software ones

[GIT PULL for v4.10] CEC fixes

2017-02-06 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.10-3 For a few documentation fixes at CEC (with got promoted from staging for 4.10), and one fix on its core. Thanks! Mauro - The following changes since commit

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Dave Stevenson
Hi Hans. On 06/02/17 12:58, Hans Verkuil wrote: On 02/06/2017 12:37 PM, Dave Stevenson wrote: Hi Hans. On 06/02/17 09:08, Hans Verkuil wrote: Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. +

[PATCH v2] Staging: omap4iss: Fix coding style issues

2017-02-06 Thread Avraham Shukron
Fixes line-over-80-characters issues as well as multiline comments style. Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 41 -- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git

V4L board mis-identified, Tuner is TDA18271HD not s921

2017-02-06 Thread Matthew Hughes
Plugged in a USB ATSC tuner, has an em28xx bridge along with both a NXP TDA18271HDC2 and a Trident DRX3933J_B2... stenciled on the board is EzTV306_1.2 It however registered as a DVB device with a sharp s921 tuner. [ 208.072748] usb 4-1.3: new high-speed USB device number 3 using ehci-pci [

Re: [PATCHv2 08/16] atmel-isi: document device tree bindings

2017-02-06 Thread Rob Herring
On Mon, Feb 6, 2017 at 6:20 AM, Hans Verkuil wrote: > On 02/01/2017 05:50 PM, Rob Herring wrote: >> On Mon, Jan 30, 2017 at 03:06:20PM +0100, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Document the device tree bindings for this driver. >>>

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-06 Thread Steve Longerbeam
On 02/06/2017 02:33 PM, Laurent Pinchart wrote: Hi Hans, (CC'ing Sakari) On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote: On 02/05/2017 04:48 PM, Laurent Pinchart wrote: On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: On 01/24/2017 04:02 AM, Philipp Zabel wrote: On Fri,

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-06 Thread Laurent Pinchart
Hi Hans, (CC'ing Sakari) On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote: > On 02/05/2017 04:48 PM, Laurent Pinchart wrote: > > On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: > >> On 01/24/2017 04:02 AM, Philipp Zabel wrote: > >>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote:

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Greg Kroah-Hartman
On Sun, Feb 05, 2017 at 10:15:21PM +, Dave Stevenson wrote: > Newbie question: if this has already been merged to staging, where am I > looking for the relevant tree to add patches on top of? > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git branch > staging-next? Yes, that

Re: [PATCH 03/11] [media] s5p-mfc: Use min scratch buffer size

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 08:16 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > After MFC v8.0, mfc f/w lets the driver know how much scratch buffer > > size is required for decoder. If mfc f/w has the functionality, > > E_MIN_SCRATCH_BUFFER_SIZE, driver can know how

Re: [PATCH 09/11] [media] s5p-mfc: Add support for HEVC encoder

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 09:55 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add HEVC encoder support and necessary registers, V4L2 CIDs, > > and hevc encoder parameters > > > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [PATCH 05/11] [media] s5p-mfc: Add support for HEVC decoder

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 08:58 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add support for codec definition and corresponding buffer > > requirements for HEVC decoder. > > > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [PATCH 05/11] [media] s5p-mfc: Add support for HEVC decoder

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 09:20 +0100, Andrzej Hajda wrote: > On 02.02.2017 08:58, Andrzej Hajda wrote: > > On 18.01.2017 11:02, Smitha T Murthy wrote: > >> Add support for codec definition and corresponding buffer > >> requirements for HEVC decoder. > >> > >> Signed-off-by: Smitha T Murthy

Re: [PATCH 02/11] [media] s5p-mfc: Adding initial support for MFC v10.10

2017-02-06 Thread Smitha T Murthy
On Sat, 2017-01-21 at 14:28 -0600, Rob Herring wrote: > On Wed, Jan 18, 2017 at 03:32:00PM +0530, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > CC: Rob Herring

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Hans Verkuil
Hi Eric, Great to see this driver appearing for upstream merging! See below for my review comments, focusing mostly on V4L2 specifics. On 01/27/2017 10:54 PM, Eric Anholt wrote: > - Supports raw YUV capture, preview, JPEG and H264. > - Uses videobuf2 for data transfer, using dma_buf. > - Uses

Re: [PATCH 06/11] [media] videodev2.h: Add v4l2 definition for HEVC

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 09:34 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > Beside small nitpick. > > Reviewed-by: Andrzej Hajda > >

Re: [PATCH 08/11] [media] s5p-mfc: Add VP9 decoder support

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 09:39 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add support for codec definition and corresponding buffer > > requirements for VP9 decoder. > > > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [PATCH 04/11] [media] s5p-mfc: Support MFCv10.10 buffer requirements

2017-02-06 Thread Smitha T Murthy
On Thu, 2017-02-02 at 09:30 +0100, Andrzej Hajda wrote: > Hi Smitha, > > Ups, I have missed this patch, I hope it wont influence the review :) > > > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > > for MFCv10.10. > > >

[PATCH] media: add operation to get configuration of "the other side" of the link

2017-02-06 Thread Pavel Machek
Normally, link configuration can be determined at probe time... but Nokia N900 has two cameras, and can switch between them at runtime, so that mechanism is not suitable here. Add a hook that tells us link configuration. Signed-off-by: Pavel Machek diff --git

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-06 Thread Hans Verkuil
On 02/05/2017 04:48 PM, Laurent Pinchart wrote: > Hi Steve, > > On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: >> On 01/24/2017 04:02 AM, Philipp Zabel wrote: >>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > + > +int vidsw_g_mbus_config(struct v4l2_subdev *sd, struct

Re: [PATCHv2] dt: bindings: Add support for CSI1 bus

2017-02-06 Thread Pavel Machek
From: Sakari Ailus In the vast majority of cases the bus type is known to the driver(s) since a receiver or transmitter can only support a single one. There are cases however where different options are possible. The existing V4L2 OF support tries to figure out the bus type

Re: [PATCHv2] dt: bindings: Add support for CSI1 bus

2017-02-06 Thread Pavel Machek
Hi! > > - bus-type: data bus type. Possible values are: > > - 0 - MIPI CSI2 > > - 1 - parallel / Bt656 > > - 2 - MIPI CSI1 > > - 3 - CCP2 > > + 0 - autodetect based on other properties (MIPI CSI2, parallel, Bt656) > > In the meantime, I also realised that we need to separate MIPI C-PHY and