Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: > On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > > @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) > > case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP:return "VPX > > P-Frame QP Value"; > > case

Re: [PATCH v2 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:03 Sakari Ailus wrote: > Pass the more generic fwnode_handle to the init function than the > device_node. > > Signed-off-by: Sakari Ailus > --- > drivers/leds/leds-aat1290.c| 5

RE: [PATCH 2/5] media: Add support for CXD2880 SPI I/F

Dear All Our patches consists of the following items. [PATCH 1/5] dt-bindings: media: Add document file for CXD2880 SPI I/F [PATCH 2/5] media: Add support for CXD2880 SPI I/F [PATCH 3/5] media: Add suppurt for CXD2880 [PATCH 4/5] media: Add suppurt for CXD2880 DVB-T2/T functions [PATCH

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On Thu, 2017-04-06 at 15:33 +0200, Hans Verkuil wrote: > On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > > Added V4l2 controls for HEVC encoder > > > > Signed-off-by: Smitha T Murthy > > General comment: don't forget to build the pdf and check that as well. > Yes I will

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

On 03/31/2017 11:57 AM, Mauro Carvalho Chehab wrote: > Em Fri, 31 Mar 2017 10:29:04 +0200 > Hans Verkuil escreveu: > >> On 30/03/17 18:02, Helen Koike wrote: >>> Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be >>> used when no inputs are available in

Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On 04/07/2017 10:31 AM, Smitha T Murthy wrote: On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: On 04/06/2017 08:11 AM, Smitha T Murthy wrote: @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_MPEG_VIDEO_VPX_P_FRAME_QP:return "VPX

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

On 04/04/2017 03:22 PM, Sakari Ailus wrote: > Hi Helen, > > On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote: >> Hi, >> >> On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote: >>> Em Fri, 31 Mar 2017 10:29:04 +0200 >>> Hans Verkuil escreveu: >>> On 30/03/17

Re: [RFC, v2, 10/11] vb2: dma-contig: Let drivers decide DMA attrs of MMAP and USERPTR bufs

Hi Ricky, On Monday 26 Dec 2016 15:58:07 Ricky Liang wrote: > On Fri, Dec 16, 2016 at 9:24 AM, Laurent Pinchart wrote: > > From: Sakari Ailus > > > > The desirable DMA attributes are not generic for all devices using > > Videobuf2 contiguous DMA ops. Let the

Re: [PATCHv6 03/10] exynos_hdmi: add CEC notifier support

On 31.03.2017 14:20, Hans Verkuil wrote: > From: Hans Verkuil > > Implement the CEC notifier support to allow CEC drivers to > be informed when there is a new physical address. > > Signed-off-by: Hans Verkuil > Tested-by: Marek Szyprowski

Re: [PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

Hi Helen, On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote: > Fix kernel Oops NULL pointer deference > Call dev_dbg_obj only after checking if gobj->mdev is not NULL > > Signed-off-by: Helen Koike > --- > drivers/media/media-entity.c | 4 ++-- > 1 file

Re: [PATCH] [media] coda: do not enumerate YUYV if VDOA is not available

Am Donnerstag, den 06.04.2017, 16:03 +0200 schrieb Philipp Zabel: > TRY_FMT already disables the YUYV format if the VDOA is not available. > ENUM_FMT must do the same. > > Fixes: d40e98c13b3e ("[media] coda: support YUYV output if VDOA is used") > Signed-off-by: Philipp Zabel

Re: [PATCH v2 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:04 Sakari Ailus wrote: > The fwnode_handle is a more generic way than OF device_node to describe > firmware nodes. Instead of the OF API, use more generic fwnode API to > obtain the same information. I would mention that this is

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On Fri, 2017-04-07 at 12:26 +0200, Sylwester Nawrocki wrote: > On 04/07/2017 12:03 PM, Smitha T Murthy wrote: > >>> +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` > >>> +Indicates loop filtering. Control ID 0 indicates loop filtering > >>> +is enabled and when set to 1 indicates no filter. > >> > >>

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:05 Sakari Ailus wrote: > Add fwnode matching to complement OF node matching. And fwnode may also be > an OF node. > > Signed-off-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-async.c | 12

Re: [Patch v4 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder

On Fri, 2017-04-07 at 11:25 +0200, Sylwester Nawrocki wrote: > On 04/07/2017 10:31 AM, Smitha T Murthy wrote: > > On Thu, 2017-04-06 at 15:14 +0200, Sylwester Nawrocki wrote: > >> On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > >>> @@ -775,6 +832,47 @@ const char *v4l2_ctrl_get_name(u32 id) > >>>

Re: [PATCH v2 8/8] v4l: Remove V4L2 OF framework in favour of V4L2 fwnode framework

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:10 Sakari Ailus wrote: > All drivers have been converted from V4L2 OF to V4L2 fwnode. The V4L2 OF > framework is now unused. Remove it. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart

Re: [PATCH v2 7/8] docs-rst: media: Switch documentation to V4L2 fwnode API

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:09 Sakari Ailus wrote: > Instead of including the V4L2 OF header in ReST documentation, use the > V4L2 fwnode header instead. > > Signed-off-by: Sakari Ailus > --- >

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On Thu, 2017-04-06 at 16:47 +0200, Sylwester Nawrocki wrote: > On 04/06/2017 08:11 AM, Smitha T Murthy wrote: > > Added V4l2 controls for HEVC encoder > > s/HEVC/H.265/HEVC ? > Ok I will change it. > > Signed-off-by: Smitha T Murthy > > --- > >

Re: [PATCH v2 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

Hi Laurent, Thank you for the review! On Fri, Apr 07, 2017 at 11:49:56AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:03 Sakari Ailus wrote: > > Pass the more generic fwnode_handle to the init function than the > > device_node. > >

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

On 04/07/2017 12:03 PM, Smitha T Murthy wrote: +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` +Indicates loop filtering. Control ID 0 indicates loop filtering +is enabled and when set to 1 indicates no filter. >> "Setting this control to 0 enables loop filtering, setting this control to 1 disables

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

Hi Laurent, On Fri, Apr 07, 2017 at 12:49:02PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:05 Sakari Ailus wrote: > > Add fwnode matching to complement OF node matching. And fwnode may also be > > an OF node. > > > > Signed-off-by:

Re: [PATCH v2 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

Hi Laurent, On Fri, Apr 07, 2017 at 01:32:54PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:07 Sakari Ailus wrote: > > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > > > Existing OF matching continues

Re: [PATCH v9] [media] vimc: Virtual Media Controller core, capture and sensor

Just a few small comments for v10: On 04/04/2017 12:16 AM, Helen Koike wrote: > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor nodes in the topology, generating a grey image in a hardcoded > format. > > Signed-off-by:

Re: [PATCH v2 6/8] v4l: media/drv-intf/soc_mediabus.h: include dependent header file

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:08 Sakari Ailus wrote: > media/drv-intf/soc_mediabus.h does depend on struct v4l2_mbus_config which > is defined in media/v4l2-mediabus.h. Include it. > > Signed-off-by: Sakari Ailus Was this

Re: [PATCH v2 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:07 Sakari Ailus wrote: > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > Existing OF matching continues to be supported. omap3isp and smiapp > drivers are converted to fwnode matching as well. > >

Re: [PATCH v2 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

Hi Laurent, On Fri, Apr 07, 2017 at 12:44:27PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:04 Sakari Ailus wrote: > > The fwnode_handle is a more generic way than OF device_node to describe > > firmware nodes. Instead of the OF API,

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

Hi Sakari, On Friday 07 Apr 2017 13:45:09 Sakari Ailus wrote: > On Fri, Apr 07, 2017 at 01:04:47PM +0300, Laurent Pinchart wrote: > > > @@ -58,6 +60,9 @@ struct v4l2_async_subdev { > > > const struct device_node *node; > > > } of; > > > struct { > > > +

Re: [PATCH RFC 1/2] [media] v4l2: add V4L2_INPUT_TYPE_DEFAULT

Hi Hans, On Friday 07 Apr 2017 11:46:48 Hans Verkuil wrote: > On 04/04/2017 03:22 PM, Sakari Ailus wrote: > > On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote: > >> On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote: > >>> Em Fri, 31 Mar 2017 10:29:04 +0200 Hans Verkuil escreveu: >

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

Hi Sakari, Thank you for the patch. One more small comment below. On Thursday 06 Apr 2017 16:12:05 Sakari Ailus wrote: > Add fwnode matching to complement OF node matching. And fwnode may also be > an OF node. > > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH v2 4/8] v4l: async: Provide interoperability between OF and fwnode matching

Hi Sakari, Thank you for the patch. On Thursday 06 Apr 2017 16:12:06 Sakari Ailus wrote: > OF and fwnode support are separated in V4L2 and individual drivers may > implement one of them. Sub-devices do not match with a notifier > expecting sub-devices with fwnodes, nor the other way around.

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

Hi Laurent, On Fri, Apr 07, 2017 at 01:04:47PM +0300, Laurent Pinchart wrote: > > @@ -58,6 +60,9 @@ struct v4l2_async_subdev { > > const struct device_node *node; > > } of; > > struct { > > + struct fwnode_handle *fwn; > > Shouldn't

Re: [PATCH v2 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

Hi Sakari, On Friday 07 Apr 2017 13:36:34 Sakari Ailus wrote: > On Fri, Apr 07, 2017 at 12:44:27PM +0300, Laurent Pinchart wrote: > > On Thursday 06 Apr 2017 16:12:04 Sakari Ailus wrote: > > > The fwnode_handle is a more generic way than OF device_node to describe > > > firmware nodes. Instead of

Re: [PATCH v2 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

Hi Sakari, On Friday 07 Apr 2017 13:58:06 Sakari Ailus wrote: > On Fri, Apr 07, 2017 at 01:32:54PM +0300, Laurent Pinchart wrote: > > On Thursday 06 Apr 2017 16:12:07 Sakari Ailus wrote: > > > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > > > > > Existing OF

Re: [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field

Hi Shuah, On Mon, Mar 27, 2017 at 04:51:40PM -0600, Shuah Khan wrote: > On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart > wrote: > > From: Sakari Ailus > > > > The struct vb2_dc_buf contains two struct sg_table fields:

[PATCH] add blank line after declarations

Add blank line after variable declarations as part of checkpatch.pl style fixup. Signed-off-by: Manny Vindiola --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

Hi Laurent, On Fri, Apr 07, 2017 at 01:54:58PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 07 Apr 2017 13:36:34 Sakari Ailus wrote: > > On Fri, Apr 07, 2017 at 12:44:27PM +0300, Laurent Pinchart wrote: > > > On Thursday 06 Apr 2017 16:12:04 Sakari Ailus wrote: > > > > The

Re: [PATCH v2 6/8] v4l: media/drv-intf/soc_mediabus.h: include dependent header file

Hi Laurent, On Fri, Apr 07, 2017 at 01:01:29PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:08 Sakari Ailus wrote: > > media/drv-intf/soc_mediabus.h does depend on struct v4l2_mbus_config which > > is defined in

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Apr 8 05:00:18 CEST 2017 media-tree git hash:2f65ec0567f77b75f459c98426053a3787af356a media_build

Re: [PATCH v2 3/8] v4l: async: Add fwnode match support

On Fri, Apr 07, 2017 at 01:47:11PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 07 Apr 2017 13:45:09 Sakari Ailus wrote: > > On Fri, Apr 07, 2017 at 01:04:47PM +0300, Laurent Pinchart wrote: > > > > @@ -58,6 +60,9 @@ struct v4l2_async_subdev { > > > > const

[PATCH v2 6/7] [media] vimc: deb: Add debayer filter

Implement the debayer filter and integrate it with the core Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: deb: Add debayer filter - Using MEDIA_ENT_F_ATV_DECODER in function - remove v4l2_dev and dev from vimc_deb_device struct -

[PATCH v2 5/7] [media] vimc: cap: Support several image formats

Allow user space to change the image format as the frame size, the pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: cap: Support several image formats - this is

[PATCH v2 3/7] [media] vimc: Add vimc_pipeline_s_stream in the core

Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-core.c as this core will be reused by other subdevices to activate the stream in their directly connected nodes Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: Add vimc_pipeline_s_stream in

[PATCH v2 1/7] [media] vimc: sen: Integrate the tpg on the sensor

Initialize the test pattern generator on the sensor Generate a colored bar image instead of a grey one Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: sen: Integrate the tpg on the sensor - Fix include location - Select V4L2_TPG in Kconfig

[PATCH v2 4/7] [media] vimc: sen: Support several image formats

Allow user space to change the image format as the frame size, the media bus pixel format, colorspace, quantization, field YCbCr encoding and the transfer function Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: sen: Support several image formats

[PATCH v2 2/7] [media] vimc: Add vimc_ent_sd_* helper functions

As all the subdevices in the topology will be initialized in the same way, to avoid code repetition the vimc_ent_sd_{register, unregister} helper functions were created Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: Add vimc_ent_sd_* helper functions

[PATCH v2 7/7] [media] vimc: sca: Add scaler

Implement scaler and integrated with the core Signed-off-by: Helen Koike --- Changes in v2: [media] vimc: sca: Add scaler - Add function MEDIA_ENT_F_IO_V4L - remove v4l2_dev and dev - s/sink_mbus_fmt/sink_fmt - remove BUG_ON, remove

[PATCH v2 0/7] [media]: vimc: Virtual Media Control VPU's

This patch series improves the current video processing units in vimc (by adding more controls to the sensor and capture node, allowing the user to configure different frame formats) and also adds a debayer and a scaler node. The debayer transforms the bayer format image received in its sink pad

Re: [PATCH v2 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

Hi Laurent, On Fri, Apr 07, 2017 at 02:09:16PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 07 Apr 2017 13:58:06 Sakari Ailus wrote: > > On Fri, Apr 07, 2017 at 01:32:54PM +0300, Laurent Pinchart wrote: > > > On Thursday 06 Apr 2017 16:12:07 Sakari Ailus wrote: > > > > Switch users

Re: [PATCH v2 7/8] docs-rst: media: Switch documentation to V4L2 fwnode API

Hi Laurent, On Fri, Apr 07, 2017 at 12:59:01PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:09 Sakari Ailus wrote: > > Instead of including the V4L2 OF header in ReST documentation, use the > > V4L2 fwnode header instead. > > > >

[PATCH] m2m-deinterlace: don't return zero on failure paths in deinterlace_probe()

If DMA does not support INTERLEAVE, deinterlace_probe() breaks off initialization, releases dma channel, but returns zero. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/platform/m2m-deinterlace.c | 1 +

Re: [PATCH v2 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.11-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 1/3] staging: atomisp: remove enable_isp_irq function and add disable_isp_irq

Enable/Disable ISP irq is switched with "enable" parameter of enable_isp_irq(). It would be better splited to two such as enable_isp_irq()/disable_isp_irq(). But the enable_isp_irq() is no use in atomisp_cmd.c file. So remove the enable_isp_irq() function and add disable_isp_irq function only.

[PATCH 2/3] staging: atomisp: replace ">asd[i]" with "asd" in __get_asd_from_port()

The address of isp->asd[i] is already assigned to local "asd" variable. ">asd[i]" would be replaced with just "asd". Signed-off-by: Daeseok Youn --- This series of patches are related to previous patches: [1] https://lkml.org/lkml/2017/3/27/159 [2]

[PATCH 3/3] staging: atomisp: move mipi_info assignment to next line in __get_asd_from_port()

The line which is initializing mipi_info variable is too long to read. It would be placed in next line. Signed-off-by: Daeseok Youn --- This series of patches are related to previous patches: [1] https://lkml.org/lkml/2017/3/27/159 [2] https://lkml.org/lkml/2017/3/30/1068

Re: [PATCH 2/5] media: Add support for CXD2880 SPI I/F

-bindings-media-Add-document-file-and-driver/20170407-064503 base: git://linuxtv.org/media_tree.git master config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note

[PATCH v10] [media] vimc: Virtual Media Controller core, capture and sensor

First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike Reviewed-by: Hans Verkuil

RE: [PATCH v3] usb: document that URB transfer_buffer should be aligned

From: Mauro Carvalho Chehab > Sent: 05 April 2017 14:53 > Several host controllers, commonly found on ARM, like dwc2, > require buffers that are CPU-word aligned for they to work. > > Failing to do that will cause buffer overflows at the caller > drivers, with could cause data corruption. > >

Re: [PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

Hi Sakari, On 2017-04-07 04:40 AM, Sakari Ailus wrote: Hi Helen, On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote: Fix kernel Oops NULL pointer deference Call dev_dbg_obj only after checking if gobj->mdev is not NULL Signed-off-by: Helen Koike ---

Re: [PATCH 1/3] staging: atomisp: remove enable_isp_irq function and add disable_isp_irq

On Fri, 2017-04-07 at 14:56 +0900, Daeseok Youn wrote: > Enable/Disable ISP irq is switched with "enable" parameter of > enable_isp_irq(). It would be better splited to two such as > enable_isp_irq()/disable_isp_irq(). > > But the enable_isp_irq() is no use in atomisp_cmd.c file. > So remove the

Re: [PATCH v2 4/8] v4l: async: Provide interoperability between OF and fwnode matching

Hi Laurent, On Fri, Apr 07, 2017 at 01:07:48PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:06 Sakari Ailus wrote: > > OF and fwnode support are separated in V4L2 and individual drivers may > > implement one of them. Sub-devices do

Re: [PATCH v2 2/8] v4l: fwnode: Support generic fwnode for parsing standardised properties

On Fri, Apr 07, 2017 at 01:36:34PM +0300, Sakari Ailus wrote: ... > > > + if (is_of_node(fwn)) { > > > + if (of_node_cmp(to_of_node(fwn)->name, "ports") == 0) > > > + fwn = fwnode_get_next_parent(fwn); > > > + } else { > > > + /* The "ports" node is always there in