Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 06/09/2017 04:23 PM, Pavel Machek wrote: Hi! Steve, You need to remove the fim node now that you've moved this to V4L2 controls. Yep, I caught this just after sending the v8 patchset. I'll send a v9 of this patch. This needs ack from devicetree people, then it can be merged. Can you

Re: [PATCH v8 19/34] media: Add i.MX media core driver

On 06/09/2017 06:15 AM, Philipp Zabel wrote: On Wed, 2017-06-07 at 11:33 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs. Signed-off-by: Philipp Zabel

Re: [PATCH v8 00/34] i.MX Media Driver

On 10/06/17 01:16, Steve Longerbeam wrote: > > > On 06/07/2017 12:02 PM, Hans Verkuil wrote: >> We're still waiting for an Ack for patch 02/34, right? >> > > Hi Hans, Rub has provided an Ack for patch 2. > >> Other than that everything is ready AFAICT. >> > > But as Pavel pointed out, in fact

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/07/2017 12:02 PM, Hans Verkuil wrote: We're still waiting for an Ack for patch 02/34, right? Hi Hans, Rub has provided an Ack for patch 2. Other than that everything is ready AFAICT. But as Pavel pointed out, in fact we are missing many Acks still, for all of the dts source

[PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

Now that the davinci drivers can be enabled in compile tests on other architectures, I ran into this warning on a 64-bit build: drivers/media/platform/davinci/dm644x_ccdc.c: In function 'ccdc_update_raw_params': drivers/media/platform/davinci/dm644x_ccdc.c:279:7: error: cast to pointer from

Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 06/09/2017 02:38 PM, Pavel Machek wrote: On Thu 2017-06-08 13:36:12, Steve Longerbeam wrote: On 06/08/2017 01:25 PM, Tim Harvey wrote: Steve, You need to remove the fim node now that you've moved this to V4L2 controls. Yep, I caught this just after sending the v8 patchset. I'll

Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

Hi! > >>>Steve, > >>> > >>>You need to remove the fim node now that you've moved this to V4L2 > >>>controls. > >>> > >> > >>Yep, I caught this just after sending the v8 patchset. I'll send > >>a v9 of this patch. > > > >This needs ack from devicetree people, then it can be merged. Can you > >be

Re: [PATCH v8 14/34] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On Thu 2017-06-08 13:36:12, Steve Longerbeam wrote: > > > On 06/08/2017 01:25 PM, Tim Harvey wrote: > > > > > >Steve, > > > >You need to remove the fim node now that you've moved this to V4L2 controls. > > > > Yep, I caught this just after sending the v8 patchset. I'll send > a v9 of this

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/09/2017 04:16 PM, Steve Longerbeam wrote: On 06/07/2017 12:02 PM, Hans Verkuil wrote: We're still waiting for an Ack for patch 02/34, right? Hi Hans, Rub damn, I really need to proof-read before hitting send. "Rob" (sorry Rob!). Steve

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

On Fri, Jun 9, 2017 at 3:07 AM, Robin Murphy wrote: > On 08/06/17 15:35, Tomasz Figa wrote: >> On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy wrote: >>> On 07/06/17 10:47, Tomasz Figa wrote: Hi Yong, +Robin, Joerg, IOMMU ML

Re: [RFC 00/10] V4L2 explicit synchronization support

Hi Mauro, 2017-06-08 Mauro Carvalho Chehab : > Hi Gustavo, > > Em Wed, 24 May 2017 21:31:01 -0300 > Gustavo Padovan escreveu: > > > Hi all, > > > > I've been working on the v2 of this series, but I think I hit a blocker > > when trying to cover

Re: [PATCH 11/12] intel-ipu3: Add imgu v4l2 driver

Hi Hans, On Tue, Jun 06, 2017 at 11:08:07AM +0200, Hans Verkuil wrote: > > + /* Initialize vdev */ > > + strlcpy(vdev->name, node->name, sizeof(vdev->name)); > > + vdev->release = video_device_release_empty; > > + vdev->fops = >v4l2_file_ops; > > +

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

Hi Kevin, On Thu, Jun 08, 2017 at 06:01:45PM -0700, Kevin Hilman wrote: > On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: > > On 07/06/17 01:37, Kevin Hilman wrote: > >> Enable getting of subdevs from DT ports and endpoints. > >> > >> The _get_pdata() function was

[PATCH v9 1/1] [media] i2c: add support for OV13858 sensor

This patch adds driver for Omnivision's ov13858 sensor, the driver supports following features: - manual exposure/gain(analog and digital) control support - two link frequencies - VBLANK/HBLANK support - test pattern support - media controller support - runtime pm support - supported resolutions

[PATCH v9 0/1] [media] i2c: add support for OV13858 sensor

I added HBLANK v4l2 control and marked it as read-only since VBLANK is enough to control FPS. Sensor also support digital gain so I added digital gain support by using V4L2_CID_GAIN control. Hyungwoo Yang (1): [media] i2c: add support for OV13858 sensor drivers/media/i2c/Kconfig |8 +

[GIT PULL FOR v4.13] Add stm32-cec driver

The following changes since commit 47f910f0e0deb880c2114811f7ea1ec115a19ee4: [media] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev (2017-06-08 16:55:25 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git stm32-cec for you to fetch changes

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

Hi Kevin, Thanks for the patch. On Fri, Jun 9, 2017 at 2:01 AM, Kevin Hilman wrote: > On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: >> On 07/06/17 01:37, Kevin Hilman wrote: >>> Enable getting of subdevs from DT ports and endpoints. >>> >>> The

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

Hi Tomasz, Couple of small comments below. On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: > >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) > >> +{ > >> + struct ipu3_mmu_domain *mmu_dom = > >> + container_of(dom, struct ipu3_mmu_domain, domain); > >>

[GIT PULL FOR v4.13] RC fixes

Hi Mauro, Here is the fixed sir_ir mod param change and a change to remove an unnecessary rc_dev member. This could not be merged earlier due to conflicts with late v4.12 fixes. Thanks Sean The following changes since commit 47f910f0e0deb880c2114811f7ea1ec115a19ee4: [media] v4l: subdev:

Re: [RFC 00/10] V4L2 explicit synchronization support

2017-06-08 Shuah Khan : > Hi Gustavo, > > On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab > wrote: > > Hi Gustavo, > > > > Em Wed, 24 May 2017 21:31:01 -0300 > > Gustavo Padovan escreveu: > > > >> Hi all, > >> > >> I've

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jun 9 05:00:26 CEST 2017 media-tree git hash:47f910f0e0deb880c2114811f7ea1ec115a19ee4 media_build

Re: [PATCH 05/12] intel-ipu3: css: tables

On Thu, Jun 08, 2017 at 05:29:48PM +0900, Tomasz Figa wrote: > Hi Yong, > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > > Coeff, config parameters etc const definitions for > > IPU3 programming. > > > > Signed-off-by: Yong Zhi > > --- > >

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Sakari, Mauro, On 08/06/17 21:10, Mauro Carvalho Chehab wrote: > Em Thu, 8 Jun 2017 22:32:10 +0300 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Thu, Jun 08, 2017 at 03:00:22PM -0300, Mauro Carvalho Chehab wrote: >>> Em Wed, 7 Jun 2017 10:52:07 +0100 >>> Kieran

Re: [PATCH 1/3] media: ngene: Replace semaphore cmd_mutex with mutex

On Fri, Jun 9, 2017 at 6:37 AM, Binoy Jayan wrote: > On 8 June 2017 at 20:40, Arnd Bergmann wrote: >> On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote: >>> The semaphore 'cmd_mutex' is used as a simple mutex, so >>> it should be

Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property

On 09/06/17 16:07, Rob Herring wrote: > On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Needed for boards that wire the CEC pin in such a way that it >> is unavailable when the HPD is low. >> >> Signed-off-by: Hans Verkuil

Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property

On Fri, Jun 9, 2017 at 9:11 AM, Hans Verkuil wrote: > On 09/06/17 16:07, Rob Herring wrote: >> On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Needed for boards that wire the CEC pin in such a way that it

Re: [RFC 00/10] V4L2 explicit synchronization support

Le lundi 03 avril 2017 à 15:46 -0400, Javier Martinez Canillas a écrit : > > The problem is that adding implicit fences changed the behavior of > > the ioctls, causing gstreamer to wait forever for buffers to be ready. > > > > The problem was related to trying to make user-space unaware of the

Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property

On 06/09/2017 05:31 PM, Rob Herring wrote: > On Fri, Jun 9, 2017 at 9:11 AM, Hans Verkuil wrote: >> On 09/06/17 16:07, Rob Herring wrote: >>> On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote: From: Hans Verkuil Needed for

Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property

On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Needed for boards that wire the CEC pin in such a way that it > is unavailable when the HPD is low. > > Signed-off-by: Hans Verkuil > Cc: Krzysztof Kozlowski

Re: [PATCH v8 02/34] [media] dt-bindings: Add bindings for i.MX media driver

On Thu, Jun 08, 2017 at 10:08:35AM -0700, Steve Longerbeam wrote: > > > On 06/08/2017 09:45 AM, Steve Longerbeam wrote: > > Hi Rob, Mark, > > > > Are there any remaining technical issues with this > > binding doc? At this point an Ack from you is the only > > thing holding up merge of the

[PATCH v7 3/7] media: i2c: max2175: Add MAX2175 support

This patch adds driver support for the MAX2175 chip. This is Maxim Integrated's RF to Bits tuner front end chip designed for software-defined radio solutions. This driver exposes the tuner as a sub-device instance with standard and custom controls to configure the device. Signed-off-by: Ramesh

[PATCH v7 0/7] Add V4L2 SDR (DRIF & MAX2175) driver

Hi Mauro, Hans, This patch set contains two drivers - Renesas R-Car Digital Radio Interface (DRIF) driver - Maxim's MAX2175 RF to Bits tuner driver These patches were based on top of media_tree. commit: 47f910f0e0deb880c2114811f7ea1ec115a19ee4 These two drivers combined together expose a V4L2

[PATCH v7 1/7] media: v4l2-ctrls: Reserve controls for MAX217X

Reserve controls for MAX217X RF to Bits tuner family. These hybrid radio receiver chips are highly programmable and hence reserving 32 controls. Signed-off-by: Ramesh Shanmugasundaram Acked-by: Laurent Pinchart ---

[PATCH v7 2/7] dt-bindings: media: Add MAX2175 binding description

Add device tree binding documentation for MAX2175 RF to bits tuner device. Signed-off-by: Ramesh Shanmugasundaram Acked-by: Rob Herring --- .../devicetree/bindings/media/i2c/max2175.txt | 59 ++

[PATCH v7 7/7] media: platform: rcar_drif: Add DRIF support

This patch adds Digital Radio Interface (DRIF) support to R-Car Gen3 SoCs. The driver exposes each instance of DRIF as a V4L2 SDR device. A DRIF device represents a channel and each channel can have one or two sub-channels respectively depending on the target board. DRIF supports only Rx

[PATCH v7 4/7] media: Add new SDR formats PC16, PC18 & PC20

This patch adds support for the three new SDR formats. These formats were prefixed with "planar" indicating I & Q data are not interleaved as in other formats. Here, I & Q data constitutes the top half and bottom half of the received buffer respectively. V4L2_SDR_FMT_PCU16BE - 14-bit complex (I &

[PATCH v7 5/7] doc_rst: media: New SDR formats PC16, PC18 & PC20

This patch adds documentation for the three new SDR formats V4L2_SDR_FMT_PCU16BE V4L2_SDR_FMT_PCU18BE V4L2_SDR_FMT_PCU20BE Signed-off-by: Ramesh Shanmugasundaram --- .../media/uapi/v4l/pixfmt-sdr-pcu16be.rst | 55 ++

[PATCH v7 6/7] dt-bindings: media: Add Renesas R-Car DRIF binding

Add binding documentation for Renesas R-Car Digital Radio Interface (DRIF) controller. Signed-off-by: Ramesh Shanmugasundaram Acked-by: Rob Herring --- .../devicetree/bindings/media/renesas,drif.txt | 176 + 1

[GIT PULL] Samsung SoC updates for v4.13

Hi Mauro, The following changes since commit 36bcba973ad478042d1ffc6e89afd92e8bd17030: [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update() (2017-05-19 07:12:05 -0300) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.13/media/next for

[PATCH] media: fdp1: Support ES2 platforms

From: Kieran Bingham The new Renesas R-Car H3 ES2.0 platforms have an updated hw version register. Update the driver accordingly. Signed-off-by: Kieran Bingham --- drivers/media/platform/rcar_fdp1.c | 4 1

[patch] [media_build] Small fix to build script (resend)

This seems to have fallen on the floor... Original send date: Thu, 1 Jun 2017 19:43:43 +1000 Avoid going splat if --depth is not given Commit 6b4a9c5 indroduced the --depth parameter to limit the commit history pulled by when cloning, giving a nice speedup. But in the process it broke running

[patch] [media_build] make check_git() give more information in verbose mode (resend)

While debugging another issue I found this change helpful. Original send Date: Thu, 1 Jun 2017 20:44:27 +1000 Make check_git() give more information in verbose mode. Signed-off-by: Vincent McIntyre --- build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] [media] media-ioc-g-topology.rst: fix typos

On Fri, Jun 9, 2017 at 2:51 AM, Mauro Carvalho Chehab wrote: > Em Wed, 7 Jun 2017 18:33:02 +0900 > Alexandre Courbot escreveu: > >> Fix what seems to be a few typos induced by copy/paste. >> >> Signed-off-by: Alexandre Courbot

[patch] [media_build] small cleanup of build script (resend)

Original send date: Thu, 1 Jun 2017 20:12:32 +1000 Introduce a function to help tracing of system() calls While debugging a recent issue I wanted more complete information about the sequencence of events in a series of calls like system("foo") or die("BAR") Adding this helper did that and

[PATCH v2 0/2] Add explicit digital gain control, document gain controls better

Hi folks, This set includes two patches: one that adds digital gain control and another that better documents the relationship between the gain controls. changes since v1: - Say that the no-gain digital gain configuration is typically the default. This was slightly unclear in the previous

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

On 09/06/17 07:20, Tomasz Figa wrote: > On Fri, Jun 9, 2017 at 3:07 AM, Robin Murphy wrote: >> On 08/06/17 15:35, Tomasz Figa wrote: >>> On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy wrote: On 07/06/17 10:47, Tomasz Figa wrote: > Hi Yong,

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

On Fri, Jun 9, 2017 at 5:26 PM, Tuukka Toivonen wrote: > Hi Tomasz, > > Couple of small comments below. > > On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) >> >> +{ >> >> + struct

Re: [media-af9013] question about return value in function af9013_wr_regs()

Gustavo A. R. Silva kirjoitti 2017-06-09 00:51: Hello everybody, While looking into Coverity ID 1227035 I ran into the following piece of code at drivers/media/dvb-frontends/af9013.c:595: The issue here is that the value stored in variable _ret_ at line 608, is not being evaluated as it

[PATCH] rcar-vin: add support for V4L2_FIELD_SEQ_{TB,BT}

The hardware do not support capturing the field types V4L2_FIELD_SEQ_TB and V4L2_FIELD_SEQ_BT. To capture in these formats the driver needs to change what field (top or bottom) is to be captured next and for every other capture adjust the offset of the capture buffer. This patch adds support for

Re: [PATCH v8 19/34] media: Add i.MX media core driver

On Wed, 2017-06-07 at 11:33 -0700, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > > Switch from the v4l2_of_ APIs to the v4l2_fwnode_ APIs. > > Signed-off-by: Philipp Zabel > > Add

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

Hi Alan, On Mon, Jun 05, 2017 at 09:43:27PM +0100, Alan Cox wrote: > On Mon, 5 Jun 2017 15:39:06 -0500 > Yong Zhi wrote: > > > Add the IPU3 specific processing parameter format > > V4L2_META_FMT_IPU3_PARAMS and metadata formats > > for 3A and other statistics: > > > >

[PATCH v2 1/2] v4l: ctrls: Add a control for digital gain

Add V4L2_CID_DIGITAL_GAIN to control explicitly digital gain. We already have analogue gain control which the digital gain control complements. Typically higher quality images are obtained using analogue gain only as the digital gain does not add information to the image (rather it may remove

[PATCH v2 2/2] v4l: controls: Improve documentation for V4L2_CID_GAIN

Elaborate the differences between V4L2_CID_GAIN and gain-type specific V4L2_CID_DIGITAL_GAIN and V4L2_CID_ANALOGUE_GAIN. Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/control.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

Hi Tomasz, On Fri, Jun 09, 2017 at 02:59:10PM +0900, Tomasz Figa wrote: > On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: > >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) > >> >> +{ > >> >> + struct ipu3_mmu_domain *mmu_dom = > >> >> +

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

On Fri, Jun 9, 2017 at 8:16 PM, Sakari Ailus wrote: > Hi Tomasz, > > On Fri, Jun 09, 2017 at 02:59:10PM +0900, Tomasz Figa wrote: >> On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: >> >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom)

[PATCH v2] [media] davinci: vpif: adaptions for DT support

The davinci VPIF is a single hardware block, but the existing driver is broken up into a common library (vpif.c), output (vpif_display.c) and intput (vpif_capture.c). When migrating to DT, to better model the hardware, and because registers, interrupts, etc. are all common,it was decided to have

Re: [RFC 00/10] V4L2 explicit synchronization support

On 06/09/2017 12:25 AM, Gustavo Padovan wrote: > 2017-06-08 Shuah Khan : > >> Hi Gustavo, >> >> On Thu, Jun 8, 2017 at 2:17 PM, Mauro Carvalho Chehab >> wrote: >>> Hi Gustavo, >>> >>> Em Wed, 24 May 2017 21:31:01 -0300 >>> Gustavo Padovan

Re: [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property

On Fri, Jun 9, 2017 at 10:55 AM, Hans Verkuil wrote: > On 06/09/2017 05:31 PM, Rob Herring wrote: >> On Fri, Jun 9, 2017 at 9:11 AM, Hans Verkuil wrote: >>> On 09/06/17 16:07, Rob Herring wrote: On Wed, Jun 07, 2017 at 04:46:14PM +0200, Hans Verkuil

[PATCH] dvb-usb-af9035: load HID table

Automatically load sniffed HID table from Windows driver if USB_VID_ITETECH:USB_PID_ITETECH_IT9135_9006 device is present (e.g. Evolveo Mars) or if module parameter force_hid_tab_load is set. Signed-off-by: Jaroslav Škarvada --- drivers/media/usb/dvb-usb-v2/af9035.c | 266

[PATCH 1/2] dt-bindings: add media/cec.txt

From: Hans Verkuil Document common HDMI CEC bindings. Add this to the MAINTAINERS file as well. Signed-off-by: Hans Verkuil Cc: Krzysztof Kozlowski Cc: Andrzej Hajda Cc: Benjamin Gaignard

[PATCH 0/2] cec.txt: document common cec bindings

From: Hans Verkuil As requested by Rob Herring. Sits on top of the earlier "cec improvements" patch series: http://www.spinics.net/lists/dri-devel/msg143377.html Regards, Hans Hans Verkuil (2): dt-bindings: add media/cec.txt dt-bindings:

[PATCH 2/2] dt-bindings: media/s5p-cec.txt, media/stih-cec.txt: refer to cec.txt

From: Hans Verkuil Now that there is a cec.txt with common CEC bindings, update the two driver-specific bindings to refer to cec.txt. Signed-off-by: Hans Verkuil Cc: Krzysztof Kozlowski Cc: Andrzej Hajda

[PATCH] [media] tuner-core: Remove unused #define PREFIX

Commit 680d87c0a9e3 ("[media] tuner-core: use pr_foo, instead of internal printk macros") removed the use of PREFIX, remove the #define Signed-off-by: Joe Perches --- drivers/media/v4l2-core/tuner-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Patch v4 00/12] Add MFC v10.10 support

On 04/06/2017 08:11 AM, Smitha T Murthy wrote: This patch series adds MFC v10.10 support. MFC v10.10 is used in some of Exynos7 variants. This adds support for following: * Add support for HEVC encoder and decoder * Add support for VP9 decoder * Update Documentation for control id definitions

[PATCH] stkwebcam: Use more common logging styles

Convert STK_ to pr_ to use the typical kernel logging. Add a define for pr_fmt. No change in logging output. Miscellanea: o Remove now unused PREFIX and STK_ macros o Realign arguments o Use pr__ratelimited o Add a few missing newlines to formats Signed-off-by: Joe Perches