Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-26 Thread Sakari Ailus
Hi Tomasz, A few more comments, better late than never I guess. On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote: ... > > +/* > > + * The CSI2 receiver has several parameters affecting > > + * the receiver timings. These depend on the MIPI bus frequency > > + * F in Hz (sensor

[PATCH v2] media: v4l2-fwnode: don't risk go out of array bounds

2017-06-26 Thread Mauro Carvalho Chehab
As warned by gcc: drivers/media/v4l2-core/v4l2-fwnode.c:76 v4l2_fwnode_endpoint_parse_csi_bus() error: buffer overflow 'array' 5 <= u16max That's because, in thesis, the routine might have called with some value at bus->num_data_lanes. While this doesn't happen, in practice, some code

[PATCH] media: davinci: variable 'common' set but not used

2017-06-26 Thread Mauro Carvalho Chehab
Get rid of those two warnings: drivers/media/platform/davinci/vpif_capture.c: In function 'vpif_remove': drivers/media/platform/davinci/vpif_capture.c:1722:21: warning: variable 'common' set but not used [-Wunused-but-set-variable] struct common_obj *common; ^~

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-26 Thread Hugues FRUCHET
On 06/26/2017 12:07 PM, Hans Verkuil wrote: > On 26/06/17 11:53, Hugues FRUCHET wrote: >> Hi Hans, thanks for review. >> >> Reply below. >> >> BR >> Hugues. >> >> On 06/22/2017 05:19 PM, Hans Verkuil wrote: >>> On 06/22/2017 05:12 PM, Hugues Fruchet wrote: Add flexibility on supported

[PATCH 0/5] Add Rockchip RGA V4l2 support

2017-06-26 Thread Jacob Chen
This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering based 2d graphics acceleration module. Before, my colleague yakir have write a drm RGA drvier and send it to the lists. http://lists.infradead.org/pipermail/linux-arm-kernel/2016-March/416769.html I have been asked to

[PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-26 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness. The drvier is mostly based on s5p-g2d v4l2 m2m driver. And supports various operations from

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-26 Thread Hugues FRUCHET
On 06/26/2017 08:03 AM, H. Nikolaus Schaller wrote: > >> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : >> >> Add a first support of OV9655 variant. >> Because of register set slightly different from OV9650/9652, >> not all of the driver features are supported

[PATCH] media: v4l2-fwnode: don't risk go out of array bounds

2017-06-26 Thread Mauro Carvalho Chehab
As warned by gcc: drivers/media/v4l2-core/v4l2-fwnode.c:76 v4l2_fwnode_endpoint_parse_csi_bus() error: buffer overflow 'array' 5 <= u16max That's because, in thesis, the routine might have called with some value at bus->num_data_lanes. While this doesn't happen, in practice, some code

[PATCH] media: pvrusb2: fix the retry logic

2017-06-26 Thread Mauro Carvalho Chehab
As reported by this warning: drivers/media/usb/pvrusb2/pvrusb2-encoder.c:263 pvr2_encoder_cmd() warn: continue to end of do { ... } while(0); loop There's an issue at the retry logic there: the current logic is: do { if (need_to_retry)

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread Hugues FRUCHET
Nikolaus, some comments about pixel format/resolution below: On 06/26/2017 10:39 AM, Pavel Machek wrote: > On Mon 2017-06-26 08:05:04, H. Nikolaus Schaller wrote: >> Hi Pavel, >> >>> Am 25.06.2017 um 11:18 schrieb Pavel Machek : >>> >>> Hi! >>> * unfortunately we still get no

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Hans Verkuil
On 26/06/17 17:14, Kieran Bingham wrote: > Hi Hans, > > Thankyou for your review, and apologies for the delay - I was OoO last week. > > > On 19/06/17 10:13, Hans Verkuil wrote: >> On 06/13/2017 02:35 AM, Kieran Bingham wrote: >>> From: Kieran Bingham

Re: [PATCH 08/12] [media] vb2: add 'ordered' property to queues

2017-06-26 Thread Gustavo Padovan
Hi Nicolas, 2017-06-16 Nicolas Dufresne : > Le vendredi 16 juin 2017 à 16:39 +0900, Gustavo Padovan a écrit : > > > From: Gustavo Padovan > > > > For explicit synchronization (and soon for HAL3/Request API) we need > > the v4l2-driver to

Re: [PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Daniel Scheller
Am Mon, 26 Jun 2017 10:55:34 +0200 schrieb Ralph Metzler : > Daniel Scheller writes: > > From: Daniel Scheller > > > > Original code at least has some signed/unsigned issues, resulting > > in values like 32dBm. > > I will look into that. > > >

Re: [PATCH 01/12] [media] vb2: add explicit fence user API

2017-06-26 Thread Gustavo Padovan
2017-06-18 kbuild test robot : > Hi Gustavo, > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on v4.12-rc5 next-20170616] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-26 Thread Jose Abreu
Hi Sylwester, On 25-06-2017 22:13, Sylwester Nawrocki wrote: > Hi Jose, > > Thank you for addressing my review comments. Couple more suggestions below. > > On 06/20/2017 07:26 PM, Jose Abreu wrote: >> This adds support for the Synopsys Designware HDMI RX PHY e405. This >> phy receives and

[GIT PULL for 4.13] ov6650 V4L2 sub-device conversion

2017-06-26 Thread Sakari Ailus
Hi Mauro, This set includes converting the ov6650 driver to V4L2 sub-device driver (from SoC camera). Rebased w/o conflicts on more recent media tree master. Please pull. The following changes since commit 430e29d9c0f65d9653a0b7f7a56f1c6cd374b84b: media: dvb-frontends/stv0367: Improve

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-26 Thread Nicolas Dufresne
Le lundi 26 juin 2017 à 22:51 +0800, Jacob Chen a écrit : > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness. > > The drvier is mostly

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Laurent Pinchart
[snip] On Monday 26 Jun 2017 16:14:47 Kieran Bingham wrote: > >> +int adv748x_txa_power(struct adv748x_state *state, bool on) > >> +{ > >> +int val; > >> + > >> +val = txa_read(state, ADV748X_CSI_FS_AS_LS); > >> +if (val < 0) > >> +return val; > >> + > >> +/* > >> + *

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
Resend since I received bad-mail-address bounces, sorry for any duplicated email. Am Mon, 26 Jun 2017 11:59:20 +0200 schrieb Ralph Metzler : > Mauro Carvalho Chehab writes: > > > > Splitting it is OK. Including a *.c file no. It shouldn't be hard > > to > [...] > >

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
Am Mon, 26 Jun 2017 06:19:20 -0300 schrieb Mauro Carvalho Chehab : > Yes, config flags work, but please don't use a config flag like this: > > if (initflags & TDA18212_INIT_DDSTV) > > The flags should identify the required functionality, not if the > caller is

Re: [PATCH v1 2/6] [media] ov9650: add device tree support

2017-06-26 Thread Sakari Ailus
Hi Hugues, On Thu, Jun 22, 2017 at 05:05:38PM +0200, Hugues Fruchet wrote: > @@ -1545,15 +1577,22 @@ static int ov965x_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ov965x_id[] = { > - { "OV9650", 0 }, > - { "OV9652", 0 }, > + { "OV9650", 0x9650 }, >

Re: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences

2017-06-26 Thread Sakari Ailus
Hi Hugues, On Thu, Jun 22, 2017 at 05:05:40PM +0200, Hugues Fruchet wrote: > Align resolution sequences on initialization sequence using > i2c_rv structure NULL terminated .This add flexibility > on resolution sequence size. > Document resolution related registers by using corresponding > define

Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Kieran Bingham
Hi Hans, Thankyou for your review, and apologies for the delay - I was OoO last week. On 19/06/17 10:13, Hans Verkuil wrote: > On 06/13/2017 02:35 AM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >>

Re: OMAP3630 ISP V4L2 Camera Not Streaming to LCD

2017-06-26 Thread Sakari Ailus
Hi Adam, On Wed, Jun 21, 2017 at 04:34:41PM -0500, Adam Ford wrote: > I have a Leopard Imaging LI-5M03 camera attached in 8-bit mode, and I > am trying to capture an image on camera and stream it to the LCD > (/dev/fb0) without using the DSP or proprietary codecs. > > I was hoping to do it with

Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-26 Thread Jose Abreu
Hi Rob, On 23-06-2017 22:58, Rob Herring wrote: > On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu >> Cc: Carlos Palminha >> Cc: Rob Herring

[PATCH v2 12/14] drm: rcar-du: Support multiple sources from the same VSP

2017-06-26 Thread Laurent Pinchart
On R-Car H3 ES2.0, DU channels 0 and 3 are served by two separate pipelines from the same VSP. Support this in the DU driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h |

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
Am Mon, 26 Jun 2017 11:45:08 +0200 schrieb Ralph Metzler : > Mauro Carvalho Chehab writes: > > > Would it be possible to change things at the dddvb tree to make > > it to use our coding style (for example, replacing CamelCase by the > > kernel_style), in order to minimize

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread Rob Herring
On Thu, Jun 22, 2017 at 05:05:37PM +0200, Hugues Fruchet wrote: > From: "H. Nikolaus Schaller" > > This adds documentation of device tree bindings > for the OV965X family camera sensor module. > > Signed-off-by: H. Nikolaus Schaller > Signed-off-by:

Re: [PATCH v1 2/6] [media] ov9650: add device tree support

2017-06-26 Thread H. Nikolaus Schaller
Hi, > Am 26.06.2017 um 18:31 schrieb Sakari Ailus : > > Hi Hugues, > > On Thu, Jun 22, 2017 at 05:05:38PM +0200, Hugues Fruchet wrote: >> @@ -1545,15 +1577,22 @@ static int ov965x_remove(struct i2c_client *client) >> } >> >> static const struct i2c_device_id ov965x_id[] =

[PATCH v2 03/14] v4l: vsp1: Don't set WPF sink pointer

2017-06-26 Thread Laurent Pinchart
The sink pointer is used to configure routing inside the VSP, and as such must point to the next VSP entity in the pipeline. The WPF being a pipeline terminal sink, its output route can't be configured. The routing configuration code already handles this correctly without referring to the sink

[PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API

2017-06-26 Thread Laurent Pinchart
In the H3 ES2.0 SoC the VSP2-DL instance has two connections to DU channels that need to be configured independently. Extend the VSP-DU API with a pipeline index to identify which pipeline the caller wants to operate on. Signed-off-by: Laurent Pinchart

[PATCH v2 02/14] v4l: vsp1: Don't recycle active list at display start

2017-06-26 Thread Laurent Pinchart
When the display start interrupt occurs, we know that the hardware has finished loading the active display list. The driver then proceeds to recycle the list, assuming it won't be needed anymore. This assumption holds true for headerless display lists, as the VSP doesn't reload the list for the

[PATCH v2 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-06-26 Thread Laurent Pinchart
New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL, as well as a new VSP2-D variant on V3M and V3H SoCs. Add new entries for them in the VSP device info table. Signed-off-by: Laurent Pinchart ---

[PATCH v2 05/14] v4l: vsp1: Don't create links for DRM pipeline

2017-06-26 Thread Laurent Pinchart
When the VSP1 is used in a DRM pipeline the driver doesn't register the media device. Links between entities are not exposed to userspace, but are still used internally for the sole purpose of setting up internal source to sink pointers through the link setup handler. Instead of going through

[PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity

2017-06-26 Thread Laurent Pinchart
The internal VSP entity source and sink pointers are stored as media_entity pointers, which are then cast to a vsp1_entity. As all sources and sinks are vsp1_entity instances, we can store the vsp1_entity pointers directly. Signed-off-by: Laurent Pinchart

[PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support

2017-06-26 Thread Laurent Pinchart
or-X: Enable DU support in DT" patch series For convenience, a branch merging this series with all dependencies is available from git://linuxtv.org/pinchartl/media.git drm/next/h3-es2/merged with the DT and driver series split in two branches respectively tagged drm-h3-es2-dt-2017062

[PATCH v3] media: v4l2-fwnode: suppress a warning at OF parsing logic

2017-06-26 Thread Mauro Carvalho Chehab
smatch produce this warning: drivers/media/v4l2-core/v4l2-fwnode.c:76 v4l2_fwnode_endpoint_parse_csi_bus() error: buffer overflow 'array' 5 <= u16max That's because, in thesis, the routine might have called with some value at bus->num_data_lanes. That's not the current case. Yet, better

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread Rob Herring
On Fri, Jun 23, 2017 at 12:25:33PM +0200, H. Nikolaus Schaller wrote: > Hi Hugues, > > > Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : > > > > From: "H. Nikolaus Schaller" > > > > This adds documentation of device tree bindings > > for the OV965X

[PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable().

2017-06-26 Thread H. Nikolaus Schaller
If a camera module driver specifies a format that is not supported by omap3isp this ends in a NULL pointer dereference instead of a simple fail. Signed-off-by: H. Nikolaus Schaller --- drivers/media/platform/omap3isp/ispccdc.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH v2 10/14] v4l: vsp1: Add support for multiple DRM pipelines

2017-06-26 Thread Laurent Pinchart
The R-Car H3 ES2.0 VSP-DL instance has two LIF entities and can drive two display pipelines at the same time. Refactor the VSP DRM code to support that by introducing a vsp_drm_pipeline object that models one display pipeline. Signed-off-by: Laurent Pinchart

[PATCH v2 01/14] v4l: vsp1: Fill display list headers without holding dlm spinlock

2017-06-26 Thread Laurent Pinchart
The display list headers are filled using information from the display list only. Lower the display list manager spinlock contention by filling the headers without holding the lock. Signed-off-by: Laurent Pinchart ---

[PATCH v2 07/14] v4l: vsp1: Add support for the BRS entity

2017-06-26 Thread Laurent Pinchart
The Blend/ROP Sub Unit (BRS) is a stripped-down version of the BRU found in several VSP2 instances. Compared to a regular BRU, it supports two inputs only, and thus has no ROP unit. Add support for the BRS by modeling it as a new entity type, but reuse the vsp1_bru object underneath. Chaining the

[PATCH v2 13/14] drm: rcar-du: Restrict DPLL duty cycle workaround to H3 ES1.x

2017-06-26 Thread Laurent Pinchart
The H3 ES1.x exhibits dot clock duty cycle stability issues. We can work around them by configuring the DPLL to twice the desired frequency, coupled with a /2 post-divider. This isn't needed on other SoCs and breaks HDMI output on M3-W for a currently unknown reason, so restrict the workaround to

[PATCH v2 11/14] v4l: vsp1: Add support for header display lists in continuous mode

2017-06-26 Thread Laurent Pinchart
The VSP supports both header and headerless display lists. The latter is easier to use when the VSP feeds data directly to the DU in continuous mode, and the driver thus uses headerless display lists for DU operation and header display lists otherwise. Headerless display lists are only available

[PATCH v2 09/14] v4l: vsp1: Add support for multiple LIF instances

2017-06-26 Thread Laurent Pinchart
The VSP2-DL instance (present in the H3 ES2.0 and M3-N SoCs) has two LIF instances. Adapt the driver infrastructure to support multiple LIFs. Support for multiple display pipelines will be added separately. The change to the entity routing table removes the ability to connect the LIF output to

[PATCH v2 14/14] drm: rcar-du: Configure DPAD0 routing through last group on Gen3

2017-06-26 Thread Laurent Pinchart
On Gen3 SoCs DPAD0 routing is configured through the last CRTC group, unlike on Gen2 where it is configured through the first CRTC group. Fix the driver accordingly. Fixes: 2427b3037710 ("drm: rcar-du: Add R8A7795 device support") Signed-off-by: Laurent Pinchart

Re: [PATCH] dt-bindings: media: Add r8a7796 DRIF bindings

2017-06-26 Thread Rob Herring
On Fri, Jun 23, 2017 at 10:25:02AM +0100, Ramesh Shanmugasundaram wrote: > Add r8a7796 DRIF bindings. > > Signed-off-by: Ramesh Shanmugasundaram > > --- > Hi DT & Media maintainers, All, > >This patch adds DRIF bindings for R8A7796 SoC. >It is

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-06-26 Thread Rob Herring
On Fri, Jun 23, 2017 at 11:34:44PM +0300, Sergei Shtylyov wrote: > From: Konstantin Kozhevnikov > > The image renderer, or the distortion correction engine, is a drawing > processor with a simple instruction system capable of referencing video > capture

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread Sylwester Nawrocki
On 06/26/2017 12:35 PM, Hugues FRUCHET wrote: >> What I am missing to support the GTA04 camera is the control of the optional >> "vana-supply". >> So the driver does not power up the camera module when needed and therefore >> probing fails. >> >> - vana-supply: a regulator to power up the

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-06-26 Thread Sergei Shtylyov
Hello! On 06/26/2017 10:49 PM, Rob Herring wrote: From: Konstantin Kozhevnikov The image renderer, or the distortion correction engine, is a drawing processor with a simple instruction system capable of referencing video capture data or data in an

Re: [PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable().

2017-06-26 Thread Sakari Ailus
Hi Nikolaus, On Mon, Jun 26, 2017 at 07:54:19PM +0200, H. Nikolaus Schaller wrote: > If a camera module driver specifies a format that is not > supported by omap3isp this ends in a NULL pointer > dereference instead of a simple fail. Has this happened in practice? If it does, it is probably a

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-06-26 Thread Geert Uytterhoeven
Hi Sergei, On Mon, Jun 26, 2017 at 9:56 PM, Sergei Shtylyov wrote: > On 06/26/2017 10:49 PM, Rob Herring wrote: >>> From: Konstantin Kozhevnikov >>> >>> The image renderer, or the distortion correction engine, is a

[PATCH] dvb-frontends: mb86a16: remove useless variables in signal_det()

2017-06-26 Thread Gustavo A. R. Silva
Remove useless variables wait_t and wait_sym and code related. Also, fix some coding style issues. Addresses-Coverity-ID: 1226947 Signed-off-by: Gustavo A. R. Silva --- drivers/media/dvb-frontends/mb86a16.c | 25 +++-- 1 file changed, 7

Potentially invalid memory accesses in file drivers/media/v4l2-core/videobuf-core.c

2017-06-26 Thread Shaobo
Hi there, My name is Shaobo He and I am a graduate student at University of Utah. I am using a static analysis tool to search for null pointer dereferences and came across a couple of potentially invalid memory accesses in the file drivers/media/v4l2-core/videobuf-core.c. Basically the

cron job: media_tree daily build: ERRORS

2017-06-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jun 27 05:00:17 CEST 2017 media-tree git hash:2748e76ddb2967c4030171342ebdd3faa6a5e8e8 media_build

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

2017-06-26 Thread Takiguchi, Yasunari
On 2017/06/26 10:24, Mauro Carvalho Chehab wrote: > Em Sun, 25 Jun 2017 09:15:06 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Fri, 23 Jun 2017 10:02:39 -0300 >> Mauro Carvalho Chehab escreveu: >> >>> Em Mon, 19 Jun 2017 16:56:13 +0900 >>>

[GIT PULL v2 for 4.13] ov6650 V4L2 sub-device conversion

2017-06-26 Thread Sakari Ailus
Hi Mauro, (v2, this time with the appropriate git tags, plus rebased on current media tree master. No other changes.) This set includes converting the ov6650 driver to V4L2 sub-device driver (from SoC camera). Rebased w/o conflicts on more recent media tree master. Please pull. The following

Re: [PATCH v1 2/6] [media] ov9650: add device tree support

2017-06-26 Thread Sakari Ailus
On Mon, Jun 26, 2017 at 07:46:34PM +0200, H. Nikolaus Schaller wrote: > Hi, > > > Am 26.06.2017 um 18:31 schrieb Sakari Ailus : > > > > Hi Hugues, > > > > On Thu, Jun 22, 2017 at 05:05:38PM +0200, Hugues Fruchet wrote: > >> @@ -1545,15 +1577,22 @@ static int

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Ralph Metzler
Daniel Scheller writes: > Am Mon, 26 Jun 2017 11:59:20 +0200 > schrieb Ralph Metzler : > > > Mauro Carvalho Chehab writes: > > > > > > Splitting it is OK. Including a *.c file no. It shouldn't be hard > > > to > > [...] > > > change the makefile to: > > >

Re: [PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable().

2017-06-26 Thread H. Nikolaus Schaller
Hi, > Am 26.06.2017 um 22:12 schrieb Sakari Ailus : > > Hi Nikolaus, > > On Mon, Jun 26, 2017 at 07:54:19PM +0200, H. Nikolaus Schaller wrote: >> If a camera module driver specifies a format that is not >> supported by omap3isp this ends in a NULL pointer >> dereference

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread H. Nikolaus Schaller
> Am 26.06.2017 um 13:16 schrieb Pavel Machek : > > Hi! > >>> You may want to try this one: >>> >>> commit 0eae9d2a8f096f703cbc8f9a0ab155cd3cc14cef >>> Author: Pavel >>> Date: Mon Feb 13 21:26:51 2017 +0100 >>> >>> omap3isp: fix VP2SDR bit so capture (not

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread H. Nikolaus Schaller
> Am 26.06.2017 um 22:04 schrieb Sylwester Nawrocki : > > On 06/26/2017 12:35 PM, Hugues FRUCHET wrote: >>> What I am missing to support the GTA04 camera is the control of the >>> optional "vana-supply". >>> So the driver does not power up the camera module when needed and

[PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Ralph Metzler
Daniel Scheller writes: > From: Daniel Scheller > > Original code at least has some signed/unsigned issues, resulting in > values like 32dBm. I will look into that. > Change signal strength readout to work without asking > the attached tuner, and use a lookup table

Re: [PATCH] dt-bindings: media: Add r8a7796 DRIF bindings

2017-06-26 Thread Geert Uytterhoeven
On Fri, Jun 23, 2017 at 11:25 AM, Ramesh Shanmugasundaram wrote: > Add r8a7796 DRIF bindings. > > Signed-off-by: Ramesh Shanmugasundaram > Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread Pavel Machek
On Mon 2017-06-26 08:05:04, H. Nikolaus Schaller wrote: > Hi Pavel, > > > Am 25.06.2017 um 11:18 schrieb Pavel Machek : > > > > Hi! > > > >> * unfortunately we still get no image :( > >> > >> The latter is likely a setup issue of our camera interface (OMAP3 ISP = > >> Image

Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread H. Nikolaus Schaller
Hi Hugues, > Am 23.06.2017 um 12:25 schrieb H. Nikolaus Schaller : > > Hi Hugues, > >> Am 22.06.2017 um 17:41 schrieb H. Nikolaus Schaller : >> >> >>> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : >>> >>> This patchset enables

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-26 Thread H. Nikolaus Schaller
> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : > > Add a first support of OV9655 variant. > Because of register set slightly different from OV9650/9652, > not all of the driver features are supported (controls). > Supported resolutions are limited to VGA, QVGA, QQVGA. >

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread H. Nikolaus Schaller
> Am 24.06.2017 um 00:24 schrieb Suman Anna : > > On 06/23/2017 01:59 PM, H. Nikolaus Schaller wrote: >> Hi Suman, >> >>> Am 23.06.2017 um 20:05 schrieb Suman Anna : >>> >> >> Or does it just mean that it defines the property name? > > Please

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread H. Nikolaus Schaller
Hi Pavel, > Am 25.06.2017 um 11:18 schrieb Pavel Machek : > > Hi! > >> * unfortunately we still get no image :( >> >> The latter is likely a setup issue of our camera interface (OMAP3 ISP = >> Image Signal Processor) which >> we were not yet able to solve. Oscilloscoping signals

Re: [PATCH 1/1] docs-rst: Document EBUSY for VIDIOC_S_FMT

2017-06-26 Thread Hans Verkuil
On 26/06/17 11:26, Sakari Ailus wrote: > VIDIOC_S_FMT may return EBUSY if the device is streaming or there are > buffers allocated. Document this. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Can you also add this to S_STD,

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-26 Thread Hugues FRUCHET
Hi Hans, thanks for review. Reply below. BR Hugues. On 06/22/2017 05:19 PM, Hans Verkuil wrote: > On 06/22/2017 05:12 PM, Hugues Fruchet wrote: >> Add flexibility on supported resolutions by cropping sensor >> image to fit user resolution format request. >> >> Signed-off-by: Hugues Fruchet

Re: [PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Jun 2017 10:55:34 +0200 Ralph Metzler escreveu: > Daniel Scheller writes: > > From: Daniel Scheller > > > > Original code at least has some signed/unsigned issues, resulting in > > values like 32dBm. > > I will look into that. > > >

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Jun 2017 11:59:20 +0200 Ralph Metzler escreveu: > Mauro Carvalho Chehab writes: > > Em Sun, 25 Jun 2017 19:52:59 +0200 > > Daniel Scheller escreveu: > > > > > Am Sat, 24 Jun 2017 13:50:01 -0300 > > > schrieb Mauro Carvalho Chehab

Re: [PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Ralph Metzler
Mauro Carvalho Chehab writes: > Em Mon, 26 Jun 2017 10:55:34 +0200 > Ralph Metzler escreveu: > > > Daniel Scheller writes: > > > From: Daniel Scheller > > > > > > Original code at least has some signed/unsigned issues, resulting in > > >

Re: [PATCH v11 00/19] Qualcomm video decoder/encoder driver

2017-06-26 Thread Stanimir Varbanov
Hi all, In case someone wants to play with the driver I've pushed a git tree at [1] which contains few patches on top of the driver. Those patches are on upstreaming phase but doesn't merged yet. [1] https://github.com/svarbanov/linux/tree/master-venus-v11 On 06/15/2017 07:31 PM, Stanimir

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Mauro Carvalho Chehab
Em Sun, 25 Jun 2017 19:52:59 +0200 Daniel Scheller escreveu: > Am Sat, 24 Jun 2017 13:50:01 -0300 > schrieb Mauro Carvalho Chehab : > > > Em Thu, 22 Jun 2017 23:35:27 +0200 > > Ralph Metzler escreveu: > > > > Would it be

[PATCH 1/1] docs-rst: Document EBUSY for VIDIOC_S_FMT

2017-06-26 Thread Sakari Ailus
VIDIOC_S_FMT may return EBUSY if the device is streaming or there are buffers allocated. Document this. Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/vidioc-g-fmt.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Ralph Metzler
Mauro Carvalho Chehab writes: > Em Thu, 22 Jun 2017 23:35:27 +0200 > Ralph Metzler escreveu: > > > Daniel Scheller writes: > > > Am Tue, 20 Jun 2017 16:10:43 -0300 > > > schrieb Mauro Carvalho Chehab : > > > ... > > > > > - Maybe for

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread H. Nikolaus Schaller
Hi Pavel, > Am 26.06.2017 um 10:39 schrieb Pavel Machek : > > On Mon 2017-06-26 08:05:04, H. Nikolaus Schaller wrote: >> Hi Pavel, >> >>> Am 25.06.2017 um 11:18 schrieb Pavel Machek : >>> >>> Hi! >>> * unfortunately we still get no image :( The

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support (fwd)

2017-06-26 Thread Hugues FRUCHET
Ok course, thanks Julia. On 06/25/2017 10:00 PM, Julia Lawall wrote: > Braces are probably missing aroud lines 1618-1620. > > julia > > -- Forwarded message -- > Date: Sun, 25 Jun 2017 23:06:03 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc:

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Ralph Metzler
Mauro Carvalho Chehab writes: > Em Sun, 25 Jun 2017 19:52:59 +0200 > Daniel Scheller escreveu: > > > Am Sat, 24 Jun 2017 13:50:01 -0300 > > schrieb Mauro Carvalho Chehab : > > > > > Em Thu, 22 Jun 2017 23:35:27 +0200 > > > Ralph

Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread Hugues FRUCHET
Hi Nikolaus, On 06/22/2017 05:41 PM, H. Nikolaus Schaller wrote: > >> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : >> >> This patchset enables OV9655 camera support. >> >> OV9655 support has been tested using STM32F4DIS-CAM extension board >> plugged on connector P1 of

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-26 Thread Hans Verkuil
On 26/06/17 11:53, Hugues FRUCHET wrote: > Hi Hans, thanks for review. > > Reply below. > > BR > Hugues. > > On 06/22/2017 05:19 PM, Hans Verkuil wrote: >> On 06/22/2017 05:12 PM, Hugues Fruchet wrote: >>> Add flexibility on supported resolutions by cropping sensor >>> image to fit user

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-26 Thread Hugues FRUCHET
On 06/23/2017 12:25 PM, H. Nikolaus Schaller wrote: > Hi Hugues, > >> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : >> >> From: "H. Nikolaus Schaller" >> >> This adds documentation of device tree bindings >> for the OV965X family camera sensor

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Mauro Carvalho Chehab
Em Mon, 26 Jun 2017 11:45:08 +0200 Ralph Metzler escreveu: > Mauro Carvalho Chehab writes: > > Em Thu, 22 Jun 2017 23:35:27 +0200 > > Ralph Metzler escreveu: > > > > > Daniel Scheller writes: > > > > Am Tue, 20 Jun 2017 16:10:43 -0300 > > >

Re: [PATCH v5 1/2] media: i2c: adv748x: add adv748x driver

2017-06-26 Thread Kieran Bingham
Thanks Rob, Comments addressed, and a new version 6 to be posted soon. On 22/06/17 22:34, Rob Herring wrote: > On Wed, Jun 14, 2017 at 08:58:12PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >>

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

2017-06-26 Thread Tony Lindgren
Tomi, * Tomi Valkeinen [170428 04:15]: > On 14/04/17 13:25, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The CEC pin was always pulled up, making it impossible to use it. ... > Tony, can you queue this? It's safe to apply separately from

Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-26 Thread Pavel Machek
Hi! > > You may want to try this one: > > > > commit 0eae9d2a8f096f703cbc8f9a0ab155cd3cc14cef > > Author: Pavel > > Date: Mon Feb 13 21:26:51 2017 +0100 > > > >omap3isp: fix VP2SDR bit so capture (not preview) works > > > >This is neccessary for capture (not preview)

Re: [PATCH v2] media: ov6650: convert to standalone v4l2 subdevice

2017-06-26 Thread Hans Verkuil
On 16/06/17 21:45, Janusz Krzysztofik wrote: > Remove the soc_camera dependencies and move the diver to i2c > > Lost features, fortunately not used or not critical on test platform: > - soc_camera power on/off callback - replaced with clock enable/disable > only, no support for platform

Re: [PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable().

2017-06-26 Thread Sakari Ailus
Hi Nikolaus, On Tue, Jun 27, 2017 at 07:46:51AM +0200, H. Nikolaus Schaller wrote: > Hi, > > > Am 26.06.2017 um 22:12 schrieb Sakari Ailus : > > > > Hi Nikolaus, > > > > On Mon, Jun 26, 2017 at 07:54:19PM +0200, H. Nikolaus Schaller wrote: > >> If a camera module driver