Re: [PATCH 1/3] [media] usb: constify usb_device_id

2017-08-13 Thread Laurent Pinchart
Hi Arvind, Thank you for the patch. On Sunday 13 Aug 2017 14:24:43 Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > >

[PATCH RFC] media: isl6421: add checks for current overflow

2017-08-13 Thread Mauro Carvalho Chehab
This Kaffeine's BZ: https://bugs.kde.org/show_bug.cgi?id=374693 affects SkyStar S2 PCI DVB-S/S2 rev 3.3 device. It could be due to a Kernel bug. While checking the Isil 6421, comparing with its manual, available at:

Re: [PATCH] [media] mxl111sf: Fix potential null pointer dereference

2017-08-13 Thread Michael Ira Krufky
On Sun, Aug 13, 2017 at 6:06 AM, Eugeniu Rosca wrote: > From: Eugeniu Rosca > > Reviewing the delta between cppcheck output of v4.9.39 and v4.9.40 > stable updates, I stumbled on the new warning: > > mxl111sf.c:80: (warning) Possible null pointer

[PATCH 5/6] staging: bcm2835-audio: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make these const as they are only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 6/6] [media] tuners: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make these const as they are only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/media/tuners/tda18271-maps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/tuners/tda18271-maps.c

[PATCH 1/6] [media] usb: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make these const as they are only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/media/usb/cx231xx/cx231xx-audio.c | 2 +- drivers/media/usb/em28xx/em28xx-audio.c | 2 +- drivers/media/usb/go7007/snd-go7007.c | 2 +-

[PATCH 2/6] [media] pci: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make these const as they are only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/media/pci/cobalt/cobalt-alsa-pcm.c | 4 ++-- drivers/media/pci/cx18/cx18-alsa-pcm.c | 2 +- drivers/media/pci/cx23885/cx23885-alsa.c | 2 +-

[PATCH 4/6] usb: gadget: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make this const as it is only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/usb/gadget/function/u_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_audio.c

Re: [PATCH RFC] media: isl6421: add checks for current overflow

2017-08-13 Thread Jemma Denson
Hi Mauro, Just tried this on my card - unfortunately the patch as is doesn't work. On 13/08/17 13:10, Mauro Carvalho Chehab wrote: This Kaffeine's BZ: https://bugs.kde.org/show_bug.cgi?id=374693 affects SkyStar S2 PCI DVB-S/S2 rev 3.3 device. It could be due to a Kernel bug. While

[PATCH] [media] media: imx: use setup_timer

2017-08-13 Thread Cihangir Akturk
Use setup_timer function instead of initializing timer with the function and data fields. Generated by: scripts/coccinelle/api/setup_timer.cocci. Signed-off-by: Cihangir Akturk --- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++---

[PATCH 0/6] drivers: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make snd_pcm_hardware structures const. Bhumika Goyal (6): [media] usb: make snd_pcm_hardware const [media] pci: make snd_pcm_hardware const drm: bridge: dw-hdmi: make snd_pcm_hardware const usb: gadget: make snd_pcm_hardware const staging: bcm2835-audio: make snd_pcm_hardware const

[PATCH 3/6] drm: bridge: dw-hdmi: make snd_pcm_hardware const

2017-08-13 Thread Bhumika Goyal
Make this const as it is only used during a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] media: isl6421: add checks for current overflow

2017-08-13 Thread Mauro Carvalho Chehab
This Kaffeine's BZ: https://bugs.kde.org/show_bug.cgi?id=374693 affects SkyStar S2 PCI DVB-S/S2 rev 3.3 device. It could be due to a Kernel bug. While checking the Isil 6421, comparing with its manual, available at:

Re: [PATCH RFC] media: isl6421: add checks for current overflow

2017-08-13 Thread Mauro Carvalho Chehab
Em Sun, 13 Aug 2017 19:47:37 +0100 Jemma Denson escreveu: > Hi Mauro, > > Just tried this on my card - unfortunately the patch as is doesn't work. > > On 13/08/17 13:10, Mauro Carvalho Chehab wrote: > > This Kaffeine's BZ: > > https://bugs.kde.org/show_bug.cgi?id=374693

cron job: media_tree daily build: ERRORS

2017-08-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Aug 14 05:00:16 CEST 2017 media-tree git hash:ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0 media_build

[PATCH 1/3] [media] usb: constify usb_device_id

2017-08-13 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. 'drivers/media/usb/b2c2/flexcop-usb.c' Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['.

[PATCH 0/3] constify media usb_device_id

2017-08-13 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] [media] usb: constify usb_device_id [PATCH 2/3] [media] rc: constify usb_device_id

[PATCH 3/3] [media] radio: constify usb_device_id

2017-08-13 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/media/radio/dsbr100.c | 2 +-

[PATCH 2/3] [media] rc: constify usb_device_id

2017-08-13 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/media/rc/ati_remote.c | 2 +-

[PATCH] [media] mxl111sf: Fix potential null pointer dereference

2017-08-13 Thread Eugeniu Rosca
From: Eugeniu Rosca Reviewing the delta between cppcheck output of v4.9.39 and v4.9.40 stable updates, I stumbled on the new warning: mxl111sf.c:80: (warning) Possible null pointer dereference: rbuf Since copying state->rcvbuf into rbuf is not needed in the 'write-only'