Re: [PATCH 13/15] scsi: make device_type const

Bhumika, > Make these const as they are only stored in the type field of a device > structure, which is const. Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

Em Thu, 24 Aug 2017 18:07:48 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the update! A few comments below. > > (Cc Hans and Laurent.) > > On Thu, Aug 24, 2017 at 09:07:35AM -0300, Mauro Carvalho Chehab wrote: > > From: "mche...@s-opensource.com"

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

Em Fri, 25 Aug 2017 10:59:40 +0200 Hans Verkuil escreveu: > On 24/08/17 14:07, Mauro Carvalho Chehab wrote: > > From: "mche...@s-opensource.com" > > > > When we added support for omap3, back in 2010, we added a new > > type of V4L2 devices that

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: > From: Mauro Carvalho Chehab > > As both vdev-centric and mc-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab

[PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

From: Mauro Carvalho Chehab As both vdev-centric and mc-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab

[PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

From: "mche...@s-opensource.com" When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we never made it clear, at the V4L2 spec, about the differences between both types. Let's

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 12:13:53 +0200 Hans Verkuil escreveu: > On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 25 Aug 2017 11:44:27 +0200 > > Hans Verkuil escreveu: > > > >> On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: > >>>

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 12:13:53 +0200 > Hans Verkuil escreveu: > >> On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 25 Aug 2017 11:44:27 +0200 >>> Hans Verkuil escreveu: >>> On

Re: [PATCH 4/4] v4l: async: add comment about re-probing to v4l2_async_notifier_unregister()

On 24/08/17 18:17, Sakari Ailus wrote: > Hi Hans, > > On Thu, Aug 24, 2017 at 09:59:41AM +0200, Hans Verkuil wrote: >> On 08/23/17 21:03, Niklas Söderlund wrote: >>> Hi, >>> >>> On 2017-08-18 15:42:37 +0200, Niklas Söderlund wrote: Hi Sakari and Laurent, Thanks for your feedback.

[PATCH 3/3] media: add V4L2_CAP_VDEV_CENTERED flag on vdev-centric drivers

From: Mauro Carvalho Chehab Those devices are controlled via their V4L2 device. Add a flag to indicate them as such. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 0/3] document types of hardware control for V4L2

On 2010, we introduced a new way to control complex V4L2 devices used on embedded systems, but this was never documented, nor it is possible for an userspace applicatin to detect the kind of control a device supports. This series fill the gap. Mauro Carvalho Chehab (3): media: open.rst:

Re: [PATCH 3/3] media: add V4L2_CAP_VDEV_CENTERED flag on vdev-centric drivers

On Fri, 2017-08-25 at 06:40 -0300, Mauro Carvalho Chehab wrote: > From: Mauro Carvalho Chehab > > Those devices are controlled via their V4L2 device. Add a > flag to indicate them as such. > > Signed-off-by: Mauro Carvalho Chehab >

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 11:44:27 +0200 Hans Verkuil escreveu: > On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: > > From: Mauro Carvalho Chehab > > > > As both vdev-centric and mc-centric devices may implement the > > same APIs, we need a flag to

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 11:44:27 +0200 > Hans Verkuil escreveu: > >> On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: >>> From: Mauro Carvalho Chehab >>> >>> As both vdev-centric and mc-centric

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 25/08/17 12:50, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 12:42:51 +0200 > Hans Verkuil escreveu: > >> On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 25 Aug 2017 12:13:53 +0200 >>> Hans Verkuil escreveu: >>> On

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

On 25/08/17 11:40, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. Yet, we never made it clear, at the V4L2

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 12:42:51 +0200 Hans Verkuil escreveu: > On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 25 Aug 2017 12:13:53 +0200 > > Hans Verkuil escreveu: > > > >> On 08/25/2017 12:06 PM, Mauro Carvalho Chehab wrote: > >>> Em

[PATCH 0/1] build: ddbridge can be now compiled for kernels older than 3.8

From: Jasmin Jessich When you have already applied patch https://www.mail-archive.com/linux-media@vger.kernel.org/msg117633.html this patch will re-enable ddbridge for all older Kernels. I have tested it with Kernel 2.6.36, 2.6.37, 3.4, 3.13 and 4.4. Please note, that you need

[PATCH 1/1] build: ddbridge can be now compiled for kernels older than 3.8

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/versions.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/v4l/versions.txt b/v4l/versions.txt index 6f27929..7634038 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -126,8 +126,6 @@ IR_SPI

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 26 05:00:15 CEST 2017 media-tree git hash:0779b8855c746c90b85bfe6e16d5dfa2a6a46655 media_build

[PATCH 0/2] fix compile for kernel 3.3 and older

From: Jasmin Jessich This series fixed compilation errors for older kernels. I have tested it with Kernel 2.6.36, 2.6.37, 3.4, 3.13 and 4.4. Please note, that you need this patch https://www.mail-archive.com/linux-media@vger.kernel.org/msg117633.html applied to be able to

[PATCH 1/2] build: Add compat code for PCI_DEVICE_SUB

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/compat.h | 6 ++ v4l/scripts/make_config_compat.pl | 1 + 2 files changed, 7 insertions(+) diff --git a/v4l/compat.h b/v4l/compat.h index 9c5d87d..1ab5c0f 100644 ---

[PATCH 2/2] build: Fixed backports/v3.3_eprobe_defer.patch

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- backports/v3.3_eprobe_defer.patch | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/backports/v3.3_eprobe_defer.patch b/backports/v3.3_eprobe_defer.patch index ec949cc..327979d

[PATCH] build: ddbridge can be now compiled for kernels older than 3.8

From: Jasmin Jessich When you have already applied patch https://www.mail-archive.com/linux-media@vger.kernel.org/msg117633.html this patch will re-enable ddbridge for all older Kernels. I have tested it with Kernel 2.6.36, 2.6.37, 3.4, 3.13 and 4.4. Please note, that you need

[PATCH] build: ddbridge can be now compiled for kernels older than 3.8

From: Jasmin Jessich Signed-off-by: Jasmin Jessich --- v4l/versions.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/v4l/versions.txt b/v4l/versions.txt index 6f27929..7634038 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -126,8 +126,6 @@ IR_SPI

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 12:56:30 +0200 Hans Verkuil escreveu: > On 25/08/17 12:50, Mauro Carvalho Chehab wrote: > > Em Fri, 25 Aug 2017 12:42:51 +0200 > > Hans Verkuil escreveu: > > > >> On 08/25/2017 12:35 PM, Mauro Carvalho Chehab wrote: > >>> Em Fri,

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

Hi Hans, On Friday, 25 August 2017 11:59:40 EEST Hans Verkuil wrote: > On 24/08/17 14:07, Mauro Carvalho Chehab wrote: > > From: "mche...@s-opensource.com" > > > > When we added support for omap3, back in 2010, we added a new > > type of V4L2 devices that aren't fully

Re: [PATCH v7] rockchip/rga: v4l2 m2m support

Hi Jacob, As promised, some more (small) review comments below. On 03/08/17 07:23, Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image

[PATCH v2 2/3] media: open.rst: document devnode-centric and mc-centric types

From: "mche...@s-opensource.com" When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we never made it clear, at the V4L2 spec, about the differences between both types. Let's

[PATCH v2 3/3] media: videodev2: add a flag for MC-centric devices

From: Mauro Carvalho Chehab As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab

[PATCH v2 1/3] media: open.rst: better document device node naming

Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst |

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

Hi Mauro, Thanks for the update. A few more small comments below. On Fri, Aug 25, 2017 at 06:40:05AM -0300, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

On 25/08/17 13:35, Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 08:30:37 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Fri, 25 Aug 2017 08:15:03 -0300 >> Mauro Carvalho Chehab escreveu: >> >>> Em Fri, 25 Aug 2017 12:56:30 +0200 >>> Hans

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

Hi Mauro, Thank you for the patch. On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the

[PATCH v2 0/3] document types of hardware control for V4L2

On 2010, we introduced a new way to control complex V4L2 devices used on embedded systems, but this was never documented, nor it is possible for an userspace applicatin to detect the kind of control a device supports. This series fill the gap. Mauro Carvalho Chehab (3): media: open.rst: better

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 08:30:37 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 25 Aug 2017 08:15:03 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Fri, 25 Aug 2017 12:56:30 +0200 > > Hans Verkuil escreveu: > > > > > On

[PATCH] [media] omap3isp: make omap3isp_prev_csc and omap3isp_prev_rgbtorgb const

Make these const as they are only used as a copy operation. Signed-off-by: Bhumika Goyal --- drivers/media/platform/omap3isp/isppreview.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isppreview.c

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Em Fri, 25 Aug 2017 08:15:03 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 25 Aug 2017 12:56:30 +0200 > Hans Verkuil escreveu: > > > On 25/08/17 12:50, Mauro Carvalho Chehab wrote: > > > Em Fri, 25 Aug 2017 12:42:51 +0200 > > > Hans Verkuil

Re: [PATCH v2 1/3] media: open.rst: better document device node naming

Em Fri, 25 Aug 2017 09:52:40 -0300 Mauro Carvalho Chehab escreveu: > Right now, only kAPI documentation describes the device naming. > However, such description is needed at the uAPI too. Add it, > and describe how to get an unique identify for a given device. > >

Re: DRM Format Modifiers in v4l2

On 24/08/17 14:26, Brian Starkey wrote: > On Thu, Aug 24, 2017 at 01:37:35PM +0200, Hans Verkuil wrote: >> On 08/24/17 13:14, Brian Starkey wrote: >>> Hi Hans, >>> >>> On Mon, Aug 21, 2017 at 06:36:29PM +0200, Hans Verkuil wrote: On 08/21/2017 06:01 PM, Daniel Vetter wrote: > On Mon, Aug

Re: [PATCH RFC v2] media: open.rst: document devnode-centric and mc-centric types

On 24/08/17 14:07, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. Yet, we never made it clear, at the V4L2

Re: [PATCH 02/15] drm: make device_type const

On Sat, Aug 19, 2017 at 01:52:13PM +0530, Bhumika Goyal wrote: > Make these const as they are only stored in the type field of a device > structure, which is const. > Done using Coccinelle. I can't apply this, it's missing your s-o-b line. You can just replay with that. Thanks, Daniel > --- >

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

Em Fri, 25 Aug 2017 16:11:15 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: > > From: "mche...@s-opensource.com" > > > > When we

Re: [PATCH v2 2/3] media: open.rst: document devnode-centric and mc-centric types

On 25/08/17 14:52, Mauro Carvalho Chehab wrote: > From: "mche...@s-opensource.com" > > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. Yet, we never made it clear, at the V4L2

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

On 25/08/17 15:11, Laurent Pinchart wrote: > Hi Mauro, > > Thank you for the patch. > > On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: >> From: "mche...@s-opensource.com" >> >> When we added support for omap3, back in 2010, we added a new >> type

Re: [PATCH v2 1/3] media: open.rst: better document device node naming

On 25/08/17 14:52, Mauro Carvalho Chehab wrote: > Right now, only kAPI documentation describes the device naming. > However, such description is needed at the uAPI too. Add it, > and describe how to get an unique identify for a given device. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Hi Benoit, On Mon, Aug 07, 2017 at 02:24:24PM -0500, Benoit Parrot wrote: > > +#define CSI2RX_STREAMS_MAX 4 > > + > > Just to confirm here that "streams" in this case are equivalent to > "Virtual Channel", correct? Kind of, yes, but it's a bit more complicated than that. The streams are the

Re: [PATCH v7] rockchip/rga: v4l2 m2m support

Hi Hans, 2017-08-21 22:16 GMT+08:00 Hans Verkuil : > Hi Jacob, > > On 08/03/2017 07:23 AM, Jacob Chen wrote: >> Rockchip RGA is a separate 2D raster graphic acceleration unit. It >> accelerates 2D graphics operations, such as point/line drawing, image >> scaling, rotation,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Yong, On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > *notifier) > > > > > +{ > > > > > + struct sun6i_csi *csi = > > > > > + container_of(notifier, struct sun6i_csi, > > > >

Re: [PATCH 1/3] media: open.rst: document devnode-centric and mc-centric types

Hi Mauro, On Friday, 25 August 2017 16:38:23 EEST Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 16:11:15 +0300 Laurent Pinchart escreveu: > > On Friday, 25 August 2017 12:40:05 EEST Mauro Carvalho Chehab wrote: > >> From: "mche...@s-opensource.com" > >> > >> When

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi Todor, Thanks a lot for working on the upstream support for this! On 08/08/2017 03:30 PM, Todor Tomov wrote: > +The Camera Subsystem hardware found on 8x16 processors and supported by the > +driver consists of: > + > +- 2 CSIPHY modules. They handle the Physical layer of the CSI2 receivers. >

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

Hi Laurent, On Wed, Aug 23, 2017 at 12:03:32AM +0300, Laurent Pinchart wrote: > > + - phys: phandle to the external D-PHY > > + - phy-names: must contain dphy, if the implementation uses an > > + external D-PHY > > I would move the last two properties in an optional

Re: [PATCH 2/3] media: videodev2: add a flag for vdev-centric devices

Hi Mauro, On Friday, 25 August 2017 13:06:32 EEST Mauro Carvalho Chehab wrote: > Em Fri, 25 Aug 2017 11:44:27 +0200 Hans Verkuil escreveu: > > On 08/25/2017 11:40 AM, Mauro Carvalho Chehab wrote: > > > From: Mauro Carvalho Chehab > > > > > > As both vdev-centric and

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Hi Laurent, I've removed the comments I'll take into account On Mon, Aug 07, 2017 at 11:42:01PM +0300, Laurent Pinchart wrote: > > + csi2rx_reset(csi2rx); > > + > > + // TODO: modify the mapping of the DPHY lanes? > > The mapping should be read from DT and applied here. As far as I

[PATCH v3 6/7] media: videodev2: add a flag for MC-centric devices

As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst| 7 +++

[PATCH v3 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 95 +++ Documentation/media/uapi/v4l/v4l2.rst | 1

[PATCH v3 3/7] media: open.rst: remove the minor number range

minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take care of it. So, remove this

[PATCH v3 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

The documentation doesn't mention if vdev-centric hardware control would have subdev API or not. Add a notice about that, reflecting the current status, where three drivers use it, in order to support some subdev-specific controls. Signed-off-by: Mauro Carvalho Chehab

[PATCH v3 0/7] document types of hardware control for V4L2

On 2010, we introduced a new way to control complex V4L2 devices used on embedded systems, but this was never documented, nor it is possible for an userspace applicatin to detect the kind of control a device supports. This series fill the gap. Mauro Carvalho Chehab (7): media: add glossary.rst

[PATCH v3 2/7] media: open.rst: better document device node naming

Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst |

[PATCH v3 5/7] media: open.rst: Adjust some terms to match the glossary

As we now have a glossary, some terms used on open.rst require adjustments. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH v3 4/7] media: open.rst: document devnode-centric and mc-centric types

When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we have never clearly documented in the V4L2 specification the differences between the two types. Let's document them based on the the current

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

Hi Maxime, On Friday, 25 August 2017 17:44:40 EEST Maxime Ripard wrote: > On Wed, Aug 23, 2017 at 12:03:32AM +0300, Laurent Pinchart wrote: > >> + - phys: phandle to the external D-PHY > >> + - phy-names: must contain dphy, if the implementation uses an > >> + external D-PHY >