[PATCH 2/2] [media] meye: Adjust two function calls together with a variable assignment

From: Markus Elfring Date: Sun, 3 Sep 2017 15:41:53 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 1/2] [media] meye: Delete three error messages for a failed memory allocation in meye_probe()

From: Markus Elfring Date: Sun, 3 Sep 2017 15:30:04 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] Motion Eye: Adjustments for meye_probe()

From: Markus Elfring Date: Sun, 3 Sep 2017 15:54:45 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete three error messages for a failed memory allocation Adjust two function calls together with a

[PATCH v2] media: net.h: add kernel-doc and use it at Documentation/

As we did with frontend.h, ca.h and dmx.h, move the struct definition to net.h. That should help to keep it updated, as more stuff gets added there. Signed-off-by: Mauro Carvalho Chehab --- v2: - Version 1 was broken: it was missing net-types.rst file and if_num was

Re: [PATCH] v4l: use struct v4l2_buffer explicitly instead of void *

Hi Mauro, On Sun, 27 Aug 2017, Mauro Carvalho Chehab wrote: > Em Fri, 28 Jul 2017 14:45:37 +0200 (CEST) > Guennadi Liakhovetski escreveu: > > > A number of functions use void * for a struct v4l2_buffer parameter. > > Avoid that to improve compile-time checking. > >

Re: UVC property auto update

Hi Edgar, I'm adding UVC maintainer to CC, he might have missed this email. Could you also tell us what cameras have those features? A recent patch from me extends the UVC driver use of the Interrupt endpoint for asynchronous control completion notifications. This would be another extension

Re: [PATCH v6 5/5] v4l: fwnode: Support generic parsing of graph endpoints in a single port

Hi Laurent, On Sat, Sep 02, 2017 at 12:52:47PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Saturday, 2 September 2017 01:57:48 EEST Sakari Ailus wrote: > > On Fri, Sep 01, 2017 at 01:28:40PM +0200, Hans Verkuil wrote: > > >> diff --git a/include/media/v4l2-fwnode.h

[PATCH 1/1] staging/atomisp: fix header guards

Files input_formatter_subsystem_defs.h begin with: #ifndef _if_subsystem_defs_h #define _if_subsystem_defs_h__ and end with: #endif /* _if_subsystem_defs_h__ */ The intent seems to have been to use _if_subsystem_defs_h__ everywhere but two underscores are missing in the initial

Re: DRM Format Modifiers in v4l2

On Fri, Sep 1, 2017 at 2:43 PM, Rob Clark wrote: > On Fri, Sep 1, 2017 at 3:13 AM, Laurent Pinchart > wrote: >> Hi Nicolas, >> >> On Thursday, 31 August 2017 19:12:58 EEST Nicolas Dufresne wrote: >>> Le jeudi 31 août 2017 à 17:28 +0300,

[PATCH 10/10] staging/atomisp: Use ARRAY_SIZE macro

Use ARRAY_SIZE macro, rather than explicitly coding some variant of it yourself. Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) /ARRAY_SIZE(\1)/g' and manual check/verification. Signed-off-by:

[PATCH 5/10] [media] lgdt3306a: Use ARRAY_SIZE macro

Use ARRAY_SIZE macro, rather than explicitly coding some variant of it yourself. Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) /ARRAY_SIZE(\1)/g' and manual check/verification. Signed-off-by:

[PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

We only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier. Signed-off-by: Sakari Ailus ---

[PATCH v7 08/18] omap3isp: Print the name of the entity where no source pads could be found

If no source pads are found in an entity, print the name of the entity. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c

[PATCH v7 06/18] rcar-vin: Use generic parser for parsing fwnode endpoints

Instead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus --- drivers/media/platform/rcar-vin/rcar-core.c | 112 +---

[PATCH v7 10/18] v4l: async: Introduce macros for calling async ops callbacks

Add two macros to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-async.c | 19 +++

[PATCH v7 02/18] v4l: async: Add V4L2 async documentation to the documentation build

The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil --- Documentation/media/kapi/v4l2-async.rst | 3 +++

[PATCH v7 01/18] v4l: fwnode: Move KernelDoc documentation to the header

In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequientally makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation.

[PATCH v7 12/18] v4l: async: Allow binding notifiers to sub-devices

Registering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device). This information is not available for sub-device drivers at probe time. What this

[PATCH v7 09/18] v4l: async: Move async subdev notifier operations to a separate structure

From: Laurent Pinchart The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function

[PATCH v7 16/18] v4l2-fwnode: Add convenience function for parsing common external refs

Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus

[PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors

The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel

[PATCH v7 00/18] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority

[PATCH v7 13/18] dt: bindings: Add a binding for flash devices associated to a sensor

Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus Acked-by: Rob Herring ---

[PATCH v7 15/18] v4l2-fwnode: Add convenience function for parsing generic references

Add function v4l2_fwnode_reference_count() for counting external references and v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. struct

[PATCH v7 03/18] docs-rst: v4l: Include Qualcomm CAMSS in documentation build

Qualcomm CAMSS was left out from documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil --- Documentation/media/v4l-drivers/index.rst | 1 + 1 file

[PATCH v7 04/18] v4l: fwnode: Support generic parsing of graph endpoints in a device

The current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback. Signed-off-by: Sakari

[PATCH v7 18/18] arm: dts: omap3: N9/N950: Add flash references to the camera

Add flash and indicator LED phandles to the sensor node. Signed-off-by: Sakari Ailus --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++-- arch/arm/boot/dts/omap3-n950.dts | 1 + 3 files changed, 4 insertions(+), 2

[PATCH v7 17/18] smiapp: Add support for flash and lens devices

Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. This

[PATCH v7 11/18] v4l: async: Register sub-devices before calling bound callback

Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus ---

[PATCH v7 05/18] omap3isp: Use generic parser for parsing fwnode endpoints

Instead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.c | 115 +++---

[PATCH 3/7] media: vivid.rst: add a blank line to correct ReST format

On all vivid parameters, there's an space after the parameter, except for "DV Timings Signal Mode". That makes this single one to be written in bold, and, at PDF output, at the same line as its description. Use the same convention as the other parameters, in order to adjust its output.

[PATCH 7/7] media: index.rst: don't write "Contents:" on PDF output

Right now, Sphinx unconditionally creates a blank page with just "Contents:" on it, on PDF output. While this makes sense for html, it doesn't o PDF, as LaTeX does what's required automatically. Fix it. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 6/7] media: pixfmt*.rst: replace a two dots by a comma

On several tables, the color sample location table preamble is written as: Color Sample Location.. Instead of: Color Sample Location: I suspect that the repetition of such pattern was due to some copy-and-paste (or perhaps some error during DocBook conversion). Anyway, fix it.

[PATCH 0/7] Another set of fixes for PDF output

There are other things that are needed for a proper PDF output, and a fix for yet another Sphinx 1.6 breakage. After this patch series, PDF output now looks OK on Sphinx 1.4 to 1.6. There's, however, one step back on Sphinx 1.6: I couldn't find any way to use a background color for notifications

[PATCH 1/7] media: format.rst: use the right markup for important notes

There's an important note there, but it is not using the ReST markup. So, it doesn't get any visual highlight on the output. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/format.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/7] media: v4l2 uapi book: get rid of driver programming's chapter

It doesn't make any sense having a driver programming's chapter at the uAPI book, as this is related to kernel API. Also, we now have such kAPI book where V4L2 driver programming is covered. So, get rid of this left-over. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 4/7] media: vidioc-g-fmt.rst: adjust table format

While doing a visual inspection with Sphinx 1.5, I noticed that one of the columns was smaller than the text written there. As this is the only thing I noticed with Sphinx 1.5, I suspect that this was also a problem with Sphinx 1.4. Yet, I opted to touch it in a way that wouldn't cause backward

[PATCH 5/7] media: fix build breakage with Sphinx 1.6

Not sure why, but, on this particular document, on Sphinx 1.4 and 1.5, the usage of \small here causes it to write the table at the same column where the text before it ended, with makes the table to go out of the page. A possible solution would be to add a \newline on latex raw, with was the

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

Em Sun, 3 Sep 2017 22:05:23 +0200 Honza Petrouš escreveu: > 1) #define CA_SET_DESCR _IOW('o', 134, ca_descr_t) > > > CA_SET_DESCR is used for feeding descrambler device > with correct keys (called here "control words") what >

Re: [PATCH 00/15] Improve DVB documentation and reduce its gap

Hi Mauro, On 01.09.2017 11:32, Mauro Carvalho Chehab wrote: > Em Fri, 1 Sep 2017 10:40:28 +0200 > Honza Petrouš escreveu: > >> 2017-09-01 1:46 GMT+02:00 Mauro Carvalho Chehab : >>> The DVB documentation was negligected for a long time, with >>>

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

Em Sun, 3 Sep 2017 22:05:23 +0200 Honza Petrouš escreveu: > > There is still a gap at the CA API, as there are three ioctls that are used > > only by a few drivers and whose structs are not properly documented: > > CA_GET_MSG, CA_SEND_MSG and CA_SET_DESCR. > > > > The first

Re: [PATCH 1/1] docs-rst: media: Don't use \small for V4L2_PIX_FMT_SRGGB10 documentation

Em Sun, 3 Sep 2017 23:12:33 +0300 Sakari Ailus escreveu: > There appears to be an issue in using \small in certain cases on Sphinx > 1.4 and 1.5. Other format documents don't use \small either, remove it > from here as well. > > Signed-off-by: Sakari Ailus

[PATCH v7 1/1] dt: bindings: smiapp: Document lens-focus and flash properties

Document optional lens-focus and flash properties for the smiapp driver. Signed-off-by: Sakari Ailus --- Hi all, This should precede the smiapp driver change. Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 4/7] [media] Hexium Gemini: Improve a size determination in hexium_attach()

From: Markus Elfring Date: Sun, 3 Sep 2017 19:51:46 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/7] [media] saa7164: Improve a size determination in two functions

From: Markus Elfring Date: Sun, 3 Sep 2017 17:53:05 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 3/7] [media] Hexium Gemini: Delete an error message for a failed memory allocation in hexium_attach()

From: Markus Elfring Date: Sun, 3 Sep 2017 19:23:37 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/7] [media] SAA71..: Adjustments for four function implementations

>From 2f421e83375df1aeef50ce053f1dbcd1366c2365 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Sun, 3 Sep 2017 20:50:10 +0200 Subject: [PATCH 0/7] [media] SAA71..: Adjustments for four function implementations Three update suggestions were taken into account

[PATCH 6/7] [media] Hexium Orion: Improve a size determination in hexium_probe()

From: Markus Elfring Date: Sun, 3 Sep 2017 20:00:17 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 7/7] [media] Hexium Orion: Adjust one function call together with a variable assignment

From: Markus Elfring Date: Sun, 3 Sep 2017 20:12:36 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

> There is still a gap at the CA API, as there are three ioctls that are used > only by a few drivers and whose structs are not properly documented: > CA_GET_MSG, CA_SEND_MSG and CA_SET_DESCR. > > The first two ones seem to be related to a way that a few drivers > provide to send/receive messages.

[PATCH 1/1] docs-rst: media: Don't use \small for V4L2_PIX_FMT_SRGGB10 documentation

There appears to be an issue in using \small in certain cases on Sphinx 1.4 and 1.5. Other format documents don't use \small either, remove it from here as well. Signed-off-by: Sakari Ailus --- Hi Mauro, What would you think of this as an alternative approach? No

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

> There is still a gap at the CA API, as there are three ioctls that are used > only by a few drivers and whose structs are not properly documented: > CA_GET_MSG, CA_SEND_MSG and CA_SET_DESCR. > > The first two ones seem to be related to a way that a few drivers > provide to send/receive messages.

[PATCH 1/7] [media] saa7164: Delete an error message for a failed memory allocation in saa7164_buffer_alloc()

From: Markus Elfring Date: Sun, 3 Sep 2017 17:47:41 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 5/7] [media] Hexium Orion: Delete an error message for a failed memory allocation in hexium_probe()

From: Markus Elfring Date: Sun, 3 Sep 2017 19:55:25 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Sep 4 05:00:15 CEST 2017 media-tree git hash:fce4b371fe5c99a9c05db8493d72f0d1a474ab26 media_build