Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices associated to a sensor

2017-09-04 Thread Sakari Ailus
On Mon, Sep 04, 2017 at 04:31:51PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > Camera flash drivers (and LEDs) are separate from the sensor devices in > > DT. In order to make an association between the two, provide the > > association information to the software.

Re: [PATCH v7 04/18] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-04 Thread Hans Verkuil
On 09/04/2017 05:54 PM, Sakari Ailus wrote: >>> +/** >>> + * v4l2_async_notifier_parse_fwnode_endpoints - Parse V4L2 fwnode >>> endpoints in a >>> + * device node >>> + * @dev: the device the endpoints of which are to be parsed >>> + * @notifier: notifier

Re: [PATCH v7 15/18] v4l2-fwnode: Add convenience function for parsing generic references

2017-09-04 Thread Hans Verkuil
On 09/04/2017 06:34 PM, Sakari Ailus wrote: >>> MODULE_LICENSE("GPL"); >>> MODULE_AUTHOR("Sakari Ailus "); >>> MODULE_AUTHOR("Sylwester Nawrocki "); >>> diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h >>> index

Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors

2017-09-04 Thread Sakari Ailus
Hi Hans, On Mon, Sep 04, 2017 at 04:37:29PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > The lens-focus property contains a phandle to the lens voice coil driver > > that is associated to the sensor; typically both are contained in the same > > camera module. > >

Re: [PATCH v7 15/18] v4l2-fwnode: Add convenience function for parsing generic references

2017-09-04 Thread Sakari Ailus
Hi Hans, On Mon, Sep 04, 2017 at 04:44:48PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > Add function v4l2_fwnode_reference_count() for counting external > > references and v4l2_fwnode_reference_parse() for parsing them as async > > sub-devices. > > > > This can

Re: [PATCH v7 12/18] v4l: async: Allow binding notifiers to sub-devices

2017-09-04 Thread Sakari Ailus
Hi Hans, On Mon, Sep 04, 2017 at 04:56:29PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > Registering a notifier has required the knowledge of struct v4l2_device > > for the reason that sub-devices generally are registered to the > > v4l2_device (as well as the

Re: [PATCH v7 09/18] v4l: async: Move async subdev notifier operations to a separate structure

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > From: Laurent Pinchart > > The async subdev notifier .bound(), .unbind() and .complete() operations > are function pointers stored directly in the v4l2_async_subdev > structure. As the structure isn't immutable,

Re: [PATCH] uvcvideo: extend UVC_QUIRK_FIX_BANDWIDTH to MJPEG streams

2017-09-04 Thread Laurent Pinchart
Hi Pavel, Thank you for the patch. On Monday, 4 September 2017 11:14:17 EEST Pavel Rojtberg wrote: > From: Pavel Rojtberg > > attaching two Logitech C615 webcams currently results in > VIDIOC_STREAMON: No space left on device > as the required bandwidth is not estimated

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

2017-09-04 Thread Mauro Carvalho Chehab
Em Mon, 4 Sep 2017 09:12:49 +0200 Honza Petrouš escreveu: > 2017-09-04 2:54 GMT+02:00 Mauro Carvalho Chehab : > > Em Sun, 3 Sep 2017 22:05:23 +0200 > > Honza Petrouš escreveu: > > > >> 1) #define CA_SET_DESCR _IOW('o',

Re: UVC property auto update

2017-09-04 Thread Edgar Thier
Hi Guennadi, > But that patch only re-reads the flags. What does that give you? Do those > > flags change? In which way? As far as I understand the UVC Autoupdate > feature, a change in GET_INFO data is only one possibility, (arguably) a > more important one is changes in GET_CUR data. My

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

2017-09-04 Thread Honza Petrouš
2017-09-04 11:06 GMT+02:00 Mauro Carvalho Chehab : > Em Mon, 4 Sep 2017 09:12:49 +0200 > Honza Petrouš escreveu: > >> 2017-09-04 2:54 GMT+02:00 Mauro Carvalho Chehab : >> > Em Sun, 3 Sep 2017 22:05:23 +0200 >> > Honza Petrouš

Re: [PATCH 00/15] Improve DVB documentation and reduce its gap

2017-09-04 Thread Mauro Carvalho Chehab
Em Mon, 4 Sep 2017 02:55:15 +0200 Soeren Moch escreveu: > Hi Mauro, > > On 01.09.2017 11:32, Mauro Carvalho Chehab wrote: > > Em Fri, 1 Sep 2017 10:40:28 +0200 > > Honza Petrouš escreveu: > > > >> 2017-09-01 1:46 GMT+02:00 Mauro Carvalho Chehab > >>

[PATCH 0/2] Documents the two remaining CA ioctls

2017-09-04 Thread Mauro Carvalho Chehab
Thanks to some discussions I had with Honza, I got some ideas about how to document the last three undocumented ioctls from ca.h, together with the two data structures. With this series (and the previous one), everything at CA, Net, Demux and DVBv5 Frontend DVB APIs are now documented. That's

[PATCH 2/2] media: ca.h: document ca_msg and the corresponding ioctls

2017-09-04 Thread Mauro Carvalho Chehab
Usually, CA messages are sent/received via reading/writing at the CA device node. However, two drivers (dst_ca and firedtv-ci) also implement it via ioctls. Apparently, on both cases, the net result is the same. Anyway, let's document it. Signed-off-by: Mauro Carvalho Chehab

[PATCH 1/2] media: ca docs: document CA_SET_DESCR ioctl and structs

2017-09-04 Thread Mauro Carvalho Chehab
The av7110 driver uses CA_SET_DESCR to store the descrambler control words at the CA descrambler slots. Document it. Thanks-to: Honza Petrouš Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/dvb/ca-set-descr.rst | 15

Re: [PATCH v6 5/5] v4l: fwnode: Support generic parsing of graph endpoints in a single port

2017-09-04 Thread Laurent Pinchart
Hi Sakari, On Sunday, 3 September 2017 10:43:39 EEST Sakari Ailus wrote: > On Sat, Sep 02, 2017 at 12:52:47PM +0300, Laurent Pinchart wrote: > > On Saturday, 2 September 2017 01:57:48 EEST Sakari Ailus wrote: > >> On Fri, Sep 01, 2017 at 01:28:40PM +0200, Hans Verkuil wrote: [sinp] > >>> I'm

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

2017-09-04 Thread Mauro Carvalho Chehab
Em Mon, 4 Sep 2017 11:40:59 +0200 Honza Petrouš escreveu: > > So, IMHO, the interface is broken by design. Perhaps that's > > the reason why no upstream driver uses it. > > I have the same feeling regarding brokenness. > > > > > What seems to be a much better design would

[PATCH] uvcvideo: extend UVC_QUIRK_FIX_BANDWIDTH to MJPEG streams

2017-09-04 Thread Pavel Rojtberg
From: Pavel Rojtberg attaching two Logitech C615 webcams currently results in VIDIOC_STREAMON: No space left on device as the required bandwidth is not estimated correctly by the device. In fact it always requests 3060 bytes - no matter the format or resolution. setting

Re: UVC property auto update

2017-09-04 Thread Edgar Thier
Hi Guennadi, The cameras in question are USB-3.0 industrial cameras from The Imaging Source. The ones I tested were the DFK UX250 and DFK UX264 models. I do not know if there are other devices that have the AUTO_UPDATE flag for various properties. Since I received no immediate answer I tried

Re: [PATCH v2 00/26] Improve DVB documentation and reduce its gap

2017-09-04 Thread Honza Petrouš
2017-09-04 2:54 GMT+02:00 Mauro Carvalho Chehab : > Em Sun, 3 Sep 2017 22:05:23 +0200 > Honza Petrouš escreveu: > >> 1) #define CA_SET_DESCR _IOW('o', 134, ca_descr_t) >> >> >> CA_SET_DESCR is used for

Re: [PATCH v7 00/18] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-09-04 Thread Sakari Ailus
Oh, and this set depends on this patch, on its way to 4.14-rc1 I believe: -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: UVC property auto update

2017-09-04 Thread Guennadi Liakhovetski
Hi Edgar, Thanks for the explanation. On Mon, 4 Sep 2017, Edgar Thier wrote: > Hi Guennadi, > > The cameras in question are USB-3.0 industrial cameras from The Imaging > Source. > The ones I tested were the DFK UX250 and DFK UX264 models. > I do not know if there are other devices that have

Re: [PATCH v7 10/18] v4l: async: Introduce macros for calling async ops callbacks

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > Add two macros to call async operations callbacks. Besides simplifying > callbacks, this allows async notifiers to have no ops set, i.e. it can be > left NULL. > > Signed-off-by: Sakari Ailus > --- >

Re: UVC property auto update

2017-09-04 Thread Guennadi Liakhovetski
On Mon, 4 Sep 2017, Edgar Thier wrote: > Hi Guennadi, > > > > But that patch only re-reads the flags. What does that give you? Do those > > flags change? In which way? As far as I understand the UVC Autoupdate > > feature, a change in GET_INFO data is only one possibility, (arguably) a > >

Re: [PATCH v7 04/18] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > The current practice is that drivers iterate over their endpoints and > parse each endpoint separately. This is very similar in a number of > drivers, implement a generic function for the job. Driver specific matters > can be taken into account in the

Re: [PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > We only want to link sub-devices that were bound to the async notifier the > isp driver registered but there may be other sub-devices in the > v4l2_device as well. Check for the correct async notifier. Just to be sure I understand this correctly: the

Re: [PATCH v7 15/18] v4l2-fwnode: Add convenience function for parsing generic references

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > Add function v4l2_fwnode_reference_count() for counting external > references and v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. > > This can be done on e.g. flash or lens async sub-devices that are not part > of but are

[PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-04 Thread Christian König
From: Christian König The logic is buggy and unnecessary complex. When dma_fence_get_rcu() fails to acquire a reference it doesn't necessary mean that there is no fence at all. It usually mean that the fence was replaced by a new one and in this situation we certainly

[PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-04 Thread Christian König
From: Christian König The logic is buggy and unnecessary complex. When dma_fence_get_rcu() fails to acquire a reference it doesn't necessary mean that there is no fence at all. It usually mean that the fence was replaced by a new one and in this situation we certainly

[PATCH v3 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX

2017-09-04 Thread Maxime Ripard
Hi, Here is an attempt at supporting the MIPI-CSI2 RX block from Cadence. This IP block is able to receive CSI data over up to 4 lanes, and split it to over 4 streams. Those streams are basically the interfaces to the video grabbers that will perform the capture. It is able to map streams to

[PATCH v3 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2017-09-04 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the former case. It also support dynamic

[PATCH v3 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2017-09-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-04 Thread Chris Wilson
Quoting Christian König (2017-09-04 14:27:33) > From: Christian König > > The logic is buggy and unnecessary complex. When dma_fence_get_rcu() fails to > acquire a reference it doesn't necessary mean that there is no fence at all. > > It usually mean that the fence was

Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices associated to a sensor

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > Camera flash drivers (and LEDs) are separate from the sensor devices in > DT. In order to make an association between the two, provide the > association information to the software. > > Signed-off-by: Sakari Ailus >

Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image sensors

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > The lens-focus property contains a phandle to the lens voice coil driver > that is associated to the sensor; typically both are contained in the same > camera module. Just to be certain: this lens-focus phandle should also work fine for a motor

Re: [PATCH v7 12/18] v4l: async: Allow binding notifiers to sub-devices

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This information is not

Re: [PATCH v7 07/18] omap3isp: Fix check for our own sub-devices

2017-09-04 Thread Sakari Ailus
On Mon, Sep 04, 2017 at 03:28:04PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > We only want to link sub-devices that were bound to the async notifier the > > isp driver registered but there may be other sub-devices in the > > v4l2_device as well. Check for the

Re: [PATCH v7 01/18] v4l: fwnode: Move KernelDoc documentation to the header

2017-09-04 Thread Pavel Machek
On Sun 2017-09-03 20:49:41, Sakari Ailus wrote: > In V4L2 the practice is to have the KernelDoc documentation in the header > and not in .c source code files. This consequientally makes the V4L2 consequientally: spelling? > fwnode function documentation part of the Media documentation build. >

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-04 Thread Christian König
I really wonder what's wrong with my mail client, but it looks like this patch never made it at least to dri-devel. Forwarding manually now, Christian. Am 04.09.2017 um 15:16 schrieb Christian König: From: Christian König The logic is buggy and unnecessary complex.

Re: [PATCH v7 10/18] v4l: async: Introduce macros for calling async ops callbacks

2017-09-04 Thread Sakari Ailus
Hi Hans, On Mon, Sep 04, 2017 at 03:50:52PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > Add two macros to call async operations callbacks. Besides simplifying > > callbacks, this allows async notifiers to have no ops set, i.e. it can be > > left NULL. > > > >

Re: [PATCH v7 16/18] v4l2-fwnode: Add convenience function for parsing common external refs

2017-09-04 Thread Hans Verkuil
On 09/03/2017 07:49 PM, Sakari Ailus wrote: > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > sensor properties that refer to adjacent devices such as flash or lens > driver chips. > > As this is an association only, there's little a regular driver needs to > know about these

Re: [PATCH v2 14/14] [media] v4l: Document explicit synchronization behaviour

2017-09-04 Thread Gustavo Padovan
2017-09-02 Hans Verkuil : > On 09/01/2017 08:21 PM, Gustavo Padovan wrote: > > Hi Hans, > > > > 2017-09-01 Hans Verkuil : > > > >> Hi Gustavo, > >> > >> I think I concentrate on this last patch first. Once I fully understand > >> this > >> I can review

Re: [PATCH v7 04/18] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-04 Thread Sakari Ailus
Hi Hans, On Mon, Sep 04, 2017 at 03:19:10PM +0200, Hans Verkuil wrote: > On 09/03/2017 07:49 PM, Sakari Ailus wrote: > > The current practice is that drivers iterate over their endpoints and > > parse each endpoint separately. This is very similar in a number of > > drivers, implement a generic

[PATCH 0/6] [media] Atmel: Adjustments for seven function implementations

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 21:44:55 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete an error message for a failed memory allocation in isc_formats_init() Improve a size

[PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init()

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 20:33:58 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 20:54:20 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 21:21:25 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 21:30:48 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

Re: [PATCH v7 04/18] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-04 Thread Sakari Ailus
On Mon, Sep 04, 2017 at 07:37:09PM +0200, Hans Verkuil wrote: > On 09/04/2017 05:54 PM, Sakari Ailus wrote: > >>> +/** > >>> + * v4l2_async_notifier_parse_fwnode_endpoints - Parse V4L2 fwnode > >>> endpoints in a > >>> + * device node > >>> + * @dev:

[PATCH 1/2] docs-rst: media: Don't use \small for V4L2_PIX_FMT_SRGGB10 documentation

2017-09-04 Thread Mauro Carvalho Chehab
From: Sakari Ailus There appears to be an issue in using \small in certain cases on Sphinx 1.4 and 1.5. Other format documents don't use \small either, remove it from here as well. [mche...@s-opensource.com: kept tabularcolumns - readjusted - and add a few blank

[PATCH 2/6] [media] atmel-isc: Improve a size determination in isc_formats_init()

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 20:50:22 +0200 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 5/6] [media] atmel-isi: Improve three size determinations

2017-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 4 Sep 2017 21:27:45 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] media: pixfmt-srggb12p.rst: better format the table for PDF output

2017-09-04 Thread Mauro Carvalho Chehab
Adjust the table to be better displayed on PDF output. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 59 +--- 1 file changed, 21 insertions(+), 38 deletions(-) diff --git

Re: [PATCH 1/1] docs-rst: media: Don't use \small for V4L2_PIX_FMT_SRGGB10 documentation

2017-09-04 Thread Mauro Carvalho Chehab
Em Sun, 3 Sep 2017 22:40:02 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 3 Sep 2017 23:12:33 +0300 > Sakari Ailus escreveu: > > > There appears to be an issue in using \small in certain cases on Sphinx > > 1.4 and 1.5. Other format

cron job: media_tree daily build: WARNINGS

2017-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 5 05:00:17 CEST 2017 media-tree git hash:fce4b371fe5c99a9c05db8493d72f0d1a474ab26 media_build