Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

On 10/25/2017 04:28 PM, Marian Mihailescu wrote: > Hi Shuah, > > For MFC patch, you can delete the "dev" variable since it's not being > used anymore and results in a compile warning. > > - struct s5p_mfc_dev *dev = ctx->dev; > > Cheers, > Marian Oops. I thought I handled that. I will fix that

Re: [GIT PULL for 4.15] More sensor driver patches

submitted V9 add an entry in MAINTAINERS fix a bug in probe Regards, Leon Luo 1130 Cadillac CT Milpitas, CA 95035 Phone: (510)371-1169 Fax: (408) 217-1960 Email: le...@leopardimaging.com www.leopardimaging.com On Wed, Oct 25, 2017 at 3:24 AM, Sakari Ailus wrote: > On Tue,

[PATCH v9 1/2] media:imx274 device tree binding file

The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann Acked-by: Rob Herring --- v9: - add an entry in MAINTAINERS v8: - no changes v7: - no changes v6: - no changes v5: -

[PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI CSI-2 running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board. Support for

[PATCH v16 21/32] dt: bindings: Add lens-focus binding for image sensors

The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Cc: Rob Herring Cc: devicet...@vger.kernel.org Acked-by:

[PATCH v16 26/32] v4l: fwnode: Add a convenience function for registering sensors

Add a convenience function for parsing firmware for information on related devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering the notifier and finally the async sub-device itself. This should be useful for sensor drivers that do not have device specific requirements

[PATCH v16 20/32] dt: bindings: Add a binding for flash LED devices associated to a sensor

Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus Cc: Rob Herring Cc:

[PATCH v16 22/32] v4l: fwnode: Move KernelDoc documentation to the header

In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequently makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation and add an

[PATCH v16 24/32] v4l: fwnode: Add a helper function to obtain device / integer references

v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property-value pair and return the resulting fwnode. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v16 16/32] v4l: async: Allow async notifier register call succeed with no subdevs

The information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that. Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't

[PATCH v16 06/32] v4l: async: Use more intuitive names for internal functions

Rename internal functions to make the names of the functions better describe what they do. Old nameNew name v4l2_async_test_notify v4l2_async_match_notify v4l2_async_belongs v4l2_async_find_match Signed-off-by: Sakari Ailus

[PATCH v16 07/32] v4l: async: Add V4L2 async documentation to the documentation build

The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v16 12/32] omap3isp: Print the name of the entity where no source pads could be found

If no source pads are found in an entity, print the name of the entity. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2

[PATCH v16 11/32] omap3isp: Fix check for our own sub-devices

We only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v16 14/32] v4l: async: Introduce helpers for calling async ops callbacks

Add three helper functions to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek

[PATCH v16 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers

While registering a notifier, check that each newly added fwnode is unique, and return an error if it is not. Also check that a newly added notifier does not have the same fwnodes twice. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil ---

[PATCH v16 10/32] rcar-vin: Use generic parser for parsing fwnode endpoints

Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Niklas Söderlund

[PATCH v16 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister()

From: Niklas Söderlund The call to v4l2_async_cleanup() will set sd->asd to NULL so passing it to notifier->unbind() has no effect and leaves the notifier confused. Call the unbind() callback prior to cleaning up the subdevice to avoid this. Signed-off-by:

[PATCH v16 17/32] v4l: async: Prepare for async sub-device notifiers

Refactor the V4L2 async framework a little in preparation for async sub-device notifiers. This avoids making some structural changes in the patch actually implementing sub-device notifiers, making that patch easier to review. Signed-off-by: Sakari Ailus Acked-by:

[PATCH v16 05/32] v4l: async: Correctly serialise async sub-device unregistration

The check whether an async sub-device is bound to a notifier was performed without list_lock held, making it possible for another process to unbind the async sub-device before the sub-device unregistration function proceeds to take the lock. Fix this by first acquiring the lock and then

[PATCH v16 18/32] v4l: async: Allow binding notifiers to sub-devices

Registering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device). This information is not available for sub-device drivers at probe time. What this

[PATCH v16 30/32] ov5670: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov5670.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v16 29/32] et8ek8: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 2

[PATCH v16 23/32] v4l: fwnode: Add a helper function for parsing generic references

Add function v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[PATCH v16 27/32] dt: bindings: smiapp: Document lens-focus and flash-leds properties

Document optional lens-focus and flash-leds properties for the smiapp driver. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1

[PATCH v16 08/32] v4l: fwnode: Support generic parsing of graph endpoints in a device

Add two functions for parsing devices graph endpoints: v4l2_async_notifier_parse_fwnode_endpoints and v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates over all endpoints whereas the latter only iterates over the endpoints in a given port. The former is mostly useful for

[PATCH v16 28/32] smiapp: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module ---

[PATCH v16 31/32] ov13858: Add support for flash and lens devices

Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov13858.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v16 25/32] v4l: fwnode: Add convenience function for parsing common external refs

Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus

[PATCH v16 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup

v4l2_async_cleanup() is called when the async sub-device is unbound from the media device. As the pointer is set by the driver registering the async sub-device, leave the pointer as set by the driver. Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel

[PATCH v16 09/32] omap3isp: Use generic parser for parsing fwnode endpoints

Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v16 32/32] arm: dts: omap3: N9/N950: Add flash references to the camera

Add flash and indicator LED phandles to the sensor node. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++--

[PATCH v16 04/32] v4l: async: Fix notifier complete callback error handling

The notifier complete callback may return an error. This error code was simply returned to the caller but never handled properly. Move calling the complete callback function to the caller from v4l2_async_test_notify and undo the work that was done either in async sub-device or async notifier

[PATCH v16 01/32] v4l: async: Remove re-probing support

Remove V4L2 async re-probing support. The re-probing support has been there to support cases where the sub-devices require resources provided by the main driver's hardware to function, such as clocks. Reprobing has allowed unbinding and again binding the main driver without explicitly unbinding

[PATCH v16 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

Hi folks, I've dropped the full set from devicetree and linux-acpi lists; let me know if you want it back. The entire set is posted to linux-media list. We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing

[PATCH v16 13/32] v4l: async: Move async subdev notifier operations to a separate structure

From: Laurent Pinchart The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function

[PATCH v16 15/32] v4l: async: Register sub-devices before calling bound callback

Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus Acked-by:

[PATCH 1/1] imx274: Add MAINTAINERS entry

Add MAINTAINERS entry for imx274 driver and DT bindings. Signed-off-by: Leon Luo Signed-off-by: Sakari Ailus --- Hi Leon, I moved the maintainers entry to a separate patch. It's better this way. MAINTAINERS | 8 1 file changed,

[GIT PULL v2 for 4.15] Imx274 driver

Hi Mauro, Here's the imx274 driver, this time with the MAINTAINERS entry. A few minor fixes have been done as well in error handling. Please pull. The following changes since commit 61065fc3e32002ba48aa6bc3816c1f6f9f8daf55: Merge commit '3728e6a255b5' into patchwork (2017-10-17 17:22:20

[GIT PULL for 4.15] Yet more sensor driver patches

Hi Mauro, Here's the final set of sensor driver patches for 4.15. Please pull. The following changes since commit 61065fc3e32002ba48aa6bc3816c1f6f9f8daf55: Merge commit '3728e6a255b5' into patchwork (2017-10-17 17:22:20 -0700) are available in the git repository at:

[RFC PATCH 2/2] v4l2-core: make VIDIOC_DQEVENT y2038 proof.

From: Hans Verkuil Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 4 +++- drivers/media/v4l2-core/v4l2-event.c | 22 +++--- drivers/media/v4l2-core/v4l2-ioctl.c | 6 --

[RFC PATCH 1/2] v4l2: add extended streaming operations

From: Hans Verkuil For year 2038 and to simplify multiplanar formats. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-common.c| 72 +++ drivers/media/v4l2-core/v4l2-dev.c | 4 + drivers/media/v4l2-core/v4l2-ioctl.c

[RFC PATCH 0/2] v4l2 core: simplify streaming ioctls, fix y2038

From: Hans Verkuil These two patches have been sitting in my tree for some time. I'm posting these just to get some discussion started. The first patch adds new extended streaming ioctls that fix y2038 and that simplify the single/multiplanar handling which is very hard

Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine

On Fri, Oct 20, 2017 at 12:34:22AM +0300, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55

camss: camera controls missing on vfe interfaces

Hi Todor, When using the camss driver trough one of its /dev/videoX device nodes, applications are currently unable to see the video controls the camera sensor exposes. Same goes for other ioctls such as VIDIOC_ENUM_FMT, so the only valid resolution setting for applications to use is the one

[PATCH v5 5/5] media: atmel-isc: Rework the format list

To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the flag member to indicate the format can be achieved from the sensor or be produced by the controller, and rename members related to the

[PATCH v5 4/5] media: atmel-isc: Remove unnecessary member

Remove the memeber *config from the isc_subdev_entity struct, the member is useless afterward. Signed-off-by: Wenyou Yang --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 10 ++ 1

[PATCH] media: i2c: Add the ov7740 image sensor driver

From: Songjun Wu The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu

[PATCH v5 2/5] media: atmel-isc: Add prepare and unprepare ops

A software write operation to the ISC_CLKEN or ISC_CLKDIS register requires double clock domain synchronization and is not permitted when the ISC_SR.SIP is asserted. So add the .prepare and .unprepare ops to make sure the ISC_CLKSR.SIP is unasserted before the write operation to the ISC_CLKEN or

[PATCH v5 3/5] media: atmel-isc: Enable the clocks during probe

To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than or equal to isc_ispck, and isc_ispck is greater than or equal to HCLOCK." Meanwhile, call the pm_runtime_enable() in the right place. Signed-off-by: Wenyou Yang

[PATCH v5 1/5] media: atmel-isc: Add spin lock for clock enable ops

Add the spin lock for the clock enable and disable operations. Signed-off-by: Wenyou Yang --- Changes in v5: None Changes in v4: None Changes in v3: - Fix the wrong used spinlock. - s/_/- on the subject. Changes in v2: None

[PATCH v5 0/5] media: atmel-isc: Rework the format list and clock provider

To improve the readability of code, rework the format list table, split the format array into two. Meanwhile, fix the issue of the clock provider operation and the pm runtime support. Changes in v5: - Fix the clock ID which enters the runtime suspend should be ISC_ISPCK, instead of ISC_MCK

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Oct 27 05:00:18 CEST 2017 media-tree git hash:61065fc3e32002ba48aa6bc3816c1f6f9f8daf55 media_build

Re: Enabling peer to peer device transactions for PCIe devices

- Original Message - > From: "David Laight" > To: "Petrosyan, Ludwig" , "Logan Gunthorpe" > > Cc: "Alexander Deucher" , "linux-kernel" > , "linux-rdma" >

Re: [PATCH] media: av7110: switch to useing timer_setup()

Hi Dmitry, Thank you for the patch! Yet we hit a small issue. [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.14-rc6 next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2] [media] dvb-frontends/stv0910: prevent consecutive mutex_unlock()'s

From: Daniel Scheller When calling gate_ctrl() with enable=0 if previously the mutex wasn't locked (ie. on enable=1 failure and subdrivers not handling this properly, or by otherwise badly behaving drivers), the i2c_lock could be unlocked consecutively which isn't allowed.

[PATCH v3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

The documentation already mentions "cec" optional clock, but currently the driver doesn't enable it. Changes: v3: - Drop useless braces v2: - Separate ENOENT errors from others - Propagate other errors (especially -EPROBE_DEFER) Signed-off-by: Pierre-Hugues Husson ---

Re: [PATCH v6 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Yong, Thanks for the update! A few minor comments still... please see below. On Wed, Oct 25, 2017 at 09:24:42PM -0500, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > Signed-off-by: Yong Zhi > Signed-off-by:

Re: [PATCH v16 06/32] v4l: async: Use more intuitive names for internal functions

On 2017-10-26 10:53:16 +0300, Sakari Ailus wrote: > Rename internal functions to make the names of the functions better > describe what they do. > > Old nameNew name > v4l2_async_test_notify v4l2_async_match_notify > v4l2_async_belongs

[PATCH v16.1 25/32] v4l: fwnode: Add convenience function for parsing common external refs

Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus

Re: [PATCH v16 04/32] v4l: async: Fix notifier complete callback error handling

Hi Sakari, On 2017-10-26 10:53:14 +0300, Sakari Ailus wrote: > The notifier complete callback may return an error. This error code was > simply returned to the caller but never handled properly. > > Move calling the complete callback function to the caller from > v4l2_async_test_notify and undo

Re: [PATCH v16 05/32] v4l: async: Correctly serialise async sub-device unregistration

On 2017-10-26 10:53:15 +0300, Sakari Ailus wrote: > The check whether an async sub-device is bound to a notifier was performed > without list_lock held, making it possible for another process to > unbind the async sub-device before the sub-device unregistration function > proceeds to take the

Re: [PATCH v16 01/32] v4l: async: Remove re-probing support

On 2017-10-26 10:53:11 +0300, Sakari Ailus wrote: > Remove V4L2 async re-probing support. The re-probing support has been > there to support cases where the sub-devices require resources provided by > the main driver's hardware to function, such as clocks. > > Reprobing has allowed unbinding and

Re: [PATCH v16 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup

On 2017-10-26 10:53:12 +0300, Sakari Ailus wrote: > v4l2_async_cleanup() is called when the async sub-device is unbound from > the media device. As the pointer is set by the driver registering the > async sub-device, leave the pointer as set by the driver. > > Signed-off-by: Sakari Ailus

[PATCH v16.1 24/32] v4l: fwnode: Add a helper function to obtain device / integer references

v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property-value pair and return the resulting fwnode. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

Re: [PATCH v16 08/32] v4l: fwnode: Support generic parsing of graph endpoints in a device

On 2017-10-26 10:53:18 +0300, Sakari Ailus wrote: > Add two functions for parsing devices graph endpoints: > v4l2_async_notifier_parse_fwnode_endpoints and > v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates > over all endpoints whereas the latter only iterates over the

Re: [PATCH v16 13/32] v4l: async: Move async subdev notifier operations to a separate structure

On 2017-10-26 10:53:23 +0300, Sakari Ailus wrote: > From: Laurent Pinchart > > The async subdev notifier .bound(), .unbind() and .complete() operations > are function pointers stored directly in the v4l2_async_subdev > structure. As the structure isn't

Re: [PATCH v16 14/32] v4l: async: Introduce helpers for calling async ops callbacks

On 2017-10-26 10:53:24 +0300, Sakari Ailus wrote: > Add three helper functions to call async operations callbacks. Besides > simplifying callbacks, this allows async notifiers to have no ops set, > i.e. it can be left NULL. > > Signed-off-by: Sakari Ailus >

Re: [PATCH v16 15/32] v4l: async: Register sub-devices before calling bound callback

On 2017-10-26 10:53:25 +0300, Sakari Ailus wrote: > Register the sub-device before calling the notifier's bound callback. > Doing this the other way around is problematic as the struct v4l2_device > has not assigned for the sub-device yet and may be required by the bound > callback. > >

Re: [PATCH v16 16/32] v4l: async: Allow async notifier register call succeed with no subdevs

On 2017-10-26 10:53:26 +0300, Sakari Ailus wrote: > The information on how many async sub-devices would be bindable to a > notifier is typically dependent on information from platform firmware and > it's not driver's business to be aware of that. > > Many V4L2 main drivers are perfectly usable

Re: [PATCH v16 17/32] v4l: async: Prepare for async sub-device notifiers

On 2017-10-26 10:53:27 +0300, Sakari Ailus wrote: > Refactor the V4L2 async framework a little in preparation for async > sub-device notifiers. This avoids making some structural changes in the > patch actually implementing sub-device notifiers, making that patch easier > to review. > >