Re: [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver

-ci/linux/commits/Wenyou-Yang/media-i2c-Add-the-ov7740-image-sensor-driver/20171030-140347 base: git://linuxtv.org/media_tree.git master config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp

Re: Adjustments for a lot of function implementations

> While we do not mind cleanup patches, the way you post them (one fix per file) I find it safer in this way while I was browsing through the landscape of Linux software components. > is really annoying and takes us too much time to review. It is just the case that there are so many remaining

Re: Adjustments for a lot of function implementations

On Mon, 30 Oct 2017, SF Markus Elfring wrote: > > While we do not mind cleanup patches, the way you post them (one fix per > > file) > > I find it safer in this way while I was browsing through the landscape of > Linux > software components. > > > > is really annoying and takes us too much

[PATCH] __dvb_frontend_free: Clear frontend_priv earlier

The writing to "fe->frontend_priv" in dvb_frontend.c:156 is a use-after-free in case the object pointed to by "dvb_frontend *fe" is already freed by the release callback called in line 153. Only if the demod driver is based on new style i2c_client the memory is still accessible. There are two

Re: Adjustments for a lot of function implementations

On 10/30/2017 10:47 AM, Julia Lawall wrote: > > > On Mon, 30 Oct 2017, SF Markus Elfring wrote: > >>> While we do not mind cleanup patches, the way you post them (one fix per >>> file) >> >> I find it safer in this way while I was browsing through the landscape of >> Linux >> software

Re: [PATCH v2 1/2] media: i2c: Add the ov7740 image sensor driver

-ci/linux/commits/Wenyou-Yang/media-i2c-Add-the-ov7740-image-sensor-driver/20171030-140347 base: git://linuxtv.org/media_tree.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https

[PATCH] em28xx: Fix use-after-free when disconnecting

Fix bug by moving the i2c_unregister_device calls after deregistration of dvb frontend. The new style i2c drivers already destroys the frontend object at i2c_unregister_device time. When the dvb frontend is unregistered afterwards it leads to this oops: [ 6058.866459] BUG: unable to handle

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

On 10/24/2017 05:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mike Isely > Cc: Mauro Carvalho

Re: Adjustments for a lot of function implementations

On 10/30/2017 11:40 AM, SF Markus Elfring wrote: > Feel free to repost, but only if you organize the patch as either fixing > the same type of > issue for a whole subdirectory (media/usb, media/pci, etc) >>> >>> Just for the record, while this may work for media, it won't work for all

Re: [PATCH 2/6 v5] V4L: Add a UVC Metadata format

Hi Guennadi, On 07/28/2017 02:46 PM, Hans Verkuil wrote: > On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote: >> Add a pixel format, used by the UVC driver to stream metadata. >> >> Signed-off-by: Guennadi Liakhovetski >> --- >>

Re: Adjustments for a lot of function implementations

> Yes, and you were told not to do it I have got an other impression. > like that again. I continued with the presentation of suggestions from my selection of change possibilities. It seems that there are very different expectations for the preferred patch granularity. Can it happen again

[PATCH v16.2 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers

While registering a notifier, check that each newly added fwnode is unique, and return an error if it is not. Also check that a newly added notifier does not have the same fwnodes twice. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil

[GIT PULL for 4.15] V4L2 async and fwnode improvements; DT and ACPI lens and flash support

Hi Mauro, This patchset improves async and fwnode frameworks and moves a lot of the job of parsing away from drivers to the framework. Also, DT and ACPI receive lens and flash support plus a few drivers using them. Some documentation and V4L2 async error handling fixes are included as well in

Re: [PATCH v16.1 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers

Hi Sebastian, On Sun, Oct 29, 2017 at 11:25:55PM +0100, Sebastian Reichel wrote: > Hi, > > On Fri, Oct 27, 2017 at 01:53:09PM +0300, Sakari Ailus wrote: > > While registering a notifier, check that each newly added fwnode is > > unique, and return an error if it is not. Also check that a newly

Re: [PATCH] media: atmel-isc: Fix clock ID for clk_prepare/unprepare

On Mon, Oct 30, 2017 at 08:46:50AM +0800, Wenyou Yang wrote: > Fix the clock ID to do the runtime pm should be ISC_ISPCK, > instead of ISC_MCK in clk_prepare(), clk_unprepare() and > isc_clk_is_enabled(). > > Signed-off-by: Wenyou Yang Acked-by: Sakari Ailus

Re: [ANN] Agenda (v2) for the media mini-summit on Friday Oct 27 in Prague

Em Fri, 20 Oct 2017 13:17:31 +0200 Hans Verkuil escreveu: > Hi all, > > We are organizing a media mini-summit on Friday October 27 in Prague, > co-located > with the ELCE conference: For those that were at our gpg sign party, don't forget to sign the keys :-) The way I

[GIT PULL FOR v4.15] More fixes/cleanups

Hi Mauro, A lot of timer_setup conversions. The other patches are all over the place. Please note the CC to stable for 3.17 and up for the v4l2-ctrl patch from Ricardo: I verified that it applies to that kernel. It's a little bug that's been there from the beginning until Ricardo noticed it

Re: [PATCH] media: usb: s2255drv: update to firmware loading

On 09/30/2017 12:15 AM, d...@sensoray.com wrote: > fixes intermittent soft reboot issue with firmware load > increases wait time of reset, as required by HW > > Signed-off-by: Dean Anderson > > --- > drivers/media/usb/s2255/s2255drv.c | 13 ++--- > 1 file

Re: [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations

Hi Markus, On 09/24/2017 12:20 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 24 Sep 2017 12:06:54 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Delete an error message

Re: [PATCH] media: pci: Convert timers to use timer_setup()

Hi Kees, On 10/24/2017 05:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mauro Carvalho Chehab

Re: Adjustments for a lot of function implementations

Feel free to repost, but only if you organize the patch as either fixing the same type of issue for a whole subdirectory (media/usb, media/pci, etc) >> >> Just for the record, while this may work for media, it won't work for all >> subsystems. One will quickly get a complaint that

Re: [patch] libv4l2: SDL test application

Hi Pavel, On 10/28/2017 09:57 PM, Pavel Machek wrote: > Add support for simple SDL test application. Allows taking jpeg > snapshots, and is meant to run on phone with touchscreen. Not > particulary useful on PC with webcam, but should work. When I try to build this I get: make[3]: Entering

Re: [patch] libv4l2: SDL test application

On Monday 30 October 2017 17:30:53 Hans Verkuil wrote: > Hi Pavel, > > On 10/28/2017 09:57 PM, Pavel Machek wrote: > > Add support for simple SDL test application. Allows taking jpeg > > snapshots, and is meant to run on phone with touchscreen. Not > > particulary useful on PC with webcam, but

Re: [patch] libv4l2: SDL test application

On 10/30/2017 05:41 PM, Pali Rohár wrote: > On Monday 30 October 2017 17:30:53 Hans Verkuil wrote: >> Hi Pavel, >> >> On 10/28/2017 09:57 PM, Pavel Machek wrote: >>> Add support for simple SDL test application. Allows taking jpeg >>> snapshots, and is meant to run on phone with touchscreen. Not

[PATCH v2] media: s5p-mfc: fix lockdep warning

The driver mmap functions shouldn't take lock when calling vb2_mmap(). Fix it to not take the lock. The following lockdep warning is fixed with this change. [ 2106.181412] == [ 2106.187563] WARNING: possible circular locking dependency detected

Re: [PATCH] media: av7110: switch to useing timer_setup()

On Tue, Oct 24, 2017 at 5:40 PM, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop

Re: [patch] libv4l2: SDL test application

On Mon 2017-10-30 17:30:53, Hans Verkuil wrote: > Hi Pavel, > > On 10/28/2017 09:57 PM, Pavel Machek wrote: > > Add support for simple SDL test application. Allows taking jpeg > > snapshots, and is meant to run on phone with touchscreen. Not > > particulary useful on PC with webcam, but should

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

On 10/25/2017 04:28 PM, Marian Mihailescu wrote: > Hi Shuah, > > For MFC patch, you can delete the "dev" variable since it's not being > used anymore and results in a compile warning. > > - struct s5p_mfc_dev *dev = ctx->dev; > Hi Marian, This series doesn't have the unused warn problem. I

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 31 05:00:15 CET 2017 media-tree git hash:bbae615636155fa43a9b0fe0ea31c678984be864 media_build

[PATCH v4 3/3] MAINTAINERS: Add a new entry of the ov7740 driver

Add a new entry of the ov7740 sensor driver to the MAINTAINERS file. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Put the MAINTAINERS change to a separate patch. Changes in v2: - Split off the bindings into a separate patch. - Add a new

[PATCH v4 1/3] media: i2c: Add the ov7740 image sensor driver

The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu Signed-off-by: Wenyou Yang ---

[PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 VGA camera image sensor. Changes in v4: - Assign 'val' a initial value to avoid warning: 'val' may be used uninitialized. - Rename REG_REG15 to avoid warning: "REG_REG15" redefined. Changes in v3: - Explicitly document the

[PATCH v4 2/3] media: ov7740: Document device tree bindings

Add the device tree binding documentation for the ov7740 sensor driver. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Explicitly document the "remote-endpoint" property. Changes in v2: None .../devicetree/bindings/media/i2c/ov7740.txt |

[PATCH] [media] dvb-core: dvb_frontend_handle_ioctl(): init err to -EOPNOTSUPP

From: Daniel Scheller Fixes: d73dcf0cdb95 ("media: dvb_frontend: cleanup ioctl handling logic") The mentioned commit cleaned up the ioctl handling, but caused an issue with the DVBv3 when they're not defined in a frontend's fe_ops: When a userspace application checks for

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

Hi Sean, I found the problem. The read buffer needs to be allocated with kmalloc too. int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8 offs, u8 *val) { u8 *wbuf; u8 *rbuf; int rc; rbuf = kmalloc(1, GFP_KERNEL); if (!rbuf)