[PATCH 6/8] [media] vivid: use ktime_t for timestamp calculation

timespec is generally deprecated because of the y2038 overflow. In vivid, the usage is fine, since we are dealing with monotonic timestamps, but we can also simplify the code by going to ktime_t. Using ktime_divns() should be roughly as efficient as the old code, since the constant 64-bit

Re: [PATCH v8 0/5] Synopsys Designware HDMI Video Capture Controller + PHY

Hi Hans, On 27-11-2017 12:05, Hans Verkuil wrote: > Hi Jose, > > Sakari's work was merged. Can you make a v9? Then we can merge this for 4.16. Yeah, I saw that. Unfortunately due to my schedule I don't have the time now to make a v9. I will try to make a new version once possible but I don't

[PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

timespec overflows in 2038 on 32-bit architectures, and the getnstimeofday() suffers from possible time jumps, so the timestamps here are better done using ktime_get(), which has neither of those problems. In case of ov2680, we don't seem to use the timestamp at all, so I just remove it.

[PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

Fixed some sparse warnings in the Atom ISP staging driver and the checkpatch warnings that affected my patches. This time with longer commit messages. :) Jeremy Sowden (3): media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings. media: staging: atomisp:

[PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

Changed the types of some arrays from int16_t to s16. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 25 +++--- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git

[PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

The "address" member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/3] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings.

Defined some const arrays as static since they don't need external linkage. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 3/3] media: staging: atomisp: prefer s16 to int16_t.

Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 25 +++--- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c

[PATCH 0/3] Sparse fixes for the Atom ISP Staging Driver

Fixed some sparse warnings in the Atom ISP staging driver and the checkpatch warnings that affected my patches. Jeremy Sowden (3): media: staging: atomisp: address member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. media: staging: atomisp: defined as static

[PATCH 1/3] media: staging: atomisp: address member of struct ia_css_host_data is a pointer-to-char, so define default as NULL.

Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isp_param/interface/ia_css_isp_param_types.h

[PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c

Re: [PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In case of ov2680, we

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take a look at this as well? Jacob, I have some high-level questions first: 1) to what extend is this code rockchip-specific as opposed to be more synopsys-generic? 2) I don't quite see how this works when there are two

Re: [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage.

On Mon, Nov 27, 2017 at 11:30:53AM +, Jeremy Sowden wrote: > Signed-off-by: Jeremy Sowden > --- > .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 > +++--- > 1 file changed, 12 insertions(+), 12 deletions(-) I can never take patches without any

[PATCH] media: exynos4-is: check pipe is valid before calling subdev

if the subdev is not yet present (probably because the subdev module has not yet been loaded), the pipe will be NULL. Make sure that this is not the case before attempting to call the op. Signed-off-by: Simon Shields --- include/media/drv-intf/exynos-fimc.h | 3 ++- 1 file

[PATCH 1/8] [media] uvc_video: use ktime_t for stats

'struct timespec' works fine here, but we try to migrate away from it in favor of ktime_t or timespec64. In this case, using ktime_t produces the simplest code. Signed-off-by: Arnd Bergmann --- drivers/media/usb/uvc/uvc_video.c | 11 --- drivers/media/usb/uvc/uvcvideo.h

Re: [PATCH 6/8] [media] vivid: use ktime_t for timestamp calculation

Hi Arnd, On 11/27/2017 02:19 PM, Arnd Bergmann wrote: > timespec is generally deprecated because of the y2038 overflow. > In vivid, the usage is fine, since we are dealing with monotonic > timestamps, but we can also simplify the code by going to ktime_t. > > Using ktime_divns() should be

Re: [PATCH v8 0/5] Synopsys Designware HDMI Video Capture Controller + PHY

Hi Jose, Sakari's work was merged. Can you make a v9? Then we can merge this for 4.16. Thanks! Hans On 09/22/2017 02:53 PM, Hans Verkuil wrote: > Hi Jose, > > I'm going to mark this patch series as 'Changes Requested' since it depends on > Sakari's subnotifier work. Once that is

[PATCH 5/8] [media] omap3isp: support 64-bit version of omap3isp_stat_data

C libraries with 64-bit time_t use an incompatible format for struct omap3isp_stat_data. This changes the kernel code to support either version, by moving over the normal handling to the 64-bit variant, and adding compatiblity code to handle the old binary format with the existing ioctl command

[PATCH 3/8] [media] solo6x10: use ktime_get_ts64() for time sync

solo6x10 correctly deals with time stamps and will never suffer from overflows, but it uses the deprecated 'struct timespec' type and 'ktime_get_ts()' interface to read the monotonic clock. This changes it to use ktime_get_ts64() instead, so we can eventually remove ktime_get_ts().

[PATCH 2/8] [media] uvc_video: use ktime_t for timestamps

uvc_video_get_ts() returns a 'struct timespec', but all its users really want a nanoseconds variable anyway. Changing the deprecated ktime_get_ts/ktime_get_real_ts to ktime_get and ktime_get_real simplifies the code noticeably, while keeping the resulting numbers unchanged. Signed-off-by: Arnd

[PATCH 8/8] [media] staging: imx: use ktime_t for timestamps

The imx media driver passes around monotonic timestamps in the deprecated 'timespec' format. This is not a problem for the driver, as they won't overflow, but moving to either timespec64 or ktime_t is preferred. I'm picking ktime_t for simplicity here. frame_interval_monitor() is the main

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

++ Joao, ++ Luis Hi Hans, We will take a look into this. Thanks for pointing this out! Best Regards, Jose Miguel Abreu On 27-11-2017 12:01, Hans Verkuil wrote: > I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take > a look at this as well? > > Jacob, I have some

[PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

timespec overflows in 2038 on 32-bit architectures, and the getnstimeofday() suffers from possible time jumps, so the timestamps here are better done using ktime_get(), which has neither of those problems. In case of ov2680, we don't seem to use the timestamp at all, so I just remove it.

Re: [PATCH v2 3/4] [media] v4l2: disable filesystem-dax mapping support

On Tue 14-11-17 11:56:45, Dan Williams wrote: > V4L2 memory registrations are incompatible with filesystem-dax that > needs the ability to revoke dma access to a mapping at will, or > otherwise allow the kernel to wait for completion of DMA. The > filesystem-dax implementation breaks the

[PATCH V3 22/29] [media] atomisp: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function. Since ISP always uses domain 0, hard-code it in the code when

Re: [Y2038] [PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

On Mon, Nov 27, 2017 at 4:05 PM, Andy Shevchenko wrote: > On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote: >> timespec overflows in 2038 on 32-bit architectures, and the >> getnstimeofday() suffers from possible time jumps, so the >> timestamps here are

Re: [PATCH 0/3] Improve CEC autorepeat handling

On 11/27/2017 10:47 AM, Sean Young wrote: > Hi Hans, > > On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: >> On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: >>> On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: Due to the slowness of the CEC bus, autorepeat handling

[PATCH v2] [media] vivid: use ktime_t for timestamp calculation

timespec is generally deprecated because of the y2038 overflow. In vivid, the usage is fine, since we are dealing with monotonic timestamps, but we can also simplify the code by going to ktime_t. Using ktime_divns() should be roughly as efficient as the old code, since the constant 64-bit

Re: [PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

On Mon, 2017-11-27 at 16:21 +0100, Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In case of ov2680, we

Re: [PATCH 6/8] [media] vivid: use ktime_t for timestamp calculation

On Mon, Nov 27, 2017 at 4:14 PM, Hans Verkuil wrote: >> - ktime_get_ts(); >> - use_alternates = ts.tv_sec % 10 >= 5; >> + timestamp = ktime_sub(ktime_get(), dev->radio_rds_init_time); >> + blk = ktime_divns(timestamp, VIVID_RDS_NSEC_PER_BLK); >> +

Re: [PATCH v2 2/4] mm: fail get_vaddr_frames() for filesystem-dax mappings

On Mon, Nov 27, 2017 at 8:15 AM, Jan Kara wrote: > On Tue 14-11-17 11:56:39, Dan Williams wrote: >> Until there is a solution to the dma-to-dax vs truncate problem it is >> not safe to allow V4L2, Exynos, and other frame vector users to create >> long standing / irrevocable memory

Re: [PATCH v2 2/4] mm: fail get_vaddr_frames() for filesystem-dax mappings

On Tue 14-11-17 11:56:39, Dan Williams wrote: > Until there is a solution to the dma-to-dax vs truncate problem it is > not safe to allow V4L2, Exynos, and other frame vector users to create > long standing / irrevocable memory registrations against filesytem-dax > vmas. > > Cc: Inki Dae

Re: [PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

On Mon, 27 Nov 2017 16:21:41 +0100 Arnd Bergmann wrote: > timespec overflows in 2038 on 32-bit architectures, and the > getnstimeofday() suffers from possible time jumps, so the > timestamps here are better done using ktime_get(), which has > neither of those problems. > > In

Re: [PATCH 3/8] [media] solo6x10: use ktime_get_ts64() for time sync

On 27/Nov/2017 14:19, Arnd Bergmann wrote: > solo6x10 correctly deals with time stamps and will never > suffer from overflows, but it uses the deprecated 'struct timespec' > type and 'ktime_get_ts()' interface to read the monotonic clock. > > This changes it to use ktime_get_ts64() instead, so we

Re: [PATCH v6 0/9] i2c: document DMA handling and add helpers for it

On Wed, Nov 08, 2017 at 10:50:37PM +, Mark Brown wrote: > On Sat, Nov 04, 2017 at 09:20:00PM +0100, Wolfram Sang wrote: > > > While previous versions until v3 tried to magically apply bounce buffers > > when > > needed, it became clear that detecting DMA safe buffers is too fragile. This > >

[PATCH 2/4] staging: improve comments usage in atomisp-ov5693

* Fix "Block comments use a trailing */ on a separate line" issue * Fix "Block comments use * on subsequent lines" issue Signed-off-by: Riccardo Schirone --- .../media/atomisp/i2c/ov5693/atomisp-ov5693.c | 38 ++ 1 file changed, 25 insertions(+), 13

Re: [PATCH v2 0/2] rcar-du, vsp1: rcar-gen3: Add support for colorkey alpha blending

Hi Alex et all, On Tuesday, 9 May 2017 10:12:31 EET Gheorghe, Alexandru wrote: > On Mon, Monday, May 8, 2017 9:29 PM +0200, Daniel Vetter wrote: > > On Mon, May 08, 2017 at 09:33:37AM -0700, Eric Anholt wrote: > >> Alexandru Gheorghe writes: > >>> Currently,

Re: [GIT PULL] SAA716x DVB driver

Em Fri, 24 Nov 2017 17:28:37 +0100 Tycho Lürsen escreveu: > Hi Mauro, > > afaik the last communication about submission of this driver was about > two months ago. > > This driver is important to me, because I own several TurboSight cards > that are saa716x based. I

Re: [PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

On Mon, 27 Nov 2017 12:44:50 + Jeremy Sowden wrote: > Changed the types of some arrays from int16_t to s16W Which are the same type, except int16_t is the standard form. No point. Alan

Re: [PATCH/RFC] not use a DiSEqC switch

Em Fri, 24 Nov 2017 10:52:04 +0200 Maksym Veremeyenko escreveu: > Hi, > > there is a code in function *dvbsat_diseqc_set_input*: > > [...] > /* Negative numbers means to not use a DiSEqC switch */ > if (parms->p.sat_number < 0) > return 0; > [...] >

Re: [linux-sunxi] Cedrus driver

Hi Maxime, Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi, Il 16/11/2017 14:39, Maxime Ripard ha scritto: On Thu, Nov 16, 2017 at 02:17:08PM +0100, Giulio Benetti wrote: Hi Hans, Il 16/11/2017 14:12, Hans Verkuil ha scritto: On 16/11/17 13:57, Giulio Benetti wrote: Il 16/11/2017

[PATCH v5 2/2] media: i2c: Add the ov7740 image sensor driver

The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu Signed-off-by: Wenyou Yang ---

[PATCH v5 0/2] media: ov7740: Add a V4L2 sensor-level driver

Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 VGA camera image sensor. Changes in v5: - Squash the driver and MAINTAINERS entry patches to one. - Precede the driver patch with the bindings patch. Changes in v4: - Assign 'val' a initial value to avoid warning: 'val' may be

[PATCH v5 1/2] media: ov7740: Document device tree bindings

Add the device tree binding documentation for the ov7740 sensor driver. Signed-off-by: Wenyou Yang --- Changes in v5: None Changes in v4: None Changes in v3: - Explicitly document the "remote-endpoint" property. Changes in v2: None

Re: [PATCH v2 02/11] media: rkisp1: Add user space ABI definitions

Hi Hans, 2017-11-27 18:26 GMT+08:00 Hans Verkuil : > On 11/24/2017 03:36 AM, Jacob Chen wrote: >> From: Jeffy Chen >> >> Add the header for userspace > > I gather that this effectively documents the metadata? > > I recommend using kernel-doc

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 28 05:00:23 CET 2017 media-tree git hash:04226916d2360f56d57ad00bc48d2d1854d1e0b0 media_build

[GIT PULL FOR v4.16] RC changes

Hi Mauro, This is my big rc-core pull request. In summary: - Teaches ir-kbd-i2c to send raw IR with the zilog microcontroller, tested on PVR-150 (ivtv), HVR-1600 (cx18), HD-PVR (hdpvr). Only driver which supports this hardware not tested is usbpvr2. - Removes lirc_zilog, lirc staging

Re: [PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings.

On 2017-11-27, at 19:09:38 +, Alan Cox wrote: > On Mon, 27 Nov 2017 12:44:50 + Jeremy Sowden wrote: > > Changed the types of some arrays from int16_t to s16 > > Which are the same type, except int16_t is the standard form. > > No point. Righto, so this would be one of those cases in which

[PATCH 0/4] fix some checkpatch style issues in atomisp driver

This patch series fixes some coding style issues reported by checkpatch. It is based on next-20171127. Riccardo Schirone (4): staging: add missing blank line after declarations in atomisp-ov5693 staging: improve comments usage in atomisp-ov5693 staging: improves comparisons readability

[PATCH 3/4] staging: improves comparisons readability in atomisp-ov5693

Fix "Comparisons should place the constant on the right side of the test" issue. Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 4/4] staging: fix indentation in atomisp-ov5693

Fix "suspect code indent for conditional statements" issue Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/4] staging: add missing blank line after declarations in atomisp-ov5693

Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

Re: [PATCH v2 02/11] media: rkisp1: Add user space ABI definitions

On 11/24/2017 03:36 AM, Jacob Chen wrote: > From: Jeffy Chen > > Add the header for userspace I gather that this effectively documents the metadata? I recommend using kernel-doc formatting here. One thing I immediately noticed is that these structures will have a

[RFC] v4l: i2c: ov7670: Implement mbus configuration

ov7670 currently supports configuration of a few parameters only through platform data. Implement media bus configuration by parsing DT properties at probe() time and opportunely configure REG_COM10 during s_format(). Signed-off-by: Jacopo Mondi --- Hi linux-media,

drivers/media/dvb-core/dvb_frontend.c:154:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganiz

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323 commit: b1cb7372fa822af6c06c8045963571d13ad6348b dvb_frontend: don't use-after-free the frontend struct date: 3 weeks ago coccinelle warnings: (new ones prefixed

[PATCH] dvb_frontend: fix ifnullfree.cocci warnings

drivers/media/dvb-core/dvb_frontend.c:154:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is

Re: [PATCH 0/3] Improve CEC autorepeat handling

On 11/27/2017 10:47 AM, Sean Young wrote: > Hi Hans, > > On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: >> On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: >>> On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: Due to the slowness of the CEC bus, autorepeat handling

Re: [PATCH 0/3] Improve CEC autorepeat handling

On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: > Hi Sean, > > On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: >> Due to the slowness of the CEC bus, autorepeat handling rather special >> on CEC. If the repeated user control pressed message is received, a >> keydown repeat should be

Re: [PATCH 0/3] Improve CEC autorepeat handling

Hi Hans, On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: > On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: > > On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: > >> Due to the slowness of the CEC bus, autorepeat handling rather special > >> on CEC. If the repeated user

Re: [PATCH v4 00/12] Intel IPU3 ImgU patchset

Hi Rajmohan, On 11/17/2017 03:58 AM, Mani, Rajmohan wrote: > Hi Sakari and all, > >> -Original Message- >> From: Zhi, Yong >> Sent: Tuesday, October 17, 2017 8:47 PM >> To: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com >> Cc: Zheng, Jian Xu ; Mani,

Re: [PATCH 0/3] Improve CEC autorepeat handling

On Mon, Nov 27, 2017 at 09:47:24AM +, Sean Young wrote: > Hi Hans, > > On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: > > On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: > > > On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: > > >> Due to the slowness of the CEC bus,

Re: [PATCH v2 01/11] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format

On 11/24/2017 03:36 AM, Jacob Chen wrote: > From: Shunqian Zheng > > Add the Rockchip ISP1 specific processing parameter format > V4L2_META_FMT_RK_ISP1_PARAMS and metadata format > V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. These formats are not documented in the V4L2 spec. I