Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-05 Thread jacopo mondi
Hi Dan, On Mon, Mar 05, 2018 at 10:21:09AM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 03:20:16PM +0100, jacopo mondi wrote: > > Hi Dan, > > > > On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > > > [ I know you're just copying files, but you might have a fix for these >

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-05 Thread Dan Carpenter
On Mon, Mar 05, 2018 at 09:51:48AM +0100, jacopo mondi wrote: > In your suggested fix: > > > (((vdelay >> 8) & 0x3) << 6) | > > (((vact >> 8) & 0x3) << 4) | > > (((hedelay >> 8) & 0x3) << 2) | > > ((hact >> 8) & 0x03); > > > > Won't your analyzer in that case point out that > "15

[PATCH 0/4] media: sun6i: Add support for the H3 CSI controller

2018-03-05 Thread Maxime Ripard
Hi, The H3 and H5 have a CSI controller based on the one previously found in the A31, that is currently supported by the sun6i-csi driver. Add the compatibles to the device tree bindings and to the driver to make it work properly. This obviously depends on the serie "Initial Allwinner V3s CSI

[PATCH 3/4] ARM: dts: sun8i: Add the H3/H5 CSI controller

2018-03-05 Thread Maxime Ripard
From: Mylène Josserand The H3 and H5 features the same CSI controller that was initially found on the A31. Add a DT node for it. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard ---

[PATCH 4/4] [DO NOT MERGE] ARM: dts: sun8i: Add CAM500B camera module to the Nano Pi M1+

2018-03-05 Thread Maxime Ripard
From: Mylène Josserand The Nano Pi M1+ comes with an optional sensor based on the ov5640 from Omnivision. Enable the support for it in the DT. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard

[PATCH 1/4] dt-bindings: media: sun6i: Add A31 and H3 compatibles

2018-03-05 Thread Maxime Ripard
The H3 has a slightly different CSI controller (no BT656, no CCI) which looks a lot like the original A31 controller. Add a compatible for the A31, and more specific compatible the for the H3 to be used in combination for the A31. Signed-off-by: Maxime Ripard ---

[PATCH 2/4] media: sun6i: Add A31 compatible

2018-03-05 Thread Maxime Ripard
The first device that used that IP was the A31. Add it to our list of compatibles. Signed-off-by: Maxime Ripard --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 0/7] media: sun6i: Various fixes and improvements

2018-03-05 Thread Yong
Hi Maxime, On Mon, 5 Mar 2018 10:35:27 +0100 Maxime Ripard wrote: > Hi Yong, > > Here are a bunch of patches I came up with after testing your last > (v8) version of the CSI patches. > > There's some improvements (patches 1 and 7) and fixes for > regressions found

[PATCH 3/7] media: sun6i: Pass the sun6i_csi_dev pointer to our helpers

2018-03-05 Thread Maxime Ripard
Some helpers need to log some errors for example when we don't support the format passed as an argument. However, we don't currently have a dev pointer available in those functions, preventing us from using any dev_* logging function. Fix that by passing the sun6i_csi_dev structure as an

[PATCH 1/7] media: sun6i: Fill dma_pfn_offset to accomodate for the RAM offset

2018-03-05 Thread Maxime Ripard
The CSI controller does its DMA accesses through a DMA bus that has the RAM mapped at the address 0. The current code removes from the dma_addr_t PHYS_OFFSET, and while it works, this is an abuse of the DMA API. Instead, fill the dma_pfn_offset field in the struct device that should be used to

[PATCH 7/7] media: sun6i: Expose controls on the v4l2_device

2018-03-05 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 8 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 ++ drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c | 6 ++ 3 files changed, 16 insertions(+) diff

[PATCH 8/8] media: sun6i: Add g_parm/s_parm ioctl support

2018-03-05 Thread Maxime Ripard
Add a g_parm and s_parm callback in order to be able to control the sensor framerate of the sensor. Signed-off-by: Maxime Ripard --- .../media/platform/sunxi/sun6i-csi/sun6i_video.c | 29 ++ 1 file changed, 29 insertions(+) diff --git

Re: [PATCH 8/8] media: sun6i: Add g_parm/s_parm ioctl support

2018-03-05 Thread Maxime Ripard
On Mon, Mar 05, 2018 at 10:35:35AM +0100, Maxime Ripard wrote: > Add a g_parm and s_parm callback in order to be able to control the sensor > framerate of the sensor. > > Signed-off-by: Maxime Ripard Hmmm, that patch shouldn't have been there. This is an outdated

[PATCH 0/7] media: sun6i: Various fixes and improvements

2018-03-05 Thread Maxime Ripard
Hi Yong, Here are a bunch of patches I came up with after testing your last (v8) version of the CSI patches. There's some improvements (patches 1 and 7) and fixes for regressions found in the v8 compared to the v7 (patches 2, 3, 4 and 5), and one fix that we discussed for the signals polarity

[PATCH 2/7] media: sun6i: Reduce the error level

2018-03-05 Thread Maxime Ripard
The is_format_support function can be called in the standard format negociation path with a sensor, where it's expected to have not exactly the same set of formats available. Reduce the error logging level when we find a format not supported to not have a lot of spurious messages. Signed-off-by:

[PATCH 5/7] media: sun6i: Support the YUYV format properly

2018-03-05 Thread Maxime Ripard
Currently, if we ever start a capture using the YUYV format, the switch case in the get_csi_input_seq function will not catch it since it considers it the default case. However, that switch default also calls dev_warn to log an error, which is this case will be either an unsupported format, or

[PATCH 6/7] media: sun6i: Invert the polarities

2018-03-05 Thread Maxime Ripard
A good look at an oscilloscope and test with a camera have shown that the polarity of all signals are actually reversed compared to the polarity documented in the datasheet for the clock, HSYNC and VSYNC signals. Signed-off-by: Maxime Ripard ---

[PATCH 4/7] media: sun6i: Don't emit a warning when the configured format isn't found

2018-03-05 Thread Maxime Ripard
Currently the driver will call WARN when a format isn't available, resulting in a kernel backtrace in our logs. This makes it look much more serious than it should be. Replace the call to the WARN macro to a dev_warn, which will still allow us to log what happened without making it too dramatic.

[PATCHv2 1/7] cec: add core error injection support

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil Add two new ops (error_inj_show and error_inj_parse_line) to support error injection functionality for CEC adapters. If both are present, then the core will add a new error-inj debugfs file that can be used to see the current error injection commands

[PATCHv2 0/7] cec: add error injection support

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for CEC error injection for drivers using the CEC Pin Framework (cec-pin.c). There are two CEC drivers currently using this framework: the sun4i Allwinner A10/A20 driver and the cec-gpio driver. This patch series was

[PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil The CEC Pin framework adds support for Error Injection. Document all the error injections commands and how to use it. Signed-off-by: Hans Verkuil --- .../media/cec-drivers/cec-pin-error-inj.rst| 322

[PATCHv2 2/7] cec-core.rst: document the error injection ops

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil Document the new core error injection callbacks. Signed-off-by: Hans Verkuil --- Documentation/media/kapi/cec-core.rst | 72 ++- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git

[PATCHv2 3/7] cec-pin: create cec_pin_start_timer() function

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil This function will be needed for injecting a custom pulse. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-pin-priv.h | 2 ++ drivers/media/cec/cec-pin.c | 21 + 2 files changed, 15

Re: [PULL] DVB-mmap Kconfig typo fix

2018-03-05 Thread Mauro Carvalho Chehab
Em Thu, 1 Mar 2018 07:55:20 -0500 Michael Ira Krufky escreveu: > Mauro, > > Please pull the following typo fix in the Kconfig for dvb-mmap: > > The following changes since commit 4df7ac5f42087dc9bcbed04b5cada0f025fbf9ef: > > drivers/media/Kconfig: typo: replace `with`

[PATCHv2 7/7] cec-pin: improve status log

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil Keep track of the number of short or long start bits, the number of short or long data bits and the number of initiated or detected low drive conditions. Show this information in the status debugfs log. Helpful when debugging, particularly when doing

[PATCHv2 4/7] cec-pin-error-inj: parse/show error injection

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil Add support to the CEC Pin framework to parse error injection commands and to show them. The next patch will do the actual implementation of this. Signed-off-by: Hans Verkuil --- drivers/media/cec/Kconfig | 6 +

[PATCHv2 5/7] cec-pin: add error injection support

2018-03-05 Thread Hans Verkuil
From: Hans Verkuil Implement all the error injection commands. The state machine gets new states for the various error situations, helper functions are added to detect whether an error injection is active and the actual error injections are implemented. Signed-off-by:

[PATCH 2/3] media: rc: add keymap for iMON RSC remote

2018-03-05 Thread Sean Young
Note that the stick on the remote is not supported yet. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-imon-rsc.c | 81 ++ include/media/rc-map.h | 1 + 3 files changed, 83

[PATCH 3/3] media: rc: new driver for early iMon device

2018-03-05 Thread Sean Young
These devices were supported by the lirc_imon.c driver which was removed from staging in commit f41003a23a02 ("[media] staging: lirc_imon: port remaining usb ids to imon and remove"). Signed-off-by: Sean Young --- MAINTAINERS | 7 ++ drivers/media/rc/Kconfig

[PATCH 1/3] Revert "[media] staging: lirc_imon: port remaining usb ids to imon and remove"

2018-03-05 Thread Sean Young
This code was ported without the necessary hardware to test. There are multiple problems which are more easily solved by writing a separate driver. This reverts commit f41003a23a02dc7299539300f74360c2a932714a. Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 135

Re: [PATCHv2 0/7] cec: add error injection support

2018-03-05 Thread Wolfram Sang
Hans, > Special thanks go to Wolfram Sang since his i2c error injection > presentation at the Embedded Linux Conference Europe 2017 inspired > me to switch to debugfs for this instead of using ioctls. You are very welcome! I am glad the presentation did inspire you. Happy hacking, Wolfram

Re: [PATCH V2 2/3] media: dvb-core: Added timers for dvb_ca_en50221_write_data

2018-03-05 Thread Mauro Carvalho Chehab
Em Wed, 14 Feb 2018 00:29:43 +0100 "Jasmin J." escreveu: > Hi! > > Please hold on in merging this series, because I have to investigate a hint > I got related to the buffer size handshake of the protocol driver: >

Re: [PATCH v4 1/2] media: dt-bindings: Add bindings for panasonic,amg88xx

2018-03-05 Thread Rob Herring
On Mon, Feb 26, 2018 at 10:11:35PM -0800, Matt Ranostay wrote: > Define the device tree bindings for the panasonic,amg88xx i2c > video driver. > > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > Signed-off-by: Matt Ranostay > --- >

[PATCH v9 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-03-05 Thread Yong Deng
Add binding documentation for Allwinner V3s CSI. Acked-by: Maxime Ripard Acked-by: Sakari Ailus Reviewed-by: Rob Herring Signed-off-by: Yong Deng --- .../devicetree/bindings/media/sun6i-csi.txt

[PATCH V3 1/2] [media] Add Rockchip RK1608 driver

2018-03-05 Thread Wen Nuan
From: Leo Wen Rk1608 is used as a PreISP to link on Soc, which mainly has two functions. One is to download the firmware of RK1608, and the other is to match the extra sensor such as camera and enable sensor by calling sensor's s_power. use below v4l2-ctl command to

[PATCH V3 0/2] Rockchip: Add RK1608 driver and DT-bindings

2018-03-05 Thread Wen Nuan
From: Leo Wen You can use the v4l2-ctl command to capture frames for RK1608. Add DT-bindings documentation for Rockchip RK1608. Add the information of the MAINTAINERS. Leo Wen (2): [media] Add Rockchip RK1608 driver dt-bindings: Document the Rockchip RK1608 bindings

[PATCH V3 2/2] dt-bindings: Document the Rockchip RK1608 bindings

2018-03-05 Thread Wen Nuan
From: Leo Wen Add DT bindings documentation for Rockchip RK1608. Changes V3: - Instead use the *-gpios. - Delete the rockchip,powerdown0 and rockchip,powerdown1 GPIO. - Delete the rockchip,reset0 and rockchip,reset1 GPIO. Signed-off-by: Leo Wen

[PATCH v9 2/2] media: V3s: Add support for Allwinner CSI.

2018-03-05 Thread Yong Deng
Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 interface and CSI1 is used for parallel interface. This is not documented in datasheet but by test and guess. This patch implement a v4l2 framework driver for it. Currently, the driver only support the parallel interface.

Re: [PATCH] media: ov2685: Not delay latch for gain

2018-03-05 Thread Tomasz Figa
On Thu, Mar 1, 2018 at 7:14 PM, Shunqian Zheng wrote: > Hi Tomasz, > > > On 2018年03月01日 16:53, Tomasz Figa wrote: >> >> Hi Shunqian, >> >> On Thu, Mar 1, 2018 at 5:44 PM, Shunqian Zheng >> wrote: >>> >>> Update the register 0x3503 to use 'no delay

[PATCH v9 0/2] Initial Allwinner V3s CSI Support

2018-03-05 Thread Yong Deng
This patchset add initial support for Allwinner V3s CSI. Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 interface and CSI1 is used for parallel interface. This is not documented in datasheet but by test and guess. This patchset implement a v4l2 framework driver and add a

Re: [PATCH v2 1/2] media: ov2680: dt: Add bindings for OV2680

2018-03-05 Thread Rob Herring
On Wed, Feb 28, 2018 at 03:27:22PM +, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > CC: devicet...@vger.kernel.org > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/i2c/ov2680.txt | 40 >

Donation For Charity Work

2018-03-05 Thread Friedrich And Ann Mayrhofer
-- Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Ann Mayrhofer.

cron job: media_tree daily build: ERRORS

2018-03-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 6 05:00:13 CET 2018 media-tree git hash:76bf7087fb2118aee16370821975f8a58febf68a media_build