Re: [PATCH] imx.rst: fix typo

2018-03-13 Thread Steve Longerbeam
Acked-by: Steve Longerbeam On 03/13/2018 11:29 AM, Hans Verkuil wrote: Multpiple -> Multiple Signed-off-by: Hans Verkuil --- diff --git a/Documentation/media/v4l-drivers/imx.rst b/Documentation/media/v4l-drivers/imx.rst index

[PATCH] pixfmt-v4l2.rst: fix broken enum :c:type:

2018-03-13 Thread Hans Verkuil
:c:type:: -> :c:type: Signed-off-by: Hans Verkuil --- diff --git a/Documentation/media/uapi/v4l/pixfmt-v4l2.rst b/Documentation/media/uapi/v4l/pixfmt-v4l2.rst index 2ee164c25637..6622938c1b41 100644 --- a/Documentation/media/uapi/v4l/pixfmt-v4l2.rst +++

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-13 Thread Hans Verkuil
On 03/09/2018 04:09 PM, Niklas Söderlund wrote: > This is an error from when the driver where converted from soc-camera. where -> was > There is absolutely no gain to check the state variable two times to be > extra sure if the hardware is stopped. I'll wait for v2 before applying this.

[PATCH] imx.rst: fix typo

2018-03-13 Thread Hans Verkuil
Multpiple -> Multiple Signed-off-by: Hans Verkuil --- diff --git a/Documentation/media/v4l-drivers/imx.rst b/Documentation/media/v4l-drivers/imx.rst index 18e3141304bb..65d3d15eb159 100644 --- a/Documentation/media/v4l-drivers/imx.rst +++

Re: [PATCH 3/3] rcar-vin: use scratch buffer and always run in continuous mode

2018-03-13 Thread Hans Verkuil
On 03/09/2018 04:09 PM, Niklas Söderlund wrote: > Instead of switching capture mode depending on how many buffers are > available use a scratch buffer and always run in continuous mode. By > using a scratch buffer the responsiveness of the capture loop is > increased as it can keep running even if

[PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-media-csi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5a195f80a24d..3a6a645b9dce 100644 ---

[GIT PULL for 4.17] Pile of atomisp patches

2018-03-13 Thread Sakari Ailus
Hi Mauro, Here's the usual pile of atomisp driver patches. Along with the usual cleanups, there's a fix that disables atomisp_compat_ioctl32 as well. The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90: media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08

RE: [PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-13 Thread David Laight
From: Kieran Bingham > Sent: 09 March 2018 22:04 > The kernel provides a __packed definition to abstract away from the > compiler specific attributes tag. > > Convert all packed structures in VSP1 to use it. > > Signed-off-by: Kieran Bingham > --- >

Re: [RFCv4,19/21] media: vim2m: add request support

2018-03-13 Thread Alexandre Courbot
On Fri, Mar 9, 2018 at 11:35 PM, Paul Kocialkowski wrote: > Hi, > > On Thu, 2018-03-08 at 22:48 +0900, Alexandre Courbot wrote: >> Hi Paul! >> >> Thanks a lot for taking the time to try this! I am also working on >> getting it to work with an actual driver, but you

[PATCH v3 0/2] media: Introduce Omnivision OV2680 driver

2018-03-13 Thread Rui Miguel Silva
Add driver and bindings for the OV2680 2 megapixel CMOS 1/5" sensor, which has a single MIPI lane interface and output format of 10-bit Raw RGB. Features supported are described in PATCH 2/2. v2->v3: Rob Herring: - add Reviewed-by tag to dts PATCH 1/1 Sakari Ailus: - align register

[PATCH v3 1/2] media: ov2680: dt: Add bindings for OV2680

2018-03-13 Thread Rui Miguel Silva
Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 ++ 1 file changed,

Re: [PATCH] media: omap3isp: fix unbalanced dma_iommu_mapping

2018-03-13 Thread Sakari Ailus
Hi Suman, Thanks for the patch. On Mon, Mar 12, 2018 at 11:52:07AM -0500, Suman Anna wrote: > The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware > ARM DMA backend. The current code creates a dma_iommu_mapping and > attaches this to the ISP device, but never detaches the

[PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, -

Re: [PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-13 Thread Kieran Bingham
Hi David, On 13/03/18 11:20, David Laight wrote: > From: Kieran Bingham >> Sent: 09 March 2018 22:04 >> The kernel provides a __packed definition to abstract away from the >> compiler specific attributes tag. >> >> Convert all packed structures in VSP1 to use it. >> >> Signed-off-by: Kieran

Re: [PATCH v8 13/13] [media] v4l: Document explicit synchronization behavior

2018-03-13 Thread jacopo mondi
Hi Gustavo, a very small comment below On Fri, Mar 09, 2018 at 02:49:20PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it > > v6: - Close some gaps in the docs (Hans) > > v5: > - Remove

[PATCH] media: s5p-mfc: Use real device for request_firmware() call

2018-03-13 Thread Marek Szyprowski
Provide proper (real) struct device to request_firmware() call. This fixes following error messages: (NULL device *): Direct firmware load for s5p-mfc-v6-v2.fw failed with error -2 (NULL device *): Direct firmware load for s5p-mfc-v6.fw failed with error -2 into a bit more meaningful ones:

Re: [PATCH 09/11] media: vsp1: Provide support for extended command pools

2018-03-13 Thread Kieran Bingham
Hi Jacopo, On 12/03/18 16:30, jacopo mondi wrote: > Hi Kieran, > just one small thing I noticed below... > > On Fri, Mar 09, 2018 at 10:04:07PM +, Kieran Bingham wrote: >> VSPD and VSP-DL devices can provide extended display lists supporting >> extended command display list objects. >>

Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-13 Thread Philipp Zabel
Hi Javier, On Mon, 2018-03-12 at 17:54 +0100, Javier Martin wrote: > Hi, > we have an i.MX6 Solo based board running the latest mainline kernel > (4.15.3). > > As part of our development we were measuring the decoding performance of > the i.MX6 coda chip. > > For that purpose we are feeding

[PATCH] venus: vdec: fix format enumeration

2018-03-13 Thread Alexandre Courbot
find_format_by_index() stops enumerating formats as soon as the index matches, and returns NULL if venus_helper_check_codec() finds out that the format is not supported. This prevents formats to be properly enumerated if a non-supported format is present, as the enumeration will end with it. Fix

Re: [PATCH] [media] mceusb: add IR learning support features (IR carrier frequency measurement and wide-band/short range receiver)

2018-03-13 Thread Sean Young
Hi, On Sun, Mar 11, 2018 at 05:40:28AM -0400, A Sun wrote: > > Windows Media Center IR transceivers include two IR receivers; > wide-band/short-range and narrow-band/long-range. The short-range > (5cm distance) receiver is for IR learning and has IR carrier > frequency measuring ability. > >

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
Hi Sakari, Thanks for the review... On Fri 09 Mar 2018 at 09:21, Sakari Ailus wrote: Hi Miguel, Thanks for the update. On Wed, Feb 28, 2018 at 03:27:23PM +, Rui Miguel Silva wrote: This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor

Re: [PATCH v2 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Sakari Ailus
On Tue, Mar 13, 2018 at 11:16:33AM +, Rui Miguel Silva wrote: ... > > > +static int ov2680_gain_set(struct ov2680_dev *sensor, bool > > > auto_gain) > > > +{ > > > + struct ov2680_ctrls *ctrls = >ctrls; > > > + u32 gain; > > > + int ret; > > > + > > > + ret = ov2680_mod_reg(sensor,

Re: coda: i.MX6 decoding performance issues for multi-streaming

2018-03-13 Thread Fabio Estevam
Hi Javier, On Mon, Mar 12, 2018 at 1:54 PM, Javier Martin wrote: > Hi, > we have an i.MX6 Solo based board running the latest mainline kernel > (4.15.3). > > As part of our development we were measuring the decoding performance of the > i.MX6 coda chip. > > For that

[PATCH] media: cxd2880-spi: avoid out-of-bounds access warning

2018-03-13 Thread Arnd Bergmann
The -Warray-bounds warning in gcc-8 triggers for a newly added file: drivers/media/spi/cxd2880-spi.c: In function 'cxd2880_write_reg': drivers/media/spi/cxd2880-spi.c:111:3: error: 'memcpy' forming offset [133, 258] is out of the bounds [0, 132] of object 'send_data' with type 'u8[132]' {aka

[PATCH] media: ngene: avoid unused variable warning

2018-03-13 Thread Arnd Bergmann
The newly added pdev variable is only used in an #ifdef, causing a build warning without CONFIG_PCI_MSI, unless we move the declaration inside the same #ifdef: drivers/media/pci/ngene/ngene-core.c: In function 'ngene_start': drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable

[PATCH] media: imx: work around false-positive warning

2018-03-13 Thread Arnd Bergmann
The IS_ERR()/PTR_ERR() combination confuses gcc to the point that it cannot prove the upstream_ep variable to be initialized: drivers/staging/media/imx/imx-media-csi.c: In function 'csi_link_validate': drivers/staging/media/imx/imx-media-csi.c:1025:20: error: 'upstream_ep' may be used

Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-13 Thread Maxime Ripard
Hi Sakari, On Fri, Mar 09, 2018 at 01:16:24PM +0200, Sakari Ailus wrote: > > + * > > + * +--+ > > + * | Oscillator | > > I wonder if this should be simply called external clock, that's what the > sensor uses. Ack > > + * +--+---+ > > + * | > > + *

Re: [PATCH 00/12] media: ov5640: Misc cleanup and improvements

2018-03-13 Thread Hugues FRUCHET
Thanks Maxime for this great series ! I've tested this series successfully on STM32 platform, I had a regression on JPEG capture linked to revisit of clocking, but easy to fix. I had another problem claimed by v4l2-compliance on format tests: v4l2-test-formats.cpp(961): Video Capture:

RE: [PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-13 Thread David Laight
From: Kieran Bingham [mailto:kieran.bingham+rene...@ideasonboard.com] > On 13/03/18 11:20, David Laight wrote: > > From: Kieran Bingham > >> Sent: 09 March 2018 22:04 > >> The kernel provides a __packed definition to abstract away from the > >> compiler specific attributes tag. > >> > >> Convert

Re: [PATCH 09/12] media: ov5640: Compute the clock rate at runtime

2018-03-13 Thread Hugues FRUCHET
Hi Maxime, Below comments about JPEG issue. On 03/02/2018 03:34 PM, Maxime Ripard wrote: > The clock rate, while hardcoded until now, is actually a function of the > resolution, framerate and bytes per pixel. Now that we have an algorithm to > adjust our clock rate, we can select it dynamically

Re: [PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-13 Thread Kieran Bingham
Hi David, On 13/03/18 13:38, David Laight wrote: > From: Kieran Bingham [mailto:kieran.bingham+rene...@ideasonboard.com] >> On 13/03/18 11:20, David Laight wrote: >>> From: Kieran Bingham Sent: 09 March 2018 22:04 The kernel provides a __packed definition to abstract away from the

[PATCH] media: v4l: omap_vout: vrfb: remove an unused variable

2018-03-13 Thread Arnd Bergmann
We now get a warning after the 'dmadev' variable is no longer used: drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb': drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable 'dmadev' [-Werror=unused-variable] Fixes: 8f0aa38292f2 ("media:

Re: [PATCH] media: v4l: omap_vout: vrfb: remove an unused variable

2018-03-13 Thread Peter Ujfalusi
On 2018-03-13 14:05, Arnd Bergmann wrote: > We now get a warning after the 'dmadev' variable is no longer used: > > drivers/media/platform/omap/omap_vout_vrfb.c: In function > 'omap_vout_prepare_vrfb': > drivers/media/platform/omap/omap_vout_vrfb.c:239:21: error: unused variable > 'dmadev'

Re: [PATCH] media: ov5640: add missing output pixel format setting

2018-03-13 Thread Akinobu Mita
2018-03-13 1:18 GMT+09:00 Hugues FRUCHET : > Hi Akinobu, > > Thanks for the patch, could you describe the test you made to reproduce > the issue that I can test on my side ? > > I'm using usually yavta or Gstreamer, but I don't know how to trig the > power on/off

[RfC PATCH] Add udmabuf misc device

2018-03-13 Thread Gerd Hoffmann
A driver to let userspace turn iovecs into dma-bufs. Use case: Allows qemu pass around dmabufs for the guest framebuffer. https://www.kraxel.org/cgit/qemu/log/?h=sirius/udmabuf has an experimental patch. Also allows qemu to export guest virtio-gpu resources as host dmabufs. Should be possible

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Daniel Vetter
On Tue, Mar 13, 2018 at 04:52:02PM +0100, Christian König wrote: > Am 13.03.2018 um 16:17 schrieb Daniel Vetter: > > [SNIP] > > > > I think a helper which both unmaps _and_ waits for all the fences to > > > > clear > > > > would be best, with some guarantees that it'll either fail or all the > >

Re: [PATCH 10/12] media: ov5640: Enhance FPS handling

2018-03-13 Thread Hugues FRUCHET
Hi Maxime, See below comments related to format compliance failing. On 03/02/2018 03:34 PM, Maxime Ripard wrote: > Now that we have moved the clock generation logic out of the bytes array, > these arrays are identical between the 15fps and 30fps variants. > > Remove the duplicate entries, and

Re: [PATCH 11/12] media: ov5640: Add 60 fps support

2018-03-13 Thread Hugues FRUCHET
Hi Maxime, See below rest of comments regarding framerate and compliance failure. On 03/02/2018 03:34 PM, Maxime Ripard wrote: > Now that we have everything in place to compute the clock rate at runtime, > we can enable the 60fps framerate for the mode we tested it with. > > Signed-off-by:

Re: [PATCH] media: omap3isp: fix unbalanced dma_iommu_mapping

2018-03-13 Thread Suman Anna
Hi Sakari, On 03/13/2018 06:14 AM, Sakari Ailus wrote: > Hi Suman, > > Thanks for the patch. > > On Mon, Mar 12, 2018 at 11:52:07AM -0500, Suman Anna wrote: >> The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware >> ARM DMA backend. The current code creates a dma_iommu_mapping

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Christian König
Am 13.03.2018 um 16:17 schrieb Daniel Vetter: [SNIP] I think a helper which both unmaps _and_ waits for all the fences to clear would be best, with some guarantees that it'll either fail or all the mappings _will_ be gone. The locking for that one will be hilarious, since we need to figure out

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Daniel Vetter
On Mon, Mar 12, 2018 at 08:13:15PM +0100, Christian K??nig wrote: > Am 12.03.2018 um 18:07 schrieb Daniel Vetter: > > On Fri, Mar 09, 2018 at 08:11:41PM +0100, Christian K??nig wrote: > > > [SNIP] > > > +/** > > > + * dma_buf_invalidate_mappings - invalidate all mappings of this dma_buf > > > + *

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-13 Thread Kieran Bingham
Hi Niklas, Thanks for the patch series :) - I've been looking forward to seeing this one ! On 10/03/18 01:09, Niklas Söderlund wrote: > This is an error from when the driver where converted from soc-camera. > There is absolutely no gain to check the state variable two times to be > extra sure if

Re: [RfC PATCH] Add udmabuf misc device

2018-03-13 Thread Daniel Vetter
On Tue, Mar 13, 2018 at 04:48:26PM +0100, Gerd Hoffmann wrote: > A driver to let userspace turn iovecs into dma-bufs. > > Use case: Allows qemu pass around dmabufs for the guest framebuffer. > https://www.kraxel.org/cgit/qemu/log/?h=sirius/udmabuf has an > experimental patch. > > Also allows

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2018-03-13 Thread Andy Shevchenko
On Sun, Mar 11, 2018 at 2:38 PM, FRÉDÉRIC PARRENIN wrote: > Dear Oliver and all, > > So I was expecting linux-4.16 to recognize my webcams, thanks to this new PCI > driver Oliver mentioned. > Therefore I installed 4.16-rc4. > Unfortunately, there is

Re: [PATCH] media: ngene: avoid unused variable warning

2018-03-13 Thread Daniel Scheller
Am Tue, 13 Mar 2018 14:06:03 +0100 schrieb Arnd Bergmann : > The newly added pdev variable is only used in an #ifdef, causing a > build warning without CONFIG_PCI_MSI, unless we move the declaration > inside the same #ifdef: > > drivers/media/pci/ngene/ngene-core.c: In function

Re: [PATCH 2/3] rcar-vin: allocate a scratch buffer at stream start

2018-03-13 Thread Kieran Bingham
Hi Niklas, On 10/03/18 01:09, Niklas Söderlund wrote: > Before starting capturing allocate a scratch buffer which can be used by "Before starting a capture, allocate a..." (two 'ings' together doesn't sound right) > the driver to give to the hardware if no buffers are available from >

Re: [PATCH v2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Fabio Estevam
Hi Peter, On Tue, Mar 13, 2018 at 7:34 PM, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer Could you please resend with a commit log explaining the reason for this patch? Tahnks

[PATCH v3 1/3] [media] dvb_frontend: add S2X and misc. other enums

2018-03-13 Thread Daniel Scheller
From: Daniel Scheller Additional enums: * FEC ratios 1/4 and 1/3 * 64/128/256-APSK modulations (DVB-S2X) * 15%, 10% and 5% rolloff factors (DVB-S2X) * 64K transmission mode (DVB-T2) Add these enums to the frontend.h docs exceptions aswell (uapi docs are updated

[PATCH v3 3/3] [media] dvb-frontends/stv0910: more detailed reporting in get_frontend()

2018-03-13 Thread Daniel Scheller
From: Daniel Scheller The first two missing FECs in the modcod2fec fe_code_rate table were 1/4 and 1/3. Add them as they're now defined by the API. Also, report the currently used S2 rolloff factor in get_frontend(). For cosmetic reasons, also change all feroll_off occurences

[PATCH v3 0/3] Add FEC rates, S2X params and 64K transmission

2018-03-13 Thread Daniel Scheller
From: Daniel Scheller Note: This v3 doesn't yet implement anything to allow userspace to detect bits regarding S2X, nor does it implement anything new to report frontend capabilities. At the moment, the main purpose for this is to enable any demod frontend to report the

[PATCH v3 2/3] [media] docs: documentation bits for S2X and the 64K transmission mode

2018-03-13 Thread Daniel Scheller
From: Daniel Scheller Add documentation bits regarding DVB-S2X. Since S2X only brings more APSK modulations and rolloff's, notice that S2 equals S2X where appropriate, and mention the additional modulations and rolloff's at the appropriate places. Signed-off-by: Daniel

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-03-13 Thread Kieran Bingham
Hi Niklas Thank you for this patch ... I know it has been a lot of work getting this and the VIN together! On 13/02/18 00:01, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are >

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Hello Steve, On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam wrote: > Hi Peter, > > Thanks for the patch. > > This needs to be done in imx-ic-prpencvf.c as well, see > prp_vb2_buf_done(). Ahh, I see, would you prefer an follow up patch or an v2 patch doing

Re: [PATCH] media: rc: meson-ir: add timeout on idle

2018-03-13 Thread Matthias Reichl
Hi Sean, On Mon, Mar 12, 2018 at 01:58:11PM +, Sean Young wrote: > On Mon, Mar 12, 2018 at 02:20:00PM +0100, Matthias Reichl wrote: > > On Sun, Mar 11, 2018 at 12:55:19PM +, Sean Young wrote: > > > That makes complete sense. I'm actually keen to get this lowered, since > > > this makes it

[PATCH 03/18] af9013: dvbv5 cnr

2018-03-13 Thread Antti Palosaari
Implement dvbv5 cnr. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 88 +-- drivers/media/dvb-frontends/af9013_priv.h | 1 + 2 files changed, 84 insertions(+), 5 deletions(-) diff --git

[PATCH 10/18] af9013: remove all legacy media attach releated stuff

2018-03-13 Thread Antti Palosaari
No one is binding that driver through media attach so remove it and all related dead code. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 80 drivers/media/dvb-frontends/af9013.h | 42 --- 2 files

[PATCH 07/18] af9013: convert inittabs suitable for regmap_update_bits

2018-03-13 Thread Antti Palosaari
Convert inttabs to format (reg, mask, val) which are suitable parameters to pass directly for regmap_update_bits. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 62 +- drivers/media/dvb-frontends/af9013_priv.h | 1488 +++--

[PATCH 05/18] af9013: wrap dvbv3 statistics via dvbv5

2018-03-13 Thread Antti Palosaari
Driver has calculated dvbv5 statistics, so use those as a base for legacy dvbv3 statistics. Wrap and convert needed values to dvbv3, remove old dvbv3 statistic implementations. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 306

[PATCH 09/18] af9015: attach demod using i2c binding

2018-03-13 Thread Antti Palosaari
af9013 demod driver has i2c binding. Use it. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 158 -- drivers/media/usb/dvb-usb-v2/af9015.h | 4 +- 2 files changed, 96 insertions(+), 66 deletions(-) diff --git

[PATCH 02/18] af9013: dvbv5 signal strength

2018-03-13 Thread Antti Palosaari
Implement dvbv5 signal strength estimate. We know tuner dependent -80dBm and -50dBm agc values, construct line equation and use it to map agc value to signal strength estimate. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 83

[PATCH 06/18] af9015: fix logging

2018-03-13 Thread Antti Palosaari
Pass correct device to dev_* logging functions, which allows us to remove redundant KBUILD_MODNAME and __func__ parameters from log format. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 160 +- 1 file changed, 81

[PATCH 12/18] af9015: use af9013 demod pid filters

2018-03-13 Thread Antti Palosaari
PID filters are moved to af9013 demod driver as those are property of demod. As pid filters are now implemented correctly by demod driver, we could enable pid filter support for possible slave demod too on dual tuner configuration. Signed-off-by: Antti Palosaari ---

[PATCH 15/18] af9015: enhance streaming config

2018-03-13 Thread Antti Palosaari
Replace static stream settings by one which enables and disables stream interface when needed (TS streaming control). 1) Configure both TS IF and USB endpoints according to current use case 2) Disable streaming USB endpoints when streaming is stopped and enable when streaming is started. Reduces

[PATCH 13/18] af9015: refactor firmware download

2018-03-13 Thread Antti Palosaari
Small revise, no functional changes. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 39 +++ 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c

[PATCH 04/18] af9013: dvbv5 ber and per

2018-03-13 Thread Antti Palosaari
Implement dvbv5 ber and per. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 73 +++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/af9013.c

[PATCH 18/18] af9015: correct some coding style issues

2018-03-13 Thread Antti Palosaari
Correct coding style issues reported mostly by checkpatch.pl. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 172 +- 1 file changed, 88 insertions(+), 84 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c

[PATCH 14/18] af9015: refactor copy firmware to slave demod

2018-03-13 Thread Antti Palosaari
Small improvements. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9015.c | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af9015.c

[PATCH 08/18] af9013: add i2c mux adapter for tuner bus

2018-03-13 Thread Antti Palosaari
Add muxed i2c adapter for demod tuner i2c bus gate control. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/Kconfig | 2 +- drivers/media/dvb-frontends/af9013.c | 126 +- drivers/media/dvb-frontends/af9013.h | 1 +

[PATCH 01/18] af9013: change lock detection slightly

2018-03-13 Thread Antti Palosaari
Whilst rewritten largely, the basic logic remains same with one exception: do not return immediately on success case. We are going to add statistics that function and cannot return too early. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 55

[PATCH 17/18] af9015: convert to regmap api

2018-03-13 Thread Antti Palosaari
Use regmap for chip register access. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/Kconfig | 1 + drivers/media/usb/dvb-usb-v2/af9015.c | 209 ++ drivers/media/usb/dvb-usb-v2/af9015.h | 2 + 3 files changed, 115 insertions(+),

[PATCH 16/18] dvb-usb-v2: add probe/disconnect callbacks

2018-03-13 Thread Antti Palosaari
Add probe and disconnect callbacks that behaves similarly than ones used commonly on Linux driver model. We need those to get early / late access to driver in order to use normal probe time stuff, like regmap, extra bus adapters and so. Signed-off-by: Antti Palosaari ---

[PATCH 11/18] af9013: add pid filter support

2018-03-13 Thread Antti Palosaari
af9013 demod has pid filter. Add support for it. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/af9013.c | 52 drivers/media/dvb-frontends/af9013.h | 5 2 files changed, 57 insertions(+) diff --git

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Steve Longerbeam
Hi Peter, Thanks for the patch. This needs to be done in imx-ic-prpencvf.c as well, see prp_vb2_buf_done(). Steve On 03/13/2018 01:00 PM, Peter Seiderer wrote: Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-media-csi.c | 5 + 1 file changed, 5

Re: [PATCH] media: rc: meson-ir: lower timeout and make configurable

2018-03-13 Thread Matthias Reichl
On Mon, Mar 12, 2018 at 09:48:40PM +, Sean Young wrote: > A timeout of 200ms is much longer than necessary, and delays the decoding > decoding of a single scancode and the last scancode when a button is being > held. This makes the remote seem sluggish. > > If the min_timeout and max_timeout

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Steve Longerbeam
On 03/13/2018 03:24 PM, Peter Seiderer wrote: Hello Steve, On Tue, 13 Mar 2018 15:03:07 -0700, Steve Longerbeam wrote: Hi Peter, Thanks for the patch. This needs to be done in imx-ic-prpencvf.c as well, see prp_vb2_buf_done(). Ahh, I see, would you prefer an

Re: [PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-13 Thread Kieran Bingham
Hi David, Just for reference here, I've posted a v2 of this patch now titled: [PATCH v2 02/11] media: vsp1: Remove packed attributes from aligned structures which removes the attributes instead of modifying them. Thanks for the pointers! Regards Kieran On 13/03/18 15:03, Kieran Bingham

[PATCH v2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-13 Thread Peter Seiderer
Signed-off-by: Peter Seiderer --- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 + drivers/staging/media/imx/imx-media-csi.c | 5 + 2 files changed, 10 insertions(+) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Christian König
Am 13.03.2018 um 17:00 schrieb Daniel Vetter: On Tue, Mar 13, 2018 at 04:52:02PM +0100, Christian König wrote: Am 13.03.2018 um 16:17 schrieb Daniel Vetter: [SNIP] Ok, so plan is to support fully pipeline moves and everything, with the old sg tables lazily cleaned up. I was thinking more about

[PATCH v2 06/11] media: vsp1: Provide VSP1 feature helper macro

2018-03-13 Thread Kieran Bingham
The VSP1 devices define their specific capabilities through features marked in their device info structure. Various parts of the code read this info structure to infer if the features are available. Wrap this into a more readable vsp1_feature(vsp1, f) macro to ensure that usage is consistent

[PATCH v2 09/11] media: vsp1: Provide support for extended command pools

2018-03-13 Thread Kieran Bingham
VSPD and VSP-DL devices can provide extended display lists supporting extended command display list objects. These extended commands require their own dma memory areas for a header and body specific to the command type. Implement a command pool to allocate all necessary memory in a single DMA

[PATCH v2 10/11] media: vsp1: Support Interlaced display pipelines

2018-03-13 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham

[PATCH v2 08/11] media: vsp1: Add support for extended display list headers

2018-03-13 Thread Kieran Bingham
Extended display list headers allow pre and post command lists to be executed by the VSP pipeline. This provides the base support for features such as AUTO_FLD (for interlaced support) and AUTO_DISP (for supporting continuous camera preview pipelines. Signed-off-by: Kieran Bingham

[PATCH v2 11/11] drm: rcar-du: Support interlaced video output through vsp1

2018-03-13 Thread Kieran Bingham
Use the newly exposed VSP1 interface to enable interlaced frame support through the VSP1 lif pipelines. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++ 2 files changed, 4

[PATCH v2 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

2018-03-13 Thread Kieran Bingham
Header mode display lists are now supported on all WPF outputs. To support extended headers and auto-fld capabilities for interlaced mode handling only header mode display lists can be used. Disable the headerless display list configuration, and remove the dead code. Signed-off-by: Kieran

[PATCH v2 05/11] media: vsp1: Clean up DLM objects on error

2018-03-13 Thread Kieran Bingham
If there is an error allocating a display list within a DLM object the existing display lists are not free'd, and neither is the DL body pool. Use the existing vsp1_dlm_destroy() function to clean up on error. Signed-off-by: Kieran Bingham ---

[PATCH v2 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-03-13 Thread Kieran Bingham
The use of the packed attribute can cause a performance penalty for all accesses to the struct members, as the compiler will assume that the structure has the potential to have an unaligned base. These structures are all correctly aligned and contain no holes, thus the attribute is redundant and

[PATCH v2 01/11] media: vsp1: drm: Fix minor grammar error

2018-03-13 Thread Kieran Bingham
The pixel format is 'unsupported'. Fix the small debug message which incorrectly declares this. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 04/11] media: vsp1: Remove unused display list structure field

2018-03-13 Thread Kieran Bingham
The vsp1 reference in the vsp1_dl_body structure is not used. Remove it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c

Re: [PATCH 1/3] rcar-vin: remove duplicated check of state in irq handler

2018-03-13 Thread Niklas Söderlund
Hi Kieran, Thanks for your feedback. On 2018-03-13 17:42:25 +0100, Kieran Bingham wrote: > Hi Niklas, > > Thanks for the patch series :) - I've been looking forward to seeing this one > ! > > On 10/03/18 01:09, Niklas Söderlund wrote: > > This is an error from when the driver where converted

[PATCH v2 00/11] R-Car DU Interlaced support through VSP1

2018-03-13 Thread Kieran Bingham
The Gen3 R-Car DU devices make use of the VSP to handle frame processing. In this series we implement support for handling interlaced pipelines by using the auto-fld feature of the VSP hardware. The implementation is preceded by some cleanup work and refactoring, through patches 1 to 6. These

[PATCH v2 03/11] media: vsp1: Rename dl_child to dl_next

2018-03-13 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham

Re: [PATCH v8 03/13] [media] omap3isp: group device capabilities

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps > earlier with this value. > > Signed-off-by: Gustavo Padovan > --- >

Re: [PATCH v8 04/13] [media] vb2: add is_unordered callback for drivers

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Explicit synchronization benefits a lot from ordered queues, they fit > better in a pipeline with DRM for example so create a opt-in way for > drivers notify videobuf2 that the queue is

Re: [PATCH v8 11/13] [media] v4l: introduce the fences capability

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Drivers capable of using fences (vb2 drivers) should report the > V4L2_CAP_FENCES to userspace, so add this flag to the uapi. > > Signed-off-by: Gustavo Padovan

[PATCH v2 1/2] rcar-vin: allocate a scratch buffer at stream start

2018-03-13 Thread Niklas Söderlund
Before starting a capture, allocate a scratch buffer which can be used by the driver to give to the hardware if no buffers are available from userspace. The buffer is not used in this patch but prepares for future refactoring where the scratch buffer can be used to avoid the need to fallback on

[PATCH v2 0/2] rcar-vin: always run in continues mode

2018-03-13 Thread Niklas Söderlund
Hi, This series reworks the R-Car VIN driver to only run using its continues capture mode. This improves performance a lot when userspace struggles to keep up and queue buffers as fast as the VIN driver consumes them. The solution to always be able to run in continues is to introduce a scratch

Re: [PATCH v8 06/13] [media] cobalt: add .is_unordered() for cobalt

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v2: - use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo Padovan

Re: [PATCH v8 08/13] [media] vb2: add explicit fence user API

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel or return an out-fence from the kernel to > userspace. > > Two new flags were added,

Re: [PATCH v8 07/13] [media] vb2: mark codec drivers as unordered

2018-03-13 Thread Hans Verkuil
On 03/09/2018 09:49 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > In preparation to have full support to explicit fence we are > marking codec as non-ordered preventively. It is easier and safer from an > uAPI point of view to move from unordered to

cron job: media_tree daily build: ERRORS

2018-03-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 14 05:00:10 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build

  1   2   >