Re: [PATCH 13/15] v4l: vsp1: Assign BRU and BRS to pipelines dynamically

2018-04-04 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 4 April 2018 19:00:10 EEST Kieran Bingham wrote: > Hi Laurent, > > Thank you for the patch. > > I don't envy you on having to deal with this one ... it's a bit of a pain > ... Yes it was a bit painful :-/ The devil was both in the big picture and the details this

Re: cron job: media_tree daily build: OK

2018-04-04 Thread Hans Verkuil
On 04/04/18 13:15, Mauro Carvalho Chehab wrote: > Hi Hans, > > Em Wed, 04 Apr 2018 05:45:22 +0200 > "Hans Verkuil" escreveu: > > Not sure what versions of sparse/smatch you're using. Here, I'm using the > latest version from both trees. Anyway, I'm getting different results

Re: [PATCH 0/3] Improve latency of IR decoding

2018-04-04 Thread Matthias Reichl
Hi Sean, On Wed, Mar 28, 2018 at 08:30:29PM +0200, Matthias Reichl wrote: > Hi Sean, > > On Sat, Mar 24, 2018 at 02:50:42PM +, Sean Young wrote: > > The current IR decoding is much too slow. Many IR protocols rely on > > a trailing space for decoding (e.g. rc-6 needs to know when the bits >

Re: cron job: media_tree daily build: OK

2018-04-04 Thread Mauro Carvalho Chehab
Hi Hans, Em Wed, 04 Apr 2018 05:45:22 +0200 "Hans Verkuil" escreveu: Not sure what versions of sparse/smatch you're using. Here, I'm using the latest version from both trees. Anyway, I'm getting different results than you (both built for i386). > sparse: WARNINGS The only

[PATCH] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props()

2018-04-04 Thread Mauro Carvalho Chehab
The logic at v4l2_fwnode_reference_parse_int_props() is somewhat complex and violates Linux coding style, as it does multiple statements on a single line. That makes static analyzers to be confused, as warned by smatch: drivers/media/v4l2-core/v4l2-fwnode.c:832

Re: [PATCH 02/18] media: staging: atomisp: do some coding style improvements

2018-04-04 Thread Sakari Ailus
On Mon, Mar 26, 2018 at 05:10:35PM -0400, Mauro Carvalho Chehab wrote: > Use make coccicheck in patch mode to do some coding style > improvements. Adjust the results manually. > > Signed-off-by: Mauro Carvalho Chehab Hi Mauro, For patches 2--18, please add: Acked-by:

Regression: DVBSky S960 USB tuner doesn't work in 4.10 or newer

2018-04-04 Thread Olli Salonen
Hello Peter and Max, I noticed that when using kernel 4.10 or newer my DVBSky S960 and S960CI satellite USB TV tuners stopped working properly. Basically, they will fail at one point when tuning to a channel. This typically takes less than 100 tuning attempts. For perspective, when performing a

Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller

2018-04-04 Thread Hans Verkuil
Hi Niklas, It might be a good idea if you can rebase the patch series on the latest master (we've just synced to Linus' master tree) and incorporate the few comments that Laurent had. Then once the merge window closes I can make the pull request, probably on the 16th. Regards, Hans On

cron job: media_tree daily build: OK

2018-04-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Apr 5 05:00:14 CEST 2018 media-tree git hash:17dec0a949153d9ac00760ba2f5b78cb583e995f media_build

Re: Linux 4.16 Kernel Boot Crash

2018-04-04 Thread Jani Nikula
On Tue, 03 Apr 2018, Peter Geis wrote: > Good Evening, > > I have been trying to use the 4.16 kernel source since 4.16-rc3. > Every time it booted it crashed upon loading the video drivers. > Now with the 4.16 release, it is still occurring, so I felt it prudent > to notify

[PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-04-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used as a bridge between pixel interfaces and a CSI-2 bus. It supports operating with an internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. While the virtual

[PATCH v8 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-04-04 Thread Maxime Ripard
Hi, Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. This IP block is able to receive 4 video streams and stream them over a MIPI-CSI2 link using up to 4 lanes. Those streams are basically the interfaces to controllers generating some video signals, like a camera or a

[PATCH 1/1] v4l: Add macros for printing V4L 4cc values

2018-04-04 Thread Sakari Ailus
Add two macros that facilitate printing V4L fourcc values with printf family of functions. v4l2_fourcc_conv provides the printf conversion specifier for printing formats and v4l2_fourcc_to_conv provides the actual arguments for that conversion specifier. These macros are useful in both user and

[PATCH v9 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-04-04 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. It also support dynamic

[PATCH v9 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2018-04-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v9 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX

2018-04-04 Thread Maxime Ripard
Hi, Here is another attempt at supporting the MIPI-CSI2 RX block from Cadence. This IP block is able to receive CSI data over up to 4 lanes, and split it to over 4 streams. Those streams are basically the interfaces to the video grabbers that will perform the capture. It is able to map streams

[PATCH v8 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-04-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 video streams and can output on up to 4 CSI-2 lanes, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

Patch "media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Re: [PATCH 01/15] v4l: vsp1: Don't start/stop media pipeline for DRM

2018-04-04 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The DRM support code manages a pipeline of VSP entities, each backed by > a media entity. When starting or stopping the pipeline, it starts and > stops the media pipeline through the media API in order to store the > pipeline pointer in

Patch "media: v4l2-compat-ioctl32.c: don't copy back the result for certain errors" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: don't copy back the result for certain errors to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Patch "media: v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: copy m.userptr in put_v4l2_plane32 to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "media: v4l2-compat-ioctl32.c: drop pr_info for unknown buffer type" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: drop pr_info for unknown buffer type to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Re: [PATCH v13 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

2018-04-04 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday, 13 February 2018 01:01:31 EEST Niklas Söderlund wrote: > Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers > are located between the video sources (CSI-2 transmitters) and the video > grabbers (VIN) on Gen3 of Renesas R-Car

[v4l-utils PATCH 1/1] cec-ctl: Prepare for __inline__ instead of inline

2018-04-04 Thread Sakari Ailus
Once formatted for user space consumption, inlined functions in include/uapi/linux/cec-funcs.h have "__inline__" modifier instead of "inline" at least in some circumstances. msg2ctl.pl gets confused of __inline__, allow both to avoid trouble. Signed-off-by: Sakari Ailus

Patch "media: media/v4l2-ctrls: volatiles should not generate CH_VALUE" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: media/v4l2-ctrls: volatiles should not generate CH_VALUE to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "media: v4l2-ctrls: fix sparse warning" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-ctrls: fix sparse warning to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018-04-04 Thread Greg KH
On Wed, Mar 28, 2018 at 03:12:19PM -0300, Mauro Carvalho Chehab wrote: > Hi Greg, > > Those are the backports meant to solve CVE-2017-13166 on Kernel 3.18. > > It contains two v4l2-ctrls fixes that are required to avoid crashes > at the test application. > > I wrote two patches myself for

Re: [PATCH] media: platform: video-mux: propagate format from sink to source

2018-04-04 Thread Chris Lesiak
Hi Philipp, On 04/04/2018 04:34 AM, Philipp Zabel wrote: Hi Chris, On Tue, 2018-04-03 at 14:50 -0500, Chris Lesiak wrote: Propagate the v4l2_mbus_framefmt to the source pad when either a sink pad is activated or when the format of the active sink pad changes. Thank you, this fixes the

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-04 Thread Laurent Pinchart
Hello, On Wednesday, 14 March 2018 00:23:49 EEST Kieran Bingham wrote: > Hi Niklas > > Thank you for this patch ... > I know it has been a lot of work getting this and the VIN together! > > On 13/02/18 00:01, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The

Patch "media: v4l2-compat-ioctl32.c: refactor compat ioctl32 logic" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: refactor compat ioctl32 logic to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "media: v4l2-compat-ioctl32.c: move 'helper' functions to __get/put_v4l2_format32" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: move 'helper' functions to __get/put_v4l2_format32 to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The

Patch "media: v4l2-compat-ioctl32.c: fix ctrl_is_pointer" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: fix ctrl_is_pointer to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "media: v4l2-compat-ioctl32: Copy v4l2_window->global_alpha" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32: Copy v4l2_window->global_alpha to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH 13/15] v4l: vsp1: Assign BRU and BRS to pipelines dynamically

2018-04-04 Thread Kieran Bingham
Hi Laurent, Thank you for the patch. I don't envy you on having to deal with this one ... it's a bit of a pain ... On 26/02/18 21:45, Laurent Pinchart wrote: > The VSPDL variant drives two DU channels through two LIF and two > blenders, BRU and BRS. The DU channels thus share the five available

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-04 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday, 13 February 2018 01:01:32 EEST Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources and the video

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-04 Thread Laurent Pinchart
Hi Maxime, On Thursday, 29 March 2018 14:30:39 EEST Maxime Ripard wrote: > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > + break; > > + case 2: > > +

Patch "media: v4l2-compat-ioctl32.c: avoid sizeof(type)" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: avoid sizeof(type) to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "media: v4l2-compat-ioctl32: initialize a reserved field" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32: initialize a reserved field to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "media: v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32 to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the

Patch "media: v4l2-compat-ioctl32: use compat_u64 for video standard" has been added to the 3.18-stable tree

2018-04-04 Thread gregkh
This is a note to let you know that I've just added the patch titled media: v4l2-compat-ioctl32: use compat_u64 for video standard to the 3.18-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: Linux 4.16 Kernel Boot Crash

2018-04-04 Thread Peter Geis
Good Afternoon, I have been digging into this issue further, and the problem is definitely with the media driver. Rebuilt the kernel with media drivers compiled in vice modular and the kernel boots without issue. The core dump states the crash occurred at drivers/media/v4l2-core/v4l2-dev.c,

Re: [PATCH 11/15] v4l: vsp1: Add per-display list completion notification support

2018-04-04 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > Display list completion is already reported to the frame end handler, > but that mechanism is global to all display lists. In order to implement > BRU and BRS reassignment in DRM pipelines we will need to wait for > completion of a

Re: [PATCH 15/15] v4l: vsp1: Rename BRU to BRx

2018-04-04 Thread Kieran Bingham
Hi Laurent, And so - the final patch (of the series) On 26/02/18 21:45, Laurent Pinchart wrote: > Some VSP instances have two blending units named BRU (Blend/ROP Unit) > and BRS (Blend/ROP Sub unit). The BRS is a smaller version of the BRU > with only two inputs, but otherwise offers similar

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-04-04 Thread Kieran Bingham
Hi Laurent, On 02/04/18 13:35, Laurent Pinchart wrote: >>> +/* Setup the output side of the pipeline (WPF and LIF). */ >>> +static int vsp1_du_pipeline_setup_output(struct vsp1_device *vsp1, >>> +struct vsp1_pipeline *pipe) >>> +{ >>> + struct

Re: [PATCH 14/15] v4l: vsp1: Add BRx dynamic assignment debugging messages

2018-04-04 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > Dynamic assignment of the BRU and BRS to pipelines is prone to > regressions, add messages to make debugging easier. Keep it as a > separate commit to ease removal of those messages once the code will > deem to be completely stable. > >

Re: [PATCH 0/3] Improve latency of IR decoding

2018-04-04 Thread Sean Young
Hi Matthias, On Wed, Apr 04, 2018 at 01:44:01PM +0200, Matthias Reichl wrote: > On Wed, Mar 28, 2018 at 08:30:29PM +0200, Matthias Reichl wrote: > > Hi Sean, > > > > On Sat, Mar 24, 2018 at 02:50:42PM +, Sean Young wrote: > > > The current IR decoding is much too slow. Many IR protocols rely

Re: Linux 4.16 Kernel Boot Crash

2018-04-04 Thread Mauro Carvalho Chehab
Em Wed, 4 Apr 2018 16:26:22 +0300 Jaak Ristioja escreveu: > Hello, all! > > I experience the same issue with a Lenovo ThinkPad T440p (LENOVO > 20AN006VMS/20AN006VMS, BIOS GLET90WW (2.44 ) 09/13/2017). I tried to > bisect v4.15..v4.16 but failed. Could you post the complete

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Robert Jarzmik
Ulf Hansson writes: > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >> Hi, >> >> This serie is aimed at removing the dmaengine slave compat use, and transfer >> knowledge of the DMA requestors into architecture code. >> As this looks like a

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Boris Brezillon
On Wed, 04 Apr 2018 21:49:26 +0200 Robert Jarzmik wrote: > Ulf Hansson writes: > > > On 2 April 2018 at 16:26, Robert Jarzmik wrote: > >> Hi, > >> > >> This serie is aimed at removing the dmaengine slave compat use, and

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-04 Thread Sakari Ailus
Hi Maxime and Niklas, On Thu, Mar 29, 2018 at 01:30:39PM +0200, Maxime Ripard wrote: > Hi Niklas, > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > +

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-04-04 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 4 April 2018 19:15:19 EEST Kieran Bingham wrote: > On 02/04/18 13:35, Laurent Pinchart wrote: > > > > >>> +/* Setup the output side of the pipeline (WPF and LIF). */ > >>> +static int vsp1_du_pipeline_setup_output(struct vsp1_device *vsp1, > >>> +

Re: [PATCH] media: ir-spi: update Andi's e-mail

2018-04-04 Thread Sean Young
Hi Andi, On Wed, Mar 28, 2018 at 06:34:24PM +0900, Andi Shyti wrote: > Because I will be leaving Samsung soon, update my e-mail to the > etezian.org mail. > > CC: Mauro Carvalho Chehab > Signed-off-by: Andi Shyti > --- > drivers/media/rc/ir-spi.c |

Re: [PATCH 11/15] v4l: vsp1: Add per-display list completion notification support

2018-04-04 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 4 April 2018 19:16:46 EEST Kieran Bingham wrote: > On 26/02/18 21:45, Laurent Pinchart wrote: > > Display list completion is already reported to the frame end handler, > > but that mechanism is global to all display lists. In order to implement > > BRU and BRS

Re: [PATCH] media: platform: video-mux: propagate format from sink to source

2018-04-04 Thread Philipp Zabel
Hi Chris, On Tue, 2018-04-03 at 14:50 -0500, Chris Lesiak wrote: > Propagate the v4l2_mbus_framefmt to the source pad when either a sink > pad is activated or when the format of the active sink pad changes. Thank you, this fixes the V4L2_SUBDEV_FORMAT_TRY use case as well as propagation of the

[PATCH] media: dvb_frontend: fix wrong cast in compat_ioctl

2018-04-04 Thread Katsuhiro Suzuki
FE_GET_PROPERTY has always failed as following situations: - Use compatible ioctl - The array of 'struct dtv_property' has 2 or more items This patch fixes wrong cast to a pointer 'struct dtv_property' from a pointer of 2nd or after item of 'struct compat_dtv_property' array. Signed-off-by: