[PATCH v2.1 09/15] v4l: vsp1: Move DRM pipeline output setup code to a function

In order to make the vsp1_du_setup_lif() easier to read, and for symmetry with the DRM pipeline input setup, move the pipeline output setup code to a separate function. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

Re: [RfC PATCH] Add udmabuf misc device

On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote: > On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: > > Hi, > > > >>>I fail to see any common ground for xen-zcopy and udmabuf ... > >>Does the above mean you can assume that xen-zcopy and udmabuf > >>can co-exist as two

Re: [PATCH v2 12/19] media: davinci: allow build vpbe_display with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [RFCv9 PATCH 04/29] media-request: core request support

Hi Hans, Thanks for your work on this. A few comments below... On Wed, Mar 28, 2018 at 03:50:05PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Implement the core of the media request processing. > > Drivers can bind request objects to a request. These objects >

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH v2.1 06/15] v4l: vsp1: Move DRM atomic commit pipeline setup to separate function

The DRM pipeline setup code used at atomic commit time is similar to the setup code used when enabling the pipeline. Move it to a separate function in order to share it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

Re: [PATCH v7 3/8] media: vsp1: Provide a body pool

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:26 EEST Kieran Bingham wrote: > Each display list allocates a body to store register values in a dma > accessible buffer from a dma_alloc_wc() allocation. Each of these > results in an entry in the TLB, and a large number of

[PATCH v8 1/2] media: dt-bindings: Add bindings for panasonic,amg88xx

Define the device tree bindings for the panasonic,amg88xx i2c video driver. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Matt Ranostay --- .../bindings/media/i2c/panasonic,amg88xx.txt | 19 +++ 1

[PATCH v8 2/2] media: video-i2c: add video-i2c driver

There are several thermal sensors that only have a low-speed bus interface but output valid video data. This patchset enables support for the AMG88xx "Grid-Eye" sensor family. Signed-off-by: Matt Ranostay --- MAINTAINERS | 6 +

[PATCH v8 0/2] media: video-i2c: add video-i2c driver support

Add support for video-i2c polling driver Changes from v1: * Switch to SPDX tags versus GPLv2 license text * Remove unneeded zeroing of data structures * Add video_i2c_try_fmt_vid_cap call in video_i2c_s_fmt_vid_cap function Changes from v2: * Add missing linux/kthread.h include that broke x86_64

Re: [PATCH v7 5/8] media: vsp1: Use reference counting for bodies

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:28 EEST Kieran Bingham wrote: > Extend the display list body with a reference count, allowing bodies to > be kept as long as a reference is maintained. This provides the ability > to keep a cached copy of bodies which will not

Re: [PATCH v7 7/8] media: vsp1: Adapt entities to configure into a body

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:30 EEST Kieran Bingham wrote: > Currently the entities store their configurations into a display list. > Adapt this such that the code can be configured into a body directly, > allowing greater flexibility and control of the

Re: [PATCH v7 1/8] media: vsp1: Reword uses of 'fragment' as 'body'

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:24 EEST Kieran Bingham wrote: > Throughout the codebase, the term 'fragment' is used to represent a > display list body. This term duplicates the 'body' which is already in > use. > > The datasheet references these objects as a

Re: [PATCH v7 0/8] vsp1: TLB optimisation and DL caching

Hi Kieran, I've finished reviewing the series. For your convenience, I've rebased it on top of the BRU/BRS dynamic allocation patches, and pushed the result to git://linuxtv.org/pinchartl/media.git v4l2/vsp1/tlb-optimise (Please note it has been compile-tested only) I have also taken

Re: [PATCH v2 19/19] media: staging: davinci_vpfe: allow building with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20180406] [cannot apply to v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v7 4/8] media: vsp1: Convert display lists to use new body pool

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:27 EEST Kieran Bingham wrote: > Adapt the dl->body0 object to use an object from the body pool. This > greatly reduces the pressure on the TLB for IPMMU use cases, as all of > the lists use a single allocation for the main body.

Re: Webcams not recognized on a Dell Latitude 5285 laptop

Hi Frédéric, On Thu, Mar 29, 2018 at 09:53:45AM +0200, FRÉDÉRIC PARRENIN wrote: > The second part now. I looked at the tables and it seems the dsdt lists two sensors (imx135 and ov2740) but the rest of the information on how they're connected etc. is missing. There are no sensor drivers in

Re: [PATCH v7 6/8] media: vsp1: Refactor display list configure operations

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:29 EEST Kieran Bingham wrote: > The entities provide a single .configure operation which configures the > object into the target display list, based on the vsp1_entity_params > selection. > > This restricts us to a single

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

Hi Kieran, Thank you for the patch. On Thursday, 8 March 2018 02:05:31 EEST Kieran Bingham wrote: > We are now able to configure a pipeline directly into a local display > list body. Take advantage of this fact, and create a cacheable body to > store the configuration of the pipeline in the

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Apr 7 05:00:16 CEST 2018 media-tree git hash:17dec0a949153d9ac00760ba2f5b78cb583e995f media_build

Re: [PATCH 02/16] media: omap3isp: allow it to build with COMPILE_TEST

Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2] Add udmabuf misc device

Am 06.04.2018 um 11:33 schrieb Gerd Hoffmann: Hi, The pages backing a DMA-buf are not allowed to move (at least not without a patch set I'm currently working on), but for certain MM operations to work correctly you must be able to modify the page tables entries and move the pages backing

Re: [RfC PATCH] Add udmabuf misc device

On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: Hi, I fail to see any common ground for xen-zcopy and udmabuf ... Does the above mean you can assume that xen-zcopy and udmabuf can co-exist as two different solutions? Well, udmabuf route isn't fully clear yet, but yes. See also gvt (intel

Re: [PATCH v2 02/19] media: omap3isp: allow it to build with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [RfC PATCH] Add udmabuf misc device

On 04/06/2018 03:11 AM, Matt Roper wrote: On Thu, Apr 05, 2018 at 10:32:04PM +0200, Daniel Vetter wrote: Pulling this out of the shadows again. We now also have xen-zcopy from Oleksandr and the hyper dmabuf stuff from Matt and Dongwong. At least from the intel side there seems to be the idea

Re: [PATCH v2 16/19] media: omap: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [RfC PATCH] Add udmabuf misc device

On 04/06/2018 12:07 PM, Gerd Hoffmann wrote: Hi, * The general interface should be able to express sharing from any guest:guest, not just guest:host. Arbitrary G:G sharing might be something some hypervisors simply aren't able to support, but the userspace API itself

Re: [RfC PATCH] Add udmabuf misc device

On Fri, Apr 06, 2018 at 10:52:21AM +0100, Daniel Stone wrote: > Hi Gerd, > > On 14 March 2018 at 08:03, Gerd Hoffmann wrote: > >> Either mlock account (because it's mlocked defacto), and get_user_pages > >> won't do that for you. > >> > >> Or you write the full-blown userptr

Re: [RfC PATCH] Add udmabuf misc device

On 04/06/2018 12:07 PM, Gerd Hoffmann wrote: I'm not sure we can create something which works on both kvm and xen. The memory management model is quite different ... On xen the hypervisor manages all memory. Guests can allow other guests to access specific pages (using grant tables). In

Re: [RfC PATCH] Add udmabuf misc device

Hi, > > I fail to see any common ground for xen-zcopy and udmabuf ... > Does the above mean you can assume that xen-zcopy and udmabuf > can co-exist as two different solutions? Well, udmabuf route isn't fully clear yet, but yes. See also gvt (intel vgpu), where the hypervisor interface is

Re: [PATCH v2 05/19] media: fsl-viu: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

On Fri, Apr 6, 2018 at 11:47 AM, Mauro Carvalho Chehab wrote: > [PATCH] media: fsl-viu: allow building it with COMPILE_TEST > > There aren't many things that would be needed to allow it > to build with compile test. > > Add the needed bits. > > Signed-off-by: Mauro

Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH] media: coda: do not try to propagate format if capture queue busy

On 28/03/18 18:12, Philipp Zabel wrote: The driver helpfully resets the capture queue format and selection rectangle whenever output format is changed. This only works while the capture queue is not busy. Signed-off-by: Philipp Zabel ---

Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST

On 05/04/18 23:29, Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab >

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

Em Thu, 5 Apr 2018 23:35:06 +0200 Arnd Bergmann escreveu: > On Thu, Apr 5, 2018 at 7:54 PM, Mauro Carvalho Chehab > wrote: > > There aren't many things that would be needed to allow it > > to build with compile test. > > > +/* Allow building this

Re: [PATCH v7 2/2] media: video-i2c: add video-i2c driver

Hi Matt, Thanks for the update. A few minor bits, please see below. On Thu, Apr 05, 2018 at 10:14:49PM -0700, Matt Ranostay wrote: > There are several thermal sensors that only have a low-speed bus > interface but output valid video data. This patchset enables support > for the AMG88xx

Re: [RfC PATCH] Add udmabuf misc device

Hi, > > * The general interface should be able to express sharing from any > > guest:guest, not just guest:host. Arbitrary G:G sharing might be > > something some hypervisors simply aren't able to support, but the > > userspace API itself shouldn't make assumptions or restrict

Re: [PATCH v2] Add udmabuf misc device

Hi, > The pages backing a DMA-buf are not allowed to move (at least not without a > patch set I'm currently working on), but for certain MM operations to work > correctly you must be able to modify the page tables entries and move the > pages backing them around. > > For example try to use

Re: [RfC PATCH] Add udmabuf misc device

Hi Gerd, On 14 March 2018 at 08:03, Gerd Hoffmann wrote: >> Either mlock account (because it's mlocked defacto), and get_user_pages >> won't do that for you. >> >> Or you write the full-blown userptr implementation, including mmu_notifier >> support (see i915 or amdgpu), but

[PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

The dependency of DRM_OMAP = n can be relaxed for just compilation test. This allows building the omap3isp driver with allyesconfig on ARM. Signed-off-by: Mauro Carvalho Chehab --- drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 05/19] media: fsl-viu: allow building it with COMPILE_TEST

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab wrote: > Em Fri, 6 Apr 2018 11:51:16 +0200 > Arnd Bergmann escreveu: > >> On Fri, Apr 6, 2018 at 11:47 AM, Mauro Carvalho Chehab >> wrote: >> >> > [PATCH] media: fsl-viu:

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

Em Fri, 6 Apr 2018 16:16:46 +0200 Arnd Bergmann escreveu: > On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab > wrote: > > Em Fri, 6 Apr 2018 11:51:16 +0200 > > Arnd Bergmann escreveu: > > > >> On Fri, Apr 6, 2018 at 11:47 AM, Mauro

[PATCH 1/2] media: meye: relax dependencies if COMPILE_TEST

This driver can be built successfuly on non-x86 archs, if we remove SONY_LAPTOP dependency. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/meye/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/meye/Kconfig

Re: [PATCH 17/21] media: ispstat: use %p to print the address of a buffer

Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 17:23:18 EEST Mauro Carvalho Chehab wrote: > Instead of converting to int, use %p. That prevents this > warning: > drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() > warn: > argument 7 to %08lx specifier is cast

[PATCH 06/21] media: davinci_vpfe: vpfe_video: remove an unused var

as warned: drivers/staging/media/davinci_vpfe/vpfe_video.c: In function 'vpfe_streamon': drivers/staging/media/davinci_vpfe/vpfe_video.c:1471:31: warning: variable 'sdinfo' set but not used [-Wunused-but-set-variable] struct vpfe_ext_subdev_info *sdinfo;

[PATCH 19/21] media: fsl-viu: use %p to print pointers

Solve those warnings: drivers/media/platform/fsl-viu.c:299 restart_video_queue() warn: argument 3 to %08lx specifier is cast from pointer drivers/media/platform/fsl-viu.c:506 buffer_queue() warn: argument 2 to %08lx specifier is cast from pointer drivers/media/platform/fsl-viu.c:518

[PATCH 11/21] media: si470x: fix __be16 annotations

The annotations there are wrong as warned: drivers/media/radio/si470x/radio-si470x-i2c.c:107:35: warning: cast to restricted __be16 drivers/media/radio/si470x/radio-si470x-i2c.c:107:35: warning: cast to restricted __be16 drivers/media/radio/si470x/radio-si470x-i2c.c:107:35: warning:

[PATCH 15/21] media: vpbe_display: properly handle error case

if v4l2_subdev_call(..., VENC_GET_FLD,...) fails, it currently returns a random value. Instead, return 1. That's probably better than returning 0, as this is very likely what happens in practice with the current code, as as the probably of an unititialized 32 bits integer to have an specific

[PATCH 08/21] media: davinci_vpfe: fix a typo for "default"

resizer_set_defualt_configuration -> resizer_set_default_configuration Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/21] media: davinci_vpfe: cleanup ipipe_[g|s]_config logic

Reduce one ident level inside those functions and use BIT() macro. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 98 1 file changed, 50 insertions(+), 48 deletions(-) diff --git

[PATCH 01/21] media: davinci_vpfe: remove useless checks from ipipe

The dm365_ipipe_hw.c and dm365_ipipe.c file check if several table pointers, declared at davinci_vpfe_user.h, are filled before using them. The problem is that those pointers come from struct declarations like: struct vpfe_ipipe_yee { ... short

[PATCH 07/21] media: davinci_vpfe: don't use kernel-doc markup for simple comments

Fix those two warnings: drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c:90: warning: Function parameter or member 'interface' not described in 'MODULE_PARM_DESC' drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c:90: warning: Function parameter or member '(default' not described in

[PATCH 1/2] media: platform: fsl-viu: add __iomem annotations

This avoids countless sparse warnings like drivers/media/platform/fsl-viu.c:1081:25: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1082:25: sparse: incorrect type in argument 2 (different address spaces) Signed-off-by: Arnd Bergmann

[PATCH 18/21] media: isppreview: fix __user annotations

That prevent those warnings: drivers/media/platform/omap3isp/isppreview.c:893:45: warning: incorrect type in initializer (different address spaces) drivers/media/platform/omap3isp/isppreview.c:893:45:expected void [noderef] *from drivers/media/platform/omap3isp/isppreview.c:893:45:

[PATCH 05/21] media: davinci_vpfe: get rid of an unused var at dm365_isif.c

Not sure what was the original idea here, but the implementation went into a different way, and the fmt var is not used anymore, as warned: drivers/staging/media/davinci_vpfe/dm365_isif.c: In function '__isif_get_format': drivers/staging/media/davinci_vpfe/dm365_isif.c:1401:29: warning: variable

[PATCH 2/2] media: platform: fsl-viu: mark local functions 'static'

Both sparse and gcc (with 'make V=1') warn about non-static symbols that have not been declared: drivers/media/platform/fsl-viu.c:235:16: warning: symbol 'format_by_fourcc' was not declared. Should it be static? drivers/media/platform/fsl-viu.c:248:6: warning: symbol 'viu_start_dma' was not

Re: [PATCH 1/2] media: platform: fsl-viu: add __iomem annotations

Em Fri, 6 Apr 2018 16:23:18 +0200 Arnd Bergmann escreveu: > This avoids countless sparse warnings like > >drivers/media/platform/fsl-viu.c:1081:25: sparse: incorrect type in > argument 2 (different address spaces) >drivers/media/platform/fsl-viu.c:1082:25: sparse:

[PATCH 17/21] media: ispstat: use %p to print the address of a buffer

Instead of converting to int, use %p. That prevents this warning: drivers/media/platform/omap3isp/ispstat.c:451 isp_stat_bufs_alloc() warn: argument 7 to %08lx specifier is cast from pointer Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 21/21] media: omap_vout: fix wrong identing

As warned: drivers/media/platform/omap/omap_vout.c:711 omap_vout_buffer_setup() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/omap/omap_vout.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-)

[PATCH 13/21] media: davinci: fix an inconsistent ident

drivers/media/platform/davinci/vpbe_osd.c:849 try_layer_config() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/davinci/vpbe_osd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 16/21] media: vpbe_display: get rid of warnings

Solve those warnings: drivers/media/platform/davinci/vpbe_display.c:288 vpbe_start_streaming() warn: inconsistent indenting drivers/media/platform/davinci/vpbe_display.c:1356 register_device() warn: argument 3 to %x specifier is cast from pointer

[PATCH 20/21] media: fsl-viu: fix __iomem annotations

Those annotations are wrong, causing this warning: drivers/media/platform/fsl-viu.c:1440:21: warning: incorrect type in assignment (different address spaces) drivers/media/platform/fsl-viu.c:1440:21:expected struct viu_reg *vr drivers/media/platform/fsl-viu.c:1440:21:got

[PATCH 04/21] media: davinci_vpfe: mark __iomem as such

There are several usages of an __iomem memory that aren't marked as such, causing those warnings: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:76:26: warning: incorrect type in argument 2 (different address spaces) drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:76:26:expected void

[PATCH 00/21] Fix sparse/smatch errors on non-x86 drivers

After applying this patch series: https://www.mail-archive.com/linux-media@vger.kernel.org/msg128829.html Which allows to build all drivers with COMPILE_TEST on x86, my scripts can finally check for errors/warnings on those drivers. This patch series correct those warnings. Mauro Carvalho

[PATCH 10/21] media: davinci_vpfe: fix __user annotations

The __user annotations on this driver are wrong, causing lots of warnings: drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1269:22: warning: incorrect type in assignment (different address spaces) drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1269:22:expected void [noderef]

[PATCH 14/21] media: mmp-driver: add needed __iomem marks to power_regs

Solve those warnings: drivers/media/platform/marvell-ccic/mmp-driver.c:135:41: warning: incorrect type in argument 2 (different address spaces) drivers/media/platform/marvell-ccic/mmp-driver.c:135:41:expected void [noderef] *

[PATCH 12/21] media: isif: reorder a statement to match coding style

On all places, we do: void *foo; Here, it is doing, instead: void * foo; That tricks static analyzers, making it see errors where there's none. So, just reorder in order to cleanup those warnings: drivers/media/platform/davinci/isif.c:1066:22: warning: incorrect type in

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

Em Fri, 6 Apr 2018 16:37:15 +0200 Arnd Bergmann escreveu: > On Fri, Apr 6, 2018 at 4:26 PM, Mauro Carvalho Chehab > wrote: > > Em Fri, 6 Apr 2018 16:16:46 +0200 > > Arnd Bergmann escreveu: > > > >> On Fri, Apr 6, 2018 at 4:15 PM, Mauro

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

Em Fri, 6 Apr 2018 11:51:16 +0200 Arnd Bergmann escreveu: > On Fri, Apr 6, 2018 at 11:47 AM, Mauro Carvalho Chehab > wrote: > > > [PATCH] media: fsl-viu: allow building it with COMPILE_TEST > > > > There aren't many things that would be needed to allow

[PATCH 02/21] media: dm365_ipipe: remove an unused var

drivers/staging/media/davinci_vpfe/dm365_ipipe.c:74:17: warning: variable 'dev' set but not used [-Wunused-but-set-variable] struct device *dev; ^~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 -- 1

[PATCH 03/21] media: davinci_vpfe: fix vpfe_ipipe_init() error handling

As warned: drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init() error: we previously assumed 'res' could be null (see line 1797) There's something wrong at vpfe_ipipe_init(): 1) it caches the resourse_size() from from the first region and reuses to the second

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

On Fri, Apr 6, 2018 at 4:26 PM, Mauro Carvalho Chehab wrote: > Em Fri, 6 Apr 2018 16:16:46 +0200 > Arnd Bergmann escreveu: > >> On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab >> wrote: >> > Em Fri, 6 Apr 2018 11:51:16

Re: [PATCH v2 09/19] media: marvel-ccic: re-enable mmp-driver build

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

uvcvideo stopped working in 4.16

Since the 4.16 kernel my uvcvideo webcam on Thinkpad X1 Carbon (5th gen) stopped working with gst-launch-1.0, kamoso (kde webcam app), Firefox and Chromium on sites like appear.in, talky.io, Google Hangouts and meet.jit.si. It works fine in 4.15 The camera is: Bus 001 Device 004: ID 04f2:b5ce

Re: [PATCH 18/21] media: isppreview: fix __user annotations

Hi Mauro, Thank you for the patch. On Friday, 6 April 2018 17:23:19 EEST Mauro Carvalho Chehab wrote: > That prevent those warnings: >drivers/media/platform/omap3isp/isppreview.c:893:45: warning: incorrect > type in initializer (different address spaces) >

Re: [PATCH] media: coda: do not try to propagate format if capture queue busy

Hi Tomasz, On Tue, 2018-04-03 at 10:13 +, Tomasz Figa wrote: > Hi Philipp, > > On Thu, Mar 29, 2018 at 2:12 AM Philipp Zabel > wrote: > > > The driver helpfully resets the capture queue format and selection > > rectangle whenever output format is changed. This only

Re: [PATCH] media: coda: do not try to propagate format if capture queue busy

Hi Ian, On Fri, 2018-04-06 at 09:40 +0100, Ian Arkver wrote: > > - ret = coda_try_fmt_vid_cap(file, priv, _cap); > > - if (ret) > > - return ret; > > - > > - q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); > > - r.left = 0; > > - r.top = 0; > > - r.width =

Re: [PATCH v2 11/19] media: davinci: allow building isif code

Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 18/21] media: isppreview: fix __user annotations

Em Fri, 06 Apr 2018 18:54:50 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 17:23:19 EEST Mauro Carvalho Chehab wrote: > > That prevent those warnings: > >

Re: [PATCH v2 09/15] v4l: vsp1: Move DRM pipeline output setup code to a function

Hi Laurent, Thanks for the updates On 05/04/18 10:18, Laurent Pinchart wrote: > In order to make the vsp1_du_setup_lif() easier to read, and for > symmetry with the DRM pipeline input setup, move the pipeline output > setup code to a separate function. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 10/15] v4l: vsp1: Turn frame end completion status into a bitfield

Hi Laurent, Thanks for this enhancement. On 05/04/18 10:18, Laurent Pinchart wrote: > We will soon need to return more than a boolean completion status from > the vsp1_dlm_irq_frame_end() IRQ handler. Turn the return value into a > bitfield to prepare for that. No functional change is introduced

Re: [PATCH v2 11/15] v4l: vsp1: Add per-display list internal completion notification support

Hi Laurent, On 05/04/18 10:18, Laurent Pinchart wrote: > Display list completion is already reported to the frame end handler, > but that mechanism is global to all display lists. In order to implement > BRU and BRS reassignment in DRM pipelines we will need to commit a > display list and wait

Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time

Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20180406] [cannot apply to v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 17/21] media: ispstat: use %p to print the address of a buffer

Em Fri, 06 Apr 2018 18:46:05 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 6 April 2018 17:23:18 EEST Mauro Carvalho Chehab wrote: > > Instead of converting to int, use %p. That prevents this > > warning: > >

Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time

Em Sat, 7 Apr 2018 00:21:07 +0800 kbuild test robot <l...@intel.com> escreveu: > Hi Mauro, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on next-20180406] > [cannot apply to v4.16]