Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Mark Brown
On Fri, Apr 20, 2018 at 03:28:26PM +0200, Geert Uytterhoeven wrote: > The first 6 patches can be applied independently by subsystem > maintainers. > The last two patches depend on the first 6 patches, and are thus marked > RFC. Would it not make sense to try to apply everything en masse rather

[PATCH 1/1] media: nec-decoder: remove trailer_space state

2018-04-20 Thread Vladislav Zhurba
From: Daniel Fu Remove STATE_TRAILER_SPACE from state machine. Causing 2 issue: - can not decode the keycode, if it didn't following with another keycode/repeat code - will generate one more code in current logic. i.e. key_right + repeat code + key_left + repeat code.

Re: linux-next: Tree for Apr 20 (media/platform/marvell-ccic/)

2018-04-20 Thread Randy Dunlap
On 04/19/18 23:11, Stephen Rothwell wrote: > Hi all, > > Changes since 20180419: > > I have added a patch to the arm-current tree to fix build problems > discovered overnight. > > Non-merge commits (relative to Linus' tree): 1278 > 1324 files changed, 47025 insertions(+), 20625 deletions(-) >

[PATCH 0/7] Enable most media drivers to build on ARM

2018-04-20 Thread Mauro Carvalho Chehab
Right now, all media drivers build successfully with COMPILE_TEST on x86, on both i386 and x86_64. Yet, several drivers there don't build on other archs. I don't need myself to build all drivers outside x86, but others could find it useful. It also relps spreading COMPILE_TEST builds, with sounds

[PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

2018-04-20 Thread Mauro Carvalho Chehab
Add stubs for omapfb_dss.h, in the case it is included by some driver when CONFIG_FB_OMAP2 is not defined, with can happen on ARM when DRM_OMAP is not 'n'. That allows building such driver(s) with COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH v3 5/7] drm/i2c: tda9950: add CEC driver

2018-04-20 Thread Russell King - ARM Linux
On Fri, Apr 20, 2018 at 05:48:12PM +0200, Hans Verkuil wrote: > On 04/20/2018 05:31 PM, Russell King - ARM Linux wrote: > > Hi Hans, > > > > Any comments? > > I have been traveling and haven't had time to look at this. Next week will > be busy as well, but I expect to be able to look at it the

Re: [PATCH v2 10/10] media: ov772x: avoid accessing registers under power saving mode

2018-04-20 Thread Akinobu Mita
2018-04-18 21:55 GMT+09:00 jacopo mondi : >> @@ -898,8 +922,20 @@ static int ov772x_s_power(struct v4l2_subdev *sd, int >> on) >> /* If the power count is modified from 0 to != 0 or from != 0 to 0, >>* update the power state. >>*/ >> - if

[PATCH 0/1] Add two IR keymaps for NVIDIA devices

2018-04-20 Thread Vladislav Zhurba
Adds two IR keymaps for NVIDIA devices. The RC types are SONY12 and NEC. Jun Yan (1): media: rc: Add NVIDIA IR keymapping drivers/media/rc/keymaps/Makefile| 2 + drivers/media/rc/keymaps/rc-nvidia-nec.c | 66 drivers/media/rc/keymaps/rc-nvidia.c | 66

[PATCH 1/1] media: rc: Add NVIDIA IR keymapping

2018-04-20 Thread Vladislav Zhurba
From: Jun Yan Add keymap with NEC and SONY12 protocol for NVIDIA IR Signed-off-by: Jun Yan Signed-off-by: marting Signed-off-by: Daniel Fu Signed-off-by: Vladislav Zhurba ---

Re: [PATCH v2 02/12] media: ov5640: Add light frequency control

2018-04-20 Thread Maxime Ripard
Hi Laurent, On Thu, Apr 19, 2018 at 12:44:18PM +0300, Laurent Pinchart wrote: > On Monday, 16 April 2018 15:36:51 EEST Maxime Ripard wrote: > > From: Mylène Josserand > > > > Add the light frequency control to be able to set the frequency > > to manual (50Hz or

[PATCH 7/7] media: via-camera: allow build on non-x86 archs with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
This driver depends on FB_VIA for lots of things. Provide stubs for the functions it needs, in order to allow building it with COMPILE_TEST outside x86 architecture. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/Kconfig | 2 +-

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-20 Thread Maxime Ripard
On Fri, Apr 20, 2018 at 04:29:42PM +0200, Daniel Mack wrote: > Hi, > > On Friday, April 20, 2018 04:15 PM, Maxime Ripard wrote: > > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: > > >> struct ov5640_ctrls { > >>struct v4l2_ctrl_handler handler; > >> + struct { > >> +

Re: [PATCH v2 01/12] media: ov5640: Add auto-focus feature

2018-04-20 Thread Maxime Ripard
On Thu, Apr 19, 2018 at 01:36:39PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Monday, 16 April 2018 15:36:50 EEST Maxime Ripard wrote: > > From: Mylène Josserand > > > > Add the auto-focus ENABLE/DISABLE feature as V4L2

Re: [PATCH v3 06/13] media: platform: video-mux: Register a subdev notifier

2018-04-20 Thread Steve Longerbeam
Hi Hans, On 04/20/2018 05:28 AM, Hans Verkuil wrote: On 03/21/18 01:37, Steve Longerbeam wrote: Parse neighbor remote devices on the video muxes input ports, add them to a subdev notifier, and register the subdev notifier for the video mux, by calling v4l2_async_register_fwnode_subdev().

[PATCH v2 7/7] media: via-camera: allow build on non-x86 archs with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
This driver depends on FB_VIA for lots of things. Provide stubs for the functions it needs, in order to allow building it with COMPILE_TEST outside x86 architecture. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/Kconfig

Re: [PATCH] media: s5p-jpeg: don't return a value on a void function

2018-04-20 Thread Jacek Anaszewski
Hi Mauro, Thank you for the patch. On 04/20/2018 09:01 PM, Mauro Carvalho Chehab wrote: > Building this driver on arm64 gives this warning: > drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:430:16: error: > return expression in void function > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v3 5/7] drm/i2c: tda9950: add CEC driver

2018-04-20 Thread Hans Verkuil
On 04/20/2018 05:31 PM, Russell King - ARM Linux wrote: > Hi Hans, > > Any comments? I have been traveling and haven't had time to look at this. Next week will be busy as well, but I expect to be able to look at it the week after that. I remember from the previous series that I couldn't test it

Re: [PATCH v3 02/13] media: v4l2: async: Allow searching for asd of any type

2018-04-20 Thread Steve Longerbeam
Hi Hans, On 04/20/2018 05:22 AM, Hans Verkuil wrote: On 03/21/18 01:37, Steve Longerbeam wrote: Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow searching for any type of async subdev, not just fwnodes. Rename to v4l2_async_notifier_has_async_subdev() and pass it an asd

[PATCH 3/7] media: rc: allow build pnp-dependent drivers with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
The pnp header already provide enough stub to build those drivers with COMPILE_TEST on non-x86 archs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 6/7] media: omap2: allow building it with COMPILE_TEST && DRM_OMAP

2018-04-20 Thread Mauro Carvalho Chehab
Now that FB_OMAP has stubs, the omap2 media drivers can be built on ARM with COMPILE_TEST && DRM_OMAP. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/omap/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/7] media: meye: allow building it with COMPILE_TEST on non-x86

2018-04-20 Thread Mauro Carvalho Chehab
This driver depends on sony-laptop driver, but this is available only for x86. So, add a stub function, in order to allow building it on non-x86 too. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/meye/Kconfig | 3 ++- include/linux/sony-laptop.h| 4

[PATCH 4/7] media: ipu3: allow building it with COMPILE_TEST on non-x86 archs

2018-04-20 Thread Mauro Carvalho Chehab
Despite depending on ACPI, this driver builds fine on non-x86 archtecture with COMPILE_TEST, as it doesn't depend on ACPI-specific functions/structs. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/intel/ipu3/Kconfig | 3 +-- 1 file changed, 1 insertion(+),

[PATCH] media: s5p-jpeg: don't return a value on a void function

2018-04-20 Thread Mauro Carvalho Chehab
Building this driver on arm64 gives this warning: drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:430:16: error: return expression in void function Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c | 4 ++-- 1

Re: [PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-04-20 Thread Steve Longerbeam
Hi Sakari, On 04/20/2018 05:24 AM, Sakari Ailus wrote: Hi Steve, Thanks for the patchset. On Tue, Mar 20, 2018 at 05:37:19PM -0700, Steve Longerbeam wrote: v4l2_async_notifier_add_subdev() adds an asd to the notifier. It checks that the asd's match_type is valid and that no other equivalent

[PATCH 1/7] asm-generic, media: allow COMPILE_TEST with virt_to_bus

2018-04-20 Thread Mauro Carvalho Chehab
The virt_to_bus/bus_to_virt macros are arch-specific. Some archs don't support it. Yet, as it is interesting to allow doing compilation tests on non-ia32/ia64 archs, provide a fallback for such archs. While here, enable COMPILE_TEST for two media drivers that depends on it. Signed-off-by: Mauro

Re: Representative Needed.

2018-04-20 Thread PPMC OFFSHORE
Good day, I am seeking your concept with great gratitude to present you as a representative to carry out business transactions with a reasonable share upon your interest and cooperation to work with us in trust. If interested please get back. Regards Kingsley --- This email has been

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-04-20 Thread Robert Jarzmik
Wolfram Sang writes: > This header only contains platform_data. Move it to the proper directory. > > Signed-off-by: Wolfram Sang For mach-pxa: Acked-by: Robert Jarzmik Take it through your tree, no problem for the pxa part.

Re: cx88 invalid video opcodes when VBI enabled

2018-04-20 Thread Daniel Glöckner
Hi, On Wed, Apr 18, 2018 at 08:29:59PM +0200, Daniel Glöckner wrote: > The VBI instruction queue read pointer points outside the VBI instruction > queue and into the video y/packed CMDS (to 0x18+0x11*4). The values > next to the iq rd ptr look ok. > > We only initialize the iq rd ptr to zero

cron job: media_tree daily build: ERRORS

2018-04-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Apr 21 05:00:22 CEST 2018 media-tree git hash:1d338b86e17d87215cf57b1ad1d13b2afe582d33 media_build

Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST

2018-04-20 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 05, 2018 04:29:42 PM Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-20 Thread Sergei Shtylyov
On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy > CONFIG_ARCH_SHMOBILE, hence use the former. > > Renesas SuperH SH-Mobile SoCs are still covered

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Daniel Vetter
On Fri, Apr 20, 2018 at 05:46:25AM -0700, Christoph Hellwig wrote: > On Fri, Apr 20, 2018 at 12:44:01PM +0200, Christian König wrote: > > > > What we need is an sg_alloc_table_from_resources(dev, resources, > > > > num_resources) which does the handling common to all drivers. > > > A structure

Re: [PATCH v3 5/7] drm/i2c: tda9950: add CEC driver

2018-04-20 Thread Russell King - ARM Linux
Hi Hans, Any comments? Thanks. On Mon, Apr 09, 2018 at 01:16:32PM +0100, Russell King wrote: > Add a CEC driver for the TDA9950, which is a stand-alone I2C CEC device, > but is also integrated into HDMI transceivers such as the TDA9989 and > TDA19989. > > The TDA9950 contains a command

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Christian König
Am 20.04.2018 um 09:13 schrieb Daniel Vetter: On Thu, Apr 19, 2018 at 01:16:57AM -0700, Christoph Hellwig wrote: On Mon, Apr 16, 2018 at 03:38:56PM +0200, Daniel Vetter wrote: We've broken that assumption in i915 years ago. Not struct page backed gpu memory is very real. Of course we'll never

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Daniel Vetter
On Thu, Apr 19, 2018 at 01:16:57AM -0700, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 03:38:56PM +0200, Daniel Vetter wrote: > > We've broken that assumption in i915 years ago. Not struct page backed > > gpu memory is very real. > > > > Of course we'll never feed such a strange sg table to

[GIT PULL v2 FOR v4.18] rc changes

2018-04-20 Thread Sean Young
Hi Mauro, These patches include the low latency changes, which do make IR more responsive. These patches could breaks things in subtle ways, so it would be great to have these changes in early in the cycle. Thanks, Sean The following changes since commit

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-04-20 Thread Lee Jones
On Thu, 19 Apr 2018, Wolfram Sang wrote: > This header only contains platform_data. Move it to the proper directory. > > Signed-off-by: Wolfram Sang > --- > MAINTAINERS | 2 +- > arch/arm/mach-ks8695/board-acs5k.c | 2 +- >

[PATCH] cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN

2018-04-20 Thread Hans Verkuil
This driver needs a pull up output GPIO, but devm_gpiod_get() is called with GPIOD_IN. This apparently works fine for the RPi3 where the DT correctly specifies a pull up GPIO, but on the i.MX6 it also needs to be specified with devm_gpiod_get(). Signed-off-by: Hans Verkuil

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-20 Thread Paul Kocialkowski
Hi and thanks for the review, On Fri, 2018-04-20 at 01:31 +, Tomasz Figa wrote: > Hi Paul, Philipp, > > On Fri, Apr 20, 2018 at 1:04 AM Philipp Zabel > wrote: > > > Hi Paul, > > On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote: > > > This adds a

Re: [PATCH v2 01/10] media: v4l2-ctrls: Add missing v4l2 ctrl unlock

2018-04-20 Thread Maxime Ripard
On Thu, Apr 19, 2018 at 05:41:15PM +0200, Paul Kocialkowski wrote: > This adds a missing v4l2_ctrl_unlock call that is required to avoid > deadlocks. Maybe you can explain what the deadlock scenario is? > Signed-off-by: Paul Kocialkowski > --- >

Re: [PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-04-20 Thread Alexandre Courbot
On Fri, Apr 20, 2018 at 12:43 AM Paul Kocialkowski < paul.kocialkow...@bootlin.com> wrote: > When using the request API in the context of a m2m driver, the > operations that come with a m2m run scheduling call in their > (m2m-specific) ioctl handler are delayed until the request is queued > (for

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-04-20 Thread Maxime Ripard
On Thu, Apr 19, 2018 at 05:45:35PM +0200, Paul Kocialkowski wrote: > This adds nodes for the Video Engine and the associated reserved memory > for the Allwinner A20. Up to 96 MiB of memory are dedicated to the VPU. > > The VPU can only map the first 256 MiB of DRAM, so the reserved memory > pool

[GIT FIXES FOR v4.17] New board, two fixes

2018-04-20 Thread Hans Verkuil
Hi Mauro, Three patches for 4.17: two are fixes, one add a new cx231xx board. Regards, Hans The following changes since commit 42a182282ea2426d56b2d63be634ee419194c45c: media: si470x: fix a typo at the Makefile causing build issues (2018-04-18 15:21:41 -0400) are available in the

[PATCH 1/3] media: ov5640: initialize mode data structs by name

2018-04-20 Thread Daniel Mack
This patch initializes the members of struct ov5640_mode_info by name for better readability. This makes later additions to this struct easier. No functional change intended. Signed-off-by: Daniel Mack --- drivers/media/i2c/ov5640.c | 207

[PATCH] media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()

2018-04-20 Thread Dan Carpenter
Smatch complains that "venc" could be unintialized. There a couple error paths where it looks like maybe that could happen. I don't know if it's really a bug, but it's reasonable to set "venc" to NULL and silence the warning. Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Christoph Hellwig
On Fri, Apr 20, 2018 at 10:58:50AM +0200, Christian König wrote: > > Yes there's a bit a layering violation insofar that drivers really > > shouldn't each have their own copy of "how do I convert a piece of dma > > memory into dma-buf", but that doesn't render the interface a bad idea. > >

Re: [PATCH v3 06/13] media: platform: video-mux: Register a subdev notifier

2018-04-20 Thread Hans Verkuil
On 03/21/18 01:37, Steve Longerbeam wrote: > Parse neighbor remote devices on the video muxes input ports, add them to a > subdev notifier, and register the subdev notifier for the video mux, by > calling v4l2_async_register_fwnode_subdev(). > > Signed-off-by: Steve Longerbeam

[PATCH] media: davinci_vpfe: fix some potential overflows

2018-04-20 Thread Dan Carpenter
We check "lutdpc->dpc_size" in ipipe_validate_lutdpc_params() but if it's invalid then we would have corrupted memory already when we do the memcpy() before calling it. We don't ever check "gamma->tbl_size" but we should since they come from the user. Signed-off-by: Dan Carpenter

Re: [PATCH v2 3/4] media: v4l2-compat-ioctl32: simplify casts

2018-04-20 Thread Hans Verkuil
On 04/19/18 18:33, Mauro Carvalho Chehab wrote: > Making the cast right for get_user/put_user is not trivial, as > it needs to ensure that the types are the correct ones. > > Improve it by using macros. > > Tested with vivid with: > $ sudo modprobe vivid no_error_inj=1 > $

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

2018-04-20 Thread Hans Verkuil
Hi Mauro, A bunch of typo, grammar and style fixes below. Looks good otherwise. On 04/19/18 18:33, Mauro Carvalho Chehab wrote: > This file does a lot of non-trivial struff. Document it using > kernel-doc markups where needed and improve the comments inside > do_video_ioctl(). > >

[PATCH v2] media: v4l2-compat-ioctl32: better document the code

2018-04-20 Thread Mauro Carvalho Chehab
This file does a lot of non-trivial struff. Document it using kernel-doc markups where needed and improve the comments inside do_video_ioctl(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 165 +- 1

Re: [PATCH v3 02/13] media: v4l2: async: Allow searching for asd of any type

2018-04-20 Thread Hans Verkuil
On 03/21/18 01:37, Steve Longerbeam wrote: > Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow > searching for any type of async subdev, not just fwnodes. Rename to > v4l2_async_notifier_has_async_subdev() and pass it an asd pointer. > > TODO: support asd compare with CUSTOM match

Re: [PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-04-20 Thread Sakari Ailus
Hi Steve, Thanks for the patchset. On Tue, Mar 20, 2018 at 05:37:19PM -0700, Steve Longerbeam wrote: > v4l2_async_notifier_add_subdev() adds an asd to the notifier. It checks > that the asd's match_type is valid and that no other equivalent asd's > have already been added to this notifier's asd

[PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
All sound drivers that don't depend on PNP can be safelly build with COMPILE_TEST, as ISA provides function stubs to be used for such purposes. As a side effect, with this change, the radio-miropcm20 can now be built outside i386 with COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab

[PATCH 4/4] media: siano: get rid of __le32/__le16 cast warnings

2018-04-20 Thread Mauro Carvalho Chehab
Those are all false-positives that appear with smatch when building for arm: drivers/media/common/siano/smsendian.c:38:36: warning: cast to restricted __le32 drivers/media/common/siano/smsendian.c:38:36: warning: cast to restricted __le32 drivers/media/common/siano/smsendian.c:38:36:

[PATCH 0/4] More COMPILE_TEST patches to build all media drivers on x86_64

2018-04-20 Thread Mauro Carvalho Chehab
While now all media drivers build with COMPILE_TEST on i386, there are still a few of them that don't build on x86_64. Making them compiling there is just a matter of touching Kconfig files. While here, fix smatch warnings when building the siano driver on big endian architectures. Mauro

[PATCH 2/4] media: sta2x11_vip: allow build with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
This driver doesn't use any weird API. So, allow building it with COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/sta2x11/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/sta2x11/Kconfig

[PATCH 1/4] media: radio: allow building ISA drivers with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
Several radio devices only build on i386, because they depend on ISA. Allow them to build on other archs by adding a COMPILE_TEST check. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/radio/Kconfig | 38 -- 1 file changed, 24

[PATCH 3/3] media: ov5640: add support for xclk frequency control

2018-04-20 Thread Daniel Mack
Allow setting the xclk rate via an optional 'clock-frequency' property in the device tree node. Signed-off-by: Daniel Mack --- Documentation/devicetree/bindings/media/i2c/ov5640.txt | 2 ++ drivers/media/i2c/ov5640.c | 10 ++ 2 files

[PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-20 Thread Daniel Mack
Add v4l2 controls to report the pixel and MIPI link rates of each mode. The camss camera subsystem needs them to set up the correct hardware clocks. Tested on msm8016 based hardware. Signed-off-by: Daniel Mack --- drivers/media/i2c/ov5640.c | 77

Re: [PATCH v2 1/4] media: v4l2-compat-ioctl32: fix several __user annotations

2018-04-20 Thread Hans Verkuil
On 04/19/18 18:33, Mauro Carvalho Chehab wrote: > Smatch report several issues with bad __user annotations: > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect > type in argument 1 (different address spaces) > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21:

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

2018-04-20 Thread Mauro Carvalho Chehab
Em Fri, 20 Apr 2018 13:16:00 +0200 Hans Verkuil escreveu: Thanks for the review! > > +/** > > + * do_video_ioctl() - Ancillary function with handles a compat32 ioctl call > > + * > > + * @file: pointer to file with the file handler > > + * @cmd: ioctl to be called > > + *

Re: [PATCH v2] media: v4l2-compat-ioctl32: better document the code

2018-04-20 Thread Hans Verkuil
On 04/20/18 13:45, Mauro Carvalho Chehab wrote: > This file does a lot of non-trivial struff. Document it using > kernel-doc markups where needed and improve the comments inside > do_video_ioctl(). > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Hans Verkuil

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-20 Thread Tomasz Figa
Hi Paul, On Fri, Apr 20, 2018 at 12:46 AM Paul Kocialkowski < paul.kocialkow...@bootlin.com> wrote: [snip] > +struct v4l2_ctrl_mpeg2_frame_hdr { > + __u32 slice_len; > + __u32 slice_pos; > + enum { MPEG1, MPEG2 } type; Is enum suitable for UAPI? > + > + __u16 width; > +

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Christian König
Am 20.04.2018 um 12:17 schrieb Christoph Hellwig: On Fri, Apr 20, 2018 at 10:58:50AM +0200, Christian König wrote: Yes there's a bit a layering violation insofar that drivers really shouldn't each have their own copy of "how do I convert a piece of dma memory into dma-buf", but that doesn't

Re: [PATCH v3 01/13] media: v4l2-fwnode: ignore endpoints that have no remote port parent

2018-04-20 Thread Hans Verkuil
On 03/21/18 01:37, Steve Longerbeam wrote: > Documentation/devicetree/bindings/media/video-interfaces.txt states that > the 'remote-endpoint' property is optional. > > So v4l2_async_notifier_fwnode_parse_endpoint() should not return error > if the endpoint has no remote port parent. Just ignore

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

2018-04-20 Thread Hans Verkuil
On 04/20/18 13:44, Mauro Carvalho Chehab wrote: > Em Fri, 20 Apr 2018 13:16:00 +0200 > Hans Verkuil escreveu: > > Thanks for the review! > >>> +/** >>> + * do_video_ioctl() - Ancillary function with handles a compat32 ioctl call >>> + * >>> + * @file: pointer to file with

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Takashi Iwai
On Fri, 20 Apr 2018 14:32:15 +0200, Mauro Carvalho Chehab wrote: > > All sound drivers that don't depend on PNP can be safelly > build with COMPILE_TEST, as ISA provides function stubs to > be used for such purposes. > > As a side effect, with this change, the radio-miropcm20 > can now be built

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
Em Fri, 20 Apr 2018 14:37:46 +0200 Takashi Iwai escreveu: > On Fri, 20 Apr 2018 14:32:15 +0200, > Mauro Carvalho Chehab wrote: > > > > All sound drivers that don't depend on PNP can be safelly > > build with COMPILE_TEST, as ISA provides function stubs to > > be used for such

Re: [PATCH] sound, isapnp: allow building more drivers with COMPILE_TEST

2018-04-20 Thread Takashi Iwai
On Fri, 20 Apr 2018 14:58:55 +0200, Mauro Carvalho Chehab wrote: > > Drivers that depend on ISAPNP currently can't be built with > COMPILE_TEST. However, looking at isapnp.h, there are already > stubs there to allow drivers to include it even when isa > PNP is not supported. > > So, remove such

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Takashi Iwai
On Fri, 20 Apr 2018 15:01:22 +0200, Mauro Carvalho Chehab wrote: > > Em Fri, 20 Apr 2018 09:51:29 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Fri, 20 Apr 2018 14:37:46 +0200 > > Takashi Iwai escreveu: > > > > > On Fri, 20 Apr 2018 14:32:15 +0200,

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
Em Fri, 20 Apr 2018 14:58:15 +0200 Takashi Iwai escreveu: > On Fri, 20 Apr 2018 14:51:29 +0200, > Mauro Carvalho Chehab wrote: > > > > Em Fri, 20 Apr 2018 14:37:46 +0200 > > Takashi Iwai escreveu: > > > > > On Fri, 20 Apr 2018 14:32:15 +0200, > > > Mauro

Re: [PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

2018-04-20 Thread Hans Verkuil
On 04/13/18 08:59, Kai Heng Feng wrote: > Hi, > >> On Mar 26, 2018, at 2:06 PM, Kai-Heng Feng >> wrote: >> >> User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. >> Add the device to the id_table to make it work. > > *Gentle ping* > I am hoping

[PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy CONFIG_ARCH_SHMOBILE, hence use the former. Renesas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 check, just like before support for

[PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy CONFIG_ARCH_SHMOBILE, hence use the former. Renesas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 check. This will allow to drop

[PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency than the legacy ARCH_SHMOBILE, hence use the former. This will allow to drop ARCH_SHMOBILE on ARM in the near future. Signed-off-by: Geert Uytterhoeven

Re: [PATCH v2 01/10] media: v4l2-ctrls: Add missing v4l2 ctrl unlock

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > This adds a missing v4l2_ctrl_unlock call that is required to avoid > deadlocks. > > Signed-off-by: Paul Kocialkowski > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [PATCH v2 03/10] videobuf2-core: Add helper to get buffer private data from media request

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > When calling media operation driver callbacks related to media requests, > only a pointer to the request itself is provided, which is insufficient > to retrieve the driver's context. Since the driver context is usually > set as vb2 queue private data

Re: [PATCH v2 06/10] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > This introduces support for Allwinner's MB32-tiled NV12 format, where > each plane is divided into macroblocks of 32x32 pixels. Hence, the size > of each plane has to be aligned to 32 bytes. The pixels inside each > macroblock are coded as they would

Re: [PATCH 3/3] media: ov5640: add support for xclk frequency control

2018-04-20 Thread Maxime Ripard
Hi, On Fri, Apr 20, 2018 at 11:44:19AM +0200, Daniel Mack wrote: > Allow setting the xclk rate via an optional 'clock-frequency' property in > the device tree node. > > Signed-off-by: Daniel Mack > --- > Documentation/devicetree/bindings/media/i2c/ov5640.txt | 2 ++ >

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Takashi Iwai
On Fri, 20 Apr 2018 14:51:29 +0200, Mauro Carvalho Chehab wrote: > > Em Fri, 20 Apr 2018 14:37:46 +0200 > Takashi Iwai escreveu: > > > On Fri, 20 Apr 2018 14:32:15 +0200, > > Mauro Carvalho Chehab wrote: > > > > > > All sound drivers that don't depend on PNP can be safelly > > >

[PATCH] sound, isapnp: allow building more drivers with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
Drivers that depend on ISAPNP currently can't be built with COMPILE_TEST. However, looking at isapnp.h, there are already stubs there to allow drivers to include it even when isa PNP is not supported. So, remove such dependencies when COMPILE_TEST. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 3/4] sound, media: allow building ISA drivers it with COMPILE_TEST

2018-04-20 Thread Mauro Carvalho Chehab
Em Fri, 20 Apr 2018 09:51:29 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 20 Apr 2018 14:37:46 +0200 > Takashi Iwai escreveu: > > > On Fri, 20 Apr 2018 14:32:15 +0200, > > Mauro Carvalho Chehab wrote: > > > > > > All sound drivers that don't

Re: [PATCH v7 2/2] uvcvideo: handle control pipe protocol STALLs

2018-04-20 Thread Guennadi Liakhovetski
Hi Laurent, I've addressed those your comments, that I had no questions for, but I'm waiting for your replies to my clarification requests to finalise and post the next revision of the patches. Thanks Guennadi On Wed, 11 Apr 2018, Guennadi Liakhovetski wrote: > Hi Laurent, > > First just

[PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
Emma Mobile is a Renesas ARM SoC. Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency than the legacy ARCH_SHMOBILE, hence use the former. This will allow to drop ARCH_SHMOBILE on ARM in the near future. Signed-off-by:

[PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
The Renesas Fine Display Processor driver is used on Renesas R-Car SoCs only. Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency than the legacy ARCH_SHMOBILE, hence use the former. This will allow to drop ARCH_SHMOBILE

[PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-20 Thread Geert Uytterhoeven
Change the menu title to refer to "Renesas SoCs" instead of "SuperH", as both SuperH and ARM SoCs are supported. Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") is ARCH_RENESAS a more appropriate platform dependency for Renesas ARM SoCs than the legacy ARCH_SHMOBILE, hence

Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Arnd Bergmann
On Fri, Apr 20, 2018 at 3:28 PM, Geert Uytterhoeven wrote: > Hi all, > > Commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > started the conversion from ARCH_SHMOBILE to ARCH_RENESAS for Renesas > ARM SoCs. This patch series completes the

Re: [PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:41, Paul Kocialkowski wrote: > When using the request API in the context of a m2m driver, the > operations that come with a m2m run scheduling call in their > (m2m-specific) ioctl handler are delayed until the request is queued > (for instance, this includes queuing buffers and

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with MPEG2 slice data, as well as a

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-20 Thread Christoph Hellwig
On Fri, Apr 20, 2018 at 12:44:01PM +0200, Christian König wrote: > > > What we need is an sg_alloc_table_from_resources(dev, resources, > > > num_resources) which does the handling common to all drivers. > > A structure that contains > > > > {page,offset,len} + {dma_addr+dma_len} > > > > is not

Re: [PATCH v8 2/2] media: video-i2c: add video-i2c driver

2018-04-20 Thread Hans Verkuil
On 04/18/18 12:30, Sakari Ailus wrote: > On Wed, Apr 18, 2018 at 01:46:08AM -0700, Matt Ranostay wrote: > > ... > >> On Wed, Apr 18, 2018 at 1:03 AM, Sakari Ailus wrote: + if (vid_cap_buf) { + struct vb2_buffer *vb2_buf =

[GIT PULL FOR v4.18] tegra-vde, video-i2c and usbtv patches

2018-04-20 Thread Hans Verkuil
The following changes since commit 1d338b86e17d87215cf57b1ad1d13b2afe582d33: media: v4l2-compat-ioctl32: better document the code (2018-04-20 08:24:13 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.18a for you to fetch changes up to

[PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-20 Thread Geert Uytterhoeven
All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS platform dependencies. Hence finish the conversion from ARCH_SHMOBILE to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS"). Signed-off-by: Geert Uytterhoeven

[PATCH/RFC 8/8] arm64: renesas: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-20 Thread Geert Uytterhoeven
The Kconfig symbol for Renesas 64-bit ARM SoCs has always been ARCH_RENESAS, with ARCH_SHMOBILE being selected to reuse drivers shared with Renesas 32-bit ARM and/or Renesas SuperH SH-Mobile SoCs. Commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") started the conversion from

[PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Geert Uytterhoeven
Hi all, Commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") started the conversion from ARCH_SHMOBILE to ARCH_RENESAS for Renesas ARM SoCs. This patch series completes the conversion, by: 1. Updating dependencies for drivers that weren't converted yet, 2. Removing the

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-04-20 Thread Hans Verkuil
On 04/19/18 17:45, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with MPEG2 slice data, as well as a

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-20 Thread Maxime Ripard
Hi, On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: > Add v4l2 controls to report the pixel and MIPI link rates of each mode. > The camss camera subsystem needs them to set up the correct hardware > clocks. > > Tested on msm8016 based hardware. > > Signed-off-by: Daniel Mack

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Sergei Shtylyov
On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is ARCH_RENESAS a more appropriate platform dependency than the legacy "ARCH_RENESAS is", no? > ARCH_SHMOBILE, hence use the former. > > This will allow to drop

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-20 Thread Daniel Mack
Hi, On Friday, April 20, 2018 04:15 PM, Maxime Ripard wrote: > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: >> struct ov5640_ctrls { >> struct v4l2_ctrl_handler handler; >> +struct { >> +struct v4l2_ctrl *link_freq; >> +struct v4l2_ctrl

  1   2   >