[linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display'

2018-05-04 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 53dcd70eb710607b2d4085ca91a433cd9feb7b41 commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/207] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP config: openrisc-allmodconfig (attached as .config) compiler:

4.17-rc3 regression in UVC driver

2018-05-04 Thread Sebastian Reichel
Hi, I just got the following error message every ms with 4.17-rc3 after upgrading to for first ~192 seconds after system start (Debian 4.17~rc3-1~exp1 kernel) on my Thinkpad X250: > uvcvideo: Failed to query (GET_MIN) UVC control 2 on unit 1: -32 (exp. 1). I see /dev/video0 and /dev/video1. The

[linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:44: sparse: call with no type!

2018-05-04 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 53dcd70eb710607b2d4085ca91a433cd9feb7b41 commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/207] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP reproduce: # apt-get install sparse git

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Maxime Ripard
On Fri, May 04, 2018 at 03:57:48PM +0200, Paul Kocialkowski wrote: > On Fri, 2018-05-04 at 15:40 +0200, Maxime Ripard wrote: > > On Fri, May 04, 2018 at 02:04:38PM +0200, Paul Kocialkowski wrote: > > > On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > > > > On Fri, May 04, 2018 at

Re: [PATCH v3 1/3] [media] dvb_frontend: add S2X and misc. other enums

2018-05-04 Thread Mauro Carvalho Chehab
Em Tue, 13 Mar 2018 23:18:03 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Additional enums: > * FEC ratios 1/4 and 1/3 > * 64/128/256-APSK modulations (DVB-S2X) > * 15%, 10% and 5% rolloff factors (DVB-S2X) > * 64K transmission

Re: [v3] [media] Use common error handling code in 19 functions

2018-05-04 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 18:08:59 +0200 SF Markus Elfring escreveu: > > Adjust jump targets so that a bit of exception handling can be better > > reused at the end of these functions. > > Why was this update suggestion rejected once more a moment ago? > >

[PATCH] media: pt3: no need to check if null for dvb_module_release()

2018-05-04 Thread Mauro Carvalho Chehab
Such check is already there at the routine. So, no need to repeat it outside. Cc: Akihiro Tsukada Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/pt3/pt3.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v4 12/14] media: ov772x: avoid accessing registers under power saving mode

2018-05-04 Thread jacopo mondi
Hi Akinobu, On Fri, May 04, 2018 at 11:50:39PM +0900, Akinobu Mita wrote: > 2018-05-04 6:03 GMT+09:00 jacopo mondi : > > Hi Akinobu, > > let me see if I got this right... > > > > On Mon, Apr 30, 2018 at 02:13:11AM +0900, Akinobu Mita wrote: > >> The set_fmt() in subdev pad

Re: [v3] [media] Use common error handling code in 19 functions

2018-05-04 Thread SF Markus Elfring
> Adjust jump targets so that a bit of exception handling can be better > reused at the end of these functions. Why was this update suggestion rejected once more a moment ago? https://patchwork.linuxtv.org/patch/47827/

[PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces

2018-05-04 Thread Ezequiel Garcia
The sync_debug.h header is internal, and only used by sw_sync.c. Therefore, SW_SYNC is always defined and there is no need for the stubs. Remove them and make the code simpler. Signed-off-by: Ezequiel Garcia --- drivers/dma-buf/sync_debug.h | 10 -- 1 file

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-04 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 16:37:23 +0200 Geert Uytterhoeven escreveu: > Hi Mauro, > > On Fri, May 4, 2018 at 2:13 PM, Mauro Carvalho Chehab > wrote: > > With the new vsp1 code changes introduced by changeset > > f81f9adc4ee1 ("media: v4l: vsp1: Assign

Re: [PATCH v4 10/14] media: ov772x: reconstruct s_frame_interval()

2018-05-04 Thread Akinobu Mita
2018-05-04 5:29 GMT+09:00 jacopo mondi : > Hi Akinobu, >thank you for the patch > > On Mon, Apr 30, 2018 at 02:13:09AM +0900, Akinobu Mita wrote: >> This splits the s_frame_interval() in subdev video ops into selecting the >> frame interval and setting up the registers. >>

Re: [PATCH v2] saa7164: Fix driver name in debug output

2018-05-04 Thread kbuild test robot
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

[PATCH] media: lgdt330x: don't use an uninitialized state

2018-05-04 Thread Mauro Carvalho Chehab
If state is not initialized or is freed, we can't use it: drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: potential null dereference 'state'. (kzalloc returns null) drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: we previously assumed

Re: [PATCH] media: i2c: adv748x: Fix pixel rate values

2018-05-04 Thread Niklas Söderlund
Hi Laurent, On 2018-04-25 01:36:42 +0200, Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your patch. > > On 2018-04-21 15:44:44 +0300, Laurent Pinchart wrote: > > The pixel rate, as reported by the V4L2_CID_PIXEL_RATE control, must > > include both horizontal and vertical blanking. Both

Applied "media: i2c: tda1997: replace codec to component" to the asoc tree

2018-05-04 Thread Mark Brown
The patch media: i2c: tda1997: replace codec to component has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent

Re: [PATCH v2 9/9] cx231xx: Add I2C_MUX dependency

2018-05-04 Thread kbuild test robot
Hi Brad, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

cron job: media_tree daily build: ERRORS

2018-05-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 5 05:00:13 CEST 2018 media-tree git hash:baa057e29b5824b3727e2eb643e513ba5e35aea0 media_build

[PATCH v9 15/15] v4l: Document explicit synchronization behavior

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it v8: amend querybuf documentation. v7: minor issues and English improvements (Hans Verkuil) v6: Close some gaps in the docs (Hans) v5: - Remove V4L2_CAP_ORDERED - Add doc about

[PATCH v9 14/15] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers that use videobuf2 are capable of using fences and should report that to userspace. v9: Add in the core. Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia ---

[PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send its fd to userspace in the fence_fd field as a return arg for the QBUF call. The fence is signaled on buffer_done(), when the job on the buffer is

[PATCH v9 00/15] V4L2 Explicit Synchronization

2018-05-04 Thread Ezequiel Garcia
Hi all, Gustavo has asked to me to take care of the final issues with this series. I'm working on adding some fences tests to v4l2-compliance, which I'll be posting shortly. So, here's a new version of the "video4linux meet fences" series. This new round hopefully addresses all the feedback

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Sam Bobrowicz
> Hi, > > On 3 May 2018 at 17:16, Maxime Ripard wrote: > > Hi, > > > > On Wed, May 02, 2018 at 11:11:55AM -0700, Sam Bobrowicz wrote: > >> > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: > >> >> FYI, still hard at work on this. Did some more experiments

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-05-04 Thread Mauro Carvalho Chehab
Em Sun, 22 Apr 2018 13:06:12 +0200 Hans Verkuil escreveu: > On 04/02/2018 04:26 PM, Robert Jarzmik wrote: > > From: Robert Jarzmik > > > > As the pxa architecture switched towards the dmaengine slave map, the > > old compatibility mechanism to

Re: [PATCH 1/1] v4l: Add macros for printing V4L 4cc values

2018-05-04 Thread Mauro Carvalho Chehab
Em Wed, 4 Apr 2018 16:02:10 +0300 Sakari Ailus escreveu: > Add two macros that facilitate printing V4L fourcc values with printf > family of functions. v4l2_fourcc_conv provides the printf conversion > specifier for printing formats and v4l2_fourcc_to_conv provides

[PATCH v9 06/15] v4l: add unordered flag to format description ioctl

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan For explicit synchronization it important for userspace to know if the format being used by the driver can deliver the buffers back to userspace in the same order they were queued with QBUF. Ordered streams fits nicely in a pipeline with DRM

[PATCH v9 08/15] cobalt: set queue as unordered

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan The cobalt driver may reorder the capture buffers so we need to report it as such. v3: set unordered as a property v2: use vb2_ops_set_unordered() helper Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Sam Bobrowicz
> Hi, > >> Good news, MIPI is now working on my platform. I had to make several >> changes to how the mipi clocking is calculated in order to get things >> stable, but I think I got it figured out. Maxime's changes were really >> helpful. > > Great, I also try to make it work with MIPI-CSI2, If

Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

2018-05-04 Thread Mauro Carvalho Chehab
Em Mon, 23 Apr 2018 13:59:32 -0700 Tim Harvey escreveu: > On Mon, Apr 23, 2018 at 9:52 AM, Mark Brown wrote: > > On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote: > > > >> Could you add some detail to the commit explaining why we need to >

[PATCH v9 03/15] omap3isp: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps earlier with this value. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v9 05/15] vb2: add unordered vb2_queue property for drivers

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Explicit synchronization benefits a lot from ordered queues, they fit better in a pipeline with DRM for example so create a opt-in way for drivers notify videobuf2 that the queue is unordered. v5: go back to a bitfield property for the

[PATCH v9 02/15] hackrf: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE everywhere, set device_caps earlier with these values. Signed-off-by: Gustavo Padovan --- drivers/media/usb/hackrf/hackrf.c | 11 --- 1 file

[PATCH v9 09/15] vb2: mark codec drivers as unordered

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan In preparation to have full support to explicit fence we are marking codec as non-ordered preventively. It is easier and safer from an uAPI point of view to move from unordered to ordered than the opposite. v3: set property instead of

[PATCH v9 01/15] xilinx: regroup caps on querycap

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan To better organize the code we concentrate the setting of V4L2_CAP_STREAMING in one place. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v9 04/15] vb2: move vb2_ops functions to videobuf2-core.[ch]

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++

[PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

2018-05-04 Thread Mauro Carvalho Chehab
Just checking for ifdefs cause build issues as reported by kernel test: config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function

[PATCH v9 10/15] vb2: add explicit fence user API

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending an in-fence to

[PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't be queued to the driver out of the order they were

[PATCH v9 07/15] v4l: mark unordered formats

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, mark the appropriate formats. Signed-off-by: Gustavo Padovan --- drivers/media/v4l2-core/v4l2-ioctl.c | 55 1

[PATCH v9 13/15] v4l: introduce the fences capability

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers capable of using fences (vb2 drivers) should report the V4L2_CAP_FENCES to userspace, so add this flag to the uapi. v2: minor doc/english fix (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v3] saa7164: Fix driver name in debug output

2018-05-04 Thread Brad Love
This issue was reported by a user who downloaded a corrupt saa7164 firmware, then went looking for a valid xc5000 firmware to fix the error displayed...but the device in question has no xc5000, thus after much effort, the wild goose chase eventually led to a support call. The xc5000 has nothing

Re: [PATCH v2 03/10] videobuf2-core: Add helper to get buffer private data from media request

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-19 at 17:41 +0200, Paul Kocialkowski wrote: > When calling media operation driver callbacks related to media > requests, > only a pointer to the request itself is provided, which is > insufficient > to retrieve the driver's context. Since the driver context is usually > set as

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-05-04 Thread Maxime Ripard
On Fri, May 04, 2018 at 09:56:20AM +0200, Paul Kocialkowski wrote: > > > I agree that the term VPU is more commonly associated with video > > > decoding, while video engine could mean a number of things. > > > > > > The reason I went with "video-engine" here (while still presenting > > > the > >

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 15:57 +0200, Hans Verkuil wrote: > On 04/19/18 17:45, Paul Kocialkowski wrote: > > Stateless video decoding engines require both the MPEG slices and > > associated metadata from the video stream in order to decode frames. > > > > This introduces definitions for a new

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-05-03 15:25:52) > > > Almost everyone uses dma_fence_default_wait. > > > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > > > I

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-03 15:25:52) > Almost everyone uses dma_fence_default_wait. > > v2: Also remove the BUG_ON(!ops->wait) (Chris). I just don't get the rationale for implicit over explicit. -Chris

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-04-20 at 09:51 +, Tomasz Figa wrote: > Hi Paul, > > On Fri, Apr 20, 2018 at 12:46 AM Paul Kocialkowski < > paul.kocialkow...@bootlin.com> wrote: > [snip] > > +struct v4l2_ctrl_mpeg2_frame_hdr { > > + __u32 slice_len; > > + __u32 slice_pos; > > + enum {

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Maxime Ripard
On Fri, May 04, 2018 at 10:47:44AM +0200, Paul Kocialkowski wrote: > > > > > + reg = <0x01c0e000 0x1000>; > > > > > + memory-region = <_memory>; > > > > > > > > Since you made the CMA region the default one, you don't need to > > > > tie > > > > it to that

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:57:59) >> On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: >> > Quoting Daniel Vetter (2018-05-04 09:23:01) >> > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel

[PATCH] media: renesas-ceu: Set mbus_fmt on subdev operations

2018-05-04 Thread Jacopo Mondi
The renesas-ceu driver intializes the desired mbus_format at 'complete' time, inspecting the supported subdevice ones, and tuning some parameters to produce the requested memory format from what the sensor can produce. Although, the initially selected mbus_format was not provided to the subdevice

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Loic Poulain
Hi, On 3 May 2018 at 17:16, Maxime Ripard wrote: > Hi, > > On Wed, May 02, 2018 at 11:11:55AM -0700, Sam Bobrowicz wrote: >> > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: >> >> FYI, still hard at work on this. Did some more experiments last week >>

Re: [PATCH 2/2] media: imx: add support for RGB565_2X8 on parallel bus

2018-05-04 Thread kbuild test robot
/0day-ci/linux/commits/Jan-Luebbe/media-imx-add-capture-support-for-RGB565_2X8-on-parallel-bus/20180504-120003 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote: > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel format, describing buffers > with MPEG2 slice

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-05-04 at 10:40 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 09:49:16AM +0200, Paul Kocialkowski wrote: > > > > + reserved-memory { > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + ranges; > > > > + > >

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:23:01) > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > > > Quoting Daniel Vetter (2018-05-03 15:25:52) > >

[PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Mauro Carvalho Chehab
>From now on, I'll start using my @kernel.org as my development e-mail. As such, let's remove the entries that point to the old mche...@s-opensource.com at MAINTAINERS file. For the files written with a copyright with mchehab@s-opensource, let's keep Samsung on their names, using

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-26 at 22:04 -0500, Rob Herring wrote: > On Fri, Apr 20, 2018 at 09:22:20AM +0200, Paul Kocialkowski wrote: > > Hi and thanks for the review, > > > > On Fri, 2018-04-20 at 01:31 +, Tomasz Figa wrote: > > > Hi Paul, Philipp, > > > > > > On Fri, Apr 20, 2018 at 1:04 AM

Re: [PATCH v2 07/10] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-04-24 at 12:13 +0300, Sakari Ailus wrote: > Hi Paul > > On Thu, Apr 19, 2018 at 05:45:33PM +0200, Paul Kocialkowski wrote: > > This introduces the Sunxi-Cedrus VPU driver that supports the VPU > > found > > in Allwinner SoCs, also known as Video Engine. It is implemented > >

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
Hi, On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 10:47:44AM +0200, Paul Kocialkowski wrote: > > > > > > + reg = <0x01c0e000 0x1000>; > > > > > > + memory-region = <_memory>; > > > > > > > > > > Since you made the CMA region

[PATCH] media: vsp1: cleanup a false positive warning

2018-05-04 Thread Mauro Carvalho Chehab
With the new vsp1 code changes introduced by changeset f81f9adc4ee1 ("media: v4l: vsp1: Assign BRU and BRS to pipelines dynamically"), smatch complains with: drivers/media/platform/vsp1/vsp1_drm.c:262 vsp1_du_pipeline_setup_bru() error: we previously assumed 'pipe->bru' could be null (see

Re: [PATCHv13 02/28] uapi/linux/media.h: add request API

2018-05-04 Thread Sakari Ailus
On Thu, May 03, 2018 at 04:52:52PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Define the public request API. > > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > and two ioctls that operate on a request in order to queue the > contents of

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-04 Thread Vikash Garodia
Hi Stanimir, On 2018-05-03 17:06, Stanimir Varbanov wrote: Hi Vikash, Thanks for the comments! On 2.05.2018 09:26, Vikash Garodia wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: Call session_continue for Venus 4xx version even when the event says that the buffer

Re: [PATCHv13 24/28] vim2m: use workqueue

2018-05-04 Thread Sakari Ailus
Hi Hans, On Thu, May 03, 2018 at 04:53:14PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in > interrupt context. Switch to a workqueue instead. > > Signed-off-by: Hans Verkuil > ---

Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Mauro Carvalho Chehab
Em Fri, 04 May 2018 13:58:39 +0300 Jani Nikula escreveu: > On Fri, 04 May 2018, Mauro Carvalho Chehab wrote: > > From now on, I'll start using my @kernel.org as my development e-mail. > > > > As such, let's remove the entries that point

[GIT PULL for v4.17-rc4] media fixes and a MAINTAINERS file update with my email

2018-05-04 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.17-4 For: - a trivial one-line fix addressing a PTR_ERR() getting value from a wrong var at imx driver; - a patch changing my e-mail at the Kernel tree to mche...@kernel.org. no

Re: [PATCHv13 01/28] v4l2-device.h: always expose mdev

2018-05-04 Thread Sakari Ailus
On Thu, May 03, 2018 at 04:52:51PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > But since we will need to pass the media_device to vb2 and the > control framework it is very convenient to just make

Hello

2018-05-04 Thread Faruk Sakawo
I have a business to discuss with you, can we talk? Regards Faruk Sakawo

Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-04 Thread Jani Nikula
On Fri, 04 May 2018, Mauro Carvalho Chehab wrote: > From now on, I'll start using my @kernel.org as my development e-mail. > > As such, let's remove the entries that point to the old > mche...@s-opensource.com at MAINTAINERS file. > > For the files written with a

Re: [PATCHv13 03/28] media-request: implement media requests

2018-05-04 Thread Sakari Ailus
Hi Hans, I've read this patch a large number of times and I think also the details begin to seem sound. A few comments below. On Thu, May 03, 2018 at 04:52:53PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add initial media request support: > > 1) Add

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

2018-05-04 Thread Sakari Ailus
On Thu, May 03, 2018 at 04:52:54PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add media_request_get_by_fd() to find a request based on the file > descriptor. > > The caller has to call media_request_put() for the returned > request since this function increments

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: > Am 04.05.2018 um 11:25 schrieb Daniel Vetter: > > On Fri, May 4, 2018 at 11:16 AM, Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2018-05-04 09:57:59) > > > > On Fri, May 04, 2018 at 09:31:33AM

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-05-04 Thread Andy Shevchenko
On Fri, 2018-05-04 at 02:29 -0500, Wenwen Wang wrote: > At the end of atomisp_subdev_set_selection(), the function > atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. > Since > this function may return a NULL pointer, it is firstly invoked to > check > the returned pointer. If

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
On Fri, 2018-05-04 at 15:40 +0200, Maxime Ripard wrote: > On Fri, May 04, 2018 at 02:04:38PM +0200, Paul Kocialkowski wrote: > > On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > > > On Fri, May 04, 2018 at 10:47:44AM +0200, Paul Kocialkowski wrote: > > > > > > > > +

Re: [PATCH v2 7/7] media: via-camera: allow build on non-x86 archs with COMPILE_TEST

2018-05-04 Thread Mauro Carvalho Chehab
Em Mon, 23 Apr 2018 14:19:31 +0200 Bartlomiej Zolnierkiewicz escreveu: > Hi Mauro, > > On Friday, April 20, 2018 04:03:21 PM Mauro Carvalho Chehab wrote: > > This driver depends on FB_VIA for lots of things. Provide stubs > > for the functions it needs, in order to

Re: [PATCH v2 7/7] media: via-camera: allow build on non-x86 archs with COMPILE_TEST

2018-05-04 Thread Mauro Carvalho Chehab
Em Mon, 23 Apr 2018 14:19:31 +0200 Bartlomiej Zolnierkiewicz escreveu: > How's about just allowing COMPILE_TEST for FB_VIA instead of adding > all these stubs? Works for me. Do you want to apply it via your tree or via the media one? If you prefer to apply on yours:

[PATCH] dma-fence: Polish kernel-doc for dma-fence.c

2018-05-04 Thread Daniel Vetter
- Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish v2: Add misplaced hunk of kerneldoc from a different patch. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

2018-05-04 Thread Mauro Carvalho Chehab
Em Wed, 25 Apr 2018 12:47:34 +0200 Bartlomiej Zolnierkiewicz escreveu: > On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 14:47:28 +0200 > > Bartlomiej Zolnierkiewicz escreveu: > > > > > On Friday,

[PATCH v12 0/4] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-05-04 Thread Maxime Ripard
Hi, Here is a hopefully final attempt at supporting the MIPI-CSI2 RX and TX blocks from Cadence. This is a merged serie of the CSI2-RX and CSI2-TX series I've been sending for a while now and gathered a significant amount of Reviewed-by/Acked-by. The merge has been done thanks to Sakari's

[PATCH v12 4/4] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-05-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used as a bridge between pixel interfaces and a CSI-2 bus. It supports operating with an internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. While the virtual

[PATCH v12 2/4] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-05-04 Thread Maxime Ripard
The Cadence CSI-2 RX Controller is an hardware block meant to be used as a bridge between a CSI-2 bus and pixel grabbers. It supports operating with internal or external D-PHY, with up to 4 lanes, or without any D-PHY. The current code only supports the latter case. It also support dynamic

[PATCH v12 1/4] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2018-05-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Rob Herring

[PATCH v12 3/4] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

2018-05-04 Thread Maxime Ripard
The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 video streams and can output on up to 4 CSI-2 lanes, depending on the hardware implementation. It can operate with an external D-PHY, an internal one or no D-PHY at all in some configurations. Acked-by: Benoit Parrot

[PATCH] dma-fence: Make ->enable_signaling optional

2018-05-04 Thread Daniel Vetter
Many drivers have a trivial implementation for ->enable_signaling. Let's make it optional by assuming that signalling is already available when the callback isn't present. v2: Don't do the trick to set the ENABLE_SIGNAL_BIT unconditionally, it results in an expensive spinlock take for everyone.

Re: [PATCH v2 02/10] media-request: Add a request complete operation to allow m2m scheduling

2018-05-04 Thread Paul Kocialkowski
Hi, On Thu, 2018-04-19 at 17:41 +0200, Paul Kocialkowski wrote: > When using the request API in the context of a m2m driver, the > operations that come with a m2m run scheduling call in their > (m2m-specific) ioctl handler are delayed until the request is queued > (for instance, this includes

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-03 15:25:52) > > Almost everyone uses dma_fence_default_wait. > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > I just don't get the rationale for implicit over explicit. Closer

Re: [PATCH v2 05/10] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-04 Thread Paul Kocialkowski
Hi, On Tue, 2018-04-24 at 12:01 +0300, Sakari Ailus wrote: > Hi Paul, > > On Thu, Apr 19, 2018 at 05:45:31PM +0200, Paul Kocialkowski wrote: > > Stateless video decoding engines require both the MPEG slices and > > associated metadata from the video stream in order to decode frames. > > > >

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Maxime Ripard
On Fri, May 04, 2018 at 09:49:16AM +0200, Paul Kocialkowski wrote: > > > + reserved-memory { > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + ranges; > > > + > > > + /* Address must be kept in the lower 256 MiBs of > > > DRAM for VE. */ > > > +

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Paul Kocialkowski
On Fri, 2018-05-04 at 10:47 +0200, Paul Kocialkowski wrote: > > > > Don't you also need to map the SRAM on the A20? > > > > > > That's a good point, there is currently no syscon handle for A20 > > > (and > > > also A13). Maybe SRAM is muxed to the VE by default so it "just > > > works"? I just

Re: [PATCHv13 05/28] media-request: add media_request_object_find

2018-05-04 Thread Sakari Ailus
On Thu, May 03, 2018 at 04:52:55PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add media_request_object_find to find a request object inside a > request based on ops and/or priv values. > > Objects of the same type (vb2 buffer, control handler) will have > the

Re: [Linaro-mm-sig] [PATCH 4/8] dma-buf: add peer2peer flag

2018-05-04 Thread Lucas Stach
Am Mittwoch, den 25.04.2018, 13:44 -0400 schrieb Alex Deucher: > On Wed, Apr 25, 2018 at 2:41 AM, Christoph Hellwig > wrote: > > On Wed, Apr 25, 2018 at 02:24:36AM -0400, Alex Deucher wrote: > > > > It has a non-coherent transaction mode (which the chipset can opt to > > > >

[PATCH 0/2] add support for TI SCAN921226H video deserializer

2018-05-04 Thread Jan Luebbe
This series adds a binding and the corresponding V4L subdev driver for the TI SCAN921226H video deserializer. Although the device doesn't need to be configured, it can be controlled via GPIOs to allow multiple sensors on the same parallel video bus. Jan Luebbe (2): media: dt-bindings: add

[PATCH 2/2] media: platform: add driver for TI SCAN921226H video deserializer

2018-05-04 Thread Jan Luebbe
Although one could have a working setup with a sensor such as the MT9V024 connected via LVDS to the deserializer and then via parallel to the SoC's camera interface even without having a driver for the deserializer, controlling the deserializer's state is needed when multiple cameras share the

[PATCH 1/2] media: dt-bindings: add binding for TI SCAN921226H video deserializer

2018-05-04 Thread Jan Luebbe
This deserializer can be used with sensors that directly produce a 10-bit LVDS stream and converts it to a parallel bus. Controlling it via the optional GPIOs is mainly useful for avoiding conflicts when another parallel sensor is connected to the same data bus as the deserializer.

Re: [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Christian König
Am 04.05.2018 um 11:25 schrieb Daniel Vetter: On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:57:59) On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:23:01) On Fri, May 04,

Re: [PATCH v2 0/9] cx231xx: House cleaning

2018-05-04 Thread Brad Love
Hi Hans, On 2018-05-04 01:27, Hans Verkuil wrote: > Hi Brad, > > On 03/05/18 23:20, Brad Love wrote: >> Included in this patch set is: >> - Bugfix for a device not working >> - Some clean up and value corrections >> - Conversion to new dvb i2c helpers >> - Update of device from old dvb attach to

Re: [PATCH v2 09/10] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-04 Thread Maxime Ripard
On Fri, May 04, 2018 at 02:04:38PM +0200, Paul Kocialkowski wrote: > On Fri, 2018-05-04 at 11:15 +0200, Maxime Ripard wrote: > > On Fri, May 04, 2018 at 10:47:44AM +0200, Paul Kocialkowski wrote: > > > > > > > + reg = <0x01c0e000 0x1000>; > > > > > > > +

[PATCH 2/7 v2] media: meye: allow building it with COMPILE_TEST on non-x86

2018-05-04 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab This driver depends on sony-laptop driver, but this is available only for x86. So, add a stub function, in order to allow building it on non-x86 too. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro

Re: atomisp: drop from staging ?

2018-05-04 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 11:30:50 +0300 Sakari Ailus escreveu: > On Mon, Apr 30, 2018 at 12:41:00PM +0300, Sakari Ailus wrote: > > Hi Alan, > > > > On Sun, Apr 29, 2018 at 01:18:37AM +0100, Alan Cox wrote: > > > > > > I think this is going to be the best option. When I started

[PATCH] media: video-i2c: get rid of two gcc warnings

2018-05-04 Thread Mauro Carvalho Chehab
After adding this driver, gcc complains with: drivers/media/i2c/video-i2c.c:55:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] const static struct v4l2_fmtdesc amg88xx_format = { ^ drivers/media/i2c/video-i2c.c:59:1: warning: 'static' is not at beginning

Re: [PATCH v2 7/7] media: via-camera: allow build on non-x86 archs with COMPILE_TEST

2018-05-04 Thread Bartlomiej Zolnierkiewicz
On Friday, May 04, 2018 11:07:01 AM Mauro Carvalho Chehab wrote: > Em Mon, 23 Apr 2018 14:19:31 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > > How's about just allowing COMPILE_TEST for FB_VIA instead of adding > > all these stubs? > > Works for me. > > Do you

  1   2   >