Hi,
I tried using the aptina_pll_calculate for a "new" imager and ran into
problems. After filling out aptina_pll_limits from the data sheet, I was
having a hard time finding a valid pix_clock. Most of the ones I tried
are rejected by aptina_pll_calculate for various reasons. In particular,
no
On 13/08/18 17:02, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:21 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> For mem2mem devices we have to make sure that v4l2_m2m_try_schedule()
>> is called whenever a request is queued.
>>
>> We do that by creating a
On 13/08/18 17:15, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:26 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> Keep track of the number of requests and request objects of a media
>> device. Helps to verify that all request-related memory is freed.
>>
>>
Em Tue, 14 Aug 2018 09:28:42 +0200
Hans Verkuil escreveu:
> On 13/08/18 17:05, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:22 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in
> >> interrupt
On 13/08/18 16:53, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:18 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> The generic vb2_request_validate helper function checks if
>> there are buffers in the request and if so, prepares (validates)
>> all objects in the
Em Tue, 14 Aug 2018 09:33:16 +0200
Hans Verkuil escreveu:
> On 13/08/18 17:15, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:26 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Keep track of the number of requests and request objects of a media
> >>
On 09/08/18 19:43, Mauro Carvalho Chehab wrote:
>> diff --git a/Documentation/media/uapi/v4l/vidioc-qbuf.rst
>> b/Documentation/media/uapi/v4l/vidioc-qbuf.rst
>> index 9e448a4aa3aa..0e415f2551b2 100644
>> --- a/Documentation/media/uapi/v4l/vidioc-qbuf.rst
>> +++
Em Fri, 10 Aug 2018 09:39:20 +0200
Hans Verkuil escreveu:
> On 08/09/2018 10:03 PM, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:00 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> We need to serialize streamon/off with queueing new requests.
> >> These
On 13/08/18 17:05, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:22 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in
>> interrupt context. Switch to a workqueue instead and drop the timer.
>>
>> Signed-off-by:
Hi Helmut,
(CC'ing Sakari Ailus who is our current PLL expert after spending so much time
on the SMIA PLL code)
On Tuesday, 14 August 2018 09:35:40 EEST Helmut Grohne wrote:
> Hi,
>
> I tried using the aptina_pll_calculate for a "new" imager and ran into
> problems. After filling out
nfds depends on RLIMIT_NOFILE, not OPEN_MAX. Update the description
for cec and v4l2.
Signed-off-by: Hans Verkuil
---
diff --git a/Documentation/media/uapi/cec/cec-func-poll.rst
b/Documentation/media/uapi/cec/cec-func-poll.rst
index d49f1ee0742d..c698c969635c 100644
---
On 18-08-13 15:41, Rob Herring wrote:
> On Mon, Aug 13, 2018 at 11:25:03AM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video input sources to their
> > AIP1A/B pins.
> >
> > Possible configurations are as follows:
> > - Analog Composite signal connected to AIP1A.
> >
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
> Hi Jacopo,
>
>
> On 08/14/2018 08:35 AM, jacopo mondi wrote:
> >Hi Steve,
> >sorry for resurecting this.
> >
> >
> >>>I'm sorry I'm not sur I'm following. Does this mean that with that bug
> >>>you are referring to
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean that with that bug
you are referring to up here fixed by my last patch you have capture
working?
No, capture still not working for me on
Em Tue, 14 Aug 2018 16:20:26 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Integrate the request support. This adds the v4l2_ctrl_request_complete
> and v4l2_ctrl_request_setup functions to complete a request and (as a
> helper function) to apply a request to the hardware.
>
> It
Em Tue, 14 Aug 2018 16:20:12 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Hi all,
>
> This is version 18 of the Request API series. The intention is that
> this will become a topic branch in preparation of merging this for
> 4.20 together with the cedrus staging driver.
>
> I
Em Tue, 14 Aug 2018 17:01:07 -0300
Mauro Carvalho Chehab escreveu:
> >
> > Besides all the review comments I also fixed a bug. See:
> > https://www.mail-archive.com/linux-media@vger.kernel.org/msg134311.html
>
> I'll look on it right now.
Sorry, I meant to say that I'm looking into this
Em Tue, 14 Aug 2018 16:20:15 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Add initial media request support:
>
> 1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c
> 2) Add struct media_request to store request objects.
> 3) Add struct media_request_object to represent a
Em Tue, 14 Aug 2018 16:20:27 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The v4l2_g/s_ext_ctrls functions now support control handlers that
> represent requests.
>
> The v4l2_ctrls_find_req_obj() function is responsible for finding the
> request from the fd.
>
> Signed-off-by: Hans
Em Tue, 14 Aug 2018 16:20:33 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The PREPARED state becomes a problem with the request API: a buffer
> could be PREPARED but dequeued, or PREPARED and in state IN_REQUEST.
>
> PREPARED is really not a state as such, but more a property of the
Em Tue, 14 Aug 2018 16:20:14 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Define the public request API.
>
> This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
> and two ioctls that operate on a request in order to queue the
> contents of the request to the driver
Em Tue, 14 Aug 2018 16:20:31 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The userspace-provided plane data needs to be stored in
> vb2_v4l2_buffer. Currently this information is applied by
> __fill_vb2_buffer() which is called by the core prepare_buf
> and qbuf functions, but when
Em Tue, 14 Aug 2018 16:20:36 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Make vb2_buffer a request object.
>
> Signed-off-by: Hans Verkuil
I had already sent a reviewed-by to this. Anyway:
Reviewed-by: Mauro Carvalho Chehab
> ---
> include/media/videobuf2-core.h | 4
> 1
Em Tue, 14 Aug 2018 16:20:40 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> The generic vb2_request_validate helper function checks if
> there are buffers in the request and if so, prepares (validates)
> all objects in the request.
>
> The generic vb2_request_queue helper function
On Fri, 10 Aug 2018 17:18:20 +0200, Philipp Zabel wrote:
> Add DT binding documentation for the Pixel Pipeline (PXP) found on
> various NXP i.MX SoCs.
>
> Signed-off-by: Philipp Zabel
> ---
> .../devicetree/bindings/media/fsl-pxp.txt | 26 +++
> 1 file changed, 26
Em Tue, 14 Aug 2018 16:20:13 +0200
Hans Verkuil escreveu:
> From: Alexandre Courbot
>
> Document the request API for V4L2 devices, and amend the documentation
> of system calls influenced by it.
Looks ok to me. Just a minor nitpick (see below).
Mental note: we'll need to push the
Em Tue, 14 Aug 2018 16:20:28 +0200
Hans Verkuil escreveu:
> If a driver needs to find/inspect the controls set in a request then
> it can use these functions.
>
> E.g. to check if a required control is set in a request use this in the
> req_validate() implementation:
>
> int res =
Em Tue, 14 Aug 2018 16:20:20 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> We need to serialize streamon/off with queueing new requests.
> These ioctls may trigger the cancellation of a streaming
> operation, and that should not be mixed with queuing a new
> request at the same time.
>
Em Tue, 14 Aug 2018 16:20:29 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> Move the __fill_v4l2_buffer() to before the vb2_queue_or_prepare_buf()
> function to prepare for the next two patches.
>
> No other changes.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
Em Tue, 14 Aug 2018 16:20:43 +0200
Hans Verkuil escreveu:
> From: Hans Verkuil
>
> For mem2mem devices we have to make sure that v4l2_m2m_try_schedule()
> is called whenever a request is queued.
>
> We do that by creating a vb2_m2m_request_queue() helper that should
> be used instead of the
Hi,
On Tue, Aug 14, 2018 at 10:30:14AM +0300, Laurent Pinchart wrote:
> Hi Helmut,
>
> (CC'ing Sakari Ailus who is our current PLL expert after spending so much
> time
> on the SMIA PLL code)
>
> On Tuesday, 14 August 2018 09:35:40 EEST Helmut Grohne wrote:
> > Hi,
> >
> > I tried using the
Em Tue, 14 Aug 2018 10:45:57 +0200
Hans Verkuil escreveu:
> On 13/08/18 13:07, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:08 +0200
> > Hans Verkuil escreveu:
> >
> >> If a driver needs to find/inspect the controls set in a request then
> >> it can use these functions.
> >>
>
On 14/08/18 10:48, Mauro Carvalho Chehab wrote:
> Em Tue, 14 Aug 2018 09:57:27 +0200
> Hans Verkuil escreveu:
>
>> On 09/08/18 19:43, Mauro Carvalho Chehab wrote:
diff --git a/Documentation/media/uapi/v4l/vidioc-qbuf.rst
b/Documentation/media/uapi/v4l/vidioc-qbuf.rst
index
Em Fri, 10 Aug 2018 09:20:48 +0200
Hans Verkuil escreveu:
> On 08/09/2018 07:43 PM, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:44:53 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Alexandre Courbot
> >>
> >> Document the request API for V4L2 devices, and amend the
Em Tue, 14 Aug 2018 10:58:59 +0200
Hans Verkuil escreveu:
> On 13/08/18 13:30, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:11 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> The PREPARED state becomes a problem with the request API: a buffer
> >> could
Dne 14.8.2018 v 10:35 Sakari Ailus napsal(a):
> Hi Pert,
>
Hello,
thanks for answering
> On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote:
>> From: Petr Cvek
>>
>> When transferring a media sensor driver from the soc_camera I've found
>> the controller module can get
On 13/08/18 13:07, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:08 +0200
> Hans Verkuil escreveu:
>
>> If a driver needs to find/inspect the controls set in a request then
>> it can use these functions.
>>
>> E.g. to check if a required control is set in a request use this in the
>>
Em Fri, 10 Aug 2018 09:21:59 +0200
Hans Verkuil escreveu:
> On 08/09/2018 07:53 PM, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:44:54 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Define the public request API.
> >>
> >> This adds the new
Em Fri, 10 Aug 2018 09:32:53 +0200
Hans Verkuil escreveu:
> On 08/09/2018 09:55 PM, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:44:57 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Add media_request_get_by_fd() to find a request based on the file
> >>
On 13/08/18 12:55, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:06 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> Integrate the request support. This adds the v4l2_ctrl_request_complete
>> and v4l2_ctrl_request_setup functions to complete a request and (as a
>> helper
Hi Pert,
On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote:
> From: Petr Cvek
>
> When transferring a media sensor driver from the soc_camera I've found
> the controller module can get removed (which will cause a stack dump
> because the sensor driver depends on resources
Em Tue, 14 Aug 2018 09:57:27 +0200
Hans Verkuil escreveu:
> On 09/08/18 19:43, Mauro Carvalho Chehab wrote:
> >> diff --git a/Documentation/media/uapi/v4l/vidioc-qbuf.rst
> >> b/Documentation/media/uapi/v4l/vidioc-qbuf.rst
> >> index 9e448a4aa3aa..0e415f2551b2 100644
> >> ---
On 14/08/18 10:46, Mauro Carvalho Chehab wrote:
> Em Fri, 10 Aug 2018 09:21:59 +0200
> Hans Verkuil escreveu:
>
>> On 08/09/2018 07:53 PM, Mauro Carvalho Chehab wrote:
>>> Em Sat, 4 Aug 2018 14:44:54 +0200
>>> Hans Verkuil escreveu:
>>>
From: Hans Verkuil
Define the public
Hi,
Thank you for the quick and helpful answer.
On Tue, Aug 14, 2018 at 09:30:14AM +0200, Laurent Pinchart wrote:
> How do you mean ? The only place where pix_clock_max is used is in the
> following code:
>
> if (pll->pix_clock == 0 || pll->pix_clock > limits->pix_clock_max) {
>
Em Tue, 14 Aug 2018 10:34:47 +0200
Hans Verkuil escreveu:
> >> +void v4l2_ctrl_request_setup(struct media_request *req,
> >> + struct v4l2_ctrl_handler *main_hdl)
> >> +{
> >> + struct media_request_object *obj;
> >> + struct v4l2_ctrl_handler *hdl;
> >> + struct
On 13/08/18 13:30, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:11 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> The PREPARED state becomes a problem with the request API: a buffer
>> could be PREPARED but dequeued, or PREPARED and in state IN_REQUEST.
>>
>> PREPARED
Hi Jesse,
Em Mon, 13 Aug 2018 01:32:45 +
Jesse Huang (黃建興) escreveu:
> Hi Mchehab,
> Hi Linux-Media,
>
> MTK/MStar try to move TV SOC proprietary driver framework to Linux TV driver.
>
> But, we also need to share/re-use driver code to non-OS which is a size
> limitation low cost system.
On 14/08/18 10:55, Mauro Carvalho Chehab wrote:
> Em Tue, 14 Aug 2018 10:45:57 +0200
> Hans Verkuil escreveu:
>
>> On 13/08/18 13:07, Mauro Carvalho Chehab wrote:
>>> Em Sat, 4 Aug 2018 14:45:08 +0200
>>> Hans Verkuil escreveu:
>>>
If a driver needs to find/inspect the controls set in
On 08/14/2018 10:38 AM, jacopo mondi wrote:
Hi Steve,
On Tue, Aug 14, 2018 at 09:51:04AM -0700, Steve Longerbeam wrote:
Hi Jacopo,
On 08/14/2018 08:35 AM, jacopo mondi wrote:
Hi Steve,
sorry for resurecting this.
I'm sorry I'm not sur I'm following. Does this mean that with that
Hi Mchehab,
We are very appreciating for your reply.
For GPL, We are agree to follow GPL license to open source code which is in
Linux kernel.
For "but we don't accept any other OS-dependent code", we can follow this rule
to remove relative OS-dependent code.
For " If otherwise all you want is
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Aug 15 05:00:16 CEST 2018
media-tree git hash:da2048b7348a0be92f706ac019e022139e29495e
media_build
On Tuesday, 14 August 2018 17:21:24 MSK Thierry Reding wrote:
> On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote:
> > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote:
> > > From: Thierry Reding
> > >
> > > The BSEV clock has a separate gate bit and can not be assumed
On Tuesday, 14 August 2018 18:05:51 MSK Dmitry Osipenko wrote:
> On Tuesday, 14 August 2018 17:21:24 MSK Thierry Reding wrote:
> > On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote:
> > > On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote:
> > > > From: Thierry Reding
> > >
Em Tue, 14 Aug 2018 11:57:48 +0200
Hans Verkuil escreveu:
> On 14/08/18 10:46, Mauro Carvalho Chehab wrote:
> > Em Fri, 10 Aug 2018 09:21:59 +0200
> > Hans Verkuil escreveu:
> >
> >> On 08/09/2018 07:53 PM, Mauro Carvalho Chehab wrote:
> >>> Em Sat, 4 Aug 2018 14:44:54 +0200
> >>> Hans
From: Hans Verkuil
Add media_request_get_by_fd() to find a request based on the file
descriptor.
The caller has to call media_request_put() for the returned
request since this function increments the refcount.
Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
Reviewed-by: Mauro Carvalho
From: Hans Verkuil
Add support for the media_device to vivid. This is a prerequisite
for request support.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/platform/vivid/vivid-core.c | 61 +++
drivers/media/platform/vivid/vivid-core.h | 8
From: Hans Verkuil
Set the first time a buffer from a request is queued to vb2
(uses_requests) or directly queued (uses_qbuf).
Cleared when the queue is canceled.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/common/videobuf2/videobuf2-core.c | 13
From: Hans Verkuil
Add support for requests to vivid.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/platform/vivid/vivid-core.c| 8
drivers/media/platform/vivid/vivid-kthread-cap.c | 12
From: Hans Verkuil
Make vb2_buffer a request object.
Signed-off-by: Hans Verkuil
---
include/media/videobuf2-core.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 2eb24961183e..413b8b2dc485 100644
---
From: Hans Verkuil
When queuing buffers allow for passing the request that should
be associated with this buffer.
If V4L2_BUF_FLAG_REQUEST_FD is set, then request_fd is used as
the file descriptor.
If a buffer is stored in a request, but not yet queued to the
driver, then
From: Alexandre Courbot
Document the request API for V4L2 devices, and amend the documentation
of system calls influenced by it.
Signed-off-by: Alexandre Courbot
Signed-off-by: Hans Verkuil
---
.../media/uapi/mediactl/media-controller.rst | 1 +
.../media/uapi/mediactl/media-funcs.rst
From: Hans Verkuil
The userspace-provided plane data needs to be stored in
vb2_v4l2_buffer. Currently this information is applied by
__fill_vb2_buffer() which is called by the core prepare_buf
and qbuf functions, but when using requests these functions
aren't called yet since the buffer won't be
From: Hans Verkuil
Add initial media request support:
1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c
2) Add struct media_request to store request objects.
3) Add struct media_request_object to represent a request object.
4) Add MEDIA_REQUEST_IOC_QUEUE/REINIT ioctl support.
From: Hans Verkuil
Define the public request API.
This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
and two ioctls that operate on a request in order to queue the
contents of the request to the driver and to re-initialize the
request.
Signed-off-by: Hans Verkuil
Acked-by:
From: Hans Verkuil
This implements the V4L2 part of the request support. The main
change is that vb2_qbuf and vb2_prepare_buf now have a new
media_device pointer. This required changes to several drivers
that did not use the vb2_ioctl_qbuf/prepare_buf helper functions.
Signed-off-by: Hans
From: Hans Verkuil
Hi all,
This is version 18 of the Request API series. The intention is that
this will become a topic branch in preparation of merging this for
4.20 together with the cedrus staging driver.
I incorporated Mauro's review comments and a review comment from
Ezequiel in v18.
The
From: Hans Verkuil
Embed and initialize a media_request_object in struct v4l2_ctrl_handler.
Add a p_req field to struct v4l2_ctrl_ref that will store the
request value.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
Reviewed-by: Mauro Carvalho Chehab
---
From: Hans Verkuil
The generic vb2_request_validate helper function checks if
there are buffers in the request and if so, prepares (validates)
all objects in the request.
The generic vb2_request_queue helper function queues all buffer
objects in the validated request.
Signed-off-by: Hans
On Mon, Aug 13, 2018 at 06:09:46PM +0300, Dmitry Osipenko wrote:
> On Monday, 13 August 2018 17:50:14 MSK Thierry Reding wrote:
> > From: Thierry Reding
> >
> > The BSEV clock has a separate gate bit and can not be assumed to be
> > always enabled. Add explicit handling for the BSEV clock and
From: Hans Verkuil
To store request data the handler_new_ref() allocates memory
for it if needed.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-ctrls.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git
From: Hans Verkuil
We need to initialize the request_fd field in struct vb2_v4l2_buffer
to -1 instead of the default of 0. So we need to add a new op that
is called when struct vb2_v4l2_buffer is allocated.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
From: Hans Verkuil
v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in
interrupt context. Switch to a workqueue instead and drop the timer.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 25 ++---
1 file
If a driver needs to find/inspect the controls set in a request then
it can use these functions.
E.g. to check if a required control is set in a request use this in the
req_validate() implementation:
int res = -EINVAL;
hdl = v4l2_ctrl_request_hdl_find(req, parent_hdl);
From: Hans Verkuil
The PREPARED state becomes a problem with the request API: a buffer
could be PREPARED but dequeued, or PREPARED and in state IN_REQUEST.
PREPARED is really not a state as such, but more a property of the
buffer. So make new 'prepared' and 'synced' bools instead to remember
From: Hans Verkuil
Replace 'if' statements by a switch in __fill_vb2_buffer()
in preparation of the next patch.
No other changes.
Signed-off-by: Hans Verkuil
---
.../media/common/videobuf2/videobuf2-v4l2.c | 21 ---
1 file changed, 14 insertions(+), 7 deletions(-)
diff
From: Alexandre Courbot
If 'which' is V4L2_CTRL_WHICH_REQUEST_VAL, then the 'request_fd' field
can be used to specify a request for the G/S/TRY_EXT_CTRLS ioctls.
Signed-off-by: Alexandre Courbot
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
From: Hans Verkuil
The next patch needs the reference to a control instead of the
control itself, so change struct v4l2_ctrl_helper accordingly.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +-
1 file changed, 9
From: Hans Verkuil
The v4l2_g/s_ext_ctrls functions now support control handlers that
represent requests.
The v4l2_ctrls_find_req_obj() function is responsible for finding the
request from the fd.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
From: Hans Verkuil
Move the __fill_v4l2_buffer() to before the vb2_queue_or_prepare_buf()
function to prepare for the next two patches.
No other changes.
Signed-off-by: Hans Verkuil
---
.../media/common/videobuf2/videobuf2-v4l2.c | 264 +-
1 file changed, 132 insertions(+),
From: Sakari Ailus
media-request.h has been recently added; add it to the documentation build
as well.
Signed-off-by: Sakari Ailus
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
Documentation/media/kapi/mc-core.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Hans Verkuil
Add a new helper function to tell if a request object is a buffer.
Add a new helper function that returns true if a media_request
contains at least one buffer.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
.../media/common/videobuf2/videobuf2-core.c
From: Hans Verkuil
Integrate the request support. This adds the v4l2_ctrl_request_complete
and v4l2_ctrl_request_setup functions to complete a request and (as a
helper function) to apply a request to the hardware.
It takes care of queuing requests and correctly chaining control values
in the
From: Hans Verkuil
For mem2mem devices we have to make sure that v4l2_m2m_try_schedule()
is called whenever a request is queued.
We do that by creating a vb2_m2m_request_queue() helper that should
be used instead of the 'normal' vb2_request_queue() helper. The m2m
helper function will call
From: Hans Verkuil
Check if the vb2 queue uses requests, and if so refuse to
add buffers that are not part of a request. Also check for
the reverse: a vb2 queue did not use requests, and an attempt
was made to queue a buffer to a request.
We might relax this in the future, but for now just
From: Hans Verkuil
We need to serialize streamon/off with queueing new requests.
These ioctls may trigger the cancellation of a streaming
operation, and that should not be mixed with queuing a new
request at the same time.
Finally close() needs this lock since that too can trigger the
From: Hans Verkuil
Add support for requests to vim2m.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/vim2m.c
From: Hans Verkuil
Add a 'bool from_other_dev' argument: set to true if the two
handlers refer to different devices (e.g. it is true when
inheriting controls from a subdev into a main v4l2 bridge
driver).
This will be used later when implementing support for the
request API since we need to
From: Hans Verkuil
Add a simple helper function that tests if the driver supports
the request API.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
include/media/v4l2-device.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/media/v4l2-device.h
From: Hans Verkuil
There is no need to check the vb2 state in the buf_prepare
callback: it can never be wrong.
Since VB2_BUF_STATE_PREPARED will be removed in the next patch
we'll remove this unnecessary check (and use of that state) first.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro
From: Hans Verkuil
Buffers can now be prepared or queued for a request.
A buffer is unbound from the request at vb2_buffer_done time or
when the queue is cancelled.
Signed-off-by: Hans Verkuil
Reviewed-by: Mauro Carvalho Chehab
---
.../media/common/videobuf2/videobuf2-core.c | 133
From: Hans Verkuil
Add media_request_object_find to find a request object inside a
request based on ops and priv values.
Objects of the same type (vb2 buffer, control handler) will have
the same ops value. And objects that refer to the same 'parent'
object (e.g. the v4l2_ctrl_handler that has
On Fri, Aug 10, 2018 at 5:44 AM Vikash Garodia wrote:
>
> hi,
>
> This pull request updates firmware files for Venus h/w codec found on the
> Qualcomm SDM845 chipset.
>
> The following changes since commit 7b5835fd37630d18ac0c755329172f6a17c1af29:
>
> linux-firmware: add firmware for mt76x2u
On 04/08/18 14:44, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add initial media request support:
>
> 1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c
> 2) Add struct media_request to store request objects.
> 3) Add struct media_request_object to represent a request object.
> 4)
On 13/08/18 16:50, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:17 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> Add a new helper function to tell if a request object is a buffer.
>>
>> Add a new helper function that returns true if a media_request
>> contains at
Em Tue, 14 Aug 2018 09:19:08 +0200
Hans Verkuil escreveu:
> On 13/08/18 16:53, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:18 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> The generic vb2_request_validate helper function checks if
> >> there are
Em Tue, 14 Aug 2018 11:51:30 +0200
Hans Verkuil escreveu:
> On 14/08/18 10:48, Mauro Carvalho Chehab wrote:
> > Em Tue, 14 Aug 2018 09:57:27 +0200
> > Hans Verkuil escreveu:
> >
> >> On 09/08/18 19:43, Mauro Carvalho Chehab wrote:
> diff --git
Em Tue, 14 Aug 2018 11:35:01 +0300
Sakari Ailus escreveu:
> Hi Pert,
>
> On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote:
> > From: Petr Cvek
> >
> > When transferring a media sensor driver from the soc_camera I've found
> > the controller module can get removed (which
Em Tue, 14 Aug 2018 14:00:16 +0200
Hans Verkuil escreveu:
> On 09/08/18 22:03, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Aug 2018 14:45:00 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> We need to serialize streamon/off with queueing new requests.
> >> These ioctls
On 09/08/18 22:03, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Aug 2018 14:45:00 +0200
> Hans Verkuil escreveu:
>
>> From: Hans Verkuil
>>
>> We need to serialize streamon/off with queueing new requests.
>> These ioctls may trigger the cancellation of a streaming
>> operation, and that should not
Hi Steve,
sorry for resurecting this.
On Mon, Jul 16, 2018 at 09:26:13AM -0700, Steve Longerbeam wrote:
>
>
> On 07/16/2018 01:29 AM, jacopo mondi wrote:
> >Hi Steve,
> >thanks for keep testing it
> >
> >On Sat, Jul 14, 2018 at 01:02:32PM -0700, Steve Longerbeam wrote:
> >>
> >>On
1 - 100 of 102 matches
Mail list logo
