Re: [RFC] Request API and V4L2 capabilities

On 08/23/2018 07:37 PM, Nicolas Dufresne wrote: > Le jeudi 23 août 2018 à 16:31 +0200, Hans Verkuil a écrit : >>> I propose adding these capabilities: >>> >>> #define V4L2_BUF_CAP_HAS_REQUESTS 0x0001 >>> #define V4L2_BUF_CAP_REQUIRES_REQUESTS0x0002 >>> #define

[PATCH 5/5] vb2: set reqbufs/create_bufs capabilities

From: Hans Verkuil Set the capabilities field of v4l2_requestbuffers and v4l2_create_buffers. The various mapping modes were easy, but for signaling the request capability a new 'supports_requests' bitfield was added to videobuf2-core.h (and set in vim2m and vivid). Drivers have to set this

[PATCH 0/5] Post-v18: Request API updates

From: Hans Verkuil Hi all, This patch series sits on top of my v18 series for the Request API. It makes some final (?) changes as discussed in: https://www.mail-archive.com/linux-media@vger.kernel.org/msg134419.html and: https://www.spinics.net/lists/linux-media/msg138596.html The combined

[PATCH 2/5] v4l2-ctrls: return -EACCES if request wasn't completed

From: Hans Verkuil For now (this might be relaxed in the future) we do not allow getting controls from a request that isn't completed. In that case we return -EACCES. Update the documentation accordingly. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/vidioc-g-ext-ctrls.rst | 18

[PATCH 4/5] videodev2.h: add new capabilities for buffer types

From: Hans Verkuil VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities telling userspace what the given buffer type is capable of. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/vidioc-create-bufs.rst | 10 +- .../media/uapi/v4l/vidioc-reqbufs.rst | 36

[PATCH 1/5] media-request: return -EINVAL for invalid request_fds

From: Hans Verkuil Instead of returning -ENOENT when a request_fd was not found (VIDIOC_QBUF and VIDIOC_G/S/TRY_EXT_CTRLS), we now return -EINVAL. This is in line with what we do when invalid dmabuf fds are passed to e.g. VIDIOC_QBUF. Also document that EINVAL is returned for invalid m.fd

[PATCH 3/5] buffer.rst: only set V4L2_BUF_FLAG_REQUEST_FD for QBUF

From: Hans Verkuil Document that V4L2_BUF_FLAG_REQUEST_FD should only be used with VIDIOC_QBUF and cleared otherwise. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/buffer.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/media/uapi/v4l/buffer.rst

Re: [RFC] Request API and V4L2 capabilities

Hi, On Fri, 2018-08-24 at 09:29 +0200, Hans Verkuil wrote: > On 08/23/2018 07:37 PM, Nicolas Dufresne wrote: > > Le jeudi 23 août 2018 à 16:31 +0200, Hans Verkuil a écrit : > > > > I propose adding these capabilities: > > > > > > > > #define V4L2_BUF_CAP_HAS_REQUESTS 0x0001 > > > >

Re: [PATCHv18 07/35] v4l2-device.h: add v4l2_device_supports_requests() helper

On Tue, Aug 14, 2018 at 04:20:19PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add a simple helper function that tests if the driver supports > the request API. > > Signed-off-by: Hans Verkuil > Reviewed-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

Re: [PATCH 0/5] Post-v18: Request API updates

Hi Hans, On Fri, Aug 24, 2018 at 5:22 PM Hans Verkuil wrote: > > From: Hans Verkuil > > Hi all, > > This patch series sits on top of my v18 series for the Request API. > It makes some final (?) changes as discussed in: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg134419.html

Re: [PATCH 4/5] videodev2.h: add new capabilities for buffer types

Hi Hans, On Fri, Aug 24, 2018 at 5:22 PM Hans Verkuil wrote: > > From: Hans Verkuil > > VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities > telling userspace what the given buffer type is capable of. > Please see my comments below. > Signed-off-by: Hans Verkuil > --- >

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 25 05:00:16 CEST 2018 media-tree git hash:da2048b7348a0be92f706ac019e022139e29495e media_build

Re: [PATCH] uvcvideo: add a D4M camera description

Hi Guennadi, On Friday, 3 August 2018 14:07:12 EEST Guennadi Liakhovetski wrote: > Hi Laurent, > > Thanks for the review. A general note: I think you're requesting a rather > detailed information about many parameters. That isn't a problem by > itself, however, it is difficult to obtain some of

Re: [PATCH v2 2/2] uvcvideo: add a D4M camera description

Hi Guennadi, Thank you for the patch. Overall this looks good to me, I only have small comments. Please see below, with a summary at the end. On Friday, 3 August 2018 14:37:08 EEST Guennadi Liakhovetski wrote: > D4M is a mobile model from the D4XX family of Intel RealSense cameras. > This

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

Hi Sakari, Thank you for taking the time to look into the issue. On Thu, Aug 23, 2018 at 01:30:12PM +0200, Sakari Ailus wrote: > Knowing the formula, the limits as well as the external clock frequency, it > should be relatively straightforward to come up with a functional pixel > clock value.

Re: [PATCH] media: aptina-pll: allow approximating the requested pix_clock

Hi Laurent, Thank you for taking the time to reply to my patch and to my earlier questions. On Thu, Aug 23, 2018 at 01:12:15PM +0200, Laurent Pinchart wrote: > Could you please share numbers, ideally when run in kernel space ? Can you explain the benefits of profiling this inside the kernel