Hi Marco,
Em Fri, 9 Nov 2018 14:46:24 +0100
Marco Felsch escreveu:
> Hi Mauro,
>
> I don't want to spam you. Can you give me some feedback? I know the
> merge window is a busy time, so maybe you have some time now.
Sorry for taking so long on looking into it... has been really busy
those days
The io.h was still included twice. Having a large number of
includes like that unsorted is likely the reason why we ended
by having 3 includes of io.h and two includes of interrupt.h
at the first place.
So, let's reorder the includes on alphabetic order. That would
make easier to maintain it.
Hi Sakari,
Thanks for the review.
On Mon 03 Dec 2018 at 12:10, Sakari Ailus wrote:
Hi Rui,
On Thu, Nov 22, 2018 at 03:18:25PM +, Rui Miguel Silva
wrote:
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a
MIPI
CSI-2 interface.
Signed-off-by: Rui Miguel Silva
---
Hi Mauro,
Here are improvements for various sensor drivers for 4.21. There area few
trivial V4L2 fwnode and async framework changes as well, plus DT binding
documentation for mt9m111.
Please pull.
The following changes since commit 9b90dc85c718443a3e573a0ccf55900ff4fa73ae:
media: seco-cec:
Em Sun, 21 Oct 2018 15:45:39 +0200
Markus Dobel escreveu:
> The original commit (the one reverted in this patch) introduced a
> regression,
> making a previously flawless adapter unresponsive after running a few
> hours
> to days. Since I never experienced the problems that the original commit
Em Sat, 7 Jul 2018 13:20:54 +0200
André Roth escreveu:
> This makes dvb_time available outside of EIT parsing, and
> struct tm to reflect the actual values received from DVB.
>
> Signed-off-by: André Roth
> ---
> lib/include/libdvbv5/descriptors.h | 11 +++
>
From: Hans Verkuil
Document V4L2_BUF_FLAG_TAG.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
Documentation/media/uapi/v4l/buffer.rst | 17 ++---
Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4
2 files changed, 18
From: Hans Verkuil
Copy tags in vicodec.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/platform/vicodec/vicodec-core.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git
From: Hans Verkuil
Add new flag to indicate that buffer tags are supported.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 ++
include/media/videobuf2-core.h | 2 ++
2 files
From: Hans Verkuil
Memory-to-memory devices should copy various parts of
struct v4l2_buffer from the output buffer to the capture buffer.
Add a helper function that does that to simplify the driver code.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre
From: Hans Verkuil
When debugging is on, log the new tag field of struct v4l2_buffer
as well.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ioctl.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
From: Hans Verkuil
V4L2_BUF_FLAG_TIMECODE is not video capture specific, so drop that
part.
The 'Timecodes' section was a bit messy, so that's cleaned up.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
Documentation/media/uapi/v4l/buffer.rst |
From: Hans Verkuil
Add support for tags to vb2. Besides just storing and setting
the tag this patch also adds the vb2_find_tag() function that
can be used to find a buffer with the given tag.
This function will only look at DEQUEUED and DONE buffers, i.e.
buffers that are already processed.
From: Hans Verkuil
Add support for 'tags' to struct v4l2_buffer. These can be used
by m2m devices so userspace can set a tag for an output buffer and
this value will then be copied to the capture buffer(s).
This tag can be used to refer to capture buffers, something that
is needed by stateless
From: Hans Verkuil
Copy tags in vim2m.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/platform/vim2m.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/vim2m.c
From: Hans Verkuil
Replace old reference frame indices by new tag method.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 9
drivers/staging/media/sunxi/cedrus/cedrus.h | 9 +---
From: Hans Verkuil
https://lkml.org/lkml/2018/10/19/440
using capture queue buffer indices to refer to reference frames is
not a good idea. A better idea is to use a 'tag' where the
application can assign a u32 tag to an output buffer, which is then
copied to the capture buffer(s) derived from
The layout of the compound controls has changed to fix
32/64 bit alignment issues and the use of tags instead of
buffer indices to refer to buffers. Note that these controls
are only used by the cedrus staging driver.
Signed-off-by: Hans Verkuil
---
.../media/uapi/v4l/extended-controls.rst
The following changes since commit b2e9a4eda11fd2cb1e6714e9ad3f455c402568ff:
media: firewire: Fix app_info parameter type in avc_ca{,_app}_info
(2018-12-05 05:34:33 -0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.21h
for you to fetch
From: Hans Verkuil
Add a note mentioning that these two controls are not part of the
public API while they still stabilizing.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/extended-controls.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git
From: Hans Verkuil
The expectation was that the MPEG-2 state controls used by the staging
cedrus driver were stable, or would only require one final change. However,
it turns out that more changes are required, and that means that it is not
such a good idea to have these controls in the public
From: Hans Verkuil
The MPEG2 state controls for the cedrus stateless MPEG2 driver are
not yet stable. Move them out of the public headers into media/mpeg2-ctrls.h.
Eventually, once this has stabilized, they will be moved back to the
public headers.
Unfortunately I had to cast the control type
The Request API is now merged to the kernel but the confidence on the
stability of that API is not great, especially regarding the interaction
with V4L2.
Add a Kconfig option for the API, with a scary-looking warning.
The patch itself disables request creation as well as does not advertise
them
On 12/05/18 13:24, Sakari Ailus wrote:
> The Request API is now merged to the kernel but the confidence on the
> stability of that API is not great, especially regarding the interaction
> with V4L2.
>
> Add a Kconfig option for the API, with a scary-looking warning.
>
> The patch itself disables
Hi,
On Wed, 2018-12-05 at 13:09 +0100, hverkuil-ci...@xs4all.nl wrote:
> From: Hans Verkuil
>
> The expectation was that the MPEG-2 state controls used by the staging
> cedrus driver were stable, or would only require one final change. However,
> it turns out that more changes are required, and
This API is not stable enough yet to be exposed in the uAPI. Move it
to a kAPI header.
Regards,
Hans
The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0:
media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18
-0500)
are available in the Git
On Wed, Dec 05, 2018 at 04:15:17PM +0200, Sakari Ailus wrote:
> The device won't be powered off on systems that have no sensors connected
> unless it has a driver bound to it. Allow that to happen even if there are
> no sensors connected to cio2.
Thanks for sending this. It helps to put the pci
The device won't be powered off on systems that have no sensors connected
unless it has a driver bound to it. Allow that to happen even if there are
no sensors connected to cio2.
Signed-off-by: Sakari Ailus
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 3 ++-
1 file changed, 2 insertions(+), 1
On 11/30/18 18:34, Ezequiel Garcia wrote:
> Add a mem2mem driver for the VPU available on Rockchip SoCs.
> Currently only JPEG encoding is supported, for RK3399 and RK3288
> platforms.
>
> Signed-off-by: Ezequiel Garcia
> ---
> diff --git
On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote:
> Unless something unexpected happens, then v12 should be the final
> version and I'll make a pull request for it. Note that it will
> probably won't make 4.20, unless you manage to do it within the next
> hour :-)
Challenge accepted!
Add a mem2mem driver for the VPU available on Rockchip SoCs.
Currently only JPEG encoding is supported, for RK3399 and RK3288
platforms.
Signed-off-by: Ezequiel Garcia
---
Changes from v11:
* Fix buffer timecode
* Add a comment explaining dma attributes
* Fix wrong parenthesis
* Remove
g_mbus_config was supposed to indicate all supported lane numbers, not
only the number of those currently in active use. Since the TC358743
can dynamically reduce the number of active lanes if the required
bandwidth allows for it, report all lane numbers up to the connected
number of lanes as
Note regarding the first 'Revert' patch: that is this patch:
https://patchwork.linuxtv.org/patch/52869/
It is currently pending for 4.20 as a fix, but since it is not merged upstream
yet, our master branch still has those old bindings.
I decided to first apply the Revert patch, then add the new
Hi Hans,
On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote:
> On 11/30/18 18:34, Ezequiel Garcia wrote:
> > Add a mem2mem driver for the VPU available on Rockchip SoCs.
> > Currently only JPEG encoding is supported, for RK3399 and RK3288
> > platforms.
> >
> > Signed-off-by: Ezequiel Garcia
Temporarily use g_mbus_config() to determine the number of active data
lanes used by the transmitter. If g_mbus_config is not supported or
does not return the number of active lines, default to using all
connected data lines.
Signed-off-by: Philipp Zabel
Acked-by: Steve Longerbeam
---
Changes
tree: git://git.ragnatech.se/linux media-tree
head: da2c94c8f9739e4099ea3cfefc208fc721b22a9c
commit: b6973637c4cc842c1aa7d6c848781b4bdeb4415b [198/228] media: ddbridge:
remove another duplicate of io.h and sort includes
config: arm-allmodconfig (attached as .config)
compiler:
On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 5 Dec 2018 16:34:04 -0200
> Mauro Carvalho Chehab escreveu:
>
> > Em Wed, 5 Dec 2018 17:29:38 +0100
> > Hans Verkuil escreveu:
> >
> > > Note regarding the first 'Revert' patch: that is this patch:
> > >
> > >
As complained by gcc:
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c: In
function 'rk3288_vpu_jpeg_enc_set_qtable':
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:70:10:
warning: variable 'chroma_qtable_p' set but not used [-Wunused-but-set-variable]
As complained by gcc:
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c: In
function 'rk3288_vpu_jpeg_enc_set_qtable':
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c:70:10:
warning: variable 'chroma_qtable_p' set but not used [-Wunused-but-set-variable]
Em Wed, 05 Dec 2018 17:02:46 -0300
Ezequiel Garcia escreveu:
> On Wed, 2018-12-05 at 16:37 -0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 5 Dec 2018 16:34:04 -0200
> > Mauro Carvalho Chehab escreveu:
> >
> > > Em Wed, 5 Dec 2018 17:29:38 +0100
> > > Hans Verkuil escreveu:
> > >
> > > >
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv =
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Dec 6 05:00:13 CET 2018
media-tree git hash:3c28b91380dd1183347d32d87d820818031ebecf
media_build
Em Wed, 5 Dec 2018 16:56:39 -0200
Mauro Carvalho Chehab escreveu:
> Em Fri, 30 Nov 2018 15:58:07 +0100
> Andreas Pape escreveu:
>
> > Hi Kieran,
> >
> > thanks for the review.
> >
> > On Mon, 26 Nov 2018 12:48:08 +
> > Kieran Bingham wrote:
> >
> > > This one worries me a little...
The interrupt urb is killed but never freed add the function
Signed-off-by: Malcolm Priestley
---
v2 avoiding stale pointer in usb_free_coherent as per sean
drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c
Interrupt is always present throughout life time of driver and
there is no dma element move this buffer to private area of driver.
Signed-off-by: Malcolm Priestley
---
v2 removed the need for DMA transfer flags as per Sean
drivers/media/usb/dvb-usb-v2/lmedm04.c | 28 +-
Em Wed, 5 Dec 2018 19:48:25 +0100
Hans Verkuil escreveu:
> On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote:
> > As reported by checkpatch.pl, some function calls have a wrong
> > alignment.
> >
> > Signed-off-by: Mauro Carvalho Chehab
> > ---
> >
Em Wed, 5 Dec 2018 19:23:54 +0200
Sakari Ailus escreveu:
> The Request API is now merged to the kernel but the confidence on the
> stability of that API is not great, especially regarding the interaction
> with V4L2.
>
> Add a Kconfig option for the API, with a scary-looking warning.
>
> The
Em Wed, 5 Dec 2018 17:29:38 +0100
Hans Verkuil escreveu:
> Note regarding the first 'Revert' patch: that is this patch:
>
> https://patchwork.linuxtv.org/patch/52869/
>
> It is currently pending for 4.20 as a fix, but since it is not merged upstream
> yet, our master branch still has those old
Em Wed, 5 Dec 2018 16:34:04 -0200
Mauro Carvalho Chehab escreveu:
> Em Wed, 5 Dec 2018 17:29:38 +0100
> Hans Verkuil escreveu:
>
> > Note regarding the first 'Revert' patch: that is this patch:
> >
> > https://patchwork.linuxtv.org/patch/52869/
> >
> > It is currently pending for 4.20 as a
As reported by checkpatch.pl, some function calls have a wrong
alignment.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 ++--
drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 4 ++--
2 files changed, 4 insertions(+), 4
On 12/05/2018 07:43 PM, Mauro Carvalho Chehab wrote:
> As reported by checkpatch.pl, some function calls have a wrong
> alignment.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 ++--
>
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
> Hi Hans, Philipp,
>
> One comment on my side...
>
> On 12/3/18 7:21 AM, Hans Verkuil wrote:
>>
>>> +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
>>> +{
>>> + struct mem2mem_priv *priv = to_mem2mem_priv(vdev);
>>>
Em Fri, 30 Nov 2018 15:58:07 +0100
Andreas Pape escreveu:
> Hi Kieran,
>
> thanks for the review.
>
> On Mon, 26 Nov 2018 12:48:08 +
> Kieran Bingham wrote:
>
> > This one worries me a little... (but hopefully not too much)
> >
>
> As mentioned, I don't have any experience concerning
The Request API is now merged to the kernel but the confidence on the
stability of that API is not great, especially regarding the interaction
with V4L2.
Add a Kconfig option for the API, with a scary-looking warning.
The patch itself disables request creation as well as does not advertise
them
54 matches
Mail list logo
