Re: tcm825x.c: migrating to sub-device framework?

2009-06-15 Thread Sakari Ailus
Hans Verkuil wrote: On Sunday 14 June 2009 14:44:53 Hans Verkuil wrote: On Sunday 14 June 2009 12:14:38 Hans Verkuil wrote: On Wednesday 06 May 2009 20:31:33 hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com This patch converts TVP514x driver to sub-device framework from V4L2-int

Re: dib3000mc.c and dib7000p.c compiler warnings

2009-06-15 Thread Patrick Boettcher
Hi Hans, On Sun, 14 Jun 2009, Hans Verkuil wrote: Hi Patrick, The daily build reports these warnings for dib3000mc.c and dib7000p.c: /marune/build/v4l-dvb-master/v4l/dib3000mc.c: In function 'dib3000mc_i2c_enumeration': /marune/build/v4l-dvb-master/v4l/dib3000mc.c:863: warning: the frame size

Re: Fwd: [PATCH 2/2] uvc: Added two webcams with 'No FID' quirk.

2009-06-15 Thread Laurent Pinchart
On Friday 12 June 2009 18:53:29 Robert Krakora wrote: From: Robert Krakora rob.krak...@messagenetsystems.com Added two webcams with 'No FID' quirk. Priority: normal Signed-off-by: Robert Krakora rob.krak...@messagenetsystems.com diff -r bff77ec33116

Re: [PATCH 1/2] uvc: Fix for no return value check of uvc_ctrl_set() which calls mutex_lock_interruptible()

2009-06-15 Thread Laurent Pinchart
On Friday 12 June 2009 18:51:03 Robert Krakora wrote: From: Robert Krakora rob.krak...@messagenetsystems.com Fix for no return value check of uvc_ctrl_set() which calls mutex_lock_interruptible(). Priority: normal Signed-off-by: Robert Krakora rob.krak...@messagenetsystems.com Acked-by:

RFC: remove video_register_device_index, add video_register_device_range

2009-06-15 Thread Hans Verkuil
Hi all, While looking at the video_register_device changes that broke ov511 I realized that the video_register_device_index function is never called from drivers. It will always assign a default index number. I also don't see a good use-case for giving it an explicit index. My proposal is to

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-15 Thread Hans Verkuil
On Sunday 14 June 2009 12:15:34 Hans Verkuil wrote: On Sunday 14 June 2009 11:50:51 Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc for the following: - ivtv/cx18: fix regression: class controls are no longer seen - v4l2-ctl: add

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-06-15 Thread Mauro Carvalho Chehab
Em Thu, 11 Jun 2009 15:35:14 -0700 (PDT) Trent Piepho xy...@speakeasy.org escreveu: On Thu, 11 Jun 2009, Patrick Boettcher wrote: On Wed, 27 May 2009, Trent Piepho wrote: On Tue, 26 May 2009, Patrick Boettcher wrote: Does this patch to fix these problems look ok? In fact, everything

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-06-15 Thread Patrick Boettcher
Hi Mauro, On Mon, 15 Jun 2009, Mauro Carvalho Chehab wrote: Em Thu, 11 Jun 2009 15:35:14 -0700 (PDT) Trent Piepho xy...@speakeasy.org escreveu: On Thu, 11 Jun 2009, Patrick Boettcher wrote: On Wed, 27 May 2009, Trent Piepho wrote: On Tue, 26 May 2009, Patrick Boettcher wrote: Does this

Re: [PATCH V2] poll method lose race condition

2009-06-15 Thread Figo.zhang
hi Mauro, is it ok for this v2? Best Regards, Figo.zhang 2009/6/1 Figo.zhang figo1...@gmail.com bttv-driver.c,cx23885-video.c,cx88-video.c: poll method lose race condition for capture video. In v2, use the clear logic.Thanks to Trent Piepho's help.

Re: RFC: remove video_register_device_index, add video_register_device_range

2009-06-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Jun 2009 13:25:28 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi all, While looking at the video_register_device changes that broke ov511 I realized that the video_register_device_index function is never called from drivers. It will always assign a default index number. I

Re: RFC: remove video_register_device_index, add video_register_device_range

2009-06-15 Thread Hans Verkuil
On Monday 15 June 2009 15:44:21 Mauro Carvalho Chehab wrote: Em Mon, 15 Jun 2009 13:25:28 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Hi all, While looking at the video_register_device changes that broke ov511 I realized that the video_register_device_index function is never

[PATCH] soc-camera: ov7670 merged multiple drivers and moved over to v4l2-subdev

2009-06-15 Thread Jonathan Cameron
From: Jonathan Cameron ji...@cam.ac.uk OV7670 soc-camera driver. Merge of drivers from Jonathan Corbet, Darius Augulis and Jonathan Cameron Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- This is my first cut at a merge of the various ov7670 drivers to work with Guennadi Liakhovetski's work

Re: s5h1411_readreg: readreg error (ret == -5)

2009-06-15 Thread Steven Toth
hermann pitton wrote: [snip] The most undiscovered configurations seem to be such ones about antenna inputs and their switching. Again according to Hartmut, and he did not know exactly what is going on here, some for us and him at this point unknown checksums are used to derive even that

[RESEND][PATCH] video: Initial support for ADV7180

2009-06-15 Thread Richard Röjfors
This is an initial driver for Analog Devices ADV7180 Video Decoder. So far it only supports query standard. Signed-off-by: Richard Röjfors richard.rojfors@mocean-labs.com --- Index: linux-2.6.30-rc7/drivers/media/video/adv7180.c

Re: [PULL] http://linuxtv.org/hg/~dougsland/em28xx/

2009-06-15 Thread Franklin Meng
Just wanted to thank Douglas Landgraf for the help he provided me with getting the em28xx driver working with the Kworld 315U tuner device (digital only at this time). As time permits, I hope to get the analog inputs and tuner to work too (if anyone want to help please let me know). Thanks,

RE: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-15 Thread Karicheri, Muralidharan
+ +struct v4l2_subdev_bus { +       enum v4l2_subdev_bus_type type; +       u8 width; +       /* 0 - active low, 1 - active high */ +       unsigned pol_vsync:1; +       /* 0 - active low, 1 - active high */ +       unsigned pol_hsync:1; +       /* 0 - low to high , 1 - high to low */ +  

Re: [PATCH] zr364xx.c: vfree does its own NULL check

2009-06-15 Thread Figo.zhang
hi Mauro, is it ok for this patch? Best Regards, Figo.zhang On Sat, 2009-06-06 at 17:16 +0800, Figo.zhang wrote: vfree() does it's own NULL checking, no need for explicit check before calling it. Signed-off-by: Figo.zhang figo1...@gmail.com --- drivers/media/video/zr364xx.c |6

[PATCH] soc_camera: Fix debug output of supported formats count

2009-06-15 Thread Stefan Herbrechtsmeier
The supported formats count must be set to 0 after debug output right before the second pass. Signed-off-by: Stefan Herbrechtsmeier hbme...@hni.uni-paderborn.de diff --git a/linux/drivers/media/video/soc_camera.c b/linux/drivers/media/video/soc_camera.c ---

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
Hans, Thanks for your review. I will get back to you if I need more information on your comments. You have reviewed the following patches in this series... 1,7,8,10 Following are part of this series which requires review as well. [PATCH 2/10 - v2] ccdc hw device header file for vpfe capture

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-15 Thread Karicheri, Muralidharan
+       /* set the default image parameters in the device */ +       ret = vpfe_config_image_format(vpfe_dev, +                               vpfe_standards[vpfe_dev- std_index].std_id); +       if (ret) +               goto unlock_out; Why you check ret value and go to label below? Probably

RE: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-15 Thread Karicheri, Muralidharan
= dm644x_clear_wbl_overflow; +       else +               return -ENODEV; Do you need clean up procedure if you return error here? I mean - calls to release_mem_region, release_mem_region, etc Oops! I need to add that. Thanks. +       spin_lock_init(oper_cfg.vpss_lock); +      

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
On Monday 15 June 2009 18:24:53 Karicheri, Muralidharan wrote: Hans, Thanks for your review. I will get back to you if I need more information on your comments. You have reviewed the following patches in this series... 1,7,8,10 Those were the only ones I had any comments on. So I'm happy

[cron job] v4l-dvb daily build 2.6.22 and up: WARNINGS, 2.6.16-2.6.21: ERRORS

2009-06-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Jun 15 19:00:04 CEST 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 11975:144d8d0cebc5 gcc version: gcc

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
Hans, That is great! Once I change the code based on the comments, do you think there is a chance to get the driver to be merged to 2.6.31 (If so, how soon should I be ready with the next version, v3 of the patch) or do we need to wait until 2.6.32? Regards, Murali Karicheri Software Design

Re: [PATCH] zl10353 and qt1010: fix stack corruption bug

2009-06-15 Thread Antti Palosaari
Hei Jan, On 06/10/2009 09:21 AM, Jan Nikitenko wrote: This patch fixes stack corruption bug present in dump_regs function of zl10353 and qt1010 drivers: the buffer buf is one byte smaller than required - there is 4 chars for address prefix, 16*3 chars for dump of 16 eeprom bytes per line and 1

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-15 Thread Mauro Carvalho Chehab
Hi Hans, Em Mon, 15 Jun 2009 13:27:42 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sunday 14 June 2009 12:15:34 Hans Verkuil wrote: On Sunday 14 June 2009 11:50:51 Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc for the

Re: RFC: remove video_register_device_index, add video_register_device_range

2009-06-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Jun 2009 16:02:40 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: The sticking point for me is that warning since for cx18/ivtv it is OK if you get something else then you specified (since it is a starting index meant to distinguish mpeg encoders from raw video inputs, from mpeg

TT-S1500 budget-ci registeration

2009-06-15 Thread Thomas Kernen
Hello to all, I'm currently testing a TT-S1500 budget card with the TT budget CI adapter with vl4 tree and kernel 2.6.28. When I modprobe budget_ci, the CI adapter seems to be detected but not registered in /dev/dvb/adapter3/ca0 as I would have expected it to be. Instead I see the

Re: GPL code for Omnivision USB video camera available.

2009-06-15 Thread Hans de Goede
On 06/15/2009 03:01 AM, Erik de Castro Lopo wrote: On Sat, 13 Jun 2009 18:12:10 +1000 Hans de Goedehdego...@redhat.com wrote: Getting ovfx2 support into the mainline kernel sounds like a good idea! I'm not such a big fan of merging the driver as is though, as it does its own buffer

Re: RFC: remove video_register_device_index, add video_register_device_range

2009-06-15 Thread Hans Verkuil
On Monday 15 June 2009 21:51:13 Mauro Carvalho Chehab wrote: Em Mon, 15 Jun 2009 16:02:40 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: The sticking point for me is that warning since for cx18/ivtv it is OK if you get something else then you specified (since it is a starting index

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-15 Thread Hans Verkuil
On Monday 15 June 2009 21:48:32 Mauro Carvalho Chehab wrote: Hi Hans, Em Mon, 15 Jun 2009 13:27:42 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sunday 14 June 2009 12:15:34 Hans Verkuil wrote: On Sunday 14 June 2009 11:50:51 Hans Verkuil wrote: Hi Mauro, Please pull

Re: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Hans Verkuil
On Monday 15 June 2009 20:44:15 Karicheri, Muralidharan wrote: Hans, That is great! Once I change the code based on the comments, do you think there is a chance to get the driver to be merged to 2.6.31 (If so, how soon should I be ready with the next version, v3 of the patch) or do we need

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-15 Thread Karicheri, Muralidharan
Hans, I am not clear about some of your comments. Please see below with a [MK] prefix. +static int debug; +static u32 numbuffers = 3; +static u32 bufsize = (720 * 576 * 2); + +module_param(numbuffers, uint, S_IRUGO); +module_param(bufsize, uint, S_IRUGO); +module_param(debug, int, 0644);

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
Hans, I will do my best to push v3 of this patch this week. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Monday, June 15, 2009

Re: TT-S1500 budget-ci registeration

2009-06-15 Thread Thomas Kernen
Thomas Kernen wrote: Hello to all, I'm currently testing a TT-S1500 budget card with the TT budget CI adapter with vl4 tree and kernel 2.6.28. When I modprobe budget_ci, the CI adapter seems to be detected but not registered in /dev/dvb/adapter3/ca0 as I would have expected it to be.

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-15 Thread Hans Verkuil
On Tuesday 16 June 2009 00:24:34 Karicheri, Muralidharan wrote: Hans, Please see my response below. snip A general remark: currently you link your inputs directly to a subdev. This approach has two disadvantages: 1) It doesn't work if there are no subdevs at all (e.g. because

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-15 Thread hermann pitton
Hi, Am Montag, den 15.06.2009, 23:35 +0200 schrieb Hans Verkuil: On Monday 15 June 2009 21:48:32 Mauro Carvalho Chehab wrote: Hi Hans, Em Mon, 15 Jun 2009 13:27:42 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On Sunday 14 June 2009 12:15:34 Hans Verkuil wrote: On Sunday 14

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Jun 2009 23:35:59 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: By looking on this patch, it is obfuscating the function even more. Creating more confusion on it, due to some reasons: 1) The name kernel number doesn't seem much appropriate. Any number used in kernel

[PATCH] FM1216MK5 FM radio patch

2009-06-15 Thread Dmitri Belimov
Hi Next code for implement Philips FM1216MK5. 1. Implement get_stereo function. 2. Add correct data byte for FM radio mode. diff -r bff77ec33116 linux/drivers/media/common/tuners/tuner-simple.c --- a/linux/drivers/media/common/tuners/tuner-simple.c Thu Jun 11 18:44:23 2009 -0300 +++

Re: [PULL] http://kernellabs.com/hg/~dheitmueller/em28xx-no-audio

2009-06-15 Thread Mauro Carvalho Chehab
Em Sun, 14 Jun 2009 20:30:18 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Hello Mauro, Please pull from http://kernellabs.com/hg/~dheitmueller/em28xx-no-audio for the following: - em28xx: don't create audio device if not supported This should correct the problems you

Re: [RESEND][PATCH] video: Initial support for ADV7180

2009-06-15 Thread Mauro Carvalho Chehab
Em Mon, 15 Jun 2009 17:13:28 +0200 Richard Röjfors richard.rojfors@mocean-labs.com escreveu: This is an initial driver for Analog Devices ADV7180 Video Decoder. So far it only supports query standard. Hmm... it seems too preliminar for merging. Also, as this is an i2c ancillary driver,

[PATCH 43/64] media: remove driver_data direct access of struct device

2009-06-15 Thread Greg Kroah-Hartman
In the near future, the driver core is going to not allow direct access to the driver_data pointer in struct device. Instead, the functions dev_get_drvdata() and dev_set_drvdata() should be used. These functions have been around since the beginning, so are backwards compatible with all older