Re: [PATCH] uvc: kmalloc failure ignored in uvc_ctrl_add_ctrl()

2009-09-24 Thread Laurent Pinchart
Hi Roel, thanks for noticing the problem and providing a patch. Some comments inlined. On Saturday 19 September 2009 03:13:37 Roel Kluin wrote: Produce an error if kmalloc() fails. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Found with sed: http://kernelnewbies.org/roelkluin

Re: [Linux-uvc-devel] [PATCH] uvc: kmalloc failure ignored in uvc_ctrl_add_ctrl()

2009-09-24 Thread Paulo Assis
Laurent, That's not enough to prevent a kernel crash. The driver can try to dereference ctrl-data if ctrl-info isn't NULL. You should only set ctrl-info if allocationg succeeds. Something like        ctrl-data = kmalloc(ctrl-info-size * UVC_CTRL_NDATA, GFP_KERNEL);        if (ctrl-data ==

PULL request - http://kernellabs.com/hg/~pboettcher/v4l-dvb/

2009-09-24 Thread Patrick Boettcher
Hi Mauro, please pull from http://kernellabs.com/hg/~pboettcher/v4l-dvb/ for - DiB7000P: improve rebostness of HAS_LOCK indicator - DiB0070: if module is not built, don't say function is extern - DIB0700: fix-up USB device ID for Terratec/Leadtek - dib8000: SNR in 10th of dB all of it should

[PATCH 1/2] media: video: pwc: Use kernel's simple_strtol()

2009-09-24 Thread Andy Shevchenko
From: Andy Shevchenko ext-andriy.shevche...@nokia.com Change own implementation of pwc_atoi() by simple_strtol(x, NULL, 10). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com Acked-by: Pekka Enberg penb...@cs.helsinki.fi --- drivers/media/video/pwc/pwc-if.c | 23

[PATCH 2/2] atoi: Drop custom atoi from drivers/video/modedb.c

2009-09-24 Thread Andy Shevchenko
From: Andy Shevchenko ext-andriy.shevche...@nokia.com Kernel has simple_strtol() implementation which could be used as atoi(). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com --- drivers/video/modedb.c | 24 +--- 1 files changed, 5 insertions(+), 19

Re: [PATCH 0/5] V4L2 patches for Intel Moorestown Camera Imaging

2009-09-24 Thread Yu, Jinlu
Hi, Hans/Guennadi I am modifying these drivers to comply with v4l2 framework. I have finished replacing our buffer managing code with utility function from videobuf-core.c and videobuf-dma-contig.c. Now I am working on the subdev. One thing I am sure is that each sensor should be registered as

Re: [PATCH 0/5] V4L2 patches for Intel Moorestown Camera Imaging

2009-09-24 Thread Mauro Carvalho Chehab
Em Thu, 24 Sep 2009 19:21:40 +0800 Yu, Jinlu jinlu...@intel.com escreveu: Hi, Hans/Guennadi I am modifying these drivers to comply with v4l2 framework. I have finished replacing our buffer managing code with utility function from videobuf-core.c and videobuf-dma-contig.c. Now I am working

RE: V4L-DVB Summit Day 1

2009-09-24 Thread Yu, Jinlu
About S_FMT, Moorestown Camera driver which I am working on has a different story. We do use different sensor resolutions, because high resolution has low FPS, and can not be used for view-finding, e.g. ov5630 only output 15fps with 5Mega resolution. Our current solution is to disable the

[PULL] http://www.linuxtv.org/hg/~dougsland/v4l-dvb

2009-09-24 Thread Douglas Schilling Landgraf
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: - radio-mr800: set radio frequency only upon success - radio-mr800: simplify device warnings - radio-mr800: preserve radio state during suspend/resume - radio-mr800: fix behavior of set_stereo

[RESEND PULL] http://udev.netup.ru/hg/v4l-dvb-aospan

2009-09-24 Thread Abylai Ospan
Mauro, Please pulll changes from: http://udev.netup.ru/hg/v4l-dvb-aospan/rev/711d9630876f Show speed of transport stream in Kbit/sec: for example, data obtained from DVB-S2 transponder from Eutelsat W4: Jun 27 12:06:01 udev TS speed 58608 Kbits/sec Jun 27 12:06:03 udev TS speed 58422 Kbits/sec

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2009-09-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Sep 24 19:00:03 CEST 2009 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 13041:a798c751f06d gcc version: gcc

Re: V4L-DVB Summit Day 1

2009-09-24 Thread Guennadi Liakhovetski
Hi Hans Thanks for keeping us updated. One comment: On Wed, 23 Sep 2009, Hans Verkuil wrote: In the afternoon we discussed the proposed timings API. There was no opposition to this API. The idea I had to also use this for sensor setup turned out to be based on a misconception on how the

Re: New device: Dikom DK-300 (maybe Kworld 323U rebranded)

2009-09-24 Thread xwang1976
The rapidshare link is no more accessible. Do you want me to put that file online again? Xwang xwang1...@email.it ha scritto: Is there any news? Xwang xwang1...@email.it ha scritto: Hi to all, I would like to know if the usbsnoop I have done under windows xp is ok or if, otherwise, I have to

Re: [PATCH 2/4] 18271_calc_main_pll small bugfix

2009-09-24 Thread Michael Krufky
On Tue, Sep 22, 2009 at 5:06 PM, s...@systol-ng.god.lan wrote: Removed code fragment that is not part of the (C2) specs. Possibly an early remnant of an attempted if_notch filter configuration. It is already handled correctly in the tda18271_set_if_notch function. Signed-off-by:

Re: [PATCH 1/4] tda18271_set_analog_params major bugfix

2009-09-24 Thread Michael Krufky
On Tue, Sep 22, 2009 at 5:05 PM, s...@systol-ng.god.lan wrote: Multiplication by 62500 causes an overflow in the 32 bits freq register when using radio. FM radio reception on a Zolid Hybrid PCI is now working. Other tda18271 configurations may also benefit from this change ;) Signed-off-by:

Re: [PATCH 3/4] tda8290 enable deemphasis_50 module parameter.

2009-09-24 Thread Michael Krufky
On Tue, Sep 22, 2009 at 5:07 PM, s...@systol-ng.god.lan wrote: This adds a forgotten module_param macro needed to set a deemphasis of 50us. It is the standard setting for commercial FM radio broadcasts outside the US. Signed-off-by: henk.vergo...@gmail.com diff -r 29e4ba1a09bc

Re: [PATCH 4/4] Zolid Hybrid PCI card add AGC control

2009-09-24 Thread Michael Krufky
On Tue, Sep 22, 2009 at 5:09 PM, s...@systol-ng.god.lan wrote: Switches IF AGC control via GPIO 21 of the saa7134. Improves DTV reception and FM radio reception. Signed-off-by: henk.vergo...@gmail.com Reviewed-by: Michael Krufky mkru...@kernellabs.com Henk, This is *very* interesting...

Re: [PATCH 4/4] Zolid Hybrid PCI card add AGC control

2009-09-24 Thread spam
On Thu, Sep 24, 2009 at 02:55:42PM -0400, Michael Krufky wrote: Henk, This is *very* interesting... Have you taken a scope to the board to measure AGC interference? This seems to be *very* similar to Hauppauge's design for the HVR1120 and HVR1150 boards, which are actually *not* based

Re: [PATCH 1/4] tda18271_set_analog_params major bugfix

2009-09-24 Thread spam
On Thu, Sep 24, 2009 at 02:46:06PM -0400, Michael Krufky wrote: On Tue, Sep 22, 2009 at 5:05 PM, s...@systol-ng.god.lan wrote: Multiplication by 62500 causes an overflow in the 32 bits freq register when using radio. FM radio reception on a Zolid Hybrid PCI is now working. Other

Re: [PULL] soc-camera 2.6.32: new driver and a compile-fix

2009-09-24 Thread Paul Mundt
On Wed, Sep 23, 2009 at 06:02:04PM +0200, Guennadi Liakhovetski wrote: On Wed, 23 Sep 2009, Guennadi Liakhovetski wrote: Hi Mauro The following two patches are for 2.6.32. One of them fixes sh_mobile_ceu_camera compile breakage, and another one adds a new soc-camera / v4l2-subdev

Re: [PULL] soc-camera 2.6.32: new driver and a compile-fix

2009-09-24 Thread Mauro Carvalho Chehab
Em Fri, 25 Sep 2009 11:52:19 +0900 Paul Mundt let...@linux-sh.org escreveu: On Wed, Sep 23, 2009 at 06:02:04PM +0200, Guennadi Liakhovetski wrote: On Wed, 23 Sep 2009, Guennadi Liakhovetski wrote: Hi Mauro The following two patches are for 2.6.32. One of them fixes

Re: [PULL] soc-camera 2.6.32: new driver and a compile-fix

2009-09-24 Thread Paul Mundt
On Fri, Sep 25, 2009 at 01:29:08AM -0300, Mauro Carvalho Chehab wrote: Em Fri, 25 Sep 2009 11:52:19 +0900 Paul Mundt let...@linux-sh.org escreveu: On Wed, Sep 23, 2009 at 06:02:04PM +0200, Guennadi Liakhovetski wrote: On Wed, 23 Sep 2009, Guennadi Liakhovetski wrote: Hi Mauro