[PATCH] pt1: Support FE_READ_SNR

2009-11-08 Thread hiranotaka
pt1: Support FE_READ_SNR Signed-off-by: HIRANO Takahito hiranot...@zng.info diff -r bb412b4e19a0 -r b386a38c7a1e linux/drivers/media/dvb/pt1/va1j5jf8007s.c --- a/linux/drivers/media/dvb/pt1/va1j5jf8007s.cSun Nov 01 03:59:42 2009 +0900 +++ b/linux/drivers/media/dvb/pt1/va1j5jf8007s.c

Re: pac7302: INFO: possible circular locking dependency detected

2009-11-08 Thread Hans de Goede
Hi, I've taken a long time to analyse the below lock dep report, and what can I say, it is nasty. This could happen (task could be a thread too): Task 1: Does a readdir on sysfs Task 1: Takes sysfs Mutex Task 2: Does an mmap on the video device Task 2: Takes mmap semphore Task 1: Is now stuck

Re: [PATCH] gspca pac7302: add edge detect control

2009-11-08 Thread Hans de Goede
Hi, On 11/07/2009 09:45 PM, Németh Márton wrote: From: Márton Némethnm...@freemail.hu Add edge detect control to pac7302 driver. When this control is turned on the camera image is switched to black and white and the edges are visualized. Bit 2 on page 0, register 0x55 controls this mode on

Re: [PATCH] gspca pac7302: add test pattern/overlay control

2009-11-08 Thread Hans de Goede
Hi, On 11/08/2009 12:05 AM, Németh Márton wrote: From: Márton Némethnm...@freemail.hu The Labtec Webcam 2200 (USB ID 093a:2626) device can produce some diagnostic patterns instead of the sensor image. An overlay test pattern also exsits which can be combined with the sensor image or with any

Re: pac7302: INFO: possible circular locking dependency detected

2009-11-08 Thread Németh Márton
Hi, Hans de Goede wrote: [snip] About the usb control msg errors, I don't think they are related to this issue at all, no real world app ever does a streamon and an mmap at the same time. As said if we could serialize mmap and ioctl at a high enough level, things would be fine too. I

[PATCH 1/2] gspca pac7302/pac7311: propagate error to higher level software

2009-11-08 Thread Németh Márton
From: Márton Németh nm...@freemail.hu The usb_control_msg() can fail any time. Only continue writing sequence if there was no error with the previous write. If there was any problem stop sending URBs and propagate the error to the gspca_main. Only the pac7302 driver was tested with Labtec Webcam

[PATCH 2/2] gspca pac7302: add debug register write interface

2009-11-08 Thread Németh Márton
From: Márton Németh nm...@freemail.hu Add debug register write interface to pac7302 to be able to set for example the edge detect mode (bit 2 register 0x55) or the test pattern (bit 0..3, register 0x72) and test overlay (bit 4, register 0x72) from the user space. Only write of register page 0 is

[PATCH] v4l2-dbg: report fail reason to the user

2009-11-08 Thread Németh Márton
From: Márton Németh nm...@freemail.hu Report the fail reason to the user when writing a register even if the verbose mode is switched off. Remove duplicated code ioctl() call which may cause different ioctl() function call in case of verbose and non verbose if not handled carefully.

libv4l problem decoding frames from pac7302

2009-11-08 Thread Németh Márton
Hi, I have some problem that libv4l cannot decode all image coming from the Labtec Webcam 2200. There are some cases when no image at all can be decoded. This case can be reproduced always for example by setting the camera to test mode to produce a color test bar. The raw data arrives from the

[PATCH] v4l: add more missing linux/sched.h includions

2009-11-08 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Unless there are objections, I'll be asking Mauro to pull this and one more patch later today. drivers/media/video/mx1_camera.c |1 + drivers/media/video/mx3_camera.c |1 +

[PATCH] soc-camera: properly initialise the device object when reusing

2009-11-08 Thread Guennadi Liakhovetski
Commit ef373189f62413803b7b816c972fc154c488cdc0 fix use-after-free Oops, resulting from a driver-core API change fixed the Oops, but didn't correct missing device object initialisation. This patch makes unloading and reloading of soc-camera host- and client-drivers possible again. Signed-off-by:

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sat, Nov 7, 2009 at 9:40 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: Hello Vince, I think the next step at this point is for you to definitively find a use case that does not work with the latest v4l-dvb tip and Robert's patch, and include exactly what kernel you tested with

Re: pac7302: INFO: possible circular locking dependency detected

2009-11-08 Thread Hans de Goede
Hi, On 11/08/2009 10:56 AM, Németh Márton wrote: Hi, Hans de Goede wrote: [snip] About the usb control msg errors, I don't think they are related to this issue at all, no real world app ever does a streamon and an mmap at the same time. As said if we could serialize mmap and ioctl at a

Re: bug in changeset 13239:54535665f94b ?

2009-11-08 Thread Johann Friedrichs
Mauro Carvalho Chehab schrieb: Hi Hartmut, Em Sun, 01 Nov 2009 16:59:26 +0100 e9hack e9h...@googlemail.com escreveu: Hi, something is wrong in changeset 13239:54535665f94b. After applying it, I get page faults in various applications: ... If I remove the call to release_all_pagetables() in

[PATCH 0/4] DVB: firedtv: port to new firewire driver stack

2009-11-08 Thread Stefan Richter
The following patch series adapts the firedtv driver for FireWire-attached DVB boxes and cards to the newer firewire-core kernel API. The driver will continue to work with the older ieee1394 kernel API as well. Which of the two IEEE 1394 stacks will be used depends on which one was configured at

[PATCH 1/4] firedtv: move remote control workqueue handling into rc source file

2009-11-08 Thread Stefan Richter
Preparation for the port of firedtv to the firewire-core kernel API: Canceling of the remote control workqueue job is factored into firedtv-rc.c. Plus trivial whitespace change. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c |5 +++--

[PATCH] gspca pac7311: stop sending URBs on first error

2009-11-08 Thread Németh Márton
From: Márton Németh nm...@freemail.hu It is no use to continue sending URBs if one of them already failed. Signed-off-by: Márton Németh nm...@freemail.hu --- The patch is based on 13335:3fd924da7091 from http://linuxtv.org/hg/~jfrancois/gspca/ . --- diff -r 3fd924da7091

[PATCH 2/4] firedtv: reform lock transaction backend call

2009-11-08 Thread Stefan Richter
Preparation for the port of firedtv to the firewire-core kernel API: The fdtv-backend-lock() hook and thus the CMP code is slightly changed to better fit with the new API. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c | 11 -

Re: [PATCH 2/2] gspca pac7302: add debug register write interface

2009-11-08 Thread Németh Márton
From: Márton Németh nm...@freemail.hu Add debug register write interface to pac7302 to be able to set for example the edge detect mode (bit 2 register 0x55) or the test pattern (bit 0..3, register 0x72) and test overlay (bit 4, register 0x72) from the user space. Only write of register page 0 is

[PATCH 3/4] firedtv: add missing include, rename a constant

2009-11-08 Thread Stefan Richter
Add #include dvb_demux.h for dvb_dmx_swfilter_packets(). This was already indirectly included via firedtv.h, but don't rely on it. The 4 bytes which were referred to as FIREWIRE_HEADER_SIZE are actually the source packet header from IEC 61883-4 (MPEG2-TS data transmission over 1394), not e.g.

[PATCH 4/4] firedtv: port to new firewire core

2009-11-08 Thread Stefan Richter
The firedtv DVB driver will now work not only on top of the old ieee1394 driver stack but also on the new firewire driver stack. Alongside to the firedtv-1394.c backend for driver binding and I/O, the firedtv-fw.c backend is added. Depending on which of the two 1394 stacks is configured, one or

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Vincent McIntyre
On 11/8/09, Devin Heitmueller dheitmuel...@kernellabs.com wrote: I think the next step at this point is for you to definitively find a use case that does not work with the latest v4l-dvb tip and Robert's patch, and include exactly what kernel you tested with and which board is having the

Re: [PATCH 10/75] V4L/DVB: declare MODULE_FIRMWARE for modules using XC2028 and XC3028L tuners

2009-11-08 Thread hermann pitton
Hi, Am Sonntag, den 08.11.2009, 01:20 -0200 schrieb Mauro Carvalho Chehab: Hi Ben, It's not clear to me what this MODULE_FIRMWARE is going to be used for, but if it's for some sort of module dependency system, then it definitely should *not* be a dependency for em28xx. There are lots

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 6:46 PM, Barry Williams bazzaw...@gmail.com wrote: Where would I find your local tree as I can't seem to get the patch to apply and I would like to take advantage of this patch asap. Thanks Barry I pushed out my tree with the fix:

Re: [PATCH 10/75] V4L/DVB: declare MODULE_FIRMWARE for modules using XC2028 and XC3028L tuners

2009-11-08 Thread Mauro Carvalho Chehab
Em Mon, 09 Nov 2009 00:32:29 +0100 hermann pitton hermann-pit...@arcor.de escreveu: I agree. An interesting case happens with devices that uses tda10046 DVB demods. They have the firmware stored internally on their eeprom. Those firmwares can be replaced by a different version loaded

[PATCH] v4l/scripts: Fix make checkpatch operation with in tree checkpatch.pl

2009-11-08 Thread Andy Walls
Mauro, make checkpatch wasn't working for me. I found that the new version of checkpatch.pl that's in the v4l/dvb tree doesn't emit a version number unless explicitly requested. This patch gets 'make checkpatch' working (and complaining again) for me. Regards, Andy Signed-off-by: Andy Walls

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
Devin Heitmueller wrote: On Sun, Nov 8, 2009 at 6:46 PM, Barry Williams bazzaw...@gmail.com wrote: Where would I find your local tree as I can't seem to get the patch to apply and I would like to take advantage of this patch asap. Thanks Barry I pushed out my tree with the fix:

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote: Hi Devin I tried your tree and I seem to get the same problem on one box I get the flood of 'dvb-usb: bulk message failed: -110 (1/0'. snip Can you please confirm the USB ID of the board you are having the problem with

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote: Hi Devin I tried your tree and I seem to get the same problem on one box I get the flood of 'dvb-usb: bulk message failed: -110 (1/0'.

Re: [PATCH 10/75] V4L/DVB: declare MODULE_FIRMWARE for modules using XC2028 and XC3028L tuners

2009-11-08 Thread hermann pitton
Am Sonntag, den 08.11.2009, 22:43 -0200 schrieb Mauro Carvalho Chehab: Em Mon, 09 Nov 2009 00:32:29 +0100 hermann pitton hermann-pit...@arcor.de escreveu: I agree. An interesting case happens with devices that uses tda10046 DVB demods. They have the firmware stored internally on

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Vincent McIntyre
Hi Barry, did you try cold-booting either system? how are you tuning? mythtv? Cheers Vince On 11/9/09, Barry Williams bazzaw...@gmail.com wrote: On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 9:01 PM, Barry Williams bazzaw...@gmail.com wrote: On the first box I have Bus 003 Device 003: ID 0fe9:db98 DVICO Bus 003 Device 002: ID 0fe9:db98 DVICO on the second Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4 (ZL10353+xc2028/xc3028)

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Robert Lowery
On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote: Hi Devin I tried your tree and I seem to get the same problem on one box I get the flood of 'dvb-usb: bulk message failed: -110

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 9:54 PM, Robert Lowery rglow...@exemail.com.au wrote: On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote: Hi Devin I tried your tree and I seem to get the same

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 1:04 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 9:01 PM, Barry Williams bazzaw...@gmail.com wrote: On the first box I have Bus 003 Device 003: ID 0fe9:db98 DVICO Bus 003 Device 002: ID 0fe9:db98 DVICO on the second Bus 001 Device

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 10:58 PM, Barry Williams bazzaw...@gmail.com wrote: Hi Devin I did not reboot after installing the patch somehow I thought simply removing the module (as I had done to restore some stability to my system) and reloading the module after the patch would be all I need.

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote: Devin Attached is the output from dmesg, I hope you're right Thanks Barry Ah, based on the dmesg I can see it wasn't what I thought it was (I saw it was dib7000 and improperly assumed it had an xc3028 tuner like the

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 3:17 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote: Devin Attached is the output from dmesg, I hope you're right Thanks Barry Ah, based on the dmesg I can see it wasn't what I thought

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 3:47 PM, Barry Williams bazzaw...@gmail.com wrote: On Mon, Nov 9, 2009 at 3:17 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote: Devin Attached is the output from dmesg, I hope you're