Re: [patch 2/7] drivers/media/video/pms.c needs version.h

2010-02-03 Thread Mauro Carvalho Chehab
a...@linux-foundation.org wrote: From: Andrew Morton a...@linux-foundation.org i386 allmodconfig: drivers/media/video/pms.c: In function 'pms_querycap': drivers/media/video/pms.c:682: error: implicit declaration of function 'KERNEL_VERSION' @@ -24,6 +24,7 @@ #include linux/delay.h

Re: [patch 1/7] drivers/media/video: move dereference after NULL test

2010-02-03 Thread Mauro Carvalho Chehab
Hi Julia, From: Julia Lawall ju...@diku.dk diff -puN drivers/media/video/davinci/vpif_display.c~drivers-media-video-move-dereference-after-null-test drivers/media/video/davinci/vpif_display.c ---

Re: [PATCH v2 00/10] add linux driver for chip TLG2300

2010-02-03 Thread Huang Shijie
Instead of a country code, the driver should use the V4L2_STD_ macros to If we are in the radio mode, I do not have any video standard, how can I choose the right audio setting in this situation? In the case of radio, the frequency ranges are controlled via the tuner Do

Re: [PATCH/RFC v2.1 0/2] Mem-to-mem device framework

2010-02-03 Thread Mauro Carvalho Chehab
Hiremath, Vaibhav wrote: -Original Message- From: Pawel Osciak [mailto:p.osc...@samsung.com] Sent: Monday, December 28, 2009 8:19 PM To: 'Hans Verkuil' Cc: linux-media@vger.kernel.org; linux-samsung-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Marek Szyprowski;

Re: [PATCH v2 00/10] add linux driver for chip TLG2300

2010-02-03 Thread Mauro Carvalho Chehab
Huang Shijie wrote: Instead of a country code, the driver should use the V4L2_STD_ macros to If we are in the radio mode, I do not have any video standard, how can I choose the right audio setting in this situation? In the case of radio, the frequency ranges are controlled

Re: [PATCH v2 00/10] add linux driver for chip TLG2300

2010-02-03 Thread Huang Shijie
The differences of FM radio standards are basically the preemphasis and the frequency ranges. For frequency ranges, V4L2_TUNER_RADIO allows specifying the maximum/minimum values. For preemphasis, you should implement V4L2_CID_TUNE_PREEMPHASIS ctrl. This CTRL has 3 states: static

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Mauro Carvalho Chehab
Hi Richard, Richard Röjfors wrote: The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board russelville. The driver is a PCI driver which chunks up the I/O memory and distributes interrupts to a number of platform devices for each IP inside the FPGA.

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Richard Röjfors
On 02/03/2010 10:16 AM, Mauro Carvalho Chehab wrote: Hi Richard, Richard Röjfors wrote: The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board russelville. The driver is a PCI driver which chunks up the I/O memory and distributes interrupts to a number of platform

Re: New DVB-Statistics API - please vote

2010-02-03 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab wrote: after the last thread which asked about signal statistics details degenerated into a discussion about the technical possibilites for implementing an entirely new API, which lead to nothing so far, I wanted to open a new thread to bring this forward. Maybe some

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Mauro Carvalho Chehab
Richard Röjfors wrote: On 02/03/2010 10:16 AM, Mauro Carvalho Chehab wrote: Hi Richard, Richard Röjfors wrote: The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board russelville. The driver is a PCI driver which chunks up the I/O memory and distributes

Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile

2010-02-03 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: On Wednesday 27 January 2010 17:22:10 Richard Röjfors wrote: This patch adds radio-timb to the Makefile and Kconfig. +config RADIO_TIMBERDALE +tristate Enable the Timberdale radio driver +depends on MFD_TIMBERDALE VIDEO_V4L2 HAS_IOMEM I think you need a

Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile

2010-02-03 Thread Mauro Carvalho Chehab
Richard Röjfors wrote: This patch adds radio-timb to the Makefile and Kconfig. On your next submission, please fold with patch 1/2. Signed-off-by: Richard Röjfors richard.rojf...@pelagicore.com --- diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Samuel Ortiz
Hi Mauro, On Wed, Feb 03, 2010 at 09:16:07AM +, Mauro Carvalho Chehab wrote: Hi Richard, Richard Röjfors wrote: The timberdale FPGA is found on the Intel in-Vehicle Infotainment reference board russelville. The driver is a PCI driver which chunks up the I/O memory and

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Mauro Carvalho Chehab
Samuel Ortiz wrote: I'm not sure how to deal with this patch. It doesn't contain anything related to V4L2 inside it, nor it applies to drivers/media, but it depends on the radio-timb driver that you submitted us. Actually, there are no build dependencies between those 2 drivers, which is

Re: New DVB-Statistics API - please vote

2010-02-03 Thread Hans Verkuil
Mauro Carvalho Chehab wrote: after the last thread which asked about signal statistics details degenerated into a discussion about the technical possibilites for implementing an entirely new API, which lead to nothing so far, I wanted to open a new thread to bring this forward. Maybe some

Re: [RESEND PATCH] ir-kbd-i2c: Allow to disable Hauppauge filter through module parameter

2010-02-03 Thread Mauro Carvalho Chehab
Hi Samuel, Samuel Rakitnican wrote: Some Hauppauge devices have id=0 so such devices won't work. For such devices add a module parameter that allow to turn off filtering. Signed-off-by: Samuel Rakitničan semiroc...@gmail.com Instead of a modprobe parameter, the proper fix is to make the

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2010-02-03 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: Hi Mauro, On Fri, 29 Jan 2010, Hans Verkuil wrote: (resent: forgot to mail it to the linux-media list) Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the following: - saa7134: remove stray unlock_kernel This is a high-prio bugfix that

Re: [HG PULL] http://linuxtv.org/hg/~awalls/v4l-dvb-bug

2010-02-03 Thread Mauro Carvalho Chehab
Andy Walls wrote: On Mon, 2010-02-01 at 16:45 -0200, Mauro Carvalho Chehab wrote: Andy Walls wrote: Mauro, Please pull from http://linuxtv.org/hg/~awalls/v4l-dvb-bug for the following 5 *high priority* changesets: Hmm... I don't think cx18 alsa code went to 2.3.33. That may explain why

Re: [PULL] http://linuxtv.org/hg/~jfrancois/v4l-dvb/

2010-02-03 Thread Mauro Carvalho Chehab
Em 01-02-2010 17:32, Hans de Goede escreveu: Hi, On 02/01/2010 07:36 PM, Mauro Carvalho Chehab wrote: Jean-Francois Moine wrote: Hi Douglas, I believe it is you to whom the pull requests must be addressed. In fact, the current workflow is different: I'll handle all patches (except for

Re: [patch 1/7] drivers/media/video: move dereference after NULL test

2010-02-03 Thread Julia Lawall
On Wed, 3 Feb 2010, Mauro Carvalho Chehab wrote: Hi Julia, From: Julia Lawall ju...@diku.dk diff -puN drivers/media/video/davinci/vpif_display.c~drivers-media-video-move-dereference-after-null-test drivers/media/video/davinci/vpif_display.c ---

Re: [PULL] http://linuxtv.org/hg/~jfrancois/v4l-dvb/

2010-02-03 Thread Mauro Carvalho Chehab
Hans de Goede wrote: Hi, On 02/01/2010 07:36 PM, Mauro Carvalho Chehab wrote: Jean-Francois Moine wrote: Hi Douglas, I believe it is you to whom the pull requests must be addressed. In fact, the current workflow is different: I'll handle all patches (except for those that are pure

Re: [PATCH] mfd: Add support for the timberdale FPGA.

2010-02-03 Thread Samuel Ortiz
On Wed, Feb 03, 2010 at 10:18:17AM +, Mauro Carvalho Chehab wrote: Samuel Ortiz wrote: I'm going to review this patch right now. Typically, mfd core drivers and their subdevices are submitted as a patchset via my tree, because the subdevices drivers have dependencies with the core. The

Re: New DVB-Statistics API - please vote

2010-02-03 Thread Manu Abraham
On Wed, Feb 3, 2010 at 2:40 PM, Hans Verkuil hverk...@xs4all.nl wrote: Mauro Carvalho Chehab wrote: after the last thread which asked about signal statistics details degenerated into a discussion about the technical possibilites for implementing an entirely new API, which lead to nothing so

[PATCH v3 0/1] radio: Add radio-timb

2010-02-03 Thread Richard Röjfors
On the intel russellville board there is a radio DSP, radio tuner and a RDS block. This umbrella driver uses two subdevs (DSP and tuner). Since v2, the RDS support has been removed from the patch. The current API in V4L2 and the simplicity of the Radio DSP makes it a bit complicated to

[PATCH v3 1/1] radio: Add radio-timb

2010-02-03 Thread Richard Röjfors
This patch add supports for the radio system on the Intel Russellville board. It's a In-Vehicle Infotainment board with a radio tuner and DSP. This umbrella driver has the DSP and tuner as V4L2 subdevs and calls them when needed. Signed-off-by: Richard Röjfors richard.rojf...@pelagicore.com

Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2010-02-03 Thread Janne Grunau
Hej, On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: Janne Grunau wrote: On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: Error handling code following a kzalloc should free the allocated data. Thanks for the report. I'll commit a different patch

Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree

2010-02-03 Thread Mauro Carvalho Chehab
Janne Grunau wrote: Hej, On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: Janne Grunau wrote: On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: Error handling code following a kzalloc should free the allocated data. Thanks for the report. I'll commit a

Re: [PATCH] hdpvr-video: cleanup signedness

2010-02-03 Thread Janne Grunau
On Sat, Jan 23, 2010 at 02:44:34PM +0100, Németh Márton wrote: From: Márton Németh nm...@freemail.hu The fifth parameter of usb_bulk_msg() is a pointer to signed (see linux/usb.h) so also call this function with pointer to signed. This will remove the following sparse warning (see make

Re: [PATCH v3 1/1] radio: Add radio-timb

2010-02-03 Thread Hans Verkuil
Hi Richard, On Wed, 3 Feb 2010, Richard R?jfors wrote: This patch add supports for the radio system on the Intel Russellville board. It's a In-Vehicle Infotainment board with a radio tuner and DSP. This umbrella driver has the DSP and tuner as V4L2 subdevs and calls them when needed.

[GIT PULL] V4L HD PVR updates

2010-02-03 Thread Janne Grunau
Hi Mauro, please pull from git://git.jannau.net/linux hdpvr for following patches: Janne Grunau (1): V4L/DVB: hdpvr: add new USB product id Márton Németh (2): hdpvr-video: cleanup signedness hdpvr-core: make module parameters local drivers/media/video/hdpvr/hdpvr-core.c |

Re: [GIT PULL] V4L HD PVR updates

2010-02-03 Thread Mauro Carvalho Chehab
Janne Grunau wrote: Hi Mauro, please pull from git://git.jannau.net/linux hdpvr Didn't work: $ git pull git://git.jannau.net/linux fatal: The remote end hung up unexpectedly I can see via the web interface, but the git method is not working. pulling via http is also broken: $ git pull

Re: Any saa711x users out there?

2010-02-03 Thread Devin Heitmueller
On Tue, Feb 2, 2010 at 7:29 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The better is to allow enabling/disabling the anti-alias via ctrl. Whatever default is chosen, the driver may adjust the control default at the board initialization, or even blocking the control when the other mode

Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init()

2010-02-03 Thread roel kluin
On Tue, Feb 2, 2010 at 3:29 PM, Oliver Neukum oli...@neukum.org wrote: Am Dienstag, 2. Februar 2010 15:29:46 schrieb Roel Kluin: If in a cold state and the download succeeded ret is zero, but we should return -ENOMEM. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Or shouldn't we? We

Re: [PATCH v4] radio: Add radio-timb

2010-02-03 Thread Hans Verkuil
Hi Richard, Looks good to me! Reviewed-by: Hans Verkuil hverk...@xs4all.nl Regards, Hans This patch add supports for the radio system on the Intel Russellville board. It's a In-Vehicle Infotainment board with a radio tuner and DSP. This umbrella driver has the DSP and tuner as

Re: git problem with uvcvideo

2010-02-03 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab wrote: However, the html URL is currently broken: $ rm -rf uvcvideo/ git clone -l --bare /git/linux-2.6.git/ uvcvideo cd uvcvideo git remote add uvcvideo http://linuxtv.org/git/pinchartl/uvcvideo.git git remote update Initialized empty Git repository in

Re: Any saa711x users out there?

2010-02-03 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: On Tue, Feb 2, 2010 at 7:29 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The better is to allow enabling/disabling the anti-alias via ctrl. Whatever default is chosen, the driver may adjust the control default at the board initialization, or even blocking the

[PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene for the following 20 changesets: 01/20: ngene: Initial check-in http://endr...@linuxtv.org/hg/~endriss/ngene?cmd=changeset;node=643e6259c1e1 02/20: ngene: Driver compiles now

RE: [PATCH v3 6/6] DaVinci - Adding platform board changes for vpfe capture on DM365

2010-02-03 Thread Karicheri, Muralidharan
Kevin, Please respond by today if you have any comments against this patch so that I can add it to my development repository at linuxtv.org and ask Mauro to pull this to your tree. As we are approaching the merge window for 2.6.34 and so many patches pending to be merged to 2.6.34, I would

Re: DM1105: could not attach frontend 195d:1105

2010-02-03 Thread Igor M. Liplianin
On 3 февраля 2010 00:07:36 Nameer Kazzaz wrote: Nameer Kazzaz wrote: Igor M. Liplianin wrote: On 2 февраля 2010 17:21:46 Nameer Kazzaz wrote: Hi Igor, What do you think ? if I can help you solve this, let me know what I can do. Thanks Nameer Nameer Kazzaz wrote: Hi

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-02-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Feb 3 19:00:04 CET 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14108:556072389bd6 gcc version:

[PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()

2010-02-03 Thread Roel Kluin
The -EINVAL was overwritten by the si470x_disconnect_check(). Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Is this needed? diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c index 4da0f15..65b4a92 100644 ---

Re: [PATCH 1/15] - tm6000 build hunk

2010-02-03 Thread Stefan Ringel
--- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -32,7 +32,7 @@ #include tm6000.h #include tm6000-regs.h #include tuner-xc2028.h -#include tuner-xc5000.h +#include xc5000.h #define TM6000_BOARD_UNKNOWN0 #define TM5600_BOARD_GENERIC

[PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -44,6 +44,10 @@ #define TM6000_BOARD_FREECOM_AND_SIMILAR7 #define TM6000_BOARD_ADSTECH_MINI_DUAL_TV8 #define TM6010_BOARD_HAUPPAUGE_900H

Re: [PATCH 1/15] - tm6000 build hunk

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: OK, patch is correct, but you should: - Use the email subject to summarize what the patch does - Add more detailed patch description; - Add your Signed-off-by. In this specific case, you could have: Subject: Fix compilation breakage Signed-off-by: your name y...@email

[PATCH 4/15] - tm6000.h

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000.h +++ b/drivers/staging/tm6000/tm6000.h @@ -90,12 +97,14 @@ enum tm6000_core_state { DEV_MISCONFIGURED = 0x04, }; +#if 1 /* io methods */ enum tm6000_io_method { IO_NONE, IO_READ,

[PATCH 5/15] - tm6000 bugfix i2c transfer

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-i2c.c +++ b/drivers/staging/tm6000/tm6000-i2c.c @@ -86,6 +86,11 @@ static int tm6000_i2c_xfer(struct i2c_adapter *i2c_adap, msgs[i].len == 1 ? 0 : msgs[i].buf[1], msgs[i +

Re: [PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de Signed-off-by: (first letter is on upper case) The patch looks ok to my eyes. --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -44,6 +44,10 @@ #define

[PATCH 7/15] - tm6000

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000.h +++ b/drivers/staging/tm6000/tm6000.h @@ -23,12 +23,15 @@ // Use the tm6000-hack, instead of the proper initialization code //#define HACK 1 +#include compat.h #include linux/videodev2.h #include

Re: [PATCH 3/15] - tm6000 bugfix hunk in init_dev

2010-02-03 Thread Mauro Carvalho Chehab
This is too generic: tm6000 bugfix hunk in init_dev A better subject would be: [PATCH 3/15] tm6000: avoid unregister the driver after success at tm6000_init_dev PS.: don't mind to re-submit those patches where just the subject has troubles. I'll fix it locally. I'm pointing the issues to

Re: [PATCH 2/15] - tm6000 bugfix

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -459,13 +506,13 @@ static int tm6000_usb_probe(struct usb_interface *interface, /* Check to see next free device and mark as used */

Re: [PATCH 4/15] - tm6000.h

2010-02-03 Thread Mauro Carvalho Chehab
This one is a very obscure patch. What are you doing this patch and why? Stefan Ringel wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000.h +++ b/drivers/staging/tm6000/tm6000.h @@ -90,12 +97,14 @@ enum tm6000_core_state { DEV_MISCONFIGURED

[PATCH 9/15] - tm6000 analog digital switch

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/common/tuners/tuner-xc2028.c +++ b/drivers/media/common/tuners/tuner-xc2028.c @@ -15,6 +15,7 @@ #include linux/delay.h #include media/tuner.h #include linux/mutex.h +#include compat.h #include asm/unaligned.h #include

[PATCH 2/15] - tm6000 add digital init for tm6010

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-core.c +++ b/drivers/staging/tm6000/tm6000-core.c @@ -219,33 +219,53 @@ int tm6000_init_analog_mode (struct tm6000_core *dev) int tm6000_init_digital_mode (struct tm6000_core *dev) { - tm6000_set_reg

[PATCH 11/15] - tm6000 add init for tm6010

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-core.c +++ b/drivers/staging/tm6000/tm6000-core.c @@ -394,7 +414,15 @@ struct reg_init tm6010_init_tab[] = { { REQ_07_SET_GET_AVREG, 0x3f, 0x00 }, { REQ_05_SET_GET_USBREG, 0x18, 0x00 }, - + +

[PATCH 12/15] - tm6000 bugfix tuner reset time and tuner param

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -221,12 +239,13 @@ struct usb_device_id tm6000_id_table [] = { { USB_DEVICE(0x2040, 0x6600), .driver_info = TM6010_BOARD_HAUPPAUGE_900H }, {

[PATCH 13/15] - xc2028 bugfix for firmware 3.6 - Zarlink use without shift in DTV8 or DTV78

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/common/tuners/tuner-xc2028.c +++ b/drivers/media/common/tuners/tuner-xc2028.c @@ -1114,7 +1122,11 @@ static int xc2028_set_params(struct dvb_frontend *fe, /* All S-code tables need a 200kHz shift */ if

[PATCH 14/15] - zl10353

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/dvb/frontends/zl10353.h +++ b/drivers/media/dvb/frontends/zl10353.h @@ -45,6 +45,8 @@ struct zl10353_config /* clock control registers (0x51-0x54) */ u8 clock_ctl_1; /* default: 0x46 */ u8 pll_0;

Re: [PATCH 9/15] - tm6000 analog digital switch

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: @@ -994,6 +995,13 @@ static int generic_set_freq(struct dvb_frontend *fe, u32 freq /* in HZ */, Your emailer is damaging the patches. The above should be in the same line, otherwise the patch won't apply. It seems that you're using Thunderbird, right? User-Agent:

Re: [linux-dvb] Twinhan dtv 3030 mantis

2010-02-03 Thread listor
Hi, Starting with 2.6.33 the mantis driver is included in mainline kernel. I have a pre5 installation that works great. I run *buntu 9.10 as well but when I saw that the kernel had mantis support I compiled my own. Just remember to add mantis as a kernel module, it's not on by default. Jakob

[PATCH 15/15] - tm6000 hack with different demodulator parameter

2010-02-03 Thread Stefan Ringel
signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/hack.c +++ b/drivers/staging/tm6000/hack.c @@ -37,7 +37,6 @@ static inline int tm6000_snd_control_msg(struct tm6000_core *dev, __u8 request, static int pseudo_zl10353_pll(struct tm6000_core *tm6000_dev, struct

Re: [PATCH 13/15] - xc2028 bugfix for firmware 3.6 - Zarlink use without shift in DTV8 or DTV78

2010-02-03 Thread Devin Heitmueller
On Wed, Feb 3, 2010 at 3:36 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/common/tuners/tuner-xc2028.c +++ b/drivers/media/common/tuners/tuner-xc2028.c @@ -1114,7 +1122,11 @@ static int xc2028_set_params(struct

Re: [PATCH 15/15] - tm6000 hack with different demodulator parameter

2010-02-03 Thread Devin Heitmueller
On Wed, Feb 3, 2010 at 3:40 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/hack.c +++ b/drivers/staging/tm6000/hack.c snip This patch shouldn't be merged at all. You should figure out the correct zl10353_config

Re: [PATCH 14/15] - zl10353

2010-02-03 Thread Devin Heitmueller
On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/dvb/frontends/zl10353.h +++ b/drivers/media/dvb/frontends/zl10353.h @@ -45,6 +45,8 @@ struct zl10353_config        /* clock control registers

Re: [PATCH 4/15] - tm6000.h

2010-02-03 Thread Stefan Ringel
Am 03.02.2010 21:25, schrieb Mauro Carvalho Chehab: This one is a very obscure patch. What are you doing this patch and why? Stefan Ringel wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000.h +++ b/drivers/staging/tm6000/tm6000.h @@ -90,12

Re: [PATCH 12/15] - tm6000 bugfix tuner reset time and tuner param

2010-02-03 Thread Devin Heitmueller
On Wed, Feb 3, 2010 at 3:31 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -221,12 +239,13 @@ struct usb_device_id tm6000_id_table [] = {     {

Re: [PATCH 9/15] - tm6000 analog digital switch

2010-02-03 Thread Stefan Ringel
Am 03.02.2010 21:40, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: @@ -994,6 +995,13 @@ static int generic_set_freq(struct dvb_frontend *fe, u32 freq /* in HZ */, Your emailer is damaging the patches. The above should be in the same line, otherwise the patch won't apply. It

Re: [PATCH 4/15] - tm6000.h

2010-02-03 Thread Devin Heitmueller
On Wed, Feb 3, 2010 at 3:50 PM, Stefan Ringel stefan.rin...@arcor.de wrote: Am 03.02.2010 21:25, schrieb Mauro Carvalho Chehab: This one is a very obscure patch. What are you doing this patch and why? Stefan Ringel wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de ---

Re: [PATCH 14/15] - zl10353

2010-02-03 Thread Stefan Ringel
Am 03.02.2010 21:49, schrieb Devin Heitmueller: On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/dvb/frontends/zl10353.h +++ b/drivers/media/dvb/frontends/zl10353.h @@ -45,6 +45,8 @@ struct

Re: [PATCH 12/15] - tm6000 bugfix tuner reset time and tuner param

2010-02-03 Thread Stefan Ringel
Am 03.02.2010 21:52, schrieb Devin Heitmueller: On Wed, Feb 3, 2010 at 3:31 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -221,12 +239,13 @@

Re: [PATCH 9/15] - tm6000 analog digital switch

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 03.02.2010 21:40, schrieb Mauro Carvalho Chehab: So, please get the asalted-patches extension, apply it on your Thunderbird, review your patch series based on the contents of README.patches and re-submit. I use thunderbird 3, but the patch is for 2. It that

Re: [PATCH 4/15] - tm6000.h

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 03.02.2010 21:25, schrieb Mauro Carvalho Chehab: This one is a very obscure patch. What are you doing this patch and why? Stefan Ringel wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000.h +++

Re: [PATCH 1/15] - tm6000 build hunk

2010-02-03 Thread Stefan Ringel
Signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/staging/tm6000/tm6000-cards.c +++ b/drivers/staging/tm6000/tm6000-cards.c @@ -32,7 +32,7 @@ #include tm6000.h #include tm6000-regs.h #include tuner-xc2028.h -#include tuner-xc5000.h +#include xc5000.h #define

Re: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()

2010-02-03 Thread Tobias Lorenz
Hello Roel, no, the default value of retval makes no difference to the function. Retval is set by si470x_disconnect_check and si470x_set_register. After each call, retval is checked. There is no need to reset it passed. The only reason, there is a default value is my static code checker, saying

Re: [GIT PULL] V4L HD PVR updates

2010-02-03 Thread Janne Grunau
On Wed, Feb 03, 2010 at 01:37:19PM -0200, Mauro Carvalho Chehab wrote: Janne Grunau wrote: Hi Mauro, please pull from git://git.jannau.net/linux hdpvr Didn't work: $ git pull git://git.jannau.net/linux fatal: The remote end hung up unexpectedly sorry, missing git-daemon-export-ok.

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi Mauro, Mauro Carvalho Chehab wrote: Hi Oliver, Oliver Endriss wrote: Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene It were not an easy to work on this changeset, since it hit a bug at gentree.pl script. Basically, this drivers use #elseif directive

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Helmut Auer
Am 03.02.2010 21:02, schrieb Mauro Carvalho Chehab: ... ERROR: that open brace { should be on the previous line #1693: FILE: drivers/media/dvb/ngene/ngene-core.c:1615: + u8 tsin4_config[6] = + {3072 / 64, 3072 / 64, 0, 3072 / 64, 3072 / 64, 0}; ERROR: that

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Mauro Carvalho Chehab
Oliver Endriss wrote: Hi Mauro, Mauro Carvalho Chehab wrote: Hi Oliver, Oliver Endriss wrote: Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene It were not an easy to work on this changeset, since it hit a bug at gentree.pl script. Basically, this drivers use

Re: [PATCH] AVerTV MCE 116 Plus radio

2010-02-03 Thread Andy Walls
On Tue, 2010-02-02 at 13:29 -0200, Mauro Carvalho Chehab wrote: Hi Andy, This patch has never been applied or nacked. From your last comment, it seems that you're waiting for Aleksandr Signed-of-by:. If this is still the case, I suggest you to wait for a couple days. If he doesn't send

ivtv-utils/test/ps-analyzer.cpp: error in extracting SCR?

2010-02-03 Thread Lars Hanisch
Hi, I'm writing some code repacking the program stream that ivtv delivers into a transport stream (BTW: is there existing code for this?). Since many players needs the PCR I would like to use the SCR of the PS and place it in the adaption field of the TS (if wikipedia [1] and my

Re: [GIT PULL] V4L HD PVR updates

2010-02-03 Thread Mauro Carvalho Chehab
Janne Grunau wrote: On Wed, Feb 03, 2010 at 01:37:19PM -0200, Mauro Carvalho Chehab wrote: Janne Grunau wrote: Hi Mauro, please pull from git://git.jannau.net/linux hdpvr Didn't work: $ git pull git://git.jannau.net/linux fatal: The remote end hung up unexpectedly sorry, missing

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi, Mauro Carvalho Chehab wrote: Oliver Endriss wrote: Mauro Carvalho Chehab wrote: Oliver Endriss wrote: Mauro, Please pull from http://endr...@linuxtv.org/hg/~endriss/ngene It were not an easy to work on this changeset, since it hit a bug at gentree.pl script. Basically, this

Re: [PULL] nGene driver - http://endr...@linuxtv.org/hg/~endriss/ngene

2010-02-03 Thread Oliver Endriss
Hi, Oliver Endriss wrote: Mauro Carvalho Chehab wrote: Oliver Endriss wrote: Mauro Carvalho Chehab wrote: After applying all the patches, I'm getting this error: drivers/media/dvb/ngene/ngene-core.c: In function ‘ngene_i2c_init’: drivers/media/dvb/ngene/ngene-core.c:860:

Re: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()

2010-02-03 Thread Mauro Carvalho Chehab
Tobias Lorenz wrote: Hello Roel, no, the default value of retval makes no difference to the function. Retval is set by si470x_disconnect_check and si470x_set_register. After each call, retval is checked. There is no need to reset it passed. The only reason, there is a default value is

Re: Any saa711x users out there?

2010-02-03 Thread Andy Walls
On Tue, 2010-02-02 at 17:51 -0500, Devin Heitmueller wrote: Hello all, I am doing some quality improvements for a couple of the em28xx/saa7113 designs, and I found a pretty serious problem which appears to have been there for some time. In fact, the regression was introduced when the

[PATCH] fix memory leak media IR keytable

2010-02-03 Thread Yoichi Yuasa
Signed-off-by: Yoichi Yuasa yu...@linux-mips.org --- drivers/media/IR/ir-keytable.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index b521ed9..44501d9 100644 --- a/drivers/media/IR/ir-keytable.c +++

Re: [PATCH 14/15] - zl10353

2010-02-03 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 03.02.2010 21:49, schrieb Devin Heitmueller: On Wed, Feb 3, 2010 at 3:38 PM, Stefan Ringel stefan.rin...@arcor.de wrote: signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- a/drivers/media/dvb/frontends/zl10353.h +++ b/drivers/media/dvb/frontends/zl10353.h @@

Re: ivtv-utils/test/ps-analyzer.cpp: error in extracting SCR?

2010-02-03 Thread Andy Walls
On Thu, 2010-02-04 at 01:18 +0100, Lars Hanisch wrote: Hi, I'm writing some code repacking the program stream that ivtv delivers into a transport stream (BTW: is there existing code for this?). Buy a CX23418 based board. That chip's firmware can produce a TS. I think Compro and LeadTek

Re: ivtv-utils/test/ps-analyzer.cpp: error in extracting SCR?

2010-02-03 Thread Hans Verkuil
On Thursday 04 February 2010 04:16:03 Andy Walls wrote: On Thu, 2010-02-04 at 01:18 +0100, Lars Hanisch wrote: Hi, I'm writing some code repacking the program stream that ivtv delivers into a transport stream (BTW: is there existing code for this?). Buy a CX23418 based board. That