Re: how does v4l2 driver communicate a frequency lock to mythtv

2010-04-02 Thread Bee Hock Goh
Hi Devin, I have introduced t->signal = 0x; /* LOCKED */ on tm6000-video.c(vidioc_g_tuner) and mythtv indeed can locked the channel. xc2028_signal is showing the correct signal strength information. How can i call get_rf_strength to set the t->signal from vidioc_g_tuner? thanks, H

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: >> Adds a method to pass IR raw pulse/code events into ir-core. This is >> needed in order to support LIRC. It also helps to move common code >> from the drivers into the core. >> >> In order to allow testing, it im

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Mauro Carvalho Chehab
Andy Walls wrote: > On Fri, 2010-04-02 at 19:39 -0400, Andy Walls wrote: >> On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > >>> +enum raw_event_type { >>> + IR_SPACE= (1 << 0), >>> + IR_PULSE= (1 << 1), >>> + IR_START_EVENT = (1 << 2), >>> + IR_STOP_EVENT

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Andy Walls
On Fri, 2010-04-02 at 19:39 -0400, Andy Walls wrote: > On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > > +enum raw_event_type { > > + IR_SPACE= (1 << 0), > > + IR_PULSE= (1 << 1), > > + IR_START_EVENT = (1 << 2), > > + IR_STOP_EVENT = (1 << 3), > > +};

Re: [RFC] Serialization flag example

2010-04-02 Thread Andy Walls
On Fri, 2010-04-02 at 18:15 -0300, Mauro Carvalho Chehab wrote: > Devin Heitmueller wrote: > In the case of a V4L x DVB type of lock, this is not to protect some memory, > but, > instead, to limit the usage of a hardware that is not capable of > simultaneously > provide V4L and DVB streams. This

Re: [RFC] Serialization flag example

2010-04-02 Thread Andy Walls
On Fri, 2010-04-02 at 10:57 +0200, Hans Verkuil wrote: > If needed one could allow drivers to override this function. But again, start > simple and only make it more complex if we really need to. Overengineering is > one of the worst mistakes one can make. I have seen too many projects fail > beca

Re: V4L-DVB drivers and BKL

2010-04-02 Thread Andy Walls
On Thu, 2010-04-01 at 17:29 -0400, Devin Heitmueller wrote: > On Thu, Apr 1, 2010 at 5:16 PM, Mauro Carvalho Chehab > I think though that we need to favor stability/reliability over > performance. You mean doing the wrong thing, as fast as you can, isn't performing? ;) I usually consider perfor

Re: [PATCH 04/15] V4L/DVB: ir-core: Add logic to decode IR protocols at the IR core

2010-04-02 Thread Andy Walls
On Thu, 2010-04-01 at 14:56 -0300, Mauro Carvalho Chehab wrote: > Adds a method to pass IR raw pulse/code events into ir-core. This is > needed in order to support LIRC. It also helps to move common code > from the drivers into the core. > > In order to allow testing, it implements a simple NEC pr

Re: [RFC] Serialization flag example

2010-04-02 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: > On Fri, Apr 2, 2010 at 1:43 PM, Manu Abraham wrote: >> IMO, A framework shouldn't lock. Current DVB framework is locked with BKL. I agree that an unconditional lock like this is very bad. We need to get rid of it as soon as possible. > Hello Manu, > > The argument I

Re: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver on top of DSS2

2010-04-02 Thread Muralidharan Karicheri
Vaibhav, I have some comments on this patch. Please address them. > + > +#include Add a line here?? > +#include > +#include > +#include > +#include > + > +#include "omap_voutlib.h" > +#include "omap_voutdef.h" > + > +MODULE_AUTHOR("Texas Instruments"); > +MODULE_DESCRIPTION("OMAP Video for

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: WARNINGS

2010-04-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Fri Apr 2 19:00:19 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14536:a539e5b68945 git master:

[patch 2/3] [PATCH] drivers/media/IR - improve keyup/keydown logic

2010-04-02 Thread david
The attached patch rewrites the keyup/keydown logic in drivers/media/IR/ir-keytable.c. (applies to http://git.linuxtv.org/mchehab/ir.git) All knowledge of keystates etc is now internal to ir-keytable.c and not scattered around ir-raw-event.c and ir-nec-decoder.c (where it doesn't belong). In add

[patch 3/3] Convert drivers/media/dvb/ttpci/budget-ci.c to use ir-core

2010-04-02 Thread david
This patch converts drivers/media/dvb/ttpci/budget-ci.c to use ir-core rather than rolling its own keydown timeout handler and reporting keys via drivers/media/IR/ir-functions.c. Signed-off-by: David Härdeman Index: ir/drivers/media/dvb/ttpci/budget-ci.c ===

[patch 1/3] [PATCH] drivers/media/IR - improve keytable code

2010-04-02 Thread david
The attached patch rewrites much of the keytable code in drivers/media/IR/ir-keytable.c. The scancodes are now inserted into the array in sorted order which allows for a binary search on lookup. The code has also been shrunk by about 150 lines. In addition it fixes the following bugs: Any use o

[patch 0/3] ir-core keytable patches

2010-04-02 Thread david
The following patchset provides a number of bug fixes and additional features to ir-core in drivers/media/IR. The first two patches are mostly cleanups to drivers/media/IR/ir-keytable.c while the third patch is an example of a conversion of drivers/media/dvb/ttpci/budget-ci.c to use the new functi

Re: [RFC] Serialization flag example

2010-04-02 Thread Devin Heitmueller
On Fri, Apr 2, 2010 at 2:24 PM, Manu Abraham wrote: > Hi Devin, > >> Hello Manu, >> >> The argument I am trying to make is that there are numerous cases >> where you should not be able to use both a particular DVB and V4L >> device at the same time.  The implementation of such locking should be >>

Re: [RFC] Serialization flag example

2010-04-02 Thread Manu Abraham
Hi Devin, > Hello Manu, > > The argument I am trying to make is that there are numerous cases > where you should not be able to use both a particular DVB and V4L > device at the same time.  The implementation of such locking should be > handled by the v4l-dvb core, but the definition of the relati

Re: [RFC] Serialization flag example

2010-04-02 Thread Devin Heitmueller
On Fri, Apr 2, 2010 at 1:43 PM, Manu Abraham wrote: > On Thu, Apr 1, 2010 at 10:24 PM, Mauro Carvalho Chehab > wrote: > >> You'll have issues also with -alsa and -dvb parts that are present on the >> drivers. >> >> Also, drivers like cx88 have another PCI device for mpeg-encoded streams. It >>

Re: [RFC] Serialization flag example

2010-04-02 Thread Manu Abraham
On Thu, Apr 1, 2010 at 10:24 PM, Mauro Carvalho Chehab wrote: > You'll have issues also with -alsa and -dvb parts that are present on the > drivers. > > Also, drivers like cx88 have another PCI device for mpeg-encoded streams. It > behaves > like two separate drivers (each with its own bind cod

[PATCH 2/2] tm6000: tm6000_i2c_xfer: request labeling

2010-04-02 Thread stefan . ringel
From: Stefan Ringel labeling the request after tuner reading and writeing Signed-off-by: Stefan Ringel --- drivers/staging/tm6000/tm6000-i2c.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-i2c.c b/drivers/staging/tm6000/tm6000-i

[PATCH 1/2] tm6000: request labeling board version check

2010-04-02 Thread stefan . ringel
From: Stefan Ringel request labeling board version check Signed-off-by: Stefan Ringel --- drivers/staging/tm6000/tm6000-cards.c |4 ++-- drivers/staging/tm6000/tm6000-core.c | 18 -- drivers/staging/tm6000/tm6000.h |1 + 3 files changed, 19 insertions(+), 4 de

Re: [RFC] Serialization flag example

2010-04-02 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: > On Thursday 01 April 2010 23:32:33 Mauro Carvalho Chehab wrote: >> Hans Verkuil wrote: Maybe a better alternative would be to pass to the V4L2 core, optionally, some lock, used internally on the driver. This approach will still be pedantic, as all ioctls

V4L2 application compliance testing

2010-04-02 Thread Markus Rechberger
Hi, we recently got around to test several video4linux2 applications and noticed that quite a few kernel drivers do not provide support properly testing applications for v4l2 compliance. http://sundtek.de/images/vivi.png we ported and modified the vivi to userspace, the testpackage is supposed t

Re: how does v4l2 driver communicate a frequency lock to mythtv

2010-04-02 Thread Bee Hock Goh
Thanks a lot for your advice! I will look into the g_tuner and signal function. On Fri, Apr 2, 2010 at 9:59 PM, Devin Heitmueller wrote: > On Fri, Apr 2, 2010 at 9:48 AM, Bee Hock Goh wrote: >> Dear all, >> >> i have been doing some usb snoop and making some changes to the >> existing staging tm

Re: em28xx vbi read timeout

2010-04-02 Thread Devin Heitmueller
On Fri, Apr 2, 2010 at 10:15 AM, Tim Stowell wrote: > Hi, > > I have a KWorld usb 2800D device and am using the newest em28xx > v4l-dvb drivers from linuxtv.org. I'm running Gentoo with a 2.6.31 > kernel. The driver compiles fine, and then I issue the following > commands: > > v4lctl setnorm NTSC

em28xx vbi read timeout

2010-04-02 Thread Tim Stowell
Hi, I have a KWorld usb 2800D device and am using the newest em28xx v4l-dvb drivers from linuxtv.org. I'm running Gentoo with a 2.6.31 kernel. The driver compiles fine, and then I issue the following commands: v4lctl setnorm NTSC zvbi-ntsc-cc -c -d /dev/vbio -v after that I just get constant "V

Re: how does v4l2 driver communicate a frequency lock to mythtv

2010-04-02 Thread Devin Heitmueller
On Fri, Apr 2, 2010 at 9:48 AM, Bee Hock Goh wrote: > Dear all, > > i have been doing some usb snoop and making some changes to the > existing staging tm6000 to get my tm5600/xc2028 usb stick to work. > Thanks to a lot of help from Stefan, I have some limited success and > is able to get mythtv to

how does v4l2 driver communicate a frequency lock to mythtv

2010-04-02 Thread Bee Hock Goh
Dear all, i have been doing some usb snoop and making some changes to the existing staging tm6000 to get my tm5600/xc2028 usb stick to work. Thanks to a lot of help from Stefan, I have some limited success and is able to get mythtv to do channel scan. However, mythtv is not able to logon to the ch

[patch] cx88: improve error handling

2010-04-02 Thread Dan Carpenter
Return -EINVAL if we don't find the right query control id. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c index 48c450f..b4c80cb 100644 --- a/drivers/media/video/cx88/cx88-video.c +++ b/drivers/media/video/cx88/cx88-video

[patch] cx231xx: improve error handling

2010-04-02 Thread Dan Carpenter
Return -EINVAL if we don't find the control id. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/cx231xx/cx231xx-video.c b/drivers/media/video/cx231xx/cx231xx-video.c index d4f546f..5a74ef8 100644 --- a/drivers/media/video/cx231xx/cx231xx-video.c +++ b/drivers/media/video/cx231xx/c

Re: [PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-02 Thread David Härdeman
On Thu, Apr 01, 2010 at 09:44:12PM -0400, Jon Smirl wrote: > On Thu, Apr 1, 2010 at 1:56 PM, Mauro Carvalho Chehab > wrote: > > This series of 15 patches improves support for IR, as discussed at the > > "What are the goals for the architecture of an in-kernel IR system?" > > thread. > > > > It bas

[GIT PATCHES FOR 2.6.35] gspca for_2.6.35

2010-04-02 Thread Jean-Francois Moine
Hi Mauro, The following changes since commit a6eb7bc8e0eea78f96ad1b0f0195ec52b88c6a00: Laurent Pinchart (1): V4L/DVB: uvcvideo: Use POLLOUT and POLLWRNORM for output devices are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.35 Jean-François Moine

CX88 TS overflows too often

2010-04-02 Thread Doru Marin
Hello, I have a system with two Hauppauge Nova-S-Plus cards and a HVR4000Lite. Very often I'm getting errors like: cx88[0]/2-mpeg: general errors: 0x0100 cx88[2]/2-mpeg: general errors: 0x0100 Digging in the code, I found that is DMA related, meaning TS overflow. Looking further, I foun

Re: stv0903bab i2c-repeater question

2010-04-02 Thread Sergey Mironov
2010/3/31 Andreas Regel : > Hi Sergey, > > Am 31.03.2010 12:14, schrieb Sergey Mironov: >> Hello maillist! >> I am integrating frontend with dvb-demux driver of one device >> called mdemux. >> >> The frontend includes following parts: >> - stv0903bab demodulator >> - stv6110a tuner >> - lnbp21 powe

Re: [RFC] Serialization flag example

2010-04-02 Thread Hans Verkuil
On Thursday 01 April 2010 23:32:33 Mauro Carvalho Chehab wrote: > Hans Verkuil wrote: > >> Maybe a better alternative would be to pass to the V4L2 core, optionally, > >> some lock, > >> used internally on the driver. This approach will still be pedantic, as > >> all ioctls will > >> keep being se

Re: adv7180 as SoC camera device

2010-04-02 Thread Rodolfo Giometti
On Fri, Apr 02, 2010 at 09:09:30AM +0200, Guennadi Liakhovetski wrote: > On Thu, 1 Apr 2010, Rodolfo Giometti wrote: > > > On Tue, Mar 30, 2010 at 04:06:11PM +0200, Rodolfo Giometti wrote: > > > On Tue, Feb 23, 2010 at 12:19:13AM +0100, Richard Röjfors wrote: > > > > > > > > We use it as a subdev

Re: adv7180 as SoC camera device

2010-04-02 Thread Guennadi Liakhovetski
On Thu, 1 Apr 2010, Rodolfo Giometti wrote: > On Tue, Mar 30, 2010 at 04:06:11PM +0200, Rodolfo Giometti wrote: > > On Tue, Feb 23, 2010 at 12:19:13AM +0100, Richard Röjfors wrote: > > > > > > We use it as a subdev to a driver not yet committed from us. So I think > > > you should extend it, not

Re: adv7180 as SoC camera device

2010-04-02 Thread Guennadi Liakhovetski
On Tue, 30 Mar 2010, Rodolfo Giometti wrote: > On Tue, Mar 30, 2010 at 04:40:17PM +0200, Guennadi Liakhovetski wrote: > > On Tue, 30 Mar 2010, Rodolfo Giometti wrote: > > > > > On Tue, Feb 23, 2010 at 12:19:13AM +0100, Richard Röjfors wrote: > > > > > > > > We use it as a subdev to a driver not