Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-08 Thread Hans de Goede
Hi, On 12/07/2010 09:01 PM, Mauro Carvalho Chehab wrote: Hi Jean-Fronçois, git commit 35680baa6822df98a6ed602e2380aa0a04e18b07 (see enclosed) caused not only a regression at PS/3 Eye webcam (git commit f43402fa55bf5e7e190c176343015122f694857c), but also at sn9c201 driver, when used on SXGA

RE: [PATCH 8/8] v4l: videobuf2: add CMA allocator

2010-12-08 Thread Sewoon Park
Hello Marek Szyprowski Wrote: Sent: Monday, December 06, 2010 7:53 PM To: linux-media@vger.kernel.org Cc: m.szyprow...@samsung.com; pa...@osciak.com; kyungmin.p...@samsung.com; andrze...@samsung.com Subject: [PATCH 8/8] v4l: videobuf2: add CMA allocator snip +struct vb2_cma_buf { +

[PATCH v3 0/2] OmniVision OV9640 sensor driver cleanup and fix

2010-12-08 Thread David Cohen
Hi, These patches apply some cleanups and fix OV9640 driver's priv data retrieving on I2C remove and video_probe functions. I included in this new version one missing fix pointed out by Guennadi Liakhovetski. Despite the patches are simple, they haven't been tested yet due to lack of hw. These

[PATCH v3 1/2] ov9640: use macro to request OmniVision OV9640 sensor private data

2010-12-08 Thread David Cohen
This cleanup patch creates macro to request OmniVision OV9640 private data, which increases readability. Signed-off-by: David Cohen daco...@gmail.com --- drivers/media/video/ov9640.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/ov9640.c

[PATCH v3 2/2] ov9640: fix OmniVision OV9640 sensor driver's priv data retrieving

2010-12-08 Thread David Cohen
OmniVision OV9640 driver wasn't requesting properly its private data on I2C remove and video_probe functions. It was retrieving the V4L2 subdev struct address instead of priv struct's one. This patch fixes such problem. Signed-off-by: David Cohen daco...@gmail.com ---

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-08 Thread Hans de Goede
Hi, On 12/08/2010 01:54 PM, Mauro Carvalho Chehab wrote: Em 08-12-2010 08:01, Hans de Goede escreveu: Hi, On 12/07/2010 09:01 PM, Mauro Carvalho Chehab wrote: Hi Jean-Fronçois, git commit 35680baa6822df98a6ed602e2380aa0a04e18b07 (see enclosed) caused not only a regression at PS/3 Eye

[PATCH] libv4l: Add support for 8-bits grey format (V4L2_PIX_FMT_GREY)

2010-12-08 Thread Mauro Carvalho Chehab
Grey format is like YUV, with U/V channels with 0. Add the corresponding bits to libv4l, for it to handle this format. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/lib/libv4lconvert/libv4lconvert-priv.h b/lib/libv4lconvert/libv4lconvert-priv.h index 61a8c39..2680ed7

[PATCH] [media] gspca/sn9c20x: Fix support for mt9m001 (mi1300) sensor

2010-12-08 Thread Mauro Carvalho Chehab
Support for mt9m001 (mi1300) is broken: - Table is incomplete; - Only low-res resolutions are currently supported by the driver; - it complains about broken JPEG headers, as image capture window is wrong. Use the same init found on em28xx driver, and properly

RE: [PATCH 2/8] v4l: videobuf2: add generic memory handling routines

2010-12-08 Thread Marek Szyprowski
Hello, On Wednesday, December 08, 2010 8:02 AM Sewoon Park wrote: Hello~ There are a lot of code changes compared with version5 patch. Some minor comments below. Thanks for spotting old, outdated comments. I'm sorry that I forgot about them. I will update them asap. snip You mentioned

Accessing running dvb device

2010-12-08 Thread Mike Martin
Hi I am trying to run multiple recordings on my dvb device (rtl2832). However when I try to access the frontend settings when a recording is active get_frontend returns nothing. This is using the Linux::DVB::DVBT module any suggestions -- To unsubscribe from this list: send the line

Re: [RFC][media] s5p-fimc : Need to modifiy input DMA burst count for FIMC performance.

2010-12-08 Thread Sylwester Nawrocki
Hi Hyunwoong, On 12/08/2010 08:12 AM, Hyunwoong Kim wrote: Hello, I am writing this mail to suggest one thing regarding FIMC H/W setting. You wrote the below code for setting S5P_MSCTRL_FRAME_COUNT as one. cfg |= (S5P_MSCTRL_FRAME_COUNT(1) | S5P_MSCTRL_INPUT_MEMORY); I think it’s

Re: [PATCH] libv4l: Add support for 8-bits grey format (V4L2_PIX_FMT_GREY)

2010-12-08 Thread Hans de Goede
Hi, On 12/08/2010 03:14 PM, Mauro Carvalho Chehab wrote: Grey format is like YUV, with U/V channels with 0. Add the corresponding bits to libv4l, for it to handle this format. Signed-off-by: Mauro Carvalho Chehabmche...@redhat.com diff --git a/lib/libv4lconvert/libv4lconvert-priv.h

RE: [PATCH v3 2/6] davinci vpbe: VPBE display driver

2010-12-08 Thread Hadli, Manjunath
Hans, Thanks for the comments. Only one comment from me. Rest everything I have taken care. Thanks and Regards, -Manju On Tue, Dec 07, 2010 at 02:13:45, Hans Verkuil wrote: Comments below... On Thursday, December 02, 2010 13:38:36 Manjunath Hadli wrote: This patch implements the coe

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-08 Thread Mauro Carvalho Chehab
Em 08-12-2010 12:11, Hans de Goede escreveu: Hi, On 12/08/2010 01:54 PM, Mauro Carvalho Chehab wrote: Em 08-12-2010 08:01, Hans de Goede escreveu: Hi, On 12/07/2010 09:01 PM, Mauro Carvalho Chehab wrote: Hi Jean-Fronçois, git commit 35680baa6822df98a6ed602e2380aa0a04e18b07 (see

Re: tm6000 and IR

2010-12-08 Thread Stefan Ringel
Am 08.12.2010 04:55, schrieb Dmitri Belimov: Hi Stefan Am 06.12.2010 11:02, schrieb Dmitri Belimov: Thank you. When I switched to this branch modules is not crash when USB removed. But disable IR over interrupt after start video/radio With my best regards, Dmitry. changing the interface

RE: [PATCH v3 2/6] davinci vpbe: VPBE display driver

2010-12-08 Thread Hans Verkuil
Hans, Thanks for the comments. Only one comment from me. Rest everything I have taken care. Thanks and Regards, -Manju On Tue, Dec 07, 2010 at 02:13:45, Hans Verkuil wrote: Comments below... On Thursday, December 02, 2010 13:38:36 Manjunath Hadli wrote: This patch implements the coe

Re: [PATCH v2] media: rc: ir-lirc-codec: fix integer overflow

2010-12-08 Thread Jarod Wilson
On Sun, Dec 05, 2010 at 12:05:22AM +0300, Vasiliy Kulikov wrote: 'n' may be bigger than MAX_INT*sizeof(int), if so checking of truncated (int)(n/sizeof(int)) for LIRCBUF_SIZE overflows and then using nontruncated 'count' doesn't make sense. This is not a security issue as too big 'n' is

Re: [PATCH] libv4l: Add support for 8-bits grey format (V4L2_PIX_FMT_GREY)

2010-12-08 Thread Mauro Carvalho Chehab
Em 08-12-2010 13:00, Hans de Goede escreveu: Hi, +/* Clear U/V */ +memset(dest, 0, src_fmt-fmt.pix.width * src_fmt-fmt.pix.height / 2); This is wrong the 0 value for U/V is 0x80 (U and V are signed, but not two's complement instead their range is up shifted by 0x80) Otherwise

[cron job] v4l-dvb daily build: WARNINGS

2010-12-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed Dec 8 19:00:17 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version:

[PATCH 00/12] IR: Fixes for 2.6.37-rc5

2010-12-08 Thread Jarod Wilson
These are assorted IR fixes I'd like to see make 2.6.37. They should all be present in media_tree.git now, if I'm not mistaken, albeit under the rc subdir instead of IR. I've got a few reports of issues with buffer parsing in mceusb, streamzap and nuvoton-cir, mostly because I've made similar

[PATCH 01/12] [media] mceusb: add support for Conexant Hybrid TV RDU253S

2010-12-08 Thread Jarod Wilson
Another multi-function Conexant device. Interface 0 is IR, though on this model, TX isn't wired up at all, so I've mixed in support for models without TX (and verified that lircd says TX isn't supported when trying to send w/this device). Signed-off-by: Jarod Wilson ja...@redhat.com

[PATCH 02/12] [media] nuvoton-cir: improve buffer parsing responsiveness

2010-12-08 Thread Jarod Wilson
Rather than waiting for trigger bits, the formula for which was slightly messy, and apparently, not actually 100% complete for some remotes, just call ir_raw_event_handle whenever we finish parsing a chunk of data from the rx fifo, similar to mceusb, as well as whenever we see an 'end of signal

[PATCH 03/12] [media] mceusb: fix up reporting of trailing space

2010-12-08 Thread Jarod Wilson
We were storing a bunch of spaces at the end of each signal, rather than a single long space. The in-kernel decoders were actually okay with this, but lirc isn't. As suggested by David Härdeman, switch to storing samples using ir_raw_event_store_with_filter, which auto-merges the consecutive space

[PATCH 04/12] [media] mceusb: buffer parsing fixups for 1st-gen device

2010-12-08 Thread Jarod Wilson
If we pass in an offset, we shouldn't skip 2 bytes. And the first-gen hardware generates a constant stream of interrupts, always with two header bytes, and if there's been no IR, with nothing else. Bail from ir processing without calling ir_handle_raw_event when we get such a buffer delivered to

[PATCH 05/12] [media] IR: add tv power scancode to rc6 mce keymap

2010-12-08 Thread Jarod Wilson
And clean up some stray spaces. Signed-off-by: Jarod Wilson ja...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/IR/keymaps/rc-rc6-mce.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git

[PATCH 07/12] streamzap: merge timeout space with trailing space

2010-12-08 Thread Jarod Wilson
There are cases where we get an ending space, and our trailing timeout space then gets sent right after it, which breaks repeat, at least for lirc userspace decoding. Merge the two spaces by way of using ir_raw_event_store_filter, set a timeout value, and we're back to good. Successfully tested

[PATCH 09/12] lirc_dev: stray unlock in lirc_dev_fop_poll()

2010-12-08 Thread Jarod Wilson
From: Dan Carpenter erro...@gmail.com We shouldn't unlock here. I think this was a cut and paste error. Signed-off-by: Dan Carpenter erro...@gmail.com Acked-by: Jarod Wilson ja...@redhat.com --- drivers/media/IR/lirc_dev.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff

[PATCH 11/12] lirc_dev: fixes in lirc_dev_fop_read()

2010-12-08 Thread Jarod Wilson
From: Dan Carpenter erro...@gmail.com This makes several changes but they're in one function and sort of related: buf was leaked on error. The leak if we try to read an invalid length is the main concern because it could be triggered over and over. If the copy_to_user() failed, then the

[PATCH 12/12] mceusb: add another device ID

2010-12-08 Thread Jarod Wilson
Signed-off-by: Jarod Wilson ja...@redhat.com --- drivers/media/IR/mceusb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c index 57ef809..eb96561 100644 --- a/drivers/media/IR/mceusb.c +++ b/drivers/media/IR/mceusb.c

dvb_unregister_frontend hanging on fepriv-dvbdev-users when called from smsdvb_unregister_client

2010-12-08 Thread Richard Zidlicky
Hi, I am trying to figure out why the smsxxx MiniStick isn't unregistered correctly when I pull out the stick while kaffeine is playing. It gets as far as calling smsdvb_unregister_client dvb_unregister_frontend where it hangs at if (fepriv-dvbdev-users -1)

Re: tm6000 and IR

2010-12-08 Thread Dmitri Belimov
Hi This is my summary changes: 1. Add vendor specific keymap for USB TV card (try git add file, but git diff doesn't include this into diff) 2. Spilt ir_config and work with a key to different rc_type 3. When rc_type is NEC get first scancode from a scantable cut address and store it for