Re: [PATCH] Make code more readable by not using the return value of the WARN() macro. Set ret variable in an undefined case.

2011-05-26 Thread Guennadi Liakhovetski
On Wed, 25 May 2011, Mauro Carvalho Chehab wrote: Em 23-05-2011 16:04, Hans Petter Selasky escreveu: On Monday 23 May 2011 20:22:02 Guennadi Liakhovetski wrote: Please, inline patches. Otherwise, this is what one gets, when replying. On Mon, 23 May 2011, Hans Petter Selasky wrote:

Re: About RFC of HDMI-CEC

2011-05-26 Thread Hans Verkuil
On Thursday, May 26, 2011 07:09:30 vipul kumar samar wrote: Hello, On 05/25/2011 06:13 PM, Martin Bugge (marbugge) wrote: Hello To be honest I became a bit disengaded after all the discussion. What caused me a lot of problems was the request for AV link support (which is used in

Re: [PATCH] Make nchg variable signed because the code compares this variable against negative values.

2011-05-26 Thread Jean-Francois Moine
On Wed, 25 May 2011 21:07:17 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: This patch looks ok to me, although the description is not 100%. The sonixj driver compares the value for nchg with if (sd-nchg -6 || sd-nchg = 12) { With u8, negative values won't work.

Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG

2011-05-26 Thread Jean-Francois Moine
On Wed, 25 May 2011 17:34:32 -0400 Jarod Wilson ja...@redhat.com wrote: diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c index 66671a4..26fc206 100644 --- a/drivers/media/video/gspca/kinect.c +++ b/drivers/media/video/gspca/kinect.c @@ -34,7 +34,7 @@

Re: [ANNOUNCE] experimental alsa stream support at xawtv3

2011-05-26 Thread Hans Verkuil
On Tuesday, May 24, 2011 16:57:22 Devin Heitmueller wrote: On Tue, May 24, 2011 at 2:50 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Monday, May 23, 2011 22:17:06 Mauro Carvalho Chehab wrote: Due to the alsa detection code that I've added at libv4l2util (at v4l2-utils) during the

[RFC v3 1/2] Add mt9p031 sensor driver.

2011-05-26 Thread Javier Martin
This patch applies on 2.6.39 (commit 61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf). It has some power management issue which causes horizontal random lines on the image. If we do not disable 1v8 regulator, the problem disappears. I would like to get some help on fixing whatever the problem with power

[RFC v3 2/2] Add platform code to support mt9p031 (LI-5M03 module) in Beagleboard xM.

2011-05-26 Thread Javier Martin
This patch is not ready to be submitted to mainline since it still has some issues (code belonging to mt9p031 must be moved to a separate file, etc...). However it is useful for you to test mt9p031 sensor driver in kernel 2.6.39 (commit 61c4f2c81c61f73549928dfd9f3e8f26aa36a8cf). Signed-off-by:

Re: [alsa-devel] [PATCH v5] [resend] radio-sf16fmr2: convert to generic TEA575x interface

2011-05-26 Thread Takashi Iwai
At Wed, 25 May 2011 21:21:30 -0300, Mauro Carvalho Chehab wrote: Em 23-05-2011 09:17, Ondrej Zary escreveu: Convert radio-sf16fmr2 to use generic TEA575x implementation. Most of the driver code goes away as SF16-FMR2 is basically just a TEA5757 tuner connected to ISA bus. The card can

Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG

2011-05-26 Thread Antonio Ospite
On Thu, 26 May 2011 08:49:12 +0200 Jean-Francois Moine moin...@free.fr wrote: On Wed, 25 May 2011 17:34:32 -0400 Jarod Wilson ja...@redhat.com wrote: diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c index 66671a4..26fc206 100644 ---

[PATCH v2] Correct error code from -ENOMEM to -EINVAL. Make sure the return value is set in all cases.

2011-05-26 Thread Hans Petter Selasky
From 9b38a5c9878b5e4be2899ae291c4524f5f5fc218 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Thu, 26 May 2011 09:49:52 +0200 Subject: [PATCH] Correct error code from -ENOMEM to -EINVAL. Make sure the return value is set in all cases. Signed-off-by: Hans Petter Selasky

[PATCH v2] Remove unused definitions which can cause conflict with definitions in usb/ch9.h.

2011-05-26 Thread Hans Petter Selasky
From 0dd2949dfeae431ed4ffbd00fd14a10dc3747ad0 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Thu, 26 May 2011 09:56:55 +0200 Subject: [PATCH] Remove unused definitions which can cause conflict with definitions in usb/ch9.h. Signed-off-by: Hans Petter Selasky

[PATCH v2] Correct and add some parameter descriptions.

2011-05-26 Thread Hans Petter Selasky
From 70d02ce19f64fae4ceee563501e8462a76e17b91 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky hsela...@c2i.net Date: Thu, 26 May 2011 10:06:09 +0200 Subject: [PATCH] Correct and add some parameter descriptions. Signed-off-by: Hans Petter Selasky hsela...@c2i.net ---

[patch] [media] DVB: dvb_frontend: off by one in dtv_property_dump()

2011-05-26 Thread Dan Carpenter
If the tvp-cmd == DTV_MAX_COMMAND then we read past the end of the array. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index 9827804..607e293 100644 ---

[patch] [media] rc: double unlock in rc_register_device()

2011-05-26 Thread Dan Carpenter
If change_protocol() fails and we goto out_raw, then it calls unlock twice. I noticed that the other time we called change_protocol() we held the dev-lock, so I changed it to hold it here too. Signed-off-by: Dan Carpenter erro...@gmail.com --- Compile tested only. diff --git

Re: [GIT PATCH FOR 2.6.40] uvcvideo patches

2011-05-26 Thread Laurent Pinchart
On Thursday 26 May 2011 01:50:07 Mauro Carvalho Chehab wrote: Em 25-05-2011 20:43, Laurent Pinchart escreveu: Issues arise when devices have floating point registers. And yes, that happens, I've learnt today about an I2C sensor with floating point registers (in this specific case it should

[patch] [media] rc/redrat3: dereferencing null pointer

2011-05-26 Thread Dan Carpenter
In the original code, if the allocation failed we dereference rr3 when it was NULL. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index 5147767..4582ef7 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c

Re: [GIT PATCH FOR 2.6.40] uvcvideo patches

2011-05-26 Thread Arnd Bergmann
On Thursday 26 May 2011, Laurent Pinchart wrote: On Thursday 26 May 2011 01:50:07 Mauro Carvalho Chehab wrote: Em 25-05-2011 20:43, Laurent Pinchart escreveu: Issues arise when devices have floating point registers. And yes, that happens, I've learnt today about an I2C sensor with

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread javier Martin
On 26 May 2011 10:51, Koen Kooi k...@beagleboard.org wrote: Op 26 mei 2011, om 09:24 heeft Javier Martin het volgende geschreven: Hi Koen, On 25 May 2011 15:38, Koen Kooi k...@beagleboard.org wrote: Op 25 mei 2011, om 13:16 heeft Javier Martin het volgende geschreven: It includes several

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread Guennadi Liakhovetski
On Thu, 26 May 2011, javier Martin wrote: Are you using a LI-5M03 module? (https://www.leopardimaging.com/Beagle_Board_xM_Camera.html) I also added pull ups to the I2C2 line so that I could communicate with mt9p031. Hm, strange, I didn't have to solder anything. Thanks Guennadi ---

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread Laurent Pinchart
On Thursday 26 May 2011 11:35:59 Guennadi Liakhovetski wrote: On Thu, 26 May 2011, javier Martin wrote: Are you using a LI-5M03 module? (https://www.leopardimaging.com/Beagle_Board_xM_Camera.html) I also added pull ups to the I2C2 line so that I could communicate with mt9p031. Hm,

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread Koen Kooi
Op 26 mei 2011, om 11:27 heeft javier Martin het volgende geschreven: On 26 May 2011 10:51, Koen Kooi k...@beagleboard.org wrote: Op 26 mei 2011, om 09:24 heeft Javier Martin het volgende geschreven: Hi Koen, On 25 May 2011 15:38, Koen Kooi k...@beagleboard.org wrote: Op 25 mei

Re: [GIT PATCH FOR 2.6.40] uvcvideo patches

2011-05-26 Thread Mauro Carvalho Chehab
Arnd Bergmann a...@arndb.de wrote: On Thursday 26 May 2011, Laurent Pinchart wrote: On Thursday 26 May 2011 01:50:07 Mauro Carvalho Chehab wrote: Em 25-05-2011 20:43, Laurent Pinchart escreveu: Issues arise when devices have floating point registers. And yes, that happens, I've learnt

Re: omap3isp - H3A auto white balance

2011-05-26 Thread Laurent Pinchart
Hi Daniel, On Thursday 26 May 2011 10:57:39 Daniel Lundborg wrote: Hello, I am developing a camera sensor driver for the Aptina MT9V034. I am only using it in snapshot mode and I can successfully trigger the sensor and receive pictures using the latest omap3isp driver from

Re: [patch] [media] DVB: dvb_frontend: off by one in dtv_property_dump()

2011-05-26 Thread Andreas Oberritter
Hi Dan, On 05/26/2011 10:44 AM, Dan Carpenter wrote: If the tvp-cmd == DTV_MAX_COMMAND then we read past the end of the array. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread javier Martin
OK, I think I've found the problem with the power management. As it is stated in mt9p031 datasheet [3] p 59, a sequence involving [VAA,VAA_PIX,VDD_PLL], [VDD,VDD_IO], [Reset] and [Ext Clk] must be followed in order to properly power up or down the sensor. If we take a look to the LI-5M031

Re: About RFC of HDMI-CEC

2011-05-26 Thread vipul kumar samar
On 05/26/2011 12:05 PM, Hans Verkuil wrote: On Thursday, May 26, 2011 07:09:30 vipul kumar samar wrote: Hello, On 05/25/2011 06:13 PM, Martin Bugge (marbugge) wrote: Hello To be honest I became a bit disengaded after all the discussion. What caused me a lot of problems was the request for

SV: omap3isp - H3A auto white balance

2011-05-26 Thread Daniel Lundborg
Hi Laurent, Hi Daniel, On Thursday 26 May 2011 10:57:39 Daniel Lundborg wrote: Hello, I am developing a camera sensor driver for the Aptina MT9V034. I am only using it in snapshot mode and I can successfully trigger the sensor and receive pictures using the latest omap3isp

use compile uvc_video

2011-05-26 Thread Jerry Geis
I am using centos 5.6 (older kernel) and I get compile errors when I grabbed the latest from http://linuxtv.org/hg/v4l-dvb (which I expect as I have an older 2.6.18 kernel) All I need is uvc so I thought I would do make menuconfig and turn everything off but v4l/UVC stuff. when I do make I

Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG

2011-05-26 Thread Jarod Wilson
On May 26, 2011, at 2:49 AM, jean-francois Moine wrote: On Wed, 25 May 2011 17:34:32 -0400 Jarod Wilson ja...@redhat.com wrote: diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c index 66671a4..26fc206 100644 --- a/drivers/media/video/gspca/kinect.c +++

Re: use compile uvc_video

2011-05-26 Thread Jarod Wilson
On May 26, 2011, at 9:11 AM, Jerry Geis wrote: I am using centos 5.6 (older kernel) and I get compile errors when I grabbed the latest from http://linuxtv.org/hg/v4l-dvb (which I expect as I have an older 2.6.18 kernel) Okay, but do realize that it hasn't been updated in ages, and its

Re: use compile uvc_video

2011-05-26 Thread Jerry Geis
Jarod, Jarod Wilson wrote: On May 26, 2011, at 9:11 AM, Jerry Geis wrote: I am using centos 5.6 (older kernel) and I get compile errors when I grabbed the latest from http://linuxtv.org/hg/v4l-dvb (which I expect as I have an older 2.6.18 kernel) Okay, but do realize that it hasn't

Re: [GIT PATCH FOR 2.6.40] uvcvideo patches

2011-05-26 Thread Sakari Ailus
Hi Arnd and others, On Thu, May 26, 2011 at 11:20:41AM +0200, Arnd Bergmann wrote: On Thursday 26 May 2011, Laurent Pinchart wrote: On Thursday 26 May 2011 01:50:07 Mauro Carvalho Chehab wrote: Em 25-05-2011 20:43, Laurent Pinchart escreveu: Issues arise when devices have floating point

Re: [patch] [media] rc: double unlock in rc_register_device()

2011-05-26 Thread Jarod Wilson
Dan Carpenter wrote: If change_protocol() fails and we goto out_raw, then it calls unlock twice. Gah, good catch, I gotta quit adding new bugs... ;) I noticed that the other time we called change_protocol() we held the dev-lock, so I changed it to hold it here too. Signed-off-by: Dan

Re: [patch] [media] rc/redrat3: dereferencing null pointer

2011-05-26 Thread Jarod Wilson
Dan Carpenter wrote: In the original code, if the allocation failed we dereference rr3 when it was NULL. D'oh, yeah, thanks for the fix. Acked-by: Jarod Wilson ja...@redhat.com -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the

Re: use compile uvc_video

2011-05-26 Thread Jarod Wilson
On May 26, 2011, at 10:25 AM, Jerry Geis wrote: ... Is there a way I can just compile the linux/drivers/media/video/uvc ? Edit the .config file, disable anything you don't want to build. thats all I need. How do I do that? Another option you can try is something along the

[cron job] v4l-dvb daily build: ERRORS

2011-05-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu May 26 19:00:48 CEST 2011 git hash:f9b51477fe540fb4c65a05027fdd6f2ecce4db3b gcc version: i686-linux-gcc (GCC)

[PATCH] Add remote control support for mantis

2011-05-26 Thread Christoph Pinkl
This patch replaces my previous patch https://patchwork.kernel.org/patch/816592/ It adds the rc_dev-dev.parent definition missing in the previous version. --- drivers/media/dvb/mantis/hopper_cards.c|2 +- drivers/media/dvb/mantis/mantis_cards.c| 27 +++-

PCTV nanoStick T2 290e support - Thank you!

2011-05-26 Thread Nicolas WILL
Just installed mine for MythTV. Works great on the first try! Many, many thanks! Nico -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [media] mceusb: add and use mce_dbg printk macro

2011-05-26 Thread Jarod Wilson
Using dev_dbg is more complexity than many users are able to deal with. Make it easier to get debug spew feedback from them by adding an mce_dbg printk macro that spews using dev_info when debug=1 is set for the mceusb module. Signed-off-by: Jarod Wilson ja...@redhat.com ---

[PATCH] [media] mceusb: support I-O Data GV-MC7/RCKIT

2011-05-26 Thread Jarod Wilson
There's an SMK-device-id remote kit from I-O Data avaiable primarily in Japan, which appears to have no tx hardware, but has rx functionality that works with the mceusb driver by simply adding its device ID. http://www.iodata.jp/product/av/tidegi/gv-mc7rckit/ Reported-by: Jeremy Kwok

[PATCH] [media] mceusb: mce_sync_in is brain-dead

2011-05-26 Thread Jarod Wilson
Aside from the initial hey, lets make sure we've flushed any pre-existing data on the device call to mce_sync_in, every other one of the calls was entirely superfluous. Ergo, remove them all, and rename the one and only (questionably) useful one to reflect what it really does. Verified on both

Re: PCTV nanoStick T2 290e support - Thank you!

2011-05-26 Thread Antti Palosaari
On 05/27/2011 12:25 AM, Nicolas WILL wrote: Just installed mine for MythTV. Works great on the first try! Many, many thanks! Thank you for the feedback! :) It will get also remote controller support and I also changed LNA (low noise amplifier) behind module parameter. After those patches

Re: [beagleboard] [PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-26 Thread Chris Rodley
On 26/05/11 19:24, javier Martin wrote: On 25 May 2011 15:38, Koen Kooi k...@beagleboard.org wrote: Op 25 mei 2011, om 13:16 heeft Javier Martin het volgende geschreven: It includes several fixes pointed out by Laurent Pinchart. However, the BUG which shows artifacts in the image