[patch v2] Staging: cx25821: off by one in cx25821_vidioc_s_input()

2011-10-12 Thread Dan Carpenter
If "i" is 2 then when we call cx25821_video_mux() we'd end up going past the end of the cx25821_boards[dev->board]->input[]. The INPUT() macro obfuscates what's going on in that function so it's a bit hard to follow. And as Mauro points out the hard coded 2 is not very helpful. Signed-off-by: Da

recent cx23385?

2011-10-12 Thread James
Is there a newer cx23385 driver than the one in kernel-3.0.4? I bought a http://linuxtv.org/wiki/index.php/Hauppauge_WinTV-HVR-1250 and it shows video for about 5 seconds and then locks up the system. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mes

Re: [PATCH 2/3] soc-camera: mt9t112: modify delay time after initialize

2011-10-12 Thread Kuninori Morimoto
Hi Guennadi > There was a question at the bottom of this email, which you might have > overseen:-) Could you give me an idea, which patche(es) exactly you meant? sorry for my super late response. I losted this email. > > > > > Subject: [PATCH 2/3] soc-camera: mt9t112: modify delay time after

Re: [RFC 2/2] dma-buf: Documentation for buffer sharing framework

2011-10-12 Thread Semwal, Sumit
Hi Randy, On Thu, Oct 13, 2011 at 4:00 AM, Randy Dunlap wrote: > On 10/11/2011 02:23 AM, Sumit Semwal wrote: >> Add documentation for dma buffer sharing framework, explaining the >> various operations, members and API of the dma buffer sharing >> framework. >> >> Signed-off-by: Sumit Semwal >> Si

Re: digital tuner

2011-10-12 Thread Devin Heitmueller
On Thu, May 12, 2011 at 3:49 PM, James wrote: > > I have an analog: Hauppauge WinTV-Go PLUS which has a lineout. > > I'm considering a digital card. > The Hauppauge WinTV-HVR-1250 does NOT have a lineout so how does it do > sound? > Does PCIe pass through the sound to the OS sound system? > I read

Re: where is the cx23887 module in kernel-3.04 config?

2011-10-12 Thread Devin Heitmueller
On Wed, Oct 12, 2011 at 4:42 PM, James wrote: > On 10/12/11 16:30, James wrote: >> >> Where is the cx23887 module in the kernel-3.04 config? >> I'm trying to get a Hauppauge WinTV-HVR-1250 working. >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a

Re: where is the cx23887 module in kernel-3.04 config?

2011-10-12 Thread James
On 10/12/11 16:30, James wrote: Where is the cx23887 module in the kernel-3.04 config? I'm trying to get a Hauppauge WinTV-HVR-1250 working. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http

where is the cx23887 module in kernel-3.04 config?

2011-10-12 Thread James
Where is the cx23887 module in the kernel-3.04 config? I'm trying to get a Hauppauge WinTV-HVR-1250 working. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [RFC 2/2] dma-buf: Documentation for buffer sharing framework

2011-10-12 Thread Randy Dunlap
On 10/11/2011 02:23 AM, Sumit Semwal wrote: > Add documentation for dma buffer sharing framework, explaining the > various operations, members and API of the dma buffer sharing > framework. > > Signed-off-by: Sumit Semwal > Signed-off-by: Sumit Semwal > --- > Documentation/dma-buf-sharing.txt |

[PATCH] media: tea5764: reconcile Kconfig symbol and macro

2011-10-12 Thread Paul Bolle
The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems to be a way to keep both. (The easiest way out would be to rip out both the Kconfig symbol and the macro.) Note there's also a module parameter 'use_xtal' t

[PATCH] [media] videodev: fix a NULL pointer dereference in v4l2_device_release()

2011-10-12 Thread Antonio Ospite
The change in 8280b66 does not cover the case when v4l2_dev is already NULL, fix that. With a Kinect sensor, seen as an USB camera using GSPCA in this context, a NULL pointer dereference BUG can be triggered by just unplugging the device after the camera driver has been loaded. Signed-off-by: Ant

Re: OMAP3 ISP ghosting

2011-10-12 Thread Gary Thomas
On 2011-10-11 07:20, Gary Thomas wrote: As a number of us have seen, when using the OMAP3 ISP with a BT-656 sensor, e.g. TVP5150, the results are not 100% correct. Some number of frames (typically 2) will be correct, followed by another set (3) which are incorrect and show only partially correct

cron job: media_tree daily build: WARNINGS

2011-10-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Oct 12 19:00:15 CEST 2011 git hash:e30528854797f057aa6ffb6dc9f890e923c467fd gcc version: i686-linux-gcc (GC

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Sakari Ailus
On Wed, Oct 12, 2011 at 05:08:20PM +0200, Tomasz Stanislawski wrote: > On 10/12/2011 01:48 PM, Sakari Ailus wrote: > >Hi Tomasz, > > > >On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: > >... > >>diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h > >>index fca24c

[PATCH] media: vb2: add a check for uninitialized buffer

2011-10-12 Thread Marek Szyprowski
__buffer_in_use() might be called for empty/uninitialized buffer in the following scenario: REQBUF(n, USER_PTR), QUERYBUF(). This patch fixes kernel ops in such case. Signed-off-by: Marek Szyprowski Signed-off-by: Kyungmin Park CC: Pawel Osciak --- drivers/media/video/videobuf2-core.c |4

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 9:34 AM, Dave Airlie wrote: > On Wed, Oct 12, 2011 at 3:24 PM, Rob Clark wrote: >> On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie wrote: But then we'd need a different set of accessors for every different drm/v4l/etc driver, wouldn't we? >>> >>> Not any more diffe

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Tomasz Stanislawski
On 10/12/2011 01:48 PM, Sakari Ailus wrote: Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index fca24cc..b7471fe 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -73

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Daniel Vetter
On Wed, Oct 12, 2011 at 03:34:54PM +0100, Dave Airlie wrote: > On Wed, Oct 12, 2011 at 3:24 PM, Rob Clark wrote: > > On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie wrote: > >>> But then we'd need a different set of accessors for every different > >>> drm/v4l/etc driver, wouldn't we? > >> > >> Not a

Re: Controlling external GPIO in IVC-200G board

2011-10-12 Thread Domenico Andreoli
On Wed, Oct 12, 2011 at 04:03:46PM +0200, Augusto Destrero wrote: > Hi there, Hi, > Now we would like to control the external GPIO embedded in the IVC-200G > board, > but we don't know how to do it. bttv driver does not expose GPIOs to the userspace but I expect it can be modified to do so. Ha

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Dave Airlie
On Wed, Oct 12, 2011 at 3:24 PM, Rob Clark wrote: > On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie wrote: >>> But then we'd need a different set of accessors for every different >>> drm/v4l/etc driver, wouldn't we? >> >> Not any more different than you need for this, you just have a new >> interfac

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 9:01 AM, Dave Airlie wrote: >> But then we'd need a different set of accessors for every different >> drm/v4l/etc driver, wouldn't we? > > Not any more different than you need for this, you just have a new > interface that you request a sw object from, > then mmap that obje

Controlling external GPIO in IVC-200G board

2011-10-12 Thread Augusto Destrero
Hi there, we recently purchased a IVC-200G board from IEI: http://ieiworld.com/product_groups/industrial/content.aspx?gid=09049535992720993533&cid=09049577938864496628&id=08142301152930771045 we would like to use the external GPIO capabilities of such board on Linux. This external GPIO is used t

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Dave Airlie
> But then we'd need a different set of accessors for every different > drm/v4l/etc driver, wouldn't we? Not any more different than you need for this, you just have a new interface that you request a sw object from, then mmap that object, and underneath it knows who owns it in the kernel. mmap j

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 8:35 AM, Dave Airlie wrote: >> >> well, the mmap is actually implemented by the buffer allocator >> (v4l/drm).. although not sure if this was the point > > Then why not use the correct interface? doing some sort of not-quite > generic interface isn't really helping anyone e

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Dave Airlie
> > well, the mmap is actually implemented by the buffer allocator > (v4l/drm).. although not sure if this was the point Then why not use the correct interface? doing some sort of not-quite generic interface isn't really helping anyone except adding an ABI that we have to support. If someone want

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Rob Clark
On Wed, Oct 12, 2011 at 7:41 AM, Dave Airlie wrote: > On Tue, Oct 11, 2011 at 10:23 AM, Sumit Semwal wrote: >> This is the first step in defining a dma buffer sharing mechanism. >> >> A new buffer object dma_buf is added, with operations and API to allow easy >> sharing of this buffer object acro

Re: [Linaro-mm-sig] [RFC 1/2] dma-buf: Introduce dma buffer sharing mechanism

2011-10-12 Thread Dave Airlie
On Tue, Oct 11, 2011 at 10:23 AM, Sumit Semwal wrote: > This is the first step in defining a dma buffer sharing mechanism. > > A new buffer object dma_buf is added, with operations and API to allow easy > sharing of this buffer object across devices. > > The framework allows: > - a new buffer-obje

Re: [RFC 0/3] omap3isp: add BT656 support

2011-10-12 Thread Gary Thomas
On 2011-10-12 02:07, Enrico wrote: On Wed, Oct 12, 2011 at 12:34 AM, Gary Thomas wrote: On 2011-10-11 16:25, Enrico wrote: On Wed, Oct 12, 2011 at 12:04 AM, Gary Thomaswrote: Sorry, this just locks up on boot for me, immediately after finding the TVP5150. I applied your changes to the a

Re: [PATCH 1/4] v4l: add support for selection api

2011-10-12 Thread Sakari Ailus
Hi Tomasz, On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: ... > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h > index fca24cc..b7471fe 100644 > --- a/include/linux/videodev2.h > +++ b/include/linux/videodev2.h > @@ -738,6 +738,48 @@ struct v4l2_crop { >

Re: [GIT PATCHES FOR 3.2] auto-cluster bug fix

2011-10-12 Thread Hans Verkuil
On Wednesday, October 12, 2011 10:00:57 Hans Verkuil wrote: > Hi Mauro, > > Here is a small fix for a bug in the autocluster handling that was found > by Hans de Goede. I've added one more fix: V4L spec: fix typo and missing CAP_RDS documentation. Regards, Hans > > Regards, >

Re: [patch] Staging: cx25821: off by on in cx25821_vidioc_s_input()

2011-10-12 Thread Dan Carpenter
Never mind. I figured out what you meant. I've fixed my patch and I will send v2 this evening. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [patch] Staging: cx25821: off by on in cx25821_vidioc_s_input()

2011-10-12 Thread Dan Carpenter
On Tue, Oct 11, 2011 at 05:59:25PM -0300, Mauro Carvalho Chehab wrote: > > - if (i > 2) { > > + if (i >= 2) { > > It would be better to add a NUM_INPUT macro (or something like that, defined > together > with the INPUT macro) that would do an ARRAY_SIZE(cx25821_boards) and use it > here, >

Re: [RFC 0/3] omap3isp: add BT656 support

2011-10-12 Thread Enrico
On Wed, Oct 12, 2011 at 12:34 AM, Gary Thomas wrote: > On 2011-10-11 16:25, Enrico wrote: >> >> On Wed, Oct 12, 2011 at 12:04 AM, Gary Thomas  wrote: >>> >>> Sorry, this just locks up on boot for me, immediately after finding the >>> TVP5150. >>> I applied your changes to the above tree >>>  commi

[GIT PATCHES FOR 3.2] auto-cluster bug fix

2011-10-12 Thread Hans Verkuil
Hi Mauro, Here is a small fix for a bug in the autocluster handling that was found by Hans de Goede. Regards, Hans The following changes since commit e30528854797f057aa6ffb6dc9f890e923c467fd: [media] it913x-fe changes to power up and down of tuner (2011-10-08 08:03:27 -0300) are av