[PATCH RFC] [media] dvb: remove bogus modulation check

2012-01-06 Thread Mauro Carvalho Chehab
This code is wrong as I should have coded it as SYS_DVBC, instead of SYS_DVBS & friends. Anyway, this check has other problems 1) it does some "magic" by assuming that all QAM modulations are below QAM_AUTO; 2) it checks modulation parameters only for one delivery system. Or the core should

[PATCH] [media] drxk_hard: Remove dead code

2012-01-06 Thread Mauro Carvalho Chehab
As reported by Oliver, some old dead code were preserved there. Thanks-to: Oliver endriss Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb/frontends/drxk_hard.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/frontends/drxk_hard.c b/drivers

Re: [git:v4l-dvb/for_v3.3] [media] dvb_frontend: Don't use ops->info.type anymore

2012-01-06 Thread Mauro Carvalho Chehab
On 07-01-2012 03:18, Oliver Endriss wrote: > On Saturday 07 January 2012 03:05:40 Mauro Carvalho Chehab wrote: >> On 06-01-2012 22:36, Oliver Endriss wrote: >>> On Wednesday 04 January 2012 20:29:36 Mauro Carvalho Chehab wrote: drivers/media/dvb/dvb-core/dvb_frontend.c | 541 ++

Re: [git:v4l-dvb/for_v3.3] [media] dvb_frontend: Don't use ops->info.type anymore

2012-01-06 Thread Oliver Endriss
On Saturday 07 January 2012 03:05:40 Mauro Carvalho Chehab wrote: > On 06-01-2012 22:36, Oliver Endriss wrote: > > On Wednesday 04 January 2012 20:29:36 Mauro Carvalho Chehab wrote: > >> drivers/media/dvb/dvb-core/dvb_frontend.c | 541 > >> ++--- > >> 1 files changed, 266

Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

2012-01-06 Thread Mauro Carvalho Chehab
On 05-01-2012 17:09, Mauro Carvalho Chehab wrote: > On 05-01-2012 15:47, Linus Torvalds wrote: >> Can you test the patch with some media capture apps (preferably with >> the obvious fix for the problem that Paulo already pointed out - >> although that won't actually matter until some block driver

Re: [git:v4l-dvb/for_v3.3] [media] dvb_frontend: Don't use ops->info.type anymore

2012-01-06 Thread Mauro Carvalho Chehab
On 06-01-2012 22:36, Oliver Endriss wrote: > On Wednesday 04 January 2012 20:29:36 Mauro Carvalho Chehab wrote: >> drivers/media/dvb/dvb-core/dvb_frontend.c | 541 >> ++--- >> 1 files changed, 266 insertions(+), 275 deletions(-) >> ... >> -static int dvb_frontend_check_pa

Re: Pause/Resume and flush for V4L2 codec drivers.

2012-01-06 Thread vkalia
Thanks Hans. Yes it does solve a part of my problem - Pause/Resume. But I dont see any command defined for Flush yet. Do you think we should add one more command to Flush. Also, I see two more commands #define V4L2_DEC_CMD_START (0) #define V4L2_DEC_CMD_STOP(1) How should I use the

Re: [PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'

2012-01-06 Thread Oliver Endriss
On Friday 06 January 2012 20:11:56 Mauro Carvalho Chehab wrote: > On 04-01-2012 16:45, Oliver Endriss wrote: > > Fix regression introduced by commit '[media] Remove Annex A/C selection via > > roll-off factor' > > As a result of this commit, DVB-T tuning did not work anymore. > > > > Signed-off-b

Re: [git:v4l-dvb/for_v3.3] [media] dvb_frontend: Don't use ops->info.type anymore

2012-01-06 Thread Oliver Endriss
On Wednesday 04 January 2012 20:29:36 Mauro Carvalho Chehab wrote: > drivers/media/dvb/dvb-core/dvb_frontend.c | 541 > ++--- > 1 files changed, 266 insertions(+), 275 deletions(-) > ... > -static int dvb_frontend_check_parameters(struct dvb_frontend *fe, > -

cx231xx: possible circular locking dependency detected on 3.2

2012-01-06 Thread Thomas Petazzoni
Hello, I'm running the Hauppauge USB-Live 2 device on an ARM OMAP3 platform. After loading the cx231xx driver and launching v4l2grab, I immediately get: [ 407.087158] cx231xx #0: setPowerMode::mode = 48, No Change req. [ 407.145477] [ 407.147064] =

Re: [PATCH] rc-videomate-m1f.c Rename to match remote controler name

2012-01-06 Thread Samuel Rakitničan
On Fri, 06 Jan 2012 17:32:06 +0100, Samuel Rakitničan wrote: This remote was added with support for card Compro VideoMate M1F. This remote is shipped with various Compro cards, not this one only. Furthermore this remote can be bought separately under name Compro VideoMate K100. http

Re: em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Mario Ceresa
Hi Mauro, Here it is. Does the "Signed-off-by:" go in the changelog, right? Many thanks to all the developers for the hard work: it is a joy to see the card working :) Best, Mario On 6 January 2012 20:21, Mauro Carvalho Chehab wrote: > On 06-01-2012 17:16, Mario Ceresa wrote: >> Hello Devin, y

Re: em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Mauro Carvalho Chehab
On 06-01-2012 17:16, Mario Ceresa wrote: > Hello Devin, you're right: here it goes! Hi Mario, Plese send it with your Signed-off-by: It is a requirement for merging the patches upstream. > > Best, > > Mario > > On 6 January 2012 19:33, Devin Heitmueller > wrote: >> On Fri, Jan 6, 2012 at 1:

Re: em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Mario Ceresa
Hello Devin, you're right: here it goes! Best, Mario On 6 January 2012 19:33, Devin Heitmueller wrote: > On Fri, Jan 6, 2012 at 1:29 PM, Mario Ceresa wrote: >> Ok boys: just to let you know that everything works now. >> >> thinking that the problem was with the audio input, I noticed that >> c

Re: [PATCH] drxk: Fix regression introduced by commit '[media] Remove Annex A/C selection via roll-off factor'

2012-01-06 Thread Mauro Carvalho Chehab
On 04-01-2012 16:45, Oliver Endriss wrote: > Fix regression introduced by commit '[media] Remove Annex A/C selection via > roll-off factor' > As a result of this commit, DVB-T tuning did not work anymore. > > Signed-off-by: Oliver Endriss > > diff --git a/drivers/media/dvb/frontends/drxk_hard.c

Re: [PATCH 0/2] Re: [git:v4l-dvb/for_v3.3] [media] dvb-bt8xx: handle errors from dvb_net_init

2012-01-06 Thread Mauro Carvalho Chehab
On 06-01-2012 16:25, Jonathan Nieder wrote: > Hi Mauro, > > Mauro Carvalho Chehab wrote: > >> Subject: [media] dvb-bt8xx: handle errors from dvb_net_init > [...] >> [mchehab.redhat.com: codingstyle fix: printk() should include KERN_ facility >> level] > [...] >> --- a/drivers/media/dvb/bt8xx/dvb

cron job: media_tree daily build: ERRORS

2012-01-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Jan 6 19:00:28 CET 2012 git hash:bcd158de94238d90adf7275548f0aaf2de724ab1 gcc version: i686-linux-gcc (GCC

[PATCH] [media] dm1105: release dvbnet on frontend attachment failure

2012-01-06 Thread Jonathan Nieder
The patch "dm1105: handle errors from dvb_net_init" moved the initialization of dvbnet to before frontend attachment but forgot to adjust the error handling when frontend attachment fails. Signed-off-by: Jonathan Nieder --- Mauro Carvalho Chehab wrote: > Subject: [media] dm1105: handle errors fr

Re: em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Devin Heitmueller
On Fri, Jan 6, 2012 at 1:29 PM, Mario Ceresa wrote: > Ok boys: just to let you know that everything works now. > > thinking that the problem was with the audio input, I noticed that > card=64 had an amux while card=19 no. > > .amux     = EM28XX_AMUX_LINE_IN, > > So I tried this card and modified t

Re: em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Mario Ceresa
Ok boys: just to let you know that everything works now. thinking that the problem was with the audio input, I noticed that card=64 had an amux while card=19 no. .amux = EM28XX_AMUX_LINE_IN, So I tried this card and modified the mplayer options accordingly: mplayer -tv device=/dev/video0:i

[PATCH 2/2] [media] dvb-bt8xx: convert printks to pr_err()

2012-01-06 Thread Jonathan Nieder
This module does some printks with the loglevel missing. pr_err() takes care of adding the KERN_ERR tag and the module name. So we can simplify the code and add the missing printk loglevel by using it. Also add a #define pr_fmt() to make this work, and remove a few unnecessary periods at the end

[PATCH 1/2] [media] dvb-bt8xx: use dprintk for debug statements

2012-01-06 Thread Jonathan Nieder
This way, the messages will be tagged with KERN_DEBUG and not clutter the log from dmesg unless the "debug" module parameter is set. Signed-off-by: Jonathan Nieder --- drivers/media/dvb/bt8xx/dvb-bt8xx.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/

[PATCH 0/2] Re: [git:v4l-dvb/for_v3.3] [media] dvb-bt8xx: handle errors from dvb_net_init

2012-01-06 Thread Jonathan Nieder
Hi Mauro, Mauro Carvalho Chehab wrote: > Subject: [media] dvb-bt8xx: handle errors from dvb_net_init [...] > [mchehab.redhat.com: codingstyle fix: printk() should include KERN_ facility > level] [...] > --- a/drivers/media/dvb/bt8xx/dvb-bt8xx.c > +++ b/drivers/media/dvb/bt8xx/dvb-bt8xx.c > @@ -7

Re: Multiple channel capture support in V4l2 layer

2012-01-06 Thread Dilip Mannil
Thanks Laurent.Found similar type of discussion in this thread http://www.mail-archive.com/linux-media@vger.kernel.org/msg38443.html On Tue, Jan 3, 2012 at 6:44 AM, Laurent Pinchart wrote: > Hi Dilip, > > On Friday 23 December 2011 19:57:22 Dilip Mannil wrote: >> Hi, >> I am trying to implement

[PATCH/RFC v2 3/4] gspca: sonixj: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-06 Thread Sylwester Nawrocki
The JPEG compression quality value can currently be read using the VIDIOC_G_JPEGCOMP ioctl. As the quality field of struct v4l2_jpgecomp is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY control, so after the deprecation period VIDIOC_G_JPEGCOMP ioctl handler can be removed, leaving

[PATCH/RFC v2 4/4] gspca: zc3xx: Add V4L2_CID_JPEG_COMPRESSION_QUALITY control support

2012-01-06 Thread Sylwester Nawrocki
The JPEG compression quality control is currently done by means of the VIDIOC_S/G_JPEGCOMP ioctls. As the quality field of struct v4l2_jpgecomp is being deprecated, we add the V4L2_CID_JPEG_COMPRESSION_QUALITY control, so after the deprecation period VIDIOC_S/G_JPEGCOMP ioctl handlers can be remove

[PATCH/RFC v2 2/4] V4L: Add JPEG compression control class documentation

2012-01-06 Thread Sylwester Nawrocki
Add DocBook entries for the JPEG control class. Signed-off-by: Sylwester Nawrocki --- Documentation/DocBook/media/v4l/biblio.xml | 20 +++ Documentation/DocBook/media/v4l/compat.xml | 10 ++ Documentation/DocBook/media/v4l/controls.xml | 161 Docum

[PATCH/RFC v2 1/4] V4L: Add JPEG compression control class

2012-01-06 Thread Sylwester Nawrocki
The V4L2_CID_JPEG_CLASS control class is intended to expose various adjustable parameters of JPEG encoders and decoders. Following controls are defined: - V4L2_CID_JPEG_CHROMA_SUBSAMPLING, - V4L2_CID_JPEG_RESTART_INTERVAL, - V4L2_CID_JPEG_COMPRESSION_QUALITY, - V4L2_CID_JPEG_ACTIVE_MARKER. Th

[PATCH/RFC v2 0/4] JPEG codecs control class

2012-01-06 Thread Sylwester Nawrocki
Hello, This patch set adds new control class - V4L2_CID_JPEG_CLASS with initially four controls in it. It also adds V4L2_CID_JPEG_COMPRESSION_QUALITY control to two gspca sub-devices: sonixj and zc3xx, as these where drivers I had the hardware handy for. The gspca patches have been tested with v4l

em28xx: no sound on board 1b80:e309 (sveon stv40)

2012-01-06 Thread Mario Ceresa
Hello again! I managed to obtain a nice video input from my sveon usb stick using last em28xx v4l drivers from git and giving the module the hint card=19. But I have no audio.The card works flawlessy in windows. The internal chipsets in the card are: - USB interface: em2860 - Audio ADC: emp202 -

Re: sveon stv40 usb stick

2012-01-06 Thread Mario Ceresa
Last updates. It works with em28xx module from v4l git as a card 19: # modprobe em28xx card=19 # echo 1b80 e309 > /sys/bus/usb/drivers/em28xx/new_id [plugged in the usb] and $ mplayer -tv device=/dev/video0:input=1:norm=PAL:alsa:immediatemode=0:audiorate=48000:amode=1:adevice=hw.2 tv:// But I h

Re: [RFC 16/17] smiapp: Add driver.

2012-01-06 Thread Sylwester Nawrocki
Hi Sakari, I have a just a few comments below. It was rather brief a review, given the size of the patch.. :-) On 12/20/2011 09:28 PM, Sakari Ailus wrote: > Add driver for SMIA++/SMIA image sensors. The driver exposes the sensor as > three subdevs, pixel array, binner and scaler --- in case the d

Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

2012-01-06 Thread Linus Torvalds
On Fri, Jan 6, 2012 at 8:19 AM, Arnd Bergmann wrote: > > For a simpler solution, we could keep the old warning message, but change > the logic from > > (.compat_ioctl == NULL || .compat_ioctl() == -ENOIOCTL) && (no generic > handler) > > to > > (.ioctl != NULL && .compat_ioctl == NULL) && (no gen

[PATCH] [media] flexcop: CodingStyle fix: don't use "if ((ret = foo()) < 0)"

2012-01-06 Thread Jonathan Nieder
Lift assignments from "if" conditionals for readability. No change in functionality intended. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Jonathan Nieder --- Mauro Carvalho Chehab wrote: > Subject: [media] flexcop: handle errors from dvb_net_init [...] > [mche...@redhat.com: CodingStyle

[PATCH] rc-videomate-m1f.c Rename to match remote controler name

2012-01-06 Thread Samuel Rakitničan
This remote was added with support for card Compro VideoMate M1F. This remote is shipped with various Compro cards, not this one only. Furthermore this remote can be bought separately under name Compro VideoMate K100. http://compro.com.tw/en/product/k100/k100.html So give it a proper na

Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

2012-01-06 Thread Arnd Bergmann
On Thursday 05 January 2012, Linus Torvalds wrote: > And finally, ENOIOCTLCMD is a way to say ENOTTY in a sane manner, and > will now be turned into ENOTTY for the user space return (not EINVAL - > I have no idea where that idiocy came from, but it's clearly confused, > although it's also clearly

Re: [PATCHv4 1/2] v4l: Add new framesamples field to struct v4l2_mbus_framefmt

2012-01-06 Thread Sakari Ailus
Hi Sylwester, On Wed, Jan 04, 2012 at 11:51:00PM +0100, Sylwester Nawrocki wrote: > On 01/04/2012 01:21 PM, Sakari Ailus wrote: > > On Sun, Jan 01, 2012 at 07:56:03PM +0100, Sylwester Nawrocki wrote: > >> On 12/31/2011 02:16 PM, Sakari Ailus wrote: > > Something else that should probably belon

Re: em2874 bulk endpoint support

2012-01-06 Thread Frank Schäfer
Am 06.01.2012 01:52, schrieb Devin Heitmueller: On Thu, Jan 5, 2012 at 6:16 PM, Dmitriy Fitisov wrote: Hello everyone, I know, Devin Heitmueller was about to add support for em2874 bulk endpoint. Is that still in plans? The project that I was slated to do this work for got cancelled, and the

[PULL] git://git.kernellabs.com/stoth/cx23885-hvr1850-fixups.git

2012-01-06 Thread Steven Toth
Mauro, Some changes to allow the querying of the NO_SIGNAL status feature on the cx25840 video decoder. The following changes since commit 45447e1e18131590203dba83f9044d6c48448e54:   [media] cx25840: Added g_std support to the video decoder driver (2012-01-04 19:16:15 -0500) are available in the

Re: [RFC 17/17] rm680: Add camera init

2012-01-06 Thread Sylwester Nawrocki
Hi Sakari, On 12/20/2011 09:28 PM, Sakari Ailus wrote: + +static int rm680_sec_camera_set_xshutdown(struct v4l2_subdev *subdev, u8 set) It may be more efficient to just use u32. +{ + gpio_set_value(SEC_CAMERA_RESET_GPIO, !!set); + return 0; +} + ... +void __init rm680_camera_in

Re: [PATCH FOR 3.3] VIDIOC_LOG_STATUS support for sub-devices

2012-01-06 Thread Sylwester Nawrocki
On 01/06/2012 03:38 PM, Mauro Carvalho Chehab wrote: On 31-12-2011 09:15, Sylwester Nawrocki wrote: Hi Mauro, The following changes since commit 3220eb73c5647af4c1f18e32c12dccb8adbac59d: s5p-fimc: Add support for alpha component configuration (2011-12-20 19:46:55 +0100) are available in th

Re: [PATCH 9/9] [media] firedtv: handle errors from dvb_net_init

2012-01-06 Thread Mauro Carvalho Chehab
On 31-12-2011 10:19, Jonathan Nieder wrote: > It is not common for dvb_net_init to fail, but after the patch > "dvb_net_init: return -errno on error" it can fail due to running out > of memory. Handle this. > >>From an audit of dvb_net_init callers. > > Signed-off-by: Jonathan Nieder > --- > Th

Re: sveon stv40 usb stick

2012-01-06 Thread Mario Ceresa
Hi again! following the thread "em28xx: new board id [eb1a:5051]" between Reuben and Gareth I was able to advance a little: 1) I opened the usn stick and my chipsets are: - USB interface: em2860 - Audio ADC: emp202 - Video ADC: saa7118h (philips) 2) I confirm that the stock em28xx driver can rec

Re: [PATCH FOR 3.3] VIDIOC_LOG_STATUS support for sub-devices

2012-01-06 Thread Mauro Carvalho Chehab
On 31-12-2011 09:15, Sylwester Nawrocki wrote: > Hi Mauro, > > The following changes since commit 3220eb73c5647af4c1f18e32c12dccb8adbac59d: > > s5p-fimc: Add support for alpha component configuration (2011-12-20 19:46:55 > +0100) > > are available in the git repository at: > git://git.infrad

Re: [RFC/PATCH 1/5] v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control

2012-01-06 Thread Sylwester Nawrocki
Hi Sakari, On 01/04/2012 03:04 PM, Sakari Ailus wrote: >> On 01/02/2012 12:16 PM, Laurent Pinchart wrote: * controls for starting/stopping auto focusing (V4L2_CID_FOCUS_AUTO == false) V4L2_CID_START_AUTO_FOCUS (button) - start auto focusing, V4L2_CID_STOP_AUTO_FOCUS

Re: [PATCHv4 1/2] v4l: Add new framesamples field to struct v4l2_mbus_framefmt

2012-01-06 Thread Sylwester Nawrocki
Hi Laurent, On 12/21/2011 01:20 AM, Laurent Pinchart wrote: > On Wednesday 14 December 2011 13:23:07 Sylwester Nawrocki wrote: >> The purpose of the new field is to allow the video pipeline elements >> to negotiate memory buffer size for compressed data frames, where >> the buffer size cannot be d

Re: [RFC/PATCH 1/5] v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control

2012-01-06 Thread Sylwester Nawrocki
Hi Sakari, On 01/04/2012 02:22 PM, Sakari Ailus wrote: >> The V4L2_CID_FOCUS_AUTO menu control has currently following items: >> 0 - V4L2_FOCUS_MANUAL, >> 1 - V4L2_FOCUS_AUTO, >> 2 - V4L2_FOCUS_AUTO_MACRO, >> 3 - V4L2_FOCUS_AUTO_CONTINUOUS. > > I would put the m

Re: [PATCH] vpif_capture.c: v4l2_device_register() is called too late in vpif_probe()

2012-01-06 Thread Mauro Carvalho Chehab
On 13-12-2011 10:19, Hadli, Manjunath wrote: > Hans, > > On Tue, Dec 13, 2011 at 15:14:42, Hans Verkuil wrote: >> The function v4l2_device_register() is called too late in vpif_probe(). >> This meant that vpif_obj.v4l2_dev is accessed before it is initialized which >> caused a crash. >> >> This u

Re: [RFC/PATCH] [media] dw2102: use symbolic names for dw2102_table indices

2012-01-06 Thread Mauro Carvalho Chehab
On 23-12-2011 21:00, Jonathan Nieder wrote: > dw2102_properties et al refer to entries in the USB-id table using > hard-coded indices, as in "&dw2102_table[6]", which means adding new > entries before the end of the list has the potential to introduce bugs > in code elsewhere in the file. > > Use

Re: Add support for new Terratec DVB USB IDs

2012-01-06 Thread Mauro Carvalho Chehab
On 22-12-2011 21:44, Jonathan Nieder wrote: > Hi, > > Eduard Bloch wrote[1]: > >> current revision of the Cinergy S2 USB box from Terratec seems to use >> another USB-IDs. The manufacturer provides patches at >> http://linux.terratec.de/tv_en.html and it seems like the only >> difference is reall

Re: Using OMAP3 ISP live display and snapshot sample applications

2012-01-06 Thread Laurent Pinchart
Hi James, On Friday 06 January 2012 07:24:54 James wrote: [snip] > After googling for the warning, I proceed with the following steps to > make the application on Steve's GNOME-R13 image from this site as it > has all the tools for native-compilation on the Tobi board. > > 1) Inside /usr/src/li

Re: Using OMAP3 ISP live display and snapshot sample applications

2012-01-06 Thread Laurent Pinchart
Hi James, On Wednesday 04 January 2012 08:07:23 James wrote: > On Tue, Jan 3, 2012 at 7:17 PM, Laurent Pinchart wrote: > > On Tuesday 03 January 2012 10:40:10 James wrote: > >> Hi Laurent, > >> > >> Happy New Year!! > > > > Thank you. Happy New Year to you as well. May 2012 bring you a workable

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-06 Thread Laurent Pinchart
Hi Sakari, On Friday 06 January 2012 12:27:03 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: > >> From: Sakari Ailus > >> > >> Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION > >> IOCTLs. They replace functionali

Re: [RFC 06/17] v4l: Add selections documentation.

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:27:58 Sakari Ailus wrote: [snip] > diff --git a/Documentation/DocBook/media/v4l/dev-subdev.xml > b/Documentation/DocBook/media/v4l/dev-subdev.xml index 0916a73..722db60 > 100644 > --- a/Documentation/DocBook/media/v4l/dev-subdev.xm

Re: [RFC 04/17] v4l: VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION IOCTLs

2012-01-06 Thread Sakari Ailus
Hi Laurent, Thanks for the comments! Laurent Pinchart wrote: > On Tuesday 20 December 2011 21:27:56 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Add support for VIDIOC_SUBDEV_S_SELECTION and VIDIOC_SUBDEV_G_SELECTION >> IOCTLs. They replace functionality provided by VIDIOC_SUBDEV_S_CROP and >

Re: Pause/Resume and flush for V4L2 codec drivers.

2012-01-06 Thread Hans Verkuil
On Friday, January 06, 2012 03:31:37 vka...@codeaurora.org wrote: > Hi > > I am trying to implement v4l2 driver for video decoders. The problem I am > facing is how to send pause/resume and flush commands from user-space to > v4l2 driver. I am thinking of using controls for this. Has anyone done >

[GIT PATCHES FOR 3.3] gspca: fixes and new driver, pwc: large cleanup

2012-01-06 Thread Hans de Goede
Hi Mauro (et all), Please pull from my tree for various gspca fixes, a new gspca sub driver and some major pwc driver cleanups, removing a lot of old driver specific API, per feature-removal-schedule.txt. The following changes since commit 6cb393c82255c448a92754f2a2a6b715bd9418dc: [media] drx

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Laurent Pinchart
Hi Sakari, On Friday 06 January 2012 11:22:00 Sakari Ailus wrote: > Sakari Ailus wrote: > ... > > > I put it there to limit the maximum to 8 instead of 9, but 9 would be > > equally good. I'll change it. > > Or not. 8 is still the index of the last value. min is one to start the > menu from the

Re: [RFC 07/17] v4l: Add pixelrate to struct v4l2_mbus_framefmt

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:27:59 Sakari Ailus wrote: > From: Sakari Ailus > > Pixelrate is an essential part of the image data parameters. Add this. > Together, the current parameters also define the frame rate. > > Sensors do not have a concept of frame ra

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Sakari Ailus
Sakari Ailus wrote: ... > I put it there to limit the maximum to 8 instead of 9, but 9 would be > equally good. I'll change it. Or not. 8 is still the index of the last value. min is one to start the menu from the second item. Would you like that to be changed to zero? -- Sakari Ailus sakari.ai

Re: [RFC 17/17] rm680: Add camera init

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:09 Sakari Ailus wrote: > This currently introduces an extra file to the arch/arm/mach-omap2 > directory: board-rm680-camera.c. Keeping the device tree in mind, the > context of the file could be represented as static data with one

Re: [RFC 03/17] vivi: Add an integer menu test control

2012-01-06 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch. Thanks for the review! > On Tuesday 20 December 2011 21:27:55 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Add an integer menu test control for the vivi driver. >> >> Signed-off-by: Sakari Ailus >> --- >> drivers/m

Re: [RFC 14/17] omap3isp: Use pixelrate from sensor media bus frameformat

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:06 Sakari Ailus wrote: > From: Sakari Ailus > > Configure the ISP based on the pixelrate in media bus frame format. > Previously the same was configured from the board code. > > Signed-off-by: Sakari Ailus > --- > drivers/med

Re: [RFC 02/17] v4l: Document integer menu controls

2012-01-06 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch. > > On Tuesday 20 December 2011 21:27:54 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Signed-off-by: Sakari Ailus >> --- >> Documentation/DocBook/media/v4l/compat.xml | 10 + >> Documentation/DocBook/m

Re: [RFC 12/17] omap3isp: Add lane configuration to platform data

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:04 Sakari Ailus wrote: > From: Sakari Ailus > > Add lane configuration (order of clock and data lane) to platform data on > both CCP2 and CSI-2. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/omap3isp/ispcsiphy.h

Re: [RFC 13/17] omap3isp: Configure CSI-2 phy based on platform data

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:05 Sakari Ailus wrote: > From: Sakari Ailus > > Configure CSI-2 phy based on platform data in the ISP driver rather than in > platform code. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/omap3isp/isp.c |

Re: [RFC 01/17] v4l: Introduce integer menu controls

2012-01-06 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the patch. Thanks for the review! > On Tuesday 20 December 2011 21:27:53 Sakari Ailus wrote: >> From: Sakari Ailus >> >> Create a new control type called V4L2_CTRL_TYPE_INTEGER_MENU. Integer menu >> controls are just like menu con

Re: [RFC 09/17] v4l: Add pad op for pipeline validation

2012-01-06 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Tuesday 20 December 2011 21:28:01 Sakari Ailus wrote: > From: Sakari Ailus > > smiapp_pad_ops.validate_pipeline is intended to validate the full pipeline > which is implemented by the driver to which the subdev implementing this op > belongs to. Should this