[PATCH] staging/media/as102: Don't call release_firmware() on uninitialized variable
If, in drivers/staging/media/as102/as102_fw.c::as102_fw_upload(), the call
cmd_buf = kzalloc(MAX_FW_PKT_SIZE, GFP_KERNEL);
should fail and return NULL so that we jump to the 'error:' label,
then we'll end up calling 'release_firmware(firmware);' with
'firmware' still uninitialized - not good.
The easy fix is to just initialize 'firmware' to NULL when we declare
it, since release_firmware() deals gracefully with being passed NULL
pointers.
Signed-off-by: Jesper Juhl
---
drivers/staging/media/as102/as102_fw.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Only compile tested.
diff --git a/drivers/staging/media/as102/as102_fw.c
b/drivers/staging/media/as102/as102_fw.c
index 43ebc43..1075fb1 100644
--- a/drivers/staging/media/as102/as102_fw.c
+++ b/drivers/staging/media/as102/as102_fw.c
@@ -165,7 +165,7 @@ error:
int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap)
{
int errno = -EFAULT;
- const struct firmware *firmware;
+ const struct firmware *firmware = NULL;
unsigned char *cmd_buf = NULL;
char *fw1, *fw2;
struct usb_device *dev = bus_adap->usb_dev;
--
1.7.9.4
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
libv4l: add Lenovo Thinkpad Edge E325 to upside down devices table
Hi,
Like the recently added Thinkpad X200 and X201 the Thinkpad Edge E325
apparently has its camera upside down. dmidecode and lsusb output is
attached. I have also confirmed that Debian's libv4l-0.8.6 with the
following entry added to its table makes the camera work:
{ 0x04f2, 0xb27c, 0, "LENOVO", "12973MG",
V4LCONTROL_HFLIPPED | V4LCONTROL_VFLIPPED },
It looks like v4l-utils git master does not know about this model yet.
My apologies if it does and I overlooked it (I only grepped through that
code, I did not run it).
Please let me know if you need more information (note I'm not subscribed
to the list, so please CC me).
Thanks,
--
Marien.
# dmidecode 2.11
SMBIOS 2.6 present.
58 structures occupying 1829 bytes.
Table at 0x000F9D00.
Handle 0x, DMI type 0, 24 bytes
BIOS Information
Vendor: LENOVO
Version: 8SET33WW (1.15 )
Release Date: 11/17/2011
Address: 0xE
Runtime Size: 128 kB
ROM Size: 2048 kB
Characteristics:
PCI is supported
PNP is supported
BIOS is upgradeable
BIOS shadowing is allowed
Boot from CD is supported
Selectable boot is supported
EDD is supported
3.5"/720 kB floppy services are supported (int 13h)
Print screen service is supported (int 5h)
8042 keyboard services are supported (int 9h)
Serial services are supported (int 14h)
Printer services are supported (int 17h)
CGA/mono video services are supported (int 10h)
ACPI is supported
USB legacy is supported
BIOS boot specification is supported
Targeted content distribution is supported
BIOS Revision: 1.15
Firmware Revision: 1.17
Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 12973MG
Version: ThinkPad Edge E325
Serial Number: LR8TVD8
UUID: 345E8401-507B-11CB-AC87-CAAA0B46EFF8
Wake-up Type: Power Switch
SKU Number: Not Specified
Family: ThinkPad Edge E325
Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
Manufacturer: LENOVO
Product Name: 12973MG
Version: Not Available
Serial Number: 1ZK9U21H1B9
Asset Tag: Not Available
Features:
Board is a hosting board
Board is replaceable
Location In Chassis: Not Available
Chassis Handle: 0x
Type: Unknown
Contained Object Handles: 0
Handle 0x0003, DMI type 3, 21 bytes
Chassis Information
Manufacturer: LENOVO
Type: Notebook
Lock: Not Present
Version: Not Available
Serial Number: LR8TVD8
Asset Tag: No Asset Information
Boot-up State: Unknown
Power Supply State: Unknown
Thermal State: Unknown
Security Status: Unknown
OEM Information: 0x
Height: Unspecified
Number Of Power Cords: Unspecified
Contained Elements: 0
Handle 0x0004, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1902
Internal Connector Type: None
External Reference Designator: Keyboard
External Connector Type: PS/2
Port Type: Keyboard Port
Handle 0x0005, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1900
Internal Connector Type: None
External Reference Designator: Touch Pad
External Connector Type: PS/2
Port Type: Mouse Port
Handle 0x0006, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1300
Internal Connector Type: None
External Reference Designator: External LAN
External Connector Type: RJ-45
Port Type: Network Port
Handle 0x0007, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1400
Internal Connector Type: None
External Reference Designator: Internal LAN
External Connector Type: RJ-45
Port Type: Network Port
Handle 0x0008, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1500
Internal Connector Type: None
External Reference Designator: USB 0
External Connector Type: Access Bus (USB)
Port Type: USB
Handle 0x0009, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1300A
Internal Connector Type: None
External Reference Designator: USB 1
External Connector Type: Access Bus (USB)
Port Type: USB
Handle 0x000A, DMI type 8, 9 bytes
Port Connector Information
Internal Reference Designator: J1500
Internal Connector Type: None
External Reference Designator: USB 2
External Connector
cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sat Mar 24 19:04:04 CET 2012 git hash:f92c97c8bd77992ff8bd6ef29a23dc82dca799cb gcc version: i686-linux-gcc (GCC) 4.6.2 host hardware:x86_64 host os: 3.1-2.slh.1-amd64 linux-git-arm-eabi-enoxys: ERRORS linux-git-arm-eabi-omap: ERRORS linux-git-armv5-ixp: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: OK linux-git-mips: WARNINGS linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS linux-2.6.31.12-i686: ERRORS linux-2.6.32.6-i686: ERRORS linux-2.6.33-i686: ERRORS linux-2.6.34-i686: WARNINGS linux-2.6.35.3-i686: WARNINGS linux-2.6.36-i686: WARNINGS linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2.1-i686: WARNINGS linux-3.3-rc1-i686: WARNINGS linux-2.6.31.12-x86_64: ERRORS linux-2.6.32.6-x86_64: ERRORS linux-2.6.33-x86_64: ERRORS linux-2.6.34-x86_64: WARNINGS linux-2.6.35.3-x86_64: WARNINGS linux-2.6.36-x86_64: WARNINGS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2.1-x86_64: WARNINGS linux-3.3-rc1-x86_64: WARNINGS apps: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 3.4] gspca for_v3.4
The following changes since commit f92c97c8bd77992ff8bd6ef29a23dc82dca799cb: [media] update CARDLIST.em28xx (2012-03-19 23:12:02 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v3.4 for you to fetch changes up to 9aadae9dfed054929f80c9f2a7e8b35b195f0b2a: gspca - sn9c20x: Change the exposure setting of Omnivision sensors (2012-03-24 13:33:42 +0100) Jean-François Moine (7): gspca - ov519: Add more information about probe problems gspca - sn9c20x: Change the number of the sensor mt9vprb gspca - sn9c20x: Add the sensor mt9vprb to the sensor ident table gspca - sn9c20x: Define more tables as constant gspca - sn9c20x: Set the i2c interface speed gspca - sn9c20x: Don't do sensor update before the capture is started gspca - sn9c20x: Change the exposure setting of Omnivision sensors drivers/media/video/gspca/ov519.c | 10 ++-- drivers/media/video/gspca/sn9c20x.c | 97 ++ 2 files changed, 68 insertions(+), 39 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[off-topic] Linux-media e-mail problems
Hi, FYI: I suddenly stopped receiving e-mails from this list last week, March 16th. Does anyone have an explanation for that? --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: dvb lock patch
Em 04-03-2012 17:49, Josu Lazkano escreveu:
> Hello all, I am using this patch to get virtual adapters for DVB
> devices:
> https://aur.archlinux.org/packages/sa/sascng-linux3-patch/sascng-linux3-patch.tar.gz
>
> Here is more info: https://aur.archlinux.org/packages.php?ID=51325
>
> Is it possible to add this patch on the dvb source?
>
> This patch is needed for people who not have a CI and need to create
> virtual adapters to get a working pay-tv system.
Please always send the diff, instead to a point to some tarball, otherwise
most developers won't care enough to see what's there.
Anyway:
> diff -Nur linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> --- linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> +++ linux-2.6.39/drivers/media/dvb/dvb-core/dvbdev.c
> @@ -83,8 +83,11 @@ static int dvb_device_open(struct inode *inode, struct
> file *file)
> file->f_op = old_fops;
> goto fail;
> }
> - if(file->f_op->open)
> + if(file->f_op->open) {
> + mutex_unlock(&dvbdev_mutex);
> err = file->f_op->open(inode,file);
> + mutex_lock(&dvbdev_mutex);
> + }
> if (err) {
> fops_put(file->f_op);
> file->f_op = fops_get(old_fops);
> --
>
That doesn't sound right to me, and can actually cause race issues.
Regards,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ViXS XCode 2100 Series TV NTSC/ATSC FM Tuner Card
Vikas N Kumar wrote: >Hi >I am interested to know if there exists any support for the ViXS XCode >2100 Series cards ? I have looked and not found any viable support for >the card chipset except for some forums mentioning "ivtv" as a driver. > >If there is anyone working on this or if there is some guidance I >would like to help out and provide support for this TV tuner card. > >Below are the full details of the card that I have. Any help or >information is appreciated ? > >Thanks. > > ># lspci -vv -d 1745: >02:00.0 Multimedia controller: ViXS Systems, Inc. XCode 2100 Series > Subsystem: ASUSTeK Computer Inc. Device 48b0 > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- >Stepping- SERR+ FastB2B- DisINTx- > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- >SERR-Latency: 0, Cache Line Size: 64 bytes > Interrupt: pin A routed to IRQ 10 > Region 0: Memory at fdf0 (64-bit, prefetchable) [size=1M] > Region 2: Memory at feaf (32-bit, non-prefetchable) [size=64K] > Region 4: I/O ports at > Capabilities: [40] Power Management version 2 > Flags: PMEClk- DSI- D1+ D2- AuxCurrent=375mA >PME(D0+,D1+,D2-,D3hot+,D3cold-) > Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- > Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+ > Address: Data: > Capabilities: [60] Express (v1) Endpoint, MSI 00 > DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <128ns, > L1 ><2us > ExtTag- AttnBtn- AttnInd- PwrInd- RBE- FLReset- > DevCtl: Report errors: Correctable- Non-Fatal- Fatal- > Unsupported- > RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop- > MaxPayload 128 bytes, MaxReadReq 512 bytes > DevSta: CorrErr- UncorrErr+ FatalErr- UnsuppReq+ AuxPwr- > TransPend- > LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Latency > L0 ><4us, L1 <64us > ClockPM- Surprise- LLActRep- BwNot- > LnkCtl: ASPM Disabled; RCB 128 bytes Disabled- Retrain- CommClk+ > ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- > LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ > DLActive- >BWMgmt- ABWMgmt- > Capabilities: [100 v1] Advanced Error Reporting > UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- >MalfTLP- ECRC- UnsupReq+ ACSViol- > UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- >MalfTLP- ECRC- UnsupReq- ACSViol- > UESvrt: DLP+ SDES- TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ >MalfTLP+ ECRC- UnsupReq- ACSViol- > CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr- > CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr- > AERCap: First Error Pointer: 14, GenCap+ CGenEn- ChkCap+ ChkEn- > Capabilities: [140 v1] Virtual Channel > Caps: LPEVC=0 RefClk=100ns PATEntryBits=1 > Arb:Fixed- WRR32- WRR64- WRR128- > Ctrl: ArbSelect=Fixed > Status: InProgress- > VC0:Caps: PATOffset=00 MaxTimeSlots=1 RejSnoopTrans- > Arb:Fixed- WRR32- WRR64- WRR128- TWRR128- WRR256- > Ctrl: Enable+ ID=0 ArbSelect=Fixed TC/VC=ff > Status: NegoPending- InProgress- > > >-- >http://www.vikaskumar.org/ >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" >in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html Hi, ivtv will never support this chip; the hardware is not even close to a CX23415/6. ViXS has never openly released any documentation. They do have a linux sdk. Hitachi supposedly used it for one of their TVs. -Andy -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
