Re: How fix driver for this USB camera (MT9T031 sensor and Cypress FX2LP USB bridge)

2012-05-17 Thread Jean-Francois Moine
On Wed, 16 May 2012 22:14:48 + (UTC) Simon Gustafsson sim...@simong.se wrote: 2) Where should I begin? My gut feeling is to go for media/video/gspca/ov519.c, since it has the code for talking to the USB bridge chip (BRIDGE_OVFX2), and Hi Simon, The FX2 is a processor, and, in ov519,

bug report: null dereference in error handling in mantis_dvb_init()

2012-05-17 Thread Dan Carpenter
Hi, I'm working on some new Smatch stuff and so I'm finding old bugs and emailing bug reports. This is a semi-automatic email about new static checker warnings. The patch 68fe255cd15c: V4L/DVB (13799): [Mantis] Unregister frontend from Dec 4, 2009, leads to the following Smatch complaint:

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-05-17 Thread Hans Verkuil
On Thu May 17 2012 04:46:37 Jun Nie wrote: Is there any discussion on HDCP on the summit? It is tightly coupled with HDMI and DVI and should be managed together with the transmitter. But there is not code to handle HDCP in DRM/FB/V4L in latest kernel. Any thoughts on HDCP? Or you guys

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread Thomas Mair
On 17.05.2012 05:40, poma wrote: […] v4-1-5-rtl2832-ver.-0.4-v2.diff Oh thanks. That Makefile is haunting me badly ;) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] [resend] radio-sf16fmr2: add PnP support for SF16-FMD2

2012-05-17 Thread Ondrej Zary
Add PnP support to radio-sf16fmr2 driver to support SF16-FMD2 card (SB16 + TEA5757). The driver can now handle two cards (FMR2 is hardwired to 0x384, FMD2 can be put at 0x384 or 0x284 by PnP). Tested with both SF16-FMR2 and SF16-FMD2 (the can work at the same time by using kernel parameter

Re: [PATCH] [resend] radio-sf16fmr2: add PnP support for SF16-FMD2

2012-05-17 Thread Hans Verkuil
On Thu May 17 2012 10:55:01 Ondrej Zary wrote: Add PnP support to radio-sf16fmr2 driver to support SF16-FMD2 card (SB16 + TEA5757). The driver can now handle two cards (FMR2 is hardwired to 0x384, FMD2 can be put at 0x384 or 0x284 by PnP). Tested with both SF16-FMR2 and SF16-FMD2 (the can work

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread Antti Palosaari
Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not see any big functiuonality problems - only some small issues that are likely considered as a coding style etc. Feel free to fix those and sent new patc serie or just new

Re: [PATCH v4 2/5] rtl28xxu: support for the rtl2832 demod driver

2012-05-17 Thread Antti Palosaari
Moikka Comments below. Reviewed-by: Antti Palosaari cr...@iki.fi On 17.05.2012 01:13, Thomas Mair wrote: This only adds support for the Terratec Cinergy T Stick Black device. Signed-off-by: Thomas Mairthomas.mai...@googlemail.com --- drivers/media/dvb/dvb-usb/Kconfig |3 +

Re: [PATCH v4 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr

2012-05-17 Thread Antti Palosaari
On 17.05.2012 01:13, Thomas Mair wrote: Signed-off-by: Thomas Mairthomas.mai...@googlemail.com Acked-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-usb/rtl28xxu.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git

Re: [PATCH v4 4/5] rtl28xxu: support G-Tek Electronics Group Lifeview LV5TDLX DVB-T

2012-05-17 Thread Antti Palosaari
On 17.05.2012 01:13, Thomas Mair wrote: Signed-off-by: Thomas Mairthomas.mai...@googlemail.com Nacked. Better PID definition is required. --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h |1 + drivers/media/dvb/dvb-usb/rtl28xxu.c| 11 ++- 2 files changed, 11 insertions(+), 1

Re: [PATCH v4 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick

2012-05-17 Thread Antti Palosaari
On 17.05.2012 01:13, Thomas Mair wrote: Signed-off-by: Hans-Frieder Vogthfv...@gmx.net Signed-off-by: Thomas Mairthomas.mai...@googlemail.com Acked-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h |1 + drivers/media/dvb/dvb-usb/rtl28xxu.c| 27

Re: [PATCH v4 0/5] support for rtl2832

2012-05-17 Thread Antti Palosaari
On 17.05.2012 01:13, Thomas Mair wrote: This is the new version of the patch series to add support for the rtl2832 demodulator driver. Before applying the patches you need to add the fc0012/fc0013 driver from Hans-Frider Vogt. Who wants to review those tuner drivers? The changes from the

[PATCH 00/10] SMIA(++) driver improvements, fixes

2012-05-17 Thread Sakari Ailus
Hi, This patchset contains a few improvements and fixes to the SMIA++ driver. Perhaps most importantly, it's no longer necessary to use board code to use the driver: alternatively a clock name can be provided instead of a function to configure the external clock. The platform data function to

[PATCH 01/10] smiapp: Allow using external clock from the clock framework

2012-05-17 Thread Sakari Ailus
Instead of providing a function in platform data, allow also providing the name of the external clock and use it through the clock framework. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c | 55 ++

[PATCH 02/10] smiapp: Pass struct sensor to register writing commands instead of i2c_client

2012-05-17 Thread Sakari Ailus
Pass struct sensor to register access commands. This allows taking quirks into account in register access. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c | 154 ++---

[PATCH 03/10] smiapp: Quirk for sensors that only do 8-bit reads

2012-05-17 Thread Sakari Ailus
Some sensors implement only 8-bit read functionality and fail on wider reads. Add a quirk flag for such sensors. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-quirk.h |1 + drivers/media/video/smiapp/smiapp-regs.c | 73

[PATCH 05/10] smiapp: Round minimum pre_pll up rather than down in ip_clk_freq check

2012-05-17 Thread Sakari Ailus
The pre_pll divisor must be such that ext_clk / pre_pll divisor does not result in a frequency that is greater than pll_ip_clk_freq. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp-pll.c |5 +++-- 1 files changed, 3 insertions(+),

[PATCH 04/10] smiapp: Use 8-bit reads only before identifying the sensor

2012-05-17 Thread Sakari Ailus
Some sensors only allow 8-bit access, so use safe 8-bit access before the sensor has been identified. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c | 63 -- 1 files changed, 34 insertions(+), 29

[PATCH 07/10] smiapp: Use non-binning limits if the binning limit is zero

2012-05-17 Thread Sakari Ailus
Some sensors do use binning but do not have valid limits in binning registers. Use non-binning limits in that case. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c | 31 +++-- 1 files changed, 28

[PATCH 09/10] smiapp: Add support for 8-bit uncompressed formats

2012-05-17 Thread Sakari Ailus
Add support for uncompressed 8-bit raw bayer formats. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/smiapp/smiapp-core.c

[PATCH 08/10] smiapp: Allow generic quirk registers

2012-05-17 Thread Sakari Ailus
Implement more generic quirk registers than just limit and capability registers. This comes with the expense of a little bit more access time so these should be only used when really needed. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com ---

[PATCH 10/10] smiapp: Use v4l2_ctrl_new_int_menu() instead of v4l2_ctrl_new_custom()

2012-05-17 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- drivers/media/video/smiapp/smiapp-core.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/media/video/smiapp/smiapp-core.c b/drivers/media/video/smiapp/smiapp-core.c index

cron job: media_tree daily build: ERRORS

2012-05-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu May 17 19:00:18 CEST 2012 git hash:61282daf505f3c8def09332ca337ac257b792029 gcc version: i686-linux-gcc

[PATCH 1/2] dvb_cmd_name function

2012-05-17 Thread André Roth
--- lib/include/dvb-fe.h |1 + lib/libdvbv5/dvb-fe.c | 21 +++-- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/lib/include/dvb-fe.h b/lib/include/dvb-fe.h index 872a558..b4c5279 100644 --- a/lib/include/dvb-fe.h +++ b/lib/include/dvb-fe.h @@ -108,6 +108,7

[PATCH 2/2] ignore user commands on fe

2012-05-17 Thread André Roth
--- lib/libdvbv5/dvb-fe.c | 32 lib/libdvbv5/dvb-v5-std.c |2 ++ 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c index 4f7a217..a91dd65 100644 --- a/lib/libdvbv5/dvb-fe.c +++

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread poma
On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not see any big functiuonality problems - only some small issues that are likely considered as a coding style etc. Feel free

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread Thomas Mair
On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not see any big functiuonality problems - only

Re: Fwd: Bug#669715: dvb-apps: Channel/frequency/etc. data needs updating for London transmitters

2012-05-17 Thread Thomas Kernen
On 5/14/12 1:54 PM, Andrew Benham wrote: I don't know if it's just Crystal Palace, but one of the multiplexes thinks it's using QPSK even though it's using QAM64 - this messes up 'scan' unless one reorders the frequency list. Having done the scan, one then needs to replace 'QPSK' by 'QAM_64' in

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread Antti Palosaari
On 17.05.2012 23:45, Thomas Mair wrote: On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not see

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread poma
On 05/17/2012 10:49 PM, Antti Palosaari wrote: On 17.05.2012 23:45, Thomas Mair wrote: On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that

Re: [PATCH] V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE]

2012-05-17 Thread Sakari Ailus
On Mon, May 14, 2012 at 07:17:03PM +0200, Sylwester Nawrocki wrote: This patch drops the _ACTIVE part from the selection target names as a prerequisite to unify the selection target names on subdevs and regular video nodes. Although not exactly the same, the meaning of V4L2_SEL_TGT_*_ACTIVE

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread poma
On 05/17/2012 10:45 PM, Thomas Mair wrote: On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not

[PATCH 1/1] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-05-17 Thread Sakari Ailus
The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE] by Sylwester Nawrocki. This patch does the same for the V4L2 subdev API. Signed-off-by: Sakari Ailus

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread Thomas Mair
On 17.05.2012 23:08, poma wrote: On 05/17/2012 10:45 PM, Thomas Mair wrote: On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread poma
On 05/17/2012 11:19 PM, Thomas Mair wrote: On 17.05.2012 23:08, poma wrote: On 05/17/2012 10:45 PM, Thomas Mair wrote: On 17.05.2012 22:41, Antti Palosaari wrote: On 17.05.2012 23:27, poma wrote: On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments

Re: [PATCH 1/1] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-05-17 Thread Sylwester Nawrocki
Hi Sakari, thanks for the patch. On 05/17/2012 11:15 PM, Sakari Ailus wrote: The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE] by Sylwester Nawrocki.

[PATCH] em28xx: simple comment fix

2012-05-17 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/video/em28xx/em28xx-dvb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index 3a5b89d..16410ac 100644 ---

[PATCH 1/2] drxk: fix GPIOs

2012-05-17 Thread Antti Palosaari
UIO-2 and UIO-3 were broken. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/frontends/drxk_hard.c |4 ++-- drivers/media/dvb/frontends/drxk_map.h |2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/frontends/drxk_hard.c

[PATCH 2/2] em28xx: disable LNA - PCTV QuatroStick nano (520e)

2012-05-17 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/video/em28xx/em28xx-dvb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index ea3810f..3a5b89d 100644 ---

Re: [PATCH 1/1] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-05-17 Thread Sakari Ailus
Hi Sylwester, On Thu, May 17, 2012 at 11:37:47PM +0200, Sylwester Nawrocki wrote: Hi Sakari, thanks for the patch. On 05/17/2012 11:15 PM, Sakari Ailus wrote: The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename

[PATCH 3/3] libscan renamings

2012-05-17 Thread André Roth
--- lib/include/libscan.h | 12 ++-- lib/libdvbv5/libscan.c |6 +++--- utils/dvb/dvbv5-scan.c |4 ++-- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/lib/include/libscan.h b/lib/include/libscan.h index bc11ce1..a2b061c 100644 --- a/lib/include/libscan.h +++

Re: [PATCH 1/1] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-05-17 Thread Sylwester Nawrocki
Hi Sakari, On 05/18/2012 12:35 AM, Sakari Ailus wrote: ... On 05/17/2012 11:15 PM, Sakari Ailus wrote: The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to

[PATCH] au0828: Add USB ID used by many dongles

2012-05-17 Thread Ismael Luceno
Tested with Yfeng 680 ATV dongle. Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/video/au0828/au0828-cards.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/video/au0828/au0828-cards.c index

[PATCH] au0828: Move the Kconfig knob under V4L_USB_DRIVERS

2012-05-17 Thread Ismael Luceno
This driver is for USB devices, but was incorrectly listed under V4L_PCI_DRIVERS. Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/video/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/Kconfig

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-17 Thread poma
On 05/17/2012 04:19 PM, Antti Palosaari wrote: Moikka Thomas, Here is the review. See comments below. And conclusion is that it is ready for the Kernel merge. I did not see any big functiuonality problems - only some small issues that are likely considered as a coding style etc. Feel free

Re: [PATCH] dma-buf: mmap support

2012-05-17 Thread Sumit Semwal
Hi Daniel, Rob, On 11 May 2012 21:00, Rob Clark rob.cl...@linaro.org wrote: On Tue, Apr 24, 2012 at 4:08 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: Compared to Rob Clark's RFC I've ditched the prepare/finish hooks snip Cc: Rob Clark rob.cl...@linaro.org Cc: Rebecca Schultz Zavin