Re: [PATCH v5 0/5] support for rtl2832

2012-05-18 Thread poma
On 05/18/2012 08:47 PM, Thomas Mair wrote: > Good Evening! > > This is the corrected version of the patch series to support the > RTL2832 demodulator. There where no major changes. The majority of > the changes consist in fixing style issues and adhering to proper > naming conventions. > > The n

Re: [PATCH v5 0/5] support for rtl2832

2012-05-18 Thread poma
On 05/18/2012 10:47 PM, Antti Palosaari wrote: > Good evening! > > On 18.05.2012 21:47, Thomas Mair wrote: >> Good Evening! >> >> This is the corrected version of the patch series to support the >> RTL2832 demodulator. There where no major changes. The majority of >> the changes consist in fixing

[Fixed PATCH] libdvbv5: constify and hide dvb_sat_lnb

2012-05-18 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/include/dvb-fe.h |2 +- lib/include/libsat.h |2 +- lib/libdvbv5/libsat.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/include/dvb-fe.h b/lib/include/dvb-fe.h index 872a558..062edd8 100644 --- a/lib/include/dvb-fe.h

[PATCH] libdvbv5: constify and hide dvb_sat_lnb

2012-05-18 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/include/dvb-fe.h |2 +- lib/include/libsat.h |2 +- lib/libdvbv5/libsat.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/include/dvb-fe.h b/lib/include/dvb-fe.h index 872a558..062edd8 100644 --- a/lib/include/dvb-fe.h ++

Re: [PATCH v5 0/5] support for rtl2832

2012-05-18 Thread Antti Palosaari
Good evening! On 18.05.2012 21:47, Thomas Mair wrote: Good Evening! This is the corrected version of the patch series to support the RTL2832 demodulator. There where no major changes. The majority of the changes consist in fixing style issues and adhering to proper naming conventions. Review

Re: PCTV 290e with DVB-C on Fedora 16?

2012-05-18 Thread Antti Palosaari
On 18.05.2012 23:27, Niklas Brunlid wrote: On 18 May 2012 15:01, Antti Palosaari wrote: On 18.05.2012 11:38, Niklas Brunlid wrote: That whole issues is related of MFE (multi-frontend) => SFE (single-frontend) change. Yes, that I have understood. But from the threads on the MythTV lists belo

Re: [PATCH v5 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick

2012-05-18 Thread Antti Palosaari
On 18.05.2012 21:47, Thomas Mair wrote: Signed-off-by: Hans-Frieder Vogt Signed-off-by: Thomas Mair Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majo

Re: [PATCH v5 2/5] rtl28xxu: support for the rtl2832 demod driver

2012-05-18 Thread Antti Palosaari
On 18.05.2012 21:47, Thomas Mair wrote: This only adds support for the Terratec Cinergy T Stick Black device. Changes from previous patches: - fixed compiler warnings - added fc0013 tuner handling to this patch Signed-off-by: Thomas Mair Acked-by: Antti Palosaari Reviewed-by: Antti Palosaar

Re: [PATCH v5 4/5] rtl28xxu: support Delock USB 2.0 DVB-T

2012-05-18 Thread Antti Palosaari
On 18.05.2012 21:47, Thomas Mair wrote: Signed-off-by: Thomas Mair Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v5 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr

2012-05-18 Thread Antti Palosaari
On 18.05.2012 21:47, Thomas Mair wrote: Signed-off-by: Thomas Mair Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majord

Re: PCTV 290e with DVB-C on Fedora 16?

2012-05-18 Thread Niklas Brunlid
On 18 May 2012 15:01, Antti Palosaari wrote: > On 18.05.2012 11:38, Niklas Brunlid wrote: > > That whole issues is related of MFE (multi-frontend) => SFE > (single-frontend) change. Yes, that I have understood. But from the threads on the MythTV lists below, it seems at least one user has one or

Re: [PATCH v5 1/5] rtl2832 ver. 0.5: support for RTL2832 demod

2012-05-18 Thread Antti Palosaari
On 18.05.2012 21:47, Thomas Mair wrote: Changelog for ver. 0.5: - fixed code style and naming errors Changelog for ver. 0.4: - removed statistics as their calculation was wrong - fixed bug in Makefile - indentation and code style improvements Signed-off-by: Thomas Mair Reviewed-by: Antti Palo

Re: [GIT PULL FOR v3.5] Fix gspca compile error if CONFIG_PM is not set

2012-05-18 Thread Sylwester Nawrocki
Hi Hans, On 05/18/2012 01:43 PM, Hans Verkuil wrote: > The field 'frozen' is only there if CONFIG_PM is set, so don't use it > directly, always check for CONFIG_PM first. If it is safe to assume that for !CONFIG_PM the field 'frozen' is always zero, wouldn't it be better to create a macro in a he

Re: [PATCH] rtl2830: implement .read_snr()

2012-05-18 Thread Antti Palosaari
On 16.05.2012 01:32, Antti Palosaari wrote: Reports value as a 0.1 dB. Drop this patch. I just PULL requested new one. regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 1/5] rtl2832 ver 0.3: suport for RTL2832 demodulator revised version

2012-05-18 Thread Antti Palosaari
On 14.05.2012 04:37, Antti Palosaari wrote: +else { +/* if_agc is read as a 10bit binary */ +ret = rtl2832_rd_demod_reg(priv, DVBT_IF_AGC_VAL,&if_agc_raw); +if (ret) +goto err; + +if (if_agc_raw< (1<< 9)) +if_agc = if_agc_raw

[GIT PULL FOR 3.5] RTL2831U changes

2012-05-18 Thread Antti Palosaari
Moikka Mauro, PULL these for 3.5. The following changes since commit a73d06b082bdf3eccfa910de75242798ff272a4e: em28xx: disable LNA - PCTV QuatroStick nano (520e) (2012-05-18 21:23:05 +0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git rtl2831u Antti Pal

[PATCH v5 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick

2012-05-18 Thread Thomas Mair
Signed-off-by: Hans-Frieder Vogt Signed-off-by: Thomas Mair --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h |1 + drivers/media/dvb/dvb-usb/rtl28xxu.c| 11 ++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/d

[PATCH v5 4/5] rtl28xxu: support Delock USB 2.0 DVB-T

2012-05-18 Thread Thomas Mair
Signed-off-by: Thomas Mair --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h |1 + drivers/media/dvb/dvb-usb/rtl28xxu.c| 11 ++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h index cd9

[PATCH v5 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr

2012-05-18 Thread Thomas Mair
Signed-off-by: Thomas Mair --- drivers/media/dvb/dvb-usb/rtl28xxu.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/rtl28xxu.c b/drivers/media/dvb/dvb-usb/rtl28xxu.c index 5285f3d..5586715 100644 --- a/drivers/

[PATCH v5 2/5] rtl28xxu: support for the rtl2832 demod driver

2012-05-18 Thread Thomas Mair
This only adds support for the Terratec Cinergy T Stick Black device. Changes from previous patches: - fixed compiler warnings - added fc0013 tuner handling to this patch Signed-off-by: Thomas Mair --- drivers/media/dvb/dvb-usb/Kconfig |3 + drivers/media/dvb/dvb-usb/dvb-usb-ids.h |

[PATCH v5 1/5] rtl2832 ver. 0.5: support for RTL2832 demod

2012-05-18 Thread Thomas Mair
Changelog for ver. 0.5: - fixed code style and naming errors Changelog for ver. 0.4: - removed statistics as their calculation was wrong - fixed bug in Makefile - indentation and code style improvements Signed-off-by: Thomas Mair --- drivers/media/dvb/frontends/Kconfig|7 + drivers/

[PATCH v5 0/5] support for rtl2832

2012-05-18 Thread Thomas Mair
Good Evening! This is the corrected version of the patch series to support the RTL2832 demodulator. There where no major changes. The majority of the changes consist in fixing style issues and adhering to proper naming conventions. The next question for me is how to proceed when including new de

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-18 Thread Antti Palosaari
On 18.05.2012 20:46, Thomas Mair wrote: On 18.05.2012 15:26, poma wrote: On 05/18/2012 02:38 PM, Antti Palosaari wrote: On 18.05.2012 13:38, poma wrote: […] printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) pr_err(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg)

cron job: media_tree daily build: ERRORS

2012-05-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri May 18 19:00:17 CEST 2012 git hash:61282daf505f3c8def09332ca337ac257b792029 gcc version: i686-linux-gcc (GC

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-18 Thread Thomas Mair
On 18.05.2012 15:26, poma wrote: > On 05/18/2012 02:38 PM, Antti Palosaari wrote: >> On 18.05.2012 13:38, poma wrote: >>> […] >>> >>> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >>> pr_err(LOG_PREFIX": " f "\n" , ## arg) >>> >>> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >>> pr_info(LOG_P

Re: [PATCH v3 07/10] arm: omap4430sdp: Add support for omap4iss camera

2012-05-18 Thread Sergio Aguirre
Hi Sakari, On Sun, May 13, 2012 at 7:24 PM, Sakari Ailus wrote: > Hi Sergio, > > On Thu, May 03, 2012 at 10:20:47PM -0500, Aguirre, Sergio wrote: >> Hi Sakari, >> >> On Thu, May 3, 2012 at 7:03 AM, Aguirre, Sergio wrote: >> > Hi Sakari, >> > >> > Thanks for reviewing. >> > >> > On Wed, May 2, 20

Re: How I must report that a driver has been broken?

2012-05-18 Thread Devin Heitmueller
On Fri, May 18, 2012 at 10:15 AM, Alfredo Jesús Delaiti wrote: > Hi > > Thank you all for your responses. > > Devin, I appreciate the time and labor you do to revise the code. > > My previous letters maybe I can help you see where the problem and the date > you began. > I thought of a patch of thi

Re: How I must report that a driver has been broken?

2012-05-18 Thread Alfredo Jesús Delaiti
Hi Thank you all for your responses. Devin, I appreciate the time and labor you do to revise the code. My previous letters maybe I can help you see where the problem and the date you began. I thought of a patch of this type: if (card != mycard) { "bad code for my card"} but unfortunately n

[PATCH 1/1] rc-loopback: remove duplicate line

2012-05-18 Thread Michel Machado
This patch just removes the second assignment "rc->priv = &loopdev;" that happens a fews lines after the first one. Signed-off-by: Michel Machado CC: Mauro Carvalho Chehab CC: "David Härdeman" --- diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c index efc6a51..fae16

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-18 Thread poma
On 05/18/2012 02:38 PM, Antti Palosaari wrote: > On 18.05.2012 13:38, poma wrote: >> […] >> >> printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) >> pr_err(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) >> pr_info(LOG_PREFIX": " f "\n" , ## arg) >> >> printk(KER

Re: How fix driver for this USB camera (MT9T031 sensor and Cypress FX2LP USB bridge)

2012-05-18 Thread Simon Gustafsson
Jean-Francois Moine free.fr> writes: > The FX2 is a processor, and, in ov519, used as a bridge, it has been > programmed by OmniVision for their sensors. It is quite sure that its > firmware is different in your webcam. > > To know more, you should examine USB traces done with some other driver

Re: PCTV 290e with DVB-C on Fedora 16?

2012-05-18 Thread Antti Palosaari
On 18.05.2012 11:38, Niklas Brunlid wrote: That whole issues is related of MFE (multi-frontend) => SFE (single-frontend) change. And there is still known issues like only one frontend parameters, as we still have three different delivery systems Due to that currently applications should no

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-18 Thread Antti Palosaari
On 18.05.2012 13:38, poma wrote: […] printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) pr_err(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) pr_info(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) pr_warn(LOG_PREFIX": " f "\n"

Re: [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework

2012-05-18 Thread Hans de Goede
Hi, Thanks for the patches. I've added them all to my tree, so they will be included in my next pull-req. In the mean time you can find them (unmodified) here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.5-wip On 05/16/2012 11:42 PM, Antonio Ospite wrote: Hi, th

Re: [PATCH 0/2] media_build: fix compilation on old kernels (<2.6.34)

2012-05-18 Thread Hans Verkuil
On Wed May 16 2012 12:44:08 Gianluca Gennari wrote: > This patches fix compilation of the media_build tree on kernels older than > 2.6.34. > > Tested on kernel 2.6.32 (Ubuntu 10.04). Applied the patches, thanks! Regards, Hans > > Gianluca Gennari (2): > media_build: add SET_SYSTEM_

[GIT PULL FOR v3.5] Fix gspca compile error if CONFIG_PM is not set

2012-05-18 Thread Hans Verkuil
The field 'frozen' is only there if CONFIG_PM is set, so don't use it directly, always check for CONFIG_PM first. Regards, Hans The following changes since commit 61282daf505f3c8def09332ca337ac257b792029: [media] V4L2: mt9t112: fixup JPEG initialization workaround (2012-05-15 16:15:3

Re: [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework

2012-05-18 Thread Antonio Ospite
On Fri, 18 May 2012 09:08:29 +0200 Jean-Francois Moine wrote: > On Wed, 16 May 2012 23:42:43 +0200 > Antonio Ospite wrote: > > > The second patch removes the dependency between auto gain and auto white > > balance, I'd like to hear Jean-Francois on this, the webcam (the ov772x > > sensor) is ab

Re: [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics

2012-05-18 Thread poma
[…] printk(KERN_ERR LOG_PREFIX": " f "\n" , ## arg) pr_err(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_INFO LOG_PREFIX": " f "\n" , ## arg) pr_info(LOG_PREFIX": " f "\n" , ## arg) printk(KERN_WARNING LOG_PREFIX": " f "\n" , ## arg) pr_warn(LOG_PREFIX": " f "\n" , ## arg) Besides what 'checkpatc

Re: [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework

2012-05-18 Thread Jean-Francois Moine
On Wed, 16 May 2012 23:42:43 +0200 Antonio Ospite wrote: > The second patch removes the dependency between auto gain and auto white > balance, I'd like to hear Jean-Francois on this, the webcam (the ov772x > sensor) is able to set the two parameters independently and the user can > see the differ