Re: [RFC/PATCH v2] media: Add stk1160 new driver
Hi Ezequiel! On Sat June 2 2012 17:37:28 Ezequiel Garcia wrote: On Sat, Jun 2, 2012 at 12:32 PM, Ezequiel Garcia elezegar...@gmail.com wrote: This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a future replacement. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- As of today testing has been performed using both vlc and mplayer on a gentoo machine, including hot unplug and on-the-fly standard change using a device with 1-cvs and 1-audio output. However more testing is underway with another device and/or another distribution. Support for multiple input devices is a missing feature. Alsa sound support is a missing feature. (I'm working on both) As this is my first complete driver, the patch (obviously) intended as RFC only. Any comments/reviews of *any* kind will be greatly appreciated. This new version tries to solve the issues pointed out by Hans Verkuil and Sylwester Nawrocki (thanks to both!) Changes from v1: * Use media control framework * Register video device as the last thing * Use v4l_device release to release all resources * Add explicit locking for file operations * Add vb2 buffer sanity check * Minor style cleanups I'm adding v4l2-compliance -v 2 -d /dev/video1 output as requested by Hans. Thanks. I've fixed several things reported by v4l2-compliance (see my patch below), but you are using an older v4l2-compliance version. You should clone and compile the v4l-utils.git repository yourself, rather than using a distro provided version (which I think is what you are doing now). Can you apply my patch on yours and run the latest v4l2-compliance again? Driver Info: Driver name : stk1160 Card type : stk1160 Bus info : Driver version: 3.4.0 Capabilities : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video1 (not using libv4l2): Required ioctls: fail: v4l2-compliance.cpp(217): string empty warn: VIDIOC_QUERYCAP: empty bus_info test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK fail: v4l2-compliance.cpp(217): string empty warn: VIDIOC_QUERYCAP: empty bus_info test VIDIOC_QUERYCAP: OK fail: v4l2-compliance.cpp(273): doioctl(node, VIDIOC_G_PRIORITY, prio) test VIDIOC_G/S_PRIORITY: FAIL Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: FAIL fail: v4l2-test-debug.cpp(82): uid == 0 ret test VIDIOC_DBG_G/S_REGISTER: FAIL test VIDIOC_LOG_STATUS: FAIL Input ioctls: fail: v4l2-test-input-output.cpp(133): couldn't get tuner 0 test VIDIOC_G/S_TUNER: FAIL fail: v4l2-test-input-output.cpp(228): could get frequency for invalid tuner 0 test VIDIOC_G/S_FREQUENCY: FAIL fail: v4l2-test-input-output.cpp(358): could not enumerate audio input 0 test VIDIOC_ENUMAUDIO: FAIL test VIDIOC_G/S/ENUMINPUT: OK fail: v4l2-test-input-output.cpp(377): No audio inputs, but G_AUDIO did not return EINVAL fail: v4l2-test-input-output.cpp(421): invalid audioset for input 0 test VIDIOC_G/S_AUDIO: FAIL Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: fail: v4l2-test-input-output.cpp(479): couldn't get modulator 0 test VIDIOC_G/S_MODULATOR: FAIL fail: v4l2-test-input-output.cpp(563): could get frequency for invalid modulator 0 test VIDIOC_G/S_FREQUENCY: FAIL fail: v4l2-test-input-output.cpp(682): could not enumerate audio output 0 test VIDIOC_ENUMAUDOUT: FAIL test VIDIOC_G/S/ENUMOUTPUT: FAIL test VIDIOC_G/S_AUDOUT: Not Supported Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: info: checking v4l2_queryctrl of control 'User Controls' (0x00980001) info: checking v4l2_queryctrl of control 'Brightness' (0x00980900) info: checking v4l2_queryctrl of control 'Contrast' (0x00980901) info: checking v4l2_queryctrl of control 'Saturation' (0x00980902) info: checking v4l2_queryctrl of control 'Hue' (0x00980903) info: checking v4l2_queryctrl of control 'Chroma AGC' (0x0098091d) info: checking v4l2_queryctrl of control 'Chroma Gain' (0x00980924) info: checking v4l2_queryctrl of control 'Brightness' (0x00980900) info: checking v4l2_queryctrl of control 'Contrast' (0x00980901) info: checking v4l2_queryctrl of control 'Saturation' (0x00980902) info: checking v4l2_queryctrl of control 'Hue' (0x00980903) info: checking v4l2_queryctrl of
Re: Fwd: [Bug 827538] DVB USB device firmware requested in module_init()
On 12-06-02 10:44 PM, Antti Palosaari wrote: That solves DVB USB firmware loading problems. As in you have a patch that works or it's just solved in theory. If you have a patch I'd love to apply it here and get this machine suspendable again. Cheers, b. signature.asc Description: OpenPGP digital signature
Re: Fwd: [Bug 827538] DVB USB device firmware requested in module_init()
On 06/03/2012 05:38 PM, Brian J. Murrell wrote: On 12-06-02 10:44 PM, Antti Palosaari wrote: That solves DVB USB firmware loading problems. As in you have a patch that works or it's just solved in theory. If you have a patch I'd love to apply it here and get this machine suspendable again. I have patch which works but is as a proof-of-concept stage. I am just finalizing it. I will inform when it is ready, likely later tonight (as I would like to really see it fixes that suspend/resume problem as I am not able to reproduce it for some reason). regards Antit -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: WARNINGS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Jun 3 19:00:20 CEST 2012 git hash:5472d3f17845c4398c6a510b46855820920c2181 gcc version: i686-linux-gcc (GCC) 4.6.3 host hardware:x86_64 host os: 3.3-6.slh.2-amd64 linux-git-arm-eabi-davinci: WARNINGS linux-git-arm-eabi-exynos: WARNINGS linux-git-arm-eabi-omap: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: WARNINGS linux-git-mips: WARNINGS linux-git-powerpc64: WARNINGS linux-git-x86_64: WARNINGS linux-2.6.31.12-i686: WARNINGS linux-2.6.32.6-i686: WARNINGS linux-2.6.33-i686: WARNINGS linux-2.6.34-i686: WARNINGS linux-2.6.35.3-i686: WARNINGS linux-2.6.36-i686: WARNINGS linux-2.6.37-i686: WARNINGS linux-2.6.38.2-i686: WARNINGS linux-2.6.39.1-i686: WARNINGS linux-3.0-i686: WARNINGS linux-3.1-i686: WARNINGS linux-3.2.1-i686: WARNINGS linux-3.3-i686: WARNINGS linux-3.4-i686: WARNINGS linux-2.6.31.12-x86_64: WARNINGS linux-2.6.32.6-x86_64: WARNINGS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-x86_64: WARNINGS linux-2.6.35.3-x86_64: WARNINGS linux-2.6.36-x86_64: WARNINGS linux-2.6.37-x86_64: WARNINGS linux-2.6.38.2-x86_64: WARNINGS linux-2.6.39.1-x86_64: WARNINGS linux-3.0-x86_64: WARNINGS linux-3.1-x86_64: WARNINGS linux-3.2.1-x86_64: WARNINGS linux-3.3-x86_64: WARNINGS linux-3.4-x86_64: WARNINGS apps: WARNINGS spec-git: WARNINGS sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fwd: [Bug 827538] DVB USB device firmware requested in module_init()
On 06/03/2012 05:43 PM, Antti Palosaari wrote: On 06/03/2012 05:38 PM, Brian J. Murrell wrote: On 12-06-02 10:44 PM, Antti Palosaari wrote: That solves DVB USB firmware loading problems. As in you have a patch that works or it's just solved in theory. If you have a patch I'd love to apply it here and get this machine suspendable again. I have patch which works but is as a proof-of-concept stage. I am just finalizing it. I will inform when it is ready, likely later tonight (as I would like to really see it fixes that suspend/resume problem as I am not able to reproduce it for some reason). That firmware downloading patch is done top of my new dvb-usb development tree. I have converted very limited set of drivers for that tree, af9015, au6610, ec168 and anysee (and those are only on my local hard disk). I tried to backport patch for the current dvb-usb but I ran many problems and gave up. Looks like it is almost impossible to convert old dvb-usb without big changes... So what driver you are using? It is possible I can convert your driver too and then it is possible to test. Patch in question can be found from that tree: http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb-usb regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH v2] media: Add stk1160 new driver
Hi Hans, On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil hverk...@xs4all.nl wrote: [snip] Thanks. I've fixed several things reported by v4l2-compliance (see my patch below), but you are using an older v4l2-compliance version. You should clone and compile the v4l-utils.git repository yourself, rather than using a distro provided version (which I think is what you are doing now). Can you apply my patch on yours and run the latest v4l2-compliance again? Okey I'll do that, and send you the results. Below is my (untested) patch that should fix a number of things. BTW, I hate the use of current_norm, and in fact I plan to get rid of current_norm in the near future. So that's why I replaced it with g_std. Okey. I wasn't aware of that. I just saw it somewhere and I assumed it was *the right thing*. Thanks for your help :) See ya, Ezequiel. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH v2] media: Add stk1160 new driver
Hans, On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks. I've fixed several things reported by v4l2-compliance (see my patch below), but you are using an older v4l2-compliance version. You should clone and compile the v4l-utils.git repository yourself, rather than using a distro provided version (which I think is what you are doing now). Can you apply my patch on yours and run the latest v4l2-compliance again? I applied your patch, updated v4l2-compliance and here is the output: --- $ v4l2-compliance -d /dev/video1 Driver Info: Driver name : stk1160 Card type : stk1160 Bus info : usb-:00:13.2-1 Driver version: 3.4.0 Capabilities : 0x8501 Video Capture Read/Write Streaming Device Capabilities Device Caps : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video1 (not using libv4l2): Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: Not Supported test VIDIOC_DBG_G/S_REGISTER: Not Supported test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER: Not Supported test VIDIOC_G/S_FREQUENCY: Not Supported test VIDIOC_S_HW_FREQ_SEEK: Not Supported test VIDIOC_ENUMAUDIO: Not Supported test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: Not Supported Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: Not Supported test VIDIOC_G/S_FREQUENCY: Not Supported test VIDIOC_ENUMAUDOUT: Not Supported test VIDIOC_G/S/ENUMOUTPUT: Not Supported test VIDIOC_G/S_AUDOUT: Not Supported Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: test VIDIOC_QUERYCTRL/MENU: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: Not Supported Standard Controls: 7 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: Not Supported test VIDIOC_G/S_DV_TIMINGS: Not Supported Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: Not Supported test VIDIOC_G_FBUF: Not Supported test VIDIOC_G_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: Not Supported Total: 31 Succeeded: 31 Failed: 0 Warnings: 0 --- None failed! :-) Would you care to explain me this change in your patch? + set_bit(V4L2_FL_USE_FH_PRIO, dev-vdev.flags); I guess I can consider the video part as working (at least with a basic set of features). I'll be working on alsa and support for several inputs now. Thanks for reviewing! Ezequiel. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
