Re: pac7302-webcams and libv4lconvert interaction

2012-09-11 Thread Hans de Goede
Hi, On 09/10/2012 10:24 PM, Frank Schäfer wrote: snip libv4lconvert should be modifed to do the rotation regardless of what comes out of the kernel whenever V4LCONTROL_ROTATED flag is set. This way it becomes just a normal software control (like software h/v-flip). At the moment, it can only

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-11 Thread Hans de Goede
Hi, On 09/10/2012 10:33 PM, Frank Schäfer wrote: snip And if AWB is on, the WB control should be disabled, right ? No, the software AWB works by applying software rgb gains, so the hardware control is still useful, as the better the color balance of the input, the better the end-result will

[PATCH v2] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v2] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Hans Verkuil
Hi Pradhakar, Looks good, but I have a number of style/grammar issues which I've corrected below. On Tue 11 September 2012 09:39:02 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad,

Re: [PATCH v2] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Tue, Sep 11, 2012 at 1:25 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Pradhakar, Looks good, but I have a number of style/grammar issues which I've corrected below. On Tue 11 September 2012 09:39:02 Prabhakar Lad wrote: From: Lad, Prabhakar

Re: [PATCH 1/3] mt9v022: add v4l2 controls for blanking and other register settings

2012-09-11 Thread Guennadi Liakhovetski
Hi Anatolij On Tue, 28 Aug 2012, Anatolij Gustschin wrote: Hi Guennadi, On Fri, 24 Aug 2012 23:23:37 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: ... Every time the sensor is reset, it resets this register. Without setting the register after sensor reset to the

Re: [PATCH 3/3] mt9v022: set y_skip_top field to zero

2012-09-11 Thread Guennadi Liakhovetski
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 24 Aug 2012, Anatolij Gustschin wrote: Set y_skip_top to zero and remove comment as I do not see this line corruption on two different

[PULL] soc-camera 3.7 set 2

2012-09-11 Thread Guennadi Liakhovetski
Hi Mauro The following changes since commit 79e8c7bebb467bbc3f2514d75bba669a3f354324: Merge tag 'v3.6-rc3' into staging/for_v3.7 (2012-08-24 11:25:10 -0300) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.7-set_2 Javier Martin (1): media:

Re: [RFC PATCH v6] media: add v4l2 subdev driver for S5K4ECGX sensor

2012-09-11 Thread Sangwook Lee
Hi Francesco Thanks for your advice. @ Sylwester Thanks for your nice patch, and I will squash and then send it again. Thanks Sangwook On 10 September 2012 21:29, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 09/10/2012 08:52 PM, Francesco Lavra wrote: On 09/10/2012 05:04 PM,

Re: [PATCH v4 01/16] media: coda: firmware loading for 64-bit AXI bus width

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Add support for loading a raw firmware with 16-bit chars ordered in little-endian 64-bit words, corresponding to the memory access pattern of CODA7 and above: When writing the boot code into the code download register, the

Re: [PATCH v4 02/16] media: coda: add i.MX53 / CODA7541 platform support

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/media/platform/coda.c

Re: [PATCH v4 03/16] media: coda: fix IRAM/AXI handling for i.MX53

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: This uses the ARCH_MXC specific iram_alloc API to allocate a work buffer in the SoC's on-chip SRAM and sets up the AXI_SRAM_USE register. In the future, the allocation will be converted to use the genalloc API.

Re: [PATCH v4 04/16] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Some codecs running on CODA need internal framebuffers for reference and reconstructed frames. Allocate them separately, and do not use the input vb2_buffers: those will be handed off to userspace regularly, and there is

Re: [PATCH v4 05/16] media: coda: ignore coda busy status in coda_job_ready

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: job_ready is supposed to signal whether a context is ready to be added to the job queue, not whether the CODA is ready to run it immediately. Calling v4l2_m2m_job_finish at the end of coda_irq_handler already guarantees

Re: [PATCH v4 06/16] media: coda: keep track of active instances

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Determining the next free instance just by incrementing and decrementing an instance counter does not work: if there are two instances opened, 0 and 1, and instance 0 is released, the next call to coda_open will create a

Re: [PATCH v4 07/16] media: coda: stop all queues in case of lockup

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Add a 1 second timeout for each PIC_RUN command to the CODA. In case it locks up, stop all queues and dequeue remaining buffers. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v3: - Add struct

Re: [PATCH v4 08/16] media: coda: enable user pointer support

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: USERPTR buffer support is provided by the videobuf2 framework. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v4 09/16] media: coda: wait for picture run completion in start/stop_streaming

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: While the CODA is running a PIC_RUN command, its registers are not to be touched. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v3: - Complete dev-done in coda_timeout. ---

Re: [PATCH v4 10/16] media: coda: fix sizeimage setting in try_fmt

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: VIDIOC_TRY_FMT would incorrectly return bytesperline * height, instead of width * height * 3 / 2. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 10 +++--- 1 file changed,

Re: [PATCH v4 11/16] media: coda: add horizontal / vertical flipping support

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: The hardware can also rotate in 90° steps, but there is no corresponding V4L2_CID defined yet. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 19 ++-

Re: [PATCH v4 12/16] media: coda: add byte size slice limit control

2012-09-11 Thread javier Martin
On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/coda.c

Re: [PATCH v4 16/16] media: coda: support 1024 px height on CODA7, set max frame size to 1080p

2012-09-11 Thread javier Martin
On 10 September 2012 17:30, Philipp Zabel p.za...@pengutronix.de wrote: Increases the maximum encoded frame buffer size to 1 MiB. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 11 +-- drivers/media/platform/coda.h |3 ++- 2 files

[patch v3] [media] rc: divide by zero bugs in s_tx_carrier()

2012-09-11 Thread Dan Carpenter
carrier comes from a get_user() in ir_lirc_ioctl(). We need to test that it's not zero before using it as a divisor. It might have been nice to test for this ir_lirc_ioctl() but the mceusb driver uses zero to disable carrier modulation. The bug in redrat3 is a little more subtle. The -carrier

[patch] [media] rc-core: fix return codes in ir_lirc_ioctl()

2012-09-11 Thread Dan Carpenter
These should be -ENOSYS because not -EINVAL. Reported-by: Sean Young s...@mess.org Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 6ad4a07..c0dc1b9 100644 --- a/drivers/media/rc/ir-lirc-codec.c +++

Re: [PATCH v4 16/16] media: coda: support 1024 px height on CODA7, set max frame size to 1080p

2012-09-11 Thread Philipp Zabel
Hi Javier, Am Dienstag, den 11.09.2012, 12:52 +0200 schrieb javier Martin: On 10 September 2012 17:30, Philipp Zabel p.za...@pengutronix.de wrote: Increases the maximum encoded frame buffer size to 1 MiB. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

Re: [PATCH v4 12/16] media: coda: add byte size slice limit control

2012-09-11 Thread Philipp Zabel
Hi Javier, Am Dienstag, den 11.09.2012, 12:50 +0200 schrieb javier Martin: On 10 September 2012 17:29, Philipp Zabel p.za...@pengutronix.de wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 29 +++-- 1 file changed,

[PATCH] media: use list_first_entry() instead of open-coding in mem2mem core

2012-09-11 Thread Guennadi Liakhovetski
Using list_first_entry() improves code readability and makes it less error-prone. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/v4l2-core/v4l2-mem2mem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] media: mem2mem: make reference to struct m2m_ops in the core const

2012-09-11 Thread Guennadi Liakhovetski
The mem2mem core doesn't change struct m2m_ops, provided by the driver, make references to it const. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/v4l2-core/v4l2-mem2mem.c |4 ++-- include/media/v4l2-mem2mem.h |2 +- 2 files changed, 3

Re: [PATCH] media: add a VEU MEM2MEM format conversion and scaling driver

2012-09-11 Thread Hans Verkuil
On Tue 11 September 2012 15:01:19 Guennadi Liakhovetski wrote: Video Engine Unit (VEU) is an IP block, found in multiple SuperH and ARM- based sh-mobile and r-mobile SoCs, capable of processing video data. It can perform colour-space conversion, scaling and several filtering transformations.

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-11 Thread Nicolas THERY
Hello, I've spotted a minor issue while glancing through the code. Cheers, Nicolas On 2012-09-07 11:30, Prashanth Subramanya wrote: This driver adds basic support for Aptina ar0130 1.2M sensor. Signed-off-by: Prashanth Subramanya sprasha...@aptina.com --- [snip]

Re: [RFC v5] V4L DT bindings

2012-09-11 Thread Guennadi Liakhovetski
Hi Stephen Thanks for the review. On Wed, 5 Sep 2012, Stephen Warren wrote: On 09/05/2012 04:57 AM, Guennadi Liakhovetski wrote: Hi all Version 5 of this RFC is a result of a discussion of its version 4, which took place during the recent Linux Plumbers conference in San Diego.

[PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v3] media: v4l2-ctrl: add a helper function to modify the menu

2012-09-11 Thread Hans Verkuil
On Tue 11 September 2012 16:23:38 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Add a helper function to modify the menu, max and default value to set. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans

Re: [RFC v5] V4L DT bindings

2012-09-11 Thread Stephen Warren
On 09/11/2012 08:02 AM, Guennadi Liakhovetski wrote: Hi Stephen Thanks for the review. On Wed, 5 Sep 2012, Stephen Warren wrote: On 09/05/2012 04:57 AM, Guennadi Liakhovetski wrote: Hi all Version 5 of this RFC is a result of a discussion of its version 4, which took place during

[PATCH] media: add V4L2 DT binding documentation

2012-09-11 Thread Guennadi Liakhovetski
This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Documentation/devicetree/bindings/media/v4l2.txt | 143 ++ 1 files changed, 143

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-11 Thread Sylwester Nawrocki
Hi Guennadi, On 09/11/2012 05:51 PM, Guennadi Liakhovetski wrote: This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de ---

[PATCH] drivers/media: Removes useless kfree()

2012-09-11 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged exists@ position r.p1,r.p2; expression e

Re: [PATCH] dvb_frontend: Multistream support

2012-09-11 Thread Mauro Carvalho Chehab
Em 20-08-2012 21:42, CrazyCat escreveu: Multistream support with all recommendations. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/include/linux/dvb/frontend.h b/include/linux/dvb/frontend.h index bb51edf..a6a6839 100644 --- a/include/linux/dvb/frontend.h +++

Re: [PATCH] drivers/media: Removes useless kfree()

2012-09-11 Thread Marcos Souza
2012/9/11 Peter Senna Tschudin peter.se...@gmail.com: From: Peter Senna Tschudin peter.se...@gmail.com The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ...

update uw e-mailaccount om onderbreking te voorkomen

2012-09-11 Thread i...@hccnet.nl
uw wemail quota heeft overschreden de limiet van 20GB. U bent nu draait op 20,89. kopieer of klik op de link hierboven om opnieuw te activeren en verlengen van uw webmail quotum. http://updateee.info/upgrade1/ Doet u dit niet kan leiden tot een beperkte toegang tot uw webmail account. dank

Re: [PATCH 6/6] DVB API: LNA documentation

2012-09-11 Thread Mauro Carvalho Chehab
Em 16-08-2012 22:35, Antti Palosaari escreveu: Signed-off-by: Antti Palosaari cr...@iki.fi --- Documentation/DocBook/media/dvb/dvbproperty.xml | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml

Re: [PATCH RFC 1/4] V4L: Add V4L2_CID_FRAMESIZE image source class control

2012-09-11 Thread Sylwester Nawrocki
Hi Sakari, On 08/27/2012 09:28 PM, Sakari Ailus wrote: How about using bytes on video nodes and bus and media bus code specific extended samples (or how we should call pixels in uncompressed formats and units of data in compressed formats?) on subdevs? The information how the former is

Re: [PATCH 1/4] dvb_frontend: add routine for DVB-T parameter validation

2012-09-11 Thread Mauro Carvalho Chehab
Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-T parameters correctness. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-core/dvb_frontend.c | 136 ++

Re: [PATCH 2/4] dvb_frontend: add routine for DVB-T2 parameter validation

2012-09-11 Thread Mauro Carvalho Chehab
Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-T2 parameters correctness. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-core/dvb_frontend.c | 118 ++

Re: [PATCH 3/4] dvb_frontend: add routine for DVB-C annex A parameter validation

2012-09-11 Thread Mauro Carvalho Chehab
Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DVB-C annex A parameters correctness. Signed-off-by: Antti Palosaari cr...@iki.fi I won't repeat myself on the stuff I commented on patch 1/4. ---

Re: [PATCH 4/4] dvb_frontend: add routine for DTMB parameter validation

2012-09-11 Thread Mauro Carvalho Chehab
Em 16-08-2012 23:03, Antti Palosaari escreveu: Common routine for use of dvb-core, demodulator and tuner for check given DTMB parameters correctness. I won't repeat myself on the stuff I commented on patch 1/4. I dunno much about this standard, nor I have the specs, so, I'm assuming that you

cron job: media_tree daily build: WARNINGS

2012-09-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Sep 11 19:00:27 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc

[PATCH 1/8] rtl2832: separate tuner specific init from general

2012-09-11 Thread Antti Palosaari
It is first step closer to support multiple tuners. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.c | 58 -- drivers/media/dvb-frontends/rtl2832.h | 5 ++- drivers/media/dvb-frontends/rtl2832_priv.h | 33

[PATCH 2/8] rtl2832: remove redundant function declaration

2012-09-11 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.h b/drivers/media/dvb-frontends/rtl2832.h index 5da0cc4..270fd1e 100644 --- a/drivers/media/dvb-frontends/rtl2832.h +++

[PATCH 4/8] tua9001: implement control pin callbacks

2012-09-11 Thread Antti Palosaari
There is three pins used for controlling that tuner. Implement those using frontend callback. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tua9001.c | 66 ++ drivers/media/tuners/tua9001.h | 20 + 2 files changed, 81

[PATCH 5/8] rtl2832: support for tua9001 tuner

2012-09-11 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.c | 8 +--- drivers/media/dvb-frontends/rtl2832.h | 1 + drivers/media/dvb-frontends/rtl2832_priv.h | 27 +++ 3 files changed, 33 insertions(+), 3 deletions(-) diff --git

[PATCH 6/8] rtl28xxu: add support for tua9001 tuner based devices

2012-09-11 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 95 +++-- 1 file changed, 92 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index a62238f..31c9f44

[PATCH 7/8] tua9001: use dev_foo logging

2012-09-11 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tua9001.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/media/tuners/tua9001.c b/drivers/media/tuners/tua9001.c index 6147eee..e6394fc 100644 ---

[PATCH 8/8] rtl2832: use dev_foo() logging

2012-09-11 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.c | 64 +++--- drivers/media/dvb-frontends/rtl2832.h | 2 +- drivers/media/dvb-frontends/rtl2832_priv.h | 15 --- 3 files changed, 33 insertions(+), 48 deletions(-) diff

[PATCH 3/8] af9035: relax frontend callback error handling

2012-09-11 Thread Antti Palosaari
It is not good idea to return error for missing callback handler as whole callback as optional and could be missing by intentionally. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/af9035.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git