Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check

2012-09-17 Thread Scott Jiang
I was using 3.3 linux kernel. I will again check if videobuf2 in 3.5 has already fixed this issue. [snip..] Ok I just checked the vb2_dma_contig allocator and it has no major changes from my version, http://lxr.linux.no/linux+v3.5.3/drivers/media/video/videobuf2-dma-contig.c#L37 So, I

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Daniel Glöckner
On Sun, Sep 16, 2012 at 11:59:42PM +0200, Sylwester Nawrocki wrote: On 09/16/2012 05:33 PM, Laurent Pinchart wrote: On Sunday 16 September 2012 15:57:14 Hans Verkuil wrote: On Sat September 15 2012 22:16:24 Sylwester Nawrocki wrote: There is already lots of overhead related to the buffers

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-17 Thread Sascha Hauer
Hi Shawn, On Mon, Sep 17, 2012 at 01:34:29PM +0800, Shawn Guo wrote: The series enables multi-platform support for imx. Since the required frameworks (clk, pwm) and spare_irq have already been adopted on imx, the series is all about cleaning up mach/* headers. Along with the changes,

[PATCH 2/3] cx25821: Replace kmemdup for kstrdup and clean up

2012-09-17 Thread Peter Senna Tschudin
Replace kmemdup for kstrdup and cleanup related code. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/pci/cx25821/cx25821-audio-upstream.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH 3/3] cx25821: Cleanup filename assignment code

2012-09-17 Thread Peter Senna Tschudin
I'm pasting the original code and my proposal on the commit message for make it easy to compare the two versions. Line 62 of cx25821-audio-upstream.h contains: char *_defaultAudioName = /root/audioGOOD.wav; Original code after replace kmemdup for kstrdup, and after fix return error code: if

[PATCH 1/3] cx25821: fix error return code and clean up

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com The function cx25821_sram_channel_setup_upstream_audio always return zero, so the return value is not saved any more. Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the

[GIT PULL FOR v3.7] API fixes from the 2012 Media Workshop

2012-09-17 Thread Hans Verkuil
Hi all, This is the pull request for the API fixes that were discussed during the 2012 Media Workshop. Changes since RFCv3: - Dropped the monotonic clock changes from this series: Sakari will pick this up as a separate project. - Removed V4L2_BUF_TYPE_PRIVATE from cx18 and ivtv (was only ever

[GIT PULL FOR v3.7] Two fixes

2012-09-17 Thread Hans Verkuil
This pull request fixes a problem when using vb2_fop_read/write in non-blocking mode and a tuner-core issue when setting the audmode for a radio device. Regards, Hans The following changes since commit 36aee5ff9098a871bda38dbbdad40ad59f6535cf: [media] ir-rx51: Adjust dependencies

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

2012-09-17 Thread Guennadi Liakhovetski
Hi Shawn Thanks for the clean up. Would you like these patches to go via a single tree, presumably, arm-soc? In this case On Mon, 17 Sep 2012, Shawn Guo wrote: This is a piece of code becoming dead since commit 2c9ba37 ([media] V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA

[GIT PULL FOR v3.7] Two control framework enhancements

2012-09-17 Thread Hans Verkuil
This pull request adds two new features to the control framework: - a notify function that is needed to have a bridge driver be notified of subdevice control changes - a new filter function to have more control over which controls are added by v4l2_ctrl_add_handler. Both of these features

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 17-09-12 01:36, Antti Palosaari wrote: On 09/17/2012 01:10 AM, Oliver Schinagl wrote: On 09/16/12 19:25, Antti Palosaari wrote: On 09/16/2012 06:03 PM, Oliver Schinagl wrote: I don't have windows, so capturing using windows is near impossible. Also since the vendor driver used to work, I

Re: How to set pixelaspect in struct v4l2_cropcap returned by VIDIOC_CROPCAP?

2012-09-17 Thread Hans Verkuil
On Sun September 16 2012 18:49:00 Georgi Chorbadzhiyski wrote: On 9/16/12 7:28 PM, Hans Verkuil wrote: On Sun September 16 2012 17:32:52 Georgi Chorbadzhiyski wrote: Guys I'm adding v4l2 output device support for VLC/ffmpeg/libav (I'm using v4l2loopback [1] driver for testing) but I have a

Re: [PATCH 12/34] media: mx1_camera: remove the driver

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: The mx1_camera driver has been broken for a few release cycles since commit 6bd0812 (dmaengine: imx-dma: merge old dma-v1.c with imx-dma.c). It seems there is no one even compile tested it since then, as doing so will end up with the following error.

Re: How to set pixelaspect in struct v4l2_cropcap returned by VIDIOC_CROPCAP?

2012-09-17 Thread Georgi Chorbadzhiyski
Around 09/17/2012 11:22 AM, Hans Verkuil scribbled: On Sun September 16 2012 18:49:00 Georgi Chorbadzhiyski wrote: On 9/16/12 7:28 PM, Hans Verkuil wrote: On Sun September 16 2012 17:32:52 Georgi Chorbadzhiyski wrote: Guys I'm adding v4l2 output device support for VLC/ffmpeg/libav (I'm using

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: Use managed functions to clean up the error handling code and function mx2_camera_remove(). Along with the change, a few variables get removed from struct mx2_camera_dev. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Guennadi Liakhovetski

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Laurent Pinchart
Hi Sylwester, On Sunday 16 September 2012 23:59:42 Sylwester Nawrocki wrote: On 09/16/2012 05:33 PM, Laurent Pinchart wrote: On Sunday 16 September 2012 15:57:14 Hans Verkuil wrote: On Sat September 15 2012 22:16:24 Sylwester Nawrocki wrote: On 09/15/2012 02:35 PM, Hans Verkuil wrote:

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the controller type, and updates the platform code accordingly. As the result, mach/hardware.h inclusion gets removed from the driver. Signed-off-by: Shawn Guo

Re: [PATCH 14/34] dma: ipu: rename mach/ipu.h to include/linux/dma/ipu-dma.h

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: The header ipu.h really belongs to dma subsystem rather than imx platform. Rename it to ipu-dma.h and put it into include/linux/dma/. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Vinod Koul vinod.k...@intel.com Cc: Guennadi Liakhovetski

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Hans Verkuil
On Mon September 17 2012 11:18:58 Laurent Pinchart wrote: Hi Sylwester, On Sunday 16 September 2012 23:59:42 Sylwester Nawrocki wrote: On 09/16/2012 05:33 PM, Laurent Pinchart wrote: On Sunday 16 September 2012 15:57:14 Hans Verkuil wrote: On Sat September 15 2012 22:16:24 Sylwester

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Daniel Glöckner
On Mon, Sep 17, 2012 at 11:18:58AM +0200, Laurent Pinchart wrote: Well, ALSA allows you to switch between gettimeofday and monotonic. So in theory at least if an app selects gettimeofday for alsa, that app might also want to select gettimeofday for v4l2. Does it, in its kernel API ?

Re: pac7302-webcams and libv4lconvert interaction

2012-09-17 Thread Hans de Goede
Hi, On 09/16/2012 02:21 PM, Frank Schäfer wrote: Hi, Am 13.09.2012 14:05, schrieb Hans de Goede: Hi, On 09/12/2012 04:36 PM, Frank Schäfer wrote: snip And a negative side effect is, that unknown pac7302 devices (with no V4LCONTROL_ROTATED_90_JPEG entry in libv4lconvert) do not work. With

TerraTec Cinergy T PCIe dual freezes the system

2012-09-17 Thread Klaus-Dieter Möller
Hello everybody, I want to use 2 TerraTec Cinergy T PCIe dual PCIe-cards in the same system. Both cards are working without any problems if used standalone. If both cards are used parallel the hole system freezes mostly on loading the kernel modules. There are no error messages in the log

[PATCH] v4l2: spi modalias is an array

2012-09-17 Thread Alan Cox
From: Alan Cox a...@linux.intel.com We want to check the contents not the array itself versus NULL Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/v4l2-core/v4l2-common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-09-17 Thread Hans Verkuil
On Thu August 16 2012 16:02:00 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Hans Verkuil hans.verk...@cisco.com Acked-by: Hans Verkuil hans.verk...@cisco.com

[PATCH 0/7] s5p-fimc/mipi-csis drivers cleanup

2012-09-17 Thread Sylwester Nawrocki
This series is a cleanup of s5p-fimc/mipi-csis drivers and changes required for adding device tree support. It depends on Arnd's platform data headers cleanup patch: ARM: samsung: move platform_data definitions git.kernel.org/?p=linux/kernel/git/arm/arm-soc.git;a=commit;h=d7243bd51b783ffd2

[PATCH 4/7] s5p-csis: Replace phy_enable platform data callback with direct call

2012-09-17 Thread Sylwester Nawrocki
The phy_enable callback is common for all Samsung SoC platforms, replace it with direct function call so the MIPI-CSI2 DPHY control is also possible on device tree instantiated platforms. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

[PATCH 5/7] s5p-fimc: Remove unused platform data structure fields

2012-09-17 Thread Sylwester Nawrocki
alignment, fixed_phy_vdd and phy_enable fields are now unused so removed them. The data alignment is now derived directly from media bus pixel code, phy_enable callback has been replaced with direct function call and fixed_phy_vdd was dropped in commit 438df3ebe5f0ce408490a777a758d5905f0dd58f

[PATCH 6/7] s5p-csis: Allow to specify pixel clock's source through platform data

2012-09-17 Thread Sylwester Nawrocki
Depending on the sensor configuration it might be required to adjust the CSIS's output pixel clock so it is greater than its input pixel clock, in order to avoid the input data FIFO overflow. Use platform data to select SCLK_CSIS clock from CMU as a source, rather than CSI APB clock.

[PATCH 7/7] s5p-csis: Change regulator supply names

2012-09-17 Thread Sylwester Nawrocki
Rename the regulator supply names to more meaningful ones. It's a prerequisite for adding device tree support. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/mipi-csis.c | 6 +++--- 1 file changed,

Re: [PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Sylwester Nawrocki
On 09/17/2012 01:02 PM, Kukjin Kim wrote: Sylwester Nawrocki wrote: The MIPI-CSI2 bus data alignment is now being derived from the media bus pixel code, the drivers don't use the corresponding structure fields, so remove them. Also remove the s5p_csis_phy_enable callback which is now used

Re: [PATCH 00/34] i.MX multi-platform support

2012-09-17 Thread Arnd Bergmann
On Monday 17 September 2012, Sascha Hauer wrote: On Mon, Sep 17, 2012 at 01:34:29PM +0800, Shawn Guo wrote: The series enables multi-platform support for imx. Since the required frameworks (clk, pwm) and spare_irq have already been adopted on imx, the series is all about cleaning up mach/*

Re: [GIT PULL] Initial i.MX5/CODA7 support for the CODA driver

2012-09-17 Thread Philipp Zabel
Thank you Ezequiel, Am Samstag, den 15.09.2012, 10:41 -0300 schrieb Ezequiel Garcia: Hi Philipp, On Thu, Sep 13, 2012 at 1:40 PM, Philipp Zabel p.za...@pengutronix.de wrote: Hi Mauro, please pull the following patches that fix a few issues in the coda driver and add initial

[PATCH] [media] cx23885: Select drivers for Terratec Cinergy T PCIe Dual

2012-09-17 Thread Jean Delvare
The Terratec Cinergy T PCIe Dual is based on the CX23885, and uses MT2063, DRX-3913k and DRX-3916k chips, so select the relevant drivers. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Stefan Ringel linu...@stefanringel.de Cc: Mauro Carvalho Chehab mche...@infradead.org ---

Re: [PATCH v2 0/6] ds3000 improvements

2012-09-17 Thread Rémi Cardona
On 09/16/2012 03:26 AM, Antti Palosaari wrote: On 09/14/2012 12:27 PM, Rémi Cardona wrote: Hi all, Here is an updated and more complete patch series for ds3000. I've done my testing on top of kernel 3.5.2 and things look ok so far. Reviews and comments are again more than welcome. I

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 17-09-12 10:25, Oliver Schinagl wrote: On 17-09-12 01:36, Antti Palosaari wrote: On 09/17/2012 01:10 AM, Oliver Schinagl wrote: On 09/16/12 19:25, Antti Palosaari wrote: On 09/16/2012 06:03 PM, Oliver Schinagl wrote: I don't have windows, so capturing using windows is near impossible.

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 17-09-12 15:16, Antti Palosaari wrote: On 09/17/2012 04:02 PM, Oliver Schinagl wrote: On 17-09-12 10:25, Oliver Schinagl wrote: On 17-09-12 01:36, Antti Palosaari wrote: On 09/17/2012 01:10 AM, Oliver Schinagl wrote: On 09/16/12 19:25, Antti Palosaari wrote: On 09/16/2012 06:03 PM,

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread javier Martin
Hi, On 17 September 2012 11:11, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 17 Sep 2012, Shawn Guo wrote: Use managed functions to clean up the error handling code and function mx2_camera_remove(). Along with the change, a few variables get removed from struct mx2_camera_dev.

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

2012-09-17 Thread javier Martin
On 17 September 2012 10:18, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Shawn Thanks for the clean up. Would you like these patches to go via a single tree, presumably, arm-soc? In this case On Mon, 17 Sep 2012, Shawn Guo wrote: This is a piece of code becoming dead since commit

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread javier Martin
Hi Shawn, On 17 September 2012 11:21, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 17 Sep 2012, Shawn Guo wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the controller type, and updates the platform code accordingly. As the result,

[PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This replaces BUG_ON() calls with WARN_ON_ONCE(), and returns EINVAL if some parameter is NULL, as suggested by Jonathan and Mauro. The BUG_ON() call is too drastic to be used in this case. See the full discussion here: http://www.spinics.net/lists/linux-media/msg52462.html Cc: Jonathan Corbet

[PATCH 2/4] pwc: Add return code check at vb2_queue_init()

2012-09-17 Thread elezegarcia
From: Ezequiel Garcia elezegar...@gmail.com This function returns an integer and it's mandatory to check the return code. Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/pwc/pwc-if.c |4 +++- 1 files changed, 3 insertions(+),

[PATCH 3/4] vivi: Add return code check at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This function returns an integer and it's mandatory to check the return code. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/vivi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/vivi.c

[PATCH 4/4] uvc: Add return code check at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This function returns an integer and it's mandatory to check the return code. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/uvc/uvc_queue.c |8 ++-- drivers/media/usb/uvc/uvc_video.c |4 +++- drivers/media/usb/uvc/uvcvideo.h |2 +- 3 files changed,

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Antti Palosaari
On 09/17/2012 04:26 PM, Oliver Schinagl wrote: On 17-09-12 15:16, Antti Palosaari wrote: On 09/17/2012 04:02 PM, Oliver Schinagl wrote: On 17-09-12 10:25, Oliver Schinagl wrote: On 17-09-12 01:36, Antti Palosaari wrote: On 09/17/2012 01:10 AM, Oliver Schinagl wrote: On 09/16/12 19:25, Antti

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, javier Martin wrote: Hi Shawn, On 17 September 2012 11:21, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 17 Sep 2012, Shawn Guo wrote: It changes the driver to use platform_device_id rather than cpu_is_xxx to determine the controller type, and

Re: [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Hans Verkuil
On Mon September 17 2012 15:43:54 Ezequiel Garcia wrote: This replaces BUG_ON() calls with WARN_ON_ONCE(), and returns EINVAL if some parameter is NULL, as suggested by Jonathan and Mauro. The BUG_ON() call is too drastic to be used in this case. See the full discussion here:

[PATCH 2/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/i2c/msp3400-driver.c | 12

[PATCH 0/6] media: input: convert to c99 format

2012-09-17 Thread Shubhrajyoti D
The series tries to convert the i2c_msg to c99 struct. This may avoid issues like below if someone tries to add an element to the structure. http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html Special thanks to Julia Lawall for helping it automate. By the below script.

[PATCH 6/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---

[PATCH 5/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/radio/saa7706h.c |4

[PATCH 4/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/radio/radio-tea5764.c |

[PATCH 1/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/i2c/ks0127.c |4 ++-- 1

[PATCH 3/6] media: Convert struct i2c_msg initialization to C99 format

2012-09-17 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/i2c/tvaudio.c |4 ++--

Re: [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Jonathan Corbet
On Mon, 17 Sep 2012 16:10:43 +0200 Hans Verkuil hverk...@xs4all.nl wrote: Why WARN_ON_ONCE? I'd want to see this all the time, not just once. It's certainly better than BUG_ON, but I'd go for WARN_ON. I like WARN_ON_ONCE better, myself. Avoids the risk of spamming the logs, and once is

Re: [PATCH 0/6] media: input: convert to c99 format

2012-09-17 Thread Hans Verkuil
On Mon September 17 2012 17:22:27 Shubhrajyoti D wrote: The series tries to convert the i2c_msg to c99 struct. This may avoid issues like below if someone tries to add an element to the structure. http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html I'm OK with this provided

Re: [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Hans Verkuil
On Mon September 17 2012 17:36:36 Jonathan Corbet wrote: On Mon, 17 Sep 2012 16:10:43 +0200 Hans Verkuil hverk...@xs4all.nl wrote: Why WARN_ON_ONCE? I'd want to see this all the time, not just once. It's certainly better than BUG_ON, but I'd go for WARN_ON. I like WARN_ON_ONCE

Re: [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Jonathan Corbet
On Mon, 17 Sep 2012 17:41:24 +0200 Hans Verkuil hverk...@xs4all.nl wrote: However, videobuf2-core.c is a core function of a core module. So it will give this warning once for one driver, then another is loaded with the same problem and you'll get no warnings anymore. Unlikely scenario, but

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: On 09/16/2012 05:33 PM, Laurent Pinchart wrote: On Sunday 16 September 2012 15:57:14 Hans Verkuil wrote: On Sat September 15 2012 22:16:24 Sylwester Nawrocki wrote: On 09/15/2012 02:35 PM, Hans Verkuil wrote: If we switch all existing drivers to

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 17-09-12 15:52, Antti Palosaari wrote: On 09/17/2012 04:26 PM, Oliver Schinagl wrote: On 17-09-12 15:16, Antti Palosaari wrote: On 09/17/2012 04:02 PM, Oliver Schinagl wrote: On 17-09-12 10:25, Oliver Schinagl wrote: On 17-09-12 01:36, Antti Palosaari wrote: On 09/17/2012 01:10 AM,

Cinergy T Stick Dual RC (rev. 2)

2012-09-17 Thread Damien Bally
Hello I bought this card because it is supported since kernel 2.6.37 according to this page : http://linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC As it it was not recognized by OpenSuse 11.4 (the kernel just sees a keyboard) I googled a while and found that rev.2 was not (and

[PATCH v2] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This replaces BUG_ON() calls with WARN_ON(), and returns EINVAL if some parameter is NULL, as suggested by Jonathan and Mauro. The BUG_ON() call is too drastic to be used in this case. See the full discussion here: http://www.spinics.net/lists/linux-media/msg52462.html Cc: Jonathan Corbet

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-17 Thread Tejun Heo
On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: This patch set fixes a reproducible crash I'm seeing on a 3.4.10 kernel. flush_kthread_worker (which is different from flush_kthread_work) is initializing a kthread_work and a completion on the stack, then queuing it and calling

cron job: media_tree daily build: WARNINGS

2012-09-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Sep 17 19:00:18 CEST 2012 git hash:36aee5ff9098a871bda38dbbdad40ad59f6535cf gcc version: i686-linux-gcc

Re: [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability.

2012-09-17 Thread Sylwester Nawrocki
Hi Sakari, On 09/17/2012 07:19 PM, Sakari Ailus wrote: Sylwester Nawrocki wrote: On 09/16/2012 05:33 PM, Laurent Pinchart wrote: On Sunday 16 September 2012 15:57:14 Hans Verkuil wrote: On Sat September 15 2012 22:16:24 Sylwester Nawrocki wrote: On 09/15/2012 02:35 PM, Hans Verkuil wrote:

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-17 Thread Greg KH
On Mon, Sep 17, 2012 at 12:40:16PM -0700, Tejun Heo wrote: On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: This patch set fixes a reproducible crash I'm seeing on a 3.4.10 kernel. flush_kthread_worker (which is different from flush_kthread_work) is initializing a kthread_work

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 09/17/12 17:20, Oliver Schinagl wrote: If tuner communication is really working and it says chip id is 0x5a then it is different than driver knows. It could be new revision of tuner. Change chip_id to match 0x5a Ah, so it's called chip_id on one end, but tuner_id on the other end. If/when

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 09/17/12 17:20, Oliver Schinagl wrote: If tuner communication is really working and it says chip id is 0x5a then it is different than driver knows. It could be new revision of tuner. Change chip_id to match 0x5a Ah, so it's called chip_id on one end, but tuner_id on the other end. If/when

[PATCH 2/7] rtl28xxu: masked reg write

2012-09-17 Thread Antti Palosaari
Implement masked register write and use it. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 83 ++--- 1 file changed, 36 insertions(+), 47 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c

[PATCH 6/7] rtl2832: add configuration for e4000 tuner

2012-09-17 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.c | 4 drivers/media/dvb-frontends/rtl2832.h | 1 + drivers/media/dvb-frontends/rtl2832_priv.h | 37 ++ 3 files changed, 42 insertions(+) diff --git

[PATCH 3/7] rtl28xxu: do not return error for unimplemented fe callback

2012-09-17 Thread Antti Palosaari
Use of frontend callback is highly hardware design dependent and whole callback could be optional in many cases. Returning error by default when callback is not implemented is stupid. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 8 ++-- 1 file

[PATCH 4/7] rtl28xxu: move tuner probing to .read_config()

2012-09-17 Thread Antti Palosaari
Move rtl2831u tuner probing correct place. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 175 ++-- 1 file changed, 99 insertions(+), 76 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c

[PATCH 1/7] rtl28xxu: move tuner probing to .read_config()

2012-09-17 Thread Antti Palosaari
Move rtl2832u tuner probing correct place. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 351 drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 1 + 2 files changed, 175 insertions(+), 177 deletions(-) diff --git

[PATCH 7/7] rtl28xxu: use proper config for e4000 tuner

2012-09-17 Thread Antti Palosaari
Do not abuse anymore fc0012 tuner config. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

[PATCH 5/7] rtl28xxu: remove fc0013 tuner fe callback

2012-09-17 Thread Antti Palosaari
It is just stub implementation, remove it. Also add debug for beginning of fe callback. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Antti Palosaari
On 09/17/2012 11:43 PM, Oliver Schinagl wrote: On 09/17/12 17:20, Oliver Schinagl wrote: If tuner communication is really working and it says chip id is 0x5a then it is different than driver knows. It could be new revision of tuner. Change chip_id to match 0x5a Ah, so it's called chip_id on

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-17 Thread Oliver Schinagl
On 09/17/12 23:07, Antti Palosaari wrote: On 09/17/2012 11:43 PM, Oliver Schinagl wrote: On 09/17/12 17:20, Oliver Schinagl wrote: If tuner communication is really working and it says chip id is 0x5a then it is different than driver knows. It could be new revision of tuner. Change chip_id to

Terratec Cinergy T PCIe Dual doesn;t work nder the Xen hypervisor

2012-09-17 Thread Javier Marcet
Hi, I recently began to investigate the Xen hypervisor. One key piece of the server I'm using is its DVB tuners. I'm using a Terratec Cinergy T PCIe Dual. When running on bare metal it works relatively well (it has other bugs I'll report later), but when running on a dom0 under the Xen

Re: [PATCH 12/34] media: mx1_camera: remove the driver

2012-09-17 Thread Shawn Guo
On Mon, Sep 17, 2012 at 10:33:25AM +0200, Guennadi Liakhovetski wrote: Ok, it used to compile not-so-long-ago, but it doesn't seem to be cared for a lot lately. Let's give Paulius a bit more time to react to this mail, otherwise I'll have no objections. Just as an idea, to make it a bit

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

2012-09-17 Thread Shawn Guo
On Mon, Sep 17, 2012 at 10:18:42AM +0200, Guennadi Liakhovetski wrote: Hi Shawn Thanks for the clean up. Would you like these patches to go via a single tree, presumably, arm-soc? In this case Yes, to save the cross-tree dependency, I would like to have the series go via arm-soc tree as a

Re: Terratec Cinergy T PCIe Dual doesn;t work nder the Xen hypervisor

2012-09-17 Thread Devin Heitmueller
On Mon, Sep 17, 2012 at 8:05 PM, Javier Marcet jmar...@gmail.com wrote: Initially I thought Xen would be the cause of the problem, but after having written on the Xen development mailing list and talked about it with a couple developers, it isn't very clear where the problem is. So far I

Re: [PATCH] vpif: replace preset with the timings API.

2012-09-17 Thread Prabhakar Lad
Hi Mauro, On Wed, Aug 8, 2012 at 5:39 PM, Prabhakar Lad prabhakar@ti.com wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com ---

Re: [PATCH 0/2] Replace the obsolete preset API by timings API

2012-09-17 Thread Prabhakar Lad
Hi Mauro/Sekhar On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad prabhakar@ti.com wrote: This first patch replaces the obsolete preset API by timings API for davinci VPBE, appropriate chnages in machine file for dm644x in which VPBE is enabled. And the second patch adds support for timings