Re: [PATCH 1/2] [RFC] video: exynos mipi dsi: Making Exynos MIPI Complaint with CDF

2013-01-03 Thread Vikas Sajjan
Hi Sachin, Thanks for the comments. On Thu, Jan 3, 2013 at 11:14 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Vikas, Some nitpicks inline Subject: s/Complaint/Compliant Oops, nice catch. On 2 January 2013 18:47, Vikas C Sajjan vikas.saj...@linaro.org wrote: From: Vikas Sajjan

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Dan Carpenter
On Wed, Jan 02, 2013 at 06:31:53PM +1300, Tony Prisk wrote: On Wed, 2013-01-02 at 08:10 +0300, Dan Carpenter wrote: clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. I told Tony about this but everyone has been gone with end of year holidays so it hasn't been addressed. Tony,

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Julia Lawall
On Thu, 3 Jan 2013, Dan Carpenter wrote: On Wed, Jan 02, 2013 at 06:31:53PM +1300, Tony Prisk wrote: On Wed, 2013-01-02 at 08:10 +0300, Dan Carpenter wrote: clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. I told Tony about this but everyone has been gone with end of year

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Russell King - ARM Linux
On Thu, Jan 03, 2013 at 12:05:20PM +0300, Dan Carpenter wrote: On Wed, Jan 02, 2013 at 06:31:53PM +1300, Tony Prisk wrote: Why should a _consumer_ of a clock care? It is _very_ important that people get this idea - to a consumer, the struct clk is just an opaque cookie. The fact that it

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Russell King - ARM Linux
On Thu, Jan 03, 2013 at 10:14:13AM +0100, Julia Lawall wrote: On Thu, 3 Jan 2013, Dan Carpenter wrote: On Wed, Jan 02, 2013 at 06:31:53PM +1300, Tony Prisk wrote: On Wed, 2013-01-02 at 08:10 +0300, Dan Carpenter wrote: clk_get() returns NULL if CONFIG_HAVE_CLK is disabled. I

Re: DT bindings for subdevices

2013-01-03 Thread Laurent Pinchart
Hi, On Wednesday 02 January 2013 11:19:04 Guennadi Liakhovetski wrote: On Wed, 2 Jan 2013, Prabhakar Lad wrote: Hi, This is my first step towards DT support for media, Question might be bit amateur :) No worries, we're all doing our first steps in this direction right at the moment.

Re: [PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Tomasz Figa
Hi Vikas, On Wednesday 02 of January 2013 18:47:22 Vikas C Sajjan wrote: From: Vikas Sajjan vikas.saj...@linaro.org Signed-off-by: Vikas Sajjan vikas.saj...@linaro.org --- include/video/display.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/video/display.h

[PATCH 1/3 RESEND] s5p-mfc: Move firmware allocation point to avoid allocation problems

2013-01-03 Thread Kamil Debski
Move firmware allocation from open to probe to avoid problems when using CMA for allocation. In certain circumstances CMA may allocate buffer that is not in the beginning of the MFC memory area. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park

[PATCH 2/3 RESEND] s5p-mfc: Correct check of vb2_dma_contig_init_ctx return value

2013-01-03 Thread Kamil Debski
vb2_dma_contig_init_ctx returns an error if failed, NULL check is not necessary. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/3 RESEND] s5p-mfc: Change internal buffer allocation from vb2 ops to dma_alloc_coherent

2013-01-03 Thread Kamil Debski
Change internal buffer allocation from vb2 memory ops call to direct calls of dma_alloc_coherent. This change shortens the code and makes it much more readable. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Dan Carpenter
Come on... Don't say we haven't read comment. Obviously, the first thing we did was read that comment. I've read it many times at this point and I still think we should add in a bit which says: NOTE: Drivers should treat the return value as an opaque cookie and not dereference it. NULL

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Russell King - ARM Linux
On Thu, Jan 03, 2013 at 02:10:40PM +0300, Dan Carpenter wrote: Come on... Don't say we haven't read comment. Obviously, the first thing we did was read that comment. I've read it many times at this point and I still think we should add in a bit which says: So where does it give you in that

Re: [PATCH 133/493] remove use of __devexit_p

2013-01-03 Thread Guennadi Liakhovetski
Hi Bill On Mon, 19 Nov 2012, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Doesn't this also make the use of __refdata in many locations like this [snip] diff --git a/drivers/media/platform/soc_camera/sh_mobile_csi2.c

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Wed, 2 Jan 2013 00:38:50 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Tue, Jan 1, 2013 at 10:59 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Tue, 1 Jan 2013 22:18:49 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Tue, Jan 1, 2013 at 8:30 PM, Mauro Carvalho

[PATCH] adv7343: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/i2c/adv7343.c | 13 - 1 files changed, 4

[PATCH] ths7303: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/i2c/ths7303.c |3 +-- 1 files changed, 1 insertions(+), 2

[PATCH] tvp514x: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/i2c/tvp514x.c |8 ++-- 1 files changed, 2 insertions(+),

[PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/i2c/tvp7002.c | 10 ++ 1 files changed, 2

Re: [PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Thursday 03 January 2013 18:52:42 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli

Re: [PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Laurent Pinchart
On Thursday 03 January 2013 14:31:20 Laurent Pinchart wrote: On Thursday 03 January 2013 18:52:42 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com

Re: [PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Prabhakar Lad
Hi Laurent, Thanks for the quick review! On Thu, Jan 3, 2013 at 7:02 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Thursday 03 January 2013 14:31:20 Laurent Pinchart wrote: On Thursday 03 January 2013 18:52:42 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Dan Carpenter
On Thu, Jan 03, 2013 at 11:21:02AM +, Russell King - ARM Linux wrote: Maybe you don't realise, but IS_ERR(NULL) is false. Therefore, this falls into category (2). No, obviously, I know the difference between IS_ERR() and IS_ERR_OR_NULL(). That's how we started this thread. *shrug*.

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Russell King - ARM Linux
On Thu, Jan 03, 2013 at 04:45:54PM +0300, Dan Carpenter wrote: On Thu, Jan 03, 2013 at 11:21:02AM +, Russell King - ARM Linux wrote: Maybe you don't realise, but IS_ERR(NULL) is false. Therefore, this falls into category (2). No, obviously, I know the difference between IS_ERR() and

[media] rtl28xxu: add Gigabyte U7300 DVB-T Dongle

2013-01-03 Thread Alexander Inyukhin
Device with ID 1b80:d393 is the Gigabyte U7300 DVB-T dongle. It contains decoder Realtek RTL2832U and tuner Fitipower FC0012. Signed-off-by: Alexander Inyukhin shur...@sectorb.msk.ru diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

Re: [BUG] crystalhd git.linuxtv.org kernel driver: unable to handle kernel paging requests, improper (spin)locking(?) and paging

2013-01-03 Thread Oliver Schinagl
I actually am one of the few that has one of those decoders so should be able to test things when needed. Just let me know what to test and I will try to comply On 02-01-13 08:48, thomas schorpp wrote: Hello guys, I'm working on supporting BCM 970012/15 crystalhd decoder in userspace

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Klaus Schmidinger
On 03.01.2013 14:20, Mauro Carvalho Chehab wrote: Em Wed, 2 Jan 2013 00:38:50 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Tue, Jan 1, 2013 at 10:59 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Tue, 1 Jan 2013 22:18:49 +0530 Manu Abraham abraham.m...@gmail.com escreveu:

Re: cannot make this Asus my cinema-u3100miniplusv2 work under linux

2013-01-03 Thread Oliver Schinagl
You may want to read into oscam and maybe tvheadend or the likes. On 02-01-13 03:19, Renato Gallo wrote: anyone can explain to me why i cannot seem to catch anything else than rai and how can i use a legally bought scart into an omnikey reader to get scrambled channels ? Il 31/12/2012 21:09

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Antti Palosaari
On 01/01/2013 06:48 PM, Manu Abraham wrote: On Tue, Jan 1, 2013 at 8:30 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: [RFCv4] dvb: Add DVBv5 properties for quality parameters The DVBv3 quality parameters are limited on several ways: - Doesn't provide any way to indicate the

[PATCH] m5mols: Fix typo in get_fmt callback

2013-01-03 Thread Sylwester Nawrocki
The check of return value from __find_format() was inverted by mistake. This patch fixes regression introduced in commit 5565a2ad47 [media] m5mols: Protect driver data with a mutex Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 1/5] s5p-fimc: Avoid possible NULL pointer dereference in set_fmt op

2013-01-03 Thread Sylwester Nawrocki
This fixes following issue found with a static analysis tool: Pointer 'ffmt' returned from call to function 'fimc_capture_try_format' at line 1522 may be NULL and may be dereferenced at line 1535. Although it shouldn't happen in practice, add the NULL pointer check to be on the safe side.

[PATCH 2/5] s5p-fimc: Prevent potential buffer overflow

2013-01-03 Thread Sylwester Nawrocki
Replace the hard coded csi_sensors[] array size with a relevant constant to make sure we don't iterate beyond the actual array. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c |

[PATCH 3/5] s5p-fimc: Fix return value of __fimc_md_create_flite_source_links()

2013-01-03 Thread Sylwester Nawrocki
Make sure 'ret' is not used uninitialized. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/5] s5p-fimc: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-03 Thread Sylwester Nawrocki
From: Tony Prisk li...@prisktech.co.nz Replace IS_ERR_OR_NULL with IS_ERR on clk_get results. Signed-off-by: Tony Prisk li...@prisktech.co.nz Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 5/5] s5p-fimc: Prevent AB-BA deadlock during links reconfiguration

2013-01-03 Thread Sylwester Nawrocki
This patch patch eliminates potential AB-BA deadlock when one process calls open(), or VIDIOC_S/TRY_FMT ioctl on the FIMC capture video node, while other thread is reconfiguring media links via media device node: /dev/video? open()/dev/media? MEDIA_IOC_SETUP_LINK ioctl

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-03 Thread Federico Vaga
After all those discussions, I'm ok on adding this new driver, but please add a summary of those discussions at the patch description. As I said, the reason why this driver is needed is not obvious. So, it needs to be very well described. ack. I will ask more information to ST about the board

[PATCH v2 4/6] media: soc-camera: split struct soc_camera_link into host and subdevice parts

2013-01-03 Thread Guennadi Liakhovetski
struct soc_camera_link currently contains fields, used both by sensor and bridge drivers. To make subdevice driver re-use simpler, split it into a host and a subdevice parts. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: following an off-list discussion with Laurent,

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Jan 2013 16:18:26 +0100 Klaus Schmidinger klaus.schmidin...@tvdr.de escreveu: On 03.01.2013 14:20, Mauro Carvalho Chehab wrote: Em Wed, 2 Jan 2013 00:38:50 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Tue, Jan 1, 2013 at 10:59 PM, Mauro Carvalho Chehab

Re: [PATCH 133/493] remove use of __devexit_p

2013-01-03 Thread Arnd Bergmann
On Monday 19 November 2012, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. I've seen a few cases where __devexit was incorrectly paired with __exit_p(). Have you checked for those as well? It may be worth removing those at the same time.

Re: [PATCH 133/493] remove use of __devexit_p

2013-01-03 Thread Greg KH
On Thu, Jan 03, 2013 at 12:43:10PM +0100, Guennadi Liakhovetski wrote: Hi Bill On Mon, 19 Nov 2012, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Doesn't this also make the use of __refdata in many locations like this [snip]

[PATCH] dib0700: do not lock interruptible on tear-down paths

2013-01-03 Thread Jiri Slaby
When mutex_lock_interruptible is used on paths where a signal can be pending, the device is not closed properly and cannot be reused. This usually happens when you start tzap for example and send it a TERM signal. The signal is pending while tear-down routines are called. Hence streaming is not

[PATCH RFC v3 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-03 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de This patch adds a document describing common OF bindings for video capture, output and video processing devices. It is curently mainly focused on video capture devices, with data busses defined by standards like ITU-R BT.656 or MIPI-CSI2. It also

[PATCH RFC v3 02/15] [media] Add a V4L2 OF parser

2013-01-03 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com ---

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Thu, 3 Jan 2013 14:14:29 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 03 Jan 2013 16:18:26 +0100 Klaus Schmidinger klaus.schmidin...@tvdr.de escreveu: On 03.01.2013 14:20, Mauro Carvalho Chehab wrote: Em Wed, 2 Jan 2013 00:38:50 +0530 Manu Abraham

[GIT PULL] soc-camera take 1 for 3.9

2013-01-03 Thread Guennadi Liakhovetski
a different version;-) My branch is based on current next, because I needed patches, that went via other trees... And the patches: The following changes since commit 3696068e4e1231311b07e5c312876deec182f18b: Add linux-next specific files for 20130103 (2013-01-03 14:24:37 +1100) are available

Re: [PATCH V3 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2013-01-03 Thread Nicolas THERY
On 2012-12-16 22:51, Albert Wang wrote: [...] +static void mcam_clk_set(struct mcam_camera *mcam, int on) +{ + unsigned int i; + + if (on) { + for (i = 0; i mcam-clk_num; i++) { + if (mcam-clk[i]) + clk_enable(mcam-clk[i]); +

Re: [PATCH v2 2/5] em28xx: respect the message size constraints for i2c transfers

2013-01-03 Thread Frank Schäfer
Am 02.01.2013 23:21, schrieb Sascha Sommer: Hello Frank, Am Wed, 02 Jan 2013 22:25:10 +0100 schrieb Frank Schäfer fschaefer@googlemail.com: Hi Sascha, Am 02.01.2013 21:45, schrieb Sascha Sommer: Hello, Am Sat, 22 Dec 2012 22:07:46 -0200 schrieb Mauro Carvalho Chehab

Re: Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)

2013-01-03 Thread Frank Schäfer
Am 13.12.2012 21:43, schrieb Mauro Carvalho Chehab: Hi Frank, Em Thu, 13 Dec 2012 18:53:46 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Hi Mauro, could you please take a look at kernel bug 14126 (https://bugzilla.kernel.org/show_bug.cgi?id=14126) ? The bug reporter posted a

[PATCH v3 0/5] em28xx: i2c bug fixes and cleanups

2013-01-03 Thread Frank Schäfer
This patch series contains some I2C bug fixes / cleanups / unifications and improvements for the em28xx driver, which I've made while working on adding support for the em25xx/em276x i2c bus B support and playing with the Terratec Cinergy 200 USB which I've got recently. Patches 1, 2, 3, 5 fix

[PATCH v3 1/5] em28xx: respect the message size constraints for i2c transfers

2013-01-03 Thread Frank Schäfer
The em2800 can transfer up to 4 bytes per i2c message. All other em25xx/em27xx/28xx chips can transfer at least 64 bytes per message. I2C adapters should never split messages transferred via the I2C subsystem into multiple message transfers, because the result will almost always NOT be the same

[PATCH v3 2/5] em28xx: fix two severe bugs in function em2800_i2c_recv_bytes()

2013-01-03 Thread Frank Schäfer
Function em2800_i2c_recv_bytes() has 2 severe bugs: 1) It does not wait for the i2c read to complete before reading the received message content from the bridge registers. 2) Reading more than 1 byte doesn't work The former can result in data corruption, the latter always does. The rewritten

[PATCH v3 3/5] em28xx: fix the i2c adapter functionality flags

2013-01-03 Thread Frank Schäfer
I2C_FUNC_SMBUS_EMUL includes flag I2C_FUNC_SMBUS_WRITE_BLOCK_DATA which signals that up to 31 data bytes can be written to the ic2 client. But the EM2800 supports only i2c messages with max. 4 data bytes. I2C_FUNC_IC2 should be set if a master_xfer function pointer is provided in struct

[PATCH v3 4/5] em28xx: fix+improve+unify i2c error handling, debug messages and code comments

2013-01-03 Thread Frank Schäfer
- do not pass USB specific error codes to userspace/i2c-subsystem - unify the returned error codes and make them compliant with the i2c subsystem spec - check number of actually transferred bytes (via USB) everywehere - fix/improve debug messages - improve code comments Changelog: v2: removed

[PATCH v3 5/5] em28xx: consider the message length limitation of the i2c adapter when reading the eeprom

2013-01-03 Thread Frank Schäfer
EEPROMs are currently read in blocks of 16 bytes, but the em2800 is limited to 4 bytes per read. All other chip variants support reading of max. 64 bytes at once (according to the em258x datasheet; also verified with em2710, em2882, and em28174). Since em2800_i2c_recv_bytes() has been fixed to

[PATCH 1/3] sh_vou: Don't modify const variable in sh_vou_s_crop()

2013-01-03 Thread Laurent Pinchart
The crop rectangle is const, make a local copy instead of modifying it. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/sh_vou.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 3/3] sh_vou: Use vou_dev instead of vou_file wherever possible

2013-01-03 Thread Laurent Pinchart
This prepares for the removal of vou_file. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/sh_vou.c | 57 +- 1 files changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/media/platform/sh_vou.c

[PATCH 2/3] sh_vou: Use video_drvdata()

2013-01-03 Thread Laurent Pinchart
Replace video_devdata() followed by video_get_drvdata() calls with video_drvdata(). Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/media/platform/sh_vou.c | 57 ++ 1 files changed, 21 insertions(+), 36 deletions(-)

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Manu Abraham
Hi Antti, On Thu, Jan 3, 2013 at 9:04 PM, Antti Palosaari cr...@iki.fi wrote: On 01/01/2013 06:48 PM, Manu Abraham wrote: On Tue, Jan 1, 2013 at 8:30 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: [RFCv4] dvb: Add DVBv5 properties for quality parameters The DVBv3 quality parameters

RE: [PATCH V3 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2013-01-03 Thread Albert Wang
Hi, Nicolas Thank you for your reminder. :) Happy New Year! -Original Message- From: Nicolas THERY [mailto:nicolas.th...@st.com] Sent: Friday, 04 January, 2013 01:38 To: Albert Wang Cc: Jonathan Corbet; g.liakhovet...@gmx.de; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Fri, 4 Jan 2013 00:39:25 +0530 Manu Abraham abraham.m...@gmail.com escreveu: Hi Antti, On Thu, Jan 3, 2013 at 9:04 PM, Antti Palosaari cr...@iki.fi wrote: On 01/01/2013 06:48 PM, Manu Abraham wrote: On Tue, Jan 1, 2013 at 8:30 PM, Mauro Carvalho Chehab mche...@redhat.com wrote:

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Manu Abraham
On Fri, Jan 4, 2013 at 12:57 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Fri, 4 Jan 2013 00:39:25 +0530 Manu Abraham abraham.m...@gmail.com escreveu: Hi Antti, On Thu, Jan 3, 2013 at 9:04 PM, Antti Palosaari cr...@iki.fi wrote: On 01/01/2013 06:48 PM, Manu Abraham wrote: On

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Fri, 4 Jan 2013 01:02:02 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Fri, Jan 4, 2013 at 12:57 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Fri, 4 Jan 2013 00:39:25 +0530 Manu Abraham abraham.m...@gmail.com escreveu: Hi Antti, On Thu, Jan 3, 2013 at 9:04 PM,

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Manu Abraham
On Thu, Jan 3, 2013 at 6:50 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Wed, 2 Jan 2013 00:38:50 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Tue, Jan 1, 2013 at 10:59 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Tue, 1 Jan 2013 22:18:49 +0530 Manu Abraham

[PATCH] ts2020.c: ts2020_set_params [BUG] point to fe-tuner_priv.

2013-01-03 Thread Malcolm Priestley
Fixes corruption of fe-demodulator_priv Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/media/dvb-frontends/ts2020.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/ts2020.c b/drivers/media/dvb-frontends/ts2020.c index

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Antti Palosaari
On 01/03/2013 09:53 PM, Mauro Carvalho Chehab wrote: Em Fri, 4 Jan 2013 01:02:02 +0530 Manu Abraham abraham.m...@gmail.com escreveu: On Fri, Jan 4, 2013 at 12:57 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Fri, 4 Jan 2013 00:39:25 +0530 Manu Abraham abraham.m...@gmail.com escreveu:

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Manu Abraham
On Fri, Jan 4, 2013 at 2:09 AM, Antti Palosaari cr...@iki.fi wrote: Manu, here is manual of the professional ISDB-T signal analyzer. Look especially BER measurement picture from Slide 10. Sure, it looks so. Just wondering what the TDM stuffing would do after the hierarchial combiner. Manu --

[PATCH] omap3isp: Don't include plat/cpu.h

2013-01-03 Thread Laurent Pinchart
The plat/*.h headers are not available to drivers in multiplatform kernels. As the header isn't needed, just remove it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/omap3isp/isp.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff

Re: AverTV_A918R (af9035-af9033-tda18218) / patch proposal

2013-01-03 Thread Diorser
I don't know why you resists to remove antenna or unplug stick, but even you remove antenna I am quite sure you will see similar results. I've been simply confused by the signal reported at level most of the time, and the scanning working. I thought the problem was a step behind with

Re: Bug 14126 (em28xx, Terratec Cinergy 200/250 USB)

2013-01-03 Thread Remy Blank
Frank Schäfer wrote: Remy, your patch needs to be rebased against the linux-media tree. Is it ok for you when I create a new patch including the composite input fix and submit it ? Sure, please do. Thanks for taking the time to get this included. -- Remy signature.asc Description: OpenPGP

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Antti Palosaari
On 01/03/2013 06:29 PM, Mauro Carvalho Chehab wrote: Em Thu, 3 Jan 2013 14:14:29 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 03 Jan 2013 16:18:26 +0100 Klaus Schmidinger klaus.schmidin...@tvdr.de escreveu: On 03.01.2013 14:20, Mauro Carvalho Chehab wrote: Em Wed, 2 Jan

cron job: media_tree daily build: ERRORS

2013-01-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Jan 3 19:00:18 CET 2013 git hash:8cd7085ff460ead3aba6174052a408f4ad52ac36 gcc version: i686-linux-gcc

Re: AverTV_A918R (af9035-af9033-tda18218) / patch proposal

2013-01-03 Thread Antti Palosaari
On 01/03/2013 11:24 PM, Diorser wrote: I don't know why you resists to remove antenna or unplug stick, but even you remove antenna I am quite sure you will see similar results. I've been simply confused by the signal reported at level most of the time, and the scanning working. hmm,

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Mauro Carvalho Chehab
Em Thu, 03 Jan 2013 23:33:49 +0200 Antti Palosaari cr...@iki.fi escreveu: On 01/03/2013 06:29 PM, Mauro Carvalho Chehab wrote: Em Thu, 3 Jan 2013 14:14:29 -0200 Mauro Carvalho Chehab mche...@redhat.com escreveu: Em Thu, 03 Jan 2013 16:18:26 +0100 Klaus Schmidinger

Re: [PATCH] omap3isp: Don't include plat/cpu.h

2013-01-03 Thread Tony Lindgren
* Laurent Pinchart laurent.pinch...@ideasonboard.com [130103 13:24]: The plat/*.h headers are not available to drivers in multiplatform kernels. As the header isn't needed, just remove it. Please consider merging this for the -rc cycle, so I can make plat/cpu.h produce an error for omap2+ to

Re: [PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Vikas Sajjan
Hi Mr. Figa, Thanks for reviewing. On 3 January 2013 16:29, Tomasz Figa t.f...@samsung.com wrote: Hi Vikas, On Wednesday 02 of January 2013 18:47:22 Vikas C Sajjan wrote: From: Vikas Sajjan vikas.saj...@linaro.org Signed-off-by: Vikas Sajjan vikas.saj...@linaro.org ---

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread VDR User
On Thu, Jan 3, 2013 at 1:33 PM, Antti Palosaari cr...@iki.fi wrote: I would not like to define exact units for BER and USB as those are quite hard to implement and also non-sense. User would like just to see if there is some (random) numbers and if those numbers are rising or reducing when he

[PATCH v2] adv7343: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- Changes for v2: 1: Fixed comments pointed out by Laurent.

[PATCH v2] tvp514x: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- Changes for v2: 1: Fixed comments pointed out by Laurent.

[PATCH v2] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- Changes for v2: 1: Fixed comments pointed out by Laurent.

Re: [linux-media] Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2013-01-03 Thread Manu Abraham
On Fri, Jan 4, 2013 at 10:33 AM, VDR User user@gmail.com wrote: On Thu, Jan 3, 2013 at 1:33 PM, Antti Palosaari cr...@iki.fi wrote: I would not like to define exact units for BER and USB as those are quite hard to implement and also non-sense. User would like just to see if there is some

RE: [PATCH V3 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2013-01-03 Thread Libin Yang
Hi Guennadi, Thanks for your review. Please see my comments below. -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, January 02, 2013 12:06 AM To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH V3

Re: [PATCH v2] adv7343: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patches. For the whole set, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com On Friday 04 January 2013 10:41:15 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths.