Hi Guennadi,
Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, January 02, 2013 12:56 AM
To: Albert Wang
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: Re: [PATCH V3 06/15] [media]
Hi Libin
On Thu, 3 Jan 2013, Libin Yang wrote:
Hi Guennadi,
Thanks for your review. Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, January 02, 2013 12:06 AM
To: Albert Wang
Cc: cor...@lwn.net;
Hi Guennadi,
On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
Hi Prabhakar
On Wed, 2 Jan 2013, Prabhakar Lad wrote:
Hi,
This is my first step towards DT support for media, Question might be
bit amateur :)
No worries, we're all doing our first steps in
On Fri, 4 Jan 2013, Prabhakar Lad wrote:
Hi Guennadi,
On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
Hi Prabhakar
On Wed, 2 Jan 2013, Prabhakar Lad wrote:
Hi,
This is my first step towards DT support for media, Question might be
bit amateur
On Thursday 03 January 2013 17:13:14 Federico Vaga wrote:
After all those discussions, I'm ok on adding this new driver, but please
add a summary of those discussions at the patch description. As I said,
the reason why this driver is needed is not obvious. So, it needs to be
very well
On Tue, Jan 1, 2013 at 10:39 AM, Antti Palosaari cr...@iki.fi wrote:
On 12/17/2012 03:12 AM, Michael Krufky wrote:
display an error message if either tuner_i2c_addr or demod_i2c_addr
are not specified in the tda10071_config structure
Nack.
I don't see it necessary at all to check
On 01/04/2013 03:33 PM, Michael Krufky wrote:
On Tue, Jan 1, 2013 at 10:39 AM, Antti Palosaari cr...@iki.fi wrote:
On 12/17/2012 03:12 AM, Michael Krufky wrote:
display an error message if either tuner_i2c_addr or demod_i2c_addr
are not specified in the tda10071_config structure
Nack.
I
I would like to discuss if there is idea to validate subdriver
parameters explicitly at run-time when subdriver module is load.
There is configuration parameters for about every driver like:
* I2C address
* clock frequency
Nowadays, when main driver loads subdriver, it passes those static
The following changes since commit 16427faf28674451a7a0485ab0a929402f355ffd:
[media] tm6000: Add parameter to keep urb bufs allocated (2012-12-04
14:54:21 -0200)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git af9035
for you to fetch changes up to
On Fri, Jan 4, 2013 at 9:02 AM, Antti Palosaari cr...@iki.fi wrote:
I would like to discuss if there is idea to validate subdriver parameters
explicitly at run-time when subdriver module is load.
There is configuration parameters for about every driver like:
* I2C address
* clock frequency
replace:
#if defined(CONFIG_RC_CORE) || defined(CONFIG_RC_CORE_MODULE)
with:
#if IS_ENABLED(CONFIG_RC_CORE)
Reported-by: Fabio Estevam feste...@gmail.com
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/af9015.c | 2 +-
drivers/media/usb/dvb-usb-v2/af9035.c
Hi Mauro,
Please pull for 3.8-rc. This includes the vb2 data_offset fix from
Laurent, which looked fine after I reviewed it more carefully, and
Exynos SoC/m5mols driver bug fixes.
The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed:
Linux 3.8-rc2 (2013-01-02 18:13:21
We recently pushed the locking down into this function, but there was
an error path where the unlock was missed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Only needed in linux-next.
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-core/dvb_ca_en50221.c
Hi Mauro,
Please pull the following for 3.9, it includes Exynos SoC drivers cleanups and
fixes. DMABUF exporting support for Exynos5 GScaler driver, device tree support
for Exynos MFC driver (platform bits for it got merged already for v3.8).
There is also included a patch removing deprecated
The following changes since commit 16427faf28674451a7a0485ab0a929402f355ffd:
[media] tm6000: Add parameter to keep urb bufs allocated (2012-12-04
14:54:21 -0200)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git dvb_usb_v2_rc-pull
for you to fetch changes
Hello Mauro,
Please pull the following series for 3.9, which ports em28xx to VB2 as
well as applying Hans Verkuil's v4l2-compliance fixes for em28xx.
Thanks,
Devin
The following changes since commit 8cd7085ff460ead3aba6174052a408f4ad52ac36:
[media] get_dvb_firmware: Fix the location of
On Fri, Jan 4, 2013 at 4:41 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
[snip]
are available in the git repository at:
git://git.kernellabs.com/dheitmueller/linuxtv.git v39staging
for you to fetch changes up to 381abfc158c2dad81a558a3d3ff924fc7f80d277:
em28xx: convert to
On 23 December 2012 00:42, Mauro Carvalho Chehab mche...@redhat.com wrote:
Em Sat, 22 Dec 2012 22:25:24 +0100
Roland Scheidegger rscheidegger_li...@hispeed.ch escreveu:
Am 21.12.2012 06:38, schrieb linux-media-ow...@vger.kernel.org:
Hi,
I've recently got a terratec h5 for dvb-c and
Laurent Pinchart laurent.pinch...@ideasonboard.com escreveu:
On Monday 17 December 2012 18:12:19 William Swanson wrote:
If the remote video sensor reports an interlaced video mode, the CCDC block
should configure itself appropriately.
What will the CCDC do in that case ? Will it capture
On Fri, Jan 4, 2013 at 2:59 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
Maybe I'm wrong, but weren't **all** changes supposed to be sent as a PATCH
to the mailing list for community review, before the PULL request was sent?
No, you are correct. I did a PULL specifically because Mauro
This patch series converts the em28xx driver to videobuf2 and fixes
a number of issues found with v4l2-compliance on em28xx.
Devin Heitmueller (1):
em28xx: convert to videobuf2
Hans Verkuil (14):
em28xx: fix querycap.
em28xx: remove bogus input/audio ioctls for the radio device.
em28xx:
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c | 42 ++-
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git
Radio devices should not implement those ioctls.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c | 35 ---
1 file changed, 35 deletions(-)
diff --git
v4l2-compliance found problems with frequency clamping that wasn't
reported correctly and missing tuner index checks.
Also removed unnecessary tuner type checks (these are now done by the
v4l2 core).
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 24 +++
drivers/media/usb/em28xx/em28xx-video.c | 248 +++
drivers/media/usb/em28xx/em28xx.h |6 +
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c |5 +
drivers/media/usb/em28xx/em28xx.h |2 ++
2 files changed, 7 insertions(+)
diff --git
TRY_FMT should not return an error if a pixelformat is unsupported. Instead just
pick a common pixelformat.
Also the bytesperline calculation was incorrect: it used the old width instead
of
the provided with, and it miscalculated the bytesperline value for the depth ==
12
case.
Signed-off-by:
When in webcam mode the STD API shouldn't be implemented.
When changing the standard the resolution wasn't updated, and there was no
check against streaming-in-progress.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
The sliced VBI support in the tvp5150 is completely broken. And there is no
support for the saa7115 sliced VBI implementation in the em28xx driver. So
we remove the sliced VBI support completely.
It should be possible to get it to work with the tvp5150, but that will
require someone to really dig
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
No longer needed now that em28xx has been converted to the control framework.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/i2c/tvp5150.c |7 ---
1 file changed, 7 deletions(-)
diff --git
This patch converts the em28xx driver over to videobuf2. It is
likely that em28xx_fh can go away entirely, but that will come in
a separate patch.
[mche...@redhat.com: fix a non-trivial merge conflict with some VBI
patches]
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
Sometimes platform/bridge drivers need to be notified when a control from
a sub-device changes value. In order to support this a notify callback was
added.
djh - fix merge conflict in v4l2-ctrls.c
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c | 38 +--
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git
g/s_parm should fill in readbuffers.
For non-webcams s_parm should return -ENOTTY instead of -EINVAL.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
---
drivers/media/usb/em28xx/em28xx-video.c |4 +++-
1 file changed, 3
On Fri, Jan 4, 2013 at 3:59 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
This patch series converts the em28xx driver to videobuf2 and fixes
a number of issues found with v4l2-compliance on em28xx.
There was a typo on my part. It's VB2 (videobuf2), not VBI2.
Devin
--
Devin J.
Em Fri, 28 Dec 2012 00:02:45 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Tested with device Terratec Cinergy 200 USB.
Sorry, but this patch is completely wrong ;)
The fix here is simple: just move the initialization to happen
earlier.
I'm posting it right now, together with a
If the device has an I2C IR, em28xx-rc should be loaded by default,
except if the user explicitly requested to not load, via modprobe
option.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The em28xx-input is used by 3 different types of input devices:
- devices with buttons (like cameras and grabber devices);
- devices with I2C remotes;
- em2860 or latter chips with RC support embedded.
When the device has an I2C remote, all it needs to do is to call
the
The ir-i2c-kbd already adds I2C IR before the name. The way it is,
the devices are named as:
i2c IR (i2c IR (EM2840 Hauppaug
With is ugly and incorrect. After this patch, it is now properly
displayed as:
i2c IR (WinTV USB2)
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
Frank pointed that IR was not working with I2C devices. So, I took some
time to fix them.
Tested with Hauppauge WinTV USB2.
Mauro Carvalho Chehab (4):
[media] em28xx: initialize button/I2C IR earlier
[media] em28xx: autoload em28xx-rc if the device has an I2C IR
[media] em28xx: simplify IR
On 01/03/2013 04:16 PM, Alexander Inyukhin wrote:
Device with ID 1b80:d393 is the Gigabyte U7300 DVB-T dongle.
It contains decoder Realtek RTL2832U and tuner Fitipower FC0012.
Signed-off-by: Alexander Inyukhin shur...@sectorb.msk.ru
Applied thanks!
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Fri Jan 4 19:00:16 CET 2013
git hash:8cd7085ff460ead3aba6174052a408f4ad52ac36
gcc version: i686-linux-gcc
The following changes since commit 8cd7085ff460ead3aba6174052a408f4ad52ac36:
[media] get_dvb_firmware: Fix the location of firmware for Terratec
HTC (2013-01-01 11:18:26 -0200)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git rtl28xxu-usb-ids
for you to
On 01/04/2013 07:52 PM, Sylwester Nawrocki wrote:
Hi Mauro,
Please pull for 3.8-rc. This includes the vb2 data_offset fix from
Laurent, which looked fine after I reviewed it more carefully, and
Exynos SoC/m5mols driver bug fixes.
The following changes since commit
On 01/04/2013 08:01 PM, Sylwester Nawrocki wrote:
Hi Mauro,
Please pull the following for 3.9, it includes Exynos SoC drivers cleanups and
fixes. DMABUF exporting support for Exynos5 GScaler driver, device tree support
for Exynos MFC driver (platform bits for it got merged already for v3.8).
Hi Laurent,
Thanks for the patch.
On Mon, Dec 17, 2012 at 09:52:48AM +0100, Laurent Pinchart wrote:
drivers/media/platform/omap3isp/ispqueue.c:399:18: warning: 'pa' may be
used uninitialized in this function [-Wuninitialized]
This is a false positive but the compiler has no way to know
Hi,
Nice patches --- thanks!!
On Mon, Dec 31, 2012 at 05:29:54PM +0100, Laurent Pinchart wrote:
kzalloc initializes the memory it allocates to 0, there's no need for an
explicit memset.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Sakari Ailus
On Thu, Jan 03, 2013 at 10:23:24PM +0100, Laurent Pinchart wrote:
The plat/*.h headers are not available to drivers in multiplatform
kernels. As the header isn't needed, just remove it.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Sakari Ailus
Add common header file defining standard image sizes, so we can
avoid redefining those in each driver.
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
include/media/image-sizes.h | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
These patches add driver for OV9650/52 image sensor. The first one
introduces a header file containing definitions of standard image
resolutions. I have also prepared a few patches reworking existing
drivers to use this global definitions, but I thought I'll submit
those only after the header is
This patch adds V4L2 sub-device driver for OV9650/OV9652
image sensors.
The driver exposes following V4L2 controls:
- auto/manual exposure, auto exposure reference area,
- auto/manual white balance,
- auto/manual gain, auto gain ceiling,
- brightness, saturation, sharpness,
- horizontal/vertical
If the remote video sensor reports an interlaced video mode, the CCDC block
should configure itself appropriately.
This patch reintroduces code with was removed in commit
cf7a3d91ade6c56bfd860b377f84bd58132f7a81, but in a way that is compatible
with the new media pipeline work.
Signed-off-by:
Em Fri, 28 Dec 2012 00:02:46 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Module ir-kbd-i2c already provides this function as IR_KBD_GET_KEY_KNC1.
See my comment for patch 6/6.
Regards,
Mauro
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
Hans/Devin,
Em Fri, 4 Jan 2013 15:59:40 -0500
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
TRY_FMT should not return an error if a pixelformat is unsupported. Instead
just
pick a common pixelformat.
Also the bytesperline calculation was incorrect: it used the old width
Hi Guennadi,
Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Friday, January 04, 2013 6:25 PM
To: Libin Yang
Cc: Albert Wang; cor...@lwn.net; linux-media@vger.kernel.org
Subject: RE: [PATCH V3 03/15] [media] marvell-ccic:
Em Fri, 28 Dec 2012 00:02:48 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
- return valid key code when button is hold
- debug: print key code only when a button is pressed
Tested with device Terratec Cinergy 200 USB (em28xx).
Signed-off-by: Frank Schäfer
That fixes the following warning:
drivers/media/usb/em28xx/em28xx-video.c:611:5: warning: no previous
prototype for 'em28xx_stop_streaming' [-Wmissing-prototypes]
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/usb/em28xx/em28xx-video.c | 2 +-
1 file changed,
The above commit were applied only partially; it broke tuner and
demod attach, but the part that added it to ngene_info was missing.
Not sure what happened there, but, without this patch, a regression
would be happening.
Also, gcc complains about a defined but not used symbol.
So, apply
60 matches
Mail list logo
