[PATCH] [media] davinci: vpfe: remove deprecated IRQF_DISABLED
This patch proposes to remove the use of the IRQF_DISABLED flag
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
index d8ce20d..cda8388c 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
@@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
{
int ret = 0;
- ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
"vpfe_capture0", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
return ret;
}
- ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
+ ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
"vpfe_capture1", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
@@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
}
ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
- IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
+ 0, "Imp_Sdram_Irq", vpfe_dev);
if (ret < 0) {
v4l2_err(&vpfe_dev->v4l2_dev,
"Error: requesting IMP IRQ interrupt\n");
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: WARNINGS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Oct 6 04:05:49 CEST 2013 git branch: test git hash: d10e8280c4c2513d3e7350c27d8e6f0fa03a5f71 gcc version:i686-linux-gcc (GCC) 4.8.1 sparse version: 0.4.5-rc1 host hardware: x86_64 host os:3.10.1 linux-git-arm-at91: OK linux-git-arm-davinci: OK linux-git-arm-exynos: OK linux-git-arm-mx: OK linux-git-arm-omap: OK linux-git-arm-omap1: OK linux-git-arm-pxa: OK linux-git-blackfin: OK linux-git-i686: OK linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-sh: OK linux-git-x86_64: OK linux-2.6.31.14-i686: OK linux-2.6.32.27-i686: OK linux-2.6.33.7-i686: OK linux-2.6.34.7-i686: OK linux-2.6.35.9-i686: OK linux-2.6.36.4-i686: OK linux-2.6.37.6-i686: OK linux-2.6.38.8-i686: OK linux-2.6.39.4-i686: OK linux-3.0.60-i686: OK linux-3.1.10-i686: OK linux-3.2.37-i686: OK linux-3.3.8-i686: OK linux-3.4.27-i686: OK linux-3.5.7-i686: OK linux-3.6.11-i686: OK linux-3.7.4-i686: OK linux-3.8-i686: OK linux-3.9.2-i686: OK linux-3.10.1-i686: OK linux-3.11.1-i686: OK linux-3.12-rc1-i686: OK linux-2.6.31.14-x86_64: OK linux-2.6.32.27-x86_64: OK linux-2.6.33.7-x86_64: OK linux-2.6.34.7-x86_64: OK linux-2.6.35.9-x86_64: OK linux-2.6.36.4-x86_64: OK linux-2.6.37.6-x86_64: OK linux-2.6.38.8-x86_64: OK linux-2.6.39.4-x86_64: OK linux-3.0.60-x86_64: OK linux-3.1.10-x86_64: OK linux-3.2.37-x86_64: OK linux-3.3.8-x86_64: OK linux-3.4.27-x86_64: OK linux-3.5.7-x86_64: OK linux-3.6.11-x86_64: OK linux-3.7.4-x86_64: OK linux-3.8-x86_64: OK linux-3.9.2-x86_64: OK linux-3.10.1-x86_64: OK linux-3.11.1-x86_64: OK linux-3.12-rc1-x86_64: OK apps: WARNINGS spec-git: OK sparse version: 0.4.5-rc1 sparse: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi
On 10/06/13 09:09, Kukjin Kim wrote: On 10/02/13 00:26, Kishon Vijay Abraham I wrote: On Wednesday 02 October 2013 02:43 AM, Sylwester Nawrocki wrote: On 10/01/2013 07:28 AM, Kishon Vijay Abraham I wrote: On Sunday 29 September 2013 12:57 AM, Sylwester Nawrocki wrote: Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Can this patch be taken through exynos dt tree? Yes, that makes more sense indeed. Kukjin, would you mind taking this patch to your tree ? Sure. Applied this whole series. Oops, sorry. Only this patch ;-) FWIW Acked-by: Kishon Vijay Abraham I Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi
On 10/02/13 00:26, Kishon Vijay Abraham I wrote: On Wednesday 02 October 2013 02:43 AM, Sylwester Nawrocki wrote: On 10/01/2013 07:28 AM, Kishon Vijay Abraham I wrote: On Sunday 29 September 2013 12:57 AM, Sylwester Nawrocki wrote: Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Can this patch be taken through exynos dt tree? Yes, that makes more sense indeed. Kukjin, would you mind taking this patch to your tree ? Sure. Applied this whole series. FWIW Acked-by: Kishon Vijay Abraham I Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] v4l: omap4iss: Add support for OMAP4 camera interface - Core
Hi Laurent,
Thanks for the patch! Some comments below.
On Thu, Oct 03, 2013 at 01:55:28AM +0200, Laurent Pinchart wrote:
...
> +int omap4iss_get_external_info(struct iss_pipeline *pipe,
> +struct media_link *link)
> +{
> + struct iss_device *iss =
> + container_of(pipe, struct iss_video, pipe)->iss;
> + struct v4l2_subdev_format fmt;
> + struct v4l2_ext_controls ctrls;
> + struct v4l2_ext_control ctrl;
> + int ret;
> +
> + if (!pipe->external)
> + return 0;
> +
> + if (pipe->external_rate)
> + return 0;
> +
> + memset(&fmt, 0, sizeof(fmt));
> +
> + fmt.pad = link->source->index;
> + fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
> + ret = v4l2_subdev_call(media_entity_to_v4l2_subdev(link->sink->entity),
> +pad, get_fmt, NULL, &fmt);
> + if (ret < 0)
> + return -EPIPE;
> +
> + pipe->external_bpp = omap4iss_video_format_info(fmt.format.code)->bpp;
> +
> + memset(&ctrls, 0, sizeof(ctrls));
> + memset(&ctrl, 0, sizeof(ctrl));
> +
As a general note, you can replace memsets of local structs and arrays by
assingning them as {0}. No need to worry about size for instance.
> + ctrl.id = V4L2_CID_PIXEL_RATE;
> +
> + ctrls.ctrl_class = V4L2_CTRL_ID2CLASS(ctrl.id);
> + ctrls.count = 1;
> + ctrls.controls = &ctrl;
> +
> + ret = v4l2_g_ext_ctrls(pipe->external->ctrl_handler, &ctrls);
> + if (ret < 0) {
> + dev_warn(iss->dev, "no pixel rate control in subdev %s\n",
> + pipe->external->name);
> + return ret;
> + }
> +
> + pipe->external_rate = ctrl.value64;
> +
> + return 0;
> +}
> +
> +/*
> + * Configure the bridge. Valid inputs are
> + *
> + * IPIPEIF_INPUT_CSI2A: CSI2a receiver
> + * IPIPEIF_INPUT_CSI2B: CSI2b receiver
> + *
> + * The bridge and lane shifter are configured according to the selected input
> + * and the ISP platform data.
> + */
> +void omap4iss_configure_bridge(struct iss_device *iss,
> +enum ipipeif_input_entity input)
> +{
> + u32 issctrl_val;
> + u32 isp5ctrl_val;
> +
> + issctrl_val = readl(iss->regs[OMAP4_ISS_MEM_TOP] + ISS_CTRL);
> + issctrl_val &= ~ISS_CTRL_INPUT_SEL_MASK;
> + issctrl_val &= ~ISS_CTRL_CLK_DIV_MASK;
> +
> + isp5ctrl_val = readl(iss->regs[OMAP4_ISS_MEM_ISP_SYS1] + ISP5_CTRL);
> +
> + switch (input) {
> + case IPIPEIF_INPUT_CSI2A:
> + issctrl_val |= ISS_CTRL_INPUT_SEL_CSI2A;
> + isp5ctrl_val |= ISP5_CTRL_VD_PULSE_EXT;
> + break;
> +
> + case IPIPEIF_INPUT_CSI2B:
> + issctrl_val |= ISS_CTRL_INPUT_SEL_CSI2B;
> + isp5ctrl_val |= ISP5_CTRL_VD_PULSE_EXT;
This assignment is independent of the case. You could do that a little later
just once.
> + break;
> +
> + default:
> + return;
Isn't this an error?
> + }
> +
> + issctrl_val |= ISS_CTRL_SYNC_DETECT_VS_RAISING;
> +
> + isp5ctrl_val |= ISP5_CTRL_PSYNC_CLK_SEL | ISP5_CTRL_SYNC_ENABLE;
> +
> + writel(issctrl_val, iss->regs[OMAP4_ISS_MEM_TOP] + ISS_CTRL);
> + writel(isp5ctrl_val, iss->regs[OMAP4_ISS_MEM_ISP_SYS1] + ISP5_CTRL);
> +}
...
> +
> +/*
> + * iss_pipeline_enable - Enable streaming on a pipeline
> + * @pipe: ISS pipeline
> + * @mode: Stream mode (single shot or continuous)
> + *
> + * Walk the entities chain starting at the pipeline output video node and
> start
> + * all modules in the chain in the given mode.
> + *
> + * Return 0 if successful, or the return value of the failed video::s_stream
> + * operation otherwise.
> + */
> +static int iss_pipeline_enable(struct iss_pipeline *pipe,
> +enum iss_pipeline_stream_state mode)
> +{
> + struct media_entity *entity;
> + struct media_pad *pad;
> + struct v4l2_subdev *subdev;
> + unsigned long flags;
> + int ret;
> +
> + spin_lock_irqsave(&pipe->lock, flags);
> + pipe->state &= ~(ISS_PIPELINE_IDLE_INPUT | ISS_PIPELINE_IDLE_OUTPUT);
> + spin_unlock_irqrestore(&pipe->lock, flags);
> +
> + pipe->do_propagation = false;
> +
> + entity = &pipe->output->video.entity;
> + while (1) {
> + pad = &entity->pads[0];
> + if (!(pad->flags & MEDIA_PAD_FL_SINK))
> + break;
> +
> + pad = media_entity_remote_pad(pad);
> + if (pad == NULL ||
> + media_entity_type(pad->entity) != MEDIA_ENT_T_V4L2_SUBDEV)
> + break;
> +
> + entity = pad->entity;
> + subdev = media_entity_to_v4l2_subdev(entity);
> +
> + ret = v4l2_subdev_call(subdev, video, s_stream, mode);
> + if (ret < 0 && ret != -ENOIOCTLCMD)
> + return ret;
This loop looks very similar to that in the omap3isp driver.
It'd be nice to do this in a generic way. Something to think about in the
future pe
You've won a Prize
You've won a Prize MICROSOFT IBERICA SL" YOU 'VE WON. ATTN:MICROSOFT IBERICA SL Your email has won (EUR244,000,00) (TWO HUNDRED AND FOURTY FOUR THOUSAND EURO) Batch number:XL73276498AM Ref number:QR352899526KC This is a millennium scientific computer game in which email addresses were used.It is a promotional program aimed at encouraging internet users,therefore you do not need to buy ticket to enter for it. For further development,clarification and procedure please Contact:Dr Eduardo Sanchez, Email contact:payingroll...@yahoo.com.hk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ivtv 1.4.2/1.4.3 broken in recent kernels?
Have been using with ivtv-1.4.0 with kernel 2.6.35 (gentoo) for the past 1 week and daughter card (audio/video) is working well. Also tried Suse-12.3 with kernel 3.7.10, and daughter card gives unusable audio. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 19/26] ivtv: Convert driver to use get_user_pages_unlocked()
Hi Jan:
This patch alone does not have suffcient information for me to evaluate
it. get_user_pages_unlocked() is added in another patch which I did not
receive, and which I cannot find in any list archives.
I wasted quite a bit of time looking for this additional patch:
https://git.kernel.org/cgit/linux/kernel/git/jack/linux-fs.git/commit/?h=get_user_pages&id=624fc1bfb70fb65d32d31fbd16427ad9c234653e
If I found the correct patch for adding get_user_pages_unlocked(), then
the patch below looks fine.
Reviewed-by: Andy Walls
Acked-by: Andy Walls
Regards,
Andy
On Wed, 2013-10-02 at 16:28 +0200, Jan Kara wrote:
> CC: Andy Walls
> CC: linux-media@vger.kernel.org
> Signed-off-by: Jan Kara
> ---
> drivers/media/pci/ivtv/ivtv-udma.c | 6 ++
> drivers/media/pci/ivtv/ivtv-yuv.c | 12 ++--
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/pci/ivtv/ivtv-udma.c
> b/drivers/media/pci/ivtv/ivtv-udma.c
> index 7338cb2d0a38..6012e5049076 100644
> --- a/drivers/media/pci/ivtv/ivtv-udma.c
> +++ b/drivers/media/pci/ivtv/ivtv-udma.c
> @@ -124,10 +124,8 @@ int ivtv_udma_setup(struct ivtv *itv, unsigned long
> ivtv_dest_addr,
> }
>
> /* Get user pages for DMA Xfer */
> - down_read(¤t->mm->mmap_sem);
> - err = get_user_pages(current, current->mm,
> - user_dma.uaddr, user_dma.page_count, 0, 1, dma->map,
> NULL);
> - up_read(¤t->mm->mmap_sem);
> + err = get_user_pages_unlocked(current, current->mm, user_dma.uaddr,
> + user_dma.page_count, 0, 1, dma->map);
>
> if (user_dma.page_count != err) {
> IVTV_DEBUG_WARN("failed to map user pages, returned %d instead
> of %d\n",
> diff --git a/drivers/media/pci/ivtv/ivtv-yuv.c
> b/drivers/media/pci/ivtv/ivtv-yuv.c
> index 2ad65eb29832..9365995917d8 100644
> --- a/drivers/media/pci/ivtv/ivtv-yuv.c
> +++ b/drivers/media/pci/ivtv/ivtv-yuv.c
> @@ -75,15 +75,15 @@ static int ivtv_yuv_prep_user_dma(struct ivtv *itv,
> struct ivtv_user_dma *dma,
> ivtv_udma_get_page_info (&uv_dma, (unsigned long)args->uv_source, 360 *
> uv_decode_height);
>
> /* Get user pages for DMA Xfer */
> - down_read(¤t->mm->mmap_sem);
> - y_pages = get_user_pages(current, current->mm, y_dma.uaddr,
> y_dma.page_count, 0, 1, &dma->map[0], NULL);
> + y_pages = get_user_pages_unlocked(current, current->mm, y_dma.uaddr,
> + y_dma.page_count, 0, 1, &dma->map[0]);
> uv_pages = 0; /* silence gcc. value is set and consumed only if: */
> if (y_pages == y_dma.page_count) {
> - uv_pages = get_user_pages(current, current->mm,
> - uv_dma.uaddr, uv_dma.page_count, 0, 1,
> - &dma->map[y_pages], NULL);
> + uv_pages = get_user_pages_unlocked(current, current->mm,
> +uv_dma.uaddr,
> +uv_dma.page_count, 0, 1,
> +&dma->map[y_pages]);
> }
> - up_read(¤t->mm->mmap_sem);
>
> if (y_pages != y_dma.page_count || uv_pages != uv_dma.page_count) {
> int rc = -EFAULT;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Dear E-mail Owner
Greetings, How are you and the family? My contacting you again is based on neglecting my previous email of investment establishment in your country. Be aware that I am in a desire of any investments establishment that will guaranty a safe and secured profitable returns in terms of energy renewals, transportation, agriculture, aviation, oil and gas, real estates, hotel resorts, casinos etc. Or any other business or investment interest of your choice that you believe will be encouraging enough for us to established in your home town and I will be very ready to cooperate and partner with you. Please contact me through this e-mail address (dr.dar@gmail.com) to enable me give you more details about the investment establishment plans and how much is the total amount that I am intending to invest in your country. Say me well to the family as I wait to read from you soon.for more details. Regards. Dr.Dar Rot -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[em28xx] WinTV HVR 900 (R2), bus freeze on sound access
Hi, accessing the capture device provided by em28xx_alsa causes a full USB freeze (keyboard/mouse are dead) with kernel 3.11.2. Video is working perfectly but no audio whatsoever (tried with arecord and sox), although there is a capture card listed by arecord -l. Is Hauppauge model 65018 (kern.log of device initialization attached) not supported any longer? Thanks in advance, Dieter syslog Description: Binary data
